eslint-plugin-n 15.2.2 → 15.2.5

package/lib/rules/exports-style.js

@@ -244,6 +244,14 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        messages: {
+            unexpectedExports:
+                "Unexpected access to 'exports'. Use 'module.exports' instead.",
+            unexpectedModuleExports:
+                "Unexpected access to 'module.exports'. Use 'exports' instead.",
+            unexpectedAssignment:
+                "Unexpected assignment to 'exports'. Don't modify 'exports' itself.",
+        },
     },
 
     create(context) {
@@ -299,8 +307,7 @@ module.exports = {
                 context.report({
                     node,
                     loc: getLocation(node),
-                    message:
-                        "Unexpected access to 'exports'. Use 'module.exports' instead.",
+                    messageId: "unexpectedExports",
                 })
             }
         }
@@ -335,8 +342,7 @@ module.exports = {
                 context.report({
                     node,
                     loc: getLocation(node),
-                    message:
-                        "Unexpected access to 'module.exports'. Use 'exports' instead.",
+                    messageId: "unexpectedModuleExports",
                     fix(fixer) {
                         return fixModuleExports(node, sourceCode, fixer)
                     },
@@ -359,8 +365,7 @@ module.exports = {
                 context.report({
                     node,
                     loc: getLocation(node),
-                    message:
-                        "Unexpected assignment to 'exports'. Don't modify 'exports' itself.",
+                    messageId: "unexpectedAssignment",
                 })
             }
         }

package/lib/rules/no-callback-literal.js

@@ -16,6 +16,9 @@ module.exports = {
         type: "problem",
         fixable: null,
         schema: [],
+        messages: {
+            unexpectedLiteral: "Unexpected literal in error position of callback."
+        }
     },
 
     create(context) {
@@ -37,8 +40,7 @@ module.exports = {
                 ) {
                     context.report({
                         node,
-                        message:
-                            "Unexpected literal in error position of callback.",
+                        messageId: "unexpectedLiteral",
                     })
                 }
             },

package/lib/rules/no-deprecated-api.js

@@ -719,6 +719,9 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        messages: {
+            "deprecated": "{{name}} was deprecated since v{{version}}{{replace}}."
+        }
     },
     create(context) {
         const { ignoredModuleItems, ignoredGlobalItems, version } =
@@ -736,8 +739,7 @@ module.exports = {
             context.report({
                 node,
                 loc: node.loc,
-                message:
-                    "{{name}} was deprecated since v{{version}}{{replace}}.",
+                messageId: "deprecated",
                 data: {
                     name,
                     version: info.since,

package/lib/rules/no-extraneous-import.js

@@ -4,7 +4,7 @@
  */
 "use strict"
 
-const checkExtraneous = require("../util/check-extraneous")
+const { checkExtraneous, messages } = require("../util/check-extraneous")
 const getAllowModules = require("../util/get-allow-modules")
 const getConvertPath = require("../util/get-convert-path")
 const getResolvePaths = require("../util/get-resolve-paths")
@@ -32,6 +32,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        messages,
     },
     create(context) {
         const filePath = context.getFilename()

package/lib/rules/no-extraneous-require.js

@@ -4,7 +4,7 @@
  */
 "use strict"
 
-const checkExtraneous = require("../util/check-extraneous")
+const { checkExtraneous, messages } = require("../util/check-extraneous")
 const getAllowModules = require("../util/get-allow-modules")
 const getConvertPath = require("../util/get-convert-path")
 const getResolvePaths = require("../util/get-resolve-paths")
@@ -34,6 +34,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        messages,
     },
     create(context) {
         const filePath = context.getFilename()

package/lib/rules/no-hide-core-modules.js

@@ -80,6 +80,9 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        messages: {
+            "unexpectedImport": "Unexpected import of third-party module '{{name}}'.",
+        }
     },
     create(context) {
         if (context.getFilename() === "<input>") {
@@ -149,8 +152,7 @@ module.exports = {
                         context.report({
                             node: target.node,
                             loc: target.node.loc,
-                            message:
-                                "Unexpected import of third-party module '{{name}}'.",
+                            messageId: "unexpectedImport",
                             data: {
                                 name: path
                                     .relative(dirPath, resolved)

package/lib/rules/no-missing-import.js

@@ -4,7 +4,7 @@
  */
 "use strict"
 
-const checkExistence = require("../util/check-existence")
+const { checkExistence, messages } = require("../util/check-existence")
 const getAllowModules = require("../util/get-allow-modules")
 const getResolvePaths = require("../util/get-resolve-paths")
 const visitImport = require("../util/visit-import")
@@ -30,6 +30,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        messages,
     },
     create(context) {
         const filePath = context.getFilename()

package/lib/rules/no-missing-require.js

@@ -4,7 +4,7 @@
  */
 "use strict"
 
-const checkExistence = require("../util/check-existence")
+const { checkExistence, messages } = require("../util/check-existence")
 const getAllowModules = require("../util/get-allow-modules")
 const getResolvePaths = require("../util/get-resolve-paths")
 const getTryExtensions = require("../util/get-try-extensions")
@@ -32,6 +32,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        messages,
     },
     create(context) {
         const filePath = context.getFilename()

package/lib/rules/no-restricted-import.js

@@ -4,7 +4,7 @@
  */
 "use strict"
 
-const check = require("../util/check-restricted")
+const { checkForRestriction, messages } = require("../util/check-restricted")
 const visit = require("../util/visit-import")
 
 module.exports = {
@@ -47,14 +47,13 @@ module.exports = {
                 additionalItems: false,
             },
         ],
-        messages: {
-            restricted:
-                "'{{name}}' module is restricted from being used.{{customMessage}}",
-        },
+        messages,
     },
 
     create(context) {
         const opts = { includeCore: true }
-        return visit(context, opts, targets => check(context, targets))
+        return visit(context, opts, targets =>
+            checkForRestriction(context, targets)
+        )
     },
 }

package/lib/rules/no-restricted-require.js

@@ -5,7 +5,7 @@
  */
 "use strict"
 
-const check = require("../util/check-restricted")
+const { checkForRestriction, messages } = require("../util/check-restricted")
 const visit = require("../util/visit-require")
 
 module.exports = {
@@ -47,14 +47,13 @@ module.exports = {
                 additionalItems: false,
             },
         ],
-        messages: {
-            restricted:
-                "'{{name}}' module is restricted from being used.{{customMessage}}",
-        },
+        messages,
     },
 
     create(context) {
         const opts = { includeCore: true }
-        return visit(context, opts, targets => check(context, targets))
+        return visit(context, opts, targets =>
+            checkForRestriction(context, targets)
+        )
     },
 }

package/lib/rules/no-unpublished-bin.js

@@ -48,6 +48,9 @@ module.exports = {
                 },
             },
         ],
+        messages: {
+            invalidIgnored: "npm ignores '{{name}}'. Check 'files' field of 'package.json' or '.npmignore'."
+        }
     },
     create(context) {
         return {
@@ -86,8 +89,7 @@ module.exports = {
                 // Report.
                 context.report({
                     node,
-                    message:
-                        "npm ignores '{{name}}'. Check 'files' field of 'package.json' or '.npmignore'.",
+                    messageId: "invalidIgnored",
                     data: { name: relativePath },
                 })
             },

package/lib/rules/no-unpublished-import.js

@@ -4,7 +4,7 @@
  */
 "use strict"
 
-const checkPublish = require("../util/check-publish")
+const { checkPublish, messages } = require("../util/check-publish")
 const getAllowModules = require("../util/get-allow-modules")
 const getConvertPath = require("../util/get-convert-path")
 const getResolvePaths = require("../util/get-resolve-paths")
@@ -32,6 +32,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        messages,
     },
     create(context) {
         const filePath = context.getFilename()

package/lib/rules/no-unpublished-require.js

@@ -4,7 +4,7 @@
  */
 "use strict"
 
-const checkPublish = require("../util/check-publish")
+const { checkPublish, messages } = require("../util/check-publish")
 const getAllowModules = require("../util/get-allow-modules")
 const getConvertPath = require("../util/get-convert-path")
 const getResolvePaths = require("../util/get-resolve-paths")
@@ -34,6 +34,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        messages,
     },
     create(context) {
         const filePath = context.getFilename()

package/lib/rules/no-unsupported-features/es-builtins.js

@@ -5,7 +5,10 @@
 "use strict"
 
 const { READ } = require("eslint-utils")
-const checkUnsupportedBuiltins = require("../../util/check-unsupported-builtins")
+const {
+    checkUnsupportedBuiltins,
+    messages,
+} = require("../../util/check-unsupported-builtins")
 const enumeratePropertyNames = require("../../util/enumerate-property-names")
 
 const trackMap = {
@@ -165,10 +168,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
-        messages: {
-            unsupported:
-                "The '{{name}}' is not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",
-        },
+        messages,
     },
     create(context) {
         return {

package/lib/rules/no-unsupported-features/es-syntax.js

@@ -7,6 +7,7 @@
 const { rules: esRules } = require("eslint-plugin-es")
 const { getInnermostScope } = require("eslint-utils")
 const { Range } = require("semver")
+const rangeSubset = require("semver/ranges/subset")
 const getConfiguredNodeVersion = require("../../util/get-configured-node-version")
 const getSemverRange = require("../../util/get-semver-range")
 const mergeVisitorsInPlace = require("../../util/merge-visitors-in-place")
@@ -457,11 +458,11 @@ function defineVisitor(context, options) {
             return true
         }
 
-        if (aCase.supported instanceof Range) {
-            return !options.version.intersects(aCase.supported)
-        }
-
-        return options.version.intersects(getSemverRange(`<${aCase.supported}`))
+        const supported =
+            typeof aCase.supported === "string"
+                ? getSemverRange(`>=${aCase.supported}`)
+                : aCase.supported
+        return !rangeSubset(options.version, supported)
     }
 
     /**

package/lib/rules/no-unsupported-features/node-builtins.js

@@ -5,7 +5,10 @@
 "use strict"
 
 const { READ } = require("eslint-utils")
-const checkUnsupportedBuiltins = require("../../util/check-unsupported-builtins")
+const {
+    checkUnsupportedBuiltins,
+    messages,
+} = require("../../util/check-unsupported-builtins")
 const enumeratePropertyNames = require("../../util/enumerate-property-names")
 
 const trackMap = {
@@ -400,10 +403,7 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
-        messages: {
-            unsupported:
-                "The '{{name}}' is not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",
-        },
+        messages,
     },
     create(context) {
         return {

package/lib/rules/no-unsupported-features.js

@@ -1076,6 +1076,10 @@ module.exports = {
                 ],
             },
         ],
+        messages: {
+            unsupported:
+                "{{feature}} {{be}} not supported yet on Node {{version}}.",
+        },
     },
     create(context) {
         const sourceCode = context.getSourceCode()
@@ -1161,8 +1165,7 @@ module.exports = {
             if (!feature.supportedInStrict) {
                 context.report({
                     node,
-                    message:
-                        "{{feature}} {{be}} not supported yet on Node {{version}}.",
+                    messageId: "unsupported",
                     data: {
                         feature: feature.name,
                         be: feature.singular ? "is" : "are",
@@ -1172,8 +1175,7 @@ module.exports = {
             } else if (!normalizeScope(context.getScope(), node).isStrict) {
                 context.report({
                     node,
-                    message:
-                        "{{feature}} {{be}} not supported yet on Node {{version}}.",
+                    messageId: "unsupported",
                     data: {
                         feature: `${feature.name} in non-strict mode`,
                         be: feature.singular ? "is" : "are",

package/lib/rules/process-exit-as-throw.js

@@ -1,3 +1,4 @@
+/* eslint-disable eslint-plugin/prefer-message-ids */
 /**
  * @author Toru Nagashima
  * See LICENSE file in root directory for full license.

package/lib/rules/shebang.js

@@ -86,6 +86,12 @@ module.exports = {
                 additionalProperties: false,
             },
         ],
+        messages: {
+            unexpectedBOM: "This file must not have Unicode BOM.",
+            expectedLF: "This file must have Unix linebreaks (LF).",
+            expectedHashbangNode: 'This file needs shebang "#!/usr/bin/env node".',
+            expectedHashbang: "This file needs no shebang."
+        }
     },
     create(context) {
         const sourceCode = context.getSourceCode()
@@ -123,7 +129,7 @@ module.exports = {
                     if (needsShebang && info.bom) {
                         context.report({
                             node,
-                            message: "This file must not have Unicode BOM.",
+                            messageId: "unexpectedBOM",
                             fix(fixer) {
                                 return fixer.removeRange([-1, 0])
                             },
@@ -132,8 +138,7 @@ module.exports = {
                     if (needsShebang && info.cr) {
                         context.report({
                             node,
-                            message:
-                                "This file must have Unix linebreaks (LF).",
+                            messageId: "expectedLF",
                             fix(fixer) {
                                 const index = sourceCode.text.indexOf("\r")
                                 return fixer.removeRange([index, index + 1])
@@ -144,8 +149,7 @@ module.exports = {
                     // Shebang is lacking.
                     context.report({
                         node,
-                        message:
-                            'This file needs shebang "#!/usr/bin/env node".',
+                        messageId: "expectedHashbangNode",
                         fix(fixer) {
                             return fixer.replaceTextRange(
                                 [-1, info.length],
@@ -157,7 +161,7 @@ module.exports = {
                     // Shebang is extra.
                     context.report({
                         node,
-                        message: "This file needs no shebang.",
+                        messageId: "expectedHashbang",
                         fix(fixer) {
                             return fixer.removeRange([0, info.length])
                         },

package/lib/util/check-existence.js

@@ -20,7 +20,7 @@ const mapTypescriptExtension = require("../util/map-typescript-extension")
  * @param {ImportTarget[]} targets - A list of target information to check.
  * @returns {void}
  */
-module.exports = function checkExistence(context, targets) {
+exports.checkExistence = function checkExistence(context, targets) {
     const allowed = new Set(getAllowModules(context))
 
     for (const target of targets) {
@@ -47,9 +47,13 @@ module.exports = function checkExistence(context, targets) {
             context.report({
                 node: target.node,
                 loc: target.node.loc,
-                message: '"{{name}}" is not found.',
+                messageId: "notFound",
                 data: target,
             })
         }
     }
 }
+
+exports.messages = {
+    notFound: '"{{name}}" is not found.',
+}

package/lib/util/check-extraneous.js

@@ -17,7 +17,7 @@ const getPackageJson = require("./get-package-json")
  * @param {ImportTarget[]} targets - A list of target information to check.
  * @returns {void}
  */
-module.exports = function checkForExtraneous(context, filePath, targets) {
+exports.checkExtraneous = function checkExtraneous(context, filePath, targets) {
     const packageInfo = getPackageJson(filePath)
     if (!packageInfo) {
         return
@@ -44,9 +44,13 @@ module.exports = function checkForExtraneous(context, filePath, targets) {
             context.report({
                 node: target.node,
                 loc: target.node.loc,
-                message: '"{{moduleName}}" is extraneous.',
+                messageId: "extraneous",
                 data: target,
             })
         }
     }
 }
+
+exports.messages = {
+    extraneous: '"{{moduleName}}" is extraneous.',
+}

package/lib/util/check-publish.js

@@ -20,7 +20,7 @@ const getPackageJson = require("./get-package-json")
  * @param {ImportTarget[]} targets - A list of target information to check.
  * @returns {void}
  */
-module.exports = function checkForPublish(context, filePath, targets) {
+exports.checkPublish = function checkPublish(context, filePath, targets) {
     const packageInfo = getPackageJson(filePath)
     if (!packageInfo) {
         return
@@ -49,16 +49,22 @@ module.exports = function checkForPublish(context, filePath, targets) {
     if (!npmignore.match(toRelative(filePath))) {
         // This file is published, so this cannot import private files.
         for (const target of targets) {
-            const isPrivateFile =
-                target.moduleName == null &&
-                npmignore.match(toRelative(target.filePath))
-            const isDevPackage =
+            const isPrivateFile = () => {
+                if (target.moduleName != null) {
+                    return false
+                }
+                const relativeTargetPath = toRelative(target.filePath)
+                return (
+                    relativeTargetPath !== "" &&
+                    npmignore.match(relativeTargetPath)
+                )
+            }
+            const isDevPackage = () =>
                 target.moduleName != null &&
                 devDependencies.has(target.moduleName) &&
                 !dependencies.has(target.moduleName) &&
                 !allowed.has(target.moduleName)
-
-            if (isPrivateFile || isDevPackage) {
+            if (isPrivateFile() || isDevPackage()) {
                 context.report({
                     node: target.node,
                     loc: target.node.loc,
@@ -69,3 +75,7 @@ module.exports = function checkForPublish(context, filePath, targets) {
         }
     }
 }
+
+exports.messages = {
+    notPublished: '"{{name}}" is not published.',
+}

package/lib/util/check-restricted.js

@@ -90,7 +90,7 @@ function createRestrictions(defs) {
  * @param {ImportTarget[]} targets - A list of target information to check.
  * @returns {void}
  */
-module.exports = function checkForRestriction(context, targets) {
+exports.checkForRestriction = function checkForRestriction(context, targets) {
     const restrictions = createRestrictions(context.options[0])
 
     for (const target of targets) {
@@ -107,3 +107,8 @@ module.exports = function checkForRestriction(context, targets) {
         }
     }
 }
+
+exports.messages = {
+    restricted:
+        "'{{name}}' module is restricted from being used.{{customMessage}}",
+}

package/lib/util/check-unsupported-builtins.js

@@ -80,7 +80,10 @@ function supportedVersionToString({ backported, supported }) {
  * @param {{modules:object,globals:object}} trackMap The map for APIs to report.
  * @returns {void}
  */
-module.exports = function checkUnsupportedBuiltins(context, trackMap) {
+module.exports.checkUnsupportedBuiltins = function checkUnsupportedBuiltins(
+    context,
+    trackMap
+) {
     const options = parseOptions(context)
     const tracker = new ReferenceTracker(context.getScope(), { mode: "legacy" })
     const references = [
@@ -106,3 +109,8 @@ module.exports = function checkUnsupportedBuiltins(context, trackMap) {
         }
     }
 }
+
+exports.messages = {
+    unsupported:
+        "The '{{name}}' is not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",
+}

package/lib/util/map-typescript-extension.js

@@ -4,6 +4,7 @@ const path = require("path")
 const isTypescript = require("../util/is-typescript")
 
 const mapping = {
+    "": ".js", // default empty extension will map to js
     ".ts": ".js",
     ".cts": ".cjs",
     ".mts": ".mjs",

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "eslint-plugin-n",
-    "version": "15.2.2",
+    "version": "15.2.5",
     "description": "Additional ESLint's rules for Node.js",
     "engines": {
         "node": ">=12.22.0"
@@ -17,29 +17,29 @@
         "eslint-plugin-es": "^4.1.0",
         "eslint-utils": "^3.0.0",
         "ignore": "^5.1.1",
-        "is-core-module": "^2.9.0",
+        "is-core-module": "^2.10.0",
         "minimatch": "^3.1.2",
-        "resolve": "^1.10.1",
+        "resolve": "^1.22.1",
         "semver": "^7.3.7"
     },
     "devDependencies": {
         "codecov": "^3.3.0",
         "esbuild": "^0.14.39",
-        "eslint": "^8.15.0",
+        "eslint": "^8.21.0",
         "eslint-config-prettier": "^8.5.0",
-        "eslint-plugin-eslint-plugin": "^4.0.1",
+        "eslint-plugin-eslint-plugin": "^5.0.2",
         "eslint-plugin-n": "file:.",
         "fast-glob": "^3.2.11",
-        "globals": "^13.14.0",
+        "globals": "^13.17.0",
         "husky": "^8.0.1",
         "import-meta-resolve": "^1.1.1",
         "lint-staged": "^12.4.1",
         "mocha": "^10.0.0",
         "nyc": "^15.1.0",
         "opener": "^1.5.1",
-        "prettier": "^2.6.2",
+        "prettier": "^2.7.1",
         "punycode": "^2.1.1",
-        "release-it": "^15.0.0",
+        "release-it": "^15.2.0",
         "rimraf": "^3.0.2"
     },
     "scripts": {