eslint-plugin-modularity 2.5.3 → 2.5.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +1 -0
- package/package.json +1 -1
- package/src/index.js +1 -1
- package/src/rules/no-external-api-calls-in-utils.js +1 -1
package/README.md
CHANGED
|
@@ -214,6 +214,7 @@ Part of the **Interlace ESLint ecosystem** — AI-native rules with LLM-optimize
|
|
|
214
214
|
| [`eslint-plugin-secure-coding`](https://www.npmjs.com/package/eslint-plugin-secure-coding) | [](https://www.npmjs.com/package/eslint-plugin-secure-coding) | Injection prevention. |
|
|
215
215
|
| [`eslint-plugin-sequelize-security`](https://www.npmjs.com/package/eslint-plugin-sequelize-security) | [](https://www.npmjs.com/package/eslint-plugin-sequelize-security) | Sequelize ORM security. |
|
|
216
216
|
| [`eslint-plugin-sqlite-security`](https://www.npmjs.com/package/eslint-plugin-sqlite-security) | [](https://www.npmjs.com/package/eslint-plugin-sqlite-security) | SQLite security. |
|
|
217
|
+
| [`eslint-plugin-supabase-security`](https://www.npmjs.com/package/eslint-plugin-supabase-security) | [](https://www.npmjs.com/package/eslint-plugin-supabase-security) | Supabase security. |
|
|
217
218
|
| [`eslint-plugin-typeorm-security`](https://www.npmjs.com/package/eslint-plugin-typeorm-security) | [](https://www.npmjs.com/package/eslint-plugin-typeorm-security) | TypeORM security. |
|
|
218
219
|
| [`eslint-plugin-vercel-ai-security`](https://www.npmjs.com/package/eslint-plugin-vercel-ai-security) | [](https://www.npmjs.com/package/eslint-plugin-vercel-ai-security) | AI SDK security. |
|
|
219
220
|
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "eslint-plugin-modularity",
|
|
3
|
-
"version": "2.5.
|
|
3
|
+
"version": "2.5.4",
|
|
4
4
|
"description": "ESLint plugin for module architecture — enforces DDD value objects and anemic-model checks, naming, REST conventions, and utility isolation.",
|
|
5
5
|
"type": "commonjs",
|
|
6
6
|
"main": "./src/index.js",
|
package/src/index.js
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");exports.rules={get"ddd-anemic-domain-model"(){return require("./rules/ddd-anemic-domain-model").dddAnemicDomainModel},get"ddd-value-object-immutability"(){return require("./rules/ddd-value-object-immutability").dddValueObjectImmutability},get"enforce-naming"(){return require("./rules/enforce-naming").enforceNaming},get"enforce-rest-conventions"(){return require("./rules/enforce-rest-conventions").enforceRestConventions},get"no-external-api-calls-in-utils"(){return require("./rules/no-external-api-calls-in-utils").noExternalApiCallsInUtils},get"no-mutable-exports"(){return require("./rules/no-mutable-exports").noMutableExports}};(0,eslint_devkit_1.withCanonicalDocsUrls)("plugin-modularity",exports.rules);exports.plugin={meta:{name:"eslint-plugin-modularity",version:"2.5.
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");exports.rules={get"ddd-anemic-domain-model"(){return require("./rules/ddd-anemic-domain-model").dddAnemicDomainModel},get"ddd-value-object-immutability"(){return require("./rules/ddd-value-object-immutability").dddValueObjectImmutability},get"enforce-naming"(){return require("./rules/enforce-naming").enforceNaming},get"enforce-rest-conventions"(){return require("./rules/enforce-rest-conventions").enforceRestConventions},get"no-external-api-calls-in-utils"(){return require("./rules/no-external-api-calls-in-utils").noExternalApiCallsInUtils},get"no-mutable-exports"(){return require("./rules/no-mutable-exports").noMutableExports}};(0,eslint_devkit_1.withCanonicalDocsUrls)("plugin-modularity",exports.rules);exports.plugin={meta:{name:"eslint-plugin-modularity",version:"2.5.4"},rules:exports.rules};const recommendedRules={"modularity/ddd-anemic-domain-model":"warn","modularity/ddd-value-object-immutability":"error","modularity/enforce-naming":"warn","modularity/enforce-rest-conventions":"error","modularity/no-external-api-calls-in-utils":"error","modularity/no-mutable-exports":"warn"};exports.configs={recommended:{plugins:{"modularity":exports.plugin},rules:recommendedRules},strict:{plugins:{"modularity":exports.plugin},rules:Object.fromEntries(Object.keys(exports.rules).map(ruleName=>[`modularity/${ruleName}`,"error"]))}};exports.default=exports.plugin;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noExternalApiCallsInUtils=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const DEFAULT_HTTP_MODULES=["axios","got","ky","node-fetch","undici","superagent","request","phin","needle","http","https","http2","node:http","node:https","node:http2"];const DEFAULT_NETWORK_METHODS=["get","post","put","patch","delete","head","options","request","fetch","all","stream"];const DEFAULT_UTILITY_PATTERNS=["**/utils/**","**/helpers/**","**/lib/**"];const GLOBAL_CLIENTS=new Set(["fetch"]);const GLOBAL_CLIENT_HOSTS=new Set(["window","globalThis","global","self"]);const AMBIGUOUS_MODULE_NAMES=new Set(["request","got"]);function isUtilityFile(filename,patterns){return patterns.some(pattern=>{const regex=new RegExp(pattern.replace(/\*\*/g,".*").replace(/\*/g,"[^/]*"));return regex.test(filename)})}function rootName(node){let current=node;while(current.type==="MemberExpression"){current=current.object}return current.type==="Identifier"?current.name:null}function requiredModule(node){if(node.type==="CallExpression"&&node.callee.type==="Identifier"&&node.callee.name==="require"&&node.arguments[0]?.type==="Literal"&&typeof node.arguments[0].value==="string"){return node.arguments[0].value}return null}exports.noExternalApiCallsInUtils=(0,eslint_devkit_2.createRule)({name:"no-external-api-calls-in-utils",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-modularity/docs/rules/no-external-api-calls-in-utils.md",description:"Detects network calls in utility functions"},hasSuggestions:true,messages:{externalApiCallInUtils:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.ARCHITECTURE,issueName:"External API call in utils",description:"Network call in utility function - breaks testability",severity:"HIGH",fix:"Use dependency injection for network calls",documentationLink:"https://rules.sonarsource.com/javascript/RSPEC-1075/"}),useDependencyInjection:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Dependency Injection",description:"Inject API client",severity:"LOW",fix:"function util(apiClient) { return apiClient.get(...) }",documentationLink:"https://en.wikipedia.org/wiki/Dependency_injection"}),extractToService:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Extract to Service",description:"Extract to service layer",severity:"LOW",fix:"Create services/apiService.ts",documentationLink:"https://martinfowler.com/eaaCatalog/serviceLayer.html"}),passApiClient:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Pass API Client",description:"Pass API client as parameter",severity:"LOW",fix:"function util(apiClient, data) { ... }",documentationLink:"https://en.wikipedia.org/wiki/Dependency_injection"})},schema:[{type:"object",properties:{httpModules:{type:"array",items:{type:"string"},default:DEFAULT_HTTP_MODULES},ignoreInTests:{type:"boolean",default:true},networkMethods:{description:'HTTP method names to flag. A bare name ("get") applies only when the receiver resolves to a known HTTP client. A dotted entry ("httpClient.get") is an exact object.method escape hatch that bypasses client resolution entirely \u2014 use it for an in-house client this rule cannot trace.',type:"array",items:{type:"string"},default:DEFAULT_NETWORK_METHODS},utilityPatterns:{type:"array",items:{type:"string"},default:DEFAULT_UTILITY_PATTERNS}},additionalProperties:false}]},defaultOptions:[{httpModules:DEFAULT_HTTP_MODULES,ignoreInTests:true,networkMethods:DEFAULT_NETWORK_METHODS,utilityPatterns:DEFAULT_UTILITY_PATTERNS}],create(context,[options={}]){const{httpModules=DEFAULT_HTTP_MODULES,ignoreInTests=true,networkMethods=DEFAULT_NETWORK_METHODS,utilityPatterns=DEFAULT_UTILITY_PATTERNS}=options||{};const filename=context.filename;const isTestFile=ignoreInTests&&/\.(test|spec)\.
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noExternalApiCallsInUtils=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const DEFAULT_HTTP_MODULES=["axios","got","ky","node-fetch","undici","superagent","request","phin","needle","http","https","http2","node:http","node:https","node:http2"];const DEFAULT_NETWORK_METHODS=["get","post","put","patch","delete","head","options","request","fetch","all","stream"];const DEFAULT_UTILITY_PATTERNS=["**/utils/**","**/helpers/**","**/lib/**"];const GLOBAL_CLIENTS=new Set(["fetch"]);const GLOBAL_CLIENT_HOSTS=new Set(["window","globalThis","global","self"]);const AMBIGUOUS_MODULE_NAMES=new Set(["request","got"]);function isUtilityFile(filename,patterns){return patterns.some(pattern=>{const regex=new RegExp(pattern.replace(/\*\*/g,".*").replace(/\*/g,"[^/]*"));return regex.test(filename)})}function rootName(node){let current=node;while(current.type==="MemberExpression"){current=current.object}return current.type==="Identifier"?current.name:null}function requiredModule(node){if(node.type==="CallExpression"&&node.callee.type==="Identifier"&&node.callee.name==="require"&&node.arguments[0]?.type==="Literal"&&typeof node.arguments[0].value==="string"){return node.arguments[0].value}return null}exports.noExternalApiCallsInUtils=(0,eslint_devkit_2.createRule)({name:"no-external-api-calls-in-utils",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-modularity/docs/rules/no-external-api-calls-in-utils.md",description:"Detects network calls in utility functions"},hasSuggestions:true,messages:{externalApiCallInUtils:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.ARCHITECTURE,issueName:"External API call in utils",description:"Network call in utility function - breaks testability",severity:"HIGH",fix:"Use dependency injection for network calls",documentationLink:"https://rules.sonarsource.com/javascript/RSPEC-1075/"}),useDependencyInjection:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Dependency Injection",description:"Inject API client",severity:"LOW",fix:"function util(apiClient) { return apiClient.get(...) }",documentationLink:"https://en.wikipedia.org/wiki/Dependency_injection"}),extractToService:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Extract to Service",description:"Extract to service layer",severity:"LOW",fix:"Create services/apiService.ts",documentationLink:"https://martinfowler.com/eaaCatalog/serviceLayer.html"}),passApiClient:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Pass API Client",description:"Pass API client as parameter",severity:"LOW",fix:"function util(apiClient, data) { ... }",documentationLink:"https://en.wikipedia.org/wiki/Dependency_injection"})},schema:[{type:"object",properties:{httpModules:{type:"array",items:{type:"string"},default:DEFAULT_HTTP_MODULES},ignoreInTests:{type:"boolean",default:true},networkMethods:{description:'HTTP method names to flag. A bare name ("get") applies only when the receiver resolves to a known HTTP client. A dotted entry ("httpClient.get") is an exact object.method escape hatch that bypasses client resolution entirely \u2014 use it for an in-house client this rule cannot trace.',type:"array",items:{type:"string"},default:DEFAULT_NETWORK_METHODS},utilityPatterns:{type:"array",items:{type:"string"},default:DEFAULT_UTILITY_PATTERNS}},additionalProperties:false}]},defaultOptions:[{httpModules:DEFAULT_HTTP_MODULES,ignoreInTests:true,networkMethods:DEFAULT_NETWORK_METHODS,utilityPatterns:DEFAULT_UTILITY_PATTERNS}],create(context,[options={}]){const{httpModules=DEFAULT_HTTP_MODULES,ignoreInTests=true,networkMethods=DEFAULT_NETWORK_METHODS,utilityPatterns=DEFAULT_UTILITY_PATTERNS}=options||{};const filename=context.filename;const isTestFile=ignoreInTests&&/\.(test|spec)\.[cm]?[jt]sx?$/.test(filename);if(isTestFile){return{}}const isUtility=isUtilityFile(filename,utilityPatterns);if(!isUtility){return{}}const modules=new Set(httpModules);const methods=new Set(networkMethods);const explicitPairs=new Set(networkMethods.filter(method=>method.includes(".")));const clients=new Set(GLOBAL_CLIENTS);for(const source of modules){const bare=source.replace(/^node:/,"");if(/^[A-Za-z_$][\w$]*$/.test(bare)&&!AMBIGUOUS_MODULE_NAMES.has(bare)){clients.add(bare)}}const aliases=[];const calls=[];function trackBinding(id){if(id.type==="Identifier"){clients.add(id.name)}else if(id.type==="ObjectPattern"){for(const property of id.properties){if(property.type==="Property"&&property.value.type==="Identifier"){clients.add(property.value.name)}}}}function isNetworkCall(node){const callee=node.callee;if(callee.type==="Identifier"){return clients.has(callee.name)}if(callee.type!=="MemberExpression"||callee.computed||callee.property.type!=="Identifier"){return false}const method=callee.property.name;const root=rootName(callee.object);if(root===null){return false}if(explicitPairs.has(`${root}.${method}`)){return true}if(GLOBAL_CLIENT_HOSTS.has(root)){return GLOBAL_CLIENTS.has(method)}return clients.has(root)&&methods.has(method)}return{ImportDeclaration(node){if(node.importKind==="type"||!modules.has(node.source.value)){return}for(const specifier of node.specifiers){if(specifier.type!=="ImportSpecifier"||specifier.importKind!=="type"){clients.add(specifier.local.name)}}},VariableDeclarator(node){if(!node.init){return}const source=requiredModule(node.init);if(source!==null){if(modules.has(source)){trackBinding(node.id)}return}const root=rootName(node.init.type==="CallExpression"?node.init.callee:node.init);if(root!==null&&node.id.type==="Identifier"){aliases.push([node.id.name,root])}},CallExpression(node){calls.push(node)},"Program:exit"(){let changed=true;while(changed){changed=false;for(const[local,root]of aliases){if(clients.has(root)&&!clients.has(local)){clients.add(local);changed=true}}}for(const node of calls){if(!isNetworkCall(node)){continue}context.report({node,messageId:"externalApiCallInUtils",suggest:[{messageId:"useDependencyInjection",fix:()=>null},{messageId:"extractToService",fix:()=>null},{messageId:"passApiClient",fix:()=>null}]})}}}}});
|