eslint-plugin-mobx 0.0.6 → 0.0.9

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # eslint-plugin-mobx
 
+## 0.0.9
+
+### Patch Changes
+
+-   [`e63c2df0`](https://github.com/mobxjs/mobx/commit/e63c2df0ef166868675bce21892cd686a46db953) [#3443](https://github.com/mobxjs/mobx/pull/3443) Thanks [@urugator](https://github.com/urugator)! - changeset for PR #3423: deprecate no-anonymous-observer
+
+## 0.0.8
+
+### Patch Changes
+
+-   [`aafda613`](https://github.com/mobxjs/mobx/commit/aafda6136afd107c6cbdd73d9bab57e45a2eb9f5) [#3256](https://github.com/mobxjs/mobx/pull/3256) Thanks [@urugator](https://github.com/urugator)! - fix `no-anonymous-observer` autofix for arrow functions without BlockStatement body
+
+## 0.0.7
+
+### Patch Changes
+
+-   [`0aaf1831`](https://github.com/mobxjs/mobx/commit/0aaf183131f3eadd40c05ccc94139282bd8d7d56) [#3231](https://github.com/mobxjs/mobx/pull/3231) Thanks [@ahoisl](https://github.com/ahoisl)! - fix(lint): fix 'missing-make-observable' rule with constructor overloads
+
 ## 0.0.6
 
 ### Patch Changes

package/README.md

@@ -82,7 +82,22 @@ It's a bit opinionated and can lead to a lot of false positives depending on you
 ]
 ```
 
-### mobx/no-anonymous-observer
+### mobx/no-anonymous-observer (deprecated)
+
+_Deprecated in favor of [react/display-name](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/display-name.md) + [componentWrapperFunctions](https://github.com/jsx-eslint/eslint-plugin-react). Example of **.eslintrc**:_
+```
+{
+  "rules": {
+    "react/display-name": "warn"
+  },
+  "settings": {
+    "componentWrapperFunctions": [
+      "observer"
+    ]
+  }
+}
+```
+---
 
 Forbids anonymous functions or classes as `observer` components.
 Improves debugging experience and [avoids problem with inability to customize `displayName`](https://github.com/mobxjs/mobx/issues/2721).

package/dist/index.js

@@ -285,7 +285,7 @@ function create$2(context) {
   var sourceCode = context.getSourceCode();
   return {
     'Decorator': function Decorator(decorator) {
-      var _constructor$value$bo, _constructor$value$bo2;
+      var _clazz$body$body$find, _constructor$value$bo, _constructor$value$bo2;
 
       if (!isMobxDecorator(decorator)) return;
       var clazz = findAncestor(decorator, function (node) {
@@ -293,7 +293,9 @@ function create$2(context) {
       });
       if (!clazz) return; // ClassDeclaration > ClassBody > []
 
-      var constructor = clazz.body.body.find(function (node) {
+      var constructor = (_clazz$body$body$find = clazz.body.body.find(function (node) {
+        return node.kind === 'constructor' && node.value.type === 'FunctionExpression';
+      })) !== null && _clazz$body$body$find !== void 0 ? _clazz$body$body$find : clazz.body.body.find(function (node) {
         return node.kind === 'constructor';
       }); // MethodDefinition > FunctionExpression > BlockStatement > []
 
@@ -431,21 +433,27 @@ function create(context) {
       var fix = function fix(fixer) {
         var _observer$parent;
 
-        // Use name from variable for autofix 
-        var name = ((_observer$parent = observer.parent) === null || _observer$parent === void 0 ? void 0 : _observer$parent.type) === 'VariableDeclarator' ? observer.parent.id.name : undefined;
+        // Use name from variable for autofix
+        var name = ((_observer$parent = observer.parent) === null || _observer$parent === void 0 ? void 0 : _observer$parent.type) === "VariableDeclarator" ? observer.parent.id.name : undefined;
         if (!name) return;
 
-        if (cmp.type === 'ArrowFunctionExpression') {
+        if (cmp.type === "ArrowFunctionExpression") {
           var arrowToken = sourceCode.getTokenBefore(cmp.body);
-          return [fixer.replaceText(arrowToken, ''), fixer.insertTextBefore(cmp, "function ".concat(name))];
+          var fixes = [fixer.replaceText(arrowToken, ""), fixer.insertTextBefore(cmp, "function ".concat(name))];
+
+          if (cmp.body.type !== "BlockStatement") {
+            fixes.push(fixer.insertTextBefore(cmp.body, "{ return "), fixer.insertTextAfter(cmp.body, " }"));
+          }
+
+          return fixes;
         }
 
-        if (cmp.type === 'FunctionExpression') {
+        if (cmp.type === "FunctionExpression") {
           var functionToken = sourceCode.getFirstToken(cmp);
           return fixer.replaceText(functionToken, "function ".concat(name));
         }
 
-        if (cmp.type === 'ClassExpression') {
+        if (cmp.type === "ClassExpression") {
           var classToken = sourceCode.getFirstToken(cmp);
           return fixer.replaceText(classToken, "class ".concat(name));
         }
@@ -453,7 +461,7 @@ function create(context) {
 
       context.report({
         node: cmp,
-        messageId: 'observerComponentMustHaveName',
+        messageId: "observerComponentMustHaveName",
         fix: fix
       });
     }
@@ -462,10 +470,10 @@ function create(context) {
 
 var noAnonymousObserver$1 = {
   meta: {
-    type: 'problem',
-    fixable: 'code',
+    type: "problem",
+    fixable: "code",
     docs: {
-      description: 'forbids anonymous functions or classes as `observer` components',
+      description: "forbids anonymous functions or classes as `observer` components",
       recommended: true
     },
     messages: {
@@ -488,8 +496,7 @@ var src = {
         "mobx/exhaustive-make-observable": "warn",
         "mobx/unconditional-make-observable": "error",
         "mobx/missing-make-observable": "error",
-        "mobx/missing-observer": "warn",
-        "mobx/no-anonymous-observer": "warn"
+        "mobx/missing-observer": "warn"
       }
     }
   },

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "eslint-plugin-mobx",
-    "version": "0.0.6",
+    "version": "0.0.9",
     "description": "ESLint rules for MobX",
     "main": "dist/index.js",
     "repository": {

package/src/index.js

@@ -14,8 +14,7 @@ module.exports = {
                 "mobx/exhaustive-make-observable": "warn",
                 "mobx/unconditional-make-observable": "error",
                 "mobx/missing-make-observable": "error",
-                "mobx/missing-observer": "warn",
-                "mobx/no-anonymous-observer": "warn"
+                "mobx/missing-observer": "warn"
             }
         }
     },

package/src/missing-make-observable.js

@@ -11,7 +11,8 @@ function create(context) {
       const clazz = findAncestor(decorator, node => node.type === 'ClassDeclaration' || node.type === 'ClassExpression');
       if (!clazz) return;
       // ClassDeclaration > ClassBody > []
-      const constructor = clazz.body.body.find(node => node.kind === 'constructor');
+      const constructor = clazz.body.body.find(node => node.kind === 'constructor' && node.value.type === 'FunctionExpression') ??
+        clazz.body.body.find(node => node.kind === 'constructor');
       // MethodDefinition > FunctionExpression > BlockStatement > []
       const isMakeObservable = node => node.expression?.callee?.name === 'makeObservable' && node.expression?.arguments[0]?.type === 'ThisExpression';
       const makeObservable = constructor?.value.body?.body.find(isMakeObservable)?.expression;

package/src/no-anonymous-observer.js

@@ -1,57 +1,65 @@
-'use strict';
+"use strict"
 
 function create(context) {
-  const sourceCode = context.getSourceCode();
+    const sourceCode = context.getSourceCode()
 
-  return {
-    'CallExpression[callee.name="observer"]': observer => {
-      const cmp = observer.arguments[0];
-      if (!cmp) return;
-      if (cmp?.id?.name) return;
+    return {
+        'CallExpression[callee.name="observer"]': observer => {
+            const cmp = observer.arguments[0]
+            if (!cmp) return
+            if (cmp?.id?.name) return
 
-      const fix = fixer => {
-        // Use name from variable for autofix 
-        const name = observer.parent?.type === 'VariableDeclarator'
-          ? observer.parent.id.name
-          : undefined;
+            const fix = fixer => {
+                // Use name from variable for autofix
+                const name =
+                    observer.parent?.type === "VariableDeclarator"
+                        ? observer.parent.id.name
+                        : undefined
 
-        if (!name) return;
-        if (cmp.type === 'ArrowFunctionExpression') {
-          const arrowToken = sourceCode.getTokenBefore(cmp.body);
-          return [
-            fixer.replaceText(arrowToken, ''),
-            fixer.insertTextBefore(cmp, `function ${name}`),
-          ]
+                if (!name) return
+                if (cmp.type === "ArrowFunctionExpression") {
+                    const arrowToken = sourceCode.getTokenBefore(cmp.body)
+                    const fixes = [
+                        fixer.replaceText(arrowToken, ""),
+                        fixer.insertTextBefore(cmp, `function ${name}`)
+                    ]
+                    if (cmp.body.type !== "BlockStatement") {
+                        fixes.push(
+                            fixer.insertTextBefore(cmp.body, `{ return `),
+                            fixer.insertTextAfter(cmp.body, ` }`)
+                        )
+                    }
+                    return fixes
+                }
+                if (cmp.type === "FunctionExpression") {
+                    const functionToken = sourceCode.getFirstToken(cmp)
+                    return fixer.replaceText(functionToken, `function ${name}`)
+                }
+                if (cmp.type === "ClassExpression") {
+                    const classToken = sourceCode.getFirstToken(cmp)
+                    return fixer.replaceText(classToken, `class ${name}`)
+                }
+            }
+            context.report({
+                node: cmp,
+                messageId: "observerComponentMustHaveName",
+                fix
+            })
         }
-        if (cmp.type === 'FunctionExpression') {
-          const functionToken = sourceCode.getFirstToken(cmp);
-          return fixer.replaceText(functionToken, `function ${name}`);
-        }
-        if (cmp.type === 'ClassExpression') {
-          const classToken = sourceCode.getFirstToken(cmp);
-          return fixer.replaceText(classToken, `class ${name}`);
-        }
-      }
-      context.report({
-        node: cmp,
-        messageId: 'observerComponentMustHaveName',
-        fix,
-      })
-    },
-  };
+    }
 }
 
 module.exports = {
-  meta: {
-    type: 'problem',
-    fixable: 'code',
-    docs: {
-      description: 'forbids anonymous functions or classes as `observer` components',
-      recommended: true,
-    },
-    messages: {
-      observerComponentMustHaveName: "`observer` component must have a name.",
+    meta: {
+        type: "problem",
+        fixable: "code",
+        docs: {
+            description: "forbids anonymous functions or classes as `observer` components",
+            recommended: true
+        },
+        messages: {
+            observerComponentMustHaveName: "`observer` component must have a name."
+        }
     },
-  },
-  create,
-};
+    create
+}