eslint-plugin-mcp-sdk-security 0.4.3 → 0.5.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +20 -8
- package/package.json +1 -1
- package/src/index.js +1 -1
- package/src/rules/no-command-injection-in-tool/index.js +1 -1
- package/src/rules/no-tool-description-injection/index.js +1 -1
- package/src/rules/no-unvalidated-tool-args/index.js +1 -1
- package/src/rules/require-tool-input-schema/index.js +1 -1
- package/src/utils/mcp-evidence.js +1 -1
- package/src/utils/tool-registration.js +1 -0
package/README.md
CHANGED
|
@@ -54,11 +54,21 @@ npm install eslint-plugin-mcp-sdk-security --save-dev
|
|
|
54
54
|
|
|
55
55
|
## ⚙️ Configuration Presets
|
|
56
56
|
|
|
57
|
-
| Preset | Description |
|
|
58
|
-
| :--- | :--- |
|
|
59
|
-
| `
|
|
60
|
-
| `
|
|
61
|
-
| `
|
|
57
|
+
| Preset | Rules (all at `error`) | Description |
|
|
58
|
+
| :--- | :--- | :--- |
|
|
59
|
+
| `minimal` | `no-command-injection-in-tool`, `require-tool-input-schema` | Only the rules whose every finding is a defect by construction. |
|
|
60
|
+
| `recommended` | `no-command-injection-in-tool`, `no-unvalidated-tool-args`, `require-tool-input-schema` | The default. Adds the schema/handler contract check. |
|
|
61
|
+
| `strict` | `no-command-injection-in-tool`, `no-tool-description-injection`, `no-unvalidated-tool-args`, `require-tool-input-schema` | Every rule. Adds `no-tool-description-injection`, which also reports a description imported from another module, because this file cannot see its text. |
|
|
62
|
+
|
|
63
|
+
Supported servers: `@modelcontextprotocol/sdk` (v1), the v2 split packages
|
|
64
|
+
(`@modelcontextprotocol/server`, `client`, `core`, `node`, `express`, `hono`,
|
|
65
|
+
`fastify`), and `mcp-handler` / `@vercel/mcp-adapter`. Every rule stays silent
|
|
66
|
+
in a file that imports none of them.
|
|
67
|
+
|
|
68
|
+
`no-command-injection-in-tool` reports a tool argument used *as* the command.
|
|
69
|
+
A command *built* from one (`` execSync(`git log ${ref}`) ``) is
|
|
70
|
+
[`eslint-plugin-node-security`](https://www.npmjs.com/package/eslint-plugin-node-security)'s
|
|
71
|
+
`no-shell-injection`, so install both to cover both shapes.
|
|
62
72
|
|
|
63
73
|
## Usage
|
|
64
74
|
|
|
@@ -122,10 +132,10 @@ See the [ESLint Version Support Policy](../../docs/ESLINT_VERSION_SUPPORT.md) fo
|
|
|
122
132
|
<!-- AUTO-GENERATED:RULES_TABLE:START - Do not edit manually -->
|
|
123
133
|
| Rule | CWE | OWASP | CVSS | Description | 🧠 | 💼 | ⚠️ | 🔧 | 💡 | 🚫 |
|
|
124
134
|
| :--- | :---: | :---: | :---: | :--- | :---: | :---: | :---: | :---: | :---: | :---: |
|
|
125
|
-
| [no-command-injection-in-tool](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security/rules/no-command-injection-in-tool?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security) | CWE-78 | A03:2021 | | Disallow an MCP tool argument being used directly as the command in a child_process call. | 🟢 |
|
|
135
|
+
| [no-command-injection-in-tool](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security/rules/no-command-injection-in-tool?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security) | CWE-78 | A03:2021 | | Disallow an MCP tool argument being used directly as the command in a child_process call. | 🟢 | 💼 | | | | |
|
|
126
136
|
| [no-tool-description-injection](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security/rules/no-tool-description-injection?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security) | CWE-1427 | A03:2021 | | Require MCP tool descriptions and titles to be static text, since they reach the model as instructions. | 🟢 | | | | | |
|
|
127
|
-
| [no-unvalidated-tool-args](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security/rules/no-unvalidated-tool-args?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security) | CWE-20 | A03:2021 | | Disallow a tool handler reading an argument its declared input schema does not include. | 🟢 |
|
|
128
|
-
| [require-tool-input-schema](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security/rules/require-tool-input-schema?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security) | CWE-20 | A03:2021 | | Require an input schema when
|
|
137
|
+
| [no-unvalidated-tool-args](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security/rules/no-unvalidated-tool-args?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security) | CWE-20 | A03:2021 | | Disallow a tool handler reading an argument its declared input schema does not include. | 🟢 | 💼 | | | | |
|
|
138
|
+
| [require-tool-input-schema](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security/rules/require-tool-input-schema?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security) | CWE-20 | A03:2021 | | Require an input schema when an MCP tool handler reads arguments. | 🟢 | 💼 | | | | |
|
|
129
139
|
<!-- AUTO-GENERATED:RULES_TABLE:END -->
|
|
130
140
|
<!-- INTERLACE:STAR_CTA:START -->
|
|
131
141
|
## ⭐ Support & follow
|
|
@@ -164,6 +174,7 @@ Part of the **Interlace ESLint ecosystem** — AI-native rules with LLM-optimize
|
|
|
164
174
|
| [`eslint-plugin-secure-coding`](https://www.npmjs.com/package/eslint-plugin-secure-coding) | [](https://www.npmjs.com/package/eslint-plugin-secure-coding) | Injection prevention. |
|
|
165
175
|
| [`eslint-plugin-sequelize-security`](https://www.npmjs.com/package/eslint-plugin-sequelize-security) | [](https://www.npmjs.com/package/eslint-plugin-sequelize-security) | Sequelize ORM security. |
|
|
166
176
|
| [`eslint-plugin-sqlite-security`](https://www.npmjs.com/package/eslint-plugin-sqlite-security) | [](https://www.npmjs.com/package/eslint-plugin-sqlite-security) | SQLite security. |
|
|
177
|
+
| [`eslint-plugin-supabase-security`](https://www.npmjs.com/package/eslint-plugin-supabase-security) | [](https://www.npmjs.com/package/eslint-plugin-supabase-security) | Supabase security. |
|
|
167
178
|
| [`eslint-plugin-typeorm-security`](https://www.npmjs.com/package/eslint-plugin-typeorm-security) | [](https://www.npmjs.com/package/eslint-plugin-typeorm-security) | TypeORM security. |
|
|
168
179
|
| [`eslint-plugin-vercel-ai-security`](https://www.npmjs.com/package/eslint-plugin-vercel-ai-security) | [](https://www.npmjs.com/package/eslint-plugin-vercel-ai-security) | AI SDK security. |
|
|
169
180
|
|
|
@@ -171,6 +182,7 @@ Part of the **Interlace ESLint ecosystem** — AI-native rules with LLM-optimize
|
|
|
171
182
|
|
|
172
183
|
| Plugin | Downloads | Description |
|
|
173
184
|
| :--- | :---: | :--- |
|
|
185
|
+
| [`eslint-plugin-cli-floor`](https://www.npmjs.com/package/eslint-plugin-cli-floor) | [](https://www.npmjs.com/package/eslint-plugin-cli-floor) | CLI floor for commander, yargs and burgee. |
|
|
174
186
|
| [`eslint-plugin-conventions`](https://www.npmjs.com/package/eslint-plugin-conventions) | [](https://www.npmjs.com/package/eslint-plugin-conventions) | Team-specific habits and styles. |
|
|
175
187
|
| [`eslint-plugin-import-next`](https://www.npmjs.com/package/eslint-plugin-import-next) | [](https://www.npmjs.com/package/eslint-plugin-import-next) | Fast cycle + import-graph analysis. |
|
|
176
188
|
| [`eslint-plugin-maintainability`](https://www.npmjs.com/package/eslint-plugin-maintainability) | [](https://www.npmjs.com/package/eslint-plugin-maintainability) | Cognitive load and clean-code patterns. |
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "eslint-plugin-mcp-sdk-security",
|
|
3
|
-
"version": "0.
|
|
3
|
+
"version": "0.5.0",
|
|
4
4
|
"description": "ESLint plugin for Model Context Protocol (MCP) SDK security — catches tools registered without an input schema, handlers reading arguments the schema never declared, model-visible descriptions built from dynamic text, and tool arguments reaching a shell.",
|
|
5
5
|
"type": "commonjs",
|
|
6
6
|
"main": "./src/index.js",
|
package/src/index.js
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=exports.requireToolInputSchema=exports.noUnvalidatedToolArgs=exports.noToolDescriptionInjection=exports.noCommandInjectionInTool=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");var no_command_injection_in_tool_2=require("./rules/no-command-injection-in-tool");Object.defineProperty(exports,"noCommandInjectionInTool",{enumerable:true,get:function(){return no_command_injection_in_tool_2.noCommandInjectionInTool}});var no_tool_description_injection_2=require("./rules/no-tool-description-injection");Object.defineProperty(exports,"noToolDescriptionInjection",{enumerable:true,get:function(){return no_tool_description_injection_2.noToolDescriptionInjection}});var no_unvalidated_tool_args_2=require("./rules/no-unvalidated-tool-args");Object.defineProperty(exports,"noUnvalidatedToolArgs",{enumerable:true,get:function(){return no_unvalidated_tool_args_2.noUnvalidatedToolArgs}});var require_tool_input_schema_2=require("./rules/require-tool-input-schema");Object.defineProperty(exports,"requireToolInputSchema",{enumerable:true,get:function(){return require_tool_input_schema_2.requireToolInputSchema}});exports.rules={get"no-command-injection-in-tool"(){return require("./rules/no-command-injection-in-tool").noCommandInjectionInTool},get"no-tool-description-injection"(){return require("./rules/no-tool-description-injection").noToolDescriptionInjection},get"no-unvalidated-tool-args"(){return require("./rules/no-unvalidated-tool-args").noUnvalidatedToolArgs},get"require-tool-input-schema"(){return require("./rules/require-tool-input-schema").requireToolInputSchema}};(0,eslint_devkit_1.withCanonicalDocsUrls)("plugin-mcp-sdk-security",exports.rules);exports.plugin={meta:{name:"eslint-plugin-mcp-sdk-security",version:"0.
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=exports.requireToolInputSchema=exports.noUnvalidatedToolArgs=exports.noToolDescriptionInjection=exports.noCommandInjectionInTool=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");var no_command_injection_in_tool_2=require("./rules/no-command-injection-in-tool");Object.defineProperty(exports,"noCommandInjectionInTool",{enumerable:true,get:function(){return no_command_injection_in_tool_2.noCommandInjectionInTool}});var no_tool_description_injection_2=require("./rules/no-tool-description-injection");Object.defineProperty(exports,"noToolDescriptionInjection",{enumerable:true,get:function(){return no_tool_description_injection_2.noToolDescriptionInjection}});var no_unvalidated_tool_args_2=require("./rules/no-unvalidated-tool-args");Object.defineProperty(exports,"noUnvalidatedToolArgs",{enumerable:true,get:function(){return no_unvalidated_tool_args_2.noUnvalidatedToolArgs}});var require_tool_input_schema_2=require("./rules/require-tool-input-schema");Object.defineProperty(exports,"requireToolInputSchema",{enumerable:true,get:function(){return require_tool_input_schema_2.requireToolInputSchema}});exports.rules={get"no-command-injection-in-tool"(){return require("./rules/no-command-injection-in-tool").noCommandInjectionInTool},get"no-tool-description-injection"(){return require("./rules/no-tool-description-injection").noToolDescriptionInjection},get"no-unvalidated-tool-args"(){return require("./rules/no-unvalidated-tool-args").noUnvalidatedToolArgs},get"require-tool-input-schema"(){return require("./rules/require-tool-input-schema").requireToolInputSchema}};(0,eslint_devkit_1.withCanonicalDocsUrls)("plugin-mcp-sdk-security",exports.rules);exports.plugin={meta:{name:"eslint-plugin-mcp-sdk-security",version:"0.5.0"},rules:exports.rules};const minimalRules={"mcp-sdk-security/no-command-injection-in-tool":"error","mcp-sdk-security/require-tool-input-schema":"error"};const recommendedRules={"mcp-sdk-security/no-command-injection-in-tool":"error","mcp-sdk-security/no-unvalidated-tool-args":"error","mcp-sdk-security/require-tool-input-schema":"error"};const strictRules=Object.fromEntries(Object.keys(exports.rules).map(ruleName=>[`mcp-sdk-security/${ruleName}`,"error"]));exports.configs={minimal:{plugins:{"mcp-sdk-security":exports.plugin},rules:minimalRules},recommended:{plugins:{"mcp-sdk-security":exports.plugin},rules:recommendedRules},strict:{plugins:{"mcp-sdk-security":exports.plugin},rules:strictRules}};exports.default={...exports.plugin,configs:exports.configs};
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noCommandInjectionInTool=void 0;exports.isBuiltString=isBuiltString;exports.handlerArgNames=handlerArgNames;const eslint_devkit_1=require("@interlace/eslint-devkit");const mcp_evidence_1=require("../../utils/mcp-evidence");const
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noCommandInjectionInTool=void 0;exports.isBuiltString=isBuiltString;exports.handlerArgNames=handlerArgNames;const eslint_devkit_1=require("@interlace/eslint-devkit");const mcp_evidence_1=require("../../utils/mcp-evidence");const tool_registration_1=require("../../utils/tool-registration");const PROCESS_SINKS=new Set(["exec","execSync","execFile","execFileSync","spawn","spawnSync","fork"]);const EXECA_SINKS=new Set(["execa","execaSync","execaCommand","execaCommandSync","execaNode"]);const ARGV_SINKS=new Set(["spawn","spawnSync","execFile","execFileSync","execa","execaSync"]);const SHELLS=new Set(["sh","bash","zsh","dash","ksh","fish","cmd","cmd.exe","powershell","powershell.exe","pwsh","pwsh.exe"]);const SHELL_SCRIPT_FLAGS=new Set(["-c","-lc","-ic","/c","/C","-Command","-command"]);const CALL_TOOL_ARGS_PATH=["params","arguments"];function isBuiltString(node){if(node.type==="TemplateLiteral")return node.expressions.length>0;if(node.type==="BinaryExpression"&&node.operator==="+")return true;return false}function bindPattern(pattern,toArgs,into,topKey){if(pattern.type==="AssignmentPattern")pattern=pattern.left;if(pattern.type==="Identifier"){if(topKey!==void 0&&toArgs.length===0)into.direct.set(pattern.name,topKey);else into.roots.set(pattern.name,[...toArgs]);return}if(pattern.type!=="ObjectPattern")return;for(const prop of pattern.properties){if(prop.type==="RestElement"){if(toArgs.length===0)bindPattern(prop.argument,[],into);continue}const key=(0,tool_registration_1.propertyKey)(prop);if(key===void 0)continue;if(toArgs.length===0)bindPattern(prop.value,[],into,topKey??key);else if(key===toArgs[0])bindPattern(prop.value,toArgs.slice(1),into)}}function handlerArgNames(handler){const bindings={direct:new Map,roots:new Map};if((handler.type==="ArrowFunctionExpression"||handler.type==="FunctionExpression"||handler.type==="FunctionDeclaration")&&handler.params[0]!==void 0){bindPattern(handler.params[0],[],bindings)}return{direct:new Set(bindings.direct.keys()),objects:new Set(bindings.roots.keys())}}function unwrap(node){for(;;){if(node.type==="TSAsExpression"||node.type==="TSNonNullExpression"||node.type==="TSTypeAssertion"||node.type==="ChainExpression"){node=node.expression}else if(node.type==="CallExpression"&&node.callee.type==="Identifier"&&node.callee.name==="String"&&node.arguments.length===1){node=node.arguments[0]}else{return node}}}function memberChain(node){const path=[];let current=unwrap(node);while(current.type==="MemberExpression"){const key=(0,eslint_devkit_1.propertyName)(current);if(key===null)return void 0;path.unshift(key);current=unwrap(current.object)}return current.type==="Identifier"?{root:current.name,path}:void 0}const startsWith=(path,prefix)=>prefix.every((segment,i)=>path[i]===segment);function bindDeclarator(declarator,bindings){const chain=declarator.init===null?void 0:memberChain(declarator.init);const toArgs=chain&&bindings.roots.get(chain.root);if(toArgs===void 0)return;if(startsWith(toArgs,chain.path)){bindPattern(declarator.id,toArgs.slice(chain.path.length),bindings)}else if(startsWith(chain.path,toArgs)){const inside=chain.path.slice(toArgs.length);bindPattern(declarator.id,[],bindings,inside[0])}}function isCallToolMethod(node,scope){if(node===void 0)return false;if((0,eslint_devkit_1.staticString)(node)==="tools/call")return true;const binding=(0,eslint_devkit_1.resolveModuleBinding)(node,scope);return binding!==void 0&&binding.module.startsWith("@modelcontextprotocol/")&&binding.path[binding.path.length-1]==="CallToolRequestSchema"}exports.noCommandInjectionInTool=(0,eslint_devkit_1.createRule)({name:"no-command-injection-in-tool",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-mcp-sdk-security/docs/rules/no-command-injection-in-tool.md",description:"Disallow an MCP tool argument being used directly as the command in a child_process call",cwe:"CWE-78",cvss:9.8},messages:{toolArgToShell:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"MCP Tool Argument Reaches a Process Sink",cwe:"CWE-78",owasp:"A03:2021",cvss:9.8,description:"Tool argument `{{arg}}` is passed straight to `{{sink}}()`, so whatever steers the model chooses what runs on this host",severity:"CRITICAL",compliance:["SOC2","NIST-CSF"],fix:"Do not let the argument name the command. Map it through a fixed allowlist of permitted operations, and pass user data as an argv array element \u2014 `execFile(ALLOWED[op], [value])` \u2014 never as the executable.",documentationLink:"https://modelcontextprotocol.io/docs/concepts/tools"})},schema:[]},defaultOptions:[],create(context){if(!(0,mcp_evidence_1.fileUsesMcpSdk)(context.sourceCode.ast))return{};const handlers=[];const declarators=[];const candidates=[];function sinkOf(callee,scope,seen=new Set){if(seen.has(callee))return void 0;seen.add(callee);const binding=(0,eslint_devkit_1.resolveModuleBinding)(callee,scope);if(binding!==void 0){const[name,extra]=binding.path;if(extra!==void 0)return void 0;if(binding.module==="child_process")return name!==void 0&&PROCESS_SINKS.has(name)?name:void 0;if(binding.module==="execa")return name===void 0?"execa":EXECA_SINKS.has(name)?name:void 0;return void 0}if(callee.type!=="Identifier")return void 0;const init=(0,tool_registration_1.constInitializer)(callee,scope);if(init?.type!=="CallExpression")return void 0;const wrapper=(0,eslint_devkit_1.resolveModuleBinding)(init.callee,scope);const wrapped=init.arguments[0];if(wrapper?.module!=="util"||wrapper.path.join(".")!=="promisify"||wrapped===void 0)return void 0;return sinkOf(wrapped,scope,seen)}function commandPositions(node,sink){const positions=[];const[file,argv]=node.arguments;if(file===void 0)return positions;positions.push(file);const shell=(0,eslint_devkit_1.staticString)(file)?.split(/[\\/]/).pop();if(ARGV_SINKS.has(sink)&&shell!==void 0&&SHELLS.has(shell)&&argv?.type==="ArrayExpression"){const flag=argv.elements.findIndex(el=>el!==null&&SHELL_SCRIPT_FLAGS.has((0,eslint_devkit_1.staticString)(el)??""));const script=flag===-1?void 0:argv.elements[flag+1];if(script&&script.type!=="SpreadElement")positions.push(script)}return positions}function enclosingHandler(node){let innermost;for(const h of handlers){const[start,end]=h.fn.range;if(node.range[0]<start||node.range[1]>end)continue;if(innermost===void 0||end-start<innermost.fn.range[1]-innermost.fn.range[0])innermost=h}return innermost}function bindingsOf(handler){if(handler.bindings)return handler.bindings;const bindings={direct:new Map,roots:new Map};const first=handler.fn.params[0];if(first!==void 0)bindPattern(first,handler.toArgs,bindings);for(const declarator of declarators){if(enclosingHandler(declarator)===handler)bindDeclarator(declarator,bindings)}handler.bindings=bindings;return bindings}function argumentRead(expression,bindings){const node=unwrap(expression);if(node.type==="Identifier"){const key=bindings.direct.get(node.name);return key===void 0?void 0:{text:node.name,key}}const chain=memberChain(node);const toArgs=chain&&bindings.roots.get(chain.root);if(toArgs===void 0||chain.path.length!==toArgs.length+1||!startsWith(chain.path,toArgs))return void 0;return{text:[chain.root,...chain.path].join("."),key:chain.path[toArgs.length]}}return{VariableDeclarator(node){declarators.push(node)},CallExpression(node){const scope=context.sourceCode.getScope(node);const registration=(0,tool_registration_1.readRegistration)(node);if(registration!==void 0){const fn=(0,tool_registration_1.resolveFunction)(registration.handler,scope);if(fn!==void 0){const closed=new Set;const fields=registration.schema.kind==="schema"?(0,tool_registration_1.schemaFields)(registration.schema.node):void 0;for(const[key,value]of fields?.fields??[]){if((0,tool_registration_1.isClosedSetSchema)(value))closed.add(key)}handlers.push({fn,toArgs:[],closed})}}else if(node.callee.type==="MemberExpression"&&(0,eslint_devkit_1.propertyName)(node.callee)==="setRequestHandler"&&isCallToolMethod(node.arguments[0],scope)){const fn=(0,tool_registration_1.resolveFunction)(node.arguments[1],scope);if(fn!==void 0)handlers.push({fn,toArgs:CALL_TOOL_ARGS_PATH,closed:new Set})}const sink=sinkOf(node.callee,scope);if(sink===void 0)return;for(const position of commandPositions(node,sink)){if(!isBuiltString(position))candidates.push({node:position,sink})}},"Program:exit"(){for(const candidate of candidates){const handler=enclosingHandler(candidate.node);if(handler===void 0)continue;const read=argumentRead(candidate.node,bindingsOf(handler));if(read===void 0||handler.closed.has(read.key))continue;context.report({node:candidate.node,messageId:"toolArgToShell",data:{arg:read.text,sink:candidate.sink}})}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noToolDescriptionInjection=void 0;exports.isStaticText=isStaticText;exports.modelFacingProperties=modelFacingProperties;const eslint_devkit_1=require("@interlace/eslint-devkit");const mcp_evidence_1=require("../../utils/mcp-evidence");const
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noToolDescriptionInjection=void 0;exports.isStaticText=isStaticText;exports.modelFacingProperties=modelFacingProperties;const eslint_devkit_1=require("@interlace/eslint-devkit");const mcp_evidence_1=require("../../utils/mcp-evidence");const tool_registration_1=require("../../utils/tool-registration");const MODEL_FACING_KEYS=["description","title"];const METADATA_CONFIG_INDEX={registerPrompt:[1,"prompt"],registerResource:[2,"resource"]};function unwrapTypeOnly(node){let current=node;while(current.type==="TSAsExpression"||current.type==="TSSatisfiesExpression"||current.type==="TSTypeAssertion"||current.type==="TSNonNullExpression"){current=current.expression}return current}function isStaticText(node,scope,seen=new Set){node=unwrapTypeOnly(node);if(seen.has(node))return false;seen.add(node);if(node.type==="Literal")return typeof node.value==="string";if(node.type==="TemplateLiteral")return node.expressions.length===0;if(node.type==="TaggedTemplateExpression")return node.quasi.expressions.length===0;if(node.type==="BinaryExpression"&&node.operator==="+"){return isStaticText(node.left,scope,seen)&&isStaticText(node.right,scope,seen)}if(node.type==="CallExpression")return isStaticJoin(node,scope,seen);if(scope===void 0)return false;if(node.type==="Identifier"){const init=(0,tool_registration_1.constInitializer)(node,scope);return init!==void 0&&isStaticText(init,scope,seen)}if(node.type==="MemberExpression"){const value=constObjectProperty(node,scope,seen);return value!==void 0&&isStaticText(value,scope,seen)}return false}function isStaticJoin(node,scope,seen){if(node.callee.type!=="MemberExpression")return false;if((0,eslint_devkit_1.propertyName)(node.callee)!=="join")return false;const array=node.callee.object;if(array.type!=="ArrayExpression")return false;if(node.arguments.length>1)return false;const separator=node.arguments[0];if(separator!==void 0&&!isStaticText(separator,scope,seen))return false;return array.elements.every(element=>element!==null&&element.type!=="SpreadElement"&&isStaticText(element,scope,seen))}function constObjectProperty(node,scope,seen){const key=(0,eslint_devkit_1.propertyName)(node);if(key===null)return void 0;let object=unwrapTypeOnly(node.object);if(object.type==="MemberExpression"){const inner=constObjectProperty(object,scope,seen);if(inner===void 0)return void 0;object=unwrapTypeOnly(inner)}else if(object.type==="Identifier"){const init=(0,tool_registration_1.constInitializer)(object,scope);if(init===void 0)return void 0;object=unwrapTypeOnly(init)}if(object.type!=="ObjectExpression")return void 0;let value;for(const prop of object.properties){if(prop.type==="SpreadElement"){value=void 0;continue}if(prop.computed)continue;const name=prop.key.type==="Identifier"?prop.key.name:(0,eslint_devkit_1.staticString)(prop.key);if(name===key)value=prop.value}return value}function modelFacingProperties(config,scope){const found=[];for(const prop of config.properties){if(prop.type!=="Property"||prop.computed)continue;const key=prop.key.type==="Identifier"?prop.key.name:(0,eslint_devkit_1.staticString)(prop.key)??void 0;if(key===void 0)continue;if(!MODEL_FACING_KEYS.includes(key))continue;if(isStaticText(prop.value,scope))continue;found.push({key,value:prop.value})}return found}exports.noToolDescriptionInjection=(0,eslint_devkit_1.createRule)({name:"no-tool-description-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-mcp-sdk-security/docs/rules/no-tool-description-injection.md",description:"Require MCP tool descriptions and titles to be static text, since they reach the model as instructions",cwe:"CWE-1427",cvss:8.6},messages:{dynamicDescription:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"MCP Tool Description Built at Runtime",cwe:"CWE-1427",owasp:"A03:2021",cvss:8.6,description:'The `{{key}}` for tool "{{tool}}" is assembled at runtime, so it reaches the model as instruction text this file does not control',severity:"HIGH",compliance:["SOC2"],fix:"Write the {{key}} as a literal. If it genuinely varies, register a separate tool per variant rather than interpolating \u2014 the text lands in the model's instruction block, so whoever controls the value controls the instructions.",documentationLink:"https://modelcontextprotocol.io/docs/concepts/tools"}),dynamicMetadata:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"MCP Prompt/Resource Description Built at Runtime",cwe:"CWE-1427",owasp:"A03:2021",cvss:8.6,description:'The `{{key}}` for {{kind}} "{{name}}" is assembled at runtime, so it reaches the model as text this file does not control',severity:"HIGH",compliance:["SOC2"],fix:"Write the {{key}} as a literal, or a const of literals in this file \u2014 whoever controls the value controls what the model reads.",documentationLink:"https://modelcontextprotocol.io/docs/concepts/prompts"})},schema:[]},defaultOptions:[],create(context){if(!(0,mcp_evidence_1.fileUsesMcpSdk)(context.sourceCode.ast))return{};const candidates=[];return{CallExpression(node){const scope=context.sourceCode.getScope(node);const tool=(0,tool_registration_1.toolNameOf)(node);const registration=(0,tool_registration_1.readRegistration)(node);if(registration!==void 0){const objects=[];if(registration.config)objects.push(registration.config);if(registration.annotations&&(0,tool_registration_1.classifyLegacyObject)(registration.annotations)!=="shape")objects.push(registration.annotations);for(const config2 of objects){for(const finding of modelFacingProperties(config2,scope)){candidates.push({node:finding.value,messageId:"dynamicDescription",data:{tool,key:finding.key}})}}if(registration.description&&!isStaticText(registration.description,scope)){candidates.push({node:registration.description,messageId:"dynamicDescription",data:{tool,key:"description"}})}return}const method=(0,tool_registration_1.calledMethod)(node);const slot=method===null?void 0:METADATA_CONFIG_INDEX[method];if(slot===void 0)return;const[index,kind]=slot;const config=node.arguments[index];if(config?.type!=="ObjectExpression")return;for(const finding of modelFacingProperties(config,scope)){candidates.push({node:finding.value,messageId:"dynamicMetadata",data:{kind,name:tool,key:finding.key}})}},"Program:exit"(){for(const{node,messageId,data}of candidates){context.report({node,messageId,data})}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noUnvalidatedToolArgs=
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noUnvalidatedToolArgs=exports.propertyKey=void 0;exports.declaredSchemaKeys=declaredSchemaKeys;exports.destructuredArgNames=destructuredArgNames;const eslint_devkit_1=require("@interlace/eslint-devkit");const mcp_evidence_1=require("../../utils/mcp-evidence");const tool_registration_1=require("../../utils/tool-registration");Object.defineProperty(exports,"propertyKey",{enumerable:true,get:function(){return tool_registration_1.propertyKey}});function declaredSchemaKeys(config){const schema=(0,tool_registration_1.configSchema)(config);if(schema.kind!=="schema")return void 0;const read=(0,tool_registration_1.schemaFields)(schema.node);return read===void 0?void 0:new Set(read.fields.keys())}function destructuredArgNames(handler){if(handler.type!=="ArrowFunctionExpression"&&handler.type!=="FunctionExpression"&&handler.type!=="FunctionDeclaration"){return[]}const first=handler.params[0];if(first===void 0||first.type!=="ObjectPattern")return[];const found=[];for(const prop of first.properties){if(prop.type==="RestElement")continue;const key=(0,tool_registration_1.propertyKey)(prop);if(key===void 0)continue;found.push({name:key,node:prop})}return found}exports.noUnvalidatedToolArgs=(0,eslint_devkit_1.createRule)({name:"no-unvalidated-tool-args",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-mcp-sdk-security/docs/rules/no-unvalidated-tool-args.md",description:"Disallow a tool handler reading an argument its declared input schema does not include",cwe:"CWE-20",cvss:7.5},messages:{undeclaredArg:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"MCP Tool Argument Outside the Declared Schema",cwe:"CWE-20",owasp:"A03:2021",cvss:7.5,description:'Tool "{{tool}}" reads `{{arg}}`, which its inputSchema does not declare \u2014 so the value either arrives unvalidated or never arrives at all',severity:"HIGH",compliance:["SOC2"],fix:"Declare `{{arg}}` in the inputSchema with the type and constraints it needs, or stop reading it. A key the schema does not mention is one nothing validated.",documentationLink:"https://modelcontextprotocol.io/docs/concepts/tools"}),undeclaredArgPassthrough:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"MCP Tool Argument Passed Through Unvalidated",cwe:"CWE-20",owasp:"A03:2021",cvss:7.5,description:'Tool "{{tool}}" reads `{{arg}}`, which its inputSchema does not declare, and the schema is loose (passthrough) \u2014 so the value reaches the handler exactly as the model sent it',severity:"HIGH",compliance:["SOC2"],fix:"Declare `{{arg}}` in the inputSchema with the type and constraints it needs. A loose schema validates the declared keys and waves every other key through.",documentationLink:"https://modelcontextprotocol.io/docs/concepts/tools"})},schema:[]},defaultOptions:[],create(context){if(!(0,mcp_evidence_1.fileUsesMcpSdk)(context.sourceCode.ast))return{};const candidates=[];return{CallExpression(node){const registration=(0,tool_registration_1.readRegistration)(node);if(registration?.schema.kind!=="schema")return;const declared=(0,tool_registration_1.schemaFields)(registration.schema.node);if(declared===void 0)return;const handler=(0,tool_registration_1.resolveFunction)(registration.handler,context.sourceCode.getScope(node));if(handler===void 0)return;for(const read of destructuredArgNames(handler)){if(declared.fields.has(read.name))continue;candidates.push({node:read.node,tool:(0,tool_registration_1.toolNameOf)(node),arg:read.name,messageId:declared.loose?"undeclaredArgPassthrough":"undeclaredArg"})}},"Program:exit"(){for(const{node,tool,arg,messageId}of candidates){context.report({node,messageId,data:{tool,arg}})}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireToolInputSchema=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const mcp_evidence_1=require("../../utils/mcp-evidence");const
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireToolInputSchema=void 0;exports.argumentRead=argumentRead;const eslint_devkit_1=require("@interlace/eslint-devkit");const mcp_evidence_1=require("../../utils/mcp-evidence");const tool_registration_1=require("../../utils/tool-registration");function argumentRead(fn,declaredVariables){let first=fn.params[0];if(first?.type==="AssignmentPattern")first=first.left;if(fn.params.length>=2){return first?.type==="Identifier"?first.name:"args"}if(first?.type==="ObjectPattern"){for(const prop of first.properties){const key=(0,tool_registration_1.propertyKey)(prop);if(key!==void 0&&!tool_registration_1.HANDLER_CONTEXT_KEYS.has(key))return key}return void 0}if(first?.type!=="Identifier")return void 0;const variable=declaredVariables(fn).find(v=>v.name===first.name);for(const ref of variable.references){const parent=ref.identifier.parent;if(parent?.type!=="MemberExpression"||parent.object!==ref.identifier)continue;const key=(0,eslint_devkit_1.propertyName)(parent);if(key!==null&&!tool_registration_1.HANDLER_CONTEXT_KEYS.has(key))return`${first.name}.${key}`}return void 0}exports.requireToolInputSchema=(0,eslint_devkit_1.createRule)({name:"require-tool-input-schema",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-mcp-sdk-security/docs/rules/require-tool-input-schema.md",description:"Require an input schema when an MCP tool handler reads arguments",cwe:"CWE-20",cvss:5.3},messages:{missingInputSchema:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"MCP Tool Handler Reads Arguments No Schema Declares",cwe:"CWE-20",owasp:"A03:2021",cvss:5.3,description:'Tool "{{tool}}" declares no inputSchema, yet its handler reads `{{arg}}`. Without a schema the SDK passes the request context there, not the client\'s arguments \u2014 nothing declared or validated what the handler expects',severity:"MEDIUM",compliance:["SOC2"],fix:'Declare the arguments the handler reads: registerTool("{{tool}}", { inputSchema: { path: z.string() } }, handler)',documentationLink:"https://modelcontextprotocol.io/docs/concepts/tools"})},schema:[]},defaultOptions:[],create(context){if(!(0,mcp_evidence_1.fileUsesMcpSdk)(context.sourceCode.ast))return{};const candidates=[];return{CallExpression(node){const registration=(0,tool_registration_1.readRegistration)(node);if(registration?.schema.kind!=="none")return;const fn=(0,tool_registration_1.resolveFunction)(registration.handler,context.sourceCode.getScope(node));if(fn===void 0)return;const arg=argumentRead(fn,n=>context.sourceCode.getDeclaredVariables(n));if(arg!==void 0)candidates.push({node,tool:(0,tool_registration_1.toolNameOf)(node),arg})},"Program:exit"(){for(const{node,tool,arg}of candidates){context.report({node,messageId:"missingInputSchema",data:{tool,arg}})}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.fileUsesMcpSdk=exports.MCP_SDK_PACKAGE=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");exports.MCP_SDK_PACKAGE="@modelcontextprotocol/sdk";exports.fileUsesMcpSdk=(0,eslint_devkit_1.createModuleEvidence)({packages:[exports.
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.fileUsesMcpSdk=exports.MCP_PACKAGES=exports.MCP_SDK_PACKAGE=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");exports.MCP_SDK_PACKAGE="@modelcontextprotocol/sdk";exports.MCP_PACKAGES=[exports.MCP_SDK_PACKAGE,"@modelcontextprotocol/server","@modelcontextprotocol/client","@modelcontextprotocol/core","@modelcontextprotocol/node","@modelcontextprotocol/express","@modelcontextprotocol/hono","@modelcontextprotocol/fastify","mcp-handler","@vercel/mcp-adapter"];exports.fileUsesMcpSdk=(0,eslint_devkit_1.createModuleEvidence)({packages:[...exports.MCP_PACKAGES]});
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.HANDLER_CONTEXT_KEYS=exports.LEGACY_TOOL=exports.REGISTER_TOOL=void 0;exports.isFunctionNode=isFunctionNode;exports.lookupVariable=lookupVariable;exports.constInitializer=constInitializer;exports.resolveFunction=resolveFunction;exports.classifyLegacyObject=classifyLegacyObject;exports.calledMethod=calledMethod;exports.toolNameOf=toolNameOf;exports.readRegistration=readRegistration;exports.configSchema=configSchema;exports.propertyKey=propertyKey;exports.schemaFields=schemaFields;exports.isClosedSetSchema=isClosedSetSchema;const eslint_devkit_1=require("@interlace/eslint-devkit");exports.REGISTER_TOOL="registerTool";exports.LEGACY_TOOL="tool";function isFunctionNode(node){return node?.type==="ArrowFunctionExpression"||node?.type==="FunctionExpression"||node?.type==="FunctionDeclaration"}function lookupVariable(name,scope){for(let current=scope;current;current=current.upper){const variable=current.set.get(name);if(variable)return variable}return void 0}function constInitializer(node,scope){const def=lookupVariable(node.name,scope)?.defs[0];if(def?.type!=="Variable")return void 0;if(def.parent.kind!=="const")return void 0;if(def.node.id.type!=="Identifier")return void 0;return def.node.init??void 0}function resolveFunction(node,scope){if(node===void 0)return void 0;if(isFunctionNode(node))return node;if(node.type!=="Identifier")return void 0;const def=lookupVariable(node.name,scope)?.defs[0];if(def?.type==="FunctionName")return def.node;const init=constInitializer(node,scope);return isFunctionNode(init)?init:void 0}function classifyLegacyObject(node){if(node.properties.length===0)return"shape";let calls=0;let literals=0;for(const prop of node.properties){if(prop.type!=="Property"||prop.computed)return"unknown";const value=prop.value;if(value.type==="CallExpression")calls++;else if(value.type==="Literal"||value.type==="TemplateLiteral")literals++}if(calls===node.properties.length)return"shape";if(literals===node.properties.length)return"annotations";return"unknown"}function isStringShaped(node){return node.type==="Literal"&&typeof node.value==="string"||node.type==="TemplateLiteral"||node.type==="TaggedTemplateExpression"||node.type==="BinaryExpression"&&node.operator==="+"}function calledMethod(node){if(node.callee.type!=="MemberExpression")return null;return(0,eslint_devkit_1.propertyName)(node.callee)}function toolNameOf(node){return(0,eslint_devkit_1.staticString)(node.arguments[0])??"unknown"}function readRegistration(node){const method=calledMethod(node);const args=node.arguments;if(method===exports.REGISTER_TOOL){const config=args[1];const handler2=args.length>=3?args[args.length-1]:void 0;if(config?.type!=="ObjectExpression"){return{method,call:node,schema:{kind:"unknown"},handler:handler2}}return{method,call:node,config,schema:configSchema(config),handler:handler2}}if(method!==exports.LEGACY_TOOL||args.length<2)return void 0;const handler=args[args.length-1];const last=args.length-1;const registration={method,call:node,schema:{kind:"none"},handler};let index=1;const first=args[1];if(index<last&&first.type!=="ObjectExpression"&&!isFunctionNode(first)&&(isStringShaped(first)||args.length>=4)){registration.description=first;index=2}if(index<last){const slot=args[index];if(slot.type!=="ObjectExpression"){registration.schema={kind:"unknown"}}else{const kind=classifyLegacyObject(slot);if(kind==="shape"){registration.schema={kind:"schema",node:slot};const next=args[index+1];if(index+1<last&&next.type==="ObjectExpression")registration.annotations=next}else if(kind==="annotations"){registration.annotations=slot}else{registration.schema={kind:"unknown"}}}}return registration}function configSchema(config){let state={kind:"none"};for(const prop of config.properties){if(prop.type==="SpreadElement"){state={kind:"unknown"};continue}if((0,eslint_devkit_1.objectKeyName)(prop)==="inputSchema")state={kind:"schema",node:prop.value}}return state}function propertyKey(prop){if(prop.type!=="Property")return void 0;return(0,eslint_devkit_1.objectKeyName)(prop)??void 0}const KEY_PRESERVING=new Set(["strict","strip","describe","partial","required","readonly","meta"]);const LOOSENING=new Set(["passthrough","loose"]);const OBJECT_CONSTRUCTORS=new Set(["object","strictObject"]);const LOOSE_CONSTRUCTORS=new Set(["looseObject"]);function schemaFields(node){let loose=false;let current=node;while(current.type==="CallExpression"){if(current.callee.type!=="MemberExpression")return void 0;const method=(0,eslint_devkit_1.propertyName)(current.callee);if(method===null)return void 0;if(OBJECT_CONSTRUCTORS.has(method)||LOOSE_CONSTRUCTORS.has(method)){if(LOOSE_CONSTRUCTORS.has(method))loose=true;const shape=current.arguments[0];if(current.arguments.length!==1||shape?.type!=="ObjectExpression")return void 0;current=shape;break}if(LOOSENING.has(method))loose=true;else if(!KEY_PRESERVING.has(method))return void 0;current=current.callee.object}if(current.type!=="ObjectExpression")return void 0;const fields=new Map;for(const entry of current.properties){if(entry.type==="SpreadElement")return void 0;const key=propertyKey(entry);if(key===void 0)return void 0;fields.set(key,entry.value)}return{fields,loose}}function isClosedSetSchema(node){let current=node;let innermost=null;while(current.type==="CallExpression"&¤t.callee.type==="MemberExpression"){innermost=(0,eslint_devkit_1.propertyName)(current.callee);current=current.callee.object}return innermost==="enum"||innermost==="literal"||innermost==="nativeEnum"}exports.HANDLER_CONTEXT_KEYS=new Set(["signal","authInfo","sessionId","_meta","requestId","requestInfo","sendNotification","sendRequest","taskStore","taskId","taskRequestedTtl","closeSSEStream","closeStandaloneSSEStream","mcpReq","http"]);
|