eslint-plugin-mcp-sdk-security 0.3.0 → 0.4.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/README.md
CHANGED
|
@@ -1,11 +1,11 @@
|
|
|
1
1
|
<p align="center">
|
|
2
|
-
<a href="https://eslint.interlace.tools/?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security" target="blank"><img src="https://eslint.interlace.tools/logos/interlace.svg" alt="Interlace" height="90" /></a>
|
|
2
|
+
<a href="https://eslint.interlace.tools/?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security" target="blank"><picture><source media="(prefers-color-scheme: dark)" srcset="https://eslint.interlace.tools/logos/interlace-dark.svg"><img src="https://eslint.interlace.tools/logos/interlace-light.svg" alt="Interlace" height="90" /></picture></a>
|
|
3
3
|
|
|
4
4
|
<a href="https://modelcontextprotocol.io" target="_blank"><img src="https://eslint.interlace.tools/logos/mcp.svg" alt="Model Context Protocol" height="90" /></a>
|
|
5
5
|
|
|
6
|
-
<a href="https://oxc.rs" target="_blank"><img src="https://eslint.interlace.tools/logos/oxlint.svg" alt="oxlint" height="90" /></a>
|
|
6
|
+
<a href="https://oxc.rs" target="_blank"><picture><source media="(prefers-color-scheme: dark)" srcset="https://eslint.interlace.tools/logos/oxlint-dark.svg"><img src="https://eslint.interlace.tools/logos/oxlint-light.svg" alt="oxlint" height="90" /></picture></a>
|
|
7
7
|
|
|
8
|
-
<a href="https://eslint.org" target="_blank"><img src="https://eslint.interlace.tools/logos/eslint.svg" alt="ESLint" height="90" /></a>
|
|
8
|
+
<a href="https://eslint.org" target="_blank"><picture><source media="(prefers-color-scheme: dark)" srcset="https://eslint.interlace.tools/logos/eslint-dark.svg"><img src="https://eslint.interlace.tools/logos/eslint-light.svg" alt="ESLint" height="90" /></picture></a>
|
|
9
9
|
</p>
|
|
10
10
|
|
|
11
11
|
<p align="center">
|
|
@@ -27,18 +27,25 @@ Security rules for code built on [`@modelcontextprotocol/sdk`](https://www.npmjs
|
|
|
27
27
|
|
|
28
28
|
**Scope:** this plugin lints the MCP **SDK's API shapes** — `registerTool`, transports, handler signatures. It does not inspect MCP wire traffic, which isn't visible from source. Every rule gates on the SDK actually being imported, so it stays silent in files that don't use MCP.
|
|
29
29
|
|
|
30
|
-
|
|
30
|
+
<!-- AUTO-GENERATED:DOCTRINE:START - Do not edit manually -->
|
|
31
31
|
|
|
32
|
-
|
|
32
|
+
- **Why** — a linter nobody reads protects nothing. We would rather miss a finding
|
|
33
|
+
than spend your attention on one that was never real.
|
|
34
|
+
- **How** — evidence, not names. A rule fires on what the code *does*, resolved
|
|
35
|
+
through the AST and ESLint's own scope analysis.
|
|
36
|
+
- **What** — every finding carries its fix, in prose for a human and as structured
|
|
37
|
+
JSON for an agent. Security rules add a CWE mapping and, where assigned, a CVSS score.
|
|
38
|
+
|
|
39
|
+
That trade costs recall, and we measure it:
|
|
40
|
+
[methodology](https://github.com/ofri-peretz/eslint/blob/main/BENCHMARK-METHODOLOGY.md)
|
|
41
|
+
· [results](https://github.com/ofri-peretz/eslint/blob/main/BENCHMARK-RESULTS.md)
|
|
42
|
+
· [a false positive is a bug](https://github.com/ofri-peretz/eslint/issues).
|
|
43
|
+
|
|
44
|
+
<!-- AUTO-GENERATED:DOCTRINE:END -->
|
|
33
45
|
|
|
34
46
|
## Getting Started
|
|
35
47
|
|
|
36
48
|
- To check out the [guide](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security), visit [eslint.interlace.tools](https://eslint.interlace.tools/?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security). 📚
|
|
37
|
-
- 要查看中文 [指南](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security), 请访问 [eslint.interlace.tools](https://eslint.interlace.tools/?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security). 📚
|
|
38
|
-
- [가이드](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security) 문서는 [eslint.interlace.tools](https://eslint.interlace.tools/?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security)에서 확인하실 수 있습니다. 📚
|
|
39
|
-
- [ガイド](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security)は [eslint.interlace.tools](https://eslint.interlace.tools/?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security)でご確認ください。 📚
|
|
40
|
-
- Para ver la [guía](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security), visita [eslint.interlace.tools](https://eslint.interlace.tools/?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security). 📚
|
|
41
|
-
- للاطلاع على [الدليل](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security)، قم بزيارة [eslint.interlace.tools](https://eslint.interlace.tools/?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security). 📚
|
|
42
49
|
|
|
43
50
|
```bash
|
|
44
51
|
npm install eslint-plugin-mcp-sdk-security --save-dev
|
|
@@ -111,10 +118,14 @@ See the [ESLint Version Support Policy](../../docs/ESLINT_VERSION_SUPPORT.md) fo
|
|
|
111
118
|
| 🟡 | **Type-aware (refining)**: pure-AST primary path; types refine precision. |
|
|
112
119
|
| 🟠 | **Type-aware (graceful)**: requires TS program; silent without it. |
|
|
113
120
|
|
|
121
|
+
<!-- AUTO-GENERATED:RULES_TABLE:START - Do not edit manually -->
|
|
114
122
|
| Rule | CWE | OWASP | CVSS | Description | 🧠 | 💼 | ⚠️ | 🔧 | 💡 | 🚫 |
|
|
115
|
-
| :--- |
|
|
116
|
-
| [
|
|
117
|
-
|
|
123
|
+
| :--- | :---: | :---: | :---: | :--- | :---: | :---: | :---: | :---: | :---: | :---: |
|
|
124
|
+
| [no-command-injection-in-tool](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security/rules/no-command-injection-in-tool?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security) | CWE-78 | A03:2021 | | Disallow an MCP tool argument being used directly as the command in a child_process call. | 🟢 | | | | | |
|
|
125
|
+
| [no-tool-description-injection](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security/rules/no-tool-description-injection?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security) | CWE-1427 | A03:2021 | | Require MCP tool descriptions and titles to be static text, since they reach the model as instructions. | 🟢 | | | | | |
|
|
126
|
+
| [no-unvalidated-tool-args](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security/rules/no-unvalidated-tool-args?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security) | CWE-20 | A03:2021 | | Disallow a tool handler reading an argument its declared input schema does not include. | 🟢 | | | | | |
|
|
127
|
+
| [require-tool-input-schema](https://eslint.interlace.tools/docs/security/plugin-mcp-sdk-security/rules/require-tool-input-schema?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security) | CWE-20 | A03:2021 | | Require an input schema when registering an MCP tool | 🟢 | | | | | |
|
|
128
|
+
<!-- AUTO-GENERATED:RULES_TABLE:END -->
|
|
118
129
|
<!-- INTERLACE:STAR_CTA:START -->
|
|
119
130
|
## ⭐ Support & follow
|
|
120
131
|
|
|
@@ -124,19 +135,52 @@ If this plugin caught a real bug for you, **[star the repo](https://github.com/o
|
|
|
124
135
|
|
|
125
136
|
<!-- INTERLACE:STAR_CTA:END -->
|
|
126
137
|
|
|
138
|
+
<!-- AUTO-GENERATED:ECOSYSTEM_TABLE:START - Do not edit manually -->
|
|
139
|
+
|
|
127
140
|
## 🔗 Related ESLint Plugins
|
|
128
141
|
|
|
129
|
-
Part of the **Interlace ESLint
|
|
142
|
+
Part of the **Interlace ESLint ecosystem** — AI-native rules with LLM-optimized error messages:
|
|
143
|
+
|
|
144
|
+
**Security**
|
|
130
145
|
|
|
131
146
|
| Plugin | Downloads | Description |
|
|
132
147
|
| :--- | :---: | :--- |
|
|
133
|
-
| [`eslint-plugin-
|
|
134
|
-
| [`eslint-plugin-
|
|
135
|
-
| [`eslint-plugin-
|
|
148
|
+
| [`eslint-plugin-anthropic-security`](https://www.npmjs.com/package/eslint-plugin-anthropic-security) | [](https://www.npmjs.com/package/eslint-plugin-anthropic-security) | Anthropic SDK security. |
|
|
149
|
+
| [`eslint-plugin-browser-security`](https://www.npmjs.com/package/eslint-plugin-browser-security) | [](https://www.npmjs.com/package/eslint-plugin-browser-security) | XSS, DOM security. |
|
|
150
|
+
| [`eslint-plugin-drizzle-security`](https://www.npmjs.com/package/eslint-plugin-drizzle-security) | [](https://www.npmjs.com/package/eslint-plugin-drizzle-security) | Drizzle security. |
|
|
151
|
+
| [`eslint-plugin-express-security`](https://www.npmjs.com/package/eslint-plugin-express-security) | [](https://www.npmjs.com/package/eslint-plugin-express-security) | Express middleware hardening. |
|
|
136
152
|
| [`eslint-plugin-gemini-security`](https://www.npmjs.com/package/eslint-plugin-gemini-security) | [](https://www.npmjs.com/package/eslint-plugin-gemini-security) | Google Gemini SDK security. |
|
|
137
|
-
| [`eslint-plugin-
|
|
138
|
-
| [`eslint-plugin-
|
|
139
|
-
| [`eslint-plugin-
|
|
153
|
+
| [`eslint-plugin-jwt-security`](https://www.npmjs.com/package/eslint-plugin-jwt-security) | [](https://www.npmjs.com/package/eslint-plugin-jwt-security) | Token security. |
|
|
154
|
+
| [`eslint-plugin-knex-security`](https://www.npmjs.com/package/eslint-plugin-knex-security) | [](https://www.npmjs.com/package/eslint-plugin-knex-security) | Knex security. |
|
|
155
|
+
| [`eslint-plugin-lambda-security`](https://www.npmjs.com/package/eslint-plugin-lambda-security) | [](https://www.npmjs.com/package/eslint-plugin-lambda-security) | AWS Lambda hardening. |
|
|
156
|
+
| [`eslint-plugin-mongodb-security`](https://www.npmjs.com/package/eslint-plugin-mongodb-security) | [](https://www.npmjs.com/package/eslint-plugin-mongodb-security) | MongoDB injection. |
|
|
157
|
+
| [`eslint-plugin-mysql-security`](https://www.npmjs.com/package/eslint-plugin-mysql-security) | [](https://www.npmjs.com/package/eslint-plugin-mysql-security) | MySQL security. |
|
|
158
|
+
| [`eslint-plugin-nestjs-security`](https://www.npmjs.com/package/eslint-plugin-nestjs-security) | [](https://www.npmjs.com/package/eslint-plugin-nestjs-security) | NestJS framework hardening. |
|
|
159
|
+
| [`eslint-plugin-node-security`](https://www.npmjs.com/package/eslint-plugin-node-security) | [](https://www.npmjs.com/package/eslint-plugin-node-security) | Server-side patterns. |
|
|
160
|
+
| [`eslint-plugin-openai-security`](https://www.npmjs.com/package/eslint-plugin-openai-security) | [](https://www.npmjs.com/package/eslint-plugin-openai-security) | OpenAI SDK security. |
|
|
161
|
+
| [`eslint-plugin-postgresql-security`](https://www.npmjs.com/package/eslint-plugin-postgresql-security) | [](https://www.npmjs.com/package/eslint-plugin-postgresql-security) | PostgreSQL security. |
|
|
162
|
+
| [`eslint-plugin-prisma-security`](https://www.npmjs.com/package/eslint-plugin-prisma-security) | [](https://www.npmjs.com/package/eslint-plugin-prisma-security) | Prisma security. |
|
|
163
|
+
| [`eslint-plugin-secure-coding`](https://www.npmjs.com/package/eslint-plugin-secure-coding) | [](https://www.npmjs.com/package/eslint-plugin-secure-coding) | Injection prevention. |
|
|
164
|
+
| [`eslint-plugin-sequelize-security`](https://www.npmjs.com/package/eslint-plugin-sequelize-security) | [](https://www.npmjs.com/package/eslint-plugin-sequelize-security) | Sequelize ORM security. |
|
|
165
|
+
| [`eslint-plugin-sqlite-security`](https://www.npmjs.com/package/eslint-plugin-sqlite-security) | [](https://www.npmjs.com/package/eslint-plugin-sqlite-security) | SQLite security. |
|
|
166
|
+
| [`eslint-plugin-typeorm-security`](https://www.npmjs.com/package/eslint-plugin-typeorm-security) | [](https://www.npmjs.com/package/eslint-plugin-typeorm-security) | TypeORM security. |
|
|
167
|
+
| [`eslint-plugin-vercel-ai-security`](https://www.npmjs.com/package/eslint-plugin-vercel-ai-security) | [](https://www.npmjs.com/package/eslint-plugin-vercel-ai-security) | AI SDK security. |
|
|
168
|
+
|
|
169
|
+
**Code quality**
|
|
170
|
+
|
|
171
|
+
| Plugin | Downloads | Description |
|
|
172
|
+
| :--- | :---: | :--- |
|
|
173
|
+
| [`eslint-plugin-conventions`](https://www.npmjs.com/package/eslint-plugin-conventions) | [](https://www.npmjs.com/package/eslint-plugin-conventions) | Team-specific habits and styles. |
|
|
174
|
+
| [`eslint-plugin-import-next`](https://www.npmjs.com/package/eslint-plugin-import-next) | [](https://www.npmjs.com/package/eslint-plugin-import-next) | Fast cycle + import-graph analysis. |
|
|
175
|
+
| [`eslint-plugin-maintainability`](https://www.npmjs.com/package/eslint-plugin-maintainability) | [](https://www.npmjs.com/package/eslint-plugin-maintainability) | Cognitive load and clean-code patterns. |
|
|
176
|
+
| [`eslint-plugin-modernization`](https://www.npmjs.com/package/eslint-plugin-modernization) | [](https://www.npmjs.com/package/eslint-plugin-modernization) | ESNext migration + syntax evolution. |
|
|
177
|
+
| [`eslint-plugin-modularity`](https://www.npmjs.com/package/eslint-plugin-modularity) | [](https://www.npmjs.com/package/eslint-plugin-modularity) | Structural integrity and DDD patterns. |
|
|
178
|
+
| [`eslint-plugin-operability`](https://www.npmjs.com/package/eslint-plugin-operability) | [](https://www.npmjs.com/package/eslint-plugin-operability) | Production readiness and resource health. |
|
|
179
|
+
| [`eslint-plugin-react-a11y`](https://www.npmjs.com/package/eslint-plugin-react-a11y) | [](https://www.npmjs.com/package/eslint-plugin-react-a11y) | React accessibility / WCAG. |
|
|
180
|
+
| [`eslint-plugin-react-features`](https://www.npmjs.com/package/eslint-plugin-react-features) | [](https://www.npmjs.com/package/eslint-plugin-react-features) | React best practices and optimization. |
|
|
181
|
+
| [`eslint-plugin-reliability`](https://www.npmjs.com/package/eslint-plugin-reliability) | [](https://www.npmjs.com/package/eslint-plugin-reliability) | Runtime stability and error safety. |
|
|
182
|
+
|
|
183
|
+
<!-- AUTO-GENERATED:ECOSYSTEM_TABLE:END -->
|
|
140
184
|
|
|
141
185
|
## 📄 License
|
|
142
186
|
|
|
@@ -147,5 +191,5 @@ MIT © [Ofri Peretz](https://github.com/ofri-peretz)
|
|
|
147
191
|
</p>
|
|
148
192
|
|
|
149
193
|
<p align="center">
|
|
150
|
-
<a href="https://eslint.interlace.tools/?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security" target="blank"><img src="https://eslint.interlace.tools/
|
|
194
|
+
<a href="https://eslint.interlace.tools/?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-mcp-sdk-security" target="blank"><picture><source media="(prefers-color-scheme: dark)" srcset="https://eslint.interlace.tools/logos/interlace-dark.svg"><img src="https://eslint.interlace.tools/logos/interlace-light.svg" alt="Interlace" height="70" /></picture></a>
|
|
151
195
|
</p>
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "eslint-plugin-mcp-sdk-security",
|
|
3
|
-
"version": "0.
|
|
3
|
+
"version": "0.4.0",
|
|
4
4
|
"description": "ESLint plugin for Model Context Protocol (MCP) SDK security — catches tools registered without an input schema, handlers reading arguments the schema never declared, model-visible descriptions built from dynamic text, and tool arguments reaching a shell.",
|
|
5
5
|
"type": "commonjs",
|
|
6
6
|
"main": "./src/index.js",
|
|
@@ -74,7 +74,7 @@
|
|
|
74
74
|
}
|
|
75
75
|
},
|
|
76
76
|
"dependencies": {
|
|
77
|
-
"@interlace/eslint-devkit": "^1.
|
|
77
|
+
"@interlace/eslint-devkit": "^1.18.0"
|
|
78
78
|
},
|
|
79
79
|
"funding": {
|
|
80
80
|
"type": "github",
|
package/src/index.js
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=exports.requireToolInputSchema=exports.noUnvalidatedToolArgs=exports.noToolDescriptionInjection=exports.noCommandInjectionInTool=void 0;var no_command_injection_in_tool_2=require("./rules/no-command-injection-in-tool");Object.defineProperty(exports,"noCommandInjectionInTool",{enumerable:true,get:function(){return no_command_injection_in_tool_2.noCommandInjectionInTool}});var no_tool_description_injection_2=require("./rules/no-tool-description-injection");Object.defineProperty(exports,"noToolDescriptionInjection",{enumerable:true,get:function(){return no_tool_description_injection_2.noToolDescriptionInjection}});var no_unvalidated_tool_args_2=require("./rules/no-unvalidated-tool-args");Object.defineProperty(exports,"noUnvalidatedToolArgs",{enumerable:true,get:function(){return no_unvalidated_tool_args_2.noUnvalidatedToolArgs}});var require_tool_input_schema_2=require("./rules/require-tool-input-schema");Object.defineProperty(exports,"requireToolInputSchema",{enumerable:true,get:function(){return require_tool_input_schema_2.requireToolInputSchema}});exports.rules={get"no-command-injection-in-tool"(){return require("./rules/no-command-injection-in-tool").noCommandInjectionInTool},get"no-tool-description-injection"(){return require("./rules/no-tool-description-injection").noToolDescriptionInjection},get"no-unvalidated-tool-args"(){return require("./rules/no-unvalidated-tool-args").noUnvalidatedToolArgs},get"require-tool-input-schema"(){return require("./rules/require-tool-input-schema").requireToolInputSchema}};exports.plugin={meta:{name:"eslint-plugin-mcp-sdk-security",version:"0.
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=exports.requireToolInputSchema=exports.noUnvalidatedToolArgs=exports.noToolDescriptionInjection=exports.noCommandInjectionInTool=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");var no_command_injection_in_tool_2=require("./rules/no-command-injection-in-tool");Object.defineProperty(exports,"noCommandInjectionInTool",{enumerable:true,get:function(){return no_command_injection_in_tool_2.noCommandInjectionInTool}});var no_tool_description_injection_2=require("./rules/no-tool-description-injection");Object.defineProperty(exports,"noToolDescriptionInjection",{enumerable:true,get:function(){return no_tool_description_injection_2.noToolDescriptionInjection}});var no_unvalidated_tool_args_2=require("./rules/no-unvalidated-tool-args");Object.defineProperty(exports,"noUnvalidatedToolArgs",{enumerable:true,get:function(){return no_unvalidated_tool_args_2.noUnvalidatedToolArgs}});var require_tool_input_schema_2=require("./rules/require-tool-input-schema");Object.defineProperty(exports,"requireToolInputSchema",{enumerable:true,get:function(){return require_tool_input_schema_2.requireToolInputSchema}});exports.rules={get"no-command-injection-in-tool"(){return require("./rules/no-command-injection-in-tool").noCommandInjectionInTool},get"no-tool-description-injection"(){return require("./rules/no-tool-description-injection").noToolDescriptionInjection},get"no-unvalidated-tool-args"(){return require("./rules/no-unvalidated-tool-args").noUnvalidatedToolArgs},get"require-tool-input-schema"(){return require("./rules/require-tool-input-schema").requireToolInputSchema}};(0,eslint_devkit_1.withCanonicalDocsUrls)("plugin-mcp-sdk-security",exports.rules);exports.plugin={meta:{name:"eslint-plugin-mcp-sdk-security",version:"0.4.0"},rules:exports.rules};const minimalConfig={plugins:{"mcp-sdk-security":exports.plugin},rules:{"mcp-sdk-security/require-tool-input-schema":"error"}};const recommendedConfig={plugins:{"mcp-sdk-security":exports.plugin},rules:{"mcp-sdk-security/require-tool-input-schema":"error"}};const strictConfig={plugins:{"mcp-sdk-security":exports.plugin},rules:Object.fromEntries(Object.keys(exports.rules).map(ruleName=>[`mcp-sdk-security/${ruleName}`,"error"]))};exports.configs={minimal:minimalConfig,recommended:recommendedConfig,strict:strictConfig};exports.default={...exports.plugin,configs:exports.configs};
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noToolDescriptionInjection=void 0;exports.isStaticText=isStaticText;exports.modelFacingProperties=modelFacingProperties;const eslint_devkit_1=require("@interlace/eslint-devkit");const mcp_evidence_1=require("../../utils/mcp-evidence");const REGISTER_TOOL="registerTool";const LEGACY_TOOL="tool";const MODEL_FACING_KEYS=["description","title"];function isStaticText(node){if(node.type==="Literal")return typeof node.value==="string";if(node.type==="TemplateLiteral")return node.expressions.length===0;if(node.type==="BinaryExpression"&&node.operator==="+"){return isStaticText(node.left)&&isStaticText(node.right)}return false}function modelFacingProperties(config){const found=[];for(const prop of config.properties){if(prop.type!=="Property"||prop.computed)continue;const key=prop.key.type==="Identifier"?prop.key.name:
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noToolDescriptionInjection=void 0;exports.isStaticText=isStaticText;exports.modelFacingProperties=modelFacingProperties;const eslint_devkit_1=require("@interlace/eslint-devkit");const mcp_evidence_1=require("../../utils/mcp-evidence");const REGISTER_TOOL="registerTool";const LEGACY_TOOL="tool";const MODEL_FACING_KEYS=["description","title"];function isStaticText(node){if(node.type==="Literal")return typeof node.value==="string";if(node.type==="TemplateLiteral")return node.expressions.length===0;if(node.type==="BinaryExpression"&&node.operator==="+"){return isStaticText(node.left)&&isStaticText(node.right)}return false}function modelFacingProperties(config){const found=[];for(const prop of config.properties){if(prop.type!=="Property"||prop.computed)continue;const key=prop.key.type==="Identifier"?prop.key.name:(0,eslint_devkit_1.staticString)(prop.key)??void 0;if(key===void 0)continue;if(!MODEL_FACING_KEYS.includes(key))continue;if(isStaticText(prop.value))continue;found.push({key,value:prop.value})}return found}exports.noToolDescriptionInjection=(0,eslint_devkit_1.createRule)({name:"no-tool-description-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-mcp-sdk-security/docs/rules/no-tool-description-injection.md",description:"Require MCP tool descriptions and titles to be static text, since they reach the model as instructions",cwe:"CWE-1427",cvss:8.6},messages:{dynamicDescription:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"MCP Tool Description Built at Runtime",cwe:"CWE-1427",owasp:"A03:2021",cvss:8.6,description:'The `{{key}}` for tool "{{tool}}" is assembled at runtime, so it reaches the model as instruction text this file does not control',severity:"HIGH",compliance:["SOC2"],fix:"Write the {{key}} as a literal. If it genuinely varies, register a separate tool per variant rather than interpolating \u2014 the text lands in the model's instruction block, so whoever controls the value controls the instructions.",documentationLink:"https://modelcontextprotocol.io/docs/concepts/tools"})},schema:[]},defaultOptions:[],create(context){if(!(0,mcp_evidence_1.fileUsesMcpSdk)(context.sourceCode.ast))return{};const candidates=[];function toolNameOf(node){const first=node.arguments[0];if(first?.type==="Literal"&&typeof first.value==="string")return first.value;return"unknown"}return{CallExpression(node){if(node.callee.type!=="MemberExpression"||node.callee.computed)return;if(node.callee.property.type!=="Identifier")return;const method=node.callee.property.name;if(method!==REGISTER_TOOL&&method!==LEGACY_TOOL)return;const config=node.arguments[1];if(config?.type!=="ObjectExpression")return;for(const finding of modelFacingProperties(config)){candidates.push({node:finding.value,tool:toolNameOf(node),key:finding.key})}},"Program:exit"(){for(const{node,tool,key}of candidates){context.report({node,messageId:"dynamicDescription",data:{tool,key}})}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noUnvalidatedToolArgs=void 0;exports.propertyKey=propertyKey;exports.declaredSchemaKeys=declaredSchemaKeys;exports.destructuredArgNames=destructuredArgNames;const eslint_devkit_1=require("@interlace/eslint-devkit");const mcp_evidence_1=require("../../utils/mcp-evidence");const REGISTER_TOOL="registerTool";const LEGACY_TOOL="tool";function propertyKey(prop){if(prop.type!=="Property"||prop.computed)return void 0;if(prop.key.type==="Identifier")return prop.key.name;
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noUnvalidatedToolArgs=void 0;exports.propertyKey=propertyKey;exports.declaredSchemaKeys=declaredSchemaKeys;exports.destructuredArgNames=destructuredArgNames;const eslint_devkit_1=require("@interlace/eslint-devkit");const mcp_evidence_1=require("../../utils/mcp-evidence");const REGISTER_TOOL="registerTool";const LEGACY_TOOL="tool";function propertyKey(prop){if(prop.type!=="Property"||prop.computed)return void 0;if(prop.key.type==="Identifier")return prop.key.name;return(0,eslint_devkit_1.staticString)(prop.key)??void 0}function declaredSchemaKeys(config){const index=config.properties.findIndex(prop=>propertyKey(prop)==="inputSchema");if(index===-1)return void 0;for(let i=index+1;i<config.properties.length;i++){if(config.properties[i].type==="SpreadElement")return void 0}const value=config.properties[index].value;if(value.type!=="ObjectExpression")return void 0;const keys=new Set;for(const entry of value.properties){if(entry.type==="SpreadElement")return void 0;const key=propertyKey(entry);if(key===void 0)return void 0;keys.add(key)}return keys}function destructuredArgNames(handler){if(handler.type!=="ArrowFunctionExpression"&&handler.type!=="FunctionExpression"&&handler.type!=="FunctionDeclaration"){return[]}const first=handler.params[0];if(first===void 0||first.type!=="ObjectPattern")return[];const found=[];for(const prop of first.properties){if(prop.type==="RestElement")continue;const key=propertyKey(prop);if(key===void 0)continue;found.push({name:key,node:prop})}return found}exports.noUnvalidatedToolArgs=(0,eslint_devkit_1.createRule)({name:"no-unvalidated-tool-args",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-mcp-sdk-security/docs/rules/no-unvalidated-tool-args.md",description:"Disallow a tool handler reading an argument its declared input schema does not include",cwe:"CWE-20",cvss:7.5},messages:{undeclaredArg:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"MCP Tool Argument Outside the Declared Schema",cwe:"CWE-20",owasp:"A03:2021",cvss:7.5,description:'Tool "{{tool}}" reads `{{arg}}`, which its inputSchema does not declare \u2014 so the value either arrives unvalidated or never arrives at all',severity:"HIGH",compliance:["SOC2"],fix:"Declare `{{arg}}` in the inputSchema with the type and constraints it needs, or stop reading it. A key the schema does not mention is one nothing validated.",documentationLink:"https://modelcontextprotocol.io/docs/concepts/tools"})},schema:[]},defaultOptions:[],create(context){if(!(0,mcp_evidence_1.fileUsesMcpSdk)(context.sourceCode.ast))return{};const candidates=[];function toolNameOf(node){const first=node.arguments[0];if(first?.type==="Literal"&&typeof first.value==="string")return first.value;return"unknown"}return{CallExpression(node){if(node.callee.type!=="MemberExpression"||node.callee.computed)return;if(node.callee.property.type!=="Identifier")return;const method=node.callee.property.name;if(method!==REGISTER_TOOL&&method!==LEGACY_TOOL)return;const config=node.arguments[1];if(config?.type!=="ObjectExpression")return;const declared=declaredSchemaKeys(config);if(declared===void 0)return;const handler=node.arguments[node.arguments.length-1];for(const read of destructuredArgNames(handler)){if(declared.has(read.name))continue;candidates.push({node:read.node,tool:toolNameOf(node),arg:read.name})}},"Program:exit"(){for(const{node,tool,arg}of candidates){context.report({node,messageId:"undeclaredArg",data:{tool,arg}})}}}}});
|