eslint-plugin-maintainability 3.0.13 → 3.0.15

package/src/rules/maintainability/consistent-function-scoping.js

@@ -1,229 +1 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.consistentFunctionScoping = void 0;
-const eslint_devkit_1 = require("@interlace/eslint-devkit");
-const eslint_devkit_2 = require("@interlace/eslint-devkit");
-exports.consistentFunctionScoping = (0, eslint_devkit_1.createRule)({
-    name: 'consistent-function-scoping',
-    meta: {
-        type: 'suggestion',
-        docs: {
-            url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-maintainability/docs/rules/consistent-function-scoping.md',
-            description: 'Move function definitions to the highest possible scope to improve readability and performance',
-        },
-        hasSuggestions: true,
-        messages: {
-            inconsistentFunctionScoping: (0, eslint_devkit_2.formatLLMMessage)({
-                icon: eslint_devkit_2.MessageIcons.ARCHITECTURE,
-                issueName: 'Inconsistent Function Scoping',
-                description: 'Function can be moved to higher scope as it doesn\'t capture outer variables',
-                severity: 'MEDIUM',
-                fix: 'Move function declaration to module scope',
-                documentationLink: 'https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/consistent-function-scoping.md',
-            }),
-            moveToModuleScope: (0, eslint_devkit_2.formatLLMMessage)({
-                icon: eslint_devkit_2.MessageIcons.ARCHITECTURE,
-                issueName: 'Function Scoping Optimization',
-                description: 'Function does not use variables from its containing scope and can be moved to module level',
-                severity: 'MEDIUM',
-                fix: 'Move function outside current scope: extract `function helper() { return "value"; }` to module level before the containing function/class',
-                documentationLink: 'https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/consistent-function-scoping.md',
-            }),
-        },
-        schema: [
-            {
-                type: 'object',
-                properties: {
-                    checkArrowFunctions: {
-                        type: 'boolean',
-                        default: true,
-                    },
-                },
-                additionalProperties: false,
-            },
-        ],
-    },
-    defaultOptions: [{ checkArrowFunctions: true }],
-    create(context) {
-        const [options] = context.options;
-        const { checkArrowFunctions = true } = options || {};
-        const scopeStack = [new Set()];
-        function enterScope() {
-            scopeStack.push(new Set());
-        }
-        function exitScope() {
-            scopeStack.pop();
-        }
-        function addVariableToCurrentScope(name) {
-            const currentScope = scopeStack[scopeStack.length - 1];
-            if (currentScope) {
-                currentScope.add(name);
-            }
-        }
-        function getOuterScopeVariables() {
-            const outerScopes = scopeStack.slice(0, -1);
-            const outerVars = new Set();
-            for (const scope of outerScopes) {
-                for (const varName of scope) {
-                    outerVars.add(varName);
-                }
-            }
-            return outerVars;
-        }
-        function analyzeFunction(node) {
-            if (node.parent?.type === 'Program' || node.parent?.type === 'ExportNamedDeclaration' || node.parent?.type === 'ExportDefaultDeclaration') {
-                return;
-            }
-            const p = node.parent;
-            if (p?.type === 'MethodDefinition' || p?.type === 'PropertyDefinition') {
-                return;
-            }
-            if (p?.type === 'CallExpression') {
-                const callee = p.callee;
-                if (callee.type === 'MemberExpression' && callee.property.type === 'Identifier') {
-                    const HOST_METHODS = new Set([
-                        'map', 'filter', 'reduce', 'reduceRight', 'forEach', 'find', 'findIndex',
-                        'some', 'every', 'sort', 'flatMap', 'flat',
-                        'then', 'catch', 'finally',
-                        'on', 'once', 'addEventListener', 'removeEventListener', 'subscribe',
-                    ]);
-                    if (HOST_METHODS.has(callee.property.name))
-                        return;
-                }
-                if (callee.type === 'Identifier') {
-                    const HOST_FNS = new Set([
-                        'setTimeout', 'setInterval', 'setImmediate',
-                        'requestAnimationFrame', 'requestIdleCallback', 'queueMicrotask',
-                    ]);
-                    if (HOST_FNS.has(callee.name))
-                        return;
-                }
-            }
-            if (p?.type === 'NewExpression' &&
-                p.callee.type === 'Identifier' &&
-                p.callee.name === 'Promise') {
-                return;
-            }
-            const referencedVars = new Set();
-            function collectReferences(astNode, depth = 0, visited = new Set()) {
-                if (depth > 10 || visited.has(astNode)) {
-                    return;
-                }
-                visited.add(astNode);
-                if (astNode.type === 'Identifier') {
-                    referencedVars.add(astNode.name);
-                }
-                if (depth < 10) {
-                    for (const key in astNode) {
-                        const child = astNode[key];
-                        if (child && typeof child === 'object') {
-                            if (Array.isArray(child)) {
-                                child.forEach(item => {
-                                    if (item && typeof item === 'object' && 'type' in item) {
-                                        collectReferences(item, depth + 1, visited);
-                                    }
-                                });
-                            }
-                            else if ('type' in child) {
-                                collectReferences(child, depth + 1, visited);
-                            }
-                        }
-                    }
-                }
-            }
-            if (node.body.type === 'BlockStatement') {
-                node.body.body.forEach((stmt) => collectReferences(stmt));
-            }
-            else {
-                collectReferences(node.body);
-            }
-            node.params.forEach((param) => {
-                if (param.type === 'Identifier') {
-                    referencedVars.add(param.name);
-                }
-            });
-            const outerVars = getOuterScopeVariables();
-            let capturesOuterVar = false;
-            for (const ref of referencedVars) {
-                if (outerVars.has(ref)) {
-                    capturesOuterVar = true;
-                    break;
-                }
-            }
-            if (!capturesOuterVar) {
-                const functionName = node.type === 'FunctionDeclaration' ? node.id?.name : undefined;
-                const moduleScope = scopeStack[0];
-                if (!functionName || !moduleScope.has(functionName)) {
-                    context.report({
-                        node,
-                        messageId: 'inconsistentFunctionScoping',
-                        data: {
-                            functionName: functionName || 'anonymous function',
-                        },
-                        suggest: [
-                            {
-                                messageId: 'moveToModuleScope',
-                                fix(fixer) {
-                                    return fixer.insertTextBefore(node, '// TODO: Move this function to module scope - it doesn\'t capture outer variables\n');
-                                },
-                            },
-                        ],
-                    });
-                }
-            }
-        }
-        return {
-            Program() {
-                enterScope();
-            },
-            'Program:exit'() {
-                exitScope();
-            },
-            FunctionDeclaration(node) {
-                enterScope();
-                node.params.forEach((param) => {
-                    if (param.type === 'Identifier') {
-                        addVariableToCurrentScope(param.name);
-                    }
-                });
-                analyzeFunction(node);
-            },
-            'FunctionDeclaration:exit'() {
-                exitScope();
-            },
-            FunctionExpression(node) {
-                enterScope();
-                node.params.forEach((param) => {
-                    if (param.type === 'Identifier') {
-                        addVariableToCurrentScope(param.name);
-                    }
-                });
-                analyzeFunction(node);
-            },
-            'FunctionExpression:exit'() {
-                exitScope();
-            },
-            ArrowFunctionExpression(node) {
-                enterScope();
-                node.params.forEach((param) => {
-                    if (param.type === 'Identifier') {
-                        addVariableToCurrentScope(param.name);
-                    }
-                });
-                if (checkArrowFunctions) {
-                    analyzeFunction(node);
-                }
-            },
-            'ArrowFunctionExpression:exit'() {
-                exitScope();
-            },
-            VariableDeclaration(node) {
-                node.declarations.forEach((decl) => {
-                    if (decl.id.type === 'Identifier') {
-                        addVariableToCurrentScope(decl.id.name);
-                    }
-                });
-            },
-        };
-    },
-});
+"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.consistentFunctionScoping=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");exports.consistentFunctionScoping=(0,eslint_devkit_1.createRule)({name:"consistent-function-scoping",meta:{type:"suggestion",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-maintainability/docs/rules/consistent-function-scoping.md",description:"Move function definitions to the highest possible scope to improve readability and performance"},hasSuggestions:true,messages:{inconsistentFunctionScoping:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.ARCHITECTURE,issueName:"Inconsistent Function Scoping",description:"Function can be moved to higher scope as it doesn't capture outer variables",severity:"MEDIUM",fix:"Move function declaration to module scope",documentationLink:"https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/consistent-function-scoping.md"}),moveToModuleScope:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.ARCHITECTURE,issueName:"Function Scoping Optimization",description:"Function does not use variables from its containing scope and can be moved to module level",severity:"MEDIUM",fix:'Move function outside current scope: extract `function helper() { return "value"; }` to module level before the containing function/class',documentationLink:"https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/consistent-function-scoping.md"})},schema:[{type:"object",properties:{checkArrowFunctions:{type:"boolean",default:true}},additionalProperties:false}]},defaultOptions:[{checkArrowFunctions:true}],create(context){const[options]=context.options;const{checkArrowFunctions=true}=options||{};const scopeStack=[new Set];function enterScope(){scopeStack.push(new Set)}function exitScope(){scopeStack.pop()}function addVariableToCurrentScope(name){const currentScope=scopeStack[scopeStack.length-1];if(currentScope){currentScope.add(name)}}function getOuterScopeVariables(){const outerScopes=scopeStack.slice(0,-1);const outerVars=new Set;for(const scope of outerScopes){for(const varName of scope){outerVars.add(varName)}}return outerVars}function analyzeFunction(node){if(node.parent?.type==="Program"||node.parent?.type==="ExportNamedDeclaration"||node.parent?.type==="ExportDefaultDeclaration"){return}const p=node.parent;if(p?.type==="MethodDefinition"||p?.type==="PropertyDefinition"){return}if(p?.type==="CallExpression"){const callee=p.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"){const HOST_METHODS=new Set(["map","filter","reduce","reduceRight","forEach","find","findIndex","some","every","sort","flatMap","flat","then","catch","finally","on","once","addEventListener","removeEventListener","subscribe"]);if(HOST_METHODS.has(callee.property.name))return}if(callee.type==="Identifier"){const HOST_FNS=new Set(["setTimeout","setInterval","setImmediate","requestAnimationFrame","requestIdleCallback","queueMicrotask"]);if(HOST_FNS.has(callee.name))return}}if(p?.type==="NewExpression"&&p.callee.type==="Identifier"&&p.callee.name==="Promise"){return}const referencedVars=new Set;function collectReferences(astNode,depth=0,visited=new Set){if(depth>10||visited.has(astNode)){return}visited.add(astNode);if(astNode.type==="Identifier"){referencedVars.add(astNode.name)}if(depth<10){for(const key in astNode){const child=astNode[key];if(child&&typeof child==="object"){if(Array.isArray(child)){child.forEach(item=>{if(item&&typeof item==="object"&&"type"in item){collectReferences(item,depth+1,visited)}})}else if("type"in child){collectReferences(child,depth+1,visited)}}}}}if(node.body.type==="BlockStatement"){node.body.body.forEach(stmt=>collectReferences(stmt))}else{collectReferences(node.body)}node.params.forEach(param=>{if(param.type==="Identifier"){referencedVars.add(param.name)}});const outerVars=getOuterScopeVariables();let capturesOuterVar=false;for(const ref of referencedVars){if(outerVars.has(ref)){capturesOuterVar=true;break}}if(!capturesOuterVar){const functionName=node.type==="FunctionDeclaration"?node.id?.name:void 0;const moduleScope=scopeStack[0];if(!functionName||!moduleScope.has(functionName)){context.report({node,messageId:"inconsistentFunctionScoping",data:{functionName:functionName||"anonymous function"},suggest:[{messageId:"moveToModuleScope",fix(fixer){return fixer.insertTextBefore(node,"// TODO: Move this function to module scope - it doesn't capture outer variables\n")}}]})}}}return{Program(){enterScope()},"Program:exit"(){exitScope()},FunctionDeclaration(node){enterScope();node.params.forEach(param=>{if(param.type==="Identifier"){addVariableToCurrentScope(param.name)}});analyzeFunction(node)},"FunctionDeclaration:exit"(){exitScope()},FunctionExpression(node){enterScope();node.params.forEach(param=>{if(param.type==="Identifier"){addVariableToCurrentScope(param.name)}});analyzeFunction(node)},"FunctionExpression:exit"(){exitScope()},ArrowFunctionExpression(node){enterScope();node.params.forEach(param=>{if(param.type==="Identifier"){addVariableToCurrentScope(param.name)}});if(checkArrowFunctions){analyzeFunction(node)}},"ArrowFunctionExpression:exit"(){exitScope()},VariableDeclaration(node){node.declarations.forEach(decl=>{if(decl.id.type==="Identifier"){addVariableToCurrentScope(decl.id.name)}})}}}});

package/src/rules/maintainability/identical-functions.js

@@ -1,259 +1 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.identicalFunctions = void 0;
-exports.buildGenericName = buildGenericName;
-const eslint_devkit_1 = require("@interlace/eslint-devkit");
-const eslint_devkit_2 = require("@interlace/eslint-devkit");
-const eslint_devkit_3 = require("@interlace/eslint-devkit");
-function buildGenericName(firstFunctionName) {
-    const baseName = firstFunctionName.replace(/^(handle|process|get|set|create|update|delete)/, '');
-    return `handle${baseName || 'Generic'}`;
-}
-exports.identicalFunctions = (0, eslint_devkit_2.createRule)({
-    name: 'identical-functions',
-    meta: {
-        type: 'suggestion',
-        docs: {
-            url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-maintainability/docs/rules/identical-functions.md',
-            description: 'Detects duplicate function implementations with DRY refactoring suggestions',
-        },
-        messages: {
-            identicalFunctions: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.DUPLICATION,
-                issueName: 'Code duplication',
-                description: '{{count}} duplicates ({{similarity}}% similar)',
-                severity: 'MEDIUM',
-                fix: 'Extract to reusable function',
-                documentationLink: 'https://en.wikipedia.org/wiki/Don%27t_repeat_yourself',
-            }),
-            extractGeneric: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.INFO,
-                issueName: 'Extract Generic',
-                description: 'Extract to generic function',
-                severity: 'LOW',
-                fix: 'Create shared function with parameters',
-                documentationLink: 'https://en.wikipedia.org/wiki/Don%27t_repeat_yourself',
-            }),
-            useHigherOrder: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.INFO,
-                issueName: 'Use Higher-Order',
-                description: 'Use higher-order function pattern',
-                severity: 'LOW',
-                fix: 'Create factory function that returns specialized functions',
-                documentationLink: 'https://developer.mozilla.org/en-US/docs/Glossary/Higher-order_function',
-            }),
-            applyInheritance: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.INFO,
-                issueName: 'Use Composition',
-                description: 'Use inheritance/composition',
-                severity: 'LOW',
-                fix: 'Extract common behavior to base class or mixin',
-                documentationLink: 'https://en.wikipedia.org/wiki/Composition_over_inheritance',
-            }),
-        },
-        schema: [
-            {
-                type: 'object',
-                properties: {
-                    minLines: {
-                        type: 'number',
-                        default: 3,
-                        minimum: 1,
-                        description: 'Minimum lines to consider for duplication',
-                    },
-                    similarityThreshold: {
-                        type: 'number',
-                        default: 0.9,
-                        minimum: 0.5,
-                        maximum: 1,
-                        description: 'Similarity threshold (0.5-1.0)',
-                    },
-                    ignoreTestFiles: {
-                        type: 'boolean',
-                        default: true,
-                    },
-                },
-                additionalProperties: false,
-            },
-        ],
-    },
-    defaultOptions: [
-        {
-            minLines: 3,
-            similarityThreshold: 0.9,
-            ignoreTestFiles: true,
-        },
-    ],
-    create(context) {
-        const { minLines = 3, similarityThreshold = 0.9, ignoreTestFiles = true, } = context.options[0] || {};
-        const sourceCode = context.sourceCode;
-        const filename = context.filename;
-        if (ignoreTestFiles && /\.(test|spec)\.[jt]sx?$/.test(filename)) {
-            return {};
-        }
-        const functions = [];
-        function normalizeBody(body) {
-            return (body
-                .replace(/\s+/g, ' ')
-                .replace(/["'`]/g, '"')
-                .replace(/\b[a-z_$][a-zA-Z0-9_$]*\b/g, 'VAR')
-                .replace(/\/\*[\s\S]*?\*\//g, '')
-                .replace(/\/\/.*/g, '')
-                .trim());
-        }
-        function calculateSimilarity(str1, str2) {
-            if (str1 === str2)
-                return 1.0;
-            const longer = str1.length > str2.length ? str1 : str2;
-            const shorter = str1.length > str2.length ? str2 : str1;
-            const editDistance = levenshteinDistance(longer, shorter);
-            return (longer.length - editDistance) / longer.length;
-        }
-        function levenshteinDistance(str1, str2) {
-            const matrix = [];
-            for (let i = 0; i <= str2.length; i++) {
-                matrix[i] = [i];
-            }
-            for (let j = 0; j <= str1.length; j++) {
-                matrix[0][j] = j;
-            }
-            for (let i = 1; i <= str2.length; i++) {
-                for (let j = 1; j <= str1.length; j++) {
-                    if (str2.charAt(i - 1) === str1.charAt(j - 1)) {
-                        matrix[i][j] = matrix[i - 1][j - 1];
-                    }
-                    else {
-                        matrix[i][j] = Math.min(matrix[i - 1][j - 1] + 1, matrix[i][j - 1] + 1, matrix[i - 1][j] + 1);
-                    }
-                }
-            }
-            return matrix[str2.length][str1.length];
-        }
-        function findDuplicationGroups() {
-            const groups = [];
-            const processed = new Set();
-            for (let i = 0; i < functions.length; i++) {
-                if (processed.has(i))
-                    continue;
-                const group = [functions[i]];
-                processed.add(i);
-                for (let j = i + 1; j < functions.length; j++) {
-                    if (processed.has(j))
-                        continue;
-                    const similarity = calculateSimilarity(functions[i].normalizedBody, functions[j].normalizedBody);
-                    if (similarity >= similarityThreshold) {
-                        group.push(functions[j]);
-                        processed.add(j);
-                    }
-                }
-                if (group.length >= 2) {
-                    const avgSimilarity = group.reduce((sum, func, idx) => {
-                        if (idx === 0)
-                            return 0;
-                        return (sum +
-                            calculateSimilarity(group[0].normalizedBody, func.normalizedBody));
-                    }, 0) /
-                        (group.length - 1);
-                    groups.push({
-                        functions: group,
-                        similarityScore: avgSimilarity,
-                        commonPattern: functions[i].normalizedBody,
-                    });
-                }
-            }
-            return groups;
-        }
-        function suggestRefactoringApproach(group) {
-            const funcNames = group.functions.map((f) => f.name);
-            const hasRolePattern = funcNames.some((name) => /user|admin|guest|customer/i.test(name));
-            const hasTypePattern = funcNames.some((name) => /payment|shipping|billing|email|sms/i.test(name));
-            if (hasRolePattern || hasTypePattern) {
-                return {
-                    approach: 'Parameter Object + Strategy Pattern',
-                    pattern: 'Extract discriminator as parameter',
-                    complexity: 'moderate',
-                };
-            }
-            if (group.functions[0].params.length > 0) {
-                return {
-                    approach: 'Higher-Order Function',
-                    pattern: 'Extract common logic, inject differences',
-                    complexity: 'simple',
-                };
-            }
-            return {
-                approach: 'Extract Method',
-                pattern: 'DRY - Single source of truth',
-                complexity: 'simple',
-            };
-        }
-        function storeFunctionInfo(node) {
-            const body = node.body ? sourceCode.getText(node.body) : '';
-            const lines = body.split('\n').length;
-            if (lines < minLines)
-                return;
-            const name = (0, eslint_devkit_3.extractFunctionSignature)(node)
-                .split('(')[0]
-                .replace('function ', '');
-            const params = node.params.map((p) => p.type === 'Identifier' ? p.name : sourceCode.getText(p));
-            functions.push({
-                node,
-                name: name || 'anonymous',
-                body,
-                normalizedBody: normalizeBody(body),
-                lines,
-                location: `${filename}:${node.loc?.start.line}`,
-                params,
-            });
-        }
-        function reportDuplications() {
-            const groups = findDuplicationGroups();
-            groups.forEach((group) => {
-                const refactoringApproach = suggestRefactoringApproach(group);
-                const primaryFunction = group.functions[0];
-                const similarityPercent = Math.round(group.similarityScore * 100);
-                context.report({
-                    node: primaryFunction.node,
-                    messageId: 'identicalFunctions',
-                    data: {
-                        count: String(group.functions.length),
-                        similarity: String(similarityPercent),
-                        filePath: filename,
-                        line: String(primaryFunction.node.loc?.start.line ?? 0),
-                    },
-                    suggest: [
-                        {
-                            messageId: 'extractGeneric',
-                            data: {
-                                functionName: buildGenericName(primaryFunction.name),
-                            },
-                            fix: () => null,
-                        },
-                        ...(refactoringApproach.approach.includes('Higher-Order')
-                            ? [
-                                {
-                                    messageId: 'useHigherOrder',
-                                    fix: () => null,
-                                },
-                            ]
-                            : []),
-                        ...(refactoringApproach.approach.includes('Strategy')
-                            ? [
-                                {
-                                    messageId: 'applyInheritance',
-                                    fix: () => null,
-                                },
-                            ]
-                            : []),
-                    ],
-                });
-            });
-        }
-        return {
-            FunctionDeclaration: storeFunctionInfo,
-            FunctionExpression: storeFunctionInfo,
-            ArrowFunctionExpression: storeFunctionInfo,
-            'Program:exit': reportDuplications,
-        };
-    },
-});
+"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.identicalFunctions=void 0;exports.buildGenericName=buildGenericName;exports.calculateSimilarity=calculateSimilarity;exports.levenshteinDistance=levenshteinDistance;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");function buildGenericName(firstFunctionName){const baseName=firstFunctionName.replace(/^(handle|process|get|set|create|update|delete)/,"");return`handle${baseName||"Generic"}`}function calculateSimilarity(str1,str2,similarityThreshold){if(str1===str2)return 1;const longer=str1.length>str2.length?str1:str2;const shorter=str1.length>str2.length?str2:str1;if(shorter.length/longer.length<similarityThreshold)return 0;const budget=longer.length-Math.ceil(longer.length*similarityThreshold);const editDistance=levenshteinDistance(longer,shorter,budget);if(editDistance<0)return 0;return(longer.length-editDistance)/longer.length}function levenshteinDistance(str1,str2,budget){let previous=[];let current=[];for(let j=0;j<=str1.length;j++)previous[j]=j;for(let i=1;i<=str2.length;i++){current[0]=i;let rowMin=current[0];for(let j=1;j<=str1.length;j++){current[j]=str2.charAt(i-1)===str1.charAt(j-1)?previous[j-1]:Math.min(previous[j-1]+1,current[j-1]+1,previous[j]+1);if(current[j]<rowMin)rowMin=current[j]}if(rowMin>budget)return-1;const swap=previous;previous=current;current=swap}return previous[str1.length]}exports.identicalFunctions=(0,eslint_devkit_2.createRule)({name:"identical-functions",meta:{type:"suggestion",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-maintainability/docs/rules/identical-functions.md",description:"Detects duplicate function implementations with DRY refactoring suggestions"},hasSuggestions:true,messages:{identicalFunctions:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.DUPLICATION,issueName:"Code duplication",description:"{{count}} duplicates ({{similarity}}% similar)",severity:"MEDIUM",fix:"Extract to reusable function",documentationLink:"https://en.wikipedia.org/wiki/Don%27t_repeat_yourself"}),extractGeneric:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Extract Generic",description:"Extract to generic function",severity:"LOW",fix:"Create shared function with parameters",documentationLink:"https://en.wikipedia.org/wiki/Don%27t_repeat_yourself"}),useHigherOrder:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Higher-Order",description:"Use higher-order function pattern",severity:"LOW",fix:"Create factory function that returns specialized functions",documentationLink:"https://developer.mozilla.org/en-US/docs/Glossary/Higher-order_function"}),applyInheritance:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Composition",description:"Use inheritance/composition",severity:"LOW",fix:"Extract common behavior to base class or mixin",documentationLink:"https://en.wikipedia.org/wiki/Composition_over_inheritance"})},schema:[{type:"object",properties:{minLines:{type:"number",default:3,minimum:1,description:"Minimum lines to consider for duplication"},similarityThreshold:{type:"number",default:.9,minimum:.5,maximum:1,description:"Similarity threshold (0.5-1.0)"},ignoreTestFiles:{type:"boolean",default:true}},additionalProperties:false}]},defaultOptions:[{minLines:3,similarityThreshold:.9,ignoreTestFiles:true}],create(context){const{minLines=3,similarityThreshold=.9,ignoreTestFiles=true}=context.options[0]||{};const sourceCode=context.sourceCode;const filename=context.filename;if(ignoreTestFiles&&/\.(test|spec)\.[jt]sx?$/.test(filename)){return{}}const functions=[];function normalizeBody(body){return body.replace(/\s+/g," ").replace(/["'`]/g,'"').replace(/\b[a-z_$][a-zA-Z0-9_$]*\b/g,"VAR").replace(/\/\*[\s\S]*?\*\//g,"").replace(/\/\/.*/g,"").trim()}function findDuplicationGroups(){const groups=[];const processed=new Set;for(let i=0;i<functions.length;i++){if(processed.has(i))continue;const group=[functions[i]];processed.add(i);for(let j=i+1;j<functions.length;j++){if(processed.has(j))continue;const similarity=calculateSimilarity(functions[i].normalizedBody,functions[j].normalizedBody,similarityThreshold);if(similarity>=similarityThreshold){group.push(functions[j]);processed.add(j)}}if(group.length>=2){const avgSimilarity=group.reduce((sum,func,idx)=>{if(idx===0)return 0;return sum+calculateSimilarity(group[0].normalizedBody,func.normalizedBody,similarityThreshold)},0)/(group.length-1);groups.push({functions:group,similarityScore:avgSimilarity,commonPattern:functions[i].normalizedBody})}}return groups}function suggestRefactoringApproach(group){const funcNames=group.functions.map(f=>f.name);const hasRolePattern=funcNames.some(name=>/user|admin|guest|customer/i.test(name));const hasTypePattern=funcNames.some(name=>/payment|shipping|billing|email|sms/i.test(name));if(hasRolePattern||hasTypePattern){return{approach:"Parameter Object + Strategy Pattern",pattern:"Extract discriminator as parameter",complexity:"moderate"}}if(group.functions[0].params.length>0){return{approach:"Higher-Order Function",pattern:"Extract common logic, inject differences",complexity:"simple"}}return{approach:"Extract Method",pattern:"DRY - Single source of truth",complexity:"simple"}}function storeFunctionInfo(node){const body=node.body?sourceCode.getText(node.body):"";const lines=body.split("\n").length;if(lines<minLines)return;const name=(0,eslint_devkit_3.extractFunctionSignature)(node).split("(")[0].replace("function ","");const params=node.params.map(p=>p.type==="Identifier"?p.name:sourceCode.getText(p));functions.push({node,name:name||"anonymous",body,normalizedBody:normalizeBody(body),lines,location:`${filename}:${node.loc?.start.line}`,params})}function reportDuplications(){const groups=findDuplicationGroups();groups.forEach(group=>{const refactoringApproach=suggestRefactoringApproach(group);const primaryFunction=group.functions[0];const similarityPercent=Math.round(group.similarityScore*100);context.report({node:primaryFunction.node,messageId:"identicalFunctions",data:{count:String(group.functions.length),similarity:String(similarityPercent),filePath:filename,line:String(primaryFunction.node.loc?.start.line??0)},suggest:[{messageId:"extractGeneric",data:{functionName:buildGenericName(primaryFunction.name)},fix:()=>null},...refactoringApproach.approach.includes("Higher-Order")?[{messageId:"useHigherOrder",fix:()=>null}]:[],...refactoringApproach.approach.includes("Strategy")?[{messageId:"applyInheritance",fix:()=>null}]:[]]})})}return{FunctionDeclaration:storeFunctionInfo,FunctionExpression:storeFunctionInfo,ArrowFunctionExpression:storeFunctionInfo,"Program:exit":reportDuplications}}});

package/src/rules/maintainability/max-parameters.js

@@ -1,129 +1 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.maxParameters = void 0;
-const eslint_devkit_1 = require("@interlace/eslint-devkit");
-const eslint_devkit_2 = require("@interlace/eslint-devkit");
-const eslint_devkit_3 = require("@interlace/eslint-devkit");
-function countParameters(node) {
-    return node.params.length;
-}
-exports.maxParameters = (0, eslint_devkit_2.createRule)({
-    name: 'max-parameters',
-    meta: {
-        type: 'suggestion',
-        docs: {
-            url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-maintainability/docs/rules/max-parameters.md',
-            description: 'Detects functions with too many parameters',
-        },
-        messages: {
-            tooManyParameters: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.COMPLEXITY,
-                issueName: 'Too many parameters',
-                description: '{{functionName}}: {{count}} parameters (max: {{max}})',
-                severity: 'MEDIUM',
-                fix: 'Refactor to use object parameter or split function',
-                documentationLink: 'https://rules.sonarsource.com/javascript/RSPEC-107/',
-            }),
-            useObjectParameter: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.INFO,
-                issueName: 'Use Object Parameter',
-                description: 'Use object parameter pattern',
-                severity: 'LOW',
-                fix: 'function({ param1, param2, param3 })',
-                documentationLink: 'https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment',
-            }),
-            extractToClass: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.INFO,
-                issueName: 'Extract to Class',
-                description: 'Extract to class with properties',
-                severity: 'LOW',
-                fix: 'Create class to hold related parameters',
-                documentationLink: 'https://refactoring.guru/introduce-parameter-object',
-            }),
-            splitFunction: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.INFO,
-                issueName: 'Split Function',
-                description: 'Split into smaller functions',
-                severity: 'LOW',
-                fix: 'Extract logic into separate focused functions',
-                documentationLink: 'https://refactoring.guru/smells/long-parameter-list',
-            }),
-        },
-        schema: [
-            {
-                type: 'object',
-                properties: {
-                    max: {
-                        type: 'number',
-                        default: 4,
-                        minimum: 1,
-                    },
-                    ignoreConstructors: {
-                        type: 'boolean',
-                        default: false,
-                    },
-                    ignoreOverriddenMethods: {
-                        type: 'boolean',
-                        default: false,
-                    },
-                },
-                additionalProperties: false,
-            },
-        ],
-    },
-    defaultOptions: [
-        {
-            max: 4,
-            ignoreConstructors: false,
-            ignoreOverriddenMethods: false,
-        },
-    ],
-    create(context, [options = {}]) {
-        const { max = 4, ignoreConstructors = false, } = options || {};
-        function checkFunction(node) {
-            if (ignoreConstructors) {
-                if (node.type === 'FunctionDeclaration' &&
-                    node.id &&
-                    node.id.name &&
-                    /^[A-Z]/.test(node.id.name)) {
-                    return;
-                }
-            }
-            const paramCount = countParameters(node);
-            if (paramCount <= max) {
-                return;
-            }
-            const functionSignature = (0, eslint_devkit_3.extractFunctionSignature)(node);
-            const overBy = paramCount - max;
-            context.report({
-                node,
-                messageId: 'tooManyParameters',
-                data: {
-                    functionName: functionSignature,
-                    count: String(paramCount),
-                    max: String(max),
-                    overBy: String(overBy),
-                },
-                suggest: [
-                    {
-                        messageId: 'useObjectParameter',
-                        fix: () => null,
-                    },
-                    {
-                        messageId: 'extractToClass',
-                        fix: () => null,
-                    },
-                    {
-                        messageId: 'splitFunction',
-                        fix: () => null,
-                    },
-                ],
-            });
-        }
-        return {
-            FunctionDeclaration: checkFunction,
-            FunctionExpression: checkFunction,
-            ArrowFunctionExpression: checkFunction,
-        };
-    },
-});
+"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.maxParameters=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");function countParameters(node){return node.params.length}exports.maxParameters=(0,eslint_devkit_2.createRule)({name:"max-parameters",meta:{type:"suggestion",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-maintainability/docs/rules/max-parameters.md",description:"Detects functions with too many parameters"},hasSuggestions:true,messages:{tooManyParameters:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.COMPLEXITY,issueName:"Too many parameters",description:"{{functionName}}: {{count}} parameters (max: {{max}})",severity:"MEDIUM",fix:"Refactor to use object parameter or split function",documentationLink:"https://rules.sonarsource.com/javascript/RSPEC-107/"}),useObjectParameter:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Object Parameter",description:"Use object parameter pattern",severity:"LOW",fix:"function({ param1, param2, param3 })",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment"}),extractToClass:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Extract to Class",description:"Extract to class with properties",severity:"LOW",fix:"Create class to hold related parameters",documentationLink:"https://refactoring.guru/introduce-parameter-object"}),splitFunction:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Split Function",description:"Split into smaller functions",severity:"LOW",fix:"Extract logic into separate focused functions",documentationLink:"https://refactoring.guru/smells/long-parameter-list"})},schema:[{type:"object",properties:{max:{type:"number",default:4,minimum:1},ignoreConstructors:{type:"boolean",default:false},ignoreOverriddenMethods:{type:"boolean",default:false}},additionalProperties:false}]},defaultOptions:[{max:4,ignoreConstructors:false,ignoreOverriddenMethods:false}],create(context,[options={}]){const{max=4,ignoreConstructors=false}=options||{};function checkFunction(node){if(ignoreConstructors){if(node.type==="FunctionDeclaration"&&node.id&&node.id.name&&/^[A-Z]/.test(node.id.name)){return}}const paramCount=countParameters(node);if(paramCount<=max){return}const functionSignature=(0,eslint_devkit_3.extractFunctionSignature)(node);const overBy=paramCount-max;context.report({node,messageId:"tooManyParameters",data:{functionName:functionSignature,count:String(paramCount),max:String(max),overBy:String(overBy)},suggest:[{messageId:"useObjectParameter",fix:()=>null},{messageId:"extractToClass",fix:()=>null},{messageId:"splitFunction",fix:()=>null}]})}return{FunctionDeclaration:checkFunction,FunctionExpression:checkFunction,ArrowFunctionExpression:checkFunction}}});