eslint-plugin-lube 0.8.0 → 0.8.1

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 0.8.1
+
+### Fixed
+
+- `svelte-naming-convention` no longer reports or renames an ambient TypeScript declaration (`declare function`, `declare const`, `declare let`, `declare var`, `declare class`, and anything inside `declare global { }` or `declare module "m" { }`) or its usages, since the name belongs to the host that injects it.
+- `svelte-naming-convention` renames every overload signature and the implementation of a function together with its calls, instead of only the calls.
+
 ## 0.8.0
 
 ### Breaking

package/docs/svelte-naming-convention.md

@@ -6,6 +6,7 @@ The strict config turns it on and the recommended config leaves it off, since it
 - The message names the expected name, `Rename 'camelCase' to 'camel_case'`, or, for a name without a snake_case form such as `NO_SNAKE__CASE`, asks for snake_case, UPPER_SNAKE_CASE or PascalCase.
 - Usages such as assignments, function bodies, `extends` clauses, JSX and TypeScript expressions are only renamed along with their declaration; `fixSameNames` sets the order.
 - Usages are matched to declarations by scope, so a global, an import or an exported camelCase function of the same name is left as it is.
+- An ambient TypeScript declaration, `declare function acquireVsCodeApi(): Api`, `declare const`, `declare class`, or anything inside `declare global { }` or `declare module "m" { }`, names a binding the code does not own: it is neither reported nor renamed, and neither are its usages.
 - A declaration exported with `export { camelCase }` is renamed together with the export specifier, `export { camel_case as camelCase }`.
 - The JSDoc of a renamed parameter follows it: `@param {T} [camelCase]`, `{camelCase is T}` and `{typeof camelCase}`.
 - In a `.svelte` file, the store subscriptions of a renamed store are renamed with it, `$camelCase` into `$camel_case`, in the same fix, and so are the usages in the markup: mustache tags, attributes, directives and the expression of `{#if}`, `{#each}`, `{#await}` and `{#key}`. A shorthand attribute is written out, `{camelCase}` into `camelCase={camel_case}`, so the name of the property stays. Names the markup declares, the context of `{#each}`, the value of `{#await}` and a `let:` property, are not reported.

package/package.json

@@ -7,11 +7,6 @@
     "@stylistic/eslint-plugin": "^5.10.0"
   },
   "description": "Fixable ESLint rules that format code without Prettier",
-  "devDependencies": {
-    "@types/estree": "^1.0.9",
-    "@typescript/native": "npm:typescript@^7.0.2",
-    "eslint": "^10.12.0"
-  },
   "engines": {
     "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
   },
@@ -53,7 +48,7 @@
   },
   "type": "module",
   "types": "types/index.d.ts",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "scripts": {
     "dts": "node ../../scripts/tsc_with_clean.js eslint-plugin-lube",
     "lint": "pnpm -w lint",

package/src/rules/svelte-naming-convention.js

@@ -188,7 +188,9 @@ export default {
 		 * @returns {void}
 		 */
 		function declare(node) {
-			add(declarations, node)
+			if (!is_ambient(node)) {
+				add(declarations, node)
+			}
 		}
 		/**
 		 * @param {import("../../private.js").AstNode & import("estree").Identifier} node
@@ -234,6 +236,22 @@ export default {
 			}
 			return depth > 0
 		}
+		/**
+		 * @param {import("../../private.js").AstNode} node
+		 * @returns {boolean}
+		 */
+		function is_ambient(node) {
+			for (
+				let current = /** @type {import("../../private.js").AstNode | undefined} */(node)/**/;
+				current;
+				current = current.parent
+			) {
+				if ("declare" in current && current.declare === true) {
+					return true
+				}
+			}
+			return false
+		}
 		/**
 		 * @param {import("../../private.js").AstNode} node
 		 * @returns {boolean}
@@ -916,7 +934,7 @@ export default {
 					plans.set(
 						name,
 						{
-							atomic: !fix_same_names || variables_by_name.has(target) || nested_targets.has(target) || store_usages.has(name),
+							atomic: !fix_same_names || nodes.length > 1 || variables_by_name.has(target) || nested_targets.has(target) || store_usages.has(name),
 							exported: (export_locals.get(name) ?? []).filter(belongs),
 							fixable: !blocked.has(name)
 								&& fixable_name_regex.test(name)
@@ -930,21 +948,16 @@ export default {
 				}
 				/**
 				 * @param {import("../../private.js").NamingIdentifier} node
-				 * @param {import("../../private.js").NamingIdentifier[]} nodes
 				 * @param {import("../../private.js").NamingIdentifier[]} usages_held
 				 * @returns {import("../../private.js").RenameEdit[]}
 				 */
-				function declaration_fix(node, nodes, usages_held) {
+				function declaration_fix(node, usages_held) {
 					const variable = resolution.get(node)
 					return [
 						...declaration_edits(node, resolution),
-						...nodes.find(
-							other => resolution.get(other) == variable
-						) == node
-							? usages_held.filter(
-								usage => resolution.get(usage) == variable
-							).map(rename_edit)
-							: []
+						...usages_held.filter(
+							usage => resolution.get(usage) == variable
+						).map(rename_edit)
 					]
 				}
 				/** @type {import("../../private.js").RenameEdit[]} */
@@ -990,7 +1003,7 @@ export default {
 						for (const node of nodes) {
 							report(
 								node,
-								fixable && !used.length ? declaration_fix(node, nodes, usages_held) : null
+								fixable && !used.length ? declaration_fix(node, usages_held) : null
 							)
 						}
 					} else {