eslint-plugin-lube 0.5.0 → 0.5.1

package/index.js

@@ -21,14 +21,14 @@ Object.assign(
 			"arrow-parens": [ "error", "as-needed" ],
 			"arrow-spacing": [
 				"error",
-				{ "before": true, "after": true }
+				{ "after": true, "before": true }
 			],
 			"block-spacing": [ "error", "always" ],
 			"brace-style": [ "error", "1tbs" ],
 			"comma-dangle": [ "error", "never" ],
 			"comma-spacing": [
 				"error",
-				{ "before": false, "after": true }
+				{ "after": true, "before": false }
 			],
 			"comma-style": [ "error", "last" ],
 			"computed-property-spacing": [ "error", "never" ],
@@ -50,6 +50,10 @@ Object.assign(
 				"error",
 				{ "after": true, "before": true }
 			],
+			"lube/pretty-imports": "error",
+			"lube/pretty-jsdoc-casting": "error",
+			"lube/pretty-sequence": "error",
+			"lube/svelte-naming-convention": "error",
 			"max-len": [ "warn", 120 ],
 			"max-statements-per-line": [ "error", { "max": 1 } ],
 			"multiline-ternary": [ "error", "always-multiline" ],
@@ -76,6 +80,7 @@ Object.assign(
 			],
 			"object-curly-newline": [ "error", { "consistent": true } ],
 			"object-curly-spacing": [ "error", "always" ],
+			"one-var": [ "error", "never" ],
 			"operator-linebreak": [ "error", "before" ],
 			"prefer-const": [
 				"warn",
@@ -105,7 +110,7 @@ Object.assign(
 			"space-infix-ops": [ "error", { "int32Hint": true } ],
 			"space-unary-ops": [
 				"error",
-				{ "words": true, "nonwords": false }
+				{ "nonwords": false, "words": true }
 			],
 			"switch-colon-spacing": [
 				"error",
@@ -113,11 +118,7 @@ Object.assign(
 			],
 			"template-curly-spacing": [ "error", "never" ],
 			"template-tag-spacing": [ "error", "never" ],
-			"yield-star-spacing": [ "error", "after" ],
-			"lube/pretty-imports": "error",
-			"lube/pretty-jsdoc-casting": "error",
-			"lube/pretty-sequence": "error",
-			"lube/svelte-naming-convention": "error"
+			"yield-star-spacing": [ "error", "after" ]
 		}
 	}
 )

package/package.json

@@ -20,6 +20,7 @@
 		"jsdoc"
 	],
 	"license": "MIT",
+	"main": "index.js",
 	"name": "eslint-plugin-lube",
 	"peerDependencies": {
 		"eslint": ">=9.0.0"
@@ -30,9 +31,10 @@
 		"url": "https://github.com/Artxe2/lube-series"
 	},
 	"scripts": {
-		"dts": "tsc",
+		"dts": "node ../../scripts/tsc_with_clean.js eslint-plugin-lube",
 		"test": "mocha"
 	},
 	"type": "commonjs",
-	"version": "0.5.0"
+	"types": "types/index.d.ts",
+	"version": "0.5.1"
 }

package/rules/svelte-naming-convention.js

@@ -346,10 +346,10 @@ module.exports = {
 					// while (camelCase) {}
 					defer(node)
 					break
-				case "WithStatement":
-					// with (camelCase) {}
-					defer(node)
-					break
+				// case "WithStatement":
+				// 	// with (camelCase) {}
+				// 	defer(node)
+				// 	break
 				case "YieldExpression":
 					// function* func() { yield camelCase }
 					defer(node)

package/test/pretty-imports/ExportNamedDeclaration.js

@@ -41,16 +41,16 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					messageId: "exports",
-					type: "ExportNamedDeclaration",
+					column: 4,
 					line: 3,
-					column: 4
+					messageId: "exports",
+					type: "ExportNamedDeclaration"
 				},
 				{
-					messageId: "exports",
-					type: "ExportNamedDeclaration",
+					column: 7,
 					line: 4,
-					column: 7
+					messageId: "exports",
+					type: "ExportNamedDeclaration"
 				}
 			],
 			options: [
@@ -84,16 +84,16 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					messageId: "exports",
-					type: "ExportNamedDeclaration",
+					column: 4,
 					line: 3,
-					column: 4
+					messageId: "exports",
+					type: "ExportNamedDeclaration"
 				},
 				{
-					messageId: "exports",
-					type: "ExportNamedDeclaration",
+					column: 7,
 					line: 4,
-					column: 7
+					messageId: "exports",
+					type: "ExportNamedDeclaration"
 				}
 			],
 			options: [

package/test/pretty-imports/ImportDeclaration.js

@@ -43,16 +43,16 @@ import {
 			`,
 			errors: [
 				{
-					messageId: "imports",
-					type: "ImportDeclaration",
+					column: 4,
 					line: 3,
-					column: 4
+					messageId: "imports",
+					type: "ImportDeclaration"
 				},
 				{
-					messageId: "imports",
-					type: "ImportDeclaration",
+					column: 7,
 					line: 4,
-					column: 7
+					messageId: "imports",
+					type: "ImportDeclaration"
 				}
 			],
 			options: [
@@ -86,16 +86,16 @@ import {
 			`,
 			errors: [
 				{
-					messageId: "imports",
-					type: "ImportDeclaration",
+					column: 4,
 					line: 3,
-					column: 4
+					messageId: "imports",
+					type: "ImportDeclaration"
 				},
 				{
-					messageId: "imports",
-					type: "ImportDeclaration",
+					column: 7,
 					line: 4,
-					column: 7
+					messageId: "imports",
+					type: "ImportDeclaration"
 				}
 			],
 			options: [

package/test/pretty-jsdoc-casting/case_by_expression.js

@@ -14,11 +14,36 @@ const test_case = (type, value) => ({
 	var value = ((/** @type {E} */(${value})))
 	`,
 	errors: [
-		{ line: 2, column: 13, type },
-		{ line: 3, column: 13, type },
-		{ line: 4, column: 13, type },
-		{ line: 7, column: 13, type },
-		{ line: 8, column: 13, type }
+		{
+			column: 13,
+			line: 2,
+			messageId: "not_match",
+			type
+		},
+		{
+			column: 13,
+			line: 3,
+			messageId: "not_match",
+			type
+		},
+		{
+			column: 13,
+			line: 4,
+			messageId: "not_match",
+			type
+		},
+		{
+			column: 13,
+			line: 7,
+			messageId: "not_match",
+			type
+		},
+		{
+			column: 13,
+			line: 8,
+			messageId: "not_match",
+			type
+		}
 	],
 	output: `
 	var value = /** @type {A} */(${value})/**/
@@ -60,28 +85,33 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 24,
+					line: 2,
+					messageId: "not_match",
 					type: "AwaitExpression"
 				},
 				{
-					line: 3,
 					column: 31,
+					line: 3,
+					messageId: "not_match",
 					type: "AwaitExpression"
 				},
 				{
-					line: 4,
 					column: 31,
+					line: 4,
+					messageId: "not_match",
 					type: "AwaitExpression"
 				},
 				{
-					line: 7,
 					column: 7,
+					line: 7,
+					messageId: "not_match",
 					type: "AwaitExpression"
 				},
 				{
-					line: 8,
 					column: 33,
+					line: 8,
+					messageId: "not_match",
 					type: "AwaitExpression"
 				}
 			],
@@ -137,28 +167,33 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 18,
+					line: 2,
+					messageId: "not_match",
 					type: "MetaProperty"
 				},
 				{
-					line: 3,
 					column: 34,
+					line: 3,
+					messageId: "not_match",
 					type: "MetaProperty"
 				},
 				{
-					line: 4,
 					column: 34,
+					line: 4,
+					messageId: "not_match",
 					type: "MetaProperty"
 				},
 				{
-					line: 7,
 					column: 7,
+					line: 7,
+					messageId: "not_match",
 					type: "MetaProperty"
 				},
 				{
-					line: 8,
 					column: 36,
+					line: 8,
+					messageId: "not_match",
 					type: "MetaProperty"
 				}
 			],
@@ -205,28 +240,33 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 19,
+					line: 2,
+					messageId: "not_match",
 					type: "YieldExpression"
 				},
 				{
-					line: 3,
 					column: 31,
+					line: 3,
+					messageId: "not_match",
 					type: "YieldExpression"
 				},
 				{
-					line: 4,
 					column: 31,
+					line: 4,
+					messageId: "not_match",
 					type: "YieldExpression"
 				},
 				{
-					line: 7,
 					column: 7,
+					line: 7,
+					messageId: "not_match",
 					type: "YieldExpression"
 				},
 				{
-					line: 8,
 					column: 33,
+					line: 8,
+					messageId: "not_match",
 					type: "YieldExpression"
 				}
 			],

package/test/pretty-jsdoc-casting/various_situations.js

@@ -37,30 +37,44 @@ exports.module = (valid, invalid) => {
 				.../** @type {X} */(x)/**/
 			})/**/;
 			/** @type {Y} */(y, /** @type {Z} */(z[/** @type {123} */(123)/**/])/**/)/**/`,
-			languageOptions: {
-				parserOptions: { ecmaVersion: "latest" }
+			languageOptions: {
+				parserOptions: { ecmaVersion: "latest" }
 			}
 		}
 	)
 	invalid.push(
 		{
 			code: "var v = /**@type {A}*/(a)/**/",
-			errors: [ { column: 8, line: 1 } ],
+			errors: [
+				{
+					column: 8,
+					line: 1,
+					messageId: "not_match"
+				}
+			],
 			output: "var v = /** @type {A} */(a)/**/"
 		},
 		{
 			code: "var v = /** @type {A} */(  /** @type {B} */(/** @type {C} */((a) /* block... */))) // line...",
-			errors: [ { column: 8, line: 1 } ],
+			errors: [
+				{
+					column: 8,
+					line: 1,
+					messageId: "not_match"
+				}
+			],
+			// eslint-disable-next-line max-len
 			output: "var v =   /** @type {A} */(/** @type {B} */(/** @type {C} */((a))/**/)/**/)/**/ /* block... */ // line..."
 		},
 		{
 			code: "var v = { b: /** @type {A} */(a) }",
-			errors: [ { column: 13, line: 1 } ],
-			output: "var v = { b: /** @type {A} */(a)/**/ }"
-		},
-		{
-			code: "var v = { b: /** @type {A} */(a) }",
-			errors: [ { column: 13, line: 1 } ],
+			errors: [
+				{
+					column: 13,
+					line: 1,
+					messageId: "not_match"
+				}
+			],
 			output: "var v = { b: /** @type {A} */(a)/**/ }"
 		},
 		{
@@ -75,7 +89,9 @@ exports.module = (valid, invalid) => {
 				.../** @type {X} */(x)
 			});
 			/** @type {Y} */(y, /** @type {Z} */(z[/** @type {123} */(123)]))`,
-			errors: [ ...new Array(21).fill({}) ],
+			errors: [
+				...new Array(21).fill({ messageId: "not_match" })
+			],
 			output: `var v = /** @type {V} */({
 				a: /** @type {A} */([/** @type {B} */(b)/**/, /** @type {C} */(c)/**/, /** @type {D} */(d)/**/])/**/,
 				e: /** @type {F} */(f)/**/(/** @type {G} */(g)/**/, /** @type {E} */(E)/**/, /** @type {I} */(i)/**/),
@@ -87,8 +103,8 @@ exports.module = (valid, invalid) => {
 				.../** @type {X} */(x)/**/
 			})/**/;
 			/** @type {Y} */(y, /** @type {Z} */(z[/** @type {123} */(123)/**/])/**/)/**/`,
-			languageOptions: {
-				parserOptions: { ecmaVersion: "latest" }
+			languageOptions: {
+				parserOptions: { ecmaVersion: "latest" }
 			}
 		}
 	)

package/test/pretty-sequence/case_by_node_type.js

@@ -12,13 +12,15 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 17,
+					line: 2,
+					messageId: "not_match",
 					type: "ArrayExpression"
 				},
 				{
-					line: 3,
 					column: 17,
+					line: 3,
+					messageId: "not_match",
 					type: "ArrayExpression"
 				}
 			],
@@ -40,13 +42,15 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 9,
+					line: 2,
+					messageId: "not_match",
 					type: "ArrayPattern"
 				},
 				{
-					line: 3,
 					column: 9,
+					line: 3,
+					messageId: "not_match",
 					type: "ArrayPattern"
 				}
 			],
@@ -59,8 +63,8 @@ exports.module = (valid, invalid) => {
 			] = value
 			var [] = value
 			`,
-			languageOptions: {
-				parserOptions: { ecmaVersion: "latest" }
+			languageOptions: {
+				parserOptions: { ecmaVersion: "latest" }
 			}
 		},
 		{
@@ -78,13 +82,15 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 17,
+					line: 2,
+					messageId: "not_match",
 					type: "ArrowFunctionExpression"
 				},
 				{
-					line: 5,
 					column: 17,
+					line: 5,
+					messageId: "not_match",
 					type: "ArrowFunctionExpression"
 				}
 			],
@@ -104,8 +110,8 @@ exports.module = (valid, invalid) => {
 			var value = async a => b
 			var value = async (a, b, c) => {}
 			`,
-			languageOptions: {
-				parserOptions: { ecmaVersion: "latest" }
+			languageOptions: {
+				parserOptions: { ecmaVersion: "latest" }
 			}
 		},
 		{
@@ -116,18 +122,20 @@ exports.module = (valid, invalid) => {
 			function func2(aaaaaaaaaa, bbbbbbbbbbb, ccccccccccc) {
 				//
 			}
-			function func() {}
-			async function func() {}
+			function func3() {}
+			async function func4() {}
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 18,
+					line: 2,
+					messageId: "not_match",
 					type: "FunctionDeclaration"
 				},
 				{
-					line: 5,
 					column: 19,
+					line: 5,
+					messageId: "not_match",
 					type: "FunctionDeclaration"
 				}
 			],
@@ -142,11 +150,11 @@ exports.module = (valid, invalid) => {
 			) {
 				//
 			}
-			function func() {}
-			async function func() {}
+			function func3() {}
+			async function func4() {}
 			`,
-			languageOptions: {
-				parserOptions: { ecmaVersion: "latest" }
+			languageOptions: {
+				parserOptions: { ecmaVersion: "latest" }
 			}
 		},
 		{
@@ -162,13 +170,15 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 26,
+					line: 2,
+					messageId: "not_match",
 					type: "FunctionExpression"
 				},
 				{
-					line: 5,
 					column: 26,
+					line: 5,
+					messageId: "not_match",
 					type: "FunctionExpression"
 				}
 			],
@@ -186,8 +196,8 @@ exports.module = (valid, invalid) => {
 			var value = function () {}
 			var value = async function () {}
 			`,
-			languageOptions: {
-				parserOptions: { ecmaVersion: "latest" }
+			languageOptions: {
+				parserOptions: { ecmaVersion: "latest" }
 			}
 		},
 		{
@@ -198,13 +208,15 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 9,
+					line: 2,
+					messageId: "not_match",
 					type: "CallExpression"
 				},
 				{
-					line: 3,
 					column: 9,
+					line: 3,
+					messageId: "not_match",
 					type: "CallExpression"
 				}
 			],
@@ -226,13 +238,15 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 10,
+					line: 2,
+					messageId: "not_match",
 					type: "NewExpression"
 				},
 				{
-					line: 3,
 					column: 10,
+					line: 3,
+					messageId: "not_match",
 					type: "NewExpression"
 				}
 			],
@@ -254,13 +268,15 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 17,
+					line: 2,
+					messageId: "not_match",
 					type: "ObjectExpression"
 				},
 				{
-					line: 3,
 					column: 17,
+					line: 3,
+					messageId: "not_match",
 					type: "ObjectExpression"
 				}
 			],
@@ -273,8 +289,8 @@ exports.module = (valid, invalid) => {
 			}
 			var value = {}
 			`,
-			languageOptions: {
-				parserOptions: { ecmaVersion: "latest" }
+			languageOptions: {
+				parserOptions: { ecmaVersion: "latest" }
 			}
 		},
 		{
@@ -285,13 +301,15 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 9,
+					line: 2,
+					messageId: "not_match",
 					type: "ObjectPattern"
 				},
 				{
-					line: 3,
 					column: 9,
+					line: 3,
+					messageId: "not_match",
 					type: "ObjectPattern"
 				}
 			],
@@ -304,8 +322,8 @@ exports.module = (valid, invalid) => {
 			} = value
 			var {} = value
 			`,
-			languageOptions: {
-				parserOptions: { ecmaVersion: "latest" }
+			languageOptions: {
+				parserOptions: { ecmaVersion: "latest" }
 			}
 		},
 		{
@@ -318,13 +336,15 @@ exports.module = (valid, invalid) => {
 			`,
 			errors: [
 				{
-					line: 2,
 					column: 4,
+					line: 2,
+					messageId: "not_match",
 					type: "SequenceExpression"
 				},
 				{
-					line: 6,
 					column: 4,
+					line: 6,
+					messageId: "not_match",
 					type: "SequenceExpression"
 				}
 			],