eslint-plugin-lube 0.3.3 → 0.3.4

package/index.js

@@ -9,41 +9,132 @@ module.exports = {
 			extends: ["eslint:recommended"],
 			plugins: ["lube"],
 			rules: {
-				"arrow-spacing": "error",
-				"comma-spacing": "error",
+				"array-bracket-newline": [
+					"error", {
+						"multiline": true
+					}
+				],
+				"array-element-newline": ["error", "consistent"],
+				"arrow-parens": ["error", "as-needed"],
+				"arrow-spacing": [
+					"error", {
+						"before": true,
+						"after": true
+					}
+				],
+				"block-spacing": ["error", "always"],
+				"brace-style": ["error", "1tbs"],
+				"comma-dangle": ["error", "never"],
+				"comma-spacing": [
+					"error", {
+						"before": false,
+						"after": true
+					}
+				],
+				"comma-style": ["error", "last"],
+				"computed-property-spacing": ["error", "never"],
 				"dot-location": ["error", "property"],
-				"for-direction": "error",
-				"getter-return": "error",
+				"eol-last": ["error", "never"],
+				"func-call-spacing": ["error", "never"],
+				"function-call-argument-newline": ["error", "consistent"],
+				"generator-star-spacing": ["error", "after"],
 				"indent": ["error", "tab"],
-				"keyword-spacing": ["error", {
-					"after": true,
-					"before": true
-				}],
+				"jsx-quotes": ["error", "prefer-double"],
+				"key-spacing": [
+					"error", {
+						"afterColon": true,
+						"beforeColon": false
+					}
+				],
+				"keyword-spacing": [
+					"error", {
+						"after": true,
+						"before": true
+					}
+				],
 				"max-len": ["warn", 120],
 				"max-nested-callbacks": ["error", 3],
+				"max-statements-per-line": [
+					"error", {
+						"max": 1
+					}
+				],
+				"multiline-ternary": ["error", "always-multiline"],
+				"newline-per-chained-call": [
+					"error", {
+						"ignoreChainWithDepth": 2
+					}
+				],
+				"no-await-in-loop": "error",
 				"no-console": "warn",
 				"no-duplicate-imports": "error",
-				"no-empty-pattern": "error",
+				"no-lonely-if": "error",
 				"no-multi-spaces": "error",
+				"no-new-native-nonconstructor": "error",
+				"no-self-compare": "error",
+				"no-shadow": "error",
+				"no-shadow-restricted-names": "error",
+				"no-trailing-spaces": [
+					"error", {
+						"ignoreComments": false,
+						"skipBlankLines": false
+					}
+				],
+				"object-curly-newline": [
+					"error", {
+						"consistent": true
+					}
+				],
 				"object-curly-spacing": ["error", "always"],
-				"prefer-const": "warn",
+				"operator-linebreak": ["error", "before"],
+				"prefer-const": [
+					"warn", {
+						"destructuring": "all",
+						"ignoreReadBeforeAssign": false
+					}
+				],
 				"quotes": ["error", "double"],
+				"rest-spread-spacing": ["error", "never"],
 				"semi": ["error", "never"],
-				"semi-spacing": ["error", {
-					"after": true,
-					"before": false
-				}],
-				"space-before-function-paren": ["error", {
-					"anonymous": "never",
-					"asyncArrow": "always",
-					"named": "never"
-				}],
+				"semi-spacing": [
+					"error", {
+						"after": true,
+						"before": false
+					}
+				],
+				"semi-style": ["error", "first"],
+				"space-before-blocks": ["error", "always"],
+				"space-before-function-paren": [
+					"error", {
+						"anonymous": "never",
+						"asyncArrow": "always",
+						"named": "never"
+					}
+				],
 				"space-in-parens": ["error", "never"],
-				"space-infix-ops": "error",
-				"space-unary-ops": "error",
+				"space-infix-ops": [
+					"error", {
+						"int32Hint": true
+					}
+				],
+				"space-unary-ops": [
+					"error", {
+						"words": true,
+						"nonwords": false
+					}
+				],
+				"switch-colon-spacing": [
+					"error", {
+						"after": true,
+						"before": false
+					}
+				],
+				"template-curly-spacing": ["error", "never"],
+				"template-tag-spacing": ["error", "never"],
+				"yield-star-spacing": ["error", "after"],
 				"lube/pretty-imports": "error",
 				"lube/pretty-jsdoc-casting": "error",
-				"lube/svelte-naming-convention": "error",
+				"lube/svelte-naming-convention": "error"
 			}
 		}
 	},

package/package.json

@@ -22,5 +22,5 @@
 		"test": "mocha"
 	},
 	"type": "commonjs",
-	"version": "0.3.3"
+	"version": "0.3.4"
 }

package/rules/pretty-imports.js

@@ -12,31 +12,33 @@ module.exports = {
 			exports: "This exports is not pretty",
 			imports: "This imports is not pretty"
 		},
-		schema: [{
-			properties: {
-				checkExports: {
-					type: "boolean",
-					default: true
-				},
-				checkImports: {
-					type: "boolean",
-					default: true
-				},
-				indent: {
-					type: "string",
-					default: "\t"
-				},
-				maxLength: {
-					type: "number",
-					default: 30
+		schema: [
+			{
+				properties: {
+					checkExports: {
+						type: "boolean",
+						default: true
+					},
+					checkImports: {
+						type: "boolean",
+						default: true
+					},
+					indent: {
+						type: "string",
+						default: "\t"
+					},
+					maxLength: {
+						type: "number",
+						default: 30
+					},
+					semicolon: {
+						type: "boolean",
+						default: false
+					}
 				},
-				semicolon: {
-					type: "boolean",
-					default: false
-				}
-			},
-			type: "object"
-		}],
+				type: "object"
+			}
+		],
 		type: "layout"
 	},
 	create(context) {
@@ -110,12 +112,12 @@ module.exports = {
 					}
 					let corrected_text = length > max_length
 						? `export {\n${line_indent + indent}${
-							
+
 							/** @type {import("../private").AstNode[]} */(node.specifiers)/**/.map(get_text)
 								.join(",\n" + line_indent + indent)
 						}\n${line_indent}}`
 						: `export { ${
-							
+
 							/** @type {import("../private").AstNode[]} */(node.specifiers)/**/.map(get_text).join(", ")
 						} }`
 					if (node.source) {
@@ -140,12 +142,12 @@ module.exports = {
 					}
 					let corrected_text = length > max_length
 						? `import {\n${line_indent + indent}${
-							
+
 							/** @type {import("../private").AstNode[]} */(node.specifiers)/**/.map(get_text)
 								.join(",\n" + line_indent + indent)
 						}\n${line_indent}} from ${node.source.raw}`
 						: `import { ${
-							
+
 							/** @type {import("../private").AstNode[]} */(node.specifiers)/**/.map(get_text).join(", ")
 						} } from ${node.source.raw}`
 					if (semicolon) {

package/rules/pretty-jsdoc-casting.js

@@ -88,18 +88,18 @@ module.exports = {
 						}
 					}
 				} else {
-					const space = left_space_regex.exec(origin_text.slice(0, left))?.[0].length
-					if (space) {
-						left -= space
+					const left_space = left_space_regex.exec(origin_text.slice(0, left))?.[0].length
+					if (left_space) {
+						left -= left_space
 					} else if (origin_text[left - 1] == "(") {
 						while (right < text_length) {
 							if (comments[right]) {
 								const comment = comments[right]
 								right = comment.range[1]
 							} else {
-								const space = right_space_regex.exec(origin_text.slice(right))?.[0].length
-								if (space) {
-									right += space
+								const right_space = right_space_regex.exec(origin_text.slice(right))?.[0].length
+								if (right_space) {
+									right += right_space
 								} else {
 									if (origin_text[right] == ")") {
 										prev_open = left--

package/rules/svelte-naming-convention.js

@@ -11,15 +11,17 @@ module.exports = {
 		messages: {
 			not_match: "Identifier '{{name}}' does not match for svelte's naming conventions."
 		},
-		schema: [{
-			properties: {
-				fixSameNames: {
-					type: "boolean",
-					default: true
+		schema: [
+			{
+				properties: {
+					fixSameNames: {
+						type: "boolean",
+						default: true
+					}
 				},
-			},
-			type: "object"
-		}],
+				type: "object"
+			}
+		],
 		type: "layout"
 	},
 	create(context) {
@@ -199,7 +201,7 @@ module.exports = {
 					break
 				case "FunctionDeclaration":
 					// function camelCase() {}
-					if ( 
+					if (
 						parent.parent?.type != "ExportNamedDeclaration"
 						|| !camel_case_regex.test(name)
 					) {
@@ -240,8 +242,7 @@ module.exports = {
 					// object.property
 					if (parent.object == node) {
 						defer(node)
-					}
-					else if (parent.computed) {
+					} else if (parent.computed) {
 						// object[camelCase]
 						// camelCase[key]
 						defer(node)
@@ -327,7 +328,7 @@ module.exports = {
 				case "VariableDeclarator":
 					// var id = init
 					if (parent.id == node) {
-						if ( 
+						if (
 							parent.parent?.parent?.type != "ExportNamedDeclaration"
 							|| !camel_case_regex.test(name)
 						) {

package/test/pretty-imports/ExportNamedDeclaration.js

@@ -1,5 +1,5 @@
 /**
- * @param {import("eslint").RuleTester.ValidTestCase[]} valid 
+ * @param {import("eslint").RuleTester.ValidTestCase[]} valid
  * @param {import("eslint").RuleTester.InvalidTestCase[]} invalid
  */
 exports.module = (valid, invalid) => {
@@ -49,10 +49,12 @@ exports.module = (valid, invalid) => {
 					column: 7
 				}
 			],
-			options: [{
-				maxLength: 10,
-				semicolon: true
-			}],
+			options: [
+				{
+					maxLength: 10,
+					semicolon: true
+				}
+			],
 			output: `
 
 			export { a, b as c, d } from 'module';
@@ -91,10 +93,12 @@ exports.module = (valid, invalid) => {
 					column: 7
 				}
 			],
-			options: [{
-				indent: "  ",
-				maxLength: 10
-			}],
+			options: [
+				{
+					indent: "  ",
+					maxLength: 10
+				}
+			],
 			output: `
 
 			export { a, b as c, d } from 'module'

package/test/pretty-imports/ImportDeclaration.js

@@ -1,5 +1,5 @@
 /**
- * @param {import("eslint").RuleTester.ValidTestCase[]} valid 
+ * @param {import("eslint").RuleTester.ValidTestCase[]} valid
  * @param {import("eslint").RuleTester.InvalidTestCase[]} invalid
  */
 exports.module = (valid, invalid) => {
@@ -51,10 +51,12 @@ import {
 					column: 7
 				}
 			],
-			options: [{
-				maxLength: 10,
-				semicolon: true
-			}],
+			options: [
+				{
+					maxLength: 10,
+					semicolon: true
+				}
+			],
 			output: `
 
 			import { a, b as c, d } from 'module';
@@ -93,10 +95,12 @@ import {
 					column: 7
 				}
 			],
-			options: [{
-				indent: "  ",
-				maxLength: 10
-			}],
+			options: [
+				{
+					indent: "  ",
+					maxLength: 10
+				}
+			],
 			output: `
 
 			import { a, b as c, d } from 'module'

package/test/pretty-imports.js

@@ -12,7 +12,7 @@ require("./pretty-imports/ImportDeclaration").module(valid, invalid)
 new RuleTester().run(
 	"pretty-imports",
 	require("../rules/pretty-imports"),
-	{ 
+	{
 		valid,
 		invalid
 	}

package/test/pretty-jsdoc-casting/case_by_expression.js

@@ -1,6 +1,6 @@
 /**
- * @param {keyof import("estree").ExpressionMap} type 
- * @param {string} value 
+ * @param {keyof import("estree").ExpressionMap} type
+ * @param {string} value
  * @returns {import("eslint").RuleTester.InvalidTestCase}
  */
 const test_case = (type, value) => ({
@@ -53,7 +53,7 @@ const test_case = (type, value) => ({
 })
 
 /**
- * @param {import("eslint").RuleTester.ValidTestCase[]} valid 
+ * @param {import("eslint").RuleTester.ValidTestCase[]} valid
  * @param {import("eslint").RuleTester.InvalidTestCase[]} invalid
  */
 exports.module = (valid, invalid) => {

package/test/pretty-jsdoc-casting/nested_casting.js

@@ -1,5 +1,5 @@
 /**
- * @param {import("eslint").RuleTester.ValidTestCase[]} valid 
+ * @param {import("eslint").RuleTester.ValidTestCase[]} valid
  * @param {import("eslint").RuleTester.InvalidTestCase[]} invalid
  */
 exports.module = (valid, invalid) => {
@@ -45,34 +45,42 @@ exports.module = (valid, invalid) => {
 	invalid.push(
 		{
 			code: "var v = /**@type {A}*/(a)/**/",
-			errors: [{
-				column: 8,
-				line: 1
-			}],
+			errors: [
+				{
+					column: 8,
+					line: 1
+				}
+			],
 			output: "var v = /** @type {A} */(a)/**/"
 		},
 		{
 			code: "var v = /** @type {A} */(  /** @type {B} */(/** @type {C} */((a) /* block... */))) // line...",
-			errors: [{
-				column: 8,
-				line: 1
-			}],
+			errors: [
+				{
+					column: 8,
+					line: 1
+				}
+			],
 			output: "var v =   /** @type {A} */(/** @type {B} */(/** @type {C} */((a))/**/)/**/)/**/ /* block... */ // line..."
 		},
 		{
 			code: "var v = { b: /** @type {A} */(a) }",
-			errors: [{
-				column: 13,
-				line: 1
-			}],
+			errors: [
+				{
+					column: 13,
+					line: 1
+				}
+			],
 			output: "var v = { b: /** @type {A} */(a)/**/ }"
 		},
 		{
 			code: "var v = { b: /** @type {A} */(a) }",
-			errors: [{
-				column: 13,
-				line: 1
-			}],
+			errors: [
+				{
+					column: 13,
+					line: 1
+				}
+			],
 			output: "var v = { b: /** @type {A} */(a)/**/ }"
 		},
 		{

package/test/pretty-jsdoc-casting.js

@@ -12,7 +12,7 @@ require("./pretty-jsdoc-casting/nested_casting").module(valid, invalid)
 new RuleTester().run(
 	"pretty-jsdoc-casting",
 	require("../rules/pretty-jsdoc-casting"),
-	{ 
+	{
 		valid,
 		invalid
 	}

package/test/svelte-naming-convention/basic_snake_case.js

@@ -1,5 +1,5 @@
 /**
- * @param {import("eslint").RuleTester.ValidTestCase[]} valid 
+ * @param {import("eslint").RuleTester.ValidTestCase[]} valid
  * @param {import("eslint").RuleTester.InvalidTestCase[]} invalid
  */
 exports.module = (valid, invalid) => {
@@ -14,32 +14,38 @@ exports.module = (valid, invalid) => {
 		{ code: "camelCase = 'Hello'" },
 		{ code: "var snake_case = camelCase" },
 		{ code: "var PascalCase = 'Hello'" },
-		{ code: "var P1ascal2Case345 = 'Hello'" },
+		{ code: "var P1ascal2Case345 = 'Hello'" }
 	)
 	invalid.push(
 		{
 			code: "var camelCase = 'Hello'",
-			errors: [{
-				line: 1,
-				column: 5
-			}],
+			errors: [
+				{
+					line: 1,
+					column: 5
+				}
+			],
 			output: "var camel_case = 'Hello'"
 		},
 		{
 			code: "var NO_SNAKE__CASE = 'Hello'",
-			errors: [{
-				line: 1,
-				column: 5
-			}],
+			errors: [
+				{
+					line: 1,
+					column: 5
+				}
+			],
 			output: "var NO_SNAKE__CASE = 'Hello'"
 		},
 		{
 			code: "var NO_SNAKE_CASE_ = 'Hello'",
-			errors: [{
-				line: 1,
-				column: 5
-			}],
+			errors: [
+				{
+					line: 1,
+					column: 5
+				}
+			],
 			output: "var NO_SNAKE_CASE_ = 'Hello'"
-		},
+		}
 	)
 }

package/test/svelte-naming-convention/case_by_identifier.js

@@ -1,5 +1,5 @@
 /**
- * @param {import("eslint").RuleTester.ValidTestCase[]} valid 
+ * @param {import("eslint").RuleTester.ValidTestCase[]} valid
  * @param {import("eslint").RuleTester.InvalidTestCase[]} invalid
  */
 exports.module = (valid, invalid) => {
@@ -36,20 +36,24 @@ exports.module = (valid, invalid) => {
 		// ArrayPattern
 		{
 			code: "var [ camelCase ] = value",
-			errors: [{
-				line: 1,
-				column: 7
-			}],
+			errors: [
+				{
+					line: 1,
+					column: 7
+				}
+			],
 			output: "var [ camel_case ] = value",
 			parserOptions: { ecmaVersion: "latest" }
 		},
 		// ArrowFunctionExpression
 		{
 			code: "(camelCase) => {}",
-			errors: [{
-				line: 1,
-				column: 2
-			}],
+			errors: [
+				{
+					line: 1,
+					column: 2
+				}
+			],
 			output: "(camel_case) => {}",
 			parserOptions: { ecmaVersion: "latest" }
 		},
@@ -237,10 +241,12 @@ exports.module = (valid, invalid) => {
 		// ClassDeclaration
 		{
 			code: "class camelCase {}",
-			errors: [{
-				line: 1,
-				column: 7
-			}],
+			errors: [
+				{
+					line: 1,
+					column: 7
+				}
+			],
 			output: "class camel_case {}",
 			parserOptions: { ecmaVersion: "latest" }
 		},
@@ -291,10 +297,12 @@ exports.module = (valid, invalid) => {
 			export * as camelCase from "module"
 			var camelCase
 			`,
-			errors: [{
-				line: 3,
-				column: 8
-			}],
+			errors: [
+				{
+					line: 3,
+					column: 8
+				}
+			],
 			output: `
 			export * as camelCase from "module"
 			var camel_case
@@ -310,10 +318,12 @@ exports.module = (valid, invalid) => {
 			export default camelCase
 			var camelCase
 			`,
-			errors: [{
-				line: 3,
-				column: 8
-			}],
+			errors: [
+				{
+					line: 3,
+					column: 8
+				}
+			],
 			options: [{ fixSameNames: false }],
 			output: `
 			export default camelCase
@@ -337,7 +347,7 @@ exports.module = (valid, invalid) => {
 				{
 					line: 3,
 					column: 8
-				},
+				}
 			],
 			output: `
 			export default camel_case
@@ -362,7 +372,7 @@ exports.module = (valid, invalid) => {
 				{
 					line: 3,
 					column: 19
-				},
+				}
 			],
 			output: `
 			export { default as camelCase, camelCase2 } from 'module'
@@ -549,10 +559,12 @@ exports.module = (valid, invalid) => {
 		// ImportDefaultSpecifier
 		{
 			code: "import camelCase from 'module'",
-			errors: [{
-				line: 1,
-				column: 8
-			}],
+			errors: [
+				{
+					line: 1,
+					column: 8
+				}
+			],
 			output: "import camel_case from 'module'",
 			parserOptions: {
 				ecmaVersion: "latest",
@@ -562,10 +574,12 @@ exports.module = (valid, invalid) => {
 		// ImportNamespaceSpecifier
 		{
 			code: "import * as camelCase from 'module'",
-			errors: [{
-				line: 1,
-				column: 13
-			}],
+			errors: [
+				{
+					line: 1,
+					column: 13
+				}
+			],
 			output: "import * as camel_case from 'module'",
 			parserOptions: {
 				ecmaVersion: "latest",
@@ -696,10 +710,12 @@ exports.module = (valid, invalid) => {
 			class ObjectB { camelCase() {} }
 			var camelCase
 			`,
-			errors: [{
-				line: 3,
-				column: 8
-			}],
+			errors: [
+				{
+					line: 3,
+					column: 8
+				}
+			],
 			output: `
 			class ObjectB { camelCase() {} }
 			var camel_case
@@ -721,7 +737,7 @@ exports.module = (valid, invalid) => {
 				},
 				{
 					line: 4,
-					column:8
+					column: 8
 				},
 				{
 					line: 5,
@@ -751,7 +767,7 @@ exports.module = (valid, invalid) => {
 				},
 				{
 					line: 4,
-					column:8
+					column: 8
 				},
 				{
 					line: 5,
@@ -930,7 +946,7 @@ exports.module = (valid, invalid) => {
 				},
 				{
 					line: 4,
-					column:8
+					column: 8
 				},
 				{
 					line: 5,
@@ -959,7 +975,7 @@ exports.module = (valid, invalid) => {
 				},
 				{
 					line: 4,
-					column:8
+					column: 8
 				},
 				{
 					line: 5,
@@ -988,7 +1004,7 @@ exports.module = (valid, invalid) => {
 				},
 				{
 					line: 4,
-					column:8
+					column: 8
 				},
 				{
 					line: 5,
@@ -1222,6 +1238,6 @@ exports.module = (valid, invalid) => {
 			function* func_c() { yield pending_a }
 			`,
 			parserOptions: { ecmaVersion: "latest" }
-		},
+		}
 	)
 }

package/test/svelte-naming-convention/snake_case_with_symbols.js

@@ -1,5 +1,5 @@
 /**
- * @param {import("eslint").RuleTester.ValidTestCase[]} valid 
+ * @param {import("eslint").RuleTester.ValidTestCase[]} valid
  * @param {import("eslint").RuleTester.InvalidTestCase[]} invalid
  */
 exports.module = (valid, invalid) => {
@@ -11,40 +11,48 @@ exports.module = (valid, invalid) => {
 		{ code: "var $$ = 'Hello'" },
 		{ code: "var $snake_case$ = 'Hello'" },
 		{ code: "var __snake_case$$ = 'Hello'" },
-		{ code: "var $$snake_case$$ = 'Hello'" },
+		{ code: "var $$snake_case$$ = 'Hello'" }
 	)
 	invalid.push(
 		{
 			code: "var __camelCase$$ = 'Hello'",
-			errors: [{
-				line: 1,
-				column: 5
-			}],
+			errors: [
+				{
+					line: 1,
+					column: 5
+				}
+			],
 			output: "var __camel_case$$ = 'Hello'"
 		},
 		{
 			code: "var ___ = 'Hello'",
-			errors: [{
-				line: 1,
-				column: 5
-			}],
+			errors: [
+				{
+					line: 1,
+					column: 5
+				}
+			],
 			output: "var ___ = 'Hello'"
 		},
 		{
 			code: "var $$$ = 'Hello'",
-			errors: [{
-				line: 1,
-				column: 5
-			}],
+			errors: [
+				{
+					line: 1,
+					column: 5
+				}
+			],
 			output: "var $$$ = 'Hello'"
 		},
 		{
 			code: "var $snake$case$ = 'Hello'",
-			errors: [{
-				line: 1,
-				column: 5
-			}],
+			errors: [
+				{
+					line: 1,
+					column: 5
+				}
+			],
 			output: "var $snake$case$ = 'Hello'"
-		},
+		}
 	)
 }

package/test/svelte-naming-convention.js

@@ -13,7 +13,7 @@ require("./svelte-naming-convention/snake_case_with_symbols").module(valid, inva
 new RuleTester().run(
 	"svelte-naming-convention",
 	require("../rules/svelte-naming-convention"),
-	{ 
+	{
 		valid,
 		invalid
 	}