eslint-plugin-lube 0.1.5 → 0.1.7

package/package.json

@@ -23,5 +23,5 @@
 		"test": "mocha"
 	},
 	"type": "commonjs",
-	"version": "0.1.5"
+	"version": "0.1.7"
 }

package/rules/svelte-naming-convention.js

@@ -9,8 +9,7 @@ module.exports = {
 		},
 		fixable: "code",
 		messages: {
-			not_match: "Identifier '{{name}}' does not match for svelte's naming conventions.",
-			not_match_private: "PrivateIdentifier '#{{name}}' does not match for svelte's naming conventions."
+			not_match: "Identifier '{{name}}' does not match for svelte's naming conventions."
 		},
 		schema: [{
 			properties: {
@@ -45,6 +44,8 @@ module.exports = {
 		const reported_declarations = new Set()
 		/** @type {Map<string, import("../private").ASTNode[]>} */
 		const pending_usages = new Map()
+		/** @type {Set<import("../private").ASTNode>} */
+		const shortand_properties = new Set()
 
 		/** @param {import("../private").ASTNode} node */
 		function defer(node) {
@@ -71,7 +72,8 @@ module.exports = {
 					if (fixable_name_regex.test(name)) {
 						return fixer.replaceTextRange(
 							node.range,
-							node.name.replace(fix_regex, fix_callback)
+							(shortand_properties.has(node) ? node.name + ": " : "")
+								+ node.name.replace(fix_regex, fix_callback)
 						)
 					}
 					return null
@@ -122,7 +124,10 @@ module.exports = {
 				// (left = right) => {}
 				if ("AssignmentPattern" == type) {
 					if (parent.left == node) {
-						report(node)
+						// function func({ camelCase = true }) {}
+						if (parent.parent?.type != "Property") {
+							report(node)
+						}
 					} else {
 						defer(node)
 					}
@@ -279,12 +284,15 @@ module.exports = {
 				// var value = { key: value }
 				// var { key: value } = value
 				if ("Property" == type) {
-					if (parent.value == node && parent.key.name != parent.value.name) {
+					if (parent.value == node) {
+						if (parent.key.name == parent.value.name) {
+							shortand_properties.add(node)
+						}
 						defer(node)
 					}
 					return
 				}
-				// class Object { key = value }
+				// class Object { camelCase = value }
 				if ("PropertyDefinition" == type) {
 					return
 				}

package/test/svelte-naming-convention/case_by_identifier.js

@@ -70,6 +70,7 @@ exports.module = (valid, invalid) => {
 			pendingA = pendingB
 			var pendingA, pendingB
 			pendingA = pendingB
+			function func({ pendingA = 123 }) {}
 			`,
 			errors: [
 				{
@@ -109,7 +110,9 @@ exports.module = (valid, invalid) => {
 			pending_a = pending_b
 			var pending_a, pending_b
 			pending_a = pending_b
-			`
+			function func({ pendingA = 123 }) {}
+			`,
+			parserOptions: { ecmaVersion: "latest" }
 		},
 		// AssignmentPattern
 		{
@@ -858,6 +861,11 @@ exports.module = (valid, invalid) => {
 					...error,
 					line: 5,
 					column: 23
+				},
+				{
+					...error,
+					line: 6,
+					column: 18
 				}
 			],
 			options: [{ fixSameNames: true }],
@@ -866,7 +874,7 @@ exports.module = (valid, invalid) => {
 			var value = { key: pending_a }
 			var pending_a
 			var value = { key: pending_a }
-			var value = { pendingA }
+			var value = { pendingA: pending_a }
 			`,
 			parserOptions: { ecmaVersion: "latest" }
 		},