eslint-plugin-lube 0.1.3 → 0.1.5

package/package.json

@@ -23,5 +23,5 @@
 		"test": "mocha"
 	},
 	"type": "commonjs",
-	"version": "0.1.3"
+	"version": "0.1.5"
 }

package/rules/svelte-naming-convention.js

@@ -30,6 +30,7 @@ module.exports = {
 		const allow_regex = /^[_$]?[_$]?(?:[0-9a-z]+(?:_[0-9a-z]+)*\$?\$?)?$|^[A-Z][0-9A-Z_]*$|^(?:[0-9A-Z][0-9a-z]*)+$/
 		const fixable_name_regex = /^[_$]?[_$]?(?:[0-9A-Za-z]+(?:_[0-9A-Za-z]+)*\$?\$?)?$/
 		const fix_regex = /([0-9a-z]?)([A-Z][0-9A-Z]*)/g
+		const camel_case_regex = /^[0-9a-z]+([A-Z][0-9a-z]*)*$/
 
 		/**
 		 * @param {string} _
@@ -206,7 +207,13 @@ module.exports = {
 				}
 				// function camelCase() {}
 				if ("FunctionDeclaration" == type) {
-					report(node)
+					if (
+						parent.parent?.type != "ExportNamedDeclaration"
+						|| !camel_case_regex.test(name)
+					) {
+						report(node)
+					}
+					// export function camelCase() {}
 					return
 				}
 				/* FunctionExpression */
@@ -258,7 +265,6 @@ module.exports = {
 				/* MetaProperty */
 				// class Object { camelCase() {} }
 				if ("MethodDefinition" == type) {
-					report(node)
 					return
 				}
 				// new camelCase
@@ -280,11 +286,6 @@ module.exports = {
 				}
 				// class Object { key = value }
 				if ("PropertyDefinition" == type) {
-					if (parent.key == node) {
-						report(node)
-					} else {
-						defer(node)
-					}
 					return
 				}
 				// var [ ...camelCase ] = value
@@ -353,7 +354,13 @@ module.exports = {
 				// var id = init
 				if ("VariableDeclarator" == type) {
 					if (parent.id == node) {
-						report(node)
+						if (
+							parent.parent?.parent?.type != "ExportNamedDeclaration"
+							|| !camel_case_regex.test(name)
+						) {
+							report(node)
+						}
+						// export var camelCase
 					} else {
 						defer(node)
 					}
@@ -374,24 +381,6 @@ module.exports = {
 					defer(node)
 					return
 				}
-			},
-			/** @param {import("../private").ASTNode} node */
-			PrivateIdentifier(node) {
-				const name = node.name
-				if (allow_regex.test(name)) return
-				const parent = node.parent
-				const type = parent.type
-				// class Object { #camelCase() {} }
-				if ("MethodDefinition" == type) {
-					report(node)
-					return
-				}
-				// class Object { #camelCase = value }
-				if ("PropertyDefinition" == type) {
-					report(node)
-					return
-				}
-				// TODO ?
 			}
 		}
 	}

package/test/svelte-naming-convention/case_by_identifier.js

@@ -561,13 +561,32 @@ exports.module = (valid, invalid) => {
 		},
 		// FunctionDeclaration
 		{
-			code: "function camelCase() {}",
-			errors: [{
-				...error,
-				line: 1,
-				column: 10
-			}],
-			output: "function camel_case() {}"
+			code: `
+			function camelCase() {}
+			export function camelCase2() {}
+			export function camelCase$() {}
+			`,
+			errors: [
+				{
+					...error,
+					line: 2,
+					column: 13
+				},
+				{
+					...error,
+					line: 4,
+					column: 20
+				}
+			],
+			output: `
+			function camel_case() {}
+			export function camelCase2() {}
+			export function camel_case$() {}
+			`,
+			parserOptions: {
+				ecmaVersion: "latest",
+				sourceType: "module"
+			}
 		},
 		// IfStatement
 		{
@@ -767,13 +786,19 @@ exports.module = (valid, invalid) => {
 		},
 		// MethodDefinition
 		{
-			code: "class Object { camelCase() {} }",
+			code: `
+			class ObjectB { camelCase() {} }
+			var camelCase
+			`,
 			errors: [{
 				...error,
-				line: 1,
-				column: 16
+				line: 3,
+				column: 8
 			}],
-			output: "class Object { camel_case() {} }",
+			output: `
+			class ObjectB { camelCase() {} }
+			var camel_case
+			`,
 			parserOptions: { ecmaVersion: "latest" }
 		},
 		// NewExpression
@@ -848,39 +873,25 @@ exports.module = (valid, invalid) => {
 		// PropertyDefinition
 		{
 			code: `
-			class ObjectA { camelCase = deferA }
-			class ObjectB { snake_case = pendingA }
-			var pendingA
-			class ObjectC { snake_case = pendingA }
+			class ObjectB { camelCase = camelCase2 }
+			var camelCase, camelCase2
 			`,
 			errors: [
-				{
-					...error,
-					line: 2,
-					column: 20
-				},
 				{
 					...error,
 					line: 3,
-					column: 33
-				},
-				{
-					...error,
-					line: 4,
 					column: 8
 				},
 				{
 					...error,
-					line: 5,
-					column: 33
+					line: 3,
+					column: 19
 				}
 			],
 			options: [{ fixSameNames: true }],
 			output: `
-			class ObjectA { camel_case = deferA }
-			class ObjectB { snake_case = pending_a }
-			var pending_a
-			class ObjectC { snake_case = pending_a }
+			class ObjectB { camelCase = camelCase2 }
+			var camel_case, camel_case2
 			`,
 			parserOptions: { ecmaVersion: "latest" }
 		},
@@ -1230,6 +1241,8 @@ exports.module = (valid, invalid) => {
 			var snake_case = pendingA
 			var pendingA
 			var snake_case = pendingA
+			export var camelCase2
+			export var camelCase$
 			`,
 			errors: [
 				{
@@ -1251,6 +1264,11 @@ exports.module = (valid, invalid) => {
 					...error,
 					line: 5,
 					column: 21
+				},
+				{
+					...error,
+					line: 7,
+					column: 15
 				}
 			],
 			options: [{ fixSameNames: true }],
@@ -1259,7 +1277,13 @@ exports.module = (valid, invalid) => {
 			var snake_case = pending_a
 			var pending_a
 			var snake_case = pending_a
-			`
+			export var camelCase2
+			export var camel_case$
+			`,
+			parserOptions: {
+				ecmaVersion: "latest",
+				sourceType: "module"
+			}
 		},
 		// WhileStatement
 		{