eslint-plugin-lit 1.8.0 → 1.8.1

package/lib/rules/no-native-attributes.js

@@ -29,6 +29,7 @@ const NATIVE_ATTRS = [
     'lang',
     'nonce',
     'part',
+    'popover',
     'role',
     'slot',
     'spellcheck',
@@ -62,10 +63,10 @@ const rule = {
         return {
             'ClassExpression,ClassDeclaration': (node) => {
                 const propertyMap = (0, util_1.getPropertyMap)(node);
-                for (const [prop] of propertyMap.entries()) {
+                for (const [prop, { key }] of propertyMap.entries()) {
                     if (NATIVE_ATTRS.includes(prop)) {
                         context.report({
-                            node: node,
+                            node: key,
                             messageId: 'noNativeAttributes',
                             data: { prop }
                         });

package/lib/util.d.ts

@@ -14,16 +14,18 @@ export interface BabelProperty extends ESTree.MethodDefinition {
  */
 export declare function getIdentifierName(node: ESTree.Node): string | undefined;
 export interface PropertyMapEntry {
+    key: ESTree.Node;
     expr: ESTree.ObjectExpression | null;
     state: boolean;
     attribute: boolean;
 }
 /**
  * Extracts property metadata from a given property object
- * @param {ESTree.ObjectExpression} node Node to extract from
+ * @param {ESTree.Node} key Node to extract from
+ * @param {ESTree.ObjectExpression} value Node to extract from
  * @return {object}
  */
-export declare function extractPropertyEntry(node: ESTree.ObjectExpression): PropertyMapEntry;
+export declare function extractPropertyEntry(key: ESTree.Node, value: ESTree.ObjectExpression): PropertyMapEntry;
 /**
  * Get the properties object of an element class
  *

package/lib/util.js

@@ -19,13 +19,14 @@ function getIdentifierName(node) {
 exports.getIdentifierName = getIdentifierName;
 /**
  * Extracts property metadata from a given property object
- * @param {ESTree.ObjectExpression} node Node to extract from
+ * @param {ESTree.Node} key Node to extract from
+ * @param {ESTree.ObjectExpression} value Node to extract from
  * @return {object}
  */
-function extractPropertyEntry(node) {
+function extractPropertyEntry(key, value) {
     let state = false;
     let attribute = true;
-    for (const prop of node.properties) {
+    for (const prop of value.properties) {
         if (prop.type === 'Property' &&
             prop.key.type === 'Identifier' &&
             prop.value.type === 'Literal') {
@@ -38,7 +39,8 @@ function extractPropertyEntry(node) {
         }
     }
     return {
-        expr: node,
+        expr: value,
+        key,
         state,
         attribute
     };
@@ -65,7 +67,7 @@ function getPropertyMap(node) {
                 if (prop.type === 'Property') {
                     const name = getIdentifierName(prop.key);
                     if (name && prop.value.type === 'ObjectExpression') {
-                        result.set(name, extractPropertyEntry(prop.value));
+                        result.set(name, extractPropertyEntry(prop.key, prop.value));
                     }
                 }
             }
@@ -87,7 +89,7 @@ function getPropertyMap(node) {
                     if (prop.type === 'Property') {
                         const name = getIdentifierName(prop.key);
                         if (name && prop.value.type === 'ObjectExpression') {
-                            result.set(name, extractPropertyEntry(prop.value));
+                            result.set(name, extractPropertyEntry(prop.key, prop.value));
                         }
                     }
                 }
@@ -96,7 +98,8 @@ function getPropertyMap(node) {
         if (member.type === 'MethodDefinition' ||
             member.type === 'PropertyDefinition') {
             const babelProp = member;
-            const memberName = getIdentifierName(member.key);
+            const key = member.key;
+            const memberName = getIdentifierName(key);
             if (memberName && babelProp.decorators) {
                 for (const decorator of babelProp.decorators) {
                     if (decorator.expression.type === 'CallExpression' &&
@@ -105,7 +108,7 @@ function getPropertyMap(node) {
                         const dArg = decorator.expression.arguments[0];
                         if ((dArg === null || dArg === void 0 ? void 0 : dArg.type) === 'ObjectExpression') {
                             const state = internalDecorators.includes(decorator.expression.callee.name);
-                            const entry = extractPropertyEntry(dArg);
+                            const entry = extractPropertyEntry(key, dArg);
                             if (state) {
                                 entry.state = true;
                             }
@@ -113,7 +116,12 @@ function getPropertyMap(node) {
                         }
                         else {
                             const state = internalDecorators.includes(decorator.expression.callee.name);
-                            result.set(memberName, { expr: null, state, attribute: true });
+                            result.set(memberName, {
+                                key,
+                                expr: null,
+                                state,
+                                attribute: true
+                            });
                         }
                     }
                 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-lit",
-  "version": "1.8.0",
+  "version": "1.8.1",
   "description": "lit-html support for ESLint",
   "main": "lib/index.js",
   "files": [