eslint-plugin-lambda-security 0.0.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/AGENTS.md +106 -0
- package/CHANGELOG.md +42 -0
- package/README.md +355 -0
- package/package.json +99 -0
- package/src/index.d.ts +65 -0
- package/src/index.js +58 -0
- package/src/index.js.map +1 -0
- package/src/rules/no-env-logging/index.d.ts +5 -0
- package/src/rules/no-env-logging/index.js +129 -0
- package/src/rules/no-env-logging/index.js.map +1 -0
- package/src/rules/no-hardcoded-credentials-sdk/index.d.ts +5 -0
- package/src/rules/no-hardcoded-credentials-sdk/index.js +226 -0
- package/src/rules/no-hardcoded-credentials-sdk/index.js.map +1 -0
- package/src/rules/no-permissive-cors-middy/index.d.ts +5 -0
- package/src/rules/no-permissive-cors-middy/index.js +134 -0
- package/src/rules/no-permissive-cors-middy/index.js.map +1 -0
- package/src/rules/no-permissive-cors-response/index.d.ts +7 -0
- package/src/rules/no-permissive-cors-response/index.js +144 -0
- package/src/rules/no-permissive-cors-response/index.js.map +1 -0
- package/src/rules/no-secrets-in-env/index.d.ts +7 -0
- package/src/rules/no-secrets-in-env/index.js +154 -0
- package/src/rules/no-secrets-in-env/index.js.map +1 -0
|
@@ -0,0 +1,144 @@
|
|
|
1
|
+
"use strict";
|
|
2
|
+
Object.defineProperty(exports, "__esModule", { value: true });
|
|
3
|
+
exports.noPermissiveCorsResponse = void 0;
|
|
4
|
+
const eslint_devkit_1 = require("@interlace/eslint-devkit");
|
|
5
|
+
exports.noPermissiveCorsResponse = (0, eslint_devkit_1.createRule)({
|
|
6
|
+
name: 'no-permissive-cors-response',
|
|
7
|
+
meta: {
|
|
8
|
+
type: 'problem',
|
|
9
|
+
docs: {
|
|
10
|
+
description: 'Detects permissive CORS (Access-Control-Allow-Origin: *) in Lambda response headers',
|
|
11
|
+
},
|
|
12
|
+
fixable: 'code',
|
|
13
|
+
messages: {
|
|
14
|
+
permissiveCors: (0, eslint_devkit_1.formatLLMMessage)({
|
|
15
|
+
icon: eslint_devkit_1.MessageIcons.SECURITY,
|
|
16
|
+
issueName: 'Permissive CORS in Lambda Response',
|
|
17
|
+
cwe: 'CWE-942',
|
|
18
|
+
description: 'Wildcard CORS origin (*) allows any domain to access this Lambda function',
|
|
19
|
+
severity: 'HIGH',
|
|
20
|
+
fix: 'Use specific origins: headers: { "Access-Control-Allow-Origin": "https://your-domain.com" }',
|
|
21
|
+
documentationLink: 'https://docs.aws.amazon.com/apigateway/latest/developerguide/how-to-cors.html',
|
|
22
|
+
}),
|
|
23
|
+
useSpecificOrigin: (0, eslint_devkit_1.formatLLMMessage)({
|
|
24
|
+
icon: eslint_devkit_1.MessageIcons.INFO,
|
|
25
|
+
issueName: 'Use Specific Origin',
|
|
26
|
+
description: 'Specify allowed origins instead of wildcard',
|
|
27
|
+
severity: 'LOW',
|
|
28
|
+
fix: 'Replace "*" with specific domain(s)',
|
|
29
|
+
documentationLink: 'https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS',
|
|
30
|
+
}),
|
|
31
|
+
},
|
|
32
|
+
schema: [
|
|
33
|
+
{
|
|
34
|
+
type: 'object',
|
|
35
|
+
properties: {
|
|
36
|
+
allowInTests: {
|
|
37
|
+
type: 'boolean',
|
|
38
|
+
default: true,
|
|
39
|
+
description: 'Allow permissive CORS in test files',
|
|
40
|
+
},
|
|
41
|
+
allowedOrigins: {
|
|
42
|
+
type: 'array',
|
|
43
|
+
items: { type: 'string' },
|
|
44
|
+
default: [],
|
|
45
|
+
description: 'Patterns for allowed origins',
|
|
46
|
+
},
|
|
47
|
+
},
|
|
48
|
+
additionalProperties: false,
|
|
49
|
+
},
|
|
50
|
+
],
|
|
51
|
+
},
|
|
52
|
+
defaultOptions: [
|
|
53
|
+
{
|
|
54
|
+
allowInTests: true,
|
|
55
|
+
allowedOrigins: [],
|
|
56
|
+
},
|
|
57
|
+
],
|
|
58
|
+
create(context, [options = {}]) {
|
|
59
|
+
const { allowInTests = true } = options;
|
|
60
|
+
const filename = context.filename || context.getFilename();
|
|
61
|
+
const isTestFile = /\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);
|
|
62
|
+
if (allowInTests && isTestFile) {
|
|
63
|
+
return {};
|
|
64
|
+
}
|
|
65
|
+
/**
|
|
66
|
+
* Check if this is a Lambda response structure
|
|
67
|
+
* { statusCode, headers, body }
|
|
68
|
+
*/
|
|
69
|
+
function isLambdaResponse(obj) {
|
|
70
|
+
const propNames = obj.properties
|
|
71
|
+
.filter((p) => p.type === eslint_devkit_1.AST_NODE_TYPES.Property)
|
|
72
|
+
.map(p => (p.key.type === eslint_devkit_1.AST_NODE_TYPES.Identifier ? p.key.name : ''));
|
|
73
|
+
return propNames.includes('statusCode') || propNames.includes('body');
|
|
74
|
+
}
|
|
75
|
+
/**
|
|
76
|
+
* Check headers object for permissive CORS
|
|
77
|
+
*/
|
|
78
|
+
function checkHeadersObject(obj) {
|
|
79
|
+
for (const prop of obj.properties) {
|
|
80
|
+
if (prop.type !== eslint_devkit_1.AST_NODE_TYPES.Property)
|
|
81
|
+
continue;
|
|
82
|
+
// Get header name
|
|
83
|
+
let headerName = '';
|
|
84
|
+
if (prop.key.type === eslint_devkit_1.AST_NODE_TYPES.Identifier) {
|
|
85
|
+
headerName = prop.key.name;
|
|
86
|
+
}
|
|
87
|
+
else if (prop.key.type === eslint_devkit_1.AST_NODE_TYPES.Literal && typeof prop.key.value === 'string') {
|
|
88
|
+
headerName = prop.key.value;
|
|
89
|
+
}
|
|
90
|
+
// Check for Access-Control-Allow-Origin
|
|
91
|
+
if (headerName.toLowerCase() === 'access-control-allow-origin') {
|
|
92
|
+
// Check if value is wildcard
|
|
93
|
+
if (prop.value.type === eslint_devkit_1.AST_NODE_TYPES.Literal && prop.value.value === '*') {
|
|
94
|
+
context.report({
|
|
95
|
+
node: prop,
|
|
96
|
+
messageId: 'permissiveCors',
|
|
97
|
+
fix: (fixer) => {
|
|
98
|
+
return fixer.replaceText(prop.value, '"https://your-domain.com"');
|
|
99
|
+
},
|
|
100
|
+
});
|
|
101
|
+
}
|
|
102
|
+
}
|
|
103
|
+
}
|
|
104
|
+
}
|
|
105
|
+
return {
|
|
106
|
+
// Check return statements that return Lambda response objects
|
|
107
|
+
ReturnStatement(node) {
|
|
108
|
+
if (node.argument?.type === eslint_devkit_1.AST_NODE_TYPES.ObjectExpression) {
|
|
109
|
+
const obj = node.argument;
|
|
110
|
+
if (isLambdaResponse(obj)) {
|
|
111
|
+
// Find headers property
|
|
112
|
+
for (const prop of obj.properties) {
|
|
113
|
+
if (prop.type === eslint_devkit_1.AST_NODE_TYPES.Property &&
|
|
114
|
+
prop.key.type === eslint_devkit_1.AST_NODE_TYPES.Identifier &&
|
|
115
|
+
prop.key.name === 'headers' &&
|
|
116
|
+
prop.value.type === eslint_devkit_1.AST_NODE_TYPES.ObjectExpression) {
|
|
117
|
+
checkHeadersObject(prop.value);
|
|
118
|
+
}
|
|
119
|
+
}
|
|
120
|
+
}
|
|
121
|
+
}
|
|
122
|
+
},
|
|
123
|
+
// Also check variable declarations with Lambda response pattern
|
|
124
|
+
VariableDeclarator(node) {
|
|
125
|
+
if (node.id.type === eslint_devkit_1.AST_NODE_TYPES.Identifier &&
|
|
126
|
+
node.id.name.toLowerCase().includes('response') &&
|
|
127
|
+
node.init?.type === eslint_devkit_1.AST_NODE_TYPES.ObjectExpression) {
|
|
128
|
+
const obj = node.init;
|
|
129
|
+
if (isLambdaResponse(obj)) {
|
|
130
|
+
for (const prop of obj.properties) {
|
|
131
|
+
if (prop.type === eslint_devkit_1.AST_NODE_TYPES.Property &&
|
|
132
|
+
prop.key.type === eslint_devkit_1.AST_NODE_TYPES.Identifier &&
|
|
133
|
+
prop.key.name === 'headers' &&
|
|
134
|
+
prop.value.type === eslint_devkit_1.AST_NODE_TYPES.ObjectExpression) {
|
|
135
|
+
checkHeadersObject(prop.value);
|
|
136
|
+
}
|
|
137
|
+
}
|
|
138
|
+
}
|
|
139
|
+
}
|
|
140
|
+
},
|
|
141
|
+
};
|
|
142
|
+
},
|
|
143
|
+
});
|
|
144
|
+
//# sourceMappingURL=index.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../../packages/eslint-plugin-lambda-security/src/rules/no-permissive-cors-response/index.ts"],"names":[],"mappings":";;;AASA,4DAAsG;AAazF,QAAA,wBAAwB,GAAG,IAAA,0BAAU,EAA0B;IAC1E,IAAI,EAAE,6BAA6B;IACnC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EAAE,qFAAqF;SACnG;QACD,OAAO,EAAE,MAAM;QACf,QAAQ,EAAE;YACR,cAAc,EAAE,IAAA,gCAAgB,EAAC;gBAC/B,IAAI,EAAE,4BAAY,CAAC,QAAQ;gBAC3B,SAAS,EAAE,oCAAoC;gBAC/C,GAAG,EAAE,SAAS;gBACd,WAAW,EAAE,2EAA2E;gBACxF,QAAQ,EAAE,MAAM;gBAChB,GAAG,EAAE,6FAA6F;gBAClG,iBAAiB,EAAE,+EAA+E;aACnG,CAAC;YACF,iBAAiB,EAAE,IAAA,gCAAgB,EAAC;gBAClC,IAAI,EAAE,4BAAY,CAAC,IAAI;gBACvB,SAAS,EAAE,qBAAqB;gBAChC,WAAW,EAAE,6CAA6C;gBAC1D,QAAQ,EAAE,KAAK;gBACf,GAAG,EAAE,qCAAqC;gBAC1C,iBAAiB,EAAE,wDAAwD;aAC5E,CAAC;SACH;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,YAAY,EAAE;wBACZ,IAAI,EAAE,SAAS;wBACf,OAAO,EAAE,IAAI;wBACb,WAAW,EAAE,qCAAqC;qBACnD;oBACD,cAAc,EAAE;wBACd,IAAI,EAAE,OAAO;wBACb,KAAK,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACzB,OAAO,EAAE,EAAE;wBACX,WAAW,EAAE,8BAA8B;qBAC5C;iBACF;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;KACF;IACD,cAAc,EAAE;QACd;YACE,YAAY,EAAE,IAAI;YAClB,cAAc,EAAE,EAAE;SACnB;KACF;IACD,MAAM,CAAC,OAAsD,EAAE,CAAC,OAAO,GAAG,EAAE,CAAC;QAC3E,MAAM,EAAE,YAAY,GAAG,IAAI,EAAE,GAAG,OAAkB,CAAC;QACnD,MAAM,QAAQ,GAAG,OAAO,CAAC,QAAQ,IAAI,OAAO,CAAC,WAAW,EAAE,CAAC;QAC3D,MAAM,UAAU,GAAG,iCAAiC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAEpE,IAAI,YAAY,IAAI,UAAU,EAAE,CAAC;YAC/B,OAAO,EAAE,CAAC;QACZ,CAAC;QAED;;;WAGG;QACH,SAAS,gBAAgB,CAAC,GAA8B;YACtD,MAAM,SAAS,GAAG,GAAG,CAAC,UAAU;iBAC7B,MAAM,CAAC,CAAC,CAAC,EAA0B,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,8BAAc,CAAC,QAAQ,CAAC;iBACzE,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;YAE1E,OAAO,SAAS,CAAC,QAAQ,CAAC,YAAY,CAAC,IAAI,SAAS,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC;QACxE,CAAC;QAED;;WAEG;QACH,SAAS,kBAAkB,CAAC,GAA8B;YACxD,KAAK,MAAM,IAAI,IAAI,GAAG,CAAC,UAAU,EAAE,CAAC;gBAClC,IAAI,IAAI,CAAC,IAAI,KAAK,8BAAc,CAAC,QAAQ;oBAAE,SAAS;gBAEpD,kBAAkB;gBAClB,IAAI,UAAU,GAAG,EAAE,CAAC;gBACpB,IAAI,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU,EAAE,CAAC;oBAChD,UAAU,GAAG,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC;gBAC7B,CAAC;qBAAM,IAAI,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,8BAAc,CAAC,OAAO,IAAI,OAAO,IAAI,CAAC,GAAG,CAAC,KAAK,KAAK,QAAQ,EAAE,CAAC;oBAC1F,UAAU,GAAG,IAAI,CAAC,GAAG,CAAC,KAAK,CAAC;gBAC9B,CAAC;gBAED,wCAAwC;gBACxC,IAAI,UAAU,CAAC,WAAW,EAAE,KAAK,6BAA6B,EAAE,CAAC;oBAC/D,6BAA6B;oBAC7B,IAAI,IAAI,CAAC,KAAK,CAAC,IAAI,KAAK,8BAAc,CAAC,OAAO,IAAI,IAAI,CAAC,KAAK,CAAC,KAAK,KAAK,GAAG,EAAE,CAAC;wBAC3E,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI,EAAE,IAAI;4BACV,SAAS,EAAE,gBAAgB;4BAC3B,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE;gCACb,OAAO,KAAK,CAAC,WAAW,CAAC,IAAI,CAAC,KAAK,EAAE,2BAA2B,CAAC,CAAC;4BACpE,CAAC;yBACF,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO;YACL,8DAA8D;YAC9D,eAAe,CAAC,IAA8B;gBAC5C,IAAI,IAAI,CAAC,QAAQ,EAAE,IAAI,KAAK,8BAAc,CAAC,gBAAgB,EAAE,CAAC;oBAC5D,MAAM,GAAG,GAAG,IAAI,CAAC,QAAQ,CAAC;oBAE1B,IAAI,gBAAgB,CAAC,GAAG,CAAC,EAAE,CAAC;wBAC1B,wBAAwB;wBACxB,KAAK,MAAM,IAAI,IAAI,GAAG,CAAC,UAAU,EAAE,CAAC;4BAClC,IACE,IAAI,CAAC,IAAI,KAAK,8BAAc,CAAC,QAAQ;gCACrC,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU;gCAC3C,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,SAAS;gCAC3B,IAAI,CAAC,KAAK,CAAC,IAAI,KAAK,8BAAc,CAAC,gBAAgB,EACnD,CAAC;gCACD,kBAAkB,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;4BACjC,CAAC;wBACH,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YAED,gEAAgE;YAChE,kBAAkB,CAAC,IAAiC;gBAClD,IACE,IAAI,CAAC,EAAE,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU;oBAC1C,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC,QAAQ,CAAC,UAAU,CAAC;oBAC/C,IAAI,CAAC,IAAI,EAAE,IAAI,KAAK,8BAAc,CAAC,gBAAgB,EACnD,CAAC;oBACD,MAAM,GAAG,GAAG,IAAI,CAAC,IAAI,CAAC;oBAEtB,IAAI,gBAAgB,CAAC,GAAG,CAAC,EAAE,CAAC;wBAC1B,KAAK,MAAM,IAAI,IAAI,GAAG,CAAC,UAAU,EAAE,CAAC;4BAClC,IACE,IAAI,CAAC,IAAI,KAAK,8BAAc,CAAC,QAAQ;gCACrC,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU;gCAC3C,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,SAAS;gCAC3B,IAAI,CAAC,KAAK,CAAC,IAAI,KAAK,8BAAc,CAAC,gBAAgB,EACnD,CAAC;gCACD,kBAAkB,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;4BACjC,CAAC;wBACH,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC"}
|
|
@@ -0,0 +1,7 @@
|
|
|
1
|
+
export interface Options {
|
|
2
|
+
/** Allow in test files. Default: true */
|
|
3
|
+
allowInTests?: boolean;
|
|
4
|
+
/** Additional secret patterns to detect. Default: [] */
|
|
5
|
+
additionalPatterns?: string[];
|
|
6
|
+
}
|
|
7
|
+
export declare const noSecretsInEnv: ESLintUtils.RuleModule<MessageIds, Options, unknown, ESLintUtils.RuleListener>;
|
|
@@ -0,0 +1,154 @@
|
|
|
1
|
+
"use strict";
|
|
2
|
+
Object.defineProperty(exports, "__esModule", { value: true });
|
|
3
|
+
exports.noSecretsInEnv = void 0;
|
|
4
|
+
const eslint_devkit_1 = require("@interlace/eslint-devkit");
|
|
5
|
+
// Patterns that indicate secrets
|
|
6
|
+
const SECRET_PATTERNS = [
|
|
7
|
+
/password/i,
|
|
8
|
+
/secret/i,
|
|
9
|
+
/api[_-]?key/i,
|
|
10
|
+
/api[_-]?token/i,
|
|
11
|
+
/auth[_-]?token/i,
|
|
12
|
+
/access[_-]?token/i,
|
|
13
|
+
/private[_-]?key/i,
|
|
14
|
+
/encryption[_-]?key/i,
|
|
15
|
+
/db[_-]?pass/i,
|
|
16
|
+
/database[_-]?password/i,
|
|
17
|
+
/jwt[_-]?secret/i,
|
|
18
|
+
/signing[_-]?key/i,
|
|
19
|
+
/client[_-]?secret/i,
|
|
20
|
+
/aws[_-]?secret/i,
|
|
21
|
+
];
|
|
22
|
+
exports.noSecretsInEnv = (0, eslint_devkit_1.createRule)({
|
|
23
|
+
name: 'no-secrets-in-env',
|
|
24
|
+
meta: {
|
|
25
|
+
type: 'problem',
|
|
26
|
+
docs: {
|
|
27
|
+
description: 'Detects secrets directly assigned to environment variables',
|
|
28
|
+
},
|
|
29
|
+
hasSuggestions: true,
|
|
30
|
+
messages: {
|
|
31
|
+
secretsInEnv: (0, eslint_devkit_1.formatLLMMessage)({
|
|
32
|
+
icon: eslint_devkit_1.MessageIcons.SECURITY,
|
|
33
|
+
issueName: 'Secret in Environment Variable',
|
|
34
|
+
cwe: 'CWE-798',
|
|
35
|
+
description: 'Secret "{{varName}}" should not be hardcoded in environment variables',
|
|
36
|
+
severity: 'CRITICAL',
|
|
37
|
+
fix: 'Use AWS Secrets Manager: const secret = await secretsClient.send(new GetSecretValueCommand({ SecretId: "{{varName}}" }))',
|
|
38
|
+
documentationLink: 'https://docs.aws.amazon.com/secretsmanager/latest/userguide/intro.html',
|
|
39
|
+
}),
|
|
40
|
+
useSecretsManager: (0, eslint_devkit_1.formatLLMMessage)({
|
|
41
|
+
icon: eslint_devkit_1.MessageIcons.INFO,
|
|
42
|
+
issueName: 'Use Secrets Manager',
|
|
43
|
+
description: 'Store secrets in AWS Secrets Manager instead of env vars',
|
|
44
|
+
severity: 'LOW',
|
|
45
|
+
fix: 'import { SecretsManagerClient, GetSecretValueCommand } from "@aws-sdk/client-secrets-manager"',
|
|
46
|
+
documentationLink: 'https://docs.aws.amazon.com/secretsmanager/latest/userguide/intro.html',
|
|
47
|
+
}),
|
|
48
|
+
},
|
|
49
|
+
schema: [
|
|
50
|
+
{
|
|
51
|
+
type: 'object',
|
|
52
|
+
properties: {
|
|
53
|
+
allowInTests: { type: 'boolean', default: true },
|
|
54
|
+
additionalPatterns: { type: 'array', items: { type: 'string' }, default: [] },
|
|
55
|
+
},
|
|
56
|
+
additionalProperties: false,
|
|
57
|
+
},
|
|
58
|
+
],
|
|
59
|
+
},
|
|
60
|
+
defaultOptions: [{ allowInTests: true, additionalPatterns: [] }],
|
|
61
|
+
create(context, [options = {}]) {
|
|
62
|
+
const { allowInTests = true, additionalPatterns = [] } = options;
|
|
63
|
+
const filename = context.filename || context.getFilename();
|
|
64
|
+
const isTestFile = /\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);
|
|
65
|
+
if (allowInTests && isTestFile) {
|
|
66
|
+
return {};
|
|
67
|
+
}
|
|
68
|
+
// Compile additional patterns
|
|
69
|
+
const allPatterns = [
|
|
70
|
+
...SECRET_PATTERNS,
|
|
71
|
+
...additionalPatterns.map(p => new RegExp(p, 'i')),
|
|
72
|
+
];
|
|
73
|
+
/**
|
|
74
|
+
* Check if a variable name looks like a secret
|
|
75
|
+
*/
|
|
76
|
+
function isSecretName(name) {
|
|
77
|
+
return allPatterns.some(pattern => pattern.test(name));
|
|
78
|
+
}
|
|
79
|
+
/**
|
|
80
|
+
* Check if a value looks like it contains a secret (not just a reference)
|
|
81
|
+
*/
|
|
82
|
+
function isHardcodedSecretValue(node) {
|
|
83
|
+
// Literal strings with reasonable length could be secrets
|
|
84
|
+
if (node.type === eslint_devkit_1.AST_NODE_TYPES.Literal && typeof node.value === 'string') {
|
|
85
|
+
return node.value.length > 5;
|
|
86
|
+
}
|
|
87
|
+
// Template literals with string parts
|
|
88
|
+
if (node.type === eslint_devkit_1.AST_NODE_TYPES.TemplateLiteral) {
|
|
89
|
+
return node.quasis.some(quasi => quasi.value.raw.length > 5);
|
|
90
|
+
}
|
|
91
|
+
return false;
|
|
92
|
+
}
|
|
93
|
+
return {
|
|
94
|
+
// Detect process.env.SECRET_KEY = 'value'
|
|
95
|
+
AssignmentExpression(node) {
|
|
96
|
+
if (node.left.type === eslint_devkit_1.AST_NODE_TYPES.MemberExpression &&
|
|
97
|
+
node.left.object.type === eslint_devkit_1.AST_NODE_TYPES.MemberExpression &&
|
|
98
|
+
node.left.object.object.type === eslint_devkit_1.AST_NODE_TYPES.Identifier &&
|
|
99
|
+
node.left.object.object.name === 'process' &&
|
|
100
|
+
node.left.object.property.type === eslint_devkit_1.AST_NODE_TYPES.Identifier &&
|
|
101
|
+
node.left.object.property.name === 'env') {
|
|
102
|
+
let envVarName = '';
|
|
103
|
+
if (node.left.property.type === eslint_devkit_1.AST_NODE_TYPES.Identifier) {
|
|
104
|
+
envVarName = node.left.property.name;
|
|
105
|
+
}
|
|
106
|
+
else if (node.left.property.type === eslint_devkit_1.AST_NODE_TYPES.Literal && typeof node.left.property.value === 'string') {
|
|
107
|
+
envVarName = node.left.property.value;
|
|
108
|
+
}
|
|
109
|
+
if (isSecretName(envVarName) && isHardcodedSecretValue(node.right)) {
|
|
110
|
+
context.report({
|
|
111
|
+
node,
|
|
112
|
+
messageId: 'secretsInEnv',
|
|
113
|
+
data: { varName: envVarName },
|
|
114
|
+
suggest: [{ messageId: 'useSecretsManager', fix: () => null }],
|
|
115
|
+
});
|
|
116
|
+
}
|
|
117
|
+
}
|
|
118
|
+
},
|
|
119
|
+
// Detect { DB_PASSWORD: 'value' } in environment config objects
|
|
120
|
+
Property(node) {
|
|
121
|
+
let propName = '';
|
|
122
|
+
if (node.key.type === eslint_devkit_1.AST_NODE_TYPES.Identifier) {
|
|
123
|
+
propName = node.key.name;
|
|
124
|
+
}
|
|
125
|
+
else if (node.key.type === eslint_devkit_1.AST_NODE_TYPES.Literal && typeof node.key.value === 'string') {
|
|
126
|
+
propName = node.key.value;
|
|
127
|
+
}
|
|
128
|
+
if (isSecretName(propName) && isHardcodedSecretValue(node.value)) {
|
|
129
|
+
// Check if this is in an environment/config context
|
|
130
|
+
let parent = node.parent;
|
|
131
|
+
while (parent) {
|
|
132
|
+
if (parent.type === eslint_devkit_1.AST_NODE_TYPES.ObjectExpression) {
|
|
133
|
+
parent = parent.parent;
|
|
134
|
+
continue;
|
|
135
|
+
}
|
|
136
|
+
if (parent.type === eslint_devkit_1.AST_NODE_TYPES.VariableDeclarator &&
|
|
137
|
+
parent.id.type === eslint_devkit_1.AST_NODE_TYPES.Identifier &&
|
|
138
|
+
/env|config|settings/i.test(parent.id.name)) {
|
|
139
|
+
context.report({
|
|
140
|
+
node,
|
|
141
|
+
messageId: 'secretsInEnv',
|
|
142
|
+
data: { varName: propName },
|
|
143
|
+
suggest: [{ messageId: 'useSecretsManager', fix: () => null }],
|
|
144
|
+
});
|
|
145
|
+
break;
|
|
146
|
+
}
|
|
147
|
+
break;
|
|
148
|
+
}
|
|
149
|
+
}
|
|
150
|
+
},
|
|
151
|
+
};
|
|
152
|
+
},
|
|
153
|
+
});
|
|
154
|
+
//# sourceMappingURL=index.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../../packages/eslint-plugin-lambda-security/src/rules/no-secrets-in-env/index.ts"],"names":[],"mappings":";;;AASA,4DAAsG;AAatG,iCAAiC;AACjC,MAAM,eAAe,GAAG;IACtB,WAAW;IACX,SAAS;IACT,cAAc;IACd,gBAAgB;IAChB,iBAAiB;IACjB,mBAAmB;IACnB,kBAAkB;IAClB,qBAAqB;IACrB,cAAc;IACd,wBAAwB;IACxB,iBAAiB;IACjB,kBAAkB;IAClB,oBAAoB;IACpB,iBAAiB;CAClB,CAAC;AAEW,QAAA,cAAc,GAAG,IAAA,0BAAU,EAA0B;IAChE,IAAI,EAAE,mBAAmB;IACzB,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EAAE,4DAA4D;SAC1E;QACD,cAAc,EAAE,IAAI;QACpB,QAAQ,EAAE;YACR,YAAY,EAAE,IAAA,gCAAgB,EAAC;gBAC7B,IAAI,EAAE,4BAAY,CAAC,QAAQ;gBAC3B,SAAS,EAAE,gCAAgC;gBAC3C,GAAG,EAAE,SAAS;gBACd,WAAW,EAAE,uEAAuE;gBACpF,QAAQ,EAAE,UAAU;gBACpB,GAAG,EAAE,0HAA0H;gBAC/H,iBAAiB,EAAE,wEAAwE;aAC5F,CAAC;YACF,iBAAiB,EAAE,IAAA,gCAAgB,EAAC;gBAClC,IAAI,EAAE,4BAAY,CAAC,IAAI;gBACvB,SAAS,EAAE,qBAAqB;gBAChC,WAAW,EAAE,0DAA0D;gBACvE,QAAQ,EAAE,KAAK;gBACf,GAAG,EAAE,+FAA+F;gBACpG,iBAAiB,EAAE,wEAAwE;aAC5F,CAAC;SACH;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,YAAY,EAAE,EAAE,IAAI,EAAE,SAAS,EAAE,OAAO,EAAE,IAAI,EAAE;oBAChD,kBAAkB,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,EAAE,OAAO,EAAE,EAAE,EAAE;iBAC9E;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;KACF;IACD,cAAc,EAAE,CAAC,EAAE,YAAY,EAAE,IAAI,EAAE,kBAAkB,EAAE,EAAE,EAAE,CAAC;IAChE,MAAM,CAAC,OAAsD,EAAE,CAAC,OAAO,GAAG,EAAE,CAAC;QAC3E,MAAM,EAAE,YAAY,GAAG,IAAI,EAAE,kBAAkB,GAAG,EAAE,EAAE,GAAG,OAAkB,CAAC;QAC5E,MAAM,QAAQ,GAAG,OAAO,CAAC,QAAQ,IAAI,OAAO,CAAC,WAAW,EAAE,CAAC;QAC3D,MAAM,UAAU,GAAG,iCAAiC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAEpE,IAAI,YAAY,IAAI,UAAU,EAAE,CAAC;YAC/B,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,8BAA8B;QAC9B,MAAM,WAAW,GAAG;YAClB,GAAG,eAAe;YAClB,GAAG,kBAAkB,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,IAAI,MAAM,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC;SACnD,CAAC;QAEF;;WAEG;QACH,SAAS,YAAY,CAAC,IAAY;YAChC,OAAO,WAAW,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;QACzD,CAAC;QAED;;WAEG;QACH,SAAS,sBAAsB,CAAC,IAAmB;YACjD,0DAA0D;YAC1D,IAAI,IAAI,CAAC,IAAI,KAAK,8BAAc,CAAC,OAAO,IAAI,OAAO,IAAI,CAAC,KAAK,KAAK,QAAQ,EAAE,CAAC;gBAC3E,OAAO,IAAI,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC;YAC/B,CAAC;YACD,sCAAsC;YACtC,IAAI,IAAI,CAAC,IAAI,KAAK,8BAAc,CAAC,eAAe,EAAE,CAAC;gBACjD,OAAO,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;YAC/D,CAAC;YACD,OAAO,KAAK,CAAC;QACf,CAAC;QAED,OAAO;YACL,0CAA0C;YAC1C,oBAAoB,CAAC,IAAmC;gBACtD,IACE,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,8BAAc,CAAC,gBAAgB;oBAClD,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,8BAAc,CAAC,gBAAgB;oBACzD,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU;oBAC1D,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,SAAS;oBAC1C,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU;oBAC5D,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,KAAK,EACxC,CAAC;oBACD,IAAI,UAAU,GAAG,EAAE,CAAC;oBACpB,IAAI,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU,EAAE,CAAC;wBAC1D,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC;oBACvC,CAAC;yBAAM,IAAI,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,OAAO,IAAI,OAAO,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,KAAK,KAAK,QAAQ,EAAE,CAAC;wBAC9G,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAC;oBACxC,CAAC;oBAED,IAAI,YAAY,CAAC,UAAU,CAAC,IAAI,sBAAsB,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC;wBACnE,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI;4BACJ,SAAS,EAAE,cAAc;4BACzB,IAAI,EAAE,EAAE,OAAO,EAAE,UAAU,EAAE;4BAC7B,OAAO,EAAE,CAAC,EAAE,SAAS,EAAE,mBAAmB,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI,EAAE,CAAC;yBAC/D,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;YACH,CAAC;YAED,gEAAgE;YAChE,QAAQ,CAAC,IAAuB;gBAC9B,IAAI,QAAQ,GAAG,EAAE,CAAC;gBAClB,IAAI,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU,EAAE,CAAC;oBAChD,QAAQ,GAAG,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC;gBAC3B,CAAC;qBAAM,IAAI,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,8BAAc,CAAC,OAAO,IAAI,OAAO,IAAI,CAAC,GAAG,CAAC,KAAK,KAAK,QAAQ,EAAE,CAAC;oBAC1F,QAAQ,GAAG,IAAI,CAAC,GAAG,CAAC,KAAK,CAAC;gBAC5B,CAAC;gBAED,IAAI,YAAY,CAAC,QAAQ,CAAC,IAAI,sBAAsB,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC;oBACjE,oDAAoD;oBACpD,IAAI,MAAM,GAA8B,IAAI,CAAC,MAAM,CAAC;oBACpD,OAAO,MAAM,EAAE,CAAC;wBACd,IAAI,MAAM,CAAC,IAAI,KAAK,8BAAc,CAAC,gBAAgB,EAAE,CAAC;4BACpD,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC;4BACvB,SAAS;wBACX,CAAC;wBACD,IACE,MAAM,CAAC,IAAI,KAAK,8BAAc,CAAC,kBAAkB;4BACjD,MAAM,CAAC,EAAE,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU;4BAC5C,sBAAsB,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC,IAAI,CAAC,EAC3C,CAAC;4BACD,OAAO,CAAC,MAAM,CAAC;gCACb,IAAI;gCACJ,SAAS,EAAE,cAAc;gCACzB,IAAI,EAAE,EAAE,OAAO,EAAE,QAAQ,EAAE;gCAC3B,OAAO,EAAE,CAAC,EAAE,SAAS,EAAE,mBAAmB,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI,EAAE,CAAC;6BAC/D,CAAC,CAAC;4BACH,MAAM;wBACR,CAAC;wBACD,MAAM;oBACR,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC"}
|