eslint-plugin-jest 28.0.0-next.2 → 28.0.0-next.3

package/lib/index.js

@@ -8,8 +8,6 @@ var snapshotProcessor = _interopRequireWildcard(require("./processors/snapshot-p
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function (e) { return e ? t : r; })(e); }
 function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && Object.prototype.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
-// v5 of `@typescript-eslint/experimental-utils` removed this
-
 // copied from https://github.com/babel/babel/blob/d8da63c929f2d28c401571e2a43166678c555bc4/packages/babel-helpers/src/helpers.js#L602-L606
 /* istanbul ignore next */
 const interopRequireDefault = obj => obj && obj.__esModule ? obj : {

package/lib/rules/consistent-test-it.js

@@ -11,9 +11,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Enforce `test` and `it` usage conventions',
-      recommended: false
+      description: 'Enforce `test` and `it` usage conventions'
     },
     fixable: 'code',
     messages: {
@@ -24,9 +22,11 @@ var _default = exports.default = (0, _utils2.createRule)({
       type: 'object',
       properties: {
         fn: {
+          type: 'string',
           enum: [_utils2.TestCaseName.it, _utils2.TestCaseName.test]
         },
         withinDescribe: {
+          type: 'string',
           enum: [_utils2.TestCaseName.it, _utils2.TestCaseName.test]
         }
       },

package/lib/rules/expect-expect.js

@@ -30,9 +30,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Enforce assertion to be made in a test body',
-      recommended: 'warn'
+      description: 'Enforce assertion to be made in a test body'
     },
     messages: {
       noAssertions: 'Test has no assertions'

package/lib/rules/max-expects.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Enforces a maximum number assertion calls in a test body',
-      recommended: false
+      description: 'Enforces a maximum number assertion calls in a test body'
     },
     messages: {
       exceededMaxAssertion: 'Too many assertion calls ({{ count }}) - maximum allowed is {{ max }}'

package/lib/rules/max-nested-describe.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Enforces a maximum depth to nested describe calls',
-      recommended: false
+      description: 'Enforces a maximum depth to nested describe calls'
     },
     messages: {
       exceededMaxDepth: 'Too many nested describe calls ({{ depth }}) - maximum allowed is {{ max }}'

package/lib/rules/no-alias-methods.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow alias methods',
-      recommended: 'error'
+      description: 'Disallow alias methods'
     },
     messages: {
       replaceAlias: `Replace {{ alias }}() with its canonical name of {{ canonical }}()`

package/lib/rules/no-commented-out-tests.js

@@ -12,9 +12,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow commented out tests',
-      recommended: 'warn'
+      description: 'Disallow commented out tests'
     },
     messages: {
       commentedTests: 'Some tests seem to be commented'

package/lib/rules/no-conditional-expect.js

@@ -11,9 +11,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      description: 'Disallow calling `expect` conditionally',
-      category: 'Best Practices',
-      recommended: 'error'
+      description: 'Disallow calling `expect` conditionally'
     },
     messages: {
       conditionalExpect: 'Avoid calling `expect` conditionally`'

package/lib/rules/no-conditional-in-test.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      description: 'Disallow conditional logic in tests',
-      category: 'Best Practices',
-      recommended: false
+      description: 'Disallow conditional logic in tests'
     },
     messages: {
       conditionalInTest: 'Avoid having conditionals in tests'

package/lib/rules/no-confusing-set-timeout.js

@@ -12,9 +12,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow confusing usages of jest.setTimeout',
-      recommended: false
+      description: 'Disallow confusing usages of jest.setTimeout'
     },
     messages: {
       globalSetTimeout: '`jest.setTimeout` should be call in `global` scope',

package/lib/rules/no-deprecated-functions.js

@@ -17,9 +17,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow use of deprecated functions',
-      recommended: 'error'
+      description: 'Disallow use of deprecated functions'
     },
     messages: {
       deprecatedFunction: '`{{ deprecation }}` has been deprecated in favor of `{{ replacement }}`'

package/lib/rules/no-disabled-tests.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow disabled tests',
-      recommended: 'warn'
+      description: 'Disallow disabled tests'
     },
     messages: {
       missingFunction: 'Test is missing function argument',

package/lib/rules/no-done-callback.js

@@ -23,9 +23,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow using a callback in asynchronous tests and hooks',
-      recommended: 'error'
+      description: 'Disallow using a callback in asynchronous tests and hooks'
     },
     messages: {
       noDoneCallback: 'Return a Promise instead of relying on callback parameter',

package/lib/rules/no-duplicate-hooks.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow duplicate setup and teardown hooks',
-      recommended: false
+      description: 'Disallow duplicate setup and teardown hooks'
     },
     messages: {
       noDuplicateHook: 'Duplicate {{hook}} in describe block'

package/lib/rules/no-export.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow using `exports` in files containing tests',
-      recommended: 'error'
+      description: 'Disallow using `exports` in files containing tests'
     },
     messages: {
       unexpectedExport: `Do not export from a test file`

package/lib/rules/no-focused-tests.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow focused tests',
-      recommended: 'error'
+      description: 'Disallow focused tests'
     },
     messages: {
       focusedTest: 'Unexpected focused test',

package/lib/rules/no-hooks.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow setup and teardown hooks',
-      recommended: false
+      description: 'Disallow setup and teardown hooks'
     },
     messages: {
       unexpectedHook: "Unexpected '{{ hookName }}' hook"
@@ -21,6 +19,7 @@ var _default = exports.default = (0, _utils.createRule)({
       properties: {
         allow: {
           type: 'array',
+          // @ts-expect-error https://github.com/eslint/eslint/discussions/17573
           contains: ['beforeAll', 'beforeEach', 'afterAll', 'afterEach']
         }
       },

package/lib/rules/no-identical-title.js

@@ -13,9 +13,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow identical titles',
-      recommended: 'error'
+      description: 'Disallow identical titles'
     },
     messages: {
       multipleTestTitle: 'Test title is used multiple times in the same describe block',

package/lib/rules/no-interpolation-in-snapshots.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow string interpolation inside snapshots',
-      recommended: 'error'
+      description: 'Disallow string interpolation inside snapshots'
     },
     messages: {
       noInterpolation: 'Do not use string interpolation inside of snapshots'

package/lib/rules/no-jasmine-globals.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow Jasmine globals',
-      recommended: 'error'
+      description: 'Disallow Jasmine globals'
     },
     messages: {
       illegalGlobal: 'Illegal usage of global `{{ global }}`, prefer `{{ replacement }}`',

package/lib/rules/no-large-snapshots.js

@@ -47,9 +47,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow large snapshots',
-      recommended: false
+      description: 'Disallow large snapshots'
     },
     messages: {
       noSnapshot: '`{{ lineCount }}`s should begin with lowercase',

package/lib/rules/no-mocks-import.js

@@ -14,9 +14,7 @@ var _default = exports.default = (0, _utils.createRule)({
   meta: {
     type: 'problem',
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow manually importing from `__mocks__`',
-      recommended: 'error'
+      description: 'Disallow manually importing from `__mocks__`'
     },
     messages: {
       noManualImport: `Mocks should not be manually imported from a ${mocksDirName} directory. Instead use \`jest.mock\` and import from the original module path`

package/lib/rules/no-restricted-jest-methods.js

@@ -13,9 +13,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow specific `jest.` methods',
-      recommended: false
+      description: 'Disallow specific `jest.` methods'
     },
     type: 'suggestion',
     schema: [{

package/lib/rules/no-restricted-matchers.js

@@ -15,9 +15,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow specific matchers & modifiers',
-      recommended: false
+      description: 'Disallow specific matchers & modifiers'
     },
     type: 'suggestion',
     schema: [{

package/lib/rules/no-standalone-expect.js

@@ -37,15 +37,14 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow using `expect` outside of `it` or `test` blocks',
-      recommended: 'error'
+      description: 'Disallow using `expect` outside of `it` or `test` blocks'
     },
     messages: {
       unexpectedExpect: 'Expect must be inside of a test block'
     },
     type: 'suggestion',
     schema: [{
+      type: 'object',
       properties: {
         additionalTestBlockFunctions: {
           type: 'array',

package/lib/rules/no-test-prefixes.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Require using `.only` and `.skip` over `f` and `x`',
-      recommended: 'error'
+      description: 'Require using `.only` and `.skip` over `f` and `x`'
     },
     messages: {
       usePreferredName: 'Use "{{ preferredNodeName }}" instead'

package/lib/rules/no-test-return-statement.js

@@ -17,9 +17,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow explicitly returning from tests',
-      recommended: false
+      description: 'Disallow explicitly returning from tests'
     },
     messages: {
       noReturnValue: 'Jest tests should not return a value'

package/lib/rules/no-untyped-mock-factory.js

@@ -16,9 +16,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Disallow using `jest.mock()` factories without an explicit type parameter',
-      recommended: false
+      description: 'Disallow using `jest.mock()` factories without an explicit type parameter'
     },
     messages: {
       addTypeParameterToModuleMock: 'Add a type parameter to the mock factory such as `typeof import({{ moduleName }})`'
@@ -31,10 +29,15 @@ var _default = exports.default = (0, _utils2.createRule)({
   create(context) {
     return {
       CallExpression(node) {
-        const {
+        let {
           callee,
-          typeParameters
+          typeArguments
         } = node;
+
+        /* istanbul ignore next */
+        if (!('typeArguments' in node)) {
+          typeArguments = node.typeParameters;
+        }
         if (callee.type !== _utils.AST_NODE_TYPES.MemberExpression) {
           return;
         }
@@ -43,7 +46,7 @@ var _default = exports.default = (0, _utils2.createRule)({
         } = callee;
         if (node.arguments.length === 2 && (0, _utils2.isTypeOfJestFnCall)(node, context, ['jest']) && (0, _utils2.isSupportedAccessor)(property) && ['mock', 'doMock'].includes((0, _utils2.getAccessorValue)(property))) {
           const [nameNode, factoryNode] = node.arguments;
-          const hasTypeParameter = typeParameters !== undefined && typeParameters.params.length > 0;
+          const hasTypeParameter = typeArguments !== undefined && typeArguments.params.length > 0;
           const hasReturnType = (0, _utils2.isFunction)(factoryNode) && factoryNode.returnType !== undefined;
           if (hasTypeParameter || hasReturnType) {
             return;

package/lib/rules/prefer-called-with.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `toBeCalledWith()` or `toHaveBeenCalledWith()`',
-      recommended: false
+      description: 'Suggest using `toBeCalledWith()` or `toHaveBeenCalledWith()`'
     },
     messages: {
       preferCalledWith: 'Prefer {{ matcherName }}With(/* expected args */)'

package/lib/rules/prefer-comparison-matcher.js

@@ -43,9 +43,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using the built-in comparison matchers',
-      recommended: false
+      description: 'Suggest using the built-in comparison matchers'
     },
     messages: {
       useToBeComparison: 'Prefer using `{{ preferredMatcher }}` instead'

package/lib/rules/prefer-each.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Prefer using `.each` rather than manual loops',
-      recommended: false
+      description: 'Prefer using `.each` rather than manual loops'
     },
     messages: {
       preferEach: 'prefer using `{{ fn }}.each` rather than a manual loop'

package/lib/rules/prefer-equality-matcher.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using the built-in equality matchers',
-      recommended: false
+      description: 'Suggest using the built-in equality matchers'
     },
     messages: {
       useEqualityMatcher: 'Prefer using one of the equality matchers instead',

package/lib/rules/prefer-expect-assertions.js

@@ -32,9 +32,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `expect.assertions()` OR `expect.hasAssertions()`',
-      recommended: false
+      description: 'Suggest using `expect.assertions()` OR `expect.hasAssertions()`'
     },
     messages: {
       hasAssertionsTakesNoArguments: '`expect.hasAssertions` expects no arguments',

package/lib/rules/prefer-expect-resolves.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Prefer `await expect(...).resolves` over `expect(await ...)` syntax',
-      recommended: false
+      description: 'Prefer `await expect(...).resolves` over `expect(await ...)` syntax'
     },
     fixable: 'code',
     messages: {

package/lib/rules/prefer-hooks-in-order.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Prefer having hooks in a consistent order',
-      recommended: false
+      description: 'Prefer having hooks in a consistent order'
     },
     messages: {
       reorderHooks: `\`{{ currentHook }}\` hooks should be before any \`{{ previousHook }}\` hooks`

package/lib/rules/prefer-hooks-on-top.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest having hooks before any test cases',
-      recommended: false
+      description: 'Suggest having hooks before any test cases'
     },
     messages: {
       noHookOnTop: 'Hooks should come before test cases'

package/lib/rules/prefer-lowercase-title.js

@@ -24,9 +24,7 @@ var _default = exports.default = (0, _utils.createRule)({
   meta: {
     type: 'suggestion',
     docs: {
-      description: 'Enforce lowercase test names',
-      category: 'Best Practices',
-      recommended: false
+      description: 'Enforce lowercase test names'
     },
     fixable: 'code',
     messages: {
@@ -38,6 +36,9 @@ var _default = exports.default = (0, _utils.createRule)({
         ignore: {
           type: 'array',
           items: {
+            type: 'string',
+            // for some reason TypeScript thinks this _must_ be a read-only
+            // array, so we have to explicitly cast it as a mutable array
             enum: [_utils.DescribeAlias.describe, _utils.TestCaseName.test, _utils.TestCaseName.it]
           },
           additionalItems: false

package/lib/rules/prefer-mock-promise-shorthand.js

@@ -22,9 +22,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Prefer mock resolved/rejected shorthands for promises',
-      recommended: false
+      description: 'Prefer mock resolved/rejected shorthands for promises'
     },
     messages: {
       useMockShorthand: 'Prefer {{ replacement }}'

package/lib/rules/prefer-snapshot-hint.js

@@ -36,9 +36,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Prefer including a hint with external snapshots',
-      recommended: false
+      description: 'Prefer including a hint with external snapshots'
     },
     messages,
     type: 'suggestion',

package/lib/rules/prefer-spy-on.js

@@ -41,9 +41,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `jest.spyOn()`',
-      recommended: false
+      description: 'Suggest using `jest.spyOn()`'
     },
     messages: {
       useJestSpyOn: 'Use jest.spyOn() instead'

package/lib/rules/prefer-strict-equal.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `toStrictEqual()`',
-      recommended: false
+      description: 'Suggest using `toStrictEqual()`'
     },
     messages: {
       useToStrictEqual: 'Use `toStrictEqual()` instead',

package/lib/rules/prefer-to-be.js

@@ -46,9 +46,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `toBe()` for primitive literals',
-      recommended: false
+      description: 'Suggest using `toBe()` for primitive literals'
     },
     messages: {
       useToBe: 'Use `toBe` when expecting primitive literals',

package/lib/rules/prefer-to-contain.js

@@ -21,9 +21,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `toContain()`',
-      recommended: false
+      description: 'Suggest using `toContain()`'
     },
     messages: {
       useToContain: 'Use toContain() instead'

package/lib/rules/prefer-to-have-length.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `toHaveLength()`',
-      recommended: false
+      description: 'Suggest using `toHaveLength()`'
     },
     messages: {
       useToHaveLength: 'Use toHaveLength() instead'

package/lib/rules/prefer-todo.js

@@ -33,9 +33,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `test.todo`',
-      recommended: false
+      description: 'Suggest using `test.todo`'
     },
     messages: {
       emptyTest: 'Prefer todo test case over empty test case',

package/lib/rules/require-hook.js

@@ -38,9 +38,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Require setup and teardown code to be within a hook',
-      recommended: false
+      description: 'Require setup and teardown code to be within a hook'
     },
     messages: {
       useHook: 'This should be done within a hook'

package/lib/rules/require-to-throw-message.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Require a message for `toThrow()`',
-      recommended: false
+      description: 'Require a message for `toThrow()`'
     },
     messages: {
       addErrorMessage: 'Add an error message to {{ matcherName }}()'

package/lib/rules/require-top-level-describe.js

@@ -14,9 +14,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Require test cases and hooks to be inside a `describe` block',
-      recommended: false
+      description: 'Require test cases and hooks to be inside a `describe` block'
     },
     messages,
     type: 'suggestion',

package/lib/rules/unbound-method.js

@@ -36,11 +36,11 @@ var _default = exports.default = (0, _utils2.createRule)({
     type: 'problem',
     ...baseRule?.meta,
     docs: {
-      category: 'Best Practices',
       description: 'Enforce unbound methods are called with their expected scope',
       requiresTypeChecking: true,
       ...baseRule?.meta.docs,
-      recommended: false
+      // mark this as not recommended
+      recommended: undefined
     }
   },
   create(context) {

package/lib/rules/utils/misc.js

@@ -160,42 +160,30 @@ const getFirstMatcherArg = expectFnCall => {
 /* istanbul ignore next */
 exports.getFirstMatcherArg = getFirstMatcherArg;
 const getFilename = context => {
-  return 'filename' in context ? context.filename : context.getFilename();
+  return context.filename ?? context.getFilename();
 };
 
 /* istanbul ignore next */
 exports.getFilename = getFilename;
 const getSourceCode = context => {
-  return 'sourceCode' in context ? context.sourceCode : context.getSourceCode();
+  return context.sourceCode ?? context.getSourceCode();
 };
 
 /* istanbul ignore next */
 exports.getSourceCode = getSourceCode;
 const getScope = (context, node) => {
-  const sourceCode = getSourceCode(context);
-  if ('getScope' in sourceCode) {
-    return sourceCode.getScope(node);
-  }
-  return context.getScope();
+  return getSourceCode(context).getScope?.(node) ?? context.getScope();
 };
 
 /* istanbul ignore next */
 exports.getScope = getScope;
 const getAncestors = (context, node) => {
-  const sourceCode = getSourceCode(context);
-  if ('getAncestors' in sourceCode) {
-    return sourceCode.getAncestors(node);
-  }
-  return context.getAncestors();
+  return getSourceCode(context).getAncestors?.(node) ?? context.getAncestors();
 };
 
 /* istanbul ignore next */
 exports.getAncestors = getAncestors;
 const getDeclaredVariables = (context, node) => {
-  const sourceCode = getSourceCode(context);
-  if ('getDeclaredVariables' in sourceCode) {
-    return sourceCode.getDeclaredVariables(node);
-  }
-  return context.getDeclaredVariables(node);
+  return getSourceCode(context).getDeclaredVariables?.(node) ?? context.getDeclaredVariables(node);
 };
 exports.getDeclaredVariables = getDeclaredVariables;

package/lib/rules/utils/parseJestFnCall.js

@@ -50,6 +50,10 @@ const determineJestFnType = name => {
   return 'unknown';
 };
 const ValidJestFnCallChains = ['afterAll', 'afterEach', 'beforeAll', 'beforeEach', 'describe', 'describe.each', 'describe.only', 'describe.only.each', 'describe.skip', 'describe.skip.each', 'fdescribe', 'fdescribe.each', 'xdescribe', 'xdescribe.each', 'it', 'it.concurrent', 'it.concurrent.failing', 'it.concurrent.each', 'it.concurrent.failing.each', 'it.concurrent.failing.only.each', 'it.concurrent.failing.skip.each', 'it.concurrent.only.each', 'it.concurrent.skip.each', 'it.each', 'it.failing', 'it.failing.each', 'it.only', 'it.only.each', 'it.only.failing', 'it.only.failing.each', 'it.skip', 'it.skip.each', 'it.skip.failing', 'it.skip.failing.each', 'it.todo', 'fit', 'fit.each', 'fit.failing', 'fit.failing.each', 'xit', 'xit.each', 'xit.failing', 'xit.failing.each', 'test', 'test.concurrent', 'test.concurrent.failing', 'test.concurrent.each', 'test.concurrent.failing.each', 'test.concurrent.failing.only.each', 'test.concurrent.failing.skip.each', 'test.concurrent.only.each', 'test.concurrent.skip.each', 'test.each', 'test.failing', 'test.failing.each', 'test.only', 'test.only.each', 'test.only.failing', 'test.only.failing.each', 'test.skip', 'test.skip.each', 'test.skip.failing', 'test.skip.failing.each', 'test.todo', 'xtest', 'xtest.each', 'xtest.failing', 'xtest.failing.each'];
+
+// todo: switch back to using declaration merging once https://github.com/typescript-eslint/typescript-eslint/pull/8485
+//  is landed
+
 const resolvePossibleAliasedGlobal = (global, context) => {
   const globalAliases = context.settings.jest?.globalAliases ?? {};
   const alias = Object.entries(globalAliases).find(([, aliases]) => aliases.includes(global));

package/lib/rules/valid-describe-callback.js

@@ -19,9 +19,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   meta: {
     type: 'problem',
     docs: {
-      category: 'Possible Errors',
-      description: 'Enforce valid `describe()` callback',
-      recommended: 'error'
+      description: 'Enforce valid `describe()` callback'
     },
     messages: {
       nameAndCallback: 'Describe requires name and callback arguments',

package/lib/rules/valid-expect-in-promise.js

@@ -205,9 +205,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Require promises that have expectations in their chain to be valid',
-      recommended: 'error'
+      description: 'Require promises that have expectations in their chain to be valid'
     },
     messages: {
       expectInFloatingPromise: 'This promise should either be returned or awaited to ensure the expects in its chain are called'

package/lib/rules/valid-expect.js

@@ -54,9 +54,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Enforce valid `expect()` usage',
-      recommended: 'error'
+      description: 'Enforce valid `expect()` usage'
     },
     messages: {
       tooManyArgs: 'Expect takes at most {{ amount }} argument{{ s }}',

package/lib/rules/valid-title.js

@@ -49,9 +49,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Enforce valid titles',
-      recommended: 'error'
+      description: 'Enforce valid titles'
     },
     messages: {
       titleMustBeString: 'Title must be a string',
@@ -93,6 +91,7 @@ var _default = exports.default = (0, _utils2.createRule)({
             type: 'string'
           }, MatcherAndMessageSchema, {
             type: 'object',
+            // @ts-expect-error https://github.com/eslint/eslint/discussions/17573
             propertyNames: {
               enum: ['describe', 'test', 'it']
             },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-jest",
-  "version": "28.0.0-next.2",
+  "version": "28.0.0-next.3",
   "description": "ESLint rules for Jest",
   "keywords": [
     "eslint",
@@ -95,7 +95,7 @@
     ]
   },
   "dependencies": {
-    "@typescript-eslint/utils": "^5.10.0"
+    "@typescript-eslint/utils": "^6.0.0"
   },
   "devDependencies": {
     "@babel/cli": "^7.4.4",
@@ -107,7 +107,7 @@
     "@schemastore/package": "^0.0.10",
     "@semantic-release/changelog": "^6.0.0",
     "@semantic-release/git": "^10.0.0",
-    "@tsconfig/node14": "^14.1.0",
+    "@tsconfig/node16": "^16.0.0",
     "@types/eslint": "^8.4.6",
     "@types/jest": "^29.0.0",
     "@types/node": "^14.18.26",