eslint-plugin-jest 28.0.0-next.1 → 28.0.0-next.3

package/lib/rules/prefer-comparison-matcher.js

@@ -43,9 +43,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using the built-in comparison matchers',
-      recommended: false
+      description: 'Suggest using the built-in comparison matchers'
     },
     messages: {
       useToBeComparison: 'Prefer using `{{ preferredMatcher }}` instead'
@@ -59,13 +57,13 @@ var _default = exports.default = (0, _utils2.createRule)({
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-        if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect' || jestFnCall.args.length === 0) {
+        if (jestFnCall?.type !== 'expect' || jestFnCall.args.length === 0) {
           return;
         }
         const {
           parent: expect
         } = jestFnCall.head.node;
-        if ((expect === null || expect === void 0 ? void 0 : expect.type) !== _utils.AST_NODE_TYPES.CallExpression) {
+        if (expect?.type !== _utils.AST_NODE_TYPES.CallExpression) {
           return;
         }
         const {
@@ -76,7 +74,7 @@ var _default = exports.default = (0, _utils2.createRule)({
           matcher
         } = jestFnCall;
         const matcherArg = (0, _utils2.getFirstMatcherArg)(jestFnCall);
-        if ((comparison === null || comparison === void 0 ? void 0 : comparison.type) !== _utils.AST_NODE_TYPES.BinaryExpression || isComparingToString(comparison) || !_utils2.EqualityMatcher.hasOwnProperty((0, _utils2.getAccessorValue)(matcher)) || !(0, _utils2.isBooleanLiteral)(matcherArg)) {
+        if (comparison?.type !== _utils.AST_NODE_TYPES.BinaryExpression || isComparingToString(comparison) || !_utils2.EqualityMatcher.hasOwnProperty((0, _utils2.getAccessorValue)(matcher)) || !(0, _utils2.isBooleanLiteral)(matcherArg)) {
           return;
         }
         const [modifier] = jestFnCall.modifiers;

package/lib/rules/prefer-each.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Prefer using `.each` rather than manual loops',
-      recommended: false
+      description: 'Prefer using `.each` rather than manual loops'
     },
     messages: {
       preferEach: 'prefer using `{{ fn }}.each` rather than a manual loop'

package/lib/rules/prefer-equality-matcher.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using the built-in equality matchers',
-      recommended: false
+      description: 'Suggest using the built-in equality matchers'
     },
     messages: {
       useEqualityMatcher: 'Prefer using one of the equality matchers instead',
@@ -27,13 +25,13 @@ var _default = exports.default = (0, _utils2.createRule)({
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-        if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect' || jestFnCall.args.length === 0) {
+        if (jestFnCall?.type !== 'expect' || jestFnCall.args.length === 0) {
           return;
         }
         const {
           parent: expect
         } = jestFnCall.head.node;
-        if ((expect === null || expect === void 0 ? void 0 : expect.type) !== _utils.AST_NODE_TYPES.CallExpression) {
+        if (expect?.type !== _utils.AST_NODE_TYPES.CallExpression) {
           return;
         }
         const {
@@ -44,7 +42,7 @@ var _default = exports.default = (0, _utils2.createRule)({
           matcher
         } = jestFnCall;
         const matcherArg = (0, _utils2.getFirstMatcherArg)(jestFnCall);
-        if ((comparison === null || comparison === void 0 ? void 0 : comparison.type) !== _utils.AST_NODE_TYPES.BinaryExpression || comparison.operator !== '===' && comparison.operator !== '!==' || !_utils2.EqualityMatcher.hasOwnProperty((0, _utils2.getAccessorValue)(matcher)) || !(0, _utils2.isBooleanLiteral)(matcherArg)) {
+        if (comparison?.type !== _utils.AST_NODE_TYPES.BinaryExpression || comparison.operator !== '===' && comparison.operator !== '!==' || !_utils2.EqualityMatcher.hasOwnProperty((0, _utils2.getAccessorValue)(matcher)) || !(0, _utils2.isBooleanLiteral)(matcherArg)) {
           return;
         }
         const matcherValue = matcherArg.value;

package/lib/rules/prefer-expect-assertions.js

@@ -9,14 +9,13 @@ var _utils2 = require("./utils");
 const isFirstStatement = node => {
   let parent = node;
   while (parent) {
-    var _parent$parent, _parent$parent2;
-    if (((_parent$parent = parent.parent) === null || _parent$parent === void 0 ? void 0 : _parent$parent.type) === _utils.AST_NODE_TYPES.BlockStatement) {
+    if (parent.parent?.type === _utils.AST_NODE_TYPES.BlockStatement) {
       return parent.parent.body[0] === parent;
     }
 
     // if we've hit an arrow function, then it must have a single expression
     // as its body, as otherwise we would have hit the block statement already
-    if (((_parent$parent2 = parent.parent) === null || _parent$parent2 === void 0 ? void 0 : _parent$parent2.type) === _utils.AST_NODE_TYPES.ArrowFunctionExpression) {
+    if (parent.parent?.type === _utils.AST_NODE_TYPES.ArrowFunctionExpression) {
       return true;
     }
     parent = parent.parent;
@@ -33,9 +32,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `expect.assertions()` OR `expect.hasAssertions()`',
-      recommended: false
+      description: 'Suggest using `expect.assertions()` OR `expect.hasAssertions()`'
     },
     messages: {
       hasAssertionsTakesNoArguments: '`expect.hasAssertions` expects no arguments',
@@ -150,13 +147,12 @@ var _default = exports.default = (0, _utils2.createRule)({
       'ForOfStatement:exit': exitForLoop,
       CallExpression(node) {
         const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-        if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'test') {
+        if (jestFnCall?.type === 'test') {
           inTestCaseCall = true;
           return;
         }
-        if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'expect' && inTestCaseCall) {
-          var _jestFnCall$head$node;
-          if (expressionDepth === 1 && isFirstStatement(node) && ((_jestFnCall$head$node = jestFnCall.head.node.parent) === null || _jestFnCall$head$node === void 0 ? void 0 : _jestFnCall$head$node.type) === _utils.AST_NODE_TYPES.MemberExpression && jestFnCall.members.length === 1 && ['assertions', 'hasAssertions'].includes((0, _utils2.getAccessorValue)(jestFnCall.members[0]))) {
+        if (jestFnCall?.type === 'expect' && inTestCaseCall) {
+          if (expressionDepth === 1 && isFirstStatement(node) && jestFnCall.head.node.parent?.type === _utils.AST_NODE_TYPES.MemberExpression && jestFnCall.members.length === 1 && ['assertions', 'hasAssertions'].includes((0, _utils2.getAccessorValue)(jestFnCall.members[0]))) {
             checkExpectHasAssertions(jestFnCall, node);
             hasExpectAssertionsAsFirstStatement = true;
           }

package/lib/rules/prefer-expect-resolves.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Prefer `await expect(...).resolves` over `expect(await ...)` syntax',
-      recommended: false
+      description: 'Prefer `await expect(...).resolves` over `expect(await ...)` syntax'
     },
     fixable: 'code',
     messages: {
@@ -25,17 +23,17 @@ var _default = exports.default = (0, _utils2.createRule)({
   create: context => ({
     CallExpression(node) {
       const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-      if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect') {
+      if (jestFnCall?.type !== 'expect') {
         return;
       }
       const {
         parent
       } = jestFnCall.head.node;
-      if ((parent === null || parent === void 0 ? void 0 : parent.type) !== _utils.AST_NODE_TYPES.CallExpression) {
+      if (parent?.type !== _utils.AST_NODE_TYPES.CallExpression) {
         return;
       }
       const [awaitNode] = parent.arguments;
-      if ((awaitNode === null || awaitNode === void 0 ? void 0 : awaitNode.type) === _utils.AST_NODE_TYPES.AwaitExpression) {
+      if (awaitNode?.type === _utils.AST_NODE_TYPES.AwaitExpression) {
         context.report({
           node: awaitNode,
           messageId: 'expectResolves',

package/lib/rules/prefer-hooks-in-order.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Prefer having hooks in a consistent order',
-      recommended: false
+      description: 'Prefer having hooks in a consistent order'
     },
     messages: {
       reorderHooks: `\`{{ currentHook }}\` hooks should be before any \`{{ previousHook }}\` hooks`
@@ -31,7 +29,7 @@ var _default = exports.default = (0, _utils.createRule)({
           return;
         }
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-        if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'hook') {
+        if (jestFnCall?.type !== 'hook') {
           // Reset the previousHookIndex when encountering something different from a hook
           previousHookIndex = -1;
           return;

package/lib/rules/prefer-hooks-on-top.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest having hooks before any test cases',
-      recommended: false
+      description: 'Suggest having hooks before any test cases'
     },
     messages: {
       noHookOnTop: 'Hooks should come before test cases'

package/lib/rules/prefer-lowercase-title.js

@@ -24,9 +24,7 @@ var _default = exports.default = (0, _utils.createRule)({
   meta: {
     type: 'suggestion',
     docs: {
-      description: 'Enforce lowercase test names',
-      category: 'Best Practices',
-      recommended: false
+      description: 'Enforce lowercase test names'
     },
     fixable: 'code',
     messages: {
@@ -38,6 +36,9 @@ var _default = exports.default = (0, _utils.createRule)({
         ignore: {
           type: 'array',
           items: {
+            type: 'string',
+            // for some reason TypeScript thinks this _must_ be a read-only
+            // array, so we have to explicitly cast it as a mutable array
             enum: [_utils.DescribeAlias.describe, _utils.TestCaseName.test, _utils.TestCaseName.it]
           },
           additionalItems: false

package/lib/rules/prefer-mock-promise-shorthand.js

@@ -10,11 +10,10 @@ const withOnce = (name, addOnce) => {
   return `${name}${addOnce ? 'Once' : ''}`;
 };
 const findSingleReturnArgumentNode = fnNode => {
-  var _fnNode$body$body$;
   if (fnNode.body.type !== _utils.AST_NODE_TYPES.BlockStatement) {
     return fnNode.body;
   }
-  if (((_fnNode$body$body$ = fnNode.body.body[0]) === null || _fnNode$body$body$ === void 0 ? void 0 : _fnNode$body$body$.type) === _utils.AST_NODE_TYPES.ReturnStatement) {
+  if (fnNode.body.body[0]?.type === _utils.AST_NODE_TYPES.ReturnStatement) {
     return fnNode.body.body[0].argument;
   }
   return null;
@@ -23,9 +22,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Prefer mock resolved/rejected shorthands for promises',
-      recommended: false
+      description: 'Prefer mock resolved/rejected shorthands for promises'
     },
     messages: {
       useMockShorthand: 'Prefer {{ replacement }}'
@@ -37,7 +34,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   defaultOptions: [],
   create(context) {
     const report = (property, isOnce, outerArgNode, innerArgNode = outerArgNode) => {
-      if ((innerArgNode === null || innerArgNode === void 0 ? void 0 : innerArgNode.type) !== _utils.AST_NODE_TYPES.CallExpression) {
+      if (innerArgNode?.type !== _utils.AST_NODE_TYPES.CallExpression) {
         return;
       }
       const argName = (0, _utils2.getNodeName)(innerArgNode);

package/lib/rules/prefer-snapshot-hint.js

@@ -36,9 +36,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Prefer including a hint with external snapshots',
-      recommended: false
+      description: 'Prefer including a hint with external snapshots'
     },
     messages,
     type: 'suggestion',
@@ -95,8 +93,8 @@ var _default = exports.default = (0, _utils.createRule)({
       },
       CallExpression(node) {
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-        if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect') {
-          if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'describe' || (jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'test') {
+        if (jestFnCall?.type !== 'expect') {
+          if (jestFnCall?.type === 'describe' || jestFnCall?.type === 'test') {
             depths.push(expressionDepth);
             expressionDepth = 0;
           }

package/lib/rules/prefer-spy-on.js

@@ -29,8 +29,7 @@ const getJestFnCall = node => {
   return getJestFnCall(obj);
 };
 const getAutoFixMockImplementation = (jestFnCall, context) => {
-  var _jestFnCall$parent;
-  const hasMockImplementationAlready = ((_jestFnCall$parent = jestFnCall.parent) === null || _jestFnCall$parent === void 0 ? void 0 : _jestFnCall$parent.type) === _utils.AST_NODE_TYPES.MemberExpression && jestFnCall.parent.property.type === _utils.AST_NODE_TYPES.Identifier && jestFnCall.parent.property.name === 'mockImplementation';
+  const hasMockImplementationAlready = jestFnCall.parent?.type === _utils.AST_NODE_TYPES.MemberExpression && jestFnCall.parent.property.type === _utils.AST_NODE_TYPES.Identifier && jestFnCall.parent.property.name === 'mockImplementation';
   if (hasMockImplementationAlready) {
     return '';
   }
@@ -42,9 +41,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `jest.spyOn()`',
-      recommended: false
+      description: 'Suggest using `jest.spyOn()`'
     },
     messages: {
       useJestSpyOn: 'Use jest.spyOn() instead'

package/lib/rules/prefer-strict-equal.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `toStrictEqual()`',
-      recommended: false
+      description: 'Suggest using `toStrictEqual()`'
     },
     messages: {
       useToStrictEqual: 'Use `toStrictEqual()` instead',
@@ -26,7 +24,7 @@ var _default = exports.default = (0, _utils.createRule)({
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-        if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect') {
+        if (jestFnCall?.type !== 'expect') {
           return;
         }
         const {

package/lib/rules/prefer-to-be.js

@@ -30,9 +30,8 @@ const reportPreferToBe = (context, whatToBe, expectFnCall, func, modifierNode) =
   context.report({
     messageId: `useToBe${whatToBe}`,
     fix(fixer) {
-      var _expectFnCall$args;
       const fixes = [(0, _utils2.replaceAccessorFixer)(fixer, expectFnCall.matcher, `toBe${whatToBe}`)];
-      if ((_expectFnCall$args = expectFnCall.args) !== null && _expectFnCall$args !== void 0 && _expectFnCall$args.length && whatToBe !== '') {
+      if (expectFnCall.args?.length && whatToBe !== '') {
         fixes.push((0, _utils2.removeExtraArgumentsFixer)(fixer, context, func, 0));
       }
       if (modifierNode) {
@@ -47,9 +46,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `toBe()` for primitive literals',
-      recommended: false
+      description: 'Suggest using `toBe()` for primitive literals'
     },
     messages: {
       useToBe: 'Use `toBe` when expecting primitive literals',
@@ -67,7 +64,7 @@ var _default = exports.default = (0, _utils2.createRule)({
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-        if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect') {
+        if (jestFnCall?.type !== 'expect') {
           return;
         }
         const matcherName = (0, _utils2.getAccessorValue)(jestFnCall.matcher);

package/lib/rules/prefer-to-contain.js

@@ -21,9 +21,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `toContain()`',
-      recommended: false
+      description: 'Suggest using `toContain()`'
     },
     messages: {
       useToContain: 'Use toContain() instead'
@@ -37,13 +35,13 @@ var _default = exports.default = (0, _utils2.createRule)({
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-        if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect' || jestFnCall.args.length === 0) {
+        if (jestFnCall?.type !== 'expect' || jestFnCall.args.length === 0) {
           return;
         }
         const {
           parent: expect
         } = jestFnCall.head.node;
-        if ((expect === null || expect === void 0 ? void 0 : expect.type) !== _utils.AST_NODE_TYPES.CallExpression) {
+        if (expect?.type !== _utils.AST_NODE_TYPES.CallExpression) {
           return;
         }
         const {

package/lib/rules/prefer-to-have-length.js

@@ -10,9 +10,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `toHaveLength()`',
-      recommended: false
+      description: 'Suggest using `toHaveLength()`'
     },
     messages: {
       useToHaveLength: 'Use toHaveLength() instead'
@@ -26,20 +24,20 @@ var _default = exports.default = (0, _utils2.createRule)({
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-        if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect') {
+        if (jestFnCall?.type !== 'expect') {
           return;
         }
         const {
           parent: expect
         } = jestFnCall.head.node;
-        if ((expect === null || expect === void 0 ? void 0 : expect.type) !== _utils.AST_NODE_TYPES.CallExpression) {
+        if (expect?.type !== _utils.AST_NODE_TYPES.CallExpression) {
           return;
         }
         const [argument] = expect.arguments;
         const {
           matcher
         } = jestFnCall;
-        if (!_utils2.EqualityMatcher.hasOwnProperty((0, _utils2.getAccessorValue)(matcher)) || (argument === null || argument === void 0 ? void 0 : argument.type) !== _utils.AST_NODE_TYPES.MemberExpression || !(0, _utils2.isSupportedAccessor)(argument.property, 'length')) {
+        if (!_utils2.EqualityMatcher.hasOwnProperty((0, _utils2.getAccessorValue)(matcher)) || argument?.type !== _utils.AST_NODE_TYPES.MemberExpression || !(0, _utils2.isSupportedAccessor)(argument.property, 'length')) {
           return;
         }
         context.report({

package/lib/rules/prefer-todo.js

@@ -33,9 +33,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Suggest using `test.todo`',
-      recommended: false
+      description: 'Suggest using `test.todo`'
     },
     messages: {
       emptyTest: 'Prefer todo test case over empty test case',
@@ -51,7 +49,7 @@ var _default = exports.default = (0, _utils2.createRule)({
       CallExpression(node) {
         const [title, callback] = node.arguments;
         const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-        if (!title || (jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'test' || !isTargetedTestCase(jestFnCall) || !(0, _utils2.isStringNode)(title)) {
+        if (!title || jestFnCall?.type !== 'test' || !isTargetedTestCase(jestFnCall) || !(0, _utils2.isStringNode)(title)) {
           return;
         }
         if (callback && isEmptyFunction(callback)) {

package/lib/rules/require-hook.js

@@ -7,11 +7,10 @@ exports.default = void 0;
 var _utils = require("@typescript-eslint/utils");
 var _utils2 = require("./utils");
 const isJestFnCall = (node, context) => {
-  var _getNodeName;
   if ((0, _utils2.parseJestFnCall)(node, context)) {
     return true;
   }
-  return !!((_getNodeName = (0, _utils2.getNodeName)(node)) !== null && _getNodeName !== void 0 && _getNodeName.startsWith('jest.'));
+  return !!(0, _utils2.getNodeName)(node)?.startsWith('jest.');
 };
 const isNullOrUndefined = node => {
   return node.type === _utils.AST_NODE_TYPES.Literal && node.value === null || (0, _utils2.isIdentifier)(node, 'undefined');
@@ -39,9 +38,7 @@ var _default = exports.default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Require setup and teardown code to be within a hook',
-      recommended: false
+      description: 'Require setup and teardown code to be within a hook'
     },
     messages: {
       useHook: 'This should be done within a hook'

package/lib/rules/require-to-throw-message.js

@@ -9,9 +9,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Require a message for `toThrow()`',
-      recommended: false
+      description: 'Require a message for `toThrow()`'
     },
     messages: {
       addErrorMessage: 'Add an error message to {{ matcherName }}()'
@@ -24,7 +22,7 @@ var _default = exports.default = (0, _utils.createRule)({
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-        if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect') {
+        if (jestFnCall?.type !== 'expect') {
           return;
         }
         const {

package/lib/rules/require-top-level-describe.js

@@ -14,9 +14,7 @@ var _default = exports.default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
-      category: 'Best Practices',
-      description: 'Require test cases and hooks to be inside a `describe` block',
-      recommended: false
+      description: 'Require test cases and hooks to be inside a `describe` block'
     },
     messages,
     type: 'suggestion',

package/lib/rules/unbound-method.js

@@ -34,27 +34,26 @@ var _default = exports.default = (0, _utils2.createRule)({
     },
     schema: [],
     type: 'problem',
-    ...(baseRule === null || baseRule === void 0 ? void 0 : baseRule.meta),
+    ...baseRule?.meta,
     docs: {
-      category: 'Best Practices',
       description: 'Enforce unbound methods are called with their expected scope',
       requiresTypeChecking: true,
-      ...(baseRule === null || baseRule === void 0 ? void 0 : baseRule.meta.docs),
-      recommended: false
+      ...baseRule?.meta.docs,
+      // mark this as not recommended
+      recommended: undefined
     }
   },
   create(context) {
-    const baseSelectors = baseRule === null || baseRule === void 0 ? void 0 : baseRule.create(context);
+    const baseSelectors = baseRule?.create(context);
     if (!baseSelectors) {
       return {};
     }
     return {
       ...baseSelectors,
       MemberExpression(node) {
-        var _node$parent, _baseSelectors$Member;
-        if (((_node$parent = node.parent) === null || _node$parent === void 0 ? void 0 : _node$parent.type) === _utils.AST_NODE_TYPES.CallExpression) {
+        if (node.parent?.type === _utils.AST_NODE_TYPES.CallExpression) {
           const jestFnCall = (0, _utils2.parseJestFnCall)((0, _utils2.findTopMostCallExpression)(node.parent), context);
-          if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'expect') {
+          if (jestFnCall?.type === 'expect') {
             const {
               matcher
             } = jestFnCall;
@@ -63,7 +62,7 @@ var _default = exports.default = (0, _utils2.createRule)({
             }
           }
         }
-        (_baseSelectors$Member = baseSelectors.MemberExpression) === null || _baseSelectors$Member === void 0 || _baseSelectors$Member.call(baseSelectors, node);
+        baseSelectors.MemberExpression?.(node);
       }
     };
   }

package/lib/rules/utils/misc.js

@@ -103,7 +103,7 @@ const getTestCallExpressionsFromDeclaredVariables = (declaredVariables, context)
     references
   }) => acc.concat(references.map(({
     identifier
-  }) => identifier.parent).filter(node => (node === null || node === void 0 ? void 0 : node.type) === _utils.AST_NODE_TYPES.CallExpression && (0, _parseJestFnCall.isTypeOfJestFnCall)(node, context, ['test']))), []);
+  }) => identifier.parent).filter(node => node?.type === _utils.AST_NODE_TYPES.CallExpression && (0, _parseJestFnCall.isTypeOfJestFnCall)(node, context, ['test']))), []);
 };
 
 /**
@@ -160,42 +160,30 @@ const getFirstMatcherArg = expectFnCall => {
 /* istanbul ignore next */
 exports.getFirstMatcherArg = getFirstMatcherArg;
 const getFilename = context => {
-  return 'filename' in context ? context.filename : context.getFilename();
+  return context.filename ?? context.getFilename();
 };
 
 /* istanbul ignore next */
 exports.getFilename = getFilename;
 const getSourceCode = context => {
-  return 'sourceCode' in context ? context.sourceCode : context.getSourceCode();
+  return context.sourceCode ?? context.getSourceCode();
 };
 
 /* istanbul ignore next */
 exports.getSourceCode = getSourceCode;
 const getScope = (context, node) => {
-  const sourceCode = getSourceCode(context);
-  if ('getScope' in sourceCode) {
-    return sourceCode.getScope(node);
-  }
-  return context.getScope();
+  return getSourceCode(context).getScope?.(node) ?? context.getScope();
 };
 
 /* istanbul ignore next */
 exports.getScope = getScope;
 const getAncestors = (context, node) => {
-  const sourceCode = getSourceCode(context);
-  if ('getAncestors' in sourceCode) {
-    return sourceCode.getAncestors(node);
-  }
-  return context.getAncestors();
+  return getSourceCode(context).getAncestors?.(node) ?? context.getAncestors();
 };
 
 /* istanbul ignore next */
 exports.getAncestors = getAncestors;
 const getDeclaredVariables = (context, node) => {
-  const sourceCode = getSourceCode(context);
-  if ('getDeclaredVariables' in sourceCode) {
-    return sourceCode.getDeclaredVariables(node);
-  }
-  return context.getDeclaredVariables(node);
+  return getSourceCode(context).getDeclaredVariables?.(node) ?? context.getDeclaredVariables(node);
 };
 exports.getDeclaredVariables = getDeclaredVariables;