eslint-plugin-jest 27.1.6 → 27.1.7

package/README.md

@@ -273,7 +273,7 @@ set to warn in.\
 
 In order to use the rules powered by TypeScript type-checking, you must be using
 `@typescript-eslint/parser` & adjust your eslint config as outlined
-[here](https://github.com/typescript-eslint/typescript-eslint/blob/main/docs/linting/TYPED_LINTING.md).
+[here](https://typescript-eslint.io/docs/linting/typed-linting).
 
 Note that unlike the type-checking rules in `@typescript-eslint/eslint-plugin`,
 the rules here will fallback to doing nothing if type information is not

package/docs/rules/no-if.md

@@ -1,7 +1,7 @@
 # Disallow conditional logic (`no-if`)
 
 ❌ This rule is deprecated. It was replaced by
-[`no-conditional-in-test`](no-conditional-in-test.md).
+[`jest/no-conditional-in-test`](../../docs/rules/no-conditional-in-test.md).
 
 <!-- end auto-generated rule header -->
 

package/lib/rules/prefer-spy-on.js

@@ -28,6 +28,16 @@ const getJestFnCall = node => {
   }
   return getJestFnCall(obj);
 };
+const getAutoFixMockImplementation = (jestFnCall, context) => {
+  var _jestFnCall$parent;
+  const hasMockImplementationAlready = ((_jestFnCall$parent = jestFnCall.parent) === null || _jestFnCall$parent === void 0 ? void 0 : _jestFnCall$parent.type) === _utils.AST_NODE_TYPES.MemberExpression && jestFnCall.parent.property.type === _utils.AST_NODE_TYPES.Identifier && jestFnCall.parent.property.name === 'mockImplementation';
+  if (hasMockImplementationAlready) {
+    return '';
+  }
+  const [arg] = jestFnCall.arguments;
+  const argSource = arg && context.getSourceCode().getText(arg);
+  return argSource ? `.mockImplementation(${argSource})` : '.mockImplementation()';
+};
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
@@ -58,10 +68,8 @@ var _default = (0, _utils2.createRule)({
           node,
           messageId: 'useJestSpyOn',
           fix(fixer) {
-            const leftPropQuote = left.property.type === _utils.AST_NODE_TYPES.Identifier ? "'" : '';
-            const [arg] = jestFnCall.arguments;
-            const argSource = arg && context.getSourceCode().getText(arg);
-            const mockImplementation = argSource ? `.mockImplementation(${argSource})` : '.mockImplementation()';
+            const leftPropQuote = left.property.type === _utils.AST_NODE_TYPES.Identifier && !left.computed ? "'" : '';
+            const mockImplementation = getAutoFixMockImplementation(jestFnCall, context);
             return [fixer.insertTextBefore(left, `jest.spyOn(`), fixer.replaceTextRange([left.object.range[1], left.property.range[0]], `, ${leftPropQuote}`), fixer.replaceTextRange([left.property.range[1], jestFnCall.range[1]], `${leftPropQuote})${mockImplementation}`)];
           }
         });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-jest",
-  "version": "27.1.6",
+  "version": "27.1.7",
   "description": "ESLint rules for Jest",
   "keywords": [
     "eslint",
@@ -29,7 +29,7 @@
     "prettier:write": "prettier --write 'docs/**/*.md' README.md '.github/**' package.json tsconfig.json src/globals.json .yarnrc.yml",
     "postpublish": "pinst --enable",
     "test": "jest",
-    "tools:regenerate-docs": "yarn prepack && eslint-doc-generator && yarn prettier:write",
+    "tools:regenerate-docs": "yarn prepack && eslint-doc-generator",
     "typecheck": "tsc -p ."
   },
   "commitlint": {
@@ -121,7 +121,7 @@
     "dedent": "^0.7.0",
     "eslint": "^6.0.0 || ^7.0.0 || ^8.0.0",
     "eslint-config-prettier": "^8.3.0",
-    "eslint-doc-generator": "^0.26.0",
+    "eslint-doc-generator": "^1.0.0",
     "eslint-plugin-eslint-comments": "^3.1.2",
     "eslint-plugin-eslint-plugin": "^5.0.6",
     "eslint-plugin-import": "^2.25.1",