eslint-plugin-jest 27.1.2 → 27.1.4

package/lib/rules/no-done-callback.js

@@ -4,35 +4,27 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 const findCallbackArg = (node, isJestEach, context) => {
   if (isJestEach) {
     return node.arguments[1];
   }
-
   const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-
   if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'hook' && node.arguments.length >= 1) {
     return node.arguments[0];
   }
-
   if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'test' && node.arguments.length >= 2) {
     return node.arguments[1];
   }
-
   return null;
 };
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
       category: 'Best Practices',
-      description: 'Avoid using a callback in asynchronous tests and hooks',
+      description: 'Disallow using a callback in asynchronous tests and hooks',
       recommended: 'error'
     },
     messages: {
@@ -45,31 +37,24 @@ var _default = (0, _utils2.createRule)({
     hasSuggestions: true
   },
   defaultOptions: [],
-
   create(context) {
     return {
       CallExpression(node) {
         var _getNodeName;
-
         // done is the second argument for it.each, not the first
         const isJestEach = ((_getNodeName = (0, _utils2.getNodeName)(node.callee)) === null || _getNodeName === void 0 ? void 0 : _getNodeName.endsWith('.each')) ?? false;
-
         if (isJestEach && node.callee.type !== _utils.AST_NODE_TYPES.TaggedTemplateExpression) {
           // isJestEach but not a TaggedTemplateExpression, so this must be
           // the `jest.each([])()` syntax which this rule doesn't support due
           // to its complexity (see jest-community/eslint-plugin-jest#710)
           return;
         }
-
         const callback = findCallbackArg(node, isJestEach, context);
         const callbackArgIndex = Number(isJestEach);
-
         if (!callback || !(0, _utils2.isFunction)(callback) || callback.params.length !== 1 + callbackArgIndex) {
           return;
         }
-
         const argument = callback.params[callbackArgIndex];
-
         if (argument.type !== _utils.AST_NODE_TYPES.Identifier) {
           context.report({
             node: argument,
@@ -77,7 +62,6 @@ var _default = (0, _utils2.createRule)({
           });
           return;
         }
-
         if (callback.async) {
           context.report({
             node: argument,
@@ -85,7 +69,6 @@ var _default = (0, _utils2.createRule)({
           });
           return;
         }
-
         context.report({
           node: argument,
           messageId: 'noDoneCallback',
@@ -94,7 +77,6 @@ var _default = (0, _utils2.createRule)({
             data: {
               callback: argument.name
             },
-
             fix(fixer) {
               const {
                 body
@@ -104,46 +86,35 @@ var _default = (0, _utils2.createRule)({
               const lastBodyToken = sourceCode.getLastToken(body);
               const tokenBeforeArgument = sourceCode.getTokenBefore(argument);
               const tokenAfterArgument = sourceCode.getTokenAfter(argument);
-              /* istanbul ignore if */
 
+              /* istanbul ignore if */
               if (!firstBodyToken || !lastBodyToken || !tokenBeforeArgument || !tokenAfterArgument) {
                 throw new Error(`Unexpected null when attempting to fix ${context.getFilename()} - please file a github issue at https://github.com/jest-community/eslint-plugin-jest`);
               }
-
               const argumentInParens = tokenBeforeArgument.value === '(' && tokenAfterArgument.value === ')';
               let argumentFix = fixer.replaceText(argument, '()');
-
               if (argumentInParens) {
                 argumentFix = fixer.remove(argument);
               }
-
               let newCallback = argument.name;
-
               if (argumentInParens) {
                 newCallback = `(${newCallback})`;
               }
-
               let beforeReplacement = `new Promise(${newCallback} => `;
               let afterReplacement = ')';
               let replaceBefore = true;
-
               if (body.type === _utils.AST_NODE_TYPES.BlockStatement) {
                 const keyword = 'return';
                 beforeReplacement = `${keyword} ${beforeReplacement}{`;
                 afterReplacement += '}';
                 replaceBefore = false;
               }
-
               return [argumentFix, replaceBefore ? fixer.insertTextBefore(firstBodyToken, beforeReplacement) : fixer.insertTextAfter(firstBodyToken, beforeReplacement), fixer.insertTextAfter(lastBodyToken, afterReplacement)];
             }
-
           }]
         });
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-duplicate-hooks.js

@@ -4,9 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("./utils");
-
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -22,27 +20,21 @@ var _default = (0, _utils.createRule)({
     type: 'suggestion'
   },
   defaultOptions: [],
-
   create(context) {
     const hookContexts = [{}];
     return {
       CallExpression(node) {
         var _jestFnCall$name;
-
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'describe') {
           hookContexts.push({});
         }
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'hook') {
           return;
         }
-
         const currentLayer = hookContexts[hookContexts.length - 1];
         currentLayer[_jestFnCall$name = jestFnCall.name] || (currentLayer[_jestFnCall$name] = 0);
         currentLayer[jestFnCall.name] += 1;
-
         if (currentLayer[jestFnCall.name] > 1) {
           context.report({
             messageId: 'noDuplicateHook',
@@ -53,16 +45,12 @@ var _default = (0, _utils.createRule)({
           });
         }
       },
-
       'CallExpression:exit'(node) {
         if ((0, _utils.isTypeOfJestFnCall)(node, context, ['describe'])) {
           hookContexts.pop();
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-export.js

@@ -4,11 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
@@ -24,7 +21,6 @@ var _default = (0, _utils2.createRule)({
     schema: []
   },
   defaultOptions: [],
-
   create(context) {
     const exportNodes = [];
     let hasTestCase = false;
@@ -39,38 +35,30 @@ var _default = (0, _utils2.createRule)({
           }
         }
       },
-
       CallExpression(node) {
         if ((0, _utils2.isTypeOfJestFnCall)(node, context, ['test'])) {
           hasTestCase = true;
         }
       },
-
       'ExportNamedDeclaration, ExportDefaultDeclaration'(node) {
         exportNodes.push(node);
       },
-
       'AssignmentExpression > MemberExpression'(node) {
         let {
           object,
           property
         } = node;
-
         if (object.type === _utils.AST_NODE_TYPES.MemberExpression) {
           ({
             object,
             property
           } = object);
         }
-
         if ('name' in object && object.name === 'module' && property.type === _utils.AST_NODE_TYPES.Identifier && /^exports?$/u.test(property.name)) {
           exportNodes.push(node);
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-focused-tests.js

@@ -4,11 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
@@ -26,43 +23,34 @@ var _default = (0, _utils2.createRule)({
     hasSuggestions: true
   },
   defaultOptions: [],
-
   create(context) {
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'test' && (jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'describe') {
           return;
         }
-
         if (jestFnCall.name.startsWith('f')) {
           context.report({
             messageId: 'focusedTest',
             node,
             suggest: [{
               messageId: 'suggestRemoveFocus',
-
               fix(fixer) {
                 // don't apply the fixer if we're an aliased import
                 if (jestFnCall.head.type === 'import' && jestFnCall.name !== jestFnCall.head.local) {
                   return null;
                 }
-
                 return fixer.removeRange([node.range[0], node.range[0] + 1]);
               }
-
             }]
           });
           return;
         }
-
         const onlyNode = jestFnCall.members.find(s => (0, _utils2.getAccessorValue)(s) === 'only');
-
         if (!onlyNode) {
           return;
         }
-
         context.report({
           messageId: 'focusedTest',
           node: onlyNode,
@@ -72,10 +60,7 @@ var _default = (0, _utils2.createRule)({
           }]
         });
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-hooks.js

@@ -4,9 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("./utils");
-
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -33,14 +31,12 @@ var _default = (0, _utils.createRule)({
   defaultOptions: [{
     allow: []
   }],
-
   create(context, [{
     allow = []
   }]) {
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'hook' && !allow.includes(jestFnCall.name)) {
           context.report({
             node,
@@ -51,10 +47,7 @@ var _default = (0, _utils.createRule)({
           });
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-identical-title.js

@@ -4,14 +4,11 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("./utils");
-
 const newDescribeContext = () => ({
   describeTitles: [],
   testTitles: []
 });
-
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -28,34 +25,26 @@ var _default = (0, _utils.createRule)({
     type: 'suggestion'
   },
   defaultOptions: [],
-
   create(context) {
     const contexts = [newDescribeContext()];
     return {
       CallExpression(node) {
         const currentLayer = contexts[contexts.length - 1];
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-
         if (!jestFnCall) {
           return;
         }
-
         if (jestFnCall.type === 'describe') {
           contexts.push(newDescribeContext());
         }
-
         if (jestFnCall.members.find(s => (0, _utils.isSupportedAccessor)(s, 'each'))) {
           return;
         }
-
         const [argument] = node.arguments;
-
         if (!argument || !(0, _utils.isStringNode)(argument)) {
           return;
         }
-
         const title = (0, _utils.getStringValue)(argument);
-
         if (jestFnCall.type === 'test') {
           if (currentLayer.testTitles.includes(title)) {
             context.report({
@@ -63,33 +52,25 @@ var _default = (0, _utils.createRule)({
               node: argument
             });
           }
-
           currentLayer.testTitles.push(title);
         }
-
         if (jestFnCall.type !== 'describe') {
           return;
         }
-
         if (currentLayer.describeTitles.includes(title)) {
           context.report({
             messageId: 'multipleDescribeTitle',
             node: argument
           });
         }
-
         currentLayer.describeTitles.push(title);
       },
-
       'CallExpression:exit'(node) {
         if ((0, _utils.isTypeOfJestFnCall)(node, context, ['describe'])) {
           contexts.pop();
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-if.js

@@ -4,21 +4,15 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 const testCaseNames = new Set([...Object.keys(_utils2.TestCaseName), 'it.only', 'it.only', 'it.skip', 'it.skip', 'test.only', 'test.only', 'test.skip', 'test.skip', 'fit.concurrent']);
-
 const isTestFunctionExpression = node => node.parent !== undefined && node.parent.type === _utils.AST_NODE_TYPES.CallExpression && testCaseNames.has((0, _utils2.getNodeName)(node.parent.callee));
-
 const conditionName = {
   [_utils.AST_NODE_TYPES.ConditionalExpression]: 'conditional',
   [_utils.AST_NODE_TYPES.SwitchStatement]: 'switch',
   [_utils.AST_NODE_TYPES.IfStatement]: 'if'
 };
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
@@ -36,17 +30,13 @@ var _default = (0, _utils2.createRule)({
     type: 'suggestion'
   },
   defaultOptions: [],
-
   create(context) {
     const stack = [];
-
     function validate(node) {
       const lastElementInStack = stack[stack.length - 1];
-
       if (stack.length === 0 || !lastElementInStack) {
         return;
       }
-
       context.report({
         data: {
           condition: conditionName[node.type]
@@ -55,57 +45,43 @@ var _default = (0, _utils2.createRule)({
         node
       });
     }
-
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'test') {
           stack.push(true);
-
           if (jestFnCall.members.some(s => (0, _utils2.getAccessorValue)(s) === 'each')) {
             stack.push(true);
           }
         }
       },
-
       FunctionExpression(node) {
         stack.push(isTestFunctionExpression(node));
       },
-
       FunctionDeclaration(node) {
         const declaredVariables = context.getDeclaredVariables(node);
         const testCallExpressions = (0, _utils2.getTestCallExpressionsFromDeclaredVariables)(declaredVariables, context);
         stack.push(testCallExpressions.length > 0);
       },
-
       ArrowFunctionExpression(node) {
         stack.push(isTestFunctionExpression(node));
       },
-
       IfStatement: validate,
       SwitchStatement: validate,
       ConditionalExpression: validate,
-
       'CallExpression:exit'() {
         stack.pop();
       },
-
       'FunctionExpression:exit'() {
         stack.pop();
       },
-
       'FunctionDeclaration:exit'() {
         stack.pop();
       },
-
       'ArrowFunctionExpression:exit'() {
         stack.pop();
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-interpolation-in-snapshots.js

@@ -4,11 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
@@ -24,16 +21,13 @@ var _default = (0, _utils2.createRule)({
     type: 'problem'
   },
   defaultOptions: [],
-
   create(context) {
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect') {
           return;
         }
-
         if (['toMatchInlineSnapshot', 'toThrowErrorMatchingInlineSnapshot'].includes((0, _utils2.getAccessorValue)(jestFnCall.matcher))) {
           // Check all since the optional 'propertyMatchers' argument might be present
           jestFnCall.args.forEach(argument => {
@@ -46,10 +40,7 @@ var _default = (0, _utils2.createRule)({
           });
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-jasmine-globals.js

@@ -4,11 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
@@ -29,7 +26,6 @@ var _default = (0, _utils2.createRule)({
     type: 'suggestion'
   },
   defaultOptions: [],
-
   create(context) {
     return {
       CallExpression(node) {
@@ -37,17 +33,14 @@ var _default = (0, _utils2.createRule)({
           callee
         } = node;
         const calleeName = (0, _utils2.getNodeName)(callee);
-
         if (!calleeName) {
           return;
         }
-
         if (calleeName === 'spyOn' || calleeName === 'spyOnProperty' || calleeName === 'fail' || calleeName === 'pending') {
           if ((0, _utils2.scopeHasLocalReference)(context.getScope(), calleeName)) {
             // It's a local variable, not a jasmine global.
             return;
           }
-
           switch (calleeName) {
             case 'spyOn':
             case 'spyOnProperty':
@@ -60,14 +53,12 @@ var _default = (0, _utils2.createRule)({
                 }
               });
               break;
-
             case 'fail':
               context.report({
                 node,
                 messageId: 'illegalFail'
               });
               break;
-
             case 'pending':
               context.report({
                 node,
@@ -75,13 +66,10 @@ var _default = (0, _utils2.createRule)({
               });
               break;
           }
-
           return;
         }
-
         if (callee.type === _utils.AST_NODE_TYPES.MemberExpression && calleeName.startsWith('jasmine.')) {
           const functionName = calleeName.replace('jasmine.', '');
-
           if (functionName === 'any' || functionName === 'anything' || functionName === 'arrayContaining' || functionName === 'objectContaining' || functionName === 'stringMatching') {
             context.report({
               fix: fixer => [fixer.replaceText(callee.object, 'expect')],
@@ -94,7 +82,6 @@ var _default = (0, _utils2.createRule)({
             });
             return;
           }
-
           if (functionName === 'addMatchers') {
             context.report({
               node,
@@ -106,7 +93,6 @@ var _default = (0, _utils2.createRule)({
             });
             return;
           }
-
           if (functionName === 'createSpy') {
             context.report({
               node,
@@ -118,27 +104,23 @@ var _default = (0, _utils2.createRule)({
             });
             return;
           }
-
           context.report({
             node,
             messageId: 'illegalJasmine'
           });
         }
       },
-
       MemberExpression(node) {
         if ((0, _utils2.isSupportedAccessor)(node.object, 'jasmine')) {
           const {
             parent,
             property
           } = node;
-
           if (parent && parent.type === _utils.AST_NODE_TYPES.AssignmentExpression) {
             if ((0, _utils2.isSupportedAccessor)(property, 'DEFAULT_TIMEOUT_INTERVAL')) {
               const {
                 right
               } = parent;
-
               if (right.type === _utils.AST_NODE_TYPES.Literal) {
                 context.report({
                   fix: fixer => [fixer.replaceText(parent, `jest.setTimeout(${right.value})`)],
@@ -148,7 +130,6 @@ var _default = (0, _utils2.createRule)({
                 return;
               }
             }
-
             context.report({
               node,
               messageId: 'illegalJasmine'
@@ -156,10 +137,7 @@ var _default = (0, _utils2.createRule)({
           }
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;