eslint-plugin-jest 26.8.7 → 27.1.6

package/lib/rules/no-deprecated-functions.js

@@ -4,20 +4,15 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 const parseJestVersion = rawVersion => {
   if (typeof rawVersion === 'number') {
     return rawVersion;
   }
-
   const [majorVersion] = rawVersion.split('.');
   return parseInt(majorVersion, 10);
 };
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
@@ -34,12 +29,11 @@ var _default = (0, _utils2.createRule)({
     fixable: 'code'
   },
   defaultOptions: [],
-
   create(context) {
     var _context$settings, _context$settings$jes;
-
     const jestVersion = parseJestVersion(((_context$settings = context.settings) === null || _context$settings === void 0 ? void 0 : (_context$settings$jes = _context$settings.jest) === null || _context$settings$jes === void 0 ? void 0 : _context$settings$jes.version) || (0, _utils2.detectJestVersion)());
-    const deprecations = { ...(jestVersion >= 15 && {
+    const deprecations = {
+      ...(jestVersion >= 15 && {
         'jest.resetModuleRegistry': 'jest.resetModules'
       }),
       ...(jestVersion >= 17 && {
@@ -61,13 +55,10 @@ var _default = (0, _utils2.createRule)({
         if (node.callee.type !== _utils.AST_NODE_TYPES.MemberExpression) {
           return;
         }
-
         const deprecation = (0, _utils2.getNodeName)(node);
-
         if (!deprecation || !(deprecation in deprecations)) {
           return;
         }
-
         const replacement = deprecations[deprecation];
         const {
           callee
@@ -79,23 +70,16 @@ var _default = (0, _utils2.createRule)({
             replacement
           },
           node,
-
           fix(fixer) {
             let [name, func] = replacement.split('.');
-
             if (callee.property.type === _utils.AST_NODE_TYPES.Literal) {
               func = `'${func}'`;
             }
-
             return [fixer.replaceText(callee.object, name), fixer.replaceText(callee.property, func)];
           }
-
         });
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-disabled-tests.js

@@ -4,9 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("./utils");
-
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -27,25 +25,20 @@ var _default = (0, _utils.createRule)({
     type: 'suggestion'
   },
   defaultOptions: [],
-
   create(context) {
     let suiteDepth = 0;
     let testDepth = 0;
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-
         if (!jestFnCall) {
           return;
         }
-
         if (jestFnCall.type === 'describe') {
           suiteDepth++;
         }
-
         if (jestFnCall.type === 'test') {
           testDepth++;
-
           if (node.arguments.length < 2 && jestFnCall.members.every(s => (0, _utils.getAccessorValue)(s) !== 'todo')) {
             context.report({
               messageId: 'missingFunction',
@@ -53,8 +46,8 @@ var _default = (0, _utils.createRule)({
             });
           }
         }
-
-        if ( // the only jest functions that are with "x" are "xdescribe", "xtest", and "xit"
+        if (
+        // the only jest functions that are with "x" are "xdescribe", "xtest", and "xit"
         jestFnCall.name.startsWith('x') || jestFnCall.members.some(s => (0, _utils.getAccessorValue)(s) === 'skip')) {
           context.report({
             messageId: jestFnCall.type === 'describe' ? 'disabledSuite' : 'disabledTest',
@@ -62,28 +55,22 @@ var _default = (0, _utils.createRule)({
           });
         }
       },
-
       'CallExpression:exit'(node) {
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-
         if (!jestFnCall) {
           return;
         }
-
         if (jestFnCall.type === 'describe') {
           suiteDepth--;
         }
-
         if (jestFnCall.type === 'test') {
           testDepth--;
         }
       },
-
       'CallExpression[callee.name="pending"]'(node) {
-        if ((0, _utils.scopeHasLocalReference)(context.getScope(), 'pending')) {
+        if ((0, _utils.resolveScope)(context.getScope(), 'pending')) {
           return;
         }
-
         if (testDepth > 0) {
           context.report({
             messageId: 'pendingTest',
@@ -101,10 +88,7 @@ var _default = (0, _utils.createRule)({
           });
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-done-callback.js

@@ -4,37 +4,28 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 const findCallbackArg = (node, isJestEach, context) => {
   if (isJestEach) {
     return node.arguments[1];
   }
-
   const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-
   if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'hook' && node.arguments.length >= 1) {
     return node.arguments[0];
   }
-
   if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'test' && node.arguments.length >= 2) {
     return node.arguments[1];
   }
-
   return null;
 };
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
       category: 'Best Practices',
-      description: 'Avoid using a callback in asynchronous tests and hooks',
-      recommended: 'error',
-      suggestion: true
+      description: 'Disallow using a callback in asynchronous tests and hooks',
+      recommended: 'error'
     },
     messages: {
       noDoneCallback: 'Return a Promise instead of relying on callback parameter',
@@ -46,31 +37,24 @@ var _default = (0, _utils2.createRule)({
     hasSuggestions: true
   },
   defaultOptions: [],
-
   create(context) {
     return {
       CallExpression(node) {
-        var _getNodeName$endsWith, _getNodeName;
-
+        var _getNodeName;
         // done is the second argument for it.each, not the first
-        const isJestEach = (_getNodeName$endsWith = (_getNodeName = (0, _utils2.getNodeName)(node.callee)) === null || _getNodeName === void 0 ? void 0 : _getNodeName.endsWith('.each')) !== null && _getNodeName$endsWith !== void 0 ? _getNodeName$endsWith : false;
-
+        const isJestEach = ((_getNodeName = (0, _utils2.getNodeName)(node.callee)) === null || _getNodeName === void 0 ? void 0 : _getNodeName.endsWith('.each')) ?? false;
         if (isJestEach && node.callee.type !== _utils.AST_NODE_TYPES.TaggedTemplateExpression) {
           // isJestEach but not a TaggedTemplateExpression, so this must be
           // the `jest.each([])()` syntax which this rule doesn't support due
           // to its complexity (see jest-community/eslint-plugin-jest#710)
           return;
         }
-
         const callback = findCallbackArg(node, isJestEach, context);
         const callbackArgIndex = Number(isJestEach);
-
         if (!callback || !(0, _utils2.isFunction)(callback) || callback.params.length !== 1 + callbackArgIndex) {
           return;
         }
-
         const argument = callback.params[callbackArgIndex];
-
         if (argument.type !== _utils.AST_NODE_TYPES.Identifier) {
           context.report({
             node: argument,
@@ -78,7 +62,6 @@ var _default = (0, _utils2.createRule)({
           });
           return;
         }
-
         if (callback.async) {
           context.report({
             node: argument,
@@ -86,7 +69,6 @@ var _default = (0, _utils2.createRule)({
           });
           return;
         }
-
         context.report({
           node: argument,
           messageId: 'noDoneCallback',
@@ -95,56 +77,47 @@ var _default = (0, _utils2.createRule)({
             data: {
               callback: argument.name
             },
-
             fix(fixer) {
+              var _tokenAfterLastParam;
               const {
-                body
+                body,
+                params
               } = callback;
               const sourceCode = context.getSourceCode();
               const firstBodyToken = sourceCode.getFirstToken(body);
               const lastBodyToken = sourceCode.getLastToken(body);
-              const tokenBeforeArgument = sourceCode.getTokenBefore(argument);
-              const tokenAfterArgument = sourceCode.getTokenAfter(argument);
-              /* istanbul ignore if */
-
-              if (!firstBodyToken || !lastBodyToken || !tokenBeforeArgument || !tokenAfterArgument) {
-                throw new Error(`Unexpected null when attempting to fix ${context.getFilename()} - please file a github issue at https://github.com/jest-community/eslint-plugin-jest`);
+              const [firstParam] = params;
+              const lastParam = params[params.length - 1];
+              const tokenBeforeFirstParam = sourceCode.getTokenBefore(firstParam);
+              let tokenAfterLastParam = sourceCode.getTokenAfter(lastParam);
+              if (((_tokenAfterLastParam = tokenAfterLastParam) === null || _tokenAfterLastParam === void 0 ? void 0 : _tokenAfterLastParam.value) === ',') {
+                tokenAfterLastParam = sourceCode.getTokenAfter(tokenAfterLastParam);
               }
 
-              const argumentInParens = tokenBeforeArgument.value === '(' && tokenAfterArgument.value === ')';
-              let argumentFix = fixer.replaceText(argument, '()');
-
-              if (argumentInParens) {
-                argumentFix = fixer.remove(argument);
+              /* istanbul ignore if */
+              if (!firstBodyToken || !lastBodyToken || !tokenBeforeFirstParam || !tokenAfterLastParam) {
+                throw new Error(`Unexpected null when attempting to fix ${context.getFilename()} - please file a github issue at https://github.com/jest-community/eslint-plugin-jest`);
               }
-
-              let newCallback = argument.name;
-
-              if (argumentInParens) {
-                newCallback = `(${newCallback})`;
+              let argumentFix = fixer.replaceText(firstParam, '()');
+              if (tokenBeforeFirstParam.value === '(' && tokenAfterLastParam.value === ')') {
+                argumentFix = fixer.removeRange([tokenBeforeFirstParam.range[1], tokenAfterLastParam.range[0]]);
               }
-
+              const newCallback = argument.name;
               let beforeReplacement = `new Promise(${newCallback} => `;
               let afterReplacement = ')';
               let replaceBefore = true;
-
               if (body.type === _utils.AST_NODE_TYPES.BlockStatement) {
                 const keyword = 'return';
                 beforeReplacement = `${keyword} ${beforeReplacement}{`;
                 afterReplacement += '}';
                 replaceBefore = false;
               }
-
               return [argumentFix, replaceBefore ? fixer.insertTextBefore(firstBodyToken, beforeReplacement) : fixer.insertTextAfter(firstBodyToken, beforeReplacement), fixer.insertTextAfter(lastBodyToken, afterReplacement)];
             }
-
           }]
         });
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-duplicate-hooks.js

@@ -4,9 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("./utils");
-
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -22,27 +20,21 @@ var _default = (0, _utils.createRule)({
     type: 'suggestion'
   },
   defaultOptions: [],
-
   create(context) {
     const hookContexts = [{}];
     return {
       CallExpression(node) {
         var _jestFnCall$name;
-
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'describe') {
           hookContexts.push({});
         }
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'hook') {
           return;
         }
-
         const currentLayer = hookContexts[hookContexts.length - 1];
         currentLayer[_jestFnCall$name = jestFnCall.name] || (currentLayer[_jestFnCall$name] = 0);
         currentLayer[jestFnCall.name] += 1;
-
         if (currentLayer[jestFnCall.name] > 1) {
           context.report({
             messageId: 'noDuplicateHook',
@@ -53,16 +45,12 @@ var _default = (0, _utils.createRule)({
           });
         }
       },
-
       'CallExpression:exit'(node) {
         if ((0, _utils.isTypeOfJestFnCall)(node, context, ['describe'])) {
           hookContexts.pop();
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-export.js

@@ -4,11 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
@@ -24,7 +21,6 @@ var _default = (0, _utils2.createRule)({
     schema: []
   },
   defaultOptions: [],
-
   create(context) {
     const exportNodes = [];
     let hasTestCase = false;
@@ -39,38 +35,30 @@ var _default = (0, _utils2.createRule)({
           }
         }
       },
-
       CallExpression(node) {
         if ((0, _utils2.isTypeOfJestFnCall)(node, context, ['test'])) {
           hasTestCase = true;
         }
       },
-
       'ExportNamedDeclaration, ExportDefaultDeclaration'(node) {
         exportNodes.push(node);
       },
-
       'AssignmentExpression > MemberExpression'(node) {
         let {
           object,
           property
         } = node;
-
         if (object.type === _utils.AST_NODE_TYPES.MemberExpression) {
           ({
             object,
             property
           } = object);
         }
-
         if ('name' in object && object.name === 'module' && property.type === _utils.AST_NODE_TYPES.Identifier && /^exports?$/u.test(property.name)) {
           exportNodes.push(node);
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-focused-tests.js

@@ -4,19 +4,15 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
     docs: {
       category: 'Best Practices',
       description: 'Disallow focused tests',
-      recommended: 'error',
-      suggestion: true
+      recommended: 'error'
     },
     messages: {
       focusedTest: 'Unexpected focused test.',
@@ -27,43 +23,34 @@ var _default = (0, _utils2.createRule)({
     hasSuggestions: true
   },
   defaultOptions: [],
-
   create(context) {
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'test' && (jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'describe') {
           return;
         }
-
         if (jestFnCall.name.startsWith('f')) {
           context.report({
             messageId: 'focusedTest',
             node,
             suggest: [{
               messageId: 'suggestRemoveFocus',
-
               fix(fixer) {
                 // don't apply the fixer if we're an aliased import
                 if (jestFnCall.head.type === 'import' && jestFnCall.name !== jestFnCall.head.local) {
                   return null;
                 }
-
                 return fixer.removeRange([node.range[0], node.range[0] + 1]);
               }
-
             }]
           });
           return;
         }
-
         const onlyNode = jestFnCall.members.find(s => (0, _utils2.getAccessorValue)(s) === 'only');
-
         if (!onlyNode) {
           return;
         }
-
         context.report({
           messageId: 'focusedTest',
           node: onlyNode,
@@ -73,10 +60,7 @@ var _default = (0, _utils2.createRule)({
           }]
         });
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-hooks.js

@@ -4,9 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("./utils");
-
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -33,14 +31,12 @@ var _default = (0, _utils.createRule)({
   defaultOptions: [{
     allow: []
   }],
-
   create(context, [{
     allow = []
   }]) {
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'hook' && !allow.includes(jestFnCall.name)) {
           context.report({
             node,
@@ -51,10 +47,7 @@ var _default = (0, _utils.createRule)({
           });
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/no-identical-title.js

@@ -4,14 +4,11 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("./utils");
-
 const newDescribeContext = () => ({
   describeTitles: [],
   testTitles: []
 });
-
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -28,34 +25,26 @@ var _default = (0, _utils.createRule)({
     type: 'suggestion'
   },
   defaultOptions: [],
-
   create(context) {
     const contexts = [newDescribeContext()];
     return {
       CallExpression(node) {
         const currentLayer = contexts[contexts.length - 1];
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-
         if (!jestFnCall) {
           return;
         }
-
         if (jestFnCall.type === 'describe') {
           contexts.push(newDescribeContext());
         }
-
         if (jestFnCall.members.find(s => (0, _utils.isSupportedAccessor)(s, 'each'))) {
           return;
         }
-
         const [argument] = node.arguments;
-
         if (!argument || !(0, _utils.isStringNode)(argument)) {
           return;
         }
-
         const title = (0, _utils.getStringValue)(argument);
-
         if (jestFnCall.type === 'test') {
           if (currentLayer.testTitles.includes(title)) {
             context.report({
@@ -63,33 +52,25 @@ var _default = (0, _utils.createRule)({
               node: argument
             });
           }
-
           currentLayer.testTitles.push(title);
         }
-
         if (jestFnCall.type !== 'describe') {
           return;
         }
-
         if (currentLayer.describeTitles.includes(title)) {
           context.report({
             messageId: 'multipleDescribeTitle',
             node: argument
           });
         }
-
         currentLayer.describeTitles.push(title);
       },
-
       'CallExpression:exit'(node) {
         if ((0, _utils.isTypeOfJestFnCall)(node, context, ['describe'])) {
           contexts.pop();
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;