eslint-plugin-jest 26.8.7 → 27.1.5

package/lib/rules/prefer-expect-resolves.js

@@ -4,11 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
@@ -28,35 +25,26 @@ var _default = (0, _utils2.createRule)({
   create: context => ({
     CallExpression(node) {
       const jestFnCall = (0, _utils2.parseJestFnCall)(node, context);
-
       if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect') {
         return;
       }
-
       const {
         parent
       } = jestFnCall.head.node;
-
       if ((parent === null || parent === void 0 ? void 0 : parent.type) !== _utils.AST_NODE_TYPES.CallExpression) {
         return;
       }
-
       const [awaitNode] = parent.arguments;
-
       if ((awaitNode === null || awaitNode === void 0 ? void 0 : awaitNode.type) === _utils.AST_NODE_TYPES.AwaitExpression) {
         context.report({
           node: awaitNode,
           messageId: 'expectResolves',
-
           fix(fixer) {
             return [fixer.insertTextBefore(parent, 'await '), fixer.removeRange([awaitNode.range[0], awaitNode.argument.range[0]]), fixer.insertTextAfter(parent, '.resolves')];
           }
-
         });
       }
     }
-
   })
 });
-
 exports.default = _default;

package/lib/rules/prefer-hooks-in-order.js

@@ -4,11 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("./utils");
-
 const HooksOrder = ['beforeAll', 'beforeEach', 'afterEach', 'afterAll'];
-
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -24,7 +21,6 @@ var _default = (0, _utils.createRule)({
     type: 'suggestion'
   },
   defaultOptions: [],
-
   create(context) {
     let previousHookIndex = -1;
     let inHook = false;
@@ -34,19 +30,15 @@ var _default = (0, _utils.createRule)({
           // Ignore everything that is passed into a hook
           return;
         }
-
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'hook') {
           // Reset the previousHookIndex when encountering something different from a hook
           previousHookIndex = -1;
           return;
         }
-
         inHook = true;
         const currentHook = jestFnCall.name;
         const currentHookIndex = HooksOrder.indexOf(currentHook);
-
         if (currentHookIndex < previousHookIndex) {
           context.report({
             messageId: 'reorderHooks',
@@ -58,27 +50,21 @@ var _default = (0, _utils.createRule)({
           });
           return;
         }
-
         previousHookIndex = currentHookIndex;
       },
-
       'CallExpression:exit'(node) {
         if ((0, _utils.isTypeOfJestFnCall)(node, context, ['hook'])) {
           inHook = false;
           return;
         }
-
         if (inHook) {
           return;
-        } // Reset the previousHookIndex when encountering something different from a hook
-
+        }
 
+        // Reset the previousHookIndex when encountering something different from a hook
         previousHookIndex = -1;
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/prefer-hooks-on-top.js

@@ -4,9 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("./utils");
-
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -22,7 +20,6 @@ var _default = (0, _utils.createRule)({
     type: 'suggestion'
   },
   defaultOptions: [],
-
   create(context) {
     const hooksContext = [false];
     return {
@@ -30,24 +27,18 @@ var _default = (0, _utils.createRule)({
         if ((0, _utils.isTypeOfJestFnCall)(node, context, ['test'])) {
           hooksContext[hooksContext.length - 1] = true;
         }
-
         if (hooksContext[hooksContext.length - 1] && (0, _utils.isTypeOfJestFnCall)(node, context, ['hook'])) {
           context.report({
             messageId: 'noHookOnTop',
             node
           });
         }
-
         hooksContext.push(false);
       },
-
       'CallExpression:exit'() {
         hooksContext.pop();
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/prefer-lowercase-title.js

@@ -4,29 +4,21 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("./utils");
-
 const hasStringAsFirstArgument = node => node.arguments[0] && (0, _utils.isStringNode)(node.arguments[0]);
-
 const populateIgnores = ignore => {
   const ignores = [];
-
   if (ignore.includes(_utils.DescribeAlias.describe)) {
     ignores.push(...Object.keys(_utils.DescribeAlias));
   }
-
   if (ignore.includes(_utils.TestCaseName.test)) {
     ignores.push(...Object.keys(_utils.TestCaseName).filter(k => k.endsWith(_utils.TestCaseName.test)));
   }
-
   if (ignore.includes(_utils.TestCaseName.it)) {
     ignores.push(...Object.keys(_utils.TestCaseName).filter(k => k.endsWith(_utils.TestCaseName.it)));
   }
-
   return ignores;
 };
-
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -70,7 +62,6 @@ var _default = (0, _utils.createRule)({
     allowedPrefixes: [],
     ignoreTopLevelDescribe: false
   }],
-
   create(context, [{
     ignore = [],
     allowedPrefixes = [],
@@ -81,60 +72,46 @@ var _default = (0, _utils.createRule)({
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-
         if (!jestFnCall || !hasStringAsFirstArgument(node)) {
           return;
         }
-
         if (jestFnCall.type === 'describe') {
           numberOfDescribeBlocks++;
-
           if (ignoreTopLevelDescribe && numberOfDescribeBlocks === 1) {
             return;
           }
         } else if (jestFnCall.type !== 'test') {
           return;
         }
-
         const [firstArg] = node.arguments;
         const description = (0, _utils.getStringValue)(firstArg);
-
         if (allowedPrefixes.some(name => description.startsWith(name))) {
           return;
         }
-
         const firstCharacter = description.charAt(0);
-
         if (!firstCharacter || firstCharacter === firstCharacter.toLowerCase() || ignores.includes(jestFnCall.name)) {
           return;
         }
-
         context.report({
           messageId: 'unexpectedLowercase',
           node: node.arguments[0],
           data: {
             method: jestFnCall.name
           },
-
           fix(fixer) {
             const description = (0, _utils.getStringValue)(firstArg);
             const rangeIgnoringQuotes = [firstArg.range[0] + 1, firstArg.range[1] - 1];
             const newDescription = description.substring(0, 1).toLowerCase() + description.substring(1);
             return [fixer.replaceTextRange(rangeIgnoringQuotes, newDescription)];
           }
-
         });
       },
-
       'CallExpression:exit'(node) {
         if ((0, _utils.isTypeOfJestFnCall)(node, context, ['describe'])) {
           numberOfDescribeBlocks--;
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/prefer-mock-promise-shorthand.js

@@ -4,29 +4,21 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 const withOnce = (name, addOnce) => {
   return `${name}${addOnce ? 'Once' : ''}`;
 };
-
 const findSingleReturnArgumentNode = fnNode => {
   var _fnNode$body$body$;
-
   if (fnNode.body.type !== _utils.AST_NODE_TYPES.BlockStatement) {
     return fnNode.body;
   }
-
   if (((_fnNode$body$body$ = fnNode.body.body[0]) === null || _fnNode$body$body$ === void 0 ? void 0 : _fnNode$body$body$.type) === _utils.AST_NODE_TYPES.ReturnStatement) {
     return fnNode.body.body[0].argument;
   }
-
   return null;
 };
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
@@ -43,19 +35,15 @@ var _default = (0, _utils2.createRule)({
     fixable: 'code'
   },
   defaultOptions: [],
-
   create(context) {
     const report = (property, isOnce, outerArgNode, innerArgNode = outerArgNode) => {
       if ((innerArgNode === null || innerArgNode === void 0 ? void 0 : innerArgNode.type) !== _utils.AST_NODE_TYPES.CallExpression) {
         return;
       }
-
       const argName = (0, _utils2.getNodeName)(innerArgNode);
-
       if (argName !== 'Promise.resolve' && argName !== 'Promise.reject') {
         return;
       }
-
       const replacement = withOnce(argName.endsWith('reject') ? 'mockRejectedValue' : 'mockResolvedValue', isOnce);
       context.report({
         node: property,
@@ -63,49 +51,40 @@ var _default = (0, _utils2.createRule)({
         data: {
           replacement
         },
-
         fix(fixer) {
-          const sourceCode = context.getSourceCode(); // there shouldn't be more than one argument, but if there is don't try
-          // fixing since we have no idea what to do with the extra arguments
+          const sourceCode = context.getSourceCode();
 
+          // there shouldn't be more than one argument, but if there is don't try
+          // fixing since we have no idea what to do with the extra arguments
           if (innerArgNode.arguments.length > 1) {
             return null;
           }
-
-          return [fixer.replaceText(property, replacement), fixer.replaceText(outerArgNode, // the value argument for both Promise methods is optional,
+          return [fixer.replaceText(property, replacement), fixer.replaceText(outerArgNode,
+          // the value argument for both Promise methods is optional,
           // whereas for Jest they're required so use an explicit undefined
           // if no argument is being passed to the call we're replacing
           innerArgNode.arguments.length === 1 ? sourceCode.getText(innerArgNode.arguments[0]) : 'undefined')];
         }
-
       });
     };
-
     return {
       CallExpression(node) {
         if (node.callee.type !== _utils.AST_NODE_TYPES.MemberExpression || !(0, _utils2.isSupportedAccessor)(node.callee.property) || node.arguments.length === 0) {
           return;
         }
-
         const mockFnName = (0, _utils2.getAccessorValue)(node.callee.property);
         const isOnce = mockFnName.endsWith('Once');
-
         if (mockFnName === withOnce('mockReturnValue', isOnce)) {
           report(node.callee.property, isOnce, node.arguments[0]);
         } else if (mockFnName === withOnce('mockImplementation', isOnce)) {
           const [arg] = node.arguments;
-
           if (!(0, _utils2.isFunction)(arg) || arg.params.length !== 0) {
             return;
           }
-
           report(node.callee.property, isOnce, arg, findSingleReturnArgumentNode(arg));
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/prefer-snapshot-hint.js

@@ -4,39 +4,34 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("./utils");
-
 const snapshotMatchers = ['toMatchSnapshot', 'toThrowErrorMatchingSnapshot'];
 const snapshotMatcherNames = snapshotMatchers;
-
 const isSnapshotMatcherWithoutHint = expectFnCall => {
   if (expectFnCall.args.length === 0) {
     return true;
-  } // this matcher only supports one argument which is the hint
-
+  }
 
+  // this matcher only supports one argument which is the hint
   if (!(0, _utils.isSupportedAccessor)(expectFnCall.matcher, 'toMatchSnapshot')) {
     return expectFnCall.args.length !== 1;
-  } // if we're being passed two arguments,
-  // the second one should be the hint
-
+  }
 
+  // if we're being passed two arguments,
+  // the second one should be the hint
   if (expectFnCall.args.length === 2) {
     return false;
   }
+  const [arg] = expectFnCall.args;
 
-  const [arg] = expectFnCall.args; // the first argument to `toMatchSnapshot` can be _either_ a snapshot hint or
+  // the first argument to `toMatchSnapshot` can be _either_ a snapshot hint or
   // an object with asymmetric matchers, so we can't just assume that the first
   // argument is a hint when it's by itself.
-
   return !(0, _utils.isStringNode)(arg);
 };
-
 const messages = {
   missingHint: 'You should provide a hint for this snapshot'
 };
-
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -53,12 +48,10 @@ var _default = (0, _utils.createRule)({
     }]
   },
   defaultOptions: ['multi'],
-
   create(context, [mode]) {
     const snapshotMatchers = [];
     const depths = [];
     let expressionDepth = 0;
-
     const reportSnapshotMatchersWithoutHints = () => {
       for (const snapshotMatcher of snapshotMatchers) {
         if (isSnapshotMatcherWithoutHint(snapshotMatcher)) {
@@ -69,72 +62,53 @@ var _default = (0, _utils.createRule)({
         }
       }
     };
-
     const enterExpression = () => {
       expressionDepth++;
     };
-
     const exitExpression = () => {
       expressionDepth--;
-
       if (mode === 'always') {
         reportSnapshotMatchersWithoutHints();
         snapshotMatchers.length = 0;
       }
-
       if (mode === 'multi' && expressionDepth === 0) {
         if (snapshotMatchers.length > 1) {
           reportSnapshotMatchersWithoutHints();
         }
-
         snapshotMatchers.length = 0;
       }
     };
-
     return {
       'Program:exit'() {
         enterExpression();
         exitExpression();
       },
-
       FunctionExpression: enterExpression,
       'FunctionExpression:exit': exitExpression,
       ArrowFunctionExpression: enterExpression,
       'ArrowFunctionExpression:exit': exitExpression,
-
       'CallExpression:exit'(node) {
         if ((0, _utils.isTypeOfJestFnCall)(node, context, ['describe', 'test'])) {
-          var _depths$pop;
-
           /* istanbul ignore next */
-          expressionDepth = (_depths$pop = depths.pop()) !== null && _depths$pop !== void 0 ? _depths$pop : 0;
+          expressionDepth = depths.pop() ?? 0;
         }
       },
-
       CallExpression(node) {
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect') {
           if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'describe' || (jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) === 'test') {
             depths.push(expressionDepth);
             expressionDepth = 0;
           }
-
           return;
         }
-
         const matcherName = (0, _utils.getAccessorValue)(jestFnCall.matcher);
-
         if (!snapshotMatcherNames.includes(matcherName)) {
           return;
         }
-
         snapshotMatchers.push(jestFnCall);
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/prefer-spy-on.js

@@ -4,41 +4,30 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("@typescript-eslint/utils");
-
 var _utils2 = require("./utils");
-
 const findNodeObject = node => {
   if ('object' in node) {
     return node.object;
   }
-
   if (node.callee.type === _utils.AST_NODE_TYPES.MemberExpression) {
     return node.callee.object;
   }
-
   return null;
 };
-
 const getJestFnCall = node => {
   if (node.type !== _utils.AST_NODE_TYPES.CallExpression && node.type !== _utils.AST_NODE_TYPES.MemberExpression) {
     return null;
   }
-
   const obj = findNodeObject(node);
-
   if (!obj) {
     return null;
   }
-
   if (obj.type === _utils.AST_NODE_TYPES.Identifier) {
     return node.type === _utils.AST_NODE_TYPES.CallExpression && (0, _utils2.getNodeName)(node.callee) === 'jest.fn' ? node : null;
   }
-
   return getJestFnCall(obj);
 };
-
 var _default = (0, _utils2.createRule)({
   name: __filename,
   meta: {
@@ -55,7 +44,6 @@ var _default = (0, _utils2.createRule)({
     type: 'suggestion'
   },
   defaultOptions: [],
-
   create(context) {
     return {
       AssignmentExpression(node) {
@@ -69,7 +57,6 @@ var _default = (0, _utils2.createRule)({
         context.report({
           node,
           messageId: 'useJestSpyOn',
-
           fix(fixer) {
             const leftPropQuote = left.property.type === _utils.AST_NODE_TYPES.Identifier ? "'" : '';
             const [arg] = jestFnCall.arguments;
@@ -77,13 +64,9 @@ var _default = (0, _utils2.createRule)({
             const mockImplementation = argSource ? `.mockImplementation(${argSource})` : '.mockImplementation()';
             return [fixer.insertTextBefore(left, `jest.spyOn(`), fixer.replaceTextRange([left.object.range[1], left.property.range[0]], `, ${leftPropQuote}`), fixer.replaceTextRange([left.property.range[1], jestFnCall.range[1]], `${leftPropQuote})${mockImplementation}`)];
           }
-
         });
       }
-
     };
   }
-
 });
-
 exports.default = _default;

package/lib/rules/prefer-strict-equal.js

@@ -4,17 +4,14 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 var _utils = require("./utils");
-
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     docs: {
       category: 'Best Practices',
       description: 'Suggest using `toStrictEqual()`',
-      recommended: false,
-      suggestion: true
+      recommended: false
     },
     messages: {
       useToStrictEqual: 'Use `toStrictEqual()` instead',
@@ -25,20 +22,16 @@ var _default = (0, _utils.createRule)({
     hasSuggestions: true
   },
   defaultOptions: [],
-
   create(context) {
     return {
       CallExpression(node) {
         const jestFnCall = (0, _utils.parseJestFnCall)(node, context);
-
         if ((jestFnCall === null || jestFnCall === void 0 ? void 0 : jestFnCall.type) !== 'expect') {
           return;
         }
-
         const {
           matcher
         } = jestFnCall;
-
         if ((0, _utils.isSupportedAccessor)(matcher, 'toEqual')) {
           context.report({
             messageId: 'useToStrictEqual',
@@ -50,10 +43,7 @@ var _default = (0, _utils.createRule)({
           });
         }
       }
-
     };
   }
-
 });
-
 exports.default = _default;