eslint-plugin-jest 26.1.3 → 26.2.0

package/README.md

@@ -59,6 +59,34 @@ doing:
 This is included in all configs shared by this plugin, so can be omitted if
 extending them.
 
+### Running rules only on test-related files
+
+The rules provided by this plugin assume that the files they are checking are
+test-related. This means it's generally not suitable to include them in your
+top-level configuration as that applies to all files being linted which can
+include source files.
+
+You can use
+[overrides](https://eslint.org/docs/user-guide/configuring/configuration-files#how-do-overrides-work)
+to have ESLint apply additional rules to specific files:
+
+```json
+{
+  "extends": ["eslint:recommended"],
+  "overrides": [
+    {
+      "files": ["test/**"],
+      "plugins": ["jest"],
+      "extends": ["plugin:jest/recommended"],
+      "rules": { "jest/prefer-expect-assertions": "off" }
+    }
+  ],
+  "rules": {
+    "indent": ["error", 2]
+  }
+}
+```
+
 ### Jest `version` setting
 
 The behaviour of some rules (specifically [`no-deprecated-functions`][]) change
@@ -211,8 +239,8 @@ adjust your eslint config as outlined
 
 Note that unlike the type-checking rules in `@typescript-eslint/eslint-plugin`,
 the rules here will fallback to doing nothing if type information is not
-available, meaning its safe to include them in shared configs that could be used
-on JavaScript and TypeScript projects.
+available, meaning it's safe to include them in shared configs that could be
+used on JavaScript and TypeScript projects.
 
 Also note that `unbound-method` depends on `@typescript-eslint/eslint-plugin`,
 as it extends the original `unbound-method` rule from that plugin.

package/docs/rules/no-conditional-expect.md

@@ -107,7 +107,7 @@ While you can use `expect.assertions` & `expect.hasAssertions` for these
 situations, they only work with `expect`.
 
 A better way to handle this situation is to introduce a wrapper to handle the
-catching, and otherwise returns a specific "no error thrown" error if nothing is
+catching, and otherwise return a specific "no error thrown" error if nothing is
 thrown by the wrapped function:
 
 ```typescript

package/docs/rules/no-deprecated-functions.md

@@ -37,8 +37,7 @@ Originally, the `requireActual` & `requireMock` the `requireActual`&
 
 These functions were later moved onto the `jest` object in order to be easier
 for type checkers to handle, and their use via `require` deprecated. Finally,
-the release of Jest 26 saw them removed from the `require` function all
-together.
+the release of Jest 26 saw them removed from the `require` function altogether.
 
 ### `jest.runTimersToTime`
 

package/docs/rules/no-identical-title.md

@@ -7,7 +7,7 @@ fix.
 
 ## Rule Details
 
-This rule looks at the title of every test and test suites. It will report when
+This rule looks at the title of every test and test suite. It will report when
 two test suites or two test cases at the same level of a test suite have the
 same title.
 

package/docs/rules/no-jasmine-globals.md

@@ -9,8 +9,8 @@ API.
 
 ### Rule details
 
-This rule reports on any usage of Jasmine globals which is not ported to Jest,
-and suggests alternative from Jest's own API.
+This rule reports on any usage of Jasmine globals, which is not ported to Jest,
+and suggests alternatives from Jest's own API.
 
 ### Default configuration
 

package/docs/rules/no-jest-import.md

@@ -17,4 +17,4 @@ first place.
 
 ## Further Reading
 
-\*[The Jest Object](https://facebook.github.io/jest/docs/en/jest-object.html)
+- [The Jest Object](https://facebook.github.io/jest/docs/en/jest-object.html)

package/docs/rules/no-large-snapshots.md

@@ -118,8 +118,8 @@ External). Use `inlineMaxSize` for
 [Inline Snapshots](https://jestjs.io/docs/en/snapshot-testing#inline-snapshots)
 size and `maxSize` for
 [External Snapshots](https://jestjs.io/docs/en/snapshot-testing#snapshot-testing-with-jest).
-If only `maxSize` is provided on options, the value of `maxSize` will be used to
-both snapshot types (Inline and External).
+If only `maxSize` is provided on options, the value of `maxSize` will be used
+for both snapshot types (Inline and External).
 
 Since `eslint-disable` comments are not preserved by Jest when updating
 snapshots, you can use the `allowedSnapshots` option to have specific snapshots

package/docs/rules/no-standalone-expect.md

@@ -61,7 +61,7 @@ describe('a test', () => {
 ```
 
 \*Note that this rule will not trigger if the helper function is never used even
-thought the `expect` will not execute. Rely on a rule like no-unused-vars for
+though the `expect` will not execute. Rely on a rule like no-unused-vars for
 this case.
 
 ### Options

package/docs/rules/prefer-comparison-matcher.md

@@ -1,6 +1,6 @@
 # Suggest using the built-in comparison matchers (`prefer-comparison-matcher`)
 
-Jest has a number of built-in matchers for comparing numbers which allow for
+Jest has a number of built-in matchers for comparing numbers, which allow for
 more readable tests and error messages if an expectation fails.
 
 ## Rule details

package/docs/rules/prefer-equality-matcher.md

@@ -1,6 +1,6 @@
 # Suggest using the built-in equality matchers (`prefer-equality-matcher`)
 
-Jest has built-in matchers for expecting equality which allow for more readable
+Jest has built-in matchers for expecting equality, which allow for more readable
 tests and error messages if an expectation fails.
 
 ## Rule details

package/docs/rules/prefer-expect-assertions.md

@@ -215,7 +215,7 @@ describe('getNumbers', () => {
 
 describe('/users', () => {
   it.each([1, 2, 3])('returns ok', id => {
-    expect.assertions(3);
+    expect.assertions(1);
 
     client.get(`/users/${id}`, response => {
       expect(response.status).toBe(200);

package/docs/rules/prefer-hooks-on-top.md

@@ -1,7 +1,7 @@
 # Suggest having hooks before any test cases (`prefer-hooks-on-top`)
 
 While hooks can be setup anywhere in a test file, they are always called in a
-specific order which means it can be confusing if they're intermixed with test
+specific order, which means it can be confusing if they're intermixed with test
 cases.
 
 This rule helps to ensure that hooks are always defined before test cases.

package/docs/rules/prefer-lowercase-title.md

@@ -73,8 +73,8 @@ it('Uppercase description');
 
 ### `allowedPrefixes`
 
-This array option allows specifying prefixes which contain capitals that titles
-can start with. This can be useful when writing tests for api endpoints, where
+This array option allows specifying prefixes, which contain capitals that titles
+can start with. This can be useful when writing tests for API endpoints, where
 you'd like to prefix with the HTTP method.
 
 By default, nothing is allowed (the equivalent of `{ "allowedPrefixes": [] }`).

package/docs/rules/valid-expect.md

@@ -136,9 +136,9 @@ test('all the things', async () => {
   await Promise.resolve(
     expect(Promise.resolve('hello')).resolves.toEqual('hello'),
   );
-  await Promise.all(
+  await Promise.all([
     expect(Promise.resolve('hello')).resolves.toEqual('hello'),
     expect(Promise.resolve('hi')).resolves.toEqual('hi'),
-  );
+  ]);
 });
 ```

package/lib/rules/consistent-test-it.js

@@ -44,6 +44,7 @@ var _default = (0, _utils2.createRule)({
   }],
 
   create(context) {
+    const scope = context.getScope();
     const configObj = context.options[0] || {};
     const testKeyword = configObj.fn || _utils2.TestCaseName.test;
     const testKeywordWithinDescribe = configObj.withinDescribe || configObj.fn || _utils2.TestCaseName.it;
@@ -56,13 +57,13 @@ var _default = (0, _utils2.createRule)({
           return;
         }
 
-        if ((0, _utils2.isDescribeCall)(node)) {
+        if ((0, _utils2.isDescribeCall)(node, scope)) {
           describeNestingLevel++;
         }
 
         const funcNode = node.callee.type === _utils.AST_NODE_TYPES.TaggedTemplateExpression ? node.callee.tag : node.callee.type === _utils.AST_NODE_TYPES.CallExpression ? node.callee.callee : node.callee;
 
-        if ((0, _utils2.isTestCaseCall)(node) && describeNestingLevel === 0 && !nodeName.includes(testKeyword)) {
+        if ((0, _utils2.isTestCaseCall)(node, scope) && describeNestingLevel === 0 && !nodeName.includes(testKeyword)) {
           const oppositeTestKeyword = getOppositeTestKeyword(testKeyword);
           context.report({
             messageId: 'consistentMethod',
@@ -75,7 +76,7 @@ var _default = (0, _utils2.createRule)({
           });
         }
 
-        if ((0, _utils2.isTestCaseCall)(node) && describeNestingLevel > 0 && !nodeName.includes(testKeywordWithinDescribe)) {
+        if ((0, _utils2.isTestCaseCall)(node, scope) && describeNestingLevel > 0 && !nodeName.includes(testKeywordWithinDescribe)) {
           const oppositeTestKeyword = getOppositeTestKeyword(testKeywordWithinDescribe);
           context.report({
             messageId: 'consistentMethodWithinDescribe',
@@ -90,7 +91,7 @@ var _default = (0, _utils2.createRule)({
       },
 
       'CallExpression:exit'(node) {
-        if ((0, _utils2.isDescribeCall)(node)) {
+        if ((0, _utils2.isDescribeCall)(node, scope)) {
           describeNestingLevel--;
         }
       }

package/lib/rules/expect-expect.js

@@ -68,6 +68,7 @@ var _default = (0, _utils2.createRule)({
     assertFunctionNames = ['expect'],
     additionalTestBlockFunctions = []
   }]) {
+    const scope = context.getScope();
     const unchecked = [];
 
     function checkCallExpressionUsed(nodes) {
@@ -76,7 +77,7 @@ var _default = (0, _utils2.createRule)({
 
         if (node.type === _utils.AST_NODE_TYPES.FunctionDeclaration) {
           const declaredVariables = context.getDeclaredVariables(node);
-          const testCallExpressions = (0, _utils2.getTestCallExpressionsFromDeclaredVariables)(declaredVariables);
+          const testCallExpressions = (0, _utils2.getTestCallExpressionsFromDeclaredVariables)(declaredVariables, scope);
           checkCallExpressionUsed(testCallExpressions);
         }
 
@@ -93,7 +94,7 @@ var _default = (0, _utils2.createRule)({
 
         const name = (_getNodeName = (0, _utils2.getNodeName)(node.callee)) !== null && _getNodeName !== void 0 ? _getNodeName : '';
 
-        if ((0, _utils2.isTestCaseCall)(node) || additionalTestBlockFunctions.includes(name)) {
+        if ((0, _utils2.isTestCaseCall)(node, scope) || additionalTestBlockFunctions.includes(name)) {
           if (node.callee.type === _utils.AST_NODE_TYPES.MemberExpression && (0, _utils2.isSupportedAccessor)(node.callee.property, 'todo')) {
             return;
           }

package/lib/rules/max-nested-describe.js

@@ -39,6 +39,7 @@ var _default = (0, _utils2.createRule)({
   create(context, [{
     max
   }]) {
+    const scope = context.getScope();
     const describeCallbackStack = [];
 
     function pushDescribeCallback(node) {
@@ -46,7 +47,7 @@ var _default = (0, _utils2.createRule)({
         parent
       } = node;
 
-      if ((parent === null || parent === void 0 ? void 0 : parent.type) !== _utils.AST_NODE_TYPES.CallExpression || !(0, _utils2.isDescribeCall)(parent)) {
+      if ((parent === null || parent === void 0 ? void 0 : parent.type) !== _utils.AST_NODE_TYPES.CallExpression || !(0, _utils2.isDescribeCall)(parent, scope)) {
         return;
       }
 
@@ -69,7 +70,7 @@ var _default = (0, _utils2.createRule)({
         parent
       } = node;
 
-      if ((parent === null || parent === void 0 ? void 0 : parent.type) === _utils.AST_NODE_TYPES.CallExpression && (0, _utils2.isDescribeCall)(parent)) {
+      if ((parent === null || parent === void 0 ? void 0 : parent.type) === _utils.AST_NODE_TYPES.CallExpression && (0, _utils2.isDescribeCall)(parent, scope)) {
         describeCallbackStack.pop();
       }
     }

package/lib/rules/no-conditional-expect.js

@@ -28,6 +28,7 @@ var _default = (0, _utils2.createRule)({
   defaultOptions: [],
 
   create(context) {
+    const scope = context.getScope();
     let conditionalDepth = 0;
     let inTestCase = false;
     let inPromiseCatch = false;
@@ -39,7 +40,7 @@ var _default = (0, _utils2.createRule)({
     return {
       FunctionDeclaration(node) {
         const declaredVariables = context.getDeclaredVariables(node);
-        const testCallExpressions = (0, _utils2.getTestCallExpressionsFromDeclaredVariables)(declaredVariables);
+        const testCallExpressions = (0, _utils2.getTestCallExpressionsFromDeclaredVariables)(declaredVariables, scope);
 
         if (testCallExpressions.length > 0) {
           inTestCase = true;
@@ -47,7 +48,7 @@ var _default = (0, _utils2.createRule)({
       },
 
       CallExpression(node) {
-        if ((0, _utils2.isTestCaseCall)(node)) {
+        if ((0, _utils2.isTestCaseCall)(node, scope)) {
           inTestCase = true;
         }
 
@@ -71,7 +72,7 @@ var _default = (0, _utils2.createRule)({
       },
 
       'CallExpression:exit'(node) {
-        if ((0, _utils2.isTestCaseCall)(node)) {
+        if ((0, _utils2.isTestCaseCall)(node, scope)) {
           inTestCase = false;
         }
 

package/lib/rules/no-conditional-in-test.js

@@ -24,6 +24,7 @@ var _default = (0, _utils.createRule)({
   defaultOptions: [],
 
   create(context) {
+    const scope = context.getScope();
     let inTestCase = false;
 
     const maybeReportConditional = node => {
@@ -37,13 +38,13 @@ var _default = (0, _utils.createRule)({
 
     return {
       CallExpression(node) {
-        if ((0, _utils.isTestCaseCall)(node)) {
+        if ((0, _utils.isTestCaseCall)(node, scope)) {
           inTestCase = true;
         }
       },
 
       'CallExpression:exit'(node) {
-        if ((0, _utils.isTestCaseCall)(node)) {
+        if ((0, _utils.isTestCaseCall)(node, scope)) {
           inTestCase = false;
         }
       },

package/lib/rules/no-done-callback.js

@@ -9,16 +9,16 @@ var _utils = require("@typescript-eslint/utils");
 
 var _utils2 = require("./utils");
 
-const findCallbackArg = (node, isJestEach) => {
+const findCallbackArg = (node, isJestEach, scope) => {
   if (isJestEach) {
     return node.arguments[1];
   }
 
-  if ((0, _utils2.isHook)(node) && node.arguments.length >= 1) {
+  if ((0, _utils2.isHookCall)(node, scope) && node.arguments.length >= 1) {
     return node.arguments[0];
   }
 
-  if ((0, _utils2.isTestCaseCall)(node) && node.arguments.length >= 2) {
+  if ((0, _utils2.isTestCaseCall)(node, scope) && node.arguments.length >= 2) {
     return node.arguments[1];
   }
 
@@ -46,6 +46,7 @@ var _default = (0, _utils2.createRule)({
   defaultOptions: [],
 
   create(context) {
+    const scope = context.getScope();
     return {
       CallExpression(node) {
         var _getNodeName$endsWith, _getNodeName;
@@ -60,7 +61,7 @@ var _default = (0, _utils2.createRule)({
           return;
         }
 
-        const callback = findCallbackArg(node, isJestEach);
+        const callback = findCallbackArg(node, isJestEach, scope);
         const callbackArgIndex = Number(isJestEach);
 
         if (!callback || !(0, _utils2.isFunction)(callback) || callback.params.length !== 1 + callbackArgIndex) {

package/lib/rules/no-duplicate-hooks.js

@@ -31,14 +31,15 @@ var _default = (0, _utils.createRule)({
   defaultOptions: [],
 
   create(context) {
+    const scope = context.getScope();
     const hookContexts = [newHookContext()];
     return {
       CallExpression(node) {
-        if ((0, _utils.isDescribeCall)(node)) {
+        if ((0, _utils.isDescribeCall)(node, scope)) {
           hookContexts.push(newHookContext());
         }
 
-        if ((0, _utils.isHook)(node)) {
+        if ((0, _utils.isHookCall)(node, scope)) {
           const currentLayer = hookContexts[hookContexts.length - 1];
           currentLayer[node.callee.name] += 1;
 
@@ -55,7 +56,7 @@ var _default = (0, _utils.createRule)({
       },
 
       'CallExpression:exit'(node) {
-        if ((0, _utils.isDescribeCall)(node)) {
+        if ((0, _utils.isDescribeCall)(node, scope)) {
           hookContexts.pop();
         }
       }

package/lib/rules/no-export.js

@@ -26,6 +26,7 @@ var _default = (0, _utils2.createRule)({
   defaultOptions: [],
 
   create(context) {
+    const scope = context.getScope();
     const exportNodes = [];
     let hasTestCase = false;
     return {
@@ -41,7 +42,7 @@ var _default = (0, _utils2.createRule)({
       },
 
       CallExpression(node) {
-        if ((0, _utils2.isTestCaseCall)(node)) {
+        if ((0, _utils2.isTestCaseCall)(node, scope)) {
           hasTestCase = true;
         }
       },

package/lib/rules/no-focused-tests.js

@@ -45,41 +45,46 @@ var _default = (0, _utils2.createRule)({
     hasSuggestions: true
   },
   defaultOptions: [],
-  create: context => ({
-    CallExpression(node) {
-      if (!(0, _utils2.isDescribeCall)(node) && !(0, _utils2.isTestCaseCall)(node)) {
-        return;
-      }
 
-      if ((0, _utils2.getNodeName)(node).startsWith('f')) {
+  create(context) {
+    const scope = context.getScope();
+    return {
+      CallExpression(node) {
+        if (!(0, _utils2.isDescribeCall)(node, scope) && !(0, _utils2.isTestCaseCall)(node, scope)) {
+          return;
+        }
+
+        if ((0, _utils2.getNodeName)(node).startsWith('f')) {
+          context.report({
+            messageId: 'focusedTest',
+            node,
+            suggest: [{
+              messageId: 'suggestRemoveFocus',
+              fix: fixer => fixer.removeRange([node.range[0], node.range[0] + 1])
+            }]
+          });
+          return;
+        }
+
+        const onlyNode = findOnlyNode(node);
+
+        if (!onlyNode) {
+          return;
+        }
+
         context.report({
           messageId: 'focusedTest',
-          node,
+          node: onlyNode,
           suggest: [{
             messageId: 'suggestRemoveFocus',
-            fix: fixer => fixer.removeRange([node.range[0], node.range[0] + 1])
+            fix: fixer => fixer.removeRange([onlyNode.range[0] - 1, onlyNode.range[1] + Number(onlyNode.type !== _utils.AST_NODE_TYPES.Identifier)])
           }]
         });
-        return;
       }
 
-      const onlyNode = findOnlyNode(node);
-
-      if (!onlyNode) {
-        return;
-      }
-
-      context.report({
-        messageId: 'focusedTest',
-        node: onlyNode,
-        suggest: [{
-          messageId: 'suggestRemoveFocus',
-          fix: fixer => fixer.removeRange([onlyNode.range[0] - 1, onlyNode.range[1] + Number(onlyNode.type !== _utils.AST_NODE_TYPES.Identifier)])
-        }]
-      });
-    }
+    };
+  }
 
-  })
 });
 
 exports.default = _default;

package/lib/rules/no-hooks.js

@@ -37,9 +37,10 @@ var _default = (0, _utils.createRule)({
   create(context, [{
     allow = []
   }]) {
+    const scope = context.getScope();
     return {
       CallExpression(node) {
-        if ((0, _utils.isHook)(node) && !allow.includes(node.callee.name)) {
+        if ((0, _utils.isHookCall)(node, scope) && !allow.includes(node.callee.name)) {
           context.report({
             node,
             messageId: 'unexpectedHook',

package/lib/rules/no-identical-title.js

@@ -30,6 +30,7 @@ var _default = (0, _utils.createRule)({
   defaultOptions: [],
 
   create(context) {
+    const scope = context.getScope();
     const contexts = [newDescribeContext()];
     return {
       CallExpression(node) {
@@ -37,7 +38,7 @@ var _default = (0, _utils.createRule)({
 
         const currentLayer = contexts[contexts.length - 1];
 
-        if ((0, _utils.isDescribeCall)(node)) {
+        if ((0, _utils.isDescribeCall)(node, scope)) {
           contexts.push(newDescribeContext());
         }
 
@@ -53,7 +54,7 @@ var _default = (0, _utils.createRule)({
 
         const title = (0, _utils.getStringValue)(argument);
 
-        if ((0, _utils.isTestCaseCall)(node)) {
+        if ((0, _utils.isTestCaseCall)(node, scope)) {
           if (currentLayer.testTitles.includes(title)) {
             context.report({
               messageId: 'multipleTestTitle',
@@ -64,7 +65,7 @@ var _default = (0, _utils.createRule)({
           currentLayer.testTitles.push(title);
         }
 
-        if (!(0, _utils.isDescribeCall)(node)) {
+        if (!(0, _utils.isDescribeCall)(node, scope)) {
           return;
         }
 
@@ -79,7 +80,7 @@ var _default = (0, _utils.createRule)({
       },
 
       'CallExpression:exit'(node) {
-        if ((0, _utils.isDescribeCall)(node)) {
+        if ((0, _utils.isDescribeCall)(node, scope)) {
           contexts.pop();
         }
       }

package/lib/rules/no-if.js

@@ -38,6 +38,7 @@ var _default = (0, _utils2.createRule)({
   defaultOptions: [],
 
   create(context) {
+    const scope = context.getScope();
     const stack = [];
 
     function validate(node) {
@@ -58,7 +59,7 @@ var _default = (0, _utils2.createRule)({
 
     return {
       CallExpression(node) {
-        if ((0, _utils2.isTestCaseCall)(node)) {
+        if ((0, _utils2.isTestCaseCall)(node, scope)) {
           stack.push(true);
 
           if ((0, _utils2.getNodeName)(node).endsWith('each')) {
@@ -73,7 +74,7 @@ var _default = (0, _utils2.createRule)({
 
       FunctionDeclaration(node) {
         const declaredVariables = context.getDeclaredVariables(node);
-        const testCallExpressions = (0, _utils2.getTestCallExpressionsFromDeclaredVariables)(declaredVariables);
+        const testCallExpressions = (0, _utils2.getTestCallExpressionsFromDeclaredVariables)(declaredVariables, scope);
         stack.push(testCallExpressions.length > 0);
       },
 

package/lib/rules/no-standalone-expect.js

@@ -9,7 +9,7 @@ var _utils = require("@typescript-eslint/utils");
 
 var _utils2 = require("./utils");
 
-const getBlockType = statement => {
+const getBlockType = (statement, scope) => {
   const func = statement.parent;
   /* istanbul ignore if */
 
@@ -30,7 +30,7 @@ const getBlockType = statement => {
     } // if it's not a variable, it will be callExpr, we only care about describe
 
 
-    if (expr.type === _utils.AST_NODE_TYPES.CallExpression && (0, _utils2.isDescribeCall)(expr)) {
+    if (expr.type === _utils.AST_NODE_TYPES.CallExpression && (0, _utils2.isDescribeCall)(expr, scope)) {
       return 'describe';
     }
   }
@@ -69,11 +69,12 @@ var _default = (0, _utils2.createRule)({
   create(context, [{
     additionalTestBlockFunctions = []
   }]) {
+    const scope = context.getScope();
     const callStack = [];
 
     const isCustomTestBlockFunction = node => additionalTestBlockFunctions.includes((0, _utils2.getNodeName)(node) || '');
 
-    const isTestBlock = node => (0, _utils2.isTestCaseCall)(node) || isCustomTestBlockFunction(node);
+    const isTestBlock = node => (0, _utils2.isTestCaseCall)(node, scope) || isCustomTestBlockFunction(node);
 
     return {
       CallExpression(node) {
@@ -108,7 +109,7 @@ var _default = (0, _utils2.createRule)({
       },
 
       BlockStatement(statement) {
-        const blockType = getBlockType(statement);
+        const blockType = getBlockType(statement, scope);
 
         if (blockType) {
           callStack.push(blockType);
@@ -116,7 +117,7 @@ var _default = (0, _utils2.createRule)({
       },
 
       'BlockStatement:exit'(statement) {
-        if (callStack[callStack.length - 1] === getBlockType(statement)) {
+        if (callStack[callStack.length - 1] === getBlockType(statement, scope)) {
           callStack.pop();
         }
       },

package/lib/rules/no-test-prefixes.js

@@ -27,10 +27,11 @@ var _default = (0, _utils2.createRule)({
   defaultOptions: [],
 
   create(context) {
+    const scope = context.getScope();
     return {
       CallExpression(node) {
         const nodeName = (0, _utils2.getNodeName)(node.callee);
-        if (!nodeName || !(0, _utils2.isDescribeCall)(node) && !(0, _utils2.isTestCaseCall)(node)) return;
+        if (!nodeName || !(0, _utils2.isDescribeCall)(node, scope) && !(0, _utils2.isTestCaseCall)(node, scope)) return;
         const preferredNodeName = getPreferredNodeName(nodeName);
         if (!preferredNodeName) return;
         const funcNode = node.callee.type === _utils.AST_NODE_TYPES.TaggedTemplateExpression ? node.callee.tag : node.callee.type === _utils.AST_NODE_TYPES.CallExpression ? node.callee.callee : node.callee;

package/lib/rules/no-test-return-statement.js

@@ -36,9 +36,10 @@ var _default = (0, _utils2.createRule)({
   defaultOptions: [],
 
   create(context) {
+    const scope = context.getScope();
     return {
       CallExpression(node) {
-        if (!(0, _utils2.isTestCaseCall)(node)) return;
+        if (!(0, _utils2.isTestCaseCall)(node, scope)) return;
         const body = getBody(node.arguments);
         const returnStmt = body.find(t => t.type === _utils.AST_NODE_TYPES.ReturnStatement);
         if (!returnStmt) return;
@@ -50,7 +51,7 @@ var _default = (0, _utils2.createRule)({
 
       FunctionDeclaration(node) {
         const declaredVariables = context.getDeclaredVariables(node);
-        const testCallExpressions = (0, _utils2.getTestCallExpressionsFromDeclaredVariables)(declaredVariables);
+        const testCallExpressions = (0, _utils2.getTestCallExpressionsFromDeclaredVariables)(declaredVariables, scope);
         if (testCallExpressions.length === 0) return;
         const returnStmt = node.body.body.find(t => t.type === _utils.AST_NODE_TYPES.ReturnStatement);
         if (!returnStmt) return;