eslint-plugin-jest 24.3.6 → 24.3.7

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [24.3.7](https://github.com/jest-community/eslint-plugin-jest/compare/v24.3.6...v24.3.7) (2021-07-21)
+
+
+### Bug Fixes
+
+* **valid-describe:** report on concise-body arrow functions ([#863](https://github.com/jest-community/eslint-plugin-jest/issues/863)) ([71c5299](https://github.com/jest-community/eslint-plugin-jest/commit/71c5299b14cac6d85ba8f8bd939461503a60468f))
+
 ## [24.3.6](https://github.com/jest-community/eslint-plugin-jest/compare/v24.3.5...v24.3.6) (2021-04-26)
 
 

package/README.md

@@ -13,8 +13,8 @@
 
 ## Installation
 
-```
-$ yarn add --dev eslint eslint-plugin-jest
+```bash
+yarn add --dev eslint eslint-plugin-jest
 ```
 
 **Note:** If you installed ESLint globally then you must also install

package/docs/rules/unbound-method.md

@@ -27,7 +27,7 @@ are not using TypeScript.
   overrides: [
     {
       files: ['test/**'],
-      extends: ['jest'],
+      plugins: ['jest'],
       rules: {
         // you should turn the original rule off *only* for test files
         '@typescript-eslint/unbound-method': 'off',

package/docs/rules/valid-describe.md

@@ -43,6 +43,12 @@ describe('myFunction', () => {
     });
   });
 });
+
+// Returning a value from a describe block is not allowed
+describe('myFunction', () =>
+  it('returns a truthy value', () => {
+    expect(myFunction()).toBeTruthy();
+  }));
 ```
 
 The following patterns are not considered warnings:

package/lib/index.js

@@ -8,9 +8,9 @@ var _globals = _interopRequireDefault(require("./globals.json"));
 
 var snapshotProcessor = _interopRequireWildcard(require("./processors/snapshot-processor"));
 
-function _getRequireWildcardCache() { if (typeof WeakMap !== "function") return null; var cache = new WeakMap(); _getRequireWildcardCache = function () { return cache; }; return cache; }
+function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function (nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
 
-function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } if (obj === null || typeof obj !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
+function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || typeof obj !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 

package/lib/rules/no-deprecated-functions.js

@@ -24,10 +24,10 @@ const detectJestVersion = () => {
   try {
     const jestPath = require.resolve('jest/package.json', {
       paths: [process.cwd()]
-    }); // eslint-disable-next-line @typescript-eslint/no-require-imports
+    });
 
-
-    const jestPackageJson = require(jestPath);
+    const jestPackageJson = // eslint-disable-next-line @typescript-eslint/no-require-imports
+    require(jestPath);
 
     if (jestPackageJson.version) {
       const [majorVersion] = jestPackageJson.version.split('.');

package/lib/rules/valid-describe.js

@@ -84,6 +84,13 @@ var _default = (0, _utils.createRule)({
           });
         }
 
+        if (callback.body.type === _experimentalUtils.AST_NODE_TYPES.CallExpression) {
+          context.report({
+            messageId: 'unexpectedReturnInDescribe',
+            node: callback
+          });
+        }
+
         if (callback.body.type === _experimentalUtils.AST_NODE_TYPES.BlockStatement) {
           callback.body.body.forEach(node => {
             if (node.type === _experimentalUtils.AST_NODE_TYPES.ReturnStatement) {

package/lib/rules/valid-expect-in-promise.js

@@ -123,13 +123,12 @@ var _default = (0, _utils.createRule)({
             return;
           }
 
-          const testFunctionBody = body.body;
-          const [fulfillmentCallback, rejectionCallback] = node.arguments; // then block can have two args, fulfillment & rejection
+          const testFunctionBody = body.body; // then block can have two args, fulfillment & rejection
           // then block can have one args, fulfillment
           // catch block can have one args, rejection
           // ref: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise
 
-          verifyExpectWithReturn([fulfillmentCallback, rejectionCallback], node.callee, context, testFunctionBody);
+          verifyExpectWithReturn(node.arguments.slice(0, 2), node.callee, context, testFunctionBody);
         }
       }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-jest",
-  "version": "24.3.6",
+  "version": "24.3.7",
   "description": "Eslint rules for Jest",
   "keywords": [
     "eslint",
@@ -97,7 +97,7 @@
     "@types/prettier": "^2.0.0",
     "@typescript-eslint/eslint-plugin": "^4.0.1",
     "@typescript-eslint/parser": "^4.0.1",
-    "babel-jest": "^26.0.1",
+    "babel-jest": "^27.0.0",
     "babel-plugin-replace-ts-export-assignment": "^0.0.2",
     "dedent": "^0.7.0",
     "eslint": "^5.1.0 || ^6.0.0 || ^7.0.0",
@@ -110,7 +110,7 @@
     "eslint-plugin-prettier": "^3.0.0",
     "husky": "^6.0.0",
     "is-ci": "^3.0.0",
-    "jest": "^26.0.1",
+    "jest": "^27.0.0",
     "jest-runner-eslint": "^0.10.0",
     "lint-staged": "^10.2.2",
     "pinst": "^2.0.0",