eslint-plugin-jest 24.3.1 → 24.3.5

package/CHANGELOG.md

@@ -1,3 +1,32 @@
+## [24.3.5](https://github.com/jest-community/eslint-plugin-jest/compare/v24.3.4...v24.3.5) (2021-04-10)
+
+
+### Bug Fixes
+
+* **valid-describe:** support using `each` with modifiers ([#820](https://github.com/jest-community/eslint-plugin-jest/issues/820)) ([cbdbcef](https://github.com/jest-community/eslint-plugin-jest/commit/cbdbcef47984eb01509493bd5b2423f518a2663d))
+
+## [24.3.4](https://github.com/jest-community/eslint-plugin-jest/compare/v24.3.3...v24.3.4) (2021-04-05)
+
+
+### Bug Fixes
+
+* support all variations of `describe`, `it`, & `test` ([#792](https://github.com/jest-community/eslint-plugin-jest/issues/792)) ([0968b55](https://github.com/jest-community/eslint-plugin-jest/commit/0968b557dd9cdb5cfcaf8a0d84e8a456825e6b25))
+
+## [24.3.3](https://github.com/jest-community/eslint-plugin-jest/compare/v24.3.2...v24.3.3) (2021-04-02)
+
+
+### Bug Fixes
+
+* **no-duplicate-hooks:** support `describe.each` ([#797](https://github.com/jest-community/eslint-plugin-jest/issues/797)) ([243cb4f](https://github.com/jest-community/eslint-plugin-jest/commit/243cb4f970e40aa195a3bffa0528dbdbfef7c4f5)), closes [#642](https://github.com/jest-community/eslint-plugin-jest/issues/642)
+* **prefer-expect-assertions:** support `.each` ([#798](https://github.com/jest-community/eslint-plugin-jest/issues/798)) ([f758243](https://github.com/jest-community/eslint-plugin-jest/commit/f75824359f2242f53997c59c238d83a59badeea3)), closes [#676](https://github.com/jest-community/eslint-plugin-jest/issues/676)
+
+## [24.3.2](https://github.com/jest-community/eslint-plugin-jest/compare/v24.3.1...v24.3.2) (2021-03-16)
+
+
+### Bug Fixes
+
+* **consistent-test-it:** properly handle `describe.each` ([#796](https://github.com/jest-community/eslint-plugin-jest/issues/796)) ([035bd30](https://github.com/jest-community/eslint-plugin-jest/commit/035bd30af43f1215e65bf1b26c2ef2e6d174d3c8)), closes [#795](https://github.com/jest-community/eslint-plugin-jest/issues/795)
+
 ## [24.3.1](https://github.com/jest-community/eslint-plugin-jest/compare/v24.3.0...v24.3.1) (2021-03-13)
 
 

package/docs/rules/no-focused-tests.md

@@ -12,7 +12,7 @@ whenever you are using the exclusivity feature.
 ## Rule Details
 
 This rule looks for every `describe.only`, `it.only`, `test.only`, `fdescribe`,
-`fit` and `ftest` occurrences within the source code. Of course there are some
+and `fit` occurrences within the source code. Of course there are some
 edge-cases which can’t be detected by this rule e.g.:
 
 ```js
@@ -31,13 +31,9 @@ test.only('foo', () => {});
 test['only']('bar', () => {});
 fdescribe('foo', () => {});
 fit('foo', () => {});
-ftest('bar', () => {});
 fit.each`
   table
 `();
-ftest.each`
-  table
-`();
 ```
 
 These patterns would not be considered warnings:

package/lib/rules/consistent-test-it.js

@@ -56,13 +56,13 @@ var _default = (0, _utils.createRule)({
           return;
         }
 
-        if ((0, _utils.isDescribe)(node)) {
+        if ((0, _utils.isDescribeCall)(node)) {
           describeNestingLevel++;
         }
 
         const funcNode = node.callee.type === _experimentalUtils.AST_NODE_TYPES.TaggedTemplateExpression ? node.callee.tag : node.callee;
 
-        if ((0, _utils.isTestCase)(node) && describeNestingLevel === 0 && !nodeName.includes(testKeyword)) {
+        if ((0, _utils.isTestCaseCall)(node) && describeNestingLevel === 0 && !nodeName.includes(testKeyword)) {
           const oppositeTestKeyword = getOppositeTestKeyword(testKeyword);
           context.report({
             messageId: 'consistentMethod',
@@ -75,7 +75,7 @@ var _default = (0, _utils.createRule)({
           });
         }
 
-        if ((0, _utils.isTestCase)(node) && describeNestingLevel > 0 && !nodeName.includes(testKeywordWithinDescribe)) {
+        if ((0, _utils.isTestCaseCall)(node) && describeNestingLevel > 0 && !nodeName.includes(testKeywordWithinDescribe)) {
           const oppositeTestKeyword = getOppositeTestKeyword(testKeywordWithinDescribe);
           context.report({
             messageId: 'consistentMethodWithinDescribe',
@@ -90,7 +90,7 @@ var _default = (0, _utils.createRule)({
       },
 
       'CallExpression:exit'(node) {
-        if ((0, _utils.isDescribe)(node)) {
+        if ((0, _utils.isDescribeCall)(node) && !(0, _utils.isEachCall)(node)) {
           describeNestingLevel--;
         }
       }

package/lib/rules/lowercase-name.js

@@ -12,14 +12,12 @@ var _utils = require("./utils");
 const hasStringAsFirstArgument = node => node.arguments[0] && (0, _utils.isStringNode)(node.arguments[0]);
 
 const findNodeNameAndArgument = node => {
-  if (!((0, _utils.isTestCase)(node) || (0, _utils.isDescribe)(node))) {
+  if (!((0, _utils.isTestCaseCall)(node) || (0, _utils.isDescribeCall)(node))) {
     return null;
   }
 
   if ((0, _utils.isEachCall)(node)) {
-    var _node$parent;
-
-    if (((_node$parent = node.parent) === null || _node$parent === void 0 ? void 0 : _node$parent.type) === _experimentalUtils.AST_NODE_TYPES.CallExpression && hasStringAsFirstArgument(node.parent)) {
+    if (node.parent.arguments.length > 0 && (0, _utils.isStringNode)(node.parent.arguments[0])) {
       return [node.callee.object.name, node.parent.arguments[0]];
     }
 
@@ -85,7 +83,7 @@ var _default = (0, _utils.createRule)({
     let numberOfDescribeBlocks = 0;
     return {
       CallExpression(node) {
-        if ((0, _utils.isDescribe)(node)) {
+        if ((0, _utils.isDescribeCall)(node)) {
           numberOfDescribeBlocks++;
 
           if (ignoreTopLevelDescribe && numberOfDescribeBlocks === 1) {
@@ -130,7 +128,7 @@ var _default = (0, _utils.createRule)({
       },
 
       'CallExpression:exit'(node) {
-        if ((0, _utils.isDescribe)(node)) {
+        if ((0, _utils.isDescribeCall)(node)) {
           numberOfDescribeBlocks--;
         }
       }

package/lib/rules/no-conditional-expect.js

@@ -42,7 +42,7 @@ var _default = (0, _utils.createRule)({
       },
 
       CallExpression(node) {
-        if ((0, _utils.isTestCase)(node)) {
+        if ((0, _utils.isTestCaseCall)(node)) {
           inTestCase = true;
         }
 
@@ -55,7 +55,7 @@ var _default = (0, _utils.createRule)({
       },
 
       'CallExpression:exit'(node) {
-        if ((0, _utils.isTestCase)(node)) {
+        if ((0, _utils.isTestCaseCall)(node)) {
           inTestCase = false;
         }
       },

package/lib/rules/no-done-callback.js

@@ -18,7 +18,7 @@ const findCallbackArg = (node, isJestEach) => {
     return node.arguments[0];
   }
 
-  if ((0, _utils.isTestCase)(node) && node.arguments.length >= 2) {
+  if ((0, _utils.isTestCaseCall)(node) && node.arguments.length >= 2) {
     return node.arguments[1];
   }
 

package/lib/rules/no-duplicate-hooks.js

@@ -34,7 +34,7 @@ var _default = (0, _utils.createRule)({
     const hookContexts = [newHookContext()];
     return {
       CallExpression(node) {
-        if ((0, _utils.isDescribe)(node)) {
+        if ((0, _utils.isDescribeCall)(node)) {
           hookContexts.push(newHookContext());
         }
 
@@ -55,7 +55,7 @@ var _default = (0, _utils.createRule)({
       },
 
       'CallExpression:exit'(node) {
-        if ((0, _utils.isDescribe)(node)) {
+        if ((0, _utils.isDescribeCall)(node) && !(0, _utils.isEachCall)(node)) {
           hookContexts.pop();
         }
       }

package/lib/rules/no-export.js

@@ -41,7 +41,7 @@ var _default = (0, _utils.createRule)({
       },
 
       CallExpression(node) {
-        if ((0, _utils.isTestCase)(node)) {
+        if ((0, _utils.isTestCaseCall)(node)) {
           hasTestCase = true;
         }
       },

package/lib/rules/no-identical-title.js

@@ -37,7 +37,7 @@ var _default = (0, _utils.createRule)({
       CallExpression(node) {
         const currentLayer = contexts[contexts.length - 1];
 
-        if ((0, _utils.isDescribe)(node)) {
+        if ((0, _utils.isDescribeCall)(node)) {
           contexts.push(newDescribeContext());
         }
 
@@ -53,7 +53,7 @@ var _default = (0, _utils.createRule)({
 
         const title = (0, _utils.getStringValue)(argument);
 
-        if ((0, _utils.isTestCase)(node)) {
+        if ((0, _utils.isTestCaseCall)(node)) {
           if (currentLayer.testTitles.includes(title)) {
             context.report({
               messageId: 'multipleTestTitle',
@@ -64,7 +64,7 @@ var _default = (0, _utils.createRule)({
           currentLayer.testTitles.push(title);
         }
 
-        if (!(0, _utils.isDescribe)(node)) {
+        if (!(0, _utils.isDescribeCall)(node)) {
           return;
         }
 
@@ -79,7 +79,7 @@ var _default = (0, _utils.createRule)({
       },
 
       'CallExpression:exit'(node) {
-        if ((0, _utils.isDescribe)(node)) {
+        if ((0, _utils.isDescribeCall)(node)) {
           contexts.pop();
         }
       }

package/lib/rules/no-if.js

@@ -56,7 +56,7 @@ var _default = (0, _utils.createRule)({
 
     return {
       CallExpression(node) {
-        if ((0, _utils.isTestCase)(node)) {
+        if ((0, _utils.isTestCaseCall)(node)) {
           stack.push(true);
         }
       },

package/lib/rules/no-standalone-expect.js

@@ -30,7 +30,7 @@ const getBlockType = statement => {
     } // if it's not a variable, it will be callExpr, we only care about describe
 
 
-    if (expr.type === _experimentalUtils.AST_NODE_TYPES.CallExpression && (0, _utils.isDescribe)(expr)) {
+    if (expr.type === _experimentalUtils.AST_NODE_TYPES.CallExpression && (0, _utils.isDescribeCall)(expr)) {
       return 'describe';
     }
   }
@@ -75,7 +75,7 @@ var _default = (0, _utils.createRule)({
 
     const isCustomTestBlockFunction = node => additionalTestBlockFunctions.includes((0, _utils.getNodeName)(node) || '');
 
-    const isTestBlock = node => (0, _utils.isTestCase)(node) || isCustomTestBlockFunction(node);
+    const isTestBlock = node => (0, _utils.isTestCaseCall)(node) || isCustomTestBlockFunction(node);
 
     return {
       CallExpression(node) {

package/lib/rules/no-test-prefixes.js

@@ -30,7 +30,7 @@ var _default = (0, _utils.createRule)({
     return {
       CallExpression(node) {
         const nodeName = (0, _utils.getNodeName)(node.callee);
-        if (!nodeName || !(0, _utils.isDescribe)(node) && !(0, _utils.isTestCase)(node)) return;
+        if (!nodeName || !(0, _utils.isDescribeCall)(node) && !(0, _utils.isTestCaseCall)(node)) return;
         const preferredNodeName = getPreferredNodeName(nodeName);
         if (!preferredNodeName) return;
         const funcNode = node.callee.type === _experimentalUtils.AST_NODE_TYPES.TaggedTemplateExpression ? node.callee.tag : node.callee;

package/lib/rules/no-test-return-statement.js

@@ -38,7 +38,7 @@ var _default = (0, _utils.createRule)({
   create(context) {
     return {
       CallExpression(node) {
-        if (!(0, _utils.isTestCase)(node)) return;
+        if (!(0, _utils.isTestCaseCall)(node)) return;
         const body = getBody(node.arguments);
         const returnStmt = body.find(t => t.type === _experimentalUtils.AST_NODE_TYPES.ReturnStatement);
         if (!returnStmt) return;

package/lib/rules/no-try-expect.js

@@ -35,7 +35,7 @@ var _default = (0, _utils.createRule)({
 
     return {
       CallExpression(node) {
-        if ((0, _utils.isTestCase)(node)) {
+        if ((0, _utils.isTestCaseCall)(node)) {
           isTest = true;
         } else if (isTest && isThrowExpectCall(node)) {
           context.report({
@@ -67,7 +67,7 @@ var _default = (0, _utils.createRule)({
       },
 
       'CallExpression:exit'(node) {
-        if ((0, _utils.isTestCase)(node)) {
+        if ((0, _utils.isTestCaseCall)(node)) {
           isTest = false;
         }
       },

package/lib/rules/prefer-expect-assertions.js

@@ -55,12 +55,24 @@ var _default = (0, _utils.createRule)({
 
   create(context, [options]) {
     return {
-      'CallExpression[callee.name=/^(it|test)$/][arguments.1.body.body]'(node) {
-        if (options.onlyFunctionsWithAsyncKeyword && !node.arguments[1].async) {
+      CallExpression(node) {
+        if (!(0, _utils.isTestCaseCall)(node)) {
           return;
         }
 
-        const testFuncBody = node.arguments[1].body.body;
+        const args = (0, _utils.isEachCall)(node) ? node.parent.arguments : node.arguments;
+
+        if (args.length < 2) {
+          return;
+        }
+
+        const [, testFn] = args;
+
+        if (!(0, _utils.isFunction)(testFn) || testFn.body.type !== _experimentalUtils.AST_NODE_TYPES.BlockStatement || options.onlyFunctionsWithAsyncKeyword && !testFn.async) {
+          return;
+        }
+
+        const testFuncBody = testFn.body.body;
 
         if (!isFirstLineExprStmt(testFuncBody)) {
           context.report({
@@ -68,7 +80,7 @@ var _default = (0, _utils.createRule)({
             node,
             suggest: suggestions.map(([messageId, text]) => ({
               messageId,
-              fix: fixer => fixer.insertTextBeforeRange([node.arguments[1].body.range[0] + 1, node.arguments[1].body.range[1]], text)
+              fix: fixer => fixer.insertTextBeforeRange([testFn.body.range[0] + 1, testFn.body.range[1]], text)
             }))
           });
           return;

package/lib/rules/prefer-hooks-on-top.js

@@ -27,7 +27,7 @@ var _default = (0, _utils.createRule)({
     const hooksContext = [false];
     return {
       CallExpression(node) {
-        if (!(0, _utils.isHook)(node) && (0, _utils.isTestCase)(node)) {
+        if (!(0, _utils.isHook)(node) && (0, _utils.isTestCaseCall)(node)) {
           hooksContext[hooksContext.length - 1] = true;
         }
 

package/lib/rules/prefer-todo.js

@@ -22,7 +22,7 @@ function createTodoFixer(node, fixer) {
   return fixer.replaceText(node.callee, `${testName}.todo`);
 }
 
-const isTargetedTestCase = node => (0, _utils.isTestCase)(node) && [_utils.TestCaseName.it, _utils.TestCaseName.test, 'it.skip', 'test.skip'].includes((0, _utils.getNodeName)(node.callee));
+const isTargetedTestCase = node => (0, _utils.isTestCaseCall)(node) && [_utils.TestCaseName.it, _utils.TestCaseName.test, 'it.skip', 'test.skip'].includes((0, _utils.getNodeName)(node.callee));
 
 var _default = (0, _utils.createRule)({
   name: __filename,

package/lib/rules/require-top-level-describe.js

@@ -28,13 +28,13 @@ var _default = (0, _utils.createRule)({
     let numberOfDescribeBlocks = 0;
     return {
       CallExpression(node) {
-        if ((0, _utils.isDescribe)(node)) {
+        if ((0, _utils.isDescribeCall)(node)) {
           numberOfDescribeBlocks++;
           return;
         }
 
         if (numberOfDescribeBlocks === 0) {
-          if ((0, _utils.isTestCase)(node)) {
+          if ((0, _utils.isTestCaseCall)(node)) {
             context.report({
               node,
               messageId: 'unexpectedTestCase'
@@ -53,7 +53,7 @@ var _default = (0, _utils.createRule)({
       },
 
       'CallExpression:exit'(node) {
-        if ((0, _utils.isDescribe)(node) && !(0, _utils.isEachCall)(node)) {
+        if ((0, _utils.isDescribeCall)(node) && !(0, _utils.isEachCall)(node)) {
           numberOfDescribeBlocks--;
         }
       }

package/lib/rules/unbound-method.js

@@ -50,6 +50,8 @@ const tryCreateBaseRule = context => {
   }
 };
 
+const DEFAULT_MESSAGE = 'This rule requires `@typescript-eslint/eslint-plugin`';
+
 var _default = (0, _utils.createRule)({
   defaultOptions: [{
     ignoreStatic: false
@@ -58,7 +60,8 @@ var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
     messages: {
-      unbound: 'This rule requires `@typescript-eslint/eslint-plugin`'
+      unbound: DEFAULT_MESSAGE,
+      unboundWithoutThisAnnotation: DEFAULT_MESSAGE
     },
     schema: [],
     type: 'problem',

package/lib/rules/utils.js

@@ -4,7 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.getNodeName = getNodeName;
-exports.scopeHasLocalReference = exports.getJestFunctionArguments = exports.isEachCall = exports.isDescribe = exports.isTestCase = exports.getTestCallExpressionsFromDeclaredVariables = exports.isHook = exports.isFunction = exports.TestCaseProperty = exports.DescribeProperty = exports.HookName = exports.TestCaseName = exports.DescribeAlias = exports.parseExpectCall = exports.isParsedEqualityMatcherCall = exports.EqualityMatcher = exports.ModifierName = exports.isExpectMember = exports.isExpectCall = exports.getAccessorValue = exports.isSupportedAccessor = exports.hasOnlyOneArgument = exports.getStringValue = exports.isStringNode = exports.followTypeAssertionChain = exports.createRule = void 0;
+exports.scopeHasLocalReference = exports.getJestFunctionArguments = exports.isEachCall = exports.isDescribeCall = exports.isTestCaseCall = exports.getTestCallExpressionsFromDeclaredVariables = exports.isHook = exports.isFunction = exports.TestCaseProperty = exports.DescribeProperty = exports.HookName = exports.TestCaseName = exports.DescribeAlias = exports.parseExpectCall = exports.isParsedEqualityMatcherCall = exports.EqualityMatcher = exports.ModifierName = exports.isExpectMember = exports.isExpectCall = exports.getAccessorValue = exports.isSupportedAccessor = exports.hasOnlyOneArgument = exports.getStringValue = exports.isStringNode = exports.followTypeAssertionChain = exports.createRule = void 0;
 
 var _path = require("path");
 
@@ -390,31 +390,103 @@ const getTestCallExpressionsFromDeclaredVariables = declaredVariables => {
     references
   }) => acc.concat(references.map(({
     identifier
-  }) => identifier.parent).filter(node => !!node && node.type === _experimentalUtils.AST_NODE_TYPES.CallExpression && isTestCase(node))), []);
+  }) => identifier.parent).filter(node => !!node && node.type === _experimentalUtils.AST_NODE_TYPES.CallExpression && isTestCaseCall(node))), []);
 };
 
 exports.getTestCallExpressionsFromDeclaredVariables = getTestCallExpressionsFromDeclaredVariables;
 
-const isTestCase = node => node.callee.type === _experimentalUtils.AST_NODE_TYPES.Identifier && TestCaseName.hasOwnProperty(node.callee.name) || // e.g. it.each``()
-node.callee.type === _experimentalUtils.AST_NODE_TYPES.TaggedTemplateExpression && node.callee.tag.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression && node.callee.tag.object.type === _experimentalUtils.AST_NODE_TYPES.Identifier && TestCaseName.hasOwnProperty(node.callee.tag.object.name) && isSupportedAccessor(node.callee.tag.property, TestCaseProperty.each) || // e.g. it.concurrent.{skip,only}
-node.callee.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression && node.callee.property.type === _experimentalUtils.AST_NODE_TYPES.Identifier && TestCaseProperty.hasOwnProperty(node.callee.property.name) && (node.callee.object.type === _experimentalUtils.AST_NODE_TYPES.Identifier && TestCaseName.hasOwnProperty(node.callee.object.name) || node.callee.object.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression && node.callee.object.object.type === _experimentalUtils.AST_NODE_TYPES.Identifier && TestCaseName.hasOwnProperty(node.callee.object.object.name));
+const isTestCaseName = node => node.type === _experimentalUtils.AST_NODE_TYPES.Identifier && TestCaseName.hasOwnProperty(node.name);
 
-exports.isTestCase = isTestCase;
+const isTestCaseProperty = node => isSupportedAccessor(node) && TestCaseProperty.hasOwnProperty(getAccessorValue(node));
+/**
+ * Checks if the given `node` is a *call* to a test case function that would
+ * result in tests being run by `jest`.
+ *
+ * Note that `.each()` does not count as a call in this context, as it will not
+ * result in `jest` running any tests.
+ *
+ * @param {TSESTree.CallExpression} node
+ *
+ * @return {node is JestFunctionCallExpression<TestCaseName>}
+ */
+
+
+const isTestCaseCall = node => {
+  if (isTestCaseName(node.callee)) {
+    return true;
+  }
+
+  const callee = node.callee.type === _experimentalUtils.AST_NODE_TYPES.TaggedTemplateExpression ? node.callee.tag : node.callee;
+
+  if (callee.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression && isTestCaseProperty(callee.property)) {
+    var _node$parent;
+
+    // if we're an `each()`, ensure we're being called (i.e `.each()()`)
+    if (node.callee.type !== _experimentalUtils.AST_NODE_TYPES.TaggedTemplateExpression && ((_node$parent = node.parent) === null || _node$parent === void 0 ? void 0 : _node$parent.type) !== _experimentalUtils.AST_NODE_TYPES.CallExpression && getAccessorValue(callee.property) === 'each') {
+      return false;
+    }
+
+    return callee.object.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression ? isTestCaseName(callee.object.object) : isTestCaseName(callee.object);
+  }
+
+  return false;
+};
+
+exports.isTestCaseCall = isTestCaseCall;
+
+const isDescribeAlias = node => node.type === _experimentalUtils.AST_NODE_TYPES.Identifier && DescribeAlias.hasOwnProperty(node.name);
 
-const isDescribe = node => node.callee.type === _experimentalUtils.AST_NODE_TYPES.Identifier && DescribeAlias.hasOwnProperty(node.callee.name) || node.callee.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression && node.callee.object.type === _experimentalUtils.AST_NODE_TYPES.Identifier && DescribeAlias.hasOwnProperty(node.callee.object.name) && node.callee.property.type === _experimentalUtils.AST_NODE_TYPES.Identifier && DescribeProperty.hasOwnProperty(node.callee.property.name) || node.callee.type === _experimentalUtils.AST_NODE_TYPES.TaggedTemplateExpression && node.callee.tag.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression && node.callee.tag.object.type === _experimentalUtils.AST_NODE_TYPES.Identifier && DescribeAlias.hasOwnProperty(node.callee.tag.object.name);
+const isDescribeProperty = node => isSupportedAccessor(node) && DescribeProperty.hasOwnProperty(getAccessorValue(node));
 /**
- * Checks if the given node` is a call to `<describe|test|it>.each(...)`.
- * If `true`, the code must look like `<method>.each(...)`.
+ * Checks if the given `node` is a *call* to a `describe` function that would
+ * result in a `describe` block being created by `jest`.
+ *
+ * Note that `.each()` does not count as a call in this context, as it will not
+ * result in `jest` creating any `describe` blocks.
+ *
+ * @param {TSESTree.CallExpression} node
+ *
+ * @return {node is JestFunctionCallExpression<TestCaseName>}
+ */
+
+
+const isDescribeCall = node => {
+  if (isDescribeAlias(node.callee)) {
+    return true;
+  }
+
+  const callee = node.callee.type === _experimentalUtils.AST_NODE_TYPES.TaggedTemplateExpression ? node.callee.tag : node.callee;
+
+  if (callee.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression && isDescribeProperty(callee.property)) {
+    var _node$parent2;
+
+    // if we're an `each()`, ensure we're being called (i.e `.each()()`)
+    if (node.callee.type !== _experimentalUtils.AST_NODE_TYPES.TaggedTemplateExpression && ((_node$parent2 = node.parent) === null || _node$parent2 === void 0 ? void 0 : _node$parent2.type) !== _experimentalUtils.AST_NODE_TYPES.CallExpression && getAccessorValue(callee.property) === 'each') {
+      return false;
+    }
+
+    return callee.object.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression ? isDescribeAlias(callee.object.object) : isDescribeAlias(callee.object);
+  }
+
+  return false;
+};
+/**
+ * Checks if the given node` is a call to `<describe|test|it>.each(...)()`.
+ * If `true`, the code must look like `<method>.each(...)()`.
  *
  * @param {JestFunctionCallExpression<DescribeAlias | TestCaseName>} node
  *
- * @return {node is JestFunctionCallExpressionWithMemberExpressionCallee<DescribeAlias | TestCaseName, DescribeProperty.each | TestCaseProperty.each>}
+ * @return {node is JestFunctionCallExpressionWithMemberExpressionCallee<DescribeAlias | TestCaseName, DescribeProperty.each | TestCaseProperty.each> & {parent: TSESTree.CallExpression}}
  */
 
 
-exports.isDescribe = isDescribe;
+exports.isDescribeCall = isDescribeCall;
 
-const isEachCall = node => node.callee.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression && isSupportedAccessor(node.callee.property, DescribeProperty.each);
+const isEachCall = node => {
+  var _node$parent3;
+
+  return ((_node$parent3 = node.parent) === null || _node$parent3 === void 0 ? void 0 : _node$parent3.type) === _experimentalUtils.AST_NODE_TYPES.CallExpression && node.callee.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression && isSupportedAccessor(node.callee.property, DescribeProperty.each);
+};
 /**
  * Gets the arguments of the given `JestFunctionCallExpression`.
  *

package/lib/rules/valid-describe.js

@@ -41,7 +41,7 @@ var _default = (0, _utils.createRule)({
   create(context) {
     return {
       CallExpression(node) {
-        if (!(0, _utils.isDescribe)(node) || node.callee.type === _experimentalUtils.AST_NODE_TYPES.TaggedTemplateExpression) {
+        if (!(0, _utils.isDescribeCall)(node) || node.callee.type === _experimentalUtils.AST_NODE_TYPES.TaggedTemplateExpression) {
           return;
         }
 

package/lib/rules/valid-title.js

@@ -132,7 +132,7 @@ var _default = (0, _utils.createRule)({
     const mustMatchPatterns = compileMatcherPatterns(mustMatch !== null && mustMatch !== void 0 ? mustMatch : {});
     return {
       CallExpression(node) {
-        if (!(0, _utils.isDescribe)(node) && !(0, _utils.isTestCase)(node)) {
+        if (!(0, _utils.isDescribeCall)(node) && !(0, _utils.isTestCaseCall)(node)) {
           return;
         }
 
@@ -147,7 +147,7 @@ var _default = (0, _utils.createRule)({
             return;
           }
 
-          if (argument.type !== _experimentalUtils.AST_NODE_TYPES.TemplateLiteral && !(ignoreTypeOfDescribeName && (0, _utils.isDescribe)(node))) {
+          if (argument.type !== _experimentalUtils.AST_NODE_TYPES.TemplateLiteral && !(ignoreTypeOfDescribeName && (0, _utils.isDescribeCall)(node))) {
             context.report({
               messageId: 'titleMustBeString',
               loc: argument.loc
@@ -163,7 +163,7 @@ var _default = (0, _utils.createRule)({
           context.report({
             messageId: 'emptyTitle',
             data: {
-              jestFunctionName: (0, _utils.isDescribe)(node) ? _utils.DescribeAlias.describe : _utils.TestCaseName.test
+              jestFunctionName: (0, _utils.isDescribeCall)(node) ? _utils.DescribeAlias.describe : _utils.TestCaseName.test
             },
             node
           });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-jest",
-  "version": "24.3.1",
+  "version": "24.3.5",
   "description": "Eslint rules for Jest",
   "keywords": [
     "eslint",
@@ -108,7 +108,7 @@
     "eslint-plugin-import": "^2.20.2",
     "eslint-plugin-node": "^11.0.0",
     "eslint-plugin-prettier": "^3.0.0",
-    "husky": "^5.1.3",
+    "husky": "^6.0.0",
     "is-ci": "^3.0.0",
     "jest": "^26.0.1",
     "jest-runner-eslint": "^0.10.0",