eslint-plugin-jest 23.7.0 → 23.8.0

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [23.8.0](https://github.com/jest-community/eslint-plugin-jest/compare/v23.7.0...v23.8.0) (2020-02-23)
+
+### Bug Fixes
+
+- **valid-title:** ensure argument node is defined before accessing props
+  ([#538](https://github.com/jest-community/eslint-plugin-jest/issues/538))
+  ([7730f75](https://github.com/jest-community/eslint-plugin-jest/commit/7730f757561100559509b756fd362ca33b9ab1d4))
+
+### Features
+
+- **no-large-snapshots:** add setting to define maxSize by snapshot type
+  ([#524](https://github.com/jest-community/eslint-plugin-jest/issues/524))
+  ([0d77300](https://github.com/jest-community/eslint-plugin-jest/commit/0d77300e61adc7a5aa84f34ff4ccc164075d5f41))
+
 # [23.7.0](https://github.com/jest-community/eslint-plugin-jest/compare/v23.6.0...v23.7.0) (2020-02-07)
 
 ### Bug Fixes

package/docs/rules/no-large-snapshots.md

@@ -98,7 +98,7 @@ line 4
 
 ## Options
 
-This rule has an option for modifying the max number of lines allowed for a
+This rule has options for modifying the max number of lines allowed for a
 snapshot:
 
 In an `eslintrc` file:
@@ -106,11 +106,19 @@ In an `eslintrc` file:
 ```json
 ...
   "rules": {
-    "jest/no-large-snapshots": ["warn", { "maxSize": 12 }]
+    "jest/no-large-snapshots": ["warn", { "maxSize": 12, "inlineMaxSize": 6 }]
   }
 ...
 ```
 
+Max number of lines allowed could be defined by snapshot type (Inline and
+External). Use `inlineMaxSize` for
+[Inline Snapshots](https://jestjs.io/docs/en/snapshot-testing#inline-snapshots)
+size and `maxSize` for
+[External Snapshots](https://jestjs.io/docs/en/snapshot-testing#snapshot-testing-with-jest).
+If only `maxSize` is provided on options, the value of `maxSize` will be used to
+both snapshot types (Inline and External).
+
 In addition there is an option for whitelisting large snapshot files. Since
 `//eslint` comments will be removed when a `.snap` file is updated, this option
 provides a way of whitelisting large snapshots. The list of whitelistedSnapshots

package/lib/rules/no-large-snapshots.js

@@ -11,6 +11,12 @@ var _experimentalUtils = require("@typescript-eslint/experimental-utils");
 
 var _utils = require("./utils");
 
+function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); if (enumerableOnly) symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; }); keys.push.apply(keys, symbols); } return keys; }
+
+function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; if (i % 2) { ownKeys(Object(source), true).forEach(function (key) { _defineProperty(target, key, source[key]); }); } else if (Object.getOwnPropertyDescriptors) { Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)); } else { ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } } return target; }
+
+function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
+
 const reportOnViolation = (context, node, {
   maxSize: lineLimit = 50,
   whitelistedSnapshots = {}
@@ -73,6 +79,9 @@ var _default = (0, _utils.createRule)({
         maxSize: {
           type: 'number'
         },
+        inlineMaxSize: {
+          type: 'number'
+        },
         whitelistedSnapshots: {
           type: 'object',
           patternProperties: {
@@ -99,7 +108,11 @@ var _default = (0, _utils.createRule)({
       return {
         CallExpression(node) {
           if ('property' in node.callee && ((0, _utils.isSupportedAccessor)(node.callee.property, 'toMatchInlineSnapshot') || (0, _utils.isSupportedAccessor)(node.callee.property, 'toThrowErrorMatchingInlineSnapshot'))) {
-            reportOnViolation(context, node, options);
+            var _options$inlineMaxSiz;
+
+            reportOnViolation(context, node, _objectSpread({}, options, {
+              maxSize: (_options$inlineMaxSiz = options.inlineMaxSize) !== null && _options$inlineMaxSiz !== void 0 ? _options$inlineMaxSiz : options.maxSize
+            }));
           }
         }
 

package/lib/rules/utils.js

@@ -360,28 +360,18 @@ exports.TestCaseProperty = TestCaseProperty;
   TestCaseProperty["todo"] = "todo";
 })(TestCaseProperty || (exports.TestCaseProperty = TestCaseProperty = {}));
 
+const joinNames = (a, b) => a && b ? `${a}.${b}` : null;
+
 function getNodeName(node) {
-  function joinNames(a, b) {
-    return a && b ? `${a}.${b}` : null;
+  if (isSupportedAccessor(node)) {
+    return getAccessorValue(node);
   }
 
   switch (node.type) {
-    case _experimentalUtils.AST_NODE_TYPES.Identifier:
-      return node.name;
-
-    case _experimentalUtils.AST_NODE_TYPES.Literal:
-      return `${node.value}`;
-
-    case _experimentalUtils.AST_NODE_TYPES.TemplateLiteral:
-      if (node.expressions.length === 0) return node.quasis[0].value.cooked;
-      break;
-
     case _experimentalUtils.AST_NODE_TYPES.MemberExpression:
       return joinNames(getNodeName(node.object), getNodeName(node.property));
 
     case _experimentalUtils.AST_NODE_TYPES.NewExpression:
-      return getNodeName(node.callee);
-
     case _experimentalUtils.AST_NODE_TYPES.CallExpression:
       return getNodeName(node.callee);
   }
@@ -397,8 +387,8 @@ const isHook = node => node.callee.type === _experimentalUtils.AST_NODE_TYPES.Id
 
 exports.isHook = isHook;
 
-const getTestCallExpressionsFromDeclaredVariables = declaredVaiables => {
-  return declaredVaiables.reduce((acc, {
+const getTestCallExpressionsFromDeclaredVariables = declaredVariables => {
+  return declaredVariables.reduce((acc, {
     references
   }) => acc.concat(references.map(({
     identifier

package/lib/rules/valid-title.js

@@ -72,12 +72,16 @@ var _default = (0, _utils.createRule)({
     const disallowedWordsRegexp = new RegExp(`\\b(${disallowedWords.join('|')})\\b`, 'iu');
     return {
       CallExpression(node) {
-        if (!((0, _utils.isDescribe)(node) || (0, _utils.isTestCase)(node)) || !node.arguments.length) {
+        if (!(0, _utils.isDescribe)(node) && !(0, _utils.isTestCase)(node)) {
           return;
         }
 
         const [argument] = (0, _utils.getJestFunctionArguments)(node);
 
+        if (!argument) {
+          return;
+        }
+
         if (!(0, _utils.isStringNode)(argument)) {
           if (argument.type === _experimentalUtils.AST_NODE_TYPES.BinaryExpression && doesBinaryExpressionContainStringNode(argument)) {
             return;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-jest",
-  "version": "23.7.0",
+  "version": "23.8.0",
   "description": "Eslint rules for Jest",
   "repository": "jest-community/eslint-plugin-jest",
   "license": "MIT",