eslint-plugin-jest 23.4.0 → 23.8.0

package/CHANGELOG.md

@@ -1,3 +1,50 @@
+# [23.8.0](https://github.com/jest-community/eslint-plugin-jest/compare/v23.7.0...v23.8.0) (2020-02-23)
+
+### Bug Fixes
+
+- **valid-title:** ensure argument node is defined before accessing props
+  ([#538](https://github.com/jest-community/eslint-plugin-jest/issues/538))
+  ([7730f75](https://github.com/jest-community/eslint-plugin-jest/commit/7730f757561100559509b756fd362ca33b9ab1d4))
+
+### Features
+
+- **no-large-snapshots:** add setting to define maxSize by snapshot type
+  ([#524](https://github.com/jest-community/eslint-plugin-jest/issues/524))
+  ([0d77300](https://github.com/jest-community/eslint-plugin-jest/commit/0d77300e61adc7a5aa84f34ff4ccc164075d5f41))
+
+# [23.7.0](https://github.com/jest-community/eslint-plugin-jest/compare/v23.6.0...v23.7.0) (2020-02-07)
+
+### Bug Fixes
+
+- **expect-expect:** use `u` flag in regex
+  ([#532](https://github.com/jest-community/eslint-plugin-jest/issues/532))
+  ([c12b725](https://github.com/jest-community/eslint-plugin-jest/commit/c12b7251ef1506073d268973b93c7fc9fbcf50af))
+
+### Features
+
+- **valid-title:** support `disallowedWords` option
+  ([#522](https://github.com/jest-community/eslint-plugin-jest/issues/522))
+  ([38bbe93](https://github.com/jest-community/eslint-plugin-jest/commit/38bbe93794ed456c6e9e5d7be848b2aeb55ce0ba))
+
+# [23.6.0](https://github.com/jest-community/eslint-plugin-jest/compare/v23.5.0...v23.6.0) (2020-01-12)
+
+### Features
+
+- **no-if:** support `switch` statements
+  ([#515](https://github.com/jest-community/eslint-plugin-jest/issues/515))
+  ([be4e49d](https://github.com/jest-community/eslint-plugin-jest/commit/be4e49dcecd64711e743f5e09d1ff24e4c6e1648))
+
+# [23.5.0](https://github.com/jest-community/eslint-plugin-jest/compare/v23.4.0...v23.5.0) (2020-01-12)
+
+### Features
+
+- **expect-expect:** support glob patterns for assertFunctionNames
+  ([#509](https://github.com/jest-community/eslint-plugin-jest/issues/509))
+  ([295ca9a](https://github.com/jest-community/eslint-plugin-jest/commit/295ca9a6969c77fadaa1a42d76e89cae992520a6))
+- **valid-expect:** refactor `valid-expect` linting messages
+  ([#501](https://github.com/jest-community/eslint-plugin-jest/issues/501))
+  ([7338362](https://github.com/jest-community/eslint-plugin-jest/commit/7338362420eb4970f99be2016bb4ded5732797e3))
+
 # [23.4.0](https://github.com/jest-community/eslint-plugin-jest/compare/v23.3.0...v23.4.0) (2020-01-10)
 
 ### Features

package/README.md

@@ -1,6 +1,3 @@
-[![Actions Status](https://github.com/jest-community/eslint-plugin-jest/workflows/Unit%20tests/badge.svg)](https://github.com/jest-community/eslint-plugin-jest/actions)
-[![Renovate badge](https://badges.renovateapi.com/github/jest-community/eslint-plugin-jest)](https://renovatebot.com/)
-
 <div align="center">
   <a href="https://eslint.org/">
     <img width="150" height="150" src="https://eslint.org/assets/img/logo.svg">
@@ -12,6 +9,9 @@
   <p>ESLint plugin for Jest</p>
 </div>
 
+[![Actions Status](https://github.com/jest-community/eslint-plugin-jest/workflows/Unit%20tests/badge.svg?branch=master)](https://github.com/jest-community/eslint-plugin-jest/actions)
+[![Renovate badge](https://badges.renovateapi.com/github/jest-community/eslint-plugin-jest)](https://renovatebot.com/)
+
 ## Installation
 
 ```

package/docs/rules/expect-expect.md

@@ -42,7 +42,9 @@ it('should work with callbacks/async', () => {
 
 ### `assertFunctionNames`
 
-This array option whitelists the assertion function names to look for.
+This array option whitelists the assertion function names to look for. Function
+names can use wildcards like `request.*.expect`, `request.**.expect`,
+`request.*.expect*`
 
 Examples of **incorrect** code for the `{ "assertFunctionNames": ["expect"] }`
 option:
@@ -78,10 +80,10 @@ test('returns sum', () =>
 
 Examples of **correct** code for working with the HTTP assertions library
 [SuperTest](https://www.npmjs.com/package/supertest) with the
-`{ "assertFunctionNames": ["expect", "request.get.expect"] }` option:
+`{ "assertFunctionNames": ["expect", "request.*.expect"] }` option:
 
 ```js
-/* eslint jest/expect-expect: ["error", { "assertFunctionNames": ["expect", "request.get.expect"] }] */
+/* eslint jest/expect-expect: ["error", { "assertFunctionNames": ["expect", "request.*.expect"] }] */
 const request = require('supertest');
 const express = require('express');
 

package/docs/rules/no-large-snapshots.md

@@ -98,7 +98,7 @@ line 4
 
 ## Options
 
-This rule has an option for modifying the max number of lines allowed for a
+This rule has options for modifying the max number of lines allowed for a
 snapshot:
 
 In an `eslintrc` file:
@@ -106,11 +106,19 @@ In an `eslintrc` file:
 ```json
 ...
   "rules": {
-    "jest/no-large-snapshots": ["warn", { "maxSize": 12 }]
+    "jest/no-large-snapshots": ["warn", { "maxSize": 12, "inlineMaxSize": 6 }]
   }
 ...
 ```
 
+Max number of lines allowed could be defined by snapshot type (Inline and
+External). Use `inlineMaxSize` for
+[Inline Snapshots](https://jestjs.io/docs/en/snapshot-testing#inline-snapshots)
+size and `maxSize` for
+[External Snapshots](https://jestjs.io/docs/en/snapshot-testing#snapshot-testing-with-jest).
+If only `maxSize` is provided on options, the value of `maxSize` will be used to
+both snapshot types (Inline and External).
+
 In addition there is an option for whitelisting large snapshot files. Since
 `//eslint` comments will be removed when a `.snap` file is updated, this option
 provides a way of whitelisting large snapshots. The list of whitelistedSnapshots

package/docs/rules/valid-title.md

@@ -45,7 +45,7 @@ xtest('foo', () => {});
 
 Titles for test blocks should always be a string literal or expression.
 
-This is also applied to describe blocks by default, but can be turned off via
+This is also applied to `describe` blocks by default, but can be turned off via
 the `ignoreTypeOfDescribeName` option:
 
 Examples of **incorrect** code for this rule:
@@ -87,7 +87,7 @@ describe(6, function() {});
 
 **duplicatePrefix**
 
-A describe/ test block should not start with duplicatePrefix
+A `describe` / `test` block should not start with `duplicatePrefix`
 
 Examples of **incorrect** code for this rule
 
@@ -117,7 +117,7 @@ describe('foo', () => {
 
 **accidentalSpace**
 
-A describe/ test block should not contain accidentalSpace
+A `describe` / `test` block should not contain accidentalSpace
 
 Examples of **incorrect** code for this rule
 
@@ -148,3 +148,45 @@ describe('foo', () => {
   test('bar', () => {});
 });
 ```
+
+## Options
+
+```ts
+interface {
+  ignoreTypeOfDescribeName?: boolean;
+  disallowedWords?: string[];
+}
+```
+
+#### `ignoreTypeOfDescribeName`
+
+Default: `false`
+
+When enabled, the type of the first argument to `describe` blocks won't be
+checked.
+
+#### `disallowedWords`
+
+Default: `[]`
+
+A string array of words that are not allowed to be used in test titles. Matching
+is not case-sensitive, and looks for complete words:
+
+Examples of **incorrect** code using `disallowedWords`:
+
+```js
+// with disallowedWords: ['correct', 'all', 'every', 'properly']
+describe('the correct way to do things', () => {});
+it('has ALL the things', () => {});
+xdescribe('every single one of them', () => {});
+test(`that the value is set properly`, () => {});
+```
+
+Examples of **correct** code when using `disallowedWords`:
+
+```js
+// with disallowedWords: ['correct', 'all', 'every', 'properly']
+it('correctly sets the value', () => {});
+test('that everything is as it should be', () => {});
+describe('the proper way to handle things', () => {});
+```

package/lib/rules/expect-expect.js

@@ -13,6 +13,21 @@ var _utils = require("./utils");
  * This implementation is adapted from eslint-plugin-jasmine.
  * MIT license, Remco Haszing.
  */
+
+/**
+ * Checks if node names returned by getNodeName matches any of the given star patterns
+ * Pattern examples:
+ *   request.*.expect
+ *   request.**.expect
+ *   request.**.expect*
+ */
+function matchesAssertFunctionName(nodeName, patterns) {
+  return patterns.some(p => new RegExp(`^${p.split('.').map(x => {
+    if (x === '**') return '[a-z\\.]*';
+    return x.replace(/\*/gu, '[a-z]*');
+  }).join('\\.')}(\\.|$)`, 'ui').test(nodeName));
+}
+
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -70,7 +85,7 @@ var _default = (0, _utils.createRule)({
 
         if (name === _utils.TestCaseName.it || name === _utils.TestCaseName.test) {
           unchecked.push(node);
-        } else if (name && assertFunctionNames.includes(name)) {
+        } else if (name && matchesAssertFunctionName(name, assertFunctionNames)) {
           // Return early in case of nested `it` statements.
           checkCallExpressionUsed(context.getAncestors());
         }

package/lib/rules/no-commented-out-tests.js

@@ -8,7 +8,7 @@ exports.default = void 0;
 var _utils = require("./utils");
 
 function hasTests(node) {
-  return /^\s*[xf]?(test|it|describe)(\.\w+|\[['"]\w+['"]\])?\s*\(/m.test(node.value);
+  return /^\s*[xf]?(test|it|describe)(\.\w+|\[['"]\w+['"]\])?\s*\(/mu.test(node.value);
 }
 
 var _default = (0, _utils.createRule)({

package/lib/rules/no-export.js

@@ -63,7 +63,7 @@ var _default = (0, _utils.createRule)({
           } = object);
         }
 
-        if ('name' in object && object.name === 'module' && property.type === _experimentalUtils.AST_NODE_TYPES.Identifier && /^exports?$/.test(property.name)) {
+        if ('name' in object && object.name === 'module' && property.type === _experimentalUtils.AST_NODE_TYPES.Identifier && /^exports?$/u.test(property.name)) {
           exportNodes.push(node);
         }
       }

package/lib/rules/no-if.js

@@ -13,6 +13,12 @@ const testCaseNames = new Set([...Object.keys(_utils.TestCaseName), 'it.only', '
 
 const isTestArrowFunction = node => node.parent !== undefined && node.parent.type === _experimentalUtils.AST_NODE_TYPES.CallExpression && testCaseNames.has((0, _utils.getNodeName)(node.parent.callee));
 
+const conditionName = {
+  [_experimentalUtils.AST_NODE_TYPES.ConditionalExpression]: 'conditional',
+  [_experimentalUtils.AST_NODE_TYPES.SwitchStatement]: 'switch',
+  [_experimentalUtils.AST_NODE_TYPES.IfStatement]: 'if'
+};
+
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -22,8 +28,7 @@ var _default = (0, _utils.createRule)({
       recommended: false
     },
     messages: {
-      noIf: 'Tests should not contain if statements.',
-      noConditional: 'Tests should not contain conditional statements.'
+      noConditionalExpect: 'Test should not contain { condition } statements.'
     },
     schema: [],
     type: 'suggestion'
@@ -36,13 +41,15 @@ var _default = (0, _utils.createRule)({
     function validate(node) {
       const lastElementInStack = stack[stack.length - 1];
 
-      if (stack.length === 0 || lastElementInStack === false) {
+      if (stack.length === 0 || !lastElementInStack) {
         return;
       }
 
-      const messageId = node.type === _experimentalUtils.AST_NODE_TYPES.ConditionalExpression ? 'noConditional' : 'noIf';
       context.report({
-        messageId,
+        data: {
+          condition: conditionName[node.type]
+        },
+        messageId: 'noConditionalExpect',
         node
       });
     }
@@ -67,6 +74,7 @@ var _default = (0, _utils.createRule)({
       },
 
       IfStatement: validate,
+      SwitchStatement: validate,
       ConditionalExpression: validate,
 
       'CallExpression:exit'() {

package/lib/rules/no-large-snapshots.js

@@ -11,6 +11,12 @@ var _experimentalUtils = require("@typescript-eslint/experimental-utils");
 
 var _utils = require("./utils");
 
+function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); if (enumerableOnly) symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; }); keys.push.apply(keys, symbols); } return keys; }
+
+function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; if (i % 2) { ownKeys(Object(source), true).forEach(function (key) { _defineProperty(target, key, source[key]); }); } else if (Object.getOwnPropertyDescriptors) { Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)); } else { ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } } return target; }
+
+function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
+
 const reportOnViolation = (context, node, {
   maxSize: lineLimit = 50,
   whitelistedSnapshots = {}
@@ -73,6 +79,9 @@ var _default = (0, _utils.createRule)({
         maxSize: {
           type: 'number'
         },
+        inlineMaxSize: {
+          type: 'number'
+        },
         whitelistedSnapshots: {
           type: 'object',
           patternProperties: {
@@ -99,7 +108,11 @@ var _default = (0, _utils.createRule)({
       return {
         CallExpression(node) {
           if ('property' in node.callee && ((0, _utils.isSupportedAccessor)(node.callee.property, 'toMatchInlineSnapshot') || (0, _utils.isSupportedAccessor)(node.callee.property, 'toThrowErrorMatchingInlineSnapshot'))) {
-            reportOnViolation(context, node, options);
+            var _options$inlineMaxSiz;
+
+            reportOnViolation(context, node, _objectSpread({}, options, {
+              maxSize: (_options$inlineMaxSiz = options.inlineMaxSize) !== null && _options$inlineMaxSiz !== void 0 ? _options$inlineMaxSiz : options.maxSize
+            }));
           }
         }
 

package/lib/rules/utils.js

@@ -360,28 +360,18 @@ exports.TestCaseProperty = TestCaseProperty;
   TestCaseProperty["todo"] = "todo";
 })(TestCaseProperty || (exports.TestCaseProperty = TestCaseProperty = {}));
 
+const joinNames = (a, b) => a && b ? `${a}.${b}` : null;
+
 function getNodeName(node) {
-  function joinNames(a, b) {
-    return a && b ? `${a}.${b}` : null;
+  if (isSupportedAccessor(node)) {
+    return getAccessorValue(node);
   }
 
   switch (node.type) {
-    case _experimentalUtils.AST_NODE_TYPES.Identifier:
-      return node.name;
-
-    case _experimentalUtils.AST_NODE_TYPES.Literal:
-      return `${node.value}`;
-
-    case _experimentalUtils.AST_NODE_TYPES.TemplateLiteral:
-      if (node.expressions.length === 0) return node.quasis[0].value.cooked;
-      break;
-
     case _experimentalUtils.AST_NODE_TYPES.MemberExpression:
       return joinNames(getNodeName(node.object), getNodeName(node.property));
 
     case _experimentalUtils.AST_NODE_TYPES.NewExpression:
-      return getNodeName(node.callee);
-
     case _experimentalUtils.AST_NODE_TYPES.CallExpression:
       return getNodeName(node.callee);
   }
@@ -397,8 +387,8 @@ const isHook = node => node.callee.type === _experimentalUtils.AST_NODE_TYPES.Id
 
 exports.isHook = isHook;
 
-const getTestCallExpressionsFromDeclaredVariables = declaredVaiables => {
-  return declaredVaiables.reduce((acc, {
+const getTestCallExpressionsFromDeclaredVariables = declaredVariables => {
+  return declaredVariables.reduce((acc, {
     references
   }) => acc.concat(references.map(({
     identifier

package/lib/rules/valid-expect.js

@@ -64,12 +64,10 @@ var _default = (0, _utils.createRule)({
       recommended: 'error'
     },
     messages: {
-      multipleArgs: 'More than one argument was passed to expect().',
-      noArgs: 'No arguments were passed to expect().',
-      noAssertions: 'No assertion was called on expect().',
-      invalidProperty: '"{{ propertyName }}" is not a valid property of expect.',
-      propertyWithoutMatcher: '"{{ propertyName }}" needs to call a matcher.',
-      matcherOnPropertyNotCalled: '"{{ propertyName }}" was not called.',
+      incorrectNumberOfArguments: 'Expect takes one and only one argument.',
+      modifierUnknown: 'Expect has no modifier named "{{ modifierName }}".',
+      matcherNotFound: 'Expect must have a corresponding matcher call.',
+      matcherNotCalled: 'Matchers must be called to assert.',
       asyncMustBeAwaited: 'Async assertions must be awaited{{ orReturned }}.',
       promisesWithAsyncAssertionsMustBeAwaited: 'Promises which return async assertions must be awaited{{ orReturned }}.'
     },
@@ -119,35 +117,39 @@ var _default = (0, _utils.createRule)({
           matcher
         } = (0, _utils.parseExpectCall)(node);
 
-        if (expect.arguments.length > 1) {
-          const secondArgumentLocStart = expect.arguments[1].loc.start;
-          const lastArgumentLocEnd = expect.arguments[node.arguments.length - 1].loc.end;
-          context.report({
-            loc: {
-              end: {
-                column: lastArgumentLocEnd.column - 1,
-                line: lastArgumentLocEnd.line
-              },
-              start: secondArgumentLocStart
-            },
-            messageId: 'multipleArgs',
-            node
-          });
-        } else if (expect.arguments.length === 0) {
+        if (expect.arguments.length !== 1) {
           const expectLength = (0, _utils.getAccessorValue)(expect.callee).length;
-          context.report({
-            loc: {
+          let loc = {
+            start: {
+              column: node.loc.start.column + expectLength,
+              line: node.loc.start.line
+            },
+            end: {
+              column: node.loc.start.column + expectLength + 1,
+              line: node.loc.start.line
+            }
+          };
+
+          if (expect.arguments.length !== 0) {
+            const {
+              start
+            } = expect.arguments[1].loc;
+            const {
+              end
+            } = expect.arguments[node.arguments.length - 1].loc;
+            loc = {
+              start,
               end: {
-                column: node.loc.start.column + expectLength + 1,
-                line: node.loc.start.line
-              },
-              start: {
-                column: node.loc.start.column + expectLength,
-                line: node.loc.start.line
+                column: end.column - 1,
+                line: end.line
               }
-            },
-            messageId: 'noArgs',
-            node
+            };
+          }
+
+          context.report({
+            messageId: 'incorrectNumberOfArguments',
+            node,
+            loc
           });
         } // something was called on `expect()`
 
@@ -155,12 +157,7 @@ var _default = (0, _utils.createRule)({
         if (!matcher) {
           if (modifier) {
             context.report({
-              data: {
-                propertyName: modifier.name
-              },
-              // todo: rename to 'modifierName'
-              messageId: 'propertyWithoutMatcher',
-              // todo: rename to 'modifierWithoutMatcher'
+              messageId: 'matcherNotFound',
               node: modifier.node.property
             });
           }
@@ -170,12 +167,10 @@ var _default = (0, _utils.createRule)({
 
         if (matcher.node.parent && (0, _utils.isExpectMember)(matcher.node.parent)) {
           context.report({
-            messageId: 'invalidProperty',
-            // todo: rename to 'invalidModifier'
+            messageId: 'modifierUnknown',
             data: {
-              propertyName: matcher.name
+              modifierName: matcher.name
             },
-            // todo: rename to 'matcherName' (or modifierName?)
             node: matcher.node.property
           });
           return;
@@ -183,12 +178,7 @@ var _default = (0, _utils.createRule)({
 
         if (!matcher.arguments) {
           context.report({
-            data: {
-              propertyName: matcher.name
-            },
-            // todo: rename to 'matcherName'
-            messageId: 'matcherOnPropertyNotCalled',
-            // todo: rename to 'matcherNotCalled'
+            messageId: 'matcherNotCalled',
             node: matcher.node.property
           });
         }
@@ -237,7 +227,7 @@ var _default = (0, _utils.createRule)({
       'CallExpression:exit'(node) {
         if ((0, _utils.isExpectCall)(node) && isNoAssertionsParentNode(node.parent)) {
           context.report({
-            messageId: 'noAssertions',
+            messageId: 'matcherNotFound',
             node
           });
         }

package/lib/rules/valid-title.js

@@ -23,6 +23,8 @@ const doesBinaryExpressionContainStringNode = binaryExp => {
   return (0, _utils.isStringNode)(binaryExp.left);
 };
 
+const quoteStringValue = node => node.type === _experimentalUtils.AST_NODE_TYPES.TemplateLiteral ? `\`${node.quasis[0].value.raw}\`` : node.raw;
+
 var _default = (0, _utils.createRule)({
   name: __filename,
   meta: {
@@ -35,7 +37,8 @@ var _default = (0, _utils.createRule)({
       titleMustBeString: 'Title must be a string',
       emptyTitle: '{{ jestFunctionName }} should not have an empty title',
       duplicatePrefix: 'should not have duplicate prefix',
-      accidentalSpace: 'should not have leading or trailing spaces'
+      accidentalSpace: 'should not have leading or trailing spaces',
+      disallowedWord: '"{{ word }}" is not allowed in test titles.'
     },
     type: 'suggestion',
     schema: [{
@@ -44,6 +47,13 @@ var _default = (0, _utils.createRule)({
         ignoreTypeOfDescribeName: {
           type: 'boolean',
           default: false
+        },
+        disallowedWords: {
+          type: 'array',
+          items: {
+            type: 'string'
+          },
+          default: []
         }
       },
       additionalProperties: false
@@ -51,20 +61,27 @@ var _default = (0, _utils.createRule)({
     fixable: 'code'
   },
   defaultOptions: [{
-    ignoreTypeOfDescribeName: false
+    ignoreTypeOfDescribeName: false,
+    disallowedWords: []
   }],
 
   create(context, [{
-    ignoreTypeOfDescribeName
+    ignoreTypeOfDescribeName,
+    disallowedWords
   }]) {
+    const disallowedWordsRegexp = new RegExp(`\\b(${disallowedWords.join('|')})\\b`, 'iu');
     return {
       CallExpression(node) {
-        if (!((0, _utils.isDescribe)(node) || (0, _utils.isTestCase)(node)) || !node.arguments.length) {
+        if (!(0, _utils.isDescribe)(node) && !(0, _utils.isTestCase)(node)) {
           return;
         }
 
         const [argument] = (0, _utils.getJestFunctionArguments)(node);
 
+        if (!argument) {
+          return;
+        }
+
         if (!(0, _utils.isStringNode)(argument)) {
           if (argument.type === _experimentalUtils.AST_NODE_TYPES.BinaryExpression && doesBinaryExpressionContainStringNode(argument)) {
             return;
@@ -93,16 +110,26 @@ var _default = (0, _utils.createRule)({
           return;
         }
 
+        if (disallowedWords.length > 0) {
+          const disallowedMatch = disallowedWordsRegexp.exec(title);
+
+          if (disallowedMatch) {
+            context.report({
+              data: {
+                word: disallowedMatch[1]
+              },
+              messageId: 'disallowedWord',
+              node: argument
+            });
+            return;
+          }
+        }
+
         if (title.trim().length !== title.length) {
           context.report({
             messageId: 'accidentalSpace',
             node: argument,
-
-            fix(fixer) {
-              const stringValue = argument.type === _experimentalUtils.AST_NODE_TYPES.TemplateLiteral ? `\`${argument.quasis[0].value.raw}\`` : argument.raw;
-              return [fixer.replaceTextRange(argument.range, stringValue.replace(/^([`'"]) +?/, '$1').replace(/ +?([`'"])$/, '$1'))];
-            }
-
+            fix: fixer => [fixer.replaceTextRange(argument.range, quoteStringValue(argument).replace(/^([`'"]) +?/u, '$1').replace(/ +?([`'"])$/u, '$1'))]
           });
         }
 
@@ -113,12 +140,7 @@ var _default = (0, _utils.createRule)({
           context.report({
             messageId: 'duplicatePrefix',
             node: argument,
-
-            fix(fixer) {
-              const stringValue = argument.type === _experimentalUtils.AST_NODE_TYPES.TemplateLiteral ? `\`${argument.quasis[0].value.raw}\`` : argument.raw;
-              return [fixer.replaceTextRange(argument.range, stringValue.replace(/^([`'"]).+? /, '$1'))];
-            }
-
+            fix: fixer => [fixer.replaceTextRange(argument.range, quoteStringValue(argument).replace(/^([`'"]).+? /u, '$1'))]
           });
         }
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-jest",
-  "version": "23.4.0",
+  "version": "23.8.0",
   "description": "Eslint rules for Jest",
   "repository": "jest-community/eslint-plugin-jest",
   "license": "MIT",
@@ -60,7 +60,7 @@
     "eslint-plugin-eslint-comments": "^3.1.2",
     "eslint-plugin-eslint-plugin": "^2.0.0",
     "eslint-plugin-import": "^2.18.0",
-    "eslint-plugin-node": "^10.0.0",
+    "eslint-plugin-node": "^11.0.0",
     "eslint-plugin-prettier": "^3.0.0",
     "husky": "^3.0.9",
     "jest": "^24.9.0",