eslint-plugin-import-next 2.3.9 → 2.3.11

package/src/rules/named.js

@@ -1,9 +1,4 @@
 "use strict";
-/**
- * Copyright (c) 2025 Ofri Peretz
- * Licensed under the MIT License. Use of this source code is governed by the
- * MIT license that can be found in the LICENSE file.
- */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.named = void 0;
 const tslib_1 = require("tslib");
@@ -20,7 +15,7 @@ exports.named = (0, eslint_devkit_1.createRule)({
         },
         messages: {
             named: (0, eslint_devkit_2.formatLLMMessage)({
-                icon: eslint_devkit_2.MessageIcons.SECURITY, // Using SECURITY as incorrect imports can be dangerous or break build
+                icon: eslint_devkit_2.MessageIcons.SECURITY,
                 issueName: 'Missing Named Export',
                 description: 'Named export not found in module',
                 severity: 'HIGH',
@@ -43,22 +38,18 @@ exports.named = (0, eslint_devkit_1.createRule)({
                     return;
                 const tsNode = services.esTreeNodeToTSNodeMap.get(node.imported);
                 let symbol = checker?.getSymbolAtLocation?.(tsNode);
-                // Resolve alias if needed
                 if (symbol && (symbol.flags & typescript_1.default.SymbolFlags.Alias)) {
                     try {
                         symbol = checker?.getAliasedSymbol?.(symbol);
                     }
                     catch {
-                        // If resolving alias fails, symbol implies broken import
                         symbol = undefined;
                     }
                 }
-                // Check if symbol is "unknown" or broken
                 if (symbol && symbol.escapedName === 'unknown') {
                     symbol = undefined;
                 }
                 if (!symbol) {
-                    // Check if module itself resolves
                     const source = node.parent.source;
                     if (!source)
                         return;

package/src/rules/namespace.js

@@ -1,9 +1,4 @@
 "use strict";
-/**
- * Copyright (c) 2025 Ofri Peretz
- * Licensed under the MIT License. Use of this source code is governed by the
- * MIT license that can be found in the LICENSE file.
- */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.namespace = void 0;
 const tslib_1 = require("tslib");
@@ -38,7 +33,6 @@ exports.namespace = (0, eslint_devkit_1.createRule)({
         const checker = services.program?.getTypeChecker?.();
         return {
             MemberExpression(node) {
-                // Check if object is a namespace import
                 const object = node.object;
                 if (object.type !== 'Identifier')
                     return;
@@ -47,17 +41,13 @@ exports.namespace = (0, eslint_devkit_1.createRule)({
                 if (symbol && symbol.declarations && symbol.declarations.length > 0) {
                     const declaration = symbol.declarations[0];
                     if (declaration.kind === typescript_1.default.SyntaxKind.NamespaceImport) {
-                        // If we have a namespace import, the symbol should refer to the module.
-                        // We need to check if the property being accessed exists on the module exports.
                         if (node.property.type !== 'Identifier')
-                            return; // Computed access might be hard to check
+                            return;
                         const propertyName = node.property.name;
-                        // This is a bit simplified; we really need to check the type of the symbol
                         const type = checker?.getTypeAtLocation?.(tsNode);
                         if (!type)
                             return;
                         const propertySymbol = checker?.getPropertyOfType?.(type, propertyName);
-                        // Removed erroneous early return here
                         if (!propertySymbol) {
                             context.report({
                                 node: node.property,

package/src/rules/newline-after-import.js

@@ -1,9 +1,4 @@
 "use strict";
-/**
- * Copyright (c) 2025 Ofri Peretz
- * Licensed under the MIT License. Use of this source code is governed by the
- * MIT license that can be found in the LICENSE file.
- */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.newlineAfterImport = void 0;
 const eslint_devkit_1 = require("@interlace/eslint-devkit");
@@ -36,13 +31,8 @@ exports.newlineAfterImport = (0, eslint_devkit_1.createRule)({
                 const sourceCode = context.sourceCode;
                 const nextToken = sourceCode.getTokenAfter(node);
                 if (!nextToken)
-                    return; // End of file
-                // If the next token is on the same line, it's an error (unless it's a comment, but usually imports are on own line)
+                    return;
                 if (nextToken.loc.start.line === node.loc.end.line) {
-                    // Maybe it's fine if it's another import?
-                    // Wait, logic is: after the *last* import in a block or any import?
-                    // "Enforce a newline after import statements" usually means after the *group* of imports.
-                    // But checking every import: if next node is NOT an import, there should be a blank line.
                 }
                 const nextNode = sourceCode.getNodeByRangeIndex(nextToken.range[0]);
                 if (nextNode &&
@@ -50,14 +40,13 @@ exports.newlineAfterImport = (0, eslint_devkit_1.createRule)({
                         nextNode.type === 'TSImportEqualsDeclaration')) {
                     return;
                 }
-                // Check lines between
                 if (nextToken.loc.start.line - node.loc.end.line < 2) {
                     context.report({
                         node,
                         messageId: 'newlineAfterImport',
                         fix(fixer) {
                             const linesBetween = nextToken.loc.start.line - node.loc.end.line;
-                            const newlinesToAdd = 2 - linesBetween; // Add enough to make it 2 lines total
+                            const newlinesToAdd = 2 - linesBetween;
                             return fixer.insertTextAfter(node, '\n'.repeat(newlinesToAdd));
                         },
                     });

package/src/rules/no-absolute-path.js

@@ -1,9 +1,4 @@
 "use strict";
-/**
- * Copyright (c) 2025 Ofri Peretz
- * Licensed under the MIT License. Use of this source code is governed by the
- * MIT license that can be found in the LICENSE file.
- */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.noAbsolutePath = void 0;
 const tslib_1 = require("tslib");
@@ -93,14 +88,12 @@ exports.noAbsolutePath = (0, eslint_devkit_1.createRule)({
                 if (node.callee.type !== 'Identifier')
                     return;
                 const calleeName = node.callee.name;
-                // CommonJS require
                 if (commonjs &&
                     calleeName === 'require' &&
                     node.arguments.length === 1 &&
                     node.arguments[0].type === 'Literal') {
                     checkImport(node, node.arguments[0]);
                 }
-                // AMD define/require
                 if (amd && (calleeName === 'define' || calleeName === 'require')) {
                     node.arguments.forEach((arg) => {
                         if (arg.type === 'Literal') {

package/src/rules/no-amd.js

@@ -1,9 +1,4 @@
 "use strict";
-/**
- * Copyright (c) 2025 Ofri Peretz
- * Licensed under the MIT License. Use of this source code is governed by the
- * MIT license that can be found in the LICENSE file.
- */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.noAmd = void 0;
 const eslint_devkit_1 = require("@interlace/eslint-devkit");
@@ -56,35 +51,27 @@ exports.noAmd = (0, eslint_devkit_1.createRule)({
     ],
     create(context) {
         const [options] = context.options;
-        const { allow = [],
-        // suggestES6 = true // Reserved for future use when hasSuggestions is enabled
-         } = options || {};
+        const { allow = [], } = options || {};
         const filename = context.filename;
         function shouldAllow() {
-            // Check if the call is in an allowed pattern
             return allow.some((pattern) => {
                 if (!filename)
                     return false;
-                // Support glob patterns like **/legacy/**
                 if (pattern.includes('**')) {
-                    // Simple glob matching: ** matches any path segment, * matches any name segment
                     const regexPattern = pattern
                         .replace(/\*\*/g, '.*')
                         .replace(/\*/g, '[^/]*');
                     const regex = new RegExp(`^${regexPattern}$`);
                     return regex.test(filename);
                 }
-                // Simple string matching for non-glob patterns
                 return filename.includes(pattern);
             });
         }
-        // Note: ES6 suggestion generation could be added here when hasSuggestions is enabled
         return {
             CallExpression(node) {
                 if (shouldAllow()) {
                     return;
                 }
-                // Check for define() calls
                 if (node.callee.type === 'Identifier' &&
                     node.callee.name === 'define') {
                     context.report({
@@ -97,16 +84,12 @@ exports.noAmd = (0, eslint_devkit_1.createRule)({
                         },
                     });
                 }
-                // Check for AMD-style require() calls (not CommonJS)
                 else if (node.callee.type === 'Identifier' &&
                     node.callee.name === 'require' &&
                     node.arguments.length > 0) {
                     const firstArg = node.arguments[0];
-                    // AMD require typically has a callback function as second argument
-                    // or is part of a define() call
                     const hasCallback = node.arguments.length > 1 &&
                         node.arguments[1]?.type === 'FunctionExpression';
-                    // Check if this looks like AMD require (array of deps + callback)
                     if (firstArg.type === 'ArrayExpression' && hasCallback) {
                         context.report({
                             node: node.callee,

package/src/rules/no-anonymous-default-export.js

@@ -1,9 +1,4 @@
 "use strict";
-/**
- * Copyright (c) 2025 Ofri Peretz
- * Licensed under the MIT License. Use of this source code is governed by the
- * MIT license that can be found in the LICENSE file.
- */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.noAnonymousDefaultExport = void 0;
 const eslint_devkit_1 = require("@interlace/eslint-devkit");
@@ -94,28 +89,20 @@ exports.noAnonymousDefaultExport = (0, eslint_devkit_1.createRule)({
                 case 'FunctionExpression':
                     return !allowFunctionExpression;
                 case 'FunctionDeclaration':
-                    // Function declarations in default exports are anonymous if they have no name
-                    // (e.g., export default function() {}), and should be treated like function expressions
                     return declaration.id ? false : !allowFunctionExpression;
                 case 'ClassDeclaration':
-                    // Class declarations in default exports are anonymous if they have no name
-                    // (e.g., export default class {}), and should be treated like class expressions
                     return declaration.id ? false : !allowClassExpression;
                 case 'CallExpression':
-                    // Allow calls like React.forwardRef(() => ...)
-                    // Allow calls like withRouter(Component)
                     return false;
                 case 'Identifier':
                 case 'Literal':
                 case 'ObjectExpression':
                 case 'ArrayExpression':
-                    // These are not anonymous - they're named references or literals
                     return false;
                 default:
                     return true;
             }
         }
-        // oxlint-disable-next-line consistent-function-scoping
         function getSuggestionText(node) {
             const declaration = node.declaration;
             switch (declaration.type) {

package/src/rules/no-barrel-file.js

@@ -1,19 +1,10 @@
 "use strict";
-/**
- * Copyright (c) 2025 Ofri Peretz
- * Licensed under the MIT License. Use of this source code is governed by the
- * MIT license that can be found in the LICENSE file.
- */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.noBarrelFile = void 0;
 const eslint_devkit_1 = require("@interlace/eslint-devkit");
-// Default barrel patterns - index files in various extensions
 const DEFAULT_BARREL_PATTERNS = [
     '.*[/\\\\]index\\.(ts|tsx|js|jsx|mts|mjs)$',
 ];
-/**
- * Check if a path matches any of the regex patterns
- */
 function matchesPattern(filePath, patterns) {
     return patterns.some((pattern) => {
         try {
@@ -21,14 +12,10 @@ function matchesPattern(filePath, patterns) {
             return regex.test(filePath);
         }
         catch {
-            // Invalid regex, try simple includes
             return filePath.includes(pattern);
         }
     });
 }
-/**
- * Check if a node is a re-export statement
- */
 function isReexport(node) {
     if (node.type === eslint_devkit_1.AST_NODE_TYPES.ExportAllDeclaration) {
         return true;
@@ -39,12 +26,8 @@ function isReexport(node) {
     }
     return false;
 }
-/**
- * Check if a node is a local export (not re-exporting from another module)
- */
 function isLocalExport(node) {
     if (node.type === eslint_devkit_1.AST_NODE_TYPES.ExportNamedDeclaration) {
-        // Has a declaration (export const x = ...) or no source (export { x })
         return node.source === null && node.declaration !== null;
     }
     if (node.type === eslint_devkit_1.AST_NODE_TYPES.ExportDefaultDeclaration) {
@@ -52,9 +35,6 @@ function isLocalExport(node) {
     }
     return false;
 }
-/**
- * Count the number of modules being re-exported
- */
 function countReexportSources(reexports, namedReexports) {
     const sources = new Set();
     for (const node of reexports) {
@@ -150,15 +130,12 @@ exports.noBarrelFile = (0, eslint_devkit_1.createRule)({
     create(context, [options = {}]) {
         const { threshold = 3, allowedPaths = [], barrelPatterns = DEFAULT_BARREL_PATTERNS, allowWithLocalExports = false, reexportRatio = 0.8, } = options || {};
         const filename = context.filename;
-        // Check if file matches barrel patterns
         if (!matchesPattern(filename, barrelPatterns)) {
             return {};
         }
-        // Check if file is in allowed paths
         if (allowedPaths.length > 0 && matchesPattern(filename, allowedPaths)) {
             return {};
         }
-        // Collect all exports
         const exportAllDeclarations = [];
         const namedReexports = [];
         const localExports = [];
@@ -182,23 +159,16 @@ exports.noBarrelFile = (0, eslint_devkit_1.createRule)({
             'Program:exit'(node) {
                 const totalReexports = exportAllDeclarations.length + namedReexports.length;
                 const totalExports = totalReexports + localExports.length;
-                // No exports = not a barrel file
                 if (totalExports === 0) {
                     return;
                 }
-                // Count unique source modules
                 const sourceCount = countReexportSources(exportAllDeclarations, namedReexports);
-                // Check if file has local exports
                 const hasLocalExports = localExports.length > 0;
-                // Skip if allows local exports and has them
                 if (allowWithLocalExports && hasLocalExports) {
                     return;
                 }
-                // Calculate re-export ratio
                 const ratio = totalReexports / totalExports;
-                // Check if this is a barrel file
                 if (sourceCount >= threshold && !hasLocalExports) {
-                    // Pure barrel file - definitely flag
                     context.report({
                         node,
                         messageId: 'barrelFileDetected',
@@ -210,8 +180,6 @@ exports.noBarrelFile = (0, eslint_devkit_1.createRule)({
                 else if (hasLocalExports &&
                     sourceCount >= threshold &&
                     ratio >= reexportRatio) {
-                    // Mixed file with high re-export ratio - suggest improvement
-                    // Only applies when there ARE local exports (mixed barrels)
                     context.report({
                         node,
                         messageId: 'considerDirectExports',

package/src/rules/no-barrel-import.js

@@ -1,15 +1,7 @@
 "use strict";
-/**
- * Copyright (c) 2025 Ofri Peretz
- * Licensed under the MIT License. Use of this source code is governed by the
- * MIT license that can be found in the LICENSE file.
- */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.noBarrelImport = void 0;
 const eslint_devkit_1 = require("@interlace/eslint-devkit");
-/**
- * Check if an import path matches any of the patterns
- */
 function matchesPattern(importPath, patterns) {
     return patterns.some((pattern) => {
         try {
@@ -21,23 +13,13 @@ function matchesPattern(importPath, patterns) {
         }
     });
 }
-/**
- * Check if import path looks like it's from node_modules
- */
 function isNodeModulesImport(importPath) {
-    // Starts with package name (not relative or absolute)
     if (importPath.startsWith('.') || importPath.startsWith('/')) {
         return false;
     }
-    // Could be a scoped or regular package
     return true;
 }
-/**
- * Check if import path explicitly references /index
- * This is a safe heuristic - explicit index imports are clearly barrel imports
- */
 function endsWithIndex(importPath) {
-    // Matches: /index, /index.ts, /index.tsx, /index.js, /index.jsx, /index.mjs
     return /\/index(\.[mc]?[jt]sx?)?$/.test(importPath);
 }
 exports.noBarrelImport = (0, eslint_devkit_1.createRule)({
@@ -99,18 +81,14 @@ exports.noBarrelImport = (0, eslint_devkit_1.createRule)({
     create(context, [options = {}]) {
         const { knownBarrels = [], ignoreNodeModules = true, ignoredPackages = [], } = options || {};
         function checkImportPath(node, importPath) {
-            // Skip node_modules if configured
             if (ignoreNodeModules && isNodeModulesImport(importPath)) {
-                // Check if it's an ignored package
                 if (ignoredPackages.length > 0 && matchesPattern(importPath, ignoredPackages)) {
                     return;
                 }
-                // For node_modules, only flag if explicitly in knownBarrels
                 if (knownBarrels.length === 0) {
                     return;
                 }
             }
-            // Check against known barrels first (explicit configuration)
             if (knownBarrels.length > 0 && matchesPattern(importPath, knownBarrels)) {
                 context.report({
                     node,
@@ -121,8 +99,6 @@ exports.noBarrelImport = (0, eslint_devkit_1.createRule)({
                 });
                 return;
             }
-            // Safe heuristic: only flag explicit /index imports (not directory imports)
-            // We can't distinguish './utils' (directory) from './utils' (file) without FS access
             if (endsWithIndex(importPath)) {
                 context.report({
                     node,
@@ -140,7 +116,6 @@ exports.noBarrelImport = (0, eslint_devkit_1.createRule)({
                     checkImportPath(node, importPath);
                 }
             },
-            // Also check re-exports that import from barrels
             ExportAllDeclaration(node) {
                 const importPath = node.source.value;
                 if (typeof importPath === 'string') {

package/src/rules/no-commonjs.js

@@ -1,9 +1,4 @@
 "use strict";
-/**
- * Copyright (c) 2025 Ofri Peretz
- * Licensed under the MIT License. Use of this source code is governed by the
- * MIT license that can be found in the LICENSE file.
- */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.noCommonjs = void 0;
 const eslint_devkit_1 = require("@interlace/eslint-devkit");
@@ -104,7 +99,6 @@ exports.noCommonjs = (0, eslint_devkit_1.createRule)({
             if (!filename) {
                 return false;
             }
-            // Check if file is in allowed list
             return allowInFiles.some((pattern) => {
                 if (pattern.includes('*')) {
                     const regex = new RegExp(pattern.replace(/\*/g, '.*'));
@@ -114,11 +108,9 @@ exports.noCommonjs = (0, eslint_devkit_1.createRule)({
             });
         }
         function generateES6Suggestion(node) {
-            // Try to generate ES6 equivalent based on the CommonJS pattern
             if (node.type === 'CallExpression' &&
                 node.callee.type === 'Identifier' &&
                 node.callee.name === 'require') {
-                // require('module')
                 const arg = node.arguments[0];
                 if (arg?.type === 'Literal' && typeof arg.value === 'string') {
                     return `// Convert to: import * as moduleName from '${arg.value}';`;
@@ -127,7 +119,6 @@ exports.noCommonjs = (0, eslint_devkit_1.createRule)({
             if (node.type === 'AssignmentExpression') {
                 const left = node.left;
                 const right = node.right;
-                // module.exports = ...
                 if (left.type === 'MemberExpression' &&
                     left.object.type === 'Identifier' &&
                     left.object.name === 'module' &&
@@ -140,7 +131,6 @@ exports.noCommonjs = (0, eslint_devkit_1.createRule)({
                         return `// Convert to: export default ${context.sourceCode.getText(right)};`;
                     }
                 }
-                // exports.something = ...
                 if (left.type === 'MemberExpression' &&
                     left.object.type === 'Identifier' &&
                     left.object.name === 'exports' &&
@@ -161,7 +151,6 @@ exports.noCommonjs = (0, eslint_devkit_1.createRule)({
                 if (shouldAllow() || allowRequire) {
                     return;
                 }
-                // Check for require() calls
                 if (node.callee.type === 'Identifier' &&
                     node.callee.name === 'require') {
                     context.report({
@@ -191,7 +180,6 @@ exports.noCommonjs = (0, eslint_devkit_1.createRule)({
                     return;
                 }
                 const left = node.left;
-                // Check for module.exports = ...
                 if (left.type === 'MemberExpression' &&
                     left.object.type === 'Identifier' &&
                     left.object.name === 'module' &&
@@ -219,7 +207,6 @@ exports.noCommonjs = (0, eslint_devkit_1.createRule)({
                             : undefined,
                     });
                 }
-                // Check for module.exports.property = ... (nested)
                 else if (left.type === 'MemberExpression' &&
                     left.object.type === 'MemberExpression' &&
                     left.object.object.type === 'Identifier' &&
@@ -247,7 +234,6 @@ exports.noCommonjs = (0, eslint_devkit_1.createRule)({
                             : undefined,
                     });
                 }
-                // Check for exports.* = ...
                 else if (left.type === 'MemberExpression' &&
                     left.object.type === 'Identifier' &&
                     left.object.name === 'exports' &&
@@ -274,12 +260,10 @@ exports.noCommonjs = (0, eslint_devkit_1.createRule)({
                     });
                 }
             },
-            // Check for TypeScript import = require() syntax
             TSImportEqualsDeclaration(node) {
                 if (shouldAllow() || allowRequire) {
                     return;
                 }
-                // Check if it's import x = require('module')
                 if (node.moduleReference.type === 'TSExternalModuleReference') {
                     context.report({
                         node,
@@ -307,13 +291,11 @@ exports.noCommonjs = (0, eslint_devkit_1.createRule)({
                     });
                 }
             },
-            // Also check for __dirname, __filename which are CommonJS-specific
             Identifier(node) {
                 if (shouldAllow()) {
                     return;
                 }
                 if (node.name === '__dirname' || node.name === '__filename') {
-                    // These are CommonJS globals that don't work in ES modules
                     context.report({
                         node,
                         messageId: 'preferES6',