eslint-plugin-import-next 2.3.7 → 2.3.8

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## [2.3.6] - 2026-05-03
 
+## 2.3.8
+
+### Patch Changes
+
+- [#252](https://github.com/ofri-peretz/eslint/pull/252) [`d67e395`](https://github.com/ofri-peretz/eslint/commit/d67e3953c2748ad36e6aebe0f24b1d04e518b4d0) Thanks [@ofri-peretz](https://github.com/ofri-peretz)! - Fix Codecov badge showing "unknown" — switch from flag to component URL format
+
 ## 2.3.7
 
 ### Patch Changes

package/README.md

@@ -10,7 +10,7 @@
   <a href="https://www.npmjs.com/package/eslint-plugin-import-next" target="_blank"><img src="https://img.shields.io/npm/v/eslint-plugin-import-next.svg" alt="NPM Version" /></a>
   <a href="https://www.npmjs.com/package/eslint-plugin-import-next" target="_blank"><img src="https://img.shields.io/npm/dm/eslint-plugin-import-next.svg" alt="NPM Downloads" /></a>
   <a href="https://opensource.org/licenses/MIT" target="_blank"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="Package License" /></a>
-  <a href="https://app.codecov.io/gh/ofri-peretz/eslint/components?components%5B0%5D=import-next" target="_blank"><img src="https://codecov.io/gh/ofri-peretz/eslint/graph/badge.svg?component=import-next" alt="Codecov" /></a>
+  <a href="https://app.codecov.io/gh/ofri-peretz/eslint/components?components%5B0%5D=eslint-plugin-import-next" target="_blank"><img src="https://codecov.io/gh/ofri-peretz/eslint/graph/badge.svg?component=eslint-plugin-import-next" alt="Codecov" /></a>
   <a href="https://github.com/ofri-peretz/eslint" target="_blank"><img src="https://img.shields.io/badge/Since-Dec_2025-blue?logo=rocket&logoColor=white" alt="Since Dec 2025" /></a>
 </p>
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-import-next",
-  "version": "2.3.7",
+  "version": "2.3.8",
   "description": "Drop-in replacement for eslint-plugin-import. 100x faster no-cycle detection, AI-optimized fixes, zero config migration.",
   "type": "commonjs",
   "main": "./src/index.js",

package/src/index.js

@@ -146,7 +146,7 @@ exports.rules = {
 exports.plugin = {
     meta: {
         name: 'eslint-plugin-import-next',
-        version: '2.3.7',
+        version: '2.3.8',
     },
     rules: exports.rules,
 };

package/src/rules/enforce-dependency-direction.js

@@ -187,32 +187,27 @@ exports.enforceDependencyDirection = (0, eslint_devkit_2.createRule)({
             }
             // For relative imports, check the import path string directly for layer patterns
             // This works for test cases where paths like '../infrastructure/repository' contain the layer
+            // The early return above guarantees importPath starts with '.' here.
             let targetLayer = null;
-            if (importPath.startsWith('.')) {
-                // Check if import path contains layer patterns
-                // e.g., '../infrastructure/repository' -> extract 'infrastructure'
-                const segments = importPath.split(/[/\\]/);
-                for (const segment of segments) {
-                    if (layerPatterns.includes(segment.toLowerCase())) {
-                        targetLayer = segment.toLowerCase();
-                        break;
-                    }
+            // Check if import path contains layer patterns
+            // e.g., '../infrastructure/repository' -> extract 'infrastructure'
+            const segments = importPath.split(/[/\\]/);
+            for (const segment of segments) {
+                if (layerPatterns.includes(segment.toLowerCase())) {
+                    targetLayer = segment.toLowerCase();
+                    break;
                 }
-                // Fallback: try regex matching
-                if (!targetLayer) {
-                    for (const pattern of layerPatterns) {
-                        const regex = new RegExp(`[/\\\\]${pattern}[/\\\\]`, 'i');
-                        if (regex.test(importPath)) {
-                            targetLayer = pattern;
-                            break;
-                        }
+            }
+            // Fallback: try regex matching
+            if (!targetLayer) {
+                for (const pattern of layerPatterns) {
+                    const regex = new RegExp(`[/\\\\]${pattern}[/\\\\]`, 'i');
+                    if (regex.test(importPath)) {
+                        targetLayer = pattern;
+                        break;
                     }
                 }
             }
-            else {
-                // For absolute or external imports, try to extract layer
-                targetLayer = extractLayer(importPath, layerPatterns);
-            }
             const targetOrder = getLayerOrder(targetLayer, layers);
             // Skip if layers are unknown
             if (sourceOrder < 0 || targetOrder < 0) {
@@ -229,8 +224,10 @@ exports.enforceDependencyDirection = (0, eslint_devkit_2.createRule)({
                     node,
                     messageId: 'dependencyDirectionViolation',
                     data: {
-                        sourceLayer: sourceLayer || 'unknown',
-                        targetLayer: targetLayer || 'unknown',
+                        // Both are guaranteed non-null here: sourceOrder/targetOrder >= 0
+                        // implies the layers were resolved (see the guard above).
+                        sourceLayer: sourceLayer,
+                        targetLayer: targetLayer,
                     },
                     suggest: [
                         {

package/src/rules/enforce-import-order.js

@@ -170,23 +170,18 @@ exports.enforceImportOrder = (0, eslint_devkit_1.createRule)({
             return 'external';
         }
         function getGroupRank(importType) {
-            const index = options.groups?.indexOf(importType) ?? -1;
+            const index = options.groups.indexOf(importType);
             return index !== -1 ? index : 999;
         }
         function getExtendedRange(node) {
             let start = node.range[0];
             let end = node.range[1];
             const commentsBefore = sourceCode.getCommentsBefore(node);
-            // Check if comments belong to this import (e.g. on previous lines, not detached)
+            // getCommentsBefore only returns comments strictly between the previous
+            // non-comment token and this node, so they always belong to this import —
+            // include them all in the range.
             if (commentsBefore.length > 0) {
-                const lastComment = commentsBefore[commentsBefore.length - 1];
-                const tokenBefore = sourceCode.getTokenBefore(node);
-                // If comment is between previous token and this node
-                if (!tokenBefore || tokenBefore.range[1] <= lastComment.range[0]) {
-                    // Simple heuristic: include all preceding comments that are contiguous with the import
-                    // This is tricky, but we'll take all commentsBefore for now to be safe
-                    start = commentsBefore[0].range[0];
-                }
+                start = commentsBefore[0].range[0];
             }
             // Include semicolon if present
             const tokenAfter = sourceCode.getTokenAfter(node);

package/src/rules/enforce-team-boundaries.js

@@ -170,10 +170,10 @@ exports.enforceTeamBoundaries = (0, eslint_devkit_1.createRule)({
         if (!sourceTeam) {
             return {};
         }
+        // Narrowed binding: the early return above guarantees sourceTeam is non-null,
+        // and closures cannot rely on that narrowing without re-checking.
+        const owningTeam = sourceTeam;
         function checkImport(node) {
-            // Guard for TypeScript - sourceTeam is checked before this function is registered
-            if (!sourceTeam)
-                return;
             let importPath = null;
             if (node.type === eslint_devkit_1.AST_NODE_TYPES.ImportDeclaration) {
                 importPath = typeof node.source.value === 'string' ? node.source.value : null;
@@ -207,11 +207,11 @@ exports.enforceTeamBoundaries = (0, eslint_devkit_1.createRule)({
                 return;
             }
             // Same team - always allowed
-            if (targetTeam.team === sourceTeam.team) {
+            if (targetTeam.team === owningTeam.team) {
                 return;
             }
             // Check if target team is in allowed dependencies
-            const allowedDeps = sourceTeam.allowedDependencies || [];
+            const allowedDeps = owningTeam.allowedDependencies || [];
             if (allowedDeps.includes(targetTeam.team)) {
                 return;
             }
@@ -220,7 +220,7 @@ exports.enforceTeamBoundaries = (0, eslint_devkit_1.createRule)({
                 node,
                 messageId: 'unauthorizedTeamImport',
                 data: {
-                    sourceTeam: sourceTeam.team,
+                    sourceTeam: owningTeam.team,
                     targetTeam: targetTeam.team,
                     importPath,
                 },

package/src/rules/named.js

@@ -66,12 +66,10 @@ exports.named = (0, eslint_devkit_1.createRule)({
                     const moduleSymbol = checker?.getSymbolAtLocation?.(moduleNode);
                     if (!moduleSymbol)
                         return;
-                    if (moduleSymbol) {
-                        context.report({
-                            node: node.imported,
-                            messageId: 'named',
-                        });
-                    }
+                    context.report({
+                        node: node.imported,
+                        messageId: 'named',
+                    });
                 }
             },
         };

package/src/rules/no-amd.js

@@ -63,7 +63,6 @@ exports.noAmd = (0, eslint_devkit_1.createRule)({
         function shouldAllow() {
             // Check if the call is in an allowed pattern
             return allow.some((pattern) => {
-                /* v8 ignore next -- defensive check, filename always provided by ESLint */
                 if (!filename)
                     return false;
                 // Support glob patterns like **/legacy/**

package/src/rules/no-cross-domain-imports.d.ts

@@ -27,6 +27,14 @@ export interface Options {
     }>;
 }
 type RuleOptions = [Options?];
+/**
+ * Check if import violates domain boundaries
+ */
+export declare function violatesDomainBoundary(sourceFile: string, importPath: string, options: Options): {
+    violates: boolean;
+    sourceDomain: string | null;
+    targetDomain: string | null;
+};
 export declare const noCrossDomainImports: TSESLint.RuleModule<MessageIds, RuleOptions, unknown, TSESLint.RuleListener> & {
     name: string;
 };

package/src/rules/no-cross-domain-imports.js

@@ -6,6 +6,7 @@
  */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.noCrossDomainImports = void 0;
+exports.violatesDomainBoundary = violatesDomainBoundary;
 const eslint_devkit_1 = require("@interlace/eslint-devkit");
 const eslint_devkit_2 = require("@interlace/eslint-devkit");
 const eslint_devkit_3 = require("@interlace/eslint-devkit");
@@ -51,8 +52,9 @@ function violatesDomainBoundary(sourceFile, importPath, options) {
     const sourceDomain = extractDomain(sourceFile, domainPatterns);
     // For relative imports, we need to resolve the path to get the actual target file
     // In tests, we can extract from the import path string directly
+    // The early return above guarantees importPath starts with '.' here.
     let targetDomain = null;
-    if (importPath.startsWith('.')) {
+    {
         // Check if import path contains domain patterns
         // e.g., '../../domains/order/service' -> extract 'order'
         // Try multiple patterns to find the domain
@@ -94,10 +96,6 @@ function violatesDomainBoundary(sourceFile, importPath, options) {
             }
         }
     }
-    else {
-        // For absolute or external imports, try to extract domain
-        targetDomain = extractDomain(importPath, domainPatterns);
-    }
     // If no domain detected, allow
     if (!sourceDomain || !targetDomain) {
         return { violates: false, sourceDomain, targetDomain };

package/src/rules/no-cycle.js

@@ -339,11 +339,6 @@ exports.noCycle = (0, eslint_devkit_1.createRule)({
          */
         function generateMessageData(cycle, strategy, sourceImport) {
             switch (strategy) {
-                case 'module-split':
-                    return {
-                        messageId: 'moduleSplit',
-                        data: generateModuleSplitMessage(cycle),
-                    };
                 case 'direct-import':
                     return {
                         messageId: 'directImport',
@@ -360,6 +355,7 @@ exports.noCycle = (0, eslint_devkit_1.createRule)({
                         data: generateDependencyInjectionMessage(cycle),
                     };
                 default:
+                    // 'module-split' (and the impossible fall-through) both split.
                     return {
                         messageId: 'moduleSplit',
                         data: generateModuleSplitMessage(cycle),

package/src/rules/no-deprecated.js

@@ -159,21 +159,20 @@ exports.noDeprecated = (0, eslint_devkit_1.createRule)({
             // Check for @deprecated decorator in TypeScript
             if ('decorators' in node &&
                 Array.isArray(node.decorators)) {
+                // The Array.isArray guard above proves decorators is an array.
                 const decorators = node.decorators;
-                if (decorators) {
-                    for (const decorator of decorators) {
-                        const dec = decorator;
-                        if ((dec.expression.type === 'CallExpression' &&
-                            dec.expression.callee.type === 'Identifier' &&
-                            dec.expression.callee.name === 'deprecated') ||
-                            (dec.expression.type === 'Identifier' &&
-                                dec.expression.name === 'deprecated')) {
-                            deprecatedItems.set(name, {
-                                location: node,
-                                reason: 'Marked with @deprecated decorator',
-                            });
-                            break;
-                        }
+                for (const decorator of decorators) {
+                    const dec = decorator;
+                    if ((dec.expression.type === 'CallExpression' &&
+                        dec.expression.callee.type === 'Identifier' &&
+                        dec.expression.callee.name === 'deprecated') ||
+                        (dec.expression.type === 'Identifier' &&
+                            dec.expression.name === 'deprecated')) {
+                        deprecatedItems.set(name, {
+                            location: node,
+                            reason: 'Marked with @deprecated decorator',
+                        });
+                        break;
                     }
                 }
             }
@@ -184,6 +183,7 @@ exports.noDeprecated = (0, eslint_devkit_1.createRule)({
             const deprecationInfo = deprecatedItems.get(name);
             if (!deprecationInfo)
                 return;
+            const { replacement } = deprecationInfo;
             context.report({
                 node,
                 messageId: 'deprecatedUsage',
@@ -197,17 +197,16 @@ exports.noDeprecated = (0, eslint_devkit_1.createRule)({
                         ? `Replace with ${deprecationInfo.replacement}`
                         : 'Find modern replacement in documentation',
                 },
-                suggest: deprecationInfo.replacement
+                suggest: replacement
                     ? [
                         {
                             messageId: 'deprecatedUsage',
                             fix(fixer) {
-                                return fixer.replaceText(node, deprecationInfo.replacement ||
-                                    'Check documentation for replacement');
+                                return fixer.replaceText(node, replacement);
                             },
                             data: {
-                                replacement: deprecationInfo.replacement,
-                                suggestion: `Replace with ${deprecationInfo.replacement}`,
+                                replacement,
+                                suggestion: `Replace with ${replacement}`,
                             },
                         },
                     ]
@@ -287,8 +286,9 @@ exports.noDeprecated = (0, eslint_devkit_1.createRule)({
             },
             // Check for usage of deprecated items
             MemberExpression(node) {
+                // No has() pre-check: reportDeprecatedUsage bails out when the
+                // object name has no recorded deprecation info.
                 if (node.object.type === 'Identifier' &&
-                    deprecatedItems.has(node.object.name) &&
                     node.property.type === 'Identifier') {
                     reportDeprecatedUsage(node, node.object.name, `${node.object.name}.${node.property.name}`);
                 }

package/src/rules/no-duplicates.js

@@ -35,13 +35,12 @@ exports.noDuplicates = (0, eslint_devkit_1.createRule)({
         return {
             ImportDeclaration(node) {
                 const source = node.source.value;
-                if (!imports.has(source)) {
-                    imports.set(source, []);
-                }
-                const sourceNodes = imports.get(source);
-                if (sourceNodes) {
-                    sourceNodes.push(node);
+                let sourceNodes = imports.get(source);
+                if (!sourceNodes) {
+                    sourceNodes = [];
+                    imports.set(source, sourceNodes);
                 }
+                sourceNodes.push(node);
             },
             'Program:exit'() {
                 for (const nodes of imports.values()) {

package/src/rules/no-named-as-default-member.js

@@ -56,8 +56,7 @@ exports.noNamedAsDefaultMember = (0, eslint_devkit_1.createRule)({
             },
             MemberExpression(node) {
                 // Check if accessing property of default import
-                if (node.object.type !== eslint_devkit_1.AST_NODE_TYPES.Identifier ||
-                    !defaultImports.has(node.object.name)) {
+                if (node.object.type !== eslint_devkit_1.AST_NODE_TYPES.Identifier) {
                     return;
                 }
                 // Skip computed properties like obj[prop]

package/src/rules/no-named-export.js

@@ -93,21 +93,15 @@ exports.noNamedExport = (0, eslint_devkit_1.createRule)({
                 if (pattern.includes('*')) {
                     const regexStr = '^' + pattern
                         .replace(/[.+?^${}()|[\]\\]/g, (match) => {
-                        if (match === '*')
-                            return '*';
+                        // The char class above never matches '*', so no special-casing needed.
                         return '\\' + match;
                     })
                         .replace(/\*\*/g, '.*')
                         .replace(/\*/g, '[^/]*') + '$';
-                    try {
-                        const regex = new RegExp(regexStr);
-                        const result = regex.test(filename);
-                        // DEBUG LOGIC if needed, but relying on report below
-                        return result;
-                    }
-                    catch {
-                        return false;
-                    }
+                    // regexStr escapes every regex metacharacter before translating
+                    // glob tokens, so new RegExp() can never throw here.
+                    const regex = new RegExp(regexStr);
+                    return regex.test(filename);
                 }
                 return filename.includes(pattern);
             });
@@ -119,19 +113,15 @@ exports.noNamedExport = (0, eslint_devkit_1.createRule)({
                 if (pattern.includes('*')) {
                     const regexStr = '^' + pattern
                         .replace(/[.+?^${}()|[\]\\]/g, (match) => {
-                        if (match === '*')
-                            return '*';
+                        // The char class above never matches '*', so no special-casing needed.
                         return '\\' + match;
                     })
                         .replace(/\*\*/g, '.*')
                         .replace(/\*/g, '[^/]*') + '$';
-                    try {
-                        const regex = new RegExp(regexStr);
-                        return regex.test(filename);
-                    }
-                    catch {
-                        return false;
-                    }
+                    // regexStr escapes every regex metacharacter before translating
+                    // glob tokens, so new RegExp() can never throw here.
+                    const regex = new RegExp(regexStr);
+                    return regex.test(filename);
                 }
                 return filename.includes(pattern);
             });

package/src/rules/no-relative-packages.js

@@ -101,10 +101,10 @@ exports.noRelativePackages = (0, eslint_devkit_1.createRule)({
                         },
                         fix(fixer) {
                             // Calculate the subpath within the package
+                            // subPath is never '' or '.': the package root is found by walking
+                            // UP from the resolved path's parent, so it is a strict ancestor.
                             const subPath = path.relative(importPackageRoot, resolvedPath);
-                            const newImport = subPath && subPath !== '.'
-                                ? `${packageName}/${subPath.replace(/\.[^/.]+$/, '')}`
-                                : packageName;
+                            const newImport = `${packageName}/${subPath.replace(/\.[^/.]+$/, '')}`;
                             return fixer.replaceText(source, `'${newImport}'`);
                         },
                     });