eslint-plugin-harlanzw 0.5.2 → 0.5.4

package/dist/index.mjs

@@ -4,7 +4,7 @@ import process from 'node:process';
 import { TextSourceCodeBase, ConfigCommentParser, Directive, VisitNodeStep } from '@eslint/plugin-kit';
 import { AST_NODE_TYPES } from '@typescript-eslint/utils';
 
-const version = "0.5.2";
+const version = "0.5.4";
 
 const STRENGTH_PATTERNS = {
   strong: ["never", "must", "always", "under no circumstances", "absolutely", "required", "mandatory", "forbidden", "prohibited"],
@@ -641,6 +641,10 @@ function parseFrontmatter(lines) {
   return result;
 }
 
+const COMPILED$8 = AMBIGUOUS_QUANTIFIERS.map((quantifier) => {
+  const escaped = quantifier.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+  return new RegExp(`\\b${escaped}\\b`, "gi");
+});
 const promptAmbiguousQuantifier = {
   meta: {
     type: "suggestion",
@@ -662,8 +666,9 @@ const promptAmbiguousQuantifier = {
           if (shouldSkipLine(i, codeBlockLines, frontmatterEnd))
             continue;
           const line = lines[i];
-          for (const quantifier of AMBIGUOUS_QUANTIFIERS) {
-            const regex = new RegExp(`\\b${quantifier}\\b`, "gi");
+          for (let qi = 0; qi < COMPILED$8.length; qi++) {
+            const regex = COMPILED$8[qi];
+            regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
               const suggestion = QUANTIFIER_SUGGESTIONS[match[0].toLowerCase()] ?? "a specific value";
@@ -689,6 +694,9 @@ const promptAmbiguousQuantifier = {
   }
 };
 
+const COMPILED$7 = UNNECESSARY_ADVERBS.map((adverb) => {
+  return { regex: new RegExp(`\\b${adverb}\\s+`, "gi"), adverb };
+});
 const aiDeslopAdverbs = {
   meta: {
     type: "suggestion",
@@ -711,8 +719,8 @@ const aiDeslopAdverbs = {
             continue;
           const line = lines[i];
           const lineNode = node.children[i];
-          for (const adverb of UNNECESSARY_ADVERBS) {
-            const regex = new RegExp(`\\b${adverb}\\s+`, "gi");
+          for (const { regex, adverb } of COMPILED$7) {
+            regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
               const startOffset = lineNode.position.start.offset + match.index;
@@ -838,7 +846,7 @@ const DEDUPED_ENTRIES = SORTED_ENTRIES$1.filter(([name, url]) => {
   SEEN_URLS.set(url, name);
   return true;
 });
-const COMPILED$1 = DEDUPED_ENTRIES.map(([name, url]) => {
+const COMPILED$6 = DEDUPED_ENTRIES.map(([name, url]) => {
   const escaped = name.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
   return { name, url, regex: new RegExp(`(?<!\\[)\\b${escaped}\\b(?!\\])(?!\\()`, "g") };
 });
@@ -867,7 +875,7 @@ const aiDeslopAutolink = {
           if (line.trimStart().startsWith("#"))
             continue;
           const lineNode = node.children[i];
-          for (const { name, url, regex } of COMPILED$1) {
+          for (const { name, url, regex } of COMPILED$6) {
             if (linkedUrls.has(url))
               continue;
             regex.lastIndex = 0;
@@ -909,6 +917,10 @@ const aiDeslopAutolink = {
 };
 
 const SORTED_PHRASES = Object.entries(BUZZWORD_PHRASES).sort((a, b) => b[0].length - a[0].length);
+const COMPILED$5 = SORTED_PHRASES.map(([phrase, replacement]) => {
+  const escaped = phrase.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+  return { regex: new RegExp(`\\b${escaped}\\b`, "gi"), phrase, replacement };
+});
 const aiDeslopBuzzwords = {
   meta: {
     type: "suggestion",
@@ -932,9 +944,8 @@ const aiDeslopBuzzwords = {
           const line = lines[i];
           const lineNode = node.children[i];
           const matched = [];
-          for (const [phrase, replacement] of SORTED_PHRASES) {
-            const escaped = phrase.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
-            const regex = new RegExp(`\\b${escaped}\\b`, "gi");
+          for (const { regex, replacement } of COMPILED$5) {
+            regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
               const matchStart = match.index;
@@ -1294,7 +1305,7 @@ const CASING_DICTIONARY = {
 };
 
 const SORTED_ENTRIES = Object.entries(CASING_DICTIONARY).sort((a, b) => b[0].length - a[0].length);
-const COMPILED = SORTED_ENTRIES.map(([key, correct]) => {
+const COMPILED$4 = SORTED_ENTRIES.map(([key, correct]) => {
   const escaped = key.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
   return { regex: new RegExp(`\\b${escaped}\\b`, "gi"), correct };
 });
@@ -1321,7 +1332,7 @@ const aiDeslopCasing = {
           const line = lines[i];
           const lineNode = node.children[i];
           const matched = [];
-          for (const { regex, correct } of COMPILED) {
+          for (const { regex, correct } of COMPILED$4) {
             regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
@@ -1353,6 +1364,10 @@ const aiDeslopCasing = {
   }
 };
 
+const COMPILED$3 = FILLER_PHRASES.map((phrase) => {
+  const escaped = phrase.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+  return { regex: new RegExp(`\\b${escaped}\\s*,?\\s*`, "gi"), phrase };
+});
 const aiDeslopFiller = {
   meta: {
     type: "suggestion",
@@ -1375,8 +1390,8 @@ const aiDeslopFiller = {
             continue;
           const line = lines[i];
           const lineNode = node.children[i];
-          for (const phrase of FILLER_PHRASES) {
-            const regex = new RegExp(`\\b${phrase}\\s*,?\\s*`, "gi");
+          for (const { regex, phrase } of COMPILED$3) {
+            regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
               const startOffset = lineNode.position.start.offset + match.index;
@@ -1412,6 +1427,10 @@ const aiDeslopFiller = {
   }
 };
 
+const COMPILED$2 = HEDGING_WORDS.map((word) => {
+  const escaped = word.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+  return { regex: new RegExp(`\\b${escaped}\\s+`, "gi"), word };
+});
 const aiDeslopHedging = {
   meta: {
     type: "suggestion",
@@ -1434,9 +1453,8 @@ const aiDeslopHedging = {
             continue;
           const line = lines[i];
           const lineNode = node.children[i];
-          for (const word of HEDGING_WORDS) {
-            const escaped = word.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
-            const regex = new RegExp(`\\b${escaped}\\s+`, "gi");
+          for (const { regex, word } of COMPILED$2) {
+            regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
               const startOffset = lineNode.position.start.offset + match.index;
@@ -1902,6 +1920,10 @@ const poorlyTokenized = [
   /\w{20,}/g,
   /\d{10,}/g
 ];
+const COMPILED_PHRASES = Object.entries(INEFFICIENT_PHRASES).map(([phrase, replacement]) => {
+  const escaped = phrase.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+  return { regex: new RegExp(`\\b${escaped}\\b`, "gi"), replacement };
+});
 const promptInefficientToken = {
   meta: {
     type: "suggestion",
@@ -1927,9 +1949,9 @@ const promptInefficientToken = {
           const lineNode = node.children[i];
           const reported = /* @__PURE__ */ new Set();
           for (const pattern of poorlyTokenized) {
-            const regex = new RegExp(pattern.source, pattern.flags);
+            pattern.lastIndex = 0;
             let match;
-            while ((match = regex.exec(line)) !== null) {
+            while ((match = pattern.exec(line)) !== null) {
               const key = `${match.index}:${match[0].length}`;
               if (reported.has(key))
                 continue;
@@ -1945,8 +1967,8 @@ const promptInefficientToken = {
               });
             }
           }
-          for (const [phrase, replacement] of Object.entries(INEFFICIENT_PHRASES)) {
-            const regex = new RegExp(`\\b${phrase}\\b`, "gi");
+          for (const { regex, replacement } of COMPILED_PHRASES) {
+            regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
               const startOffset = lineNode.position.start.offset + match.index;
@@ -2194,9 +2216,9 @@ const promptRedundantInstruction = {
         for (let i = 0; i < lines.length; i++) {
           if (shouldSkipLine(i, codeBlockLines, frontmatterEnd))
             continue;
-          const regex = new RegExp(instructionRegex.source, instructionRegex.flags);
+          instructionRegex.lastIndex = 0;
           let match;
-          while ((match = regex.exec(lines[i])) !== null) {
+          while ((match = instructionRegex.exec(lines[i])) !== null) {
             const normalized = match[1].toLowerCase().trim().replace(/\s+/g, " ");
             if (normalized.length > 10) {
               const existing = instructionPatterns.get(normalized) ?? [];
@@ -2568,9 +2590,9 @@ const promptUndefinedVariable = {
             continue;
           const line = lines[i];
           for (const defPattern of definitionPatterns) {
-            const regex = new RegExp(defPattern.source, defPattern.flags);
+            defPattern.lastIndex = 0;
             let match2;
-            while ((match2 = regex.exec(line)) !== null)
+            while ((match2 = defPattern.exec(line)) !== null)
               definedVars.add(match2[1].toLowerCase());
           }
           const varRegex = /\{\{(\w+)\}\}/g;
@@ -2629,9 +2651,9 @@ const promptUnresolvedReference = {
             continue;
           const line = lines[i];
           for (const pattern of unresolvedPatterns) {
-            const regex = new RegExp(pattern.source, pattern.flags);
+            pattern.lastIndex = 0;
             let match;
-            while ((match = regex.exec(line)) !== null) {
+            while ((match = pattern.exec(line)) !== null) {
               context.report({
                 loc: {
                   start: { line: i + 1, column: match.index + 1 },
@@ -2648,6 +2670,9 @@ const promptUnresolvedReference = {
   }
 };
 
+const COMPILED$1 = VAGUE_TERMS.map((term) => {
+  return new RegExp(`\\bbe ${term}\\b|\\bin a ${term}\\b`, "gi");
+});
 const promptVagueTerm = {
   meta: {
     type: "suggestion",
@@ -2668,8 +2693,9 @@ const promptVagueTerm = {
           if (shouldSkipLine(i, codeBlockLines, frontmatterEnd))
             continue;
           const line = lines[i];
-          for (const term of VAGUE_TERMS) {
-            const regex = new RegExp(`\\bbe ${term}\\b|\\bin a ${term}\\b`, "gi");
+          for (let vi = 0; vi < COMPILED$1.length; vi++) {
+            const regex = COMPILED$1[vi];
+            regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
               context.report({
@@ -2688,6 +2714,10 @@ const promptVagueTerm = {
   }
 };
 
+const COMPILED = STRENGTH_PATTERNS.weak.map((pattern) => {
+  const escaped = pattern.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+  return new RegExp(`\\b${escaped}\\b`, "gi");
+});
 const promptWeakInstruction = {
   meta: {
     type: "suggestion",
@@ -2709,8 +2739,9 @@ const promptWeakInstruction = {
           if (shouldSkipLine(i, codeBlockLines, frontmatterEnd))
             continue;
           const line = lines[i];
-          for (const pattern of STRENGTH_PATTERNS.weak) {
-            const regex = new RegExp(`\\b${pattern}\\b`, "gi");
+          for (let wi = 0; wi < COMPILED.length; wi++) {
+            const regex = COMPILED[wi];
+            regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
               const suggestion = WEAK_TO_STRONG[match[0].toLowerCase()] ?? "Must";
@@ -2778,12 +2809,21 @@ function hasJsxExternalAttr(attrs) {
     (a) => a.type === "JSXAttribute" && a.name?.name === "external"
   );
 }
+const excludeCache = /* @__PURE__ */ new Map();
+function getExcludeRegex(pattern) {
+  let regex = excludeCache.get(pattern);
+  if (!regex) {
+    regex = new RegExp(pattern);
+    excludeCache.set(pattern, regex);
+  }
+  return regex;
+}
 function shouldSkipLink(url, node, options) {
   if (options.ignoreExternal && (isExternalUrl(url) || hasExternalAttr(node)))
     return true;
   if (options.exclude?.length) {
     for (const pattern of options.exclude) {
-      if (new RegExp(pattern).test(url))
+      if (getExcludeRegex(pattern).test(url))
         return true;
     }
   }
@@ -2794,7 +2834,7 @@ function shouldSkipJsxLink(url, attrs, options) {
     return true;
   if (options.exclude?.length) {
     for (const pattern of options.exclude) {
-      if (new RegExp(pattern).test(url))
+      if (getExcludeRegex(pattern).test(url))
         return true;
     }
   }
@@ -2883,16 +2923,6 @@ function isReturned(node) {
   }
   return false;
 }
-function isInFunction(node) {
-  let parent = node.parent;
-  while (parent) {
-    if (parent.type === "FunctionDeclaration" || parent.type === "FunctionExpression" || parent.type === "ArrowFunctionExpression") {
-      return true;
-    }
-    parent = parent.parent;
-  }
-  return false;
-}
 function isInAsyncFunction(node) {
   let parent = node.parent;
   while (parent) {
@@ -2906,18 +2936,18 @@ function isInAsyncFunction(node) {
 function isFunctionCall(node, functionName) {
   return node.callee.type === "Identifier" && node.callee.name === functionName;
 }
-function isAtTopLevel(node) {
+function getNodeScope(node) {
   let parent = node.parent;
   while (parent) {
-    if (parent.type === "Program") {
-      return true;
-    }
     if (parent.type === "FunctionDeclaration" || parent.type === "FunctionExpression" || parent.type === "ArrowFunctionExpression") {
-      return false;
+      return { atTopLevel: false, inFunction: true };
+    }
+    if (parent.type === "Program") {
+      return { atTopLevel: true, inFunction: false };
     }
     parent = parent.parent;
   }
-  return false;
+  return { atTopLevel: false, inFunction: false };
 }
 function isCallExpression(node) {
   return node.type === "CallExpression";
@@ -3109,17 +3139,15 @@ function isReactivityCall(node, vueImports) {
   }
   return false;
 }
+const COMPOSABLE_RE = /^use[A-Z_]/;
 function isComposableCall(node) {
   if (node.callee.type === "Identifier") {
-    return /^use[A-Z_]/.test(node.callee.name);
+    return COMPOSABLE_RE.test(node.callee.name);
   }
   return false;
 }
 function isComposableName(name) {
-  return /^use[A-Z_]/.test(name);
-}
-function isInVueScriptSetup(node) {
-  return isAtTopLevel(node);
+  return COMPOSABLE_RE.test(name);
 }
 function isDefinePropsCall(node) {
   return node.callee.type === "Identifier" && node.callee.name === "defineProps";
@@ -3963,9 +3991,8 @@ const nuxtAwaitNavigateTo = createEslintRule({
         if (!isFunctionCall(node, "navigateTo")) {
           return;
         }
-        const inFunction = isInFunction(node);
-        const inVueScriptSetup = isInVueScriptSetup(node);
-        if (inVueScriptSetup && !inFunction) {
+        const { inFunction, atTopLevel: inVueScriptSetup } = getNodeScope(node);
+        if (inVueScriptSetup) {
           if (!isAwaited(node)) {
             context.report({
               node,
@@ -4481,9 +4508,8 @@ ${indent}})`;
         if (!isSideEffectCall(node)) {
           return;
         }
-        const inVueScriptSetup = isInVueScriptSetup(node);
-        const inFunction = isInFunction(node);
-        if (inVueScriptSetup && !inFunction) {
+        const { atTopLevel } = getNodeScope(node);
+        if (atTopLevel) {
           const functionName = node.callee.type === "Identifier" ? node.callee.name : "unknown";
           reportSideEffect(node, functionName);
         }
@@ -4492,9 +4518,8 @@ ${indent}})`;
         if (node.callee.type !== "Identifier" || !SIDE_EFFECT_FUNCTIONS.has(node.callee.name)) {
           return;
         }
-        const inVueScriptSetup = isInVueScriptSetup(node);
-        const inFunction = isInFunction(node);
-        if (inVueScriptSetup && !inFunction) {
+        const { atTopLevel } = getNodeScope(node);
+        if (atTopLevel) {
           const functionName = node.callee.type === "Identifier" ? node.callee.name : "unknown";
           reportSideEffect(node, functionName);
         }
@@ -5317,6 +5342,8 @@ const vueNoTorefsOnProps = createEslintRule({
 });
 
 const RULE_NAME = "vue-require-composable-prefix";
+const DEFINE_RE = /^define[A-Z]/;
+const CREATE_RE = /^create[A-Z]/;
 const vueRequireComposablePrefix = createEslintRule({
   name: RULE_NAME,
   meta: {
@@ -5340,7 +5367,7 @@ const vueRequireComposablePrefix = createEslintRule({
     const candidateFunctions = /* @__PURE__ */ new Map();
     const { hasReactivityInStatement, hasReactivityInExpression } = createReactivityChecker(vueImports, nonVueImports);
     function isExcludedName(name) {
-      return /^define[A-Z]/.test(name) || /^create[A-Z]/.test(name) || name === "setup";
+      return DEFINE_RE.test(name) || CREATE_RE.test(name) || name === "setup";
     }
     function checkFunctionForReactivity(functionNode, idNode, functionName) {
       if (!functionNode.body)
@@ -5531,6 +5558,7 @@ plugin.configs["prompt:skill"] = [
     }
   }
 ];
+const CODE_IGNORES = [".claude/**", ".cursor/**", ".github/copilot-instructions.md"];
 const deslopRules = {
   "harlanzw/ai-deslop-buzzwords": "error",
   "harlanzw/ai-deslop-casing": "error",
@@ -5546,6 +5574,7 @@ plugin.configs.content = [
   {
     name: "harlanzw/content",
     files: CONTENT_FILES,
+    ignores: CODE_IGNORES,
     language: "harlanzw/prompt",
     plugins: { harlanzw: plugin },
     rules: deslopRules
@@ -5565,6 +5594,7 @@ plugin.configs.link = [
   {
     name: "harlanzw/link",
     files: LINK_FILES,
+    ignores: CODE_IGNORES,
     plugins: { harlanzw: plugin },
     rules: {
       "harlanzw/link-ascii-only": "warn",
@@ -5583,6 +5613,7 @@ plugin.configs.nuxt = [
   {
     name: "harlanzw/nuxt",
     files: NUXT_VUE_FILES,
+    ignores: CODE_IGNORES,
     plugins: { harlanzw: plugin },
     rules: {
       "harlanzw/nuxt-await-navigate-to": "error",
@@ -5600,6 +5631,7 @@ plugin.configs.vue = [
   {
     name: "harlanzw/vue",
     files: NUXT_VUE_FILES,
+    ignores: CODE_IGNORES,
     plugins: { harlanzw: plugin },
     rules: {
       "harlanzw/vue-no-faux-composables": "error",
@@ -5650,6 +5682,7 @@ function harlanzw(options = {}, ...extraConfigs) {
     configs.push({
       name: "harlanzw/link",
       files: LINK_FILES,
+      ignores: CODE_IGNORES,
       plugins: { harlanzw: plugin },
       rules: buildLinkRules(linkOpts)
     });

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-harlanzw",
   "type": "module",
-  "version": "0.5.2",
+  "version": "0.5.4",
   "description": "Harlan's opinionated ESLint rules",
   "author": "Harlan Wilton <harlan@harlanzw.com>",
   "license": "MIT",