eslint-plugin-harlanzw 0.16.0 → 0.17.0

package/README.md

@@ -76,6 +76,7 @@ The rules are organized into the following categories:
 | [`ai-deslop-buzzwords`](./src/prompt/rules/deslop-buzzwords.ts) | replace AI-generated buzzword phrases with simpler alternatives (e.g. "leverage" → "use") |
 | [`ai-deslop-casing`](./src/prompt/rules/deslop-casing.ts) | enforce correct casing for tech terms, brands, and abbreviations (e.g. "github" → "GitHub") |
 | [`ai-deslop-false-dichotomy`](./src/prompt/rules/deslop-false-dichotomy.ts) | flag "it's not X, it's Y" contrast patterns common in AI writing |
+| [`ai-deslop-false-sincerity`](./src/prompt/rules/deslop-false-sincerity.ts) | remove false-sincerity openers that pad sentences ("honestly", "frankly", "in all honesty") |
 | [`ai-deslop-filler`](./src/prompt/rules/deslop-filler.ts) | remove AI-generated filler sentences and phrases (e.g. "it's worth noting that") |
 | [`ai-deslop-hedging`](./src/prompt/rules/deslop-hedging.ts) | remove hedging/qualifying words that weaken copy (e.g. "very", "really", "quite", "just") |
 | [`ai-deslop-no-em-dash`](./src/prompt/rules/deslop-no-em-dash.ts) | replace em dashes in content prose |
@@ -211,6 +212,7 @@ export default [
 | `ai-deslop-casing` | Fixes tech term casing using a 300+ term dictionary ("github" → "GitHub", "typescript" → "TypeScript") |
 | `ai-deslop-autolink` | Links first mention of tech terms to their canonical URLs ("Nuxt" → `[Nuxt](https://nuxt.com)`) |
 | `ai-deslop-false-dichotomy` | Flags "it's not X, it's Y" false contrast patterns |
+| `ai-deslop-false-sincerity` | Strips false-sincerity openers ("honestly", "frankly", "in all honesty", "let's be real") |
 | `ai-deslop-hedging` | Strips hedging words that weaken copy ("very", "really", "quite", "just", "somewhat") |
 | `ai-deslop-no-em-dash` | Replaces em dashes in content prose |
 | `ai-deslop-no-exclamation` | Replaces exclamation marks with periods in content prose |

package/dist/index.mjs

@@ -4,7 +4,7 @@ import process from 'node:process';
 import { TextSourceCodeBase, ConfigCommentParser, Directive, VisitNodeStep } from '@eslint/plugin-kit';
 import { AST_NODE_TYPES } from '@typescript-eslint/utils';
 
-const version = "0.16.0";
+const version = "0.17.0";
 
 const STRENGTH_PATTERNS = {
   strong: ["never", "must", "always", "under no circumstances", "absolutely", "required", "mandatory", "forbidden", "prohibited"],
@@ -356,6 +356,17 @@ const FILLER_PHRASES = [
   "to summarize",
   "to sum up"
 ];
+const FALSE_SINCERITY_OPENERS = [
+  "honestly",
+  "frankly",
+  "in all honesty",
+  "in all fairness",
+  "to be frank",
+  "let's be real",
+  "if i'm honest",
+  "if i'm being honest",
+  "if we're being honest"
+];
 const UNNECESSARY_ADVERBS = [
   "fundamentally",
   "essentially",
@@ -718,7 +729,7 @@ function parseFrontmatter(lines) {
 }
 
 const REGEX_1$u = /[.*+?^${}()|[\]\\]/g;
-const COMPILED$8 = AMBIGUOUS_QUANTIFIERS.map((quantifier) => {
+const COMPILED$9 = AMBIGUOUS_QUANTIFIERS.map((quantifier) => {
   const escaped = quantifier.replace(REGEX_1$u, "\\$&");
   return new RegExp(`\\b${escaped}\\b`, "gi");
 });
@@ -743,8 +754,8 @@ const promptAmbiguousQuantifier = {
           if (shouldSkipLine(i, codeBlockLines, frontmatterEnd))
             continue;
           const line = lines[i];
-          for (let qi = 0; qi < COMPILED$8.length; qi++) {
-            const regex = COMPILED$8[qi];
+          for (let qi = 0; qi < COMPILED$9.length; qi++) {
+            const regex = COMPILED$9[qi];
             regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
@@ -773,7 +784,7 @@ const promptAmbiguousQuantifier = {
 
 const REGEX_2$d = /^[-*>\s#\d.]+$/;
 const REGEX_1$t = /\.\s+$/;
-const COMPILED$7 = UNNECESSARY_ADVERBS.map((adverb) => {
+const COMPILED$8 = UNNECESSARY_ADVERBS.map((adverb) => {
   return { regex: new RegExp(`\\b${adverb}\\s+`, "gi"), adverb };
 });
 const aiDeslopAdverbs = {
@@ -799,7 +810,7 @@ const aiDeslopAdverbs = {
           const line = lines[i];
           const lineNode = node.children[i];
           const scopes = parseLineScopes(line);
-          for (const { regex, adverb } of COMPILED$7) {
+          for (const { regex, adverb } of COMPILED$8) {
             regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
@@ -940,7 +951,7 @@ const DEDUPED_ENTRIES = SORTED_ENTRIES$1.filter(([name, url]) => {
   SEEN_URLS.set(url, name);
   return true;
 });
-const COMPILED$6 = DEDUPED_ENTRIES.map(([name, url]) => {
+const COMPILED$7 = DEDUPED_ENTRIES.map(([name, url]) => {
   const escaped = name.replace(REGEX_3$7, "\\$&");
   return { name, url, regex: new RegExp(`(?<=\\s|^)${escaped}(?=\\s|$|[.,;:!?)])`, "g") };
 });
@@ -963,7 +974,7 @@ const aiDeslopAutolink = {
         const codeBlockLines = getCodeBlockLines(lines);
         const frontmatterEnd = getFrontmatterEnd(lines);
         const linkedUrls = /* @__PURE__ */ new Set();
-        const allUrls = new Set(COMPILED$6.map((c) => c.url));
+        const allUrls = new Set(COMPILED$7.map((c) => c.url));
         for (const line of lines) {
           LINK_URL_RE.lastIndex = 0;
           let urlMatch;
@@ -982,7 +993,7 @@ const aiDeslopAutolink = {
             continue;
           const lineNode = node.children[i];
           const scopes = parseLineScopes(line);
-          for (const { name, url, regex } of COMPILED$6) {
+          for (const { name, url, regex } of COMPILED$7) {
             if (linkedUrls.has(url))
               continue;
             regex.lastIndex = 0;
@@ -1028,7 +1039,7 @@ const REGEX_3$6 = /[.*+?^${}()|[\]\\]/g;
 const REGEX_2$b = /^[-*>\s#\d.]+$/;
 const REGEX_1$r = /\.\s+$/;
 const SORTED_PHRASES = Object.entries(BUZZWORD_PHRASES).sort((a, b) => b[0].length - a[0].length);
-const COMPILED$5 = SORTED_PHRASES.map(([phrase, replacement]) => {
+const COMPILED$6 = SORTED_PHRASES.map(([phrase, replacement]) => {
   const escaped = phrase.replace(REGEX_3$6, "\\$&");
   return { regex: new RegExp(`\\b${escaped}\\b`, "gi"), phrase, replacement };
 });
@@ -1056,7 +1067,7 @@ const aiDeslopBuzzwords = {
           const lineNode = node.children[i];
           const scopes = parseLineScopes(line);
           const matched = [];
-          for (const { regex, replacement } of COMPILED$5) {
+          for (const { regex, replacement } of COMPILED$6) {
             regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
@@ -1433,7 +1444,7 @@ const CASING_DICTIONARY = {
 
 const REGEX_1$q = /[.*+?^${}()|[\]\\]/g;
 const SORTED_ENTRIES = Object.entries(CASING_DICTIONARY).sort((a, b) => b[0].length - a[0].length);
-const COMPILED$4 = SORTED_ENTRIES.map(([key, correct]) => {
+const COMPILED$5 = SORTED_ENTRIES.map(([key, correct]) => {
   const escaped = key.replace(REGEX_1$q, "\\$&");
   return { regex: new RegExp(`\\b${escaped}\\b`, "gi"), correct };
 });
@@ -1461,7 +1472,7 @@ const aiDeslopCasing = {
           const lineNode = node.children[i];
           const scopes = parseLineScopes(line);
           const matched = [];
-          for (const { regex, correct } of COMPILED$4) {
+          for (const { regex, correct } of COMPILED$5) {
             regex.lastIndex = 0;
             let match;
             while ((match = regex.exec(line)) !== null) {
@@ -1557,12 +1568,12 @@ const aiDeslopCodeLang = {
   }
 };
 
-const APOSTROPHE = `(?:'|\u2019)`;
-const SUBJECT_NOT = `(?:it${APOSTROPHE}s|it is|they${APOSTROPHE}re|they are|we${APOSTROPHE}re|we are|you${APOSTROPHE}re|you are|this is|that is|is|are)`;
-const SUBJECT_IS = `(?:it${APOSTROPHE}s|it is|they${APOSTROPHE}re|they are|we${APOSTROPHE}re|we are|you${APOSTROPHE}re|you are|this is|that is|is|are)`;
-const CONTRACTION_NOT = `(?:isn${APOSTROPHE}t|aren${APOSTROPHE}t|wasn${APOSTROPHE}t|weren${APOSTROPHE}t)`;
-const NO_LONGER = `(?:is|it${APOSTROPHE}s|was)`;
-const PATTERN = new RegExp(`\\b${SUBJECT_NOT}\\s+not\\b.{1,80}?\\b${SUBJECT_IS}\\b|\\b${CONTRACTION_NOT}\\s+(?:just\\s+)?about\\b.{1,80}?\\b(?:it${APOSTROPHE}s|is)\\s+about\\b|\\b${NO_LONGER}\\s+no\\s+longer\\b.{1,60}?\\b(?:it${APOSTROPHE}s|is)\\b`, "i");
+const APOSTROPHE$1 = `(?:'|\u2019)`;
+const SUBJECT_NOT = `(?:it${APOSTROPHE$1}s|it is|they${APOSTROPHE$1}re|they are|we${APOSTROPHE$1}re|we are|you${APOSTROPHE$1}re|you are|this is|that is|is|are)`;
+const SUBJECT_IS = `(?:it${APOSTROPHE$1}s|it is|they${APOSTROPHE$1}re|they are|we${APOSTROPHE$1}re|we are|you${APOSTROPHE$1}re|you are|this is|that is|is|are)`;
+const CONTRACTION_NOT = `(?:isn${APOSTROPHE$1}t|aren${APOSTROPHE$1}t|wasn${APOSTROPHE$1}t|weren${APOSTROPHE$1}t)`;
+const NO_LONGER = `(?:is|it${APOSTROPHE$1}s|was)`;
+const PATTERN = new RegExp(`\\b${SUBJECT_NOT}\\s+not\\b.{1,80}?\\b${SUBJECT_IS}\\b|\\b${CONTRACTION_NOT}\\s+(?:just\\s+)?about\\b.{1,80}?\\b(?:it${APOSTROPHE$1}s|is)\\s+about\\b|\\b${NO_LONGER}\\s+no\\s+longer\\b.{1,60}?\\b(?:it${APOSTROPHE$1}s|is)\\b`, "i");
 const aiDeslopFalseDichotomy = {
   meta: {
     type: "suggestion",
@@ -1604,6 +1615,78 @@ const aiDeslopFalseDichotomy = {
   }
 };
 
+const REGEX_ESCAPE = /[.*+?^${}()|[\]\\]/g;
+const APOSTROPHE = /\\'/g;
+const SENTENCE_START_PREFIX = /^[-*>\s#\d.]+$/;
+const SENTENCE_END = /[.:!?]\s+$/;
+const COMPILED$4 = FALSE_SINCERITY_OPENERS.map((opener) => {
+  const escaped = opener.replace(REGEX_ESCAPE, "\\$&").replace(APOSTROPHE, `['\u2019]`);
+  return { regex: new RegExp(`\\b${escaped}\\b\\s*,?\\s*`, "gi"), opener };
+});
+const aiDeslopFalseSincerity = {
+  meta: {
+    type: "suggestion",
+    docs: { description: "Remove false-sincerity openers that pad the sentence without adding meaning" },
+    fixable: "code",
+    schema: [],
+    messages: {
+      falseSincerity: 'False-sincerity opener: "{{found}}". It signals nothing. State the point.'
+    }
+  },
+  create(context) {
+    return {
+      document(node) {
+        const sourceCode = context.sourceCode;
+        const lines = sourceCode.lines;
+        const codeBlockLines = getCodeBlockLines(lines);
+        const frontmatterEnd = getFrontmatterEnd(lines);
+        for (let i = 0; i < lines.length; i++) {
+          if (shouldSkipLine(i, codeBlockLines, frontmatterEnd))
+            continue;
+          const line = lines[i];
+          const lineNode = node.children[i];
+          const scopes = parseLineScopes(line);
+          for (const { regex, opener } of COMPILED$4) {
+            regex.lastIndex = 0;
+            let match;
+            while ((match = regex.exec(line)) !== null) {
+              const textBefore = line.slice(0, match.index);
+              const isAtSentenceStart = match.index === 0 || SENTENCE_START_PREFIX.test(textBefore) || SENTENCE_END.test(textBefore);
+              if (!isAtSentenceStart)
+                continue;
+              if (isInsideCompoundIdentifier(line, match.index, match.index + match[0].length))
+                continue;
+              if (isInScope(scopes, match.index, match.index + match[0].length, ["code", "link-url"]))
+                continue;
+              const startOffset = lineNode.position.start.offset + match.index;
+              const endOffset = startOffset + match[0].length;
+              const afterMatch = line.slice(match.index + match[0].length);
+              context.report({
+                loc: {
+                  start: { line: i + 1, column: match.index + 1 },
+                  end: { line: i + 1, column: match.index + match[0].length + 1 }
+                },
+                messageId: "falseSincerity",
+                data: { found: opener },
+                fix(fixer) {
+                  const nextChar = afterMatch[0];
+                  if (nextChar >= "a" && nextChar <= "z") {
+                    return [
+                      fixer.replaceTextRange([startOffset, endOffset], ""),
+                      fixer.replaceTextRange([endOffset, endOffset + 1], nextChar.toUpperCase())
+                    ];
+                  }
+                  return fixer.replaceTextRange([startOffset, endOffset], "");
+                }
+              });
+            }
+          }
+        }
+      }
+    };
+  }
+};
+
 const REGEX_3$5 = /[.*+?^${}()|[\]\\]/g;
 const REGEX_2$a = /^[-*>\s#\d.]+$/;
 const REGEX_1$p = /\.\s+$/;
@@ -4963,18 +5046,18 @@ const SIDE_EFFECT_PATTERNS = /* @__PURE__ */ new Set([
   "requestAnimationFrame",
   "requestIdleCallback"
 ]);
-const RECEIVER_SCOPED_METHODS = {
+const RECEIVER_SCOPED_METHODS = /* @__PURE__ */ new Map([
   // Navigation — only on router instances
-  push: /* @__PURE__ */ new Set(["router", "$router"]),
-  replace: /* @__PURE__ */ new Set(["router", "$router"]),
-  go: /* @__PURE__ */ new Set(["router", "$router"]),
-  back: /* @__PURE__ */ new Set(["router", "$router"]),
-  forward: /* @__PURE__ */ new Set(["router", "$router"]),
+  ["push", /* @__PURE__ */ new Set(["router", "$router"])],
+  ["replace", /* @__PURE__ */ new Set(["router", "$router"])],
+  ["go", /* @__PURE__ */ new Set(["router", "$router"])],
+  ["back", /* @__PURE__ */ new Set(["router", "$router"])],
+  ["forward", /* @__PURE__ */ new Set(["router", "$router"])],
   // Analytics — only on analytics/tracking objects
-  track: /* @__PURE__ */ new Set(["analytics", "mixpanel", "segment"]),
-  identify: /* @__PURE__ */ new Set(["analytics", "mixpanel", "segment"]),
-  page: /* @__PURE__ */ new Set(["analytics", "mixpanel", "segment"])
-};
+  ["track", /* @__PURE__ */ new Set(["analytics", "mixpanel", "segment"])],
+  ["identify", /* @__PURE__ */ new Set(["analytics", "mixpanel", "segment"])],
+  ["page", /* @__PURE__ */ new Set(["analytics", "mixpanel", "segment"])]
+]);
 const SIDE_EFFECT_RECEIVERS = /* @__PURE__ */ new Set([
   "console",
   "gtag",
@@ -4999,7 +5082,7 @@ function isSideEffectInHandler(node) {
       const method = node.callee.property.name;
       if (SIDE_EFFECT_PATTERNS.has(method))
         return true;
-      const allowedReceivers = RECEIVER_SCOPED_METHODS[method];
+      const allowedReceivers = RECEIVER_SCOPED_METHODS.get(method);
       if (allowedReceivers && node.callee.object.type === "Identifier" && allowedReceivers.has(node.callee.object.name))
         return true;
       if (node.callee.object.type === "Identifier" && SIDE_EFFECT_RECEIVERS.has(node.callee.object.name))
@@ -6993,6 +7076,7 @@ const plugin = {
     "ai-deslop-casing": aiDeslopCasing,
     "ai-deslop-code-lang": aiDeslopCodeLang,
     "ai-deslop-false-dichotomy": aiDeslopFalseDichotomy,
+    "ai-deslop-false-sincerity": aiDeslopFalseSincerity,
     "ai-deslop-filler": aiDeslopFiller,
     "ai-deslop-frontmatter-spacing": aiDeslopFrontmatterSpacing,
     "ai-deslop-hedging": aiDeslopHedging,
@@ -7120,6 +7204,7 @@ const deslopRules = {
   "harlanzw/ai-deslop-buzzwords": "error",
   "harlanzw/ai-deslop-casing": "error",
   "harlanzw/ai-deslop-false-dichotomy": "warn",
+  "harlanzw/ai-deslop-false-sincerity": "error",
   "harlanzw/ai-deslop-filler": "error",
   "harlanzw/ai-deslop-adverbs": "error",
   "harlanzw/ai-deslop-hedging": "warn",
@@ -7319,13 +7404,14 @@ function harlanzw(options = {}, ...extraConfigs) {
 }
 function detectFramework() {
   const cwd = process.cwd();
-  const nuxt = existsSync(resolve(cwd, "nuxt.config.ts")) || existsSync(resolve(cwd, "nuxt.config.js"));
+  let nuxt = existsSync(resolve(cwd, "nuxt.config.ts")) || existsSync(resolve(cwd, "nuxt.config.js"));
   let vue = nuxt;
-  if (!vue) {
+  if (!vue || !nuxt) {
     try {
       const pkg = JSON.parse(readFileSync(resolve(cwd, "package.json"), "utf-8"));
       const deps = { ...pkg.dependencies, ...pkg.devDependencies };
-      vue = !!(deps.vue || deps.nuxt);
+      nuxt = nuxt || !!deps.nuxt;
+      vue = vue || !!(deps.vue || deps.nuxt);
     } catch {
     }
   }

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "eslint-plugin-harlanzw",
   "type": "module",
-  "version": "0.16.0",
+  "version": "0.17.0",
   "description": "Harlan's opinionated ESLint rules",
   "author": "Harlan Wilton <harlan@harlanzw.com>",
   "license": "MIT",
-  "funding": "https://github.com/sponsors/harlan-zw",
+  "funding": "https://github.comcla/sponsors/harlan-zw",
   "homepage": "https://github.com/harlan-zw/eslint-plugin-harlanzw#readme",
   "repository": {
     "type": "git",