eslint-plugin-harlanzw 0.12.3 → 0.14.0

package/dist/index.mjs

@@ -4,7 +4,7 @@ import process from 'node:process';
 import { TextSourceCodeBase, ConfigCommentParser, Directive, VisitNodeStep } from '@eslint/plugin-kit';
 import { AST_NODE_TYPES } from '@typescript-eslint/utils';
 
-const version = "0.12.3";
+const version = "0.14.0";
 
 const STRENGTH_PATTERNS = {
   strong: ["never", "must", "always", "under no circumstances", "absolutely", "required", "mandatory", "forbidden", "prohibited"],
@@ -3780,9 +3780,9 @@ function createReactivityChecker(vueImports, nonVueImports) {
 
 const REGEX_2$4 = /[^\u0020-\u007F]/;
 const REGEX_1$6 = /[^\u0020-\u007F]/;
-const RULE_NAME$s = "link-ascii-only";
+const RULE_NAME$t = "link-ascii-only";
 const linkAsciiOnly = createEslintRule({
-  name: RULE_NAME$s,
+  name: RULE_NAME$t,
   meta: {
     type: "suggestion",
     docs: {
@@ -3858,9 +3858,9 @@ const REGEX_4$1 = /[A-Z]/;
 const REGEX_3$2 = /%[0-9A-F]{2}/i;
 const REGEX_2$3 = /[A-Z]/;
 const REGEX_1$5 = /%[0-9A-F]{2}/i;
-const RULE_NAME$r = "link-lowercase";
+const RULE_NAME$s = "link-lowercase";
 const linkLowercase = createEslintRule({
-  name: RULE_NAME$r,
+  name: RULE_NAME$s,
   meta: {
     type: "suggestion",
     docs: {
@@ -3939,7 +3939,7 @@ const linkLowercase = createEslintRule({
 const REGEX_3$1 = /\/+/g;
 const REGEX_2$2 = /\/{2,}/;
 const REGEX_1$4 = /\/{2,}/;
-const RULE_NAME$q = "link-no-double-slashes";
+const RULE_NAME$r = "link-no-double-slashes";
 function fixDoubleSlashesInUrl(url) {
   if (url.startsWith("//") || url.includes("://"))
     return url;
@@ -3959,7 +3959,7 @@ function fixDoubleSlashesInUrl(url) {
   return `${path.replace(REGEX_3$1, "/")}${search}${hash}`;
 }
 const linkNoDoubleSlashes = createEslintRule({
-  name: RULE_NAME$q,
+  name: RULE_NAME$r,
   meta: {
     type: "problem",
     docs: {
@@ -4035,9 +4035,9 @@ const linkNoDoubleSlashes = createEslintRule({
   }
 });
 
-const RULE_NAME$p = "link-no-underscores";
+const RULE_NAME$q = "link-no-underscores";
 const linkNoUnderscores = createEslintRule({
-  name: RULE_NAME$p,
+  name: RULE_NAME$q,
   meta: {
     type: "suggestion",
     docs: {
@@ -4115,9 +4115,9 @@ const REGEX_4 = /\s/;
 const REGEX_3 = /\s/g;
 const REGEX_2$1 = /\s/;
 const REGEX_1$3 = /\s/g;
-const RULE_NAME$o = "link-no-whitespace";
+const RULE_NAME$p = "link-no-whitespace";
 const linkNoWhitespace = createEslintRule({
-  name: RULE_NAME$o,
+  name: RULE_NAME$p,
   meta: {
     type: "suggestion",
     docs: {
@@ -4191,7 +4191,7 @@ const linkNoWhitespace = createEslintRule({
   }
 });
 
-const RULE_NAME$n = "link-require-descriptive-text";
+const RULE_NAME$o = "link-require-descriptive-text";
 const BAD_LINK_TEXTS = /* @__PURE__ */ new Set([
   "click here",
   "click this",
@@ -4237,7 +4237,7 @@ function getVueLinkUrl(node) {
   return null;
 }
 const linkRequireDescriptiveText = createEslintRule({
-  name: RULE_NAME$n,
+  name: RULE_NAME$o,
   meta: {
     type: "suggestion",
     docs: {
@@ -4313,9 +4313,9 @@ const linkRequireDescriptiveText = createEslintRule({
   }
 });
 
-const RULE_NAME$m = "link-require-href";
+const RULE_NAME$n = "link-require-href";
 const linkRequireHref = createEslintRule({
-  name: RULE_NAME$m,
+  name: RULE_NAME$n,
   meta: {
     type: "problem",
     docs: {
@@ -4383,12 +4383,12 @@ const linkRequireHref = createEslintRule({
   }
 });
 
-const RULE_NAME$l = "link-trailing-slash";
+const RULE_NAME$m = "link-trailing-slash";
 function shouldSkipUrl(url) {
   return url.startsWith("#") || url.includes(":") || url === "/" || url === "";
 }
 const linkTrailingSlash = createEslintRule({
-  name: RULE_NAME$l,
+  name: RULE_NAME$m,
   meta: {
     type: "suggestion",
     docs: {
@@ -4503,7 +4503,7 @@ const linkTrailingSlash = createEslintRule({
   }
 });
 
-const RULE_NAME$k = "no-silent-catch";
+const RULE_NAME$l = "no-silent-catch";
 function isEmptyOrVoid(node) {
   if (node.type === "ArrowFunctionExpression") {
     if (node.body.type === "BlockStatement" && node.body.body.length === 0)
@@ -4523,7 +4523,7 @@ function hasOnlyComments(node, sourceCode) {
   return node.body.length === 0 && sourceCode.getCommentsInside(node).length > 0;
 }
 const noSilentCatch = createEslintRule({
-  name: RULE_NAME$k,
+  name: RULE_NAME$l,
   meta: {
     type: "problem",
     docs: {
@@ -4561,9 +4561,9 @@ const noSilentCatch = createEslintRule({
   }
 });
 
-const RULE_NAME$j = "nuxt-await-navigate-to";
+const RULE_NAME$k = "nuxt-await-navigate-to";
 const nuxtAwaitNavigateTo = createEslintRule({
-  name: RULE_NAME$j,
+  name: RULE_NAME$k,
   meta: {
     type: "problem",
     docs: {
@@ -4719,7 +4719,7 @@ function isInConsequentBranch(node, ternary) {
   return false;
 }
 
-const RULE_NAME$i = "nuxt-no-random";
+const RULE_NAME$j = "nuxt-no-random";
 function isMathRandomCall(node) {
   return node.callee.type === "MemberExpression" && node.callee.object.type === "Identifier" && node.callee.object.name === "Math" && node.callee.property.type === "Identifier" && node.callee.property.name === "random";
 }
@@ -4750,7 +4750,7 @@ function reportRandom(context, node, template) {
   }
 }
 const nuxtNoRandom = createEslintRule({
-  name: RULE_NAME$i,
+  name: RULE_NAME$j,
   meta: {
     type: "problem",
     docs: {
@@ -4789,9 +4789,9 @@ const nuxtNoRandom = createEslintRule({
   }
 });
 
-const RULE_NAME$h = "nuxt-no-redundant-import-meta";
+const RULE_NAME$i = "nuxt-no-redundant-import-meta";
 const nuxtNoRedundantImportMeta = createEslintRule({
-  name: RULE_NAME$h,
+  name: RULE_NAME$i,
   meta: {
     type: "problem",
     docs: {
@@ -4829,7 +4829,7 @@ const nuxtNoRedundantImportMeta = createEslintRule({
 });
 
 const REGEX_1$2 = /\n\s*\n\s*\n/g;
-const RULE_NAME$g = "nuxt-no-side-effects-in-async-data-handler";
+const RULE_NAME$h = "nuxt-no-side-effects-in-async-data-handler";
 const SIDE_EFFECT_PATTERNS = /* @__PURE__ */ new Set([
   // Store/State mutations ($ prefix makes these unambiguous)
   "$patch",
@@ -4939,7 +4939,7 @@ function findSideEffectsInFunction(functionNode) {
   return sideEffects;
 }
 const nuxtNoSideEffectsInAsyncDataHandler = createEslintRule({
-  name: RULE_NAME$g,
+  name: RULE_NAME$h,
   meta: {
     type: "problem",
     docs: {
@@ -5030,9 +5030,9 @@ ${indent}${callOnceBlock}`)
   }
 });
 
-const RULE_NAME$f = "nuxt-no-side-effects-in-setup";
+const RULE_NAME$g = "nuxt-no-side-effects-in-setup";
 const nuxtNoSideEffectsInSetup = createEslintRule({
-  name: RULE_NAME$f,
+  name: RULE_NAME$g,
   meta: {
     type: "problem",
     docs: {
@@ -5123,7 +5123,7 @@ ${indent}})`;
   }
 });
 
-const RULE_NAME$e = "nuxt-no-unsafe-date";
+const RULE_NAME$f = "nuxt-no-unsafe-date";
 function isDateNowCall(node) {
   return node.callee.type === "MemberExpression" && node.callee.object.type === "Identifier" && node.callee.object.name === "Date" && node.callee.property.type === "Identifier" && node.callee.property.name === "now";
 }
@@ -5154,7 +5154,7 @@ function isChainedWithStableMethod(node) {
   return grandparent?.type === "CallExpression" && grandparent.callee === parent;
 }
 const nuxtNoUnsafeDate = createEslintRule({
-  name: RULE_NAME$e,
+  name: RULE_NAME$f,
   meta: {
     type: "problem",
     docs: {
@@ -5218,9 +5218,9 @@ const nuxtNoUnsafeDate = createEslintRule({
   }
 });
 
-const RULE_NAME$d = "nuxt-prefer-navigate-to-over-router-push-replace";
+const RULE_NAME$e = "nuxt-prefer-navigate-to-over-router-push-replace";
 const nuxtPreferNavigateToOverRouterPushReplace = createEslintRule({
-  name: RULE_NAME$d,
+  name: RULE_NAME$e,
   meta: {
     type: "suggestion",
     docs: {
@@ -5285,9 +5285,9 @@ const nuxtPreferNavigateToOverRouterPushReplace = createEslintRule({
 
 const REGEX_2 = /router-link|RouterLink/gi;
 const REGEX_1$1 = /router-link|RouterLink/gi;
-const RULE_NAME$c = "nuxt-prefer-nuxt-link-over-router-link";
+const RULE_NAME$d = "nuxt-prefer-nuxt-link-over-router-link";
 const nuxtPreferNuxtLinkOverRouterLink = createEslintRule({
-  name: RULE_NAME$c,
+  name: RULE_NAME$d,
   meta: {
     type: "suggestion",
     docs: {
@@ -5358,7 +5358,7 @@ const nuxtPreferNuxtLinkOverRouterLink = createEslintRule({
   }
 });
 
-const RULE_NAME$b = "nuxt-ui-prefer-shorthand-css";
+const RULE_NAME$c = "nuxt-ui-prefer-shorthand-css";
 const REPLACEMENTS = {
   // text
   "text-[var(--ui-text)]": "text-default",
@@ -5415,7 +5415,7 @@ function findVerboseClasses(value) {
   return results;
 }
 const nuxtUiPreferShorthandCss = createEslintRule({
-  name: RULE_NAME$b,
+  name: RULE_NAME$c,
   meta: {
     type: "suggestion",
     docs: {
@@ -5564,6 +5564,189 @@ const nuxtUiPreferShorthandCss = createEslintRule({
   }
 });
 
+const RULE_NAME$b = "prefer-node-style-text";
+const ESC_ALT = String.raw`(?:\\x1[bB]|\\u001[bB]|\\033|\x1B)`;
+const ANSI_ANYWHERE_RE = new RegExp(`${ESC_ALT}\\[[\\d;]*m`);
+const FULL_WRAP_RE = new RegExp(`^${ESC_ALT}\\[([\\d;]+)m([\\s\\S]*?)${ESC_ALT}\\[0m$`);
+const ANY_ANSI_RE = new RegExp(`${ESC_ALT}\\[`);
+const SGR_NAMES = {
+  0: "reset",
+  1: "bold",
+  2: "dim",
+  3: "italic",
+  4: "underline",
+  7: "inverse",
+  8: "hidden",
+  9: "strikethrough",
+  30: "black",
+  31: "red",
+  32: "green",
+  33: "yellow",
+  34: "blue",
+  35: "magenta",
+  36: "cyan",
+  37: "white",
+  90: "gray",
+  91: "redBright",
+  92: "greenBright",
+  93: "yellowBright",
+  94: "blueBright",
+  95: "magentaBright",
+  96: "cyanBright",
+  97: "whiteBright",
+  40: "bgBlack",
+  41: "bgRed",
+  42: "bgGreen",
+  43: "bgYellow",
+  44: "bgBlue",
+  45: "bgMagenta",
+  46: "bgCyan",
+  47: "bgWhite"
+};
+function paramsToNames(params) {
+  const parts = params.split(";").filter(Boolean);
+  const names = parts.map((p) => SGR_NAMES[p]);
+  if (names.some((n) => !n || n === "reset"))
+    return null;
+  return names;
+}
+function describeCodes(raw) {
+  const m = raw.match(new RegExp(`${ESC_ALT}\\[([\\d;]*)m`));
+  if (!m)
+    return "ANSI";
+  const names = m[1].split(";").filter(Boolean).map((p) => SGR_NAMES[p] || p);
+  return names.join(", ") || "ANSI";
+}
+function formatCodes(names) {
+  if (names.length === 1)
+    return `'${names[0]}'`;
+  return `[${names.map((n) => `'${n}'`).join(", ")}]`;
+}
+const preferNodeStyleText = createEslintRule({
+  name: RULE_NAME$b,
+  meta: {
+    type: "suggestion",
+    fixable: "code",
+    docs: {
+      description: "prefer `styleText` from `node:util` over raw ANSI escape sequences"
+    },
+    schema: [],
+    messages: {
+      preferStyleText: "Avoid raw ANSI escape sequences ({{codes}}). Use `styleText` from `node:util` instead."
+    }
+  },
+  defaultOptions: [],
+  create: (context) => {
+    const sourceCode = context.sourceCode ?? context.getSourceCode();
+    let program = null;
+    let nodeUtilImport = null;
+    let hasStyleText = false;
+    function ensureStyleTextImportFix(fixer) {
+      const fixes = [];
+      if (hasStyleText)
+        return fixes;
+      if (nodeUtilImport) {
+        const specifiers = nodeUtilImport.specifiers.filter(
+          (s) => s.type === "ImportSpecifier"
+        );
+        if (specifiers.length > 0) {
+          const last = specifiers[specifiers.length - 1];
+          fixes.push(fixer.insertTextAfter(last, ", styleText"));
+        } else {
+          const defaultSpec = nodeUtilImport.specifiers[0];
+          if (defaultSpec)
+            fixes.push(fixer.insertTextAfter(defaultSpec, ", { styleText }"));
+        }
+      } else if (program) {
+        fixes.push(fixer.insertTextBefore(program.body[0], `import { styleText } from 'node:util'
+`));
+      }
+      return fixes;
+    }
+    function buildReplacement(node) {
+      const text = sourceCode.getText(node);
+      if (node.type === "Literal") {
+        if (typeof node.value !== "string")
+          return null;
+        const quote = text[0];
+        if (quote !== '"' && quote !== "'")
+          return null;
+        const inner2 = text.slice(1, -1);
+        const m2 = inner2.match(FULL_WRAP_RE);
+        if (!m2)
+          return null;
+        const names2 = paramsToNames(m2[1]);
+        if (!names2)
+          return null;
+        const body2 = m2[2];
+        if (ANY_ANSI_RE.test(body2))
+          return null;
+        return {
+          codes: names2.join(", "),
+          replacement: `styleText(${formatCodes(names2)}, ${quote}${body2}${quote})`
+        };
+      }
+      if (node.parent?.type === "TaggedTemplateExpression")
+        return null;
+      const inner = text.slice(1, -1);
+      const m = inner.match(FULL_WRAP_RE);
+      if (!m)
+        return null;
+      const names = paramsToNames(m[1]);
+      if (!names)
+        return null;
+      const body = m[2];
+      if (ANY_ANSI_RE.test(body))
+        return null;
+      return {
+        codes: names.join(", "),
+        replacement: `styleText(${formatCodes(names)}, \`${body}\`)`
+      };
+    }
+    function check(node, raw) {
+      if (!ANSI_ANYWHERE_RE.test(raw))
+        return;
+      const codes = describeCodes(raw);
+      const built = buildReplacement(node);
+      context.report({
+        node,
+        messageId: "preferStyleText",
+        data: { codes },
+        fix: built ? (fixer) => {
+          const fixes = [fixer.replaceText(node, built.replacement), ...ensureStyleTextImportFix(fixer)];
+          return fixes;
+        } : null
+      });
+    }
+    return {
+      Program(node) {
+        program = node;
+        for (const stmt of node.body) {
+          if (stmt.type !== "ImportDeclaration")
+            continue;
+          if (stmt.source.value !== "node:util" && stmt.source.value !== "util")
+            continue;
+          nodeUtilImport = stmt;
+          for (const spec of stmt.specifiers) {
+            if (spec.type === "ImportSpecifier" && spec.imported.type === "Identifier" && spec.imported.name === "styleText") {
+              hasStyleText = true;
+            }
+          }
+        }
+      },
+      Literal(node) {
+        if (typeof node.value !== "string")
+          return;
+        check(node, sourceCode.getText(node));
+      },
+      TemplateLiteral(node) {
+        const text = sourceCode.getText(node);
+        check(node, text);
+      }
+    };
+  }
+});
+
 const RULE_NAME$a = "vue-no-async-lifecycle-hook";
 const LIFECYCLE_HOOKS = /* @__PURE__ */ new Set([
   "onBeforeMount",
@@ -6404,8 +6587,6 @@ function hasUnresolvableType(node) {
         return node.typeArguments.params.some((t) => hasUnresolvableType(t));
       }
       return false;
-    case "TSParenthesizedType":
-      return hasUnresolvableType(node.typeAnnotation);
     default:
       return false;
   }
@@ -6672,6 +6853,7 @@ const plugin = {
     "nuxt-prefer-nuxt-link-over-router-link": nuxtPreferNuxtLinkOverRouterLink,
     "nuxt-ui-prefer-shorthand-css": nuxtUiPreferShorthandCss,
     "pnpm-require-trust-policy": pnpmRequireTrustPolicy,
+    "prefer-node-style-text": preferNodeStyleText,
     "prompt-ambiguous-quantifier": promptAmbiguousQuantifier,
     "prompt-duplicate-heading": promptDuplicateHeading,
     "prompt-empty-section": promptEmptySection,
@@ -6845,7 +7027,8 @@ plugin.configs.nuxt = [
       "harlanzw/nuxt-no-unsafe-date": "warn",
       "harlanzw/nuxt-prefer-navigate-to-over-router-push-replace": "warn",
       "harlanzw/nuxt-prefer-nuxt-link-over-router-link": "warn",
-      "harlanzw/nuxt-ui-prefer-shorthand-css": "warn"
+      "harlanzw/nuxt-ui-prefer-shorthand-css": "warn",
+      "harlanzw/no-silent-catch": "error"
     }
   }
 ];
@@ -6867,7 +7050,8 @@ plugin.configs.vue = [
       "harlanzw/vue-no-torefs-on-props": "warn",
       "harlanzw/vue-no-unresolvable-define-emits": "error",
       "harlanzw/vue-prefer-define-emits-object-syntax": "warn",
-      "harlanzw/vue-require-composable-prefix": "warn"
+      "harlanzw/vue-require-composable-prefix": "warn",
+      "harlanzw/no-silent-catch": "error"
     }
   },
   {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-harlanzw",
   "type": "module",
-  "version": "0.12.3",
+  "version": "0.14.0",
   "description": "Harlan's opinionated ESLint rules",
   "author": "Harlan Wilton <harlan@harlanzw.com>",
   "license": "MIT",
@@ -37,6 +37,7 @@
     "@antfu/utils": "^9.3.0",
     "@types/eslint": "^9.6.1",
     "@types/node": "^25.7.0",
+    "@typescript-eslint/parser": "^8.59.3",
     "@typescript-eslint/typescript-estree": "^8.59.3",
     "@typescript-eslint/utils": "^8.59.3",
     "bumpp": "^11.1.0",
@@ -50,6 +51,7 @@
     "vite": "^8.0.12",
     "vitest": "^4.1.6",
     "vue": "^3.5.34",
+    "vue-eslint-parser": "^10.4.0",
     "yaml-eslint-parser": "^2.0.0"
   },
   "resolutions": {