eslint-plugin-fsd-paths-check 0.0.14 → 0.0.16

package/lib/constants/constants.js

@@ -0,0 +1,5 @@
+const allFsdLayers = ['shared', 'entities', 'features', 'widgets', 'pages', 'app'];
+
+module.exports = {
+    allFsdLayers
+}

package/lib/helpers/pathContainsFsdLayer.js

@@ -0,0 +1,23 @@
+const { allFsdLayers } = require("../constants/constants");
+
+const getFsdLayerFromPath = (filePath) => {
+    const normalizedPath = filePath.replace(/\\/g, '/');
+    const segments = normalizedPath.split('/');
+
+    for (const segment of segments) {
+        if (allFsdLayers.includes(segment)) {
+            return segment;
+        }
+    }
+
+    return null;
+};
+
+const hasFsdLayerInPath = (filePath) => {
+    return getFsdLayerFromPath(filePath) !== null;
+};
+
+module.exports = {
+    getFsdLayerFromPath,
+    hasFsdLayerInPath,
+};

package/lib/rules/enforce-public-api-imports.js

@@ -1,7 +1,9 @@
 "use strict";
 
-const { isPathRelative } = require("../helpers/isPathRelative");
+const {isPathRelative} = require("../helpers/isPathRelative");
 const {isSameModuleImport} = require("../helpers/isSameModuleImport");
+const {getFsdLayerFromPath} = require("../helpers/pathContainsFsdLayer");
+const {allFsdLayers} = require("../constants/constants");
 
 const fsdLayers = {
   'entities': 'entities',
@@ -30,6 +32,7 @@ module.exports = {
     messages: {
       useOthersModulesPublicApi: `When importing from other modules, public api should be used`,
       doNotUseAbsolutePathInSameModuleImport: `When importing from the same module, absolute path should not be used`,
+      doNotUseRelativePathsBetweenLayers: `When importing from other modules, absolute path should be used`,
     },
   },
 
@@ -41,22 +44,35 @@ module.exports = {
         const pathTo = alias ? value.replace(`${alias}`, ``) : value;
         const currentFile = context.getFilename();
 
-        if(isPathRelative(pathTo)) {
+        const pathToLayer = getFsdLayerFromPath(pathTo)
+        const segments = pathTo.split("/");
+
+        if(isPathRelative(pathTo) && !pathToLayer) {
           return;
+        } else if(isPathRelative(pathTo)) {
+          context.report({
+            node,
+            messageId: `doNotUseRelativePathsBetweenLayers`,
+            fix(fixer) {
+              const layerIndex = segments.findIndex(segment => allFsdLayers.includes(segment));
+              if (layerIndex === -1) return undefined;
+
+              const absolutePath = `${alias}${segments.slice(layerIndex).join(`/`)}`;
+
+              return fixer.replaceText(node.source, `'${absolutePath}'`);
+            }
+          })
         }
 
-        const segments = pathTo.split("/");
         const layer = segments[0];
-
         if(!fsdLayers[layer]) {
           return;
         }
-
         const isImportNotFromPublicApi = segments.length > 2;
         const isSameModule = isSameModuleImport(currentFile, pathTo, fsdLayers);
 
         if (isImportNotFromPublicApi && !isSameModule) {
-          context.report({
+          return context.report({
             node,
             messageId: `useOthersModulesPublicApi`,
             fix(fixer) {
@@ -70,7 +86,7 @@ module.exports = {
           })
         }
         else if (isSameModule) {
-          context.report({
+          return context.report({
             node,
             messageId: `doNotUseAbsolutePathInSameModuleImport`
           })

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-fsd-paths-check",
-  "version": "0.0.14",
+  "version": "0.0.16",
   "description": "Plugin to check feature sliced design paths correctness",
   "keywords": [
     "eslint",