eslint-plugin-firebase-ai-logic 1.2.0 → 1.4.0

package/dist/index.js

@@ -239,7 +239,7 @@ const configs = {
 const plugin = {
     meta: {
         name: 'eslint-plugin-firebase-ai-logic',
-        version: '1.2.0',
+        version: '1.4.0',
     },
     rules,
     configs,

package/dist/rules/check-temperature-defaults.d.ts

@@ -1,4 +1,28 @@
 import type { Rule } from 'eslint';
+/**
+ * check-temperature-defaults
+ *
+ * This rule suggests using the default temperature (1.0) for Gemini 3 models,
+ * but with important exceptions:
+ *
+ * ONLY APPLIES TO:
+ * - gemini-3-flash-preview
+ * - gemini-3-pro-preview
+ * (Other models like gemini-2.5-* don't have this recommendation)
+ *
+ * EXCEPTIONS (low temperature is valid and recommended):
+ * 1. Structured output (responseMimeType: 'application/json')
+ *    - Low temperature (0.1-0.3) prevents hallucinations in extraction tasks
+ * 2. Classification tasks (maxOutputTokens <= 20)
+ *    - Deterministic outputs benefit from low temperature
+ * 3. Data extraction with responseSchema
+ *    - Precise extraction needs low temperature
+ *
+ * The rule only warns when:
+ * - Model is Gemini 3 (flash or pro preview)
+ * - Temperature is NOT 1.0
+ * - AND it's NOT a structured output or classification task
+ */
 declare const rule: Rule.RuleModule;
 export default rule;
 //# sourceMappingURL=check-temperature-defaults.d.ts.map

package/dist/rules/check-temperature-defaults.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"check-temperature-defaults.d.ts","sourceRoot":"","sources":["../../src/rules/check-temperature-defaults.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAOnC,QAAA,MAAM,IAAI,EAAE,IAAI,CAAC,UA6DhB,CAAC;AAEF,eAAe,IAAI,CAAC"}
+{"version":3,"file":"check-temperature-defaults.d.ts","sourceRoot":"","sources":["../../src/rules/check-temperature-defaults.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AASnC;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,QAAA,MAAM,IAAI,EAAE,IAAI,CAAC,UA4GhB,CAAC;AAEF,eAAe,IAAI,CAAC"}

package/dist/rules/check-temperature-defaults.js

@@ -1,20 +1,51 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 const ast_helpers_js_1 = require("../utils/ast-helpers.js");
+/**
+ * check-temperature-defaults
+ *
+ * This rule suggests using the default temperature (1.0) for Gemini 3 models,
+ * but with important exceptions:
+ *
+ * ONLY APPLIES TO:
+ * - gemini-3-flash-preview
+ * - gemini-3-pro-preview
+ * (Other models like gemini-2.5-* don't have this recommendation)
+ *
+ * EXCEPTIONS (low temperature is valid and recommended):
+ * 1. Structured output (responseMimeType: 'application/json')
+ *    - Low temperature (0.1-0.3) prevents hallucinations in extraction tasks
+ * 2. Classification tasks (maxOutputTokens <= 20)
+ *    - Deterministic outputs benefit from low temperature
+ * 3. Data extraction with responseSchema
+ *    - Precise extraction needs low temperature
+ *
+ * The rule only warns when:
+ * - Model is Gemini 3 (flash or pro preview)
+ * - Temperature is NOT 1.0
+ * - AND it's NOT a structured output or classification task
+ */
 const rule = {
     meta: {
-        type: 'problem',
+        type: 'suggestion',
         docs: {
-            description: 'Enforce default temperature (1.0) for Gemini 3 models to prevent unexpected behavior',
+            description: 'Suggest default temperature (1.0) for Gemini 3 models, except for structured output and classification tasks',
             recommended: true,
             url: 'https://github.com/Just-mpm/eslint-plugin-firebase-ai-logic#check-temperature-defaults',
         },
         schema: [],
         messages: {
-            nonDefaultTemperature: 'Gemini 3 models are optimized for the default temperature (1.0). Changing this value may lead to unexpected behavior, looping, or degraded reasoning performance.',
+            nonDefaultTemperature: 'Consider using the default temperature (1.0) for Gemini 3 models. Lower values may cause looping or degraded reasoning. Exception: low temperature is appropriate for structured output (JSON) and classification tasks.',
         },
     },
     create(context) {
+        // Gemini 3 models that have the temperature=1.0 recommendation
+        const GEMINI_3_MODELS = [
+            'gemini-3-flash-preview',
+            'gemini-3-pro-preview',
+            'gemini-3-flash',
+            'gemini-3-pro',
+        ];
         return {
             CallExpression(node) {
                 const calleeName = (0, ast_helpers_js_1.getCalleeName)(node);
@@ -27,20 +58,55 @@ const rule = {
                 const configArg = node.arguments[1];
                 if (!configArg || !(0, ast_helpers_js_1.isObjectExpression)(configArg))
                     return;
+                // Check model name - only apply to Gemini 3 models
+                const modelProp = (0, ast_helpers_js_1.findProperty)(configArg, 'model');
+                if (modelProp) {
+                    const modelName = (0, ast_helpers_js_1.getStringValue)(modelProp.value);
+                    if (modelName && !GEMINI_3_MODELS.some(m => modelName.includes(m))) {
+                        // Not a Gemini 3 model - don't apply this rule
+                        return;
+                    }
+                }
                 // Check for generationConfig
-                let generationConfig = (0, ast_helpers_js_1.findProperty)(configArg, 'generationConfig');
-                let configToCheck = generationConfig
+                const generationConfig = (0, ast_helpers_js_1.findProperty)(configArg, 'generationConfig');
+                const configToCheck = generationConfig
                     ? generationConfig.value
                     : configArg;
                 if (!(0, ast_helpers_js_1.isObjectExpression)(configToCheck))
                     return;
+                // Check for responseMimeType - if it's 'application/json', low temperature is valid
+                const responseMimeTypeProp = (0, ast_helpers_js_1.findProperty)(configToCheck, 'responseMimeType');
+                if (responseMimeTypeProp) {
+                    const mimeType = (0, ast_helpers_js_1.getStringValue)(responseMimeTypeProp.value);
+                    if (mimeType === 'application/json') {
+                        // Structured output - low temperature is appropriate, don't warn
+                        return;
+                    }
+                }
+                // Check for responseSchema - if present, it's structured output
+                const responseSchemaProp = (0, ast_helpers_js_1.findProperty)(configToCheck, 'responseSchema');
+                if (responseSchemaProp) {
+                    // Has response schema - structured output, don't warn
+                    return;
+                }
+                // Check for maxOutputTokens - if very low (<= 20), it's likely classification
+                const maxOutputTokensProp = (0, ast_helpers_js_1.findProperty)(configToCheck, 'maxOutputTokens');
+                if (maxOutputTokensProp) {
+                    const maxTokens = (0, ast_helpers_js_1.getNumberValue)(maxOutputTokensProp.value);
+                    if (maxTokens !== null && maxTokens <= 20) {
+                        // Classification task (very short output) - low temperature is appropriate
+                        return;
+                    }
+                }
                 // Check for temperature property
                 const temperatureProp = (0, ast_helpers_js_1.findProperty)(configToCheck, 'temperature');
                 if (temperatureProp) {
-                    // If value is literal and not 1.0, report
+                    // If value is literal and not 1.0, suggest (not require) using default
                     if (temperatureProp.value.type === 'Literal' &&
                         typeof temperatureProp.value.value === 'number') {
-                        if (temperatureProp.value.value !== 1.0) {
+                        const temp = temperatureProp.value.value;
+                        // Only warn for non-default temperature when NOT doing structured output
+                        if (temp !== 1.0) {
                             context.report({
                                 node: temperatureProp,
                                 messageId: 'nonDefaultTemperature',

package/dist/rules/check-temperature-defaults.js.map

@@ -1 +1 @@
-{"version":3,"file":"check-temperature-defaults.js","sourceRoot":"","sources":["../../src/rules/check-temperature-defaults.ts"],"names":[],"mappings":";;AACA,4DAIiC;AAEjC,MAAM,IAAI,GAAoB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EACT,sFAAsF;YACxF,WAAW,EAAE,IAAI;YACjB,GAAG,EAAE,wFAAwF;SAC9F;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,qBAAqB,EACnB,mKAAmK;SACtK;KACF;IAED,MAAM,CAAC,OAAO;QACZ,OAAO;YACL,cAAc,CAAC,IAAI;gBACjB,MAAM,UAAU,GAAG,IAAA,8BAAa,EAAC,IAAI,CAAC,CAAC;gBAEvC,oDAAoD;gBACpD,IACE,UAAU,KAAK,oBAAoB;oBACnC,UAAU,KAAK,iBAAiB,EAChC,CAAC;oBACD,OAAO;gBACT,CAAC;gBAED,+CAA+C;gBAC/C,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;gBACpC,IAAI,CAAC,SAAS,IAAI,CAAC,IAAA,mCAAkB,EAAC,SAAS,CAAC;oBAAE,OAAO;gBAEzD,6BAA6B;gBAC7B,IAAI,gBAAgB,GAAG,IAAA,6BAAY,EAAC,SAAS,EAAE,kBAAkB,CAAC,CAAC;gBACnE,IAAI,aAAa,GAAG,gBAAgB;oBAClC,CAAC,CAAC,gBAAgB,CAAC,KAAK;oBACxB,CAAC,CAAC,SAAS,CAAC;gBAEd,IAAI,CAAC,IAAA,mCAAkB,EAAC,aAAa,CAAC;oBAAE,OAAO;gBAE/C,iCAAiC;gBACjC,MAAM,eAAe,GAAG,IAAA,6BAAY,EAAC,aAAa,EAAE,aAAa,CAAC,CAAC;gBAEnE,IAAI,eAAe,EAAE,CAAC;oBACpB,0CAA0C;oBAC1C,IACE,eAAe,CAAC,KAAK,CAAC,IAAI,KAAK,SAAS;wBACxC,OAAO,eAAe,CAAC,KAAK,CAAC,KAAK,KAAK,QAAQ,EAC/C,CAAC;wBACD,IAAI,eAAe,CAAC,KAAK,CAAC,KAAK,KAAK,GAAG,EAAE,CAAC;4BACxC,OAAO,CAAC,MAAM,CAAC;gCACb,IAAI,EAAE,eAAe;gCACrB,SAAS,EAAE,uBAAuB;6BACnC,CAAC,CAAC;wBACL,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,kBAAe,IAAI,CAAC"}
+{"version":3,"file":"check-temperature-defaults.js","sourceRoot":"","sources":["../../src/rules/check-temperature-defaults.ts"],"names":[],"mappings":";;AACA,4DAMiC;AAEjC;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,MAAM,IAAI,GAAoB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EACT,8GAA8G;YAChH,WAAW,EAAE,IAAI;YACjB,GAAG,EAAE,wFAAwF;SAC9F;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,qBAAqB,EACnB,0NAA0N;SAC7N;KACF;IAED,MAAM,CAAC,OAAO;QACZ,+DAA+D;QAC/D,MAAM,eAAe,GAAG;YACtB,wBAAwB;YACxB,sBAAsB;YACtB,gBAAgB;YAChB,cAAc;SACf,CAAC;QAEF,OAAO;YACL,cAAc,CAAC,IAAI;gBACjB,MAAM,UAAU,GAAG,IAAA,8BAAa,EAAC,IAAI,CAAC,CAAC;gBAEvC,oDAAoD;gBACpD,IACE,UAAU,KAAK,oBAAoB;oBACnC,UAAU,KAAK,iBAAiB,EAChC,CAAC;oBACD,OAAO;gBACT,CAAC;gBAED,+CAA+C;gBAC/C,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;gBACpC,IAAI,CAAC,SAAS,IAAI,CAAC,IAAA,mCAAkB,EAAC,SAAS,CAAC;oBAAE,OAAO;gBAEzD,mDAAmD;gBACnD,MAAM,SAAS,GAAG,IAAA,6BAAY,EAAC,SAAS,EAAE,OAAO,CAAC,CAAC;gBACnD,IAAI,SAAS,EAAE,CAAC;oBACd,MAAM,SAAS,GAAG,IAAA,+BAAc,EAAC,SAAS,CAAC,KAAK,CAAC,CAAC;oBAClD,IAAI,SAAS,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,SAAS,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;wBACnE,+CAA+C;wBAC/C,OAAO;oBACT,CAAC;gBACH,CAAC;gBAED,6BAA6B;gBAC7B,MAAM,gBAAgB,GAAG,IAAA,6BAAY,EAAC,SAAS,EAAE,kBAAkB,CAAC,CAAC;gBACrE,MAAM,aAAa,GAAG,gBAAgB;oBACpC,CAAC,CAAC,gBAAgB,CAAC,KAAK;oBACxB,CAAC,CAAC,SAAS,CAAC;gBAEd,IAAI,CAAC,IAAA,mCAAkB,EAAC,aAAa,CAAC;oBAAE,OAAO;gBAE/C,oFAAoF;gBACpF,MAAM,oBAAoB,GAAG,IAAA,6BAAY,EAAC,aAAa,EAAE,kBAAkB,CAAC,CAAC;gBAC7E,IAAI,oBAAoB,EAAE,CAAC;oBACzB,MAAM,QAAQ,GAAG,IAAA,+BAAc,EAAC,oBAAoB,CAAC,KAAK,CAAC,CAAC;oBAC5D,IAAI,QAAQ,KAAK,kBAAkB,EAAE,CAAC;wBACpC,iEAAiE;wBACjE,OAAO;oBACT,CAAC;gBACH,CAAC;gBAED,gEAAgE;gBAChE,MAAM,kBAAkB,GAAG,IAAA,6BAAY,EAAC,aAAa,EAAE,gBAAgB,CAAC,CAAC;gBACzE,IAAI,kBAAkB,EAAE,CAAC;oBACvB,sDAAsD;oBACtD,OAAO;gBACT,CAAC;gBAED,8EAA8E;gBAC9E,MAAM,mBAAmB,GAAG,IAAA,6BAAY,EAAC,aAAa,EAAE,iBAAiB,CAAC,CAAC;gBAC3E,IAAI,mBAAmB,EAAE,CAAC;oBACxB,MAAM,SAAS,GAAG,IAAA,+BAAc,EAAC,mBAAmB,CAAC,KAAK,CAAC,CAAC;oBAC5D,IAAI,SAAS,KAAK,IAAI,IAAI,SAAS,IAAI,EAAE,EAAE,CAAC;wBAC1C,2EAA2E;wBAC3E,OAAO;oBACT,CAAC;gBACH,CAAC;gBAED,iCAAiC;gBACjC,MAAM,eAAe,GAAG,IAAA,6BAAY,EAAC,aAAa,EAAE,aAAa,CAAC,CAAC;gBAEnE,IAAI,eAAe,EAAE,CAAC;oBACpB,uEAAuE;oBACvE,IACE,eAAe,CAAC,KAAK,CAAC,IAAI,KAAK,SAAS;wBACxC,OAAO,eAAe,CAAC,KAAK,CAAC,KAAK,KAAK,QAAQ,EAC/C,CAAC;wBACD,MAAM,IAAI,GAAG,eAAe,CAAC,KAAK,CAAC,KAAK,CAAC;wBACzC,yEAAyE;wBACzE,IAAI,IAAI,KAAK,GAAG,EAAE,CAAC;4BACjB,OAAO,CAAC,MAAM,CAAC;gCACb,IAAI,EAAE,eAAe;gCACrB,SAAS,EAAE,uBAAuB;6BACnC,CAAC,CAAC;wBACL,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,kBAAe,IAAI,CAAC"}

package/dist/rules/prefer-count-tokens.d.ts

@@ -1,4 +1,28 @@
 import type { Rule } from 'eslint';
+/**
+ * prefer-count-tokens
+ *
+ * This rule suggests using countTokens() before large requests.
+ *
+ * WHY 2000 CHARACTERS DEFAULT?
+ * - 2000 chars ≈ 500 tokens (roughly 4 chars per token)
+ * - Cost increases significantly above 200K tokens context
+ * - countTokens API is FREE and has 3000 RPM quota
+ * - Below 500 tokens, the cost impact is minimal (~$0.0001 for flash)
+ *
+ * Based on Google's pricing:
+ * - Gemini 2.5 Flash-Lite: $0.10/M input tokens
+ * - Gemini 2.5 Flash: $0.15/M input tokens
+ * - Gemini 3 Pro: $2.00/M input tokens (up to 200K), $4.00/M above
+ *
+ * The rule is meant to catch large prompts that could:
+ * 1. Unexpectedly increase costs
+ * 2. Risk exceeding context window limits
+ * 3. Benefit from cost estimation before sending
+ *
+ * @see https://ai.google.dev/gemini-api/docs/tokens
+ * @see https://ai.google.dev/gemini-api/docs/pricing
+ */
 declare const rule: Rule.RuleModule;
 export default rule;
 //# sourceMappingURL=prefer-count-tokens.d.ts.map

package/dist/rules/prefer-count-tokens.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-count-tokens.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-count-tokens.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAGnC,QAAA,MAAM,IAAI,EAAE,IAAI,CAAC,UA0HhB,CAAC;AAEF,eAAe,IAAI,CAAC"}
+{"version":3,"file":"prefer-count-tokens.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-count-tokens.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAGnC;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,QAAA,MAAM,IAAI,EAAE,IAAI,CAAC,UA4HhB,CAAC;AAEF,eAAe,IAAI,CAAC"}

package/dist/rules/prefer-count-tokens.js

@@ -1,6 +1,30 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 const ast_helpers_js_1 = require("../utils/ast-helpers.js");
+/**
+ * prefer-count-tokens
+ *
+ * This rule suggests using countTokens() before large requests.
+ *
+ * WHY 2000 CHARACTERS DEFAULT?
+ * - 2000 chars ≈ 500 tokens (roughly 4 chars per token)
+ * - Cost increases significantly above 200K tokens context
+ * - countTokens API is FREE and has 3000 RPM quota
+ * - Below 500 tokens, the cost impact is minimal (~$0.0001 for flash)
+ *
+ * Based on Google's pricing:
+ * - Gemini 2.5 Flash-Lite: $0.10/M input tokens
+ * - Gemini 2.5 Flash: $0.15/M input tokens
+ * - Gemini 3 Pro: $2.00/M input tokens (up to 200K), $4.00/M above
+ *
+ * The rule is meant to catch large prompts that could:
+ * 1. Unexpectedly increase costs
+ * 2. Risk exceeding context window limits
+ * 3. Benefit from cost estimation before sending
+ *
+ * @see https://ai.google.dev/gemini-api/docs/tokens
+ * @see https://ai.google.dev/gemini-api/docs/pricing
+ */
 const rule = {
     meta: {
         type: 'suggestion',
@@ -15,8 +39,8 @@ const rule = {
                 properties: {
                     promptLengthThreshold: {
                         type: 'number',
-                        default: 500,
-                        description: 'Character length threshold to suggest token counting',
+                        default: 2000,
+                        description: 'Character length threshold to suggest token counting (default: 2000 chars ≈ 500 tokens)',
                     },
                 },
                 additionalProperties: false,
@@ -29,7 +53,9 @@ const rule = {
     },
     create(context) {
         const options = context.options[0] ?? {};
-        const promptLengthThreshold = options.promptLengthThreshold ?? 500;
+        // Default threshold: 2000 chars ≈ 500 tokens
+        // This is a reasonable threshold where token counting becomes useful
+        const promptLengthThreshold = options.promptLengthThreshold ?? 2000;
         // Track if countTokens was called in the same scope
         const scopesWithCountTokens = new Set();
         function getScopeKey(node) {

package/dist/rules/prefer-count-tokens.js.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-count-tokens.js","sourceRoot":"","sources":["../../src/rules/prefer-count-tokens.ts"],"names":[],"mappings":";;AACA,4DAAwE;AAExE,MAAM,IAAI,GAAoB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EACT,+FAA+F;YACjG,WAAW,EAAE,KAAK;YAClB,GAAG,EAAE,iFAAiF;SACvF;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,qBAAqB,EAAE;wBACrB,IAAI,EAAE,QAAQ;wBACd,OAAO,EAAE,GAAG;wBACZ,WAAW,EAAE,sDAAsD;qBACpE;iBACF;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;QACD,QAAQ,EAAE;YACR,uBAAuB,EACrB,2IAA2I;YAC7I,qBAAqB,EACnB,uGAAuG;SAC1G;KACF;IAED,MAAM,CAAC,OAAO;QACZ,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;QACzC,MAAM,qBAAqB,GAAG,OAAO,CAAC,qBAAqB,IAAI,GAAG,CAAC;QAEnE,oDAAoD;QACpD,MAAM,qBAAqB,GAAG,IAAI,GAAG,EAAU,CAAC;QAEhD,SAAS,WAAW,CAAC,IAAe;YAClC,IAAI,OAAO,GAAG,IAAI,CAAC,MAAM,CAAC;YAC1B,OAAO,OAAO,EAAE,CAAC;gBACf,IACE,OAAO,CAAC,IAAI,KAAK,qBAAqB;oBACtC,OAAO,CAAC,IAAI,KAAK,oBAAoB;oBACrC,OAAO,CAAC,IAAI,KAAK,yBAAyB,EAC1C,CAAC;oBACD,IAAI,OAAO,CAAC,IAAI,KAAK,qBAAqB,IAAI,OAAO,CAAC,EAAE,EAAE,CAAC;wBACzD,OAAO,OAAO,CAAC,EAAE,CAAC,IAAI,CAAC;oBACzB,CAAC;oBACD,OAAO,aAAa,OAAO,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC;gBAChD,CAAC;gBACD,OAAO,GAAI,OAAO,CAAC,MAAgC,IAAI,IAAI,CAAC;YAC9D,CAAC;YACD,OAAO,QAAQ,CAAC;QAClB,CAAC;QAED,OAAO;YACL,cAAc,CAAC,IAAI;gBACjB,MAAM,UAAU,GAAG,IAAA,8BAAa,EAAC,IAAI,CAAC,CAAC;gBAEvC,0BAA0B;gBAC1B,IAAI,UAAU,KAAK,aAAa,EAAE,CAAC;oBACjC,MAAM,QAAQ,GAAG,WAAW,CAAC,IAAiB,CAAC,CAAC;oBAChD,qBAAqB,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC;oBACpC,OAAO;gBACT,CAAC;gBAED,8CAA8C;gBAC9C,IACE,UAAU,KAAK,iBAAiB;oBAChC,UAAU,KAAK,uBAAuB;oBACtC,UAAU,KAAK,aAAa;oBAC5B,UAAU,KAAK,mBAAmB,EAClC,CAAC;oBACD,MAAM,QAAQ,GAAG,WAAW,CAAC,IAAiB,CAAC,CAAC;oBAEhD,uDAAuD;oBACvD,IAAI,qBAAqB,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,CAAC;wBACxC,OAAO;oBACT,CAAC;oBAED,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;oBACpC,IAAI,CAAC,SAAS;wBAAE,OAAO;oBAEvB,sBAAsB;oBACtB,IAAI,YAAY,GAAG,CAAC,CAAC;oBAErB,iBAAiB;oBACjB,MAAM,WAAW,GAAG,IAAA,+BAAc,EAAC,SAAS,CAAC,CAAC;oBAC9C,IAAI,WAAW,EAAE,CAAC;wBAChB,YAAY,GAAG,WAAW,CAAC,MAAM,CAAC;oBACpC,CAAC;oBAED,mBAAmB;oBACnB,IAAI,SAAS,CAAC,IAAI,KAAK,iBAAiB,EAAE,CAAC;wBACzC,YAAY,GAAG,SAAS,CAAC,MAAM,CAAC,MAAM,CACpC,CAAC,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,GAAG,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC,MAAM,EAAE,MAAM,IAAI,CAAC,CAAC,EAC/C,CAAC,CACF,CAAC;wBACF,mDAAmD;wBACnD,YAAY,IAAI,SAAS,CAAC,WAAW,CAAC,MAAM,GAAG,EAAE,CAAC;oBACpD,CAAC;oBAED,8BAA8B;oBAC9B,IAAI,SAAS,CAAC,IAAI,KAAK,iBAAiB,EAAE,CAAC;wBACzC,2DAA2D;wBAC3D,yDAAyD;wBACzD,YAAY,GAAG,qBAAqB,GAAG,CAAC,CAAC,CAAC,mBAAmB;oBAC/D,CAAC;oBAED,IAAI,YAAY,GAAG,qBAAqB,EAAE,CAAC;wBACzC,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI;4BACJ,SAAS,EAAE,yBAAyB;4BACpC,IAAI,EAAE;gCACJ,MAAM,EAAE,YAAY,CAAC,QAAQ,EAAE;6BAChC;yBACF,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,kBAAe,IAAI,CAAC"}
+{"version":3,"file":"prefer-count-tokens.js","sourceRoot":"","sources":["../../src/rules/prefer-count-tokens.ts"],"names":[],"mappings":";;AACA,4DAAwE;AAExE;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,MAAM,IAAI,GAAoB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EACT,+FAA+F;YACjG,WAAW,EAAE,KAAK;YAClB,GAAG,EAAE,iFAAiF;SACvF;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,qBAAqB,EAAE;wBACrB,IAAI,EAAE,QAAQ;wBACd,OAAO,EAAE,IAAI;wBACb,WAAW,EAAE,yFAAyF;qBACvG;iBACF;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;QACD,QAAQ,EAAE;YACR,uBAAuB,EACrB,2IAA2I;YAC7I,qBAAqB,EACnB,uGAAuG;SAC1G;KACF;IAED,MAAM,CAAC,OAAO;QACZ,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;QACzC,6CAA6C;QAC7C,qEAAqE;QACrE,MAAM,qBAAqB,GAAG,OAAO,CAAC,qBAAqB,IAAI,IAAI,CAAC;QAEpE,oDAAoD;QACpD,MAAM,qBAAqB,GAAG,IAAI,GAAG,EAAU,CAAC;QAEhD,SAAS,WAAW,CAAC,IAAe;YAClC,IAAI,OAAO,GAAG,IAAI,CAAC,MAAM,CAAC;YAC1B,OAAO,OAAO,EAAE,CAAC;gBACf,IACE,OAAO,CAAC,IAAI,KAAK,qBAAqB;oBACtC,OAAO,CAAC,IAAI,KAAK,oBAAoB;oBACrC,OAAO,CAAC,IAAI,KAAK,yBAAyB,EAC1C,CAAC;oBACD,IAAI,OAAO,CAAC,IAAI,KAAK,qBAAqB,IAAI,OAAO,CAAC,EAAE,EAAE,CAAC;wBACzD,OAAO,OAAO,CAAC,EAAE,CAAC,IAAI,CAAC;oBACzB,CAAC;oBACD,OAAO,aAAa,OAAO,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC;gBAChD,CAAC;gBACD,OAAO,GAAI,OAAO,CAAC,MAAgC,IAAI,IAAI,CAAC;YAC9D,CAAC;YACD,OAAO,QAAQ,CAAC;QAClB,CAAC;QAED,OAAO;YACL,cAAc,CAAC,IAAI;gBACjB,MAAM,UAAU,GAAG,IAAA,8BAAa,EAAC,IAAI,CAAC,CAAC;gBAEvC,0BAA0B;gBAC1B,IAAI,UAAU,KAAK,aAAa,EAAE,CAAC;oBACjC,MAAM,QAAQ,GAAG,WAAW,CAAC,IAAiB,CAAC,CAAC;oBAChD,qBAAqB,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC;oBACpC,OAAO;gBACT,CAAC;gBAED,8CAA8C;gBAC9C,IACE,UAAU,KAAK,iBAAiB;oBAChC,UAAU,KAAK,uBAAuB;oBACtC,UAAU,KAAK,aAAa;oBAC5B,UAAU,KAAK,mBAAmB,EAClC,CAAC;oBACD,MAAM,QAAQ,GAAG,WAAW,CAAC,IAAiB,CAAC,CAAC;oBAEhD,uDAAuD;oBACvD,IAAI,qBAAqB,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,CAAC;wBACxC,OAAO;oBACT,CAAC;oBAED,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;oBACpC,IAAI,CAAC,SAAS;wBAAE,OAAO;oBAEvB,sBAAsB;oBACtB,IAAI,YAAY,GAAG,CAAC,CAAC;oBAErB,iBAAiB;oBACjB,MAAM,WAAW,GAAG,IAAA,+BAAc,EAAC,SAAS,CAAC,CAAC;oBAC9C,IAAI,WAAW,EAAE,CAAC;wBAChB,YAAY,GAAG,WAAW,CAAC,MAAM,CAAC;oBACpC,CAAC;oBAED,mBAAmB;oBACnB,IAAI,SAAS,CAAC,IAAI,KAAK,iBAAiB,EAAE,CAAC;wBACzC,YAAY,GAAG,SAAS,CAAC,MAAM,CAAC,MAAM,CACpC,CAAC,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,GAAG,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC,MAAM,EAAE,MAAM,IAAI,CAAC,CAAC,EAC/C,CAAC,CACF,CAAC;wBACF,mDAAmD;wBACnD,YAAY,IAAI,SAAS,CAAC,WAAW,CAAC,MAAM,GAAG,EAAE,CAAC;oBACpD,CAAC;oBAED,8BAA8B;oBAC9B,IAAI,SAAS,CAAC,IAAI,KAAK,iBAAiB,EAAE,CAAC;wBACzC,2DAA2D;wBAC3D,yDAAyD;wBACzD,YAAY,GAAG,qBAAqB,GAAG,CAAC,CAAC,CAAC,mBAAmB;oBAC/D,CAAC;oBAED,IAAI,YAAY,GAAG,qBAAqB,EAAE,CAAC;wBACzC,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI;4BACJ,SAAS,EAAE,yBAAyB;4BACpC,IAAI,EAAE;gCACJ,MAAM,EAAE,YAAY,CAAC,QAAQ,EAAE;6BAChC;yBACF,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,kBAAe,IAAI,CAAC"}

package/dist/rules/prefer-optional-properties.d.ts

@@ -1,4 +1,22 @@
 import type { Rule } from 'eslint';
+/**
+ * prefer-optional-properties
+ *
+ * This rule suggests using 'optionalProperties' array for optional fields,
+ * but with important exceptions:
+ *
+ * EXCEPTIONS (no warning):
+ * 1. If the schema has a 'required' array defined
+ *    - This is the standard way to define required fields in function calling
+ *    - Fields not in 'required' are implicitly optional
+ * 2. If the schema is for function calling parameters
+ *    - Function calling uses 'required' array pattern
+ *
+ * The rule only warns when:
+ * - Schema has many properties (>5)
+ * - AND no 'optionalProperties' array
+ * - AND no 'required' array (which would indicate intent)
+ */
 declare const rule: Rule.RuleModule;
 export default rule;
 //# sourceMappingURL=prefer-optional-properties.d.ts.map

package/dist/rules/prefer-optional-properties.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-optional-properties.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-optional-properties.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAQnC,QAAA,MAAM,IAAI,EAAE,IAAI,CAAC,UA0GhB,CAAC;AAEF,eAAe,IAAI,CAAC"}
+{"version":3,"file":"prefer-optional-properties.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-optional-properties.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAQnC;;;;;;;;;;;;;;;;;GAiBG;AACH,QAAA,MAAM,IAAI,EAAE,IAAI,CAAC,UAqHhB,CAAC;AAEF,eAAe,IAAI,CAAC"}

package/dist/rules/prefer-optional-properties.js

@@ -1,6 +1,24 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 const ast_helpers_js_1 = require("../utils/ast-helpers.js");
+/**
+ * prefer-optional-properties
+ *
+ * This rule suggests using 'optionalProperties' array for optional fields,
+ * but with important exceptions:
+ *
+ * EXCEPTIONS (no warning):
+ * 1. If the schema has a 'required' array defined
+ *    - This is the standard way to define required fields in function calling
+ *    - Fields not in 'required' are implicitly optional
+ * 2. If the schema is for function calling parameters
+ *    - Function calling uses 'required' array pattern
+ *
+ * The rule only warns when:
+ * - Schema has many properties (>5)
+ * - AND no 'optionalProperties' array
+ * - AND no 'required' array (which would indicate intent)
+ */
 const rule = {
     meta: {
         type: 'suggestion',
@@ -13,7 +31,7 @@ const rule = {
         messages: {
             useOptionalProperties: "In Firebase AI Logic, all schema fields are required by default. Use 'optionalProperties: [\"fieldName\"]' array to mark fields as optional.",
             nullableNotOptional: "Using 'nullable: true' makes the field accept null but still requires it. Use 'optionalProperties' array to make it truly optional.",
-            missingOptionalProperties: "Schema has many properties but no 'optionalProperties' array. Consider which fields should be optional.",
+            missingOptionalProperties: "Schema has many properties but no 'optionalProperties' or 'required' array. Consider which fields should be optional.",
         },
     },
     create(context) {
@@ -22,6 +40,12 @@ const rule = {
                 return;
             const propertiesProp = (0, ast_helpers_js_1.findProperty)(obj, 'properties');
             const optionalPropertiesProp = (0, ast_helpers_js_1.findProperty)(obj, 'optionalProperties');
+            const requiredProp = (0, ast_helpers_js_1.findProperty)(obj, 'required');
+            // If 'required' array is defined, the developer has explicitly chosen
+            // which fields are required - no need to warn about optionalProperties
+            if (requiredProp) {
+                return;
+            }
             // Check for nullable fields without optionalProperties
             if (propertiesProp && (0, ast_helpers_js_1.isObjectExpression)(propertiesProp.value)) {
                 const propsObj = propertiesProp.value;
@@ -55,7 +79,11 @@ const rule = {
             // Check if schema has many properties but no optionalProperties
             if (propertiesProp && (0, ast_helpers_js_1.isObjectExpression)(propertiesProp.value)) {
                 const propertyCount = propertiesProp.value.properties.filter(ast_helpers_js_1.isProperty).length;
-                if (propertyCount > 5 && !optionalPropertiesProp) {
+                // Only warn if:
+                // - Many properties (>5)
+                // - No optionalProperties
+                // - No required array (which indicates intentional field selection)
+                if (propertyCount > 5 && !optionalPropertiesProp && !requiredProp) {
                     context.report({
                         node: obj,
                         messageId: 'missingOptionalProperties',

package/dist/rules/prefer-optional-properties.js.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-optional-properties.js","sourceRoot":"","sources":["../../src/rules/prefer-optional-properties.ts"],"names":[],"mappings":";;AACA,4DAKiC;AAEjC,MAAM,IAAI,GAAoB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EACT,oGAAoG;YACtG,WAAW,EAAE,IAAI;YACjB,GAAG,EAAE,wFAAwF;SAC9F;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,qBAAqB,EACnB,8IAA8I;YAChJ,mBAAmB,EACjB,qIAAqI;YACvI,yBAAyB,EACvB,yGAAyG;SAC5G;KACF;IAED,MAAM,CAAC,OAAO;QACZ,SAAS,iBAAiB,CAAC,KAAgB,EAAE,GAA6C;YACxF,IAAI,CAAC,IAAA,mCAAkB,EAAC,GAAG,CAAC;gBAAE,OAAO;YAErC,MAAM,cAAc,GAAG,IAAA,6BAAY,EAAC,GAAG,EAAE,YAAY,CAAC,CAAC;YACvD,MAAM,sBAAsB,GAAG,IAAA,6BAAY,EAAC,GAAG,EAAE,oBAAoB,CAAC,CAAC;YAEvE,uDAAuD;YACvD,IAAI,cAAc,IAAI,IAAA,mCAAkB,EAAC,cAAc,CAAC,KAAK,CAAC,EAAE,CAAC;gBAC/D,MAAM,QAAQ,GAAG,cAAc,CAAC,KAAK,CAAC;gBACtC,IAAI,iBAAiB,GAAG,KAAK,CAAC;gBAC9B,MAAM,kBAAkB,GAAa,EAAE,CAAC;gBAExC,KAAK,MAAM,IAAI,IAAI,QAAQ,CAAC,UAAU,EAAE,CAAC;oBACvC,IAAI,CAAC,IAAA,2BAAU,EAAC,IAAI,CAAC;wBAAE,SAAS;oBAEhC,MAAM,QAAQ,GAAG,IAAA,gCAAe,EAAC,IAAI,CAAC,CAAC;oBACvC,IAAI,CAAC,QAAQ;wBAAE,SAAS;oBAExB,uDAAuD;oBACvD,IAAI,IAAA,mCAAkB,EAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC;wBACnC,MAAM,YAAY,GAAG,IAAA,6BAAY,EAAC,IAAI,CAAC,KAAK,EAAE,UAAU,CAAC,CAAC;wBAC1D,IACE,YAAY;4BACZ,YAAY,CAAC,KAAK,CAAC,IAAI,KAAK,SAAS;4BACrC,YAAY,CAAC,KAAK,CAAC,KAAK,KAAK,IAAI,EACjC,CAAC;4BACD,iBAAiB,GAAG,IAAI,CAAC;4BACzB,kBAAkB,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;wBACpC,CAAC;oBACH,CAAC;gBACH,CAAC;gBAED,2FAA2F;gBAC3F,IAAI,iBAAiB,IAAI,CAAC,sBAAsB,EAAE,CAAC;oBACjD,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,cAAc;wBACpB,SAAS,EAAE,qBAAqB;qBACjC,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;YAED,gEAAgE;YAChE,IAAI,cAAc,IAAI,IAAA,mCAAkB,EAAC,cAAc,CAAC,KAAK,CAAC,EAAE,CAAC;gBAC/D,MAAM,aAAa,GAAG,cAAc,CAAC,KAAK,CAAC,UAAU,CAAC,MAAM,CAAC,2BAAU,CAAC,CAAC,MAAM,CAAC;gBAEhF,IAAI,aAAa,GAAG,CAAC,IAAI,CAAC,sBAAsB,EAAE,CAAC;oBACjD,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,GAAgB;wBACtB,SAAS,EAAE,2BAA2B;qBACvC,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO;YACL,8BAA8B;YAC9B,cAAc,CAAC,IAAI;gBACjB,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC;gBAE3B,IACE,MAAM,CAAC,IAAI,KAAK,kBAAkB;oBAClC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY;oBACnC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,QAAQ;oBAC/B,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY;oBACrC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,QAAQ,EACjC,CAAC;oBACD,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;oBAC9B,IAAI,IAAA,mCAAkB,EAAC,GAAG,CAAC,EAAE,CAAC;wBAC5B,iBAAiB,CAAC,GAAgB,EAAE,GAAG,CAAC,CAAC;oBAC3C,CAAC;gBACH,CAAC;YACH,CAAC;YAED,wCAAwC;YACxC,QAAQ,CAAC,IAAI;gBACX,IACE,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,YAAY;oBAC9B,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,gBAAgB;oBAClC,IAAA,mCAAkB,EAAC,IAAI,CAAC,KAAK,CAAC,EAC9B,CAAC;oBACD,iBAAiB,CAAC,IAAI,CAAC,KAAkB,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC;gBACzD,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,kBAAe,IAAI,CAAC"}
+{"version":3,"file":"prefer-optional-properties.js","sourceRoot":"","sources":["../../src/rules/prefer-optional-properties.ts"],"names":[],"mappings":";;AACA,4DAKiC;AAEjC;;;;;;;;;;;;;;;;;GAiBG;AACH,MAAM,IAAI,GAAoB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EACT,oGAAoG;YACtG,WAAW,EAAE,IAAI;YACjB,GAAG,EAAE,wFAAwF;SAC9F;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,qBAAqB,EACnB,8IAA8I;YAChJ,mBAAmB,EACjB,qIAAqI;YACvI,yBAAyB,EACvB,uHAAuH;SAC1H;KACF;IAED,MAAM,CAAC,OAAO;QACZ,SAAS,iBAAiB,CAAC,KAAgB,EAAE,GAA6C;YACxF,IAAI,CAAC,IAAA,mCAAkB,EAAC,GAAG,CAAC;gBAAE,OAAO;YAErC,MAAM,cAAc,GAAG,IAAA,6BAAY,EAAC,GAAG,EAAE,YAAY,CAAC,CAAC;YACvD,MAAM,sBAAsB,GAAG,IAAA,6BAAY,EAAC,GAAG,EAAE,oBAAoB,CAAC,CAAC;YACvE,MAAM,YAAY,GAAG,IAAA,6BAAY,EAAC,GAAG,EAAE,UAAU,CAAC,CAAC;YAEnD,sEAAsE;YACtE,uEAAuE;YACvE,IAAI,YAAY,EAAE,CAAC;gBACjB,OAAO;YACT,CAAC;YAED,uDAAuD;YACvD,IAAI,cAAc,IAAI,IAAA,mCAAkB,EAAC,cAAc,CAAC,KAAK,CAAC,EAAE,CAAC;gBAC/D,MAAM,QAAQ,GAAG,cAAc,CAAC,KAAK,CAAC;gBACtC,IAAI,iBAAiB,GAAG,KAAK,CAAC;gBAC9B,MAAM,kBAAkB,GAAa,EAAE,CAAC;gBAExC,KAAK,MAAM,IAAI,IAAI,QAAQ,CAAC,UAAU,EAAE,CAAC;oBACvC,IAAI,CAAC,IAAA,2BAAU,EAAC,IAAI,CAAC;wBAAE,SAAS;oBAEhC,MAAM,QAAQ,GAAG,IAAA,gCAAe,EAAC,IAAI,CAAC,CAAC;oBACvC,IAAI,CAAC,QAAQ;wBAAE,SAAS;oBAExB,uDAAuD;oBACvD,IAAI,IAAA,mCAAkB,EAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC;wBACnC,MAAM,YAAY,GAAG,IAAA,6BAAY,EAAC,IAAI,CAAC,KAAK,EAAE,UAAU,CAAC,CAAC;wBAC1D,IACE,YAAY;4BACZ,YAAY,CAAC,KAAK,CAAC,IAAI,KAAK,SAAS;4BACrC,YAAY,CAAC,KAAK,CAAC,KAAK,KAAK,IAAI,EACjC,CAAC;4BACD,iBAAiB,GAAG,IAAI,CAAC;4BACzB,kBAAkB,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;wBACpC,CAAC;oBACH,CAAC;gBACH,CAAC;gBAED,2FAA2F;gBAC3F,IAAI,iBAAiB,IAAI,CAAC,sBAAsB,EAAE,CAAC;oBACjD,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,cAAc;wBACpB,SAAS,EAAE,qBAAqB;qBACjC,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;YAED,gEAAgE;YAChE,IAAI,cAAc,IAAI,IAAA,mCAAkB,EAAC,cAAc,CAAC,KAAK,CAAC,EAAE,CAAC;gBAC/D,MAAM,aAAa,GAAG,cAAc,CAAC,KAAK,CAAC,UAAU,CAAC,MAAM,CAAC,2BAAU,CAAC,CAAC,MAAM,CAAC;gBAEhF,gBAAgB;gBAChB,yBAAyB;gBACzB,0BAA0B;gBAC1B,oEAAoE;gBACpE,IAAI,aAAa,GAAG,CAAC,IAAI,CAAC,sBAAsB,IAAI,CAAC,YAAY,EAAE,CAAC;oBAClE,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,GAAgB;wBACtB,SAAS,EAAE,2BAA2B;qBACvC,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO;YACL,8BAA8B;YAC9B,cAAc,CAAC,IAAI;gBACjB,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC;gBAE3B,IACE,MAAM,CAAC,IAAI,KAAK,kBAAkB;oBAClC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY;oBACnC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,QAAQ;oBAC/B,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY;oBACrC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,QAAQ,EACjC,CAAC;oBACD,MAAM,GAAG,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;oBAC9B,IAAI,IAAA,mCAAkB,EAAC,GAAG,CAAC,EAAE,CAAC;wBAC5B,iBAAiB,CAAC,GAAgB,EAAE,GAAG,CAAC,CAAC;oBAC3C,CAAC;gBACH,CAAC;YACH,CAAC;YAED,wCAAwC;YACxC,QAAQ,CAAC,IAAI;gBACX,IACE,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,YAAY;oBAC9B,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,gBAAgB;oBAClC,IAAA,mCAAkB,EAAC,IAAI,CAAC,KAAK,CAAC,EAC9B,CAAC;oBACD,iBAAiB,CAAC,IAAI,CAAC,KAAkB,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC;gBACzD,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,kBAAe,IAAI,CAAC"}

package/dist/rules/require-app-check-production.d.ts

@@ -1,4 +1,25 @@
 import type { Rule } from 'eslint';
+/**
+ * require-app-check-production
+ *
+ * This rule suggests using App Check to protect AI endpoints from abuse.
+ *
+ * IMPORTANT LIMITATIONS:
+ * - This rule only checks within the SAME FILE
+ * - Many projects use lazy loading where App Check is initialized in a separate file
+ * - Projects using hooks like useAppCheck() or ensureAppCheckReady() are valid
+ *
+ * The rule checks for:
+ * 1. Direct import of 'firebase/app-check'
+ * 2. Calls to initializeAppCheck()
+ * 3. Common patterns: useAppCheck, ensureAppCheckReady, AppCheckProvider
+ * 4. Module-level detection: If the file imports from a module that handles AI
+ *    (like './ai' or '../firebase/ai'), it's likely App Check is handled there
+ *
+ * If none are found in the same file as getAI(), it suggests (not requires) App Check.
+ *
+ * CONFIGURABLE: Set 'ignoreFiles' to skip specific files/patterns.
+ */
 declare const rule: Rule.RuleModule;
 export default rule;
 //# sourceMappingURL=require-app-check-production.d.ts.map

package/dist/rules/require-app-check-production.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"require-app-check-production.d.ts","sourceRoot":"","sources":["../../src/rules/require-app-check-production.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAGnC,QAAA,MAAM,IAAI,EAAE,IAAI,CAAC,UAmEhB,CAAC;AAEF,eAAe,IAAI,CAAC"}
+{"version":3,"file":"require-app-check-production.d.ts","sourceRoot":"","sources":["../../src/rules/require-app-check-production.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAGnC;;;;;;;;;;;;;;;;;;;;GAoBG;AACH,QAAA,MAAM,IAAI,EAAE,IAAI,CAAC,UA0JhB,CAAC;AAEF,eAAe,IAAI,CAAC"}

package/dist/rules/require-app-check-production.js

@@ -1,6 +1,27 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 const ast_helpers_js_1 = require("../utils/ast-helpers.js");
+/**
+ * require-app-check-production
+ *
+ * This rule suggests using App Check to protect AI endpoints from abuse.
+ *
+ * IMPORTANT LIMITATIONS:
+ * - This rule only checks within the SAME FILE
+ * - Many projects use lazy loading where App Check is initialized in a separate file
+ * - Projects using hooks like useAppCheck() or ensureAppCheckReady() are valid
+ *
+ * The rule checks for:
+ * 1. Direct import of 'firebase/app-check'
+ * 2. Calls to initializeAppCheck()
+ * 3. Common patterns: useAppCheck, ensureAppCheckReady, AppCheckProvider
+ * 4. Module-level detection: If the file imports from a module that handles AI
+ *    (like './ai' or '../firebase/ai'), it's likely App Check is handled there
+ *
+ * If none are found in the same file as getAI(), it suggests (not requires) App Check.
+ *
+ * CONFIGURABLE: Set 'ignoreFiles' to skip specific files/patterns.
+ */
 const rule = {
     meta: {
         type: 'suggestion',
@@ -9,43 +30,120 @@ const rule = {
             recommended: true,
             url: 'https://github.com/Just-mpm/eslint-plugin-firebase-ai-logic#require-app-check-production',
         },
-        schema: [],
+        schema: [
+            {
+                type: 'object',
+                properties: {
+                    ignoreFiles: {
+                        type: 'array',
+                        items: { type: 'string' },
+                        default: [],
+                        description: 'File patterns to ignore (e.g., "*.test.ts", "test/**/*")',
+                    },
+                },
+                additionalProperties: false,
+            },
+        ],
         messages: {
-            missingAppCheck: 'Consider using App Check with reCAPTCHA to protect your AI endpoints from abuse. Initialize with initializeAppCheck() before using AI features.',
-            appCheckSuggestion: "import { initializeAppCheck, ReCaptchaV3Provider } from 'firebase/app-check'; initializeAppCheck(app, { provider: new ReCaptchaV3Provider('SITE_KEY') });",
+            missingAppCheck: 'Consider using App Check to protect your AI endpoints from abuse. If you use lazy loading (useAppCheck, ensureAppCheckReady) in a separate file, you can safely ignore this warning.',
+            appCheckSuggestion: "import { initializeAppCheck, ReCaptchaEnterpriseProvider } from 'firebase/app-check'; initializeAppCheck(app, { provider: new ReCaptchaEnterpriseProvider('SITE_KEY') });",
         },
     },
     create(context) {
         let hasAppCheckImport = false;
         let hasAppCheckInit = false;
+        let hasAppCheckHelper = false;
         let hasAIInit = false;
         let aiInitNode = null;
+        let importsFromAIModule = false;
+        // Common App Check helper patterns used in lazy loading
+        const appCheckHelperPatterns = [
+            'useAppCheck',
+            'ensureAppCheckReady',
+            'AppCheckProvider',
+            'getAppCheckInstance',
+            'isAppCheckReady',
+            'initializeAppCheckLazy',
+            'withAppCheck',
+            'appCheckReady',
+        ];
+        // Common AI module patterns where App Check might be configured
+        const aiModulePatterns = [
+            '/ai',
+            '/firebase/ai',
+            '/lib/ai',
+            '/services/ai',
+            'getAIInstance',
+            'aiService',
+        ];
         return {
             // Track App Check imports
             ImportDeclaration(node) {
-                if (node.source.value === 'firebase/app-check' &&
-                    node.specifiers.some((spec) => spec.type === 'ImportSpecifier' &&
-                        spec.imported.type === 'Identifier' &&
-                        spec.imported.name === 'initializeAppCheck')) {
+                const source = node.source.value;
+                if (typeof source !== 'string')
+                    return;
+                // Direct firebase/app-check import
+                if (source === 'firebase/app-check') {
                     hasAppCheckImport = true;
                 }
+                // Check for imports from common App Check helper files/hooks
+                if (source.includes('useAppCheck') ||
+                    source.includes('AppCheck') ||
+                    source.includes('appCheck')) {
+                    hasAppCheckHelper = true;
+                }
+                // Check if importing from a common AI module pattern
+                // These modules typically handle App Check internally
+                if (aiModulePatterns.some((pattern) => source.includes(pattern))) {
+                    importsFromAIModule = true;
+                }
+                // Check imported specifiers for App Check helpers
+                for (const spec of node.specifiers) {
+                    if (spec.type === 'ImportSpecifier' && spec.imported.type === 'Identifier') {
+                        const importedName = spec.imported.name;
+                        if (appCheckHelperPatterns.includes(importedName)) {
+                            hasAppCheckHelper = true;
+                        }
+                        // Check if importing getAIInstance or similar from another module
+                        if (importedName === 'getAIInstance' ||
+                            importedName === 'getAI' ||
+                            importedName === 'aiInstance') {
+                            importsFromAIModule = true;
+                        }
+                    }
+                }
             },
-            // Track initializeAppCheck calls
+            // Track function calls
             CallExpression(node) {
                 const calleeName = (0, ast_helpers_js_1.getCalleeName)(node);
+                if (!calleeName)
+                    return;
+                // Direct initializeAppCheck call
                 if (calleeName === 'initializeAppCheck') {
                     hasAppCheckInit = true;
                 }
-                // Track getAI calls
+                // App Check helper calls
+                if (appCheckHelperPatterns.includes(calleeName)) {
+                    hasAppCheckHelper = true;
+                }
+                // Track getAI calls - but only if it's a DIRECT call, not imported wrapper
                 if (calleeName === 'getAI') {
-                    hasAIInit = true;
-                    aiInitNode = node;
+                    // Check if this is the actual firebase/ai getAI or a wrapper
+                    // If we already import from an AI module, the App Check is likely handled there
+                    if (!importsFromAIModule) {
+                        hasAIInit = true;
+                        aiInitNode = node;
+                    }
                 }
             },
             // Check at the end of the program
             'Program:exit'() {
-                // Only warn if AI is being used but App Check is not configured
-                if (hasAIInit && !hasAppCheckImport && !hasAppCheckInit && aiInitNode) {
+                // Only suggest if:
+                // 1. AI is being used directly (not via imported wrapper)
+                // 2. No App Check patterns found
+                // 3. Not importing from a module that likely handles App Check
+                const hasAnyAppCheckPattern = hasAppCheckImport || hasAppCheckInit || hasAppCheckHelper || importsFromAIModule;
+                if (hasAIInit && !hasAnyAppCheckPattern && aiInitNode) {
                     context.report({
                         node: aiInitNode,
                         messageId: 'missingAppCheck',

package/dist/rules/require-app-check-production.js.map

@@ -1 +1 @@
-{"version":3,"file":"require-app-check-production.js","sourceRoot":"","sources":["../../src/rules/require-app-check-production.ts"],"names":[],"mappings":";;AACA,4DAAwD;AAExD,MAAM,IAAI,GAAoB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EACT,iFAAiF;YACnF,WAAW,EAAE,IAAI;YACjB,GAAG,EAAE,0FAA0F;SAChG;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,eAAe,EACb,iJAAiJ;YACnJ,kBAAkB,EAChB,2JAA2J;SAC9J;KACF;IAED,MAAM,CAAC,OAAO;QACZ,IAAI,iBAAiB,GAAG,KAAK,CAAC;QAC9B,IAAI,eAAe,GAAG,KAAK,CAAC;QAC5B,IAAI,SAAS,GAAG,KAAK,CAAC;QACtB,IAAI,UAAU,GAAqB,IAAI,CAAC;QAExC,OAAO;YACL,0BAA0B;YAC1B,iBAAiB,CAAC,IAAI;gBACpB,IACE,IAAI,CAAC,MAAM,CAAC,KAAK,KAAK,oBAAoB;oBAC1C,IAAI,CAAC,UAAU,CAAC,IAAI,CAClB,CAAC,IAAI,EAAE,EAAE,CACP,IAAI,CAAC,IAAI,KAAK,iBAAiB;wBAC/B,IAAI,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY;wBACnC,IAAI,CAAC,QAAQ,CAAC,IAAI,KAAK,oBAAoB,CAC9C,EACD,CAAC;oBACD,iBAAiB,GAAG,IAAI,CAAC;gBAC3B,CAAC;YACH,CAAC;YAED,iCAAiC;YACjC,cAAc,CAAC,IAAI;gBACjB,MAAM,UAAU,GAAG,IAAA,8BAAa,EAAC,IAAI,CAAC,CAAC;gBAEvC,IAAI,UAAU,KAAK,oBAAoB,EAAE,CAAC;oBACxC,eAAe,GAAG,IAAI,CAAC;gBACzB,CAAC;gBAED,oBAAoB;gBACpB,IAAI,UAAU,KAAK,OAAO,EAAE,CAAC;oBAC3B,SAAS,GAAG,IAAI,CAAC;oBACjB,UAAU,GAAG,IAAiB,CAAC;gBACjC,CAAC;YACH,CAAC;YAED,kCAAkC;YAClC,cAAc;gBACZ,gEAAgE;gBAChE,IAAI,SAAS,IAAI,CAAC,iBAAiB,IAAI,CAAC,eAAe,IAAI,UAAU,EAAE,CAAC;oBACtE,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,UAAU;wBAChB,SAAS,EAAE,iBAAiB;qBAC7B,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,kBAAe,IAAI,CAAC"}
+{"version":3,"file":"require-app-check-production.js","sourceRoot":"","sources":["../../src/rules/require-app-check-production.ts"],"names":[],"mappings":";;AACA,4DAAwD;AAExD;;;;;;;;;;;;;;;;;;;;GAoBG;AACH,MAAM,IAAI,GAAoB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EACT,iFAAiF;YACnF,WAAW,EAAE,IAAI;YACjB,GAAG,EAAE,0FAA0F;SAChG;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,WAAW,EAAE;wBACX,IAAI,EAAE,OAAO;wBACb,KAAK,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACzB,OAAO,EAAE,EAAE;wBACX,WAAW,EAAE,0DAA0D;qBACxE;iBACF;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;QACD,QAAQ,EAAE;YACR,eAAe,EACb,sLAAsL;YACxL,kBAAkB,EAChB,2KAA2K;SAC9K;KACF;IAED,MAAM,CAAC,OAAO;QACZ,IAAI,iBAAiB,GAAG,KAAK,CAAC;QAC9B,IAAI,eAAe,GAAG,KAAK,CAAC;QAC5B,IAAI,iBAAiB,GAAG,KAAK,CAAC;QAC9B,IAAI,SAAS,GAAG,KAAK,CAAC;QACtB,IAAI,UAAU,GAAqB,IAAI,CAAC;QACxC,IAAI,mBAAmB,GAAG,KAAK,CAAC;QAEhC,wDAAwD;QACxD,MAAM,sBAAsB,GAAG;YAC7B,aAAa;YACb,qBAAqB;YACrB,kBAAkB;YAClB,qBAAqB;YACrB,iBAAiB;YACjB,wBAAwB;YACxB,cAAc;YACd,eAAe;SAChB,CAAC;QAEF,gEAAgE;QAChE,MAAM,gBAAgB,GAAG;YACvB,KAAK;YACL,cAAc;YACd,SAAS;YACT,cAAc;YACd,eAAe;YACf,WAAW;SACZ,CAAC;QAEF,OAAO;YACL,0BAA0B;YAC1B,iBAAiB,CAAC,IAAI;gBACpB,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC;gBAEjC,IAAI,OAAO,MAAM,KAAK,QAAQ;oBAAE,OAAO;gBAEvC,mCAAmC;gBACnC,IAAI,MAAM,KAAK,oBAAoB,EAAE,CAAC;oBACpC,iBAAiB,GAAG,IAAI,CAAC;gBAC3B,CAAC;gBAED,6DAA6D;gBAC7D,IACE,MAAM,CAAC,QAAQ,CAAC,aAAa,CAAC;oBAC9B,MAAM,CAAC,QAAQ,CAAC,UAAU,CAAC;oBAC3B,MAAM,CAAC,QAAQ,CAAC,UAAU,CAAC,EAC3B,CAAC;oBACD,iBAAiB,GAAG,IAAI,CAAC;gBAC3B,CAAC;gBAED,qDAAqD;gBACrD,sDAAsD;gBACtD,IAAI,gBAAgB,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC;oBACjE,mBAAmB,GAAG,IAAI,CAAC;gBAC7B,CAAC;gBAED,kDAAkD;gBAClD,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,UAAU,EAAE,CAAC;oBACnC,IAAI,IAAI,CAAC,IAAI,KAAK,iBAAiB,IAAI,IAAI,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY,EAAE,CAAC;wBAC3E,MAAM,YAAY,GAAG,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC;wBAExC,IAAI,sBAAsB,CAAC,QAAQ,CAAC,YAAY,CAAC,EAAE,CAAC;4BAClD,iBAAiB,GAAG,IAAI,CAAC;wBAC3B,CAAC;wBAED,kEAAkE;wBAClE,IACE,YAAY,KAAK,eAAe;4BAChC,YAAY,KAAK,OAAO;4BACxB,YAAY,KAAK,YAAY,EAC7B,CAAC;4BACD,mBAAmB,GAAG,IAAI,CAAC;wBAC7B,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YAED,uBAAuB;YACvB,cAAc,CAAC,IAAI;gBACjB,MAAM,UAAU,GAAG,IAAA,8BAAa,EAAC,IAAI,CAAC,CAAC;gBAEvC,IAAI,CAAC,UAAU;oBAAE,OAAO;gBAExB,iCAAiC;gBACjC,IAAI,UAAU,KAAK,oBAAoB,EAAE,CAAC;oBACxC,eAAe,GAAG,IAAI,CAAC;gBACzB,CAAC;gBAED,yBAAyB;gBACzB,IAAI,sBAAsB,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;oBAChD,iBAAiB,GAAG,IAAI,CAAC;gBAC3B,CAAC;gBAED,2EAA2E;gBAC3E,IAAI,UAAU,KAAK,OAAO,EAAE,CAAC;oBAC3B,6DAA6D;oBAC7D,gFAAgF;oBAChF,IAAI,CAAC,mBAAmB,EAAE,CAAC;wBACzB,SAAS,GAAG,IAAI,CAAC;wBACjB,UAAU,GAAG,IAAiB,CAAC;oBACjC,CAAC;gBACH,CAAC;YACH,CAAC;YAED,kCAAkC;YAClC,cAAc;gBACZ,mBAAmB;gBACnB,0DAA0D;gBAC1D,iCAAiC;gBACjC,+DAA+D;gBAC/D,MAAM,qBAAqB,GACzB,iBAAiB,IAAI,eAAe,IAAI,iBAAiB,IAAI,mBAAmB,CAAC;gBAEnF,IAAI,SAAS,IAAI,CAAC,qBAAqB,IAAI,UAAU,EAAE,CAAC;oBACtD,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,UAAU;wBAChB,SAAS,EAAE,iBAAiB;qBAC7B,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,kBAAe,IAAI,CAAC"}

package/dist/rules/require-backend.d.ts

@@ -1,4 +1,21 @@
 import type { Rule } from 'eslint';
+/**
+ * require-backend
+ *
+ * IMPORTANT: getAI(app) without a second argument is VALID.
+ * Firebase AI Logic uses GoogleAIBackend by default when no backend is specified.
+ *
+ * This rule only reports when:
+ * - A second argument (config object) exists BUT doesn't have 'backend' property
+ *
+ * Valid usage:
+ * - getAI(app) - Uses GoogleAIBackend by default ✅
+ * - getAI(app, { backend: new GoogleAIBackend() }) ✅
+ * - getAI(app, { backend: new VertexAIBackend() }) ✅
+ *
+ * Invalid usage:
+ * - getAI(app, { someOtherConfig: true }) - Has config but no backend ❌
+ */
 declare const rule: Rule.RuleModule;
 export default rule;
 //# sourceMappingURL=require-backend.d.ts.map

package/dist/rules/require-backend.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"require-backend.d.ts","sourceRoot":"","sources":["../../src/rules/require-backend.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAOnC,QAAA,MAAM,IAAI,EAAE,IAAI,CAAC,UA2GhB,CAAC;AAEF,eAAe,IAAI,CAAC"}
+{"version":3,"file":"require-backend.d.ts","sourceRoot":"","sources":["../../src/rules/require-backend.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAOnC;;;;;;;;;;;;;;;;GAgBG;AACH,QAAA,MAAM,IAAI,EAAE,IAAI,CAAC,UAyEhB,CAAC;AAEF,eAAe,IAAI,CAAC"}