eslint-plugin-express-security 3.2.2 → 3.2.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +2 -2
- package/package.json +14 -2
- package/src/index.js +1 -1
- package/src/rules/no-error-details-in-response/index.js +1 -1
package/README.md
CHANGED
|
@@ -1,5 +1,5 @@
|
|
|
1
1
|
<p align="center">
|
|
2
|
-
<a href="https://eslint.interlace.tools
|
|
2
|
+
<a href="https://eslint.interlace.tools/docs/security/plugin-express-security?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security" target="blank"><picture><source media="(prefers-color-scheme: dark)" srcset="https://eslint.interlace.tools/logos/interlace-dark.svg"><img src="https://eslint.interlace.tools/logos/interlace-light.svg" alt="Interlace" height="90" /></picture></a>
|
|
3
3
|
|
|
4
4
|
<a href="https://expressjs.com" target="_blank"><img src="https://eslint.interlace.tools/logos/express.svg" alt="Express" height="90" /></a>
|
|
5
5
|
|
|
@@ -195,5 +195,5 @@ MIT © [Ofri Peretz](https://github.com/ofri-peretz)
|
|
|
195
195
|
</p>
|
|
196
196
|
|
|
197
197
|
<p align="center">
|
|
198
|
-
<a href="https://eslint.interlace.tools
|
|
198
|
+
<a href="https://eslint.interlace.tools/docs/security/plugin-express-security?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security" target="blank"><picture><source media="(prefers-color-scheme: dark)" srcset="https://eslint.interlace.tools/logos/interlace-dark.svg"><img src="https://eslint.interlace.tools/logos/interlace-light.svg" alt="Interlace" height="70" /></picture></a>
|
|
199
199
|
</p>
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "eslint-plugin-express-security",
|
|
3
|
-
"version": "3.2.
|
|
3
|
+
"version": "3.2.4",
|
|
4
4
|
"description": "ESLint plugin for Express.js security — detects permissive CORS, missing CSRF protection, missing helmet headers, insecure cookies, and GraphQL introspection in production.",
|
|
5
5
|
"type": "commonjs",
|
|
6
6
|
"main": "./src/index.js",
|
|
@@ -76,7 +76,7 @@
|
|
|
76
76
|
"node": ">=18.0.0"
|
|
77
77
|
},
|
|
78
78
|
"dependencies": {
|
|
79
|
-
"@interlace/eslint-devkit": "^1.19.
|
|
79
|
+
"@interlace/eslint-devkit": "^1.19.2"
|
|
80
80
|
},
|
|
81
81
|
"peerDependencies": {
|
|
82
82
|
"eslint": "^8.40.0 || ^9.0.0 || ^10.0.0",
|
|
@@ -106,5 +106,17 @@
|
|
|
106
106
|
"funding": {
|
|
107
107
|
"type": "github",
|
|
108
108
|
"url": "git+https://github.com/ofri-peretz/eslint.git"
|
|
109
|
+
},
|
|
110
|
+
"interlace": {
|
|
111
|
+
"surface": {
|
|
112
|
+
"kind": "npm",
|
|
113
|
+
"modules": [
|
|
114
|
+
"express",
|
|
115
|
+
"helmet",
|
|
116
|
+
"cors",
|
|
117
|
+
"csurf",
|
|
118
|
+
"express-rate-limit"
|
|
119
|
+
]
|
|
120
|
+
}
|
|
109
121
|
}
|
|
110
122
|
}
|
package/src/index.js
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");exports.rules={get"require-helmet"(){return require("./rules/require-helmet").requireHelmet},get"no-permissive-cors"(){return require("./rules/no-permissive-cors").noPermissiveCors},get"require-csrf-protection"(){return require("./rules/require-csrf-protection").requireCsrfProtection},get"no-insecure-cookie-options"(){return require("./rules/no-insecure-cookie-options").noInsecureCookieOptions},get"require-rate-limiting"(){return require("./rules/require-rate-limiting").requireRateLimiting},get"no-graphql-introspection-production"(){return require("./rules/no-graphql-introspection-production").noGraphqlIntrospectionProduction},get"no-cors-credentials-wildcard"(){return require("./rules/no-cors-credentials-wildcard").noCorsCredentialsWildcard},get"require-express-body-parser-limits"(){return require("./rules/require-express-body-parser-limits").requireExpressBodyParserLimits},get"no-express-unsafe-regex-route"(){return require("./rules/no-express-unsafe-regex-route").noExpressUnsafeRegexRoute},get"no-exposed-debug-endpoints"(){return require("./rules/no-exposed-debug-endpoints").noExposedDebugEndpoints},get"no-missing-cors-check"(){return require("./rules/no-missing-cors-check").noMissingCorsCheck},get"no-missing-csrf-protection"(){return require("./rules/no-missing-csrf-protection").noMissingCsrfProtection},get"no-missing-security-headers"(){return require("./rules/no-missing-security-headers").noMissingSecurityHeaders},get"no-user-controlled-redirect"(){return require("./rules/no-user-controlled-redirect").noUserControlledRedirect},get"no-host-header-in-links"(){return require("./rules/no-host-header-in-links").noHostHeaderInLinks},get"no-error-details-in-response"(){return require("./rules/no-error-details-in-response").noErrorDetailsInResponse},get"no-sensitive-data-in-query"(){return require("./rules/no-sensitive-data-in-query").noSensitiveDataInQuery},get"no-user-controlled-render-locals"(){return require("./rules/no-user-controlled-render-locals").noUserControlledRenderLocals},get"no-static-root-exposure"(){return require("./rules/no-static-root-exposure").noStaticRootExposure},get"require-case-insensitive-path-guard"(){return require("./rules/require-case-insensitive-path-guard").requireCaseInsensitivePathGuard},get"require-query-type-guard"(){return require("./rules/require-query-type-guard").requireQueryTypeGuard},get"no-disabled-helmet-protections"(){return require("./rules/no-disabled-helmet-protections").noDisabledHelmetProtections},get"require-strict-transport-security"(){return require("./rules/require-strict-transport-security").requireStrictTransportSecurity},get"no-unsafe-csp-directives"(){return require("./rules/no-unsafe-csp-directives").noUnsafeCspDirectives},get"no-permissive-trust-proxy"(){return require("./rules/no-permissive-trust-proxy").noPermissiveTrustProxy},get"require-route-authentication"(){return require("./rules/require-route-authentication").requireRouteAuthentication},get"no-client-controlled-authorization"(){return require("./rules/no-client-controlled-authorization").noClientControlledAuthorization},get"no-idor-resource-access"(){return require("./rules/no-idor-resource-access").noIdorResourceAccess}};(0,eslint_devkit_1.withCanonicalDocsUrls)("plugin-express-security",exports.rules);exports.plugin={meta:{name:"eslint-plugin-express-security",version:"3.2.
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");exports.rules={get"require-helmet"(){return require("./rules/require-helmet").requireHelmet},get"no-permissive-cors"(){return require("./rules/no-permissive-cors").noPermissiveCors},get"require-csrf-protection"(){return require("./rules/require-csrf-protection").requireCsrfProtection},get"no-insecure-cookie-options"(){return require("./rules/no-insecure-cookie-options").noInsecureCookieOptions},get"require-rate-limiting"(){return require("./rules/require-rate-limiting").requireRateLimiting},get"no-graphql-introspection-production"(){return require("./rules/no-graphql-introspection-production").noGraphqlIntrospectionProduction},get"no-cors-credentials-wildcard"(){return require("./rules/no-cors-credentials-wildcard").noCorsCredentialsWildcard},get"require-express-body-parser-limits"(){return require("./rules/require-express-body-parser-limits").requireExpressBodyParserLimits},get"no-express-unsafe-regex-route"(){return require("./rules/no-express-unsafe-regex-route").noExpressUnsafeRegexRoute},get"no-exposed-debug-endpoints"(){return require("./rules/no-exposed-debug-endpoints").noExposedDebugEndpoints},get"no-missing-cors-check"(){return require("./rules/no-missing-cors-check").noMissingCorsCheck},get"no-missing-csrf-protection"(){return require("./rules/no-missing-csrf-protection").noMissingCsrfProtection},get"no-missing-security-headers"(){return require("./rules/no-missing-security-headers").noMissingSecurityHeaders},get"no-user-controlled-redirect"(){return require("./rules/no-user-controlled-redirect").noUserControlledRedirect},get"no-host-header-in-links"(){return require("./rules/no-host-header-in-links").noHostHeaderInLinks},get"no-error-details-in-response"(){return require("./rules/no-error-details-in-response").noErrorDetailsInResponse},get"no-sensitive-data-in-query"(){return require("./rules/no-sensitive-data-in-query").noSensitiveDataInQuery},get"no-user-controlled-render-locals"(){return require("./rules/no-user-controlled-render-locals").noUserControlledRenderLocals},get"no-static-root-exposure"(){return require("./rules/no-static-root-exposure").noStaticRootExposure},get"require-case-insensitive-path-guard"(){return require("./rules/require-case-insensitive-path-guard").requireCaseInsensitivePathGuard},get"require-query-type-guard"(){return require("./rules/require-query-type-guard").requireQueryTypeGuard},get"no-disabled-helmet-protections"(){return require("./rules/no-disabled-helmet-protections").noDisabledHelmetProtections},get"require-strict-transport-security"(){return require("./rules/require-strict-transport-security").requireStrictTransportSecurity},get"no-unsafe-csp-directives"(){return require("./rules/no-unsafe-csp-directives").noUnsafeCspDirectives},get"no-permissive-trust-proxy"(){return require("./rules/no-permissive-trust-proxy").noPermissiveTrustProxy},get"require-route-authentication"(){return require("./rules/require-route-authentication").requireRouteAuthentication},get"no-client-controlled-authorization"(){return require("./rules/no-client-controlled-authorization").noClientControlledAuthorization},get"no-idor-resource-access"(){return require("./rules/no-idor-resource-access").noIdorResourceAccess}};(0,eslint_devkit_1.withCanonicalDocsUrls)("plugin-express-security",exports.rules);exports.plugin={meta:{name:"eslint-plugin-express-security",version:"3.2.4"},rules:exports.rules};const recommendedRules={"express-security/require-helmet":"error","express-security/no-permissive-cors":"error","express-security/require-csrf-protection":"warn","express-security/no-insecure-cookie-options":"error","express-security/require-rate-limiting":"error","express-security/no-graphql-introspection-production":"warn","express-security/no-cors-credentials-wildcard":"error","express-security/require-express-body-parser-limits":"warn","express-security/no-express-unsafe-regex-route":"error","express-security/no-exposed-debug-endpoints":"error","express-security/no-user-controlled-redirect":"error","express-security/no-host-header-in-links":"error","express-security/no-error-details-in-response":"error","express-security/no-sensitive-data-in-query":"warn","express-security/no-user-controlled-render-locals":"error","express-security/no-static-root-exposure":"error","express-security/require-case-insensitive-path-guard":"warn","express-security/require-query-type-guard":"warn","express-security/no-disabled-helmet-protections":"error","express-security/require-strict-transport-security":"error","express-security/no-unsafe-csp-directives":"error","express-security/no-permissive-trust-proxy":"error","express-security/require-route-authentication":"warn","express-security/no-client-controlled-authorization":"warn","express-security/no-idor-resource-access":"warn"};exports.configs={recommended:{plugins:{"express-security":exports.plugin},rules:recommendedRules},strict:{plugins:{"express-security":exports.plugin},rules:Object.fromEntries(Object.keys(exports.rules).map(ruleName=>[`express-security/${ruleName}`,"error"]))},api:{plugins:{"express-security":exports.plugin},rules:{"express-security/require-helmet":"error","express-security/no-disabled-helmet-protections":"error","express-security/require-strict-transport-security":"error","express-security/no-unsafe-csp-directives":"error","express-security/no-permissive-trust-proxy":"error","express-security/no-permissive-cors":"error","express-security/require-csrf-protection":"error","express-security/no-insecure-cookie-options":"error","express-security/require-rate-limiting":"error"}},graphql:{plugins:{"express-security":exports.plugin},rules:{"express-security/no-graphql-introspection-production":"error"}}};exports.default=exports.plugin;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noErrorDetailsInResponse=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const SEND_METHODS=new Set(["send","json","end"]);const ERROR_PARAM_NAME=/^(err|error)$/i;exports.noErrorDetailsInResponse=(0,eslint_devkit_1.createRule)({name:"no-error-details-in-response",meta:{type:"problem",hasSuggestions:false,docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-error-details-in-response.md",description:"Disallow sending caught error objects, stacks, or spreads of them in HTTP responses",cwe:"CWE-209",cvss:5.3},messages:{errorDetailsExposed:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Error Details Exposed (CWE-209)",cwe:"CWE-209",description:"The HTTP response includes {{detail}}. Stack traces and driver errors leak file paths, dependency versions, query text and hostnames to the caller.",severity:"MEDIUM",fix:"Log the error server-side and respond with a generic body: logger.error(err); res.status(500).json({ error: 'Internal Server Error' })",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Error_Handling_Cheat_Sheet.html"})},schema:[{type:"object",properties:{allowMessage:{type:"boolean",default:true,description:"Allow err.message in responses"},allowInDev:{type:"boolean",default:false,description:"Allow error details inside an if-guard checking NODE_ENV"}},additionalProperties:false}]},defaultOptions:[{}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowMessage,allowInDev}=options;const messageAllowed=allowMessage??true;const devAllowed=allowInDev??false;const sourceCode=context.sourceCode;const frames=[];function isErrorName(name){return frames.some(frame=>frame.name===name)}function enterFunction(node){const first=node.params[0];if(first!==void 0&&first.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&ERROR_PARAM_NAME.test(first.name)){frames.push({node,name:first.name})}}function exitFrame(node){if(frames.length>0&&frames[frames.length-1].node===node){frames.pop()}}function isResponseSend(node){const callee=node.callee;if(callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return false;
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noErrorDetailsInResponse=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const SEND_METHODS=new Set(["send","json","end"]);const ERROR_PARAM_NAME=/^(err|error)$/i;exports.noErrorDetailsInResponse=(0,eslint_devkit_1.createRule)({name:"no-error-details-in-response",meta:{type:"problem",hasSuggestions:false,docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-error-details-in-response.md",description:"Disallow sending caught error objects, stacks, or spreads of them in HTTP responses",cwe:"CWE-209",cvss:5.3},messages:{errorDetailsExposed:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Error Details Exposed (CWE-209)",cwe:"CWE-209",description:"The HTTP response includes {{detail}}. Stack traces and driver errors leak file paths, dependency versions, query text and hostnames to the caller.",severity:"MEDIUM",fix:"Log the error server-side and respond with a generic body: logger.error(err); res.status(500).json({ error: 'Internal Server Error' })",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Error_Handling_Cheat_Sheet.html"})},schema:[{type:"object",properties:{allowMessage:{type:"boolean",default:true,description:"Allow err.message in responses"},allowInDev:{type:"boolean",default:false,description:"Allow error details inside an if-guard checking NODE_ENV"}},additionalProperties:false}]},defaultOptions:[{}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowMessage,allowInDev}=options;const messageAllowed=allowMessage??true;const devAllowed=allowInDev??false;const sourceCode=context.sourceCode;const frames=[];function isErrorName(name){return frames.some(frame=>frame.name===name)}function enterFunction(node){const first=node.params[0];if(first!==void 0&&first.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&ERROR_PARAM_NAME.test(first.name)){frames.push({node,name:first.name})}}function exitFrame(node){if(frames.length>0&&frames[frames.length-1].node===node){frames.pop()}}function isResponseSend(node){const callee=node.callee;if(callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return false;const method=(0,eslint_devkit_1.propertyName)(callee);if(method===null||!SEND_METHODS.has(method))return false;let obj=callee.object;while(obj.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&obj.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression){obj=obj.callee.object}if(obj.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const lower=obj.name.toLowerCase();return lower==="res"||lower==="response"||lower==="reply"}function detailOf(node){if(node.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&isErrorName(node.name)){return`the raw error \`${node.name}\``}if(node.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&node.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&isErrorName(node.object.name)&&(0,eslint_devkit_1.propertyName)(node)!==null){const field=(0,eslint_devkit_1.propertyName)(node);if(field==="stack"){return`\`${node.object.name}.stack\``}if(field==="message"&&!messageAllowed){return`\`${node.object.name}.message\``}}return null}function collectFindings(arg){const direct=detailOf(arg);if(direct!==null)return[{node:arg,detail:direct}];if(arg.type!==eslint_devkit_1.AST_NODE_TYPES.ObjectExpression)return[];const findings=[];for(const prop of arg.properties){if(prop.type===eslint_devkit_1.AST_NODE_TYPES.SpreadElement){if(prop.argument.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&isErrorName(prop.argument.name)){findings.push({node:prop,detail:`\`{ ...${prop.argument.name} }\` (spread of the raw error)`})}continue}const detail=detailOf(prop.value);if(detail!==null)findings.push({node:prop.value,detail})}return findings}function isInDevGuard(node){let current=node.parent;while(current!=null){if(current.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement&&sourceCode.getText(current.test).includes("NODE_ENV")){return true}current=current.parent}return false}return{CatchClause(node){if(node.param!==null&&node.param.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){frames.push({node,name:node.param.name})}},"CatchClause:exit":exitFrame,FunctionDeclaration:enterFunction,"FunctionDeclaration:exit":exitFrame,FunctionExpression:enterFunction,"FunctionExpression:exit":exitFrame,ArrowFunctionExpression:enterFunction,"ArrowFunctionExpression:exit":exitFrame,CallExpression(node){if(frames.length===0)return;if(!isResponseSend(node))return;const arg=node.arguments[0];if(arg===void 0)return;if(devAllowed&&isInDevGuard(node))return;for(const finding of collectFindings(arg)){context.report({node:finding.node,messageId:"errorDetailsExposed",data:{detail:finding.detail}})}}}}});
|