eslint-plugin-express-security 3.1.1 → 3.1.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/README.md CHANGED
@@ -140,11 +140,15 @@ See the [ESLint Version Support Policy](../../docs/ESLINT_VERSION_SUPPORT.md)
140
140
  | [no-host-header-in-links](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-host-header-in-links?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-640 | A07:2021 | | Disallow building absolute URLs (password-reset and verification links) from the Host or X-Forwarded-Host r… | 🟢 | 💼 | | | | |
141
141
  | [no-idor-resource-access](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-idor-resource-access?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-639 | A01:2021 | | This rule detects a resource fetched by an identifier taken straight from the request inside a handler that… | 🟢 | | ⚠️ | | | |
142
142
  | [no-insecure-cookie-options](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-insecure-cookie-options?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-614 | | | The rule provides LLM-optimized error messages (Compact 2-line format) with actionable security guidance: | 🟢 | 💼 | | | | |
143
+ | [no-missing-cors-check](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-missing-cors-check?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-346 | | | Detects missing CORS validation (wildcard CORS, missing origin check) | 🟢 | | | | | |
144
+ | [no-missing-csrf-protection](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-missing-csrf-protection?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-352 | | | Detects missing CSRF token validation in POST/PUT/DELETE requests | 🟢 | | | | | |
145
+ | [no-missing-security-headers](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-missing-security-headers?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-693 | | | Detects missing security headers in HTTP responses | 🟢 | | | | | |
143
146
  | [no-permissive-cors](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-permissive-cors?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-942 | | | Detects overly permissive CORS configurations in Express.js applications | 🟢 | 💼 | | | | |
144
147
  | [no-permissive-trust-proxy](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-permissive-trust-proxy?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-348 | A05:2021 | | This rule detects unconditional 'trust proxy' settings, which make req.ip whatever the caller says it is an… | 🟢 | 💼 | | | | |
145
148
  | [no-sensitive-data-in-query](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-sensitive-data-in-query?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-598 | A04:2021 | | Disallow reading sensitive-named parameters (password, token, secret, apiKey, ...) from req.query. | 🟢 | | ⚠️ | | | |
146
149
  | [no-static-root-exposure](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-static-root-exposure?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-548 | A05:2021 | | Disallow express.static() roots that expose the application directory and any serve-index usage | 🟢 | 💼 | | | | |
147
150
  | [no-unsafe-csp-directives](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-unsafe-csp-directives?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-79 | A03:2021 | | This rule detects Content-Security-Policy directives that hand back the protection the header exists to pro… | 🟢 | 💼 | | | | |
151
+ | [no-user-controlled-redirect](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-user-controlled-redirect?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-601 | | | Disallow res.redirect() with values directly from req.query / req.body / req.params | 🟢 | 💼 | | | | |
148
152
  | [no-user-controlled-render-locals](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/no-user-controlled-render-locals?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-73 | A03:2021 | | Disallow res.render() with locals or view names sourced wholesale from req.body / req.query / req.params | 🟢 | 💼 | | | | |
149
153
  | [require-case-insensitive-path-guard](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/require-case-insensitive-path-guard?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-178 | A01:2021 | | This rule detects path-based authorization guards that compare req.path case-sensitively, which case-insens… | 🟢 | | ⚠️ | | | |
150
154
  | [require-csrf-protection](https://eslint.interlace.tools/docs/security/plugin-express-security/rules/require-csrf-protection?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-express-security) | CWE-352 | | | The rule provides LLM-optimized error messages (Compact 2-line format) with actionable security guidance: | 🟢 | | ⚠️ | | | |
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "eslint-plugin-express-security",
3
- "version": "3.1.1",
3
+ "version": "3.1.3",
4
4
  "description": "ESLint plugin for Express.js security — detects permissive CORS, missing CSRF protection, missing helmet headers, insecure cookies, and GraphQL introspection in production.",
5
5
  "type": "commonjs",
6
6
  "main": "./src/index.js",
@@ -76,7 +76,7 @@
76
76
  "node": ">=18.0.0"
77
77
  },
78
78
  "dependencies": {
79
- "@interlace/eslint-devkit": "^1.16.0"
79
+ "@interlace/eslint-devkit": "^1.17.2"
80
80
  },
81
81
  "peerDependencies": {
82
82
  "eslint": "^8.40.0 || ^9.0.0 || ^10.0.0",
package/src/index.js CHANGED
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;exports.rules={get"require-helmet"(){return require("./rules/require-helmet").requireHelmet},get"no-permissive-cors"(){return require("./rules/no-permissive-cors").noPermissiveCors},get"require-csrf-protection"(){return require("./rules/require-csrf-protection").requireCsrfProtection},get"no-insecure-cookie-options"(){return require("./rules/no-insecure-cookie-options").noInsecureCookieOptions},get"require-rate-limiting"(){return require("./rules/require-rate-limiting").requireRateLimiting},get"no-graphql-introspection-production"(){return require("./rules/no-graphql-introspection-production").noGraphqlIntrospectionProduction},get"no-cors-credentials-wildcard"(){return require("./rules/no-cors-credentials-wildcard").noCorsCredentialsWildcard},get"require-express-body-parser-limits"(){return require("./rules/require-express-body-parser-limits").requireExpressBodyParserLimits},get"no-express-unsafe-regex-route"(){return require("./rules/no-express-unsafe-regex-route").noExpressUnsafeRegexRoute},get"no-exposed-debug-endpoints"(){return require("./rules/no-exposed-debug-endpoints").noExposedDebugEndpoints},get"no-missing-cors-check"(){return require("./rules/no-missing-cors-check").noMissingCorsCheck},get"no-missing-csrf-protection"(){return require("./rules/no-missing-csrf-protection").noMissingCsrfProtection},get"no-missing-security-headers"(){return require("./rules/no-missing-security-headers").noMissingSecurityHeaders},get"no-user-controlled-redirect"(){return require("./rules/no-user-controlled-redirect").noUserControlledRedirect},get"no-host-header-in-links"(){return require("./rules/no-host-header-in-links").noHostHeaderInLinks},get"no-error-details-in-response"(){return require("./rules/no-error-details-in-response").noErrorDetailsInResponse},get"no-sensitive-data-in-query"(){return require("./rules/no-sensitive-data-in-query").noSensitiveDataInQuery},get"no-user-controlled-render-locals"(){return require("./rules/no-user-controlled-render-locals").noUserControlledRenderLocals},get"no-static-root-exposure"(){return require("./rules/no-static-root-exposure").noStaticRootExposure},get"require-case-insensitive-path-guard"(){return require("./rules/require-case-insensitive-path-guard").requireCaseInsensitivePathGuard},get"require-query-type-guard"(){return require("./rules/require-query-type-guard").requireQueryTypeGuard},get"no-disabled-helmet-protections"(){return require("./rules/no-disabled-helmet-protections").noDisabledHelmetProtections},get"require-strict-transport-security"(){return require("./rules/require-strict-transport-security").requireStrictTransportSecurity},get"no-unsafe-csp-directives"(){return require("./rules/no-unsafe-csp-directives").noUnsafeCspDirectives},get"no-permissive-trust-proxy"(){return require("./rules/no-permissive-trust-proxy").noPermissiveTrustProxy},get"require-route-authentication"(){return require("./rules/require-route-authentication").requireRouteAuthentication},get"no-client-controlled-authorization"(){return require("./rules/no-client-controlled-authorization").noClientControlledAuthorization},get"no-idor-resource-access"(){return require("./rules/no-idor-resource-access").noIdorResourceAccess}};exports.plugin={meta:{name:"eslint-plugin-express-security",version:"3.1.1"},rules:exports.rules};const recommendedRules={"express-security/require-helmet":"error","express-security/no-permissive-cors":"error","express-security/require-csrf-protection":"warn","express-security/no-insecure-cookie-options":"error","express-security/require-rate-limiting":"error","express-security/no-graphql-introspection-production":"warn","express-security/no-cors-credentials-wildcard":"error","express-security/require-express-body-parser-limits":"warn","express-security/no-express-unsafe-regex-route":"error","express-security/no-exposed-debug-endpoints":"error","express-security/no-user-controlled-redirect":"error","express-security/no-host-header-in-links":"error","express-security/no-error-details-in-response":"error","express-security/no-sensitive-data-in-query":"warn","express-security/no-user-controlled-render-locals":"error","express-security/no-static-root-exposure":"error","express-security/require-case-insensitive-path-guard":"warn","express-security/require-query-type-guard":"warn","express-security/no-disabled-helmet-protections":"error","express-security/require-strict-transport-security":"error","express-security/no-unsafe-csp-directives":"error","express-security/no-permissive-trust-proxy":"error","express-security/require-route-authentication":"warn","express-security/no-client-controlled-authorization":"warn","express-security/no-idor-resource-access":"warn"};exports.configs={recommended:{plugins:{"express-security":exports.plugin},rules:recommendedRules},strict:{plugins:{"express-security":exports.plugin},rules:Object.fromEntries(Object.keys(exports.rules).map(ruleName=>[`express-security/${ruleName}`,"error"]))},api:{plugins:{"express-security":exports.plugin},rules:{"express-security/require-helmet":"error","express-security/no-disabled-helmet-protections":"error","express-security/require-strict-transport-security":"error","express-security/no-unsafe-csp-directives":"error","express-security/no-permissive-trust-proxy":"error","express-security/no-permissive-cors":"error","express-security/require-csrf-protection":"error","express-security/no-insecure-cookie-options":"error","express-security/require-rate-limiting":"error"}},graphql:{plugins:{"express-security":exports.plugin},rules:{"express-security/no-graphql-introspection-production":"error"}}};exports.default=exports.plugin;
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");exports.rules={get"require-helmet"(){return require("./rules/require-helmet").requireHelmet},get"no-permissive-cors"(){return require("./rules/no-permissive-cors").noPermissiveCors},get"require-csrf-protection"(){return require("./rules/require-csrf-protection").requireCsrfProtection},get"no-insecure-cookie-options"(){return require("./rules/no-insecure-cookie-options").noInsecureCookieOptions},get"require-rate-limiting"(){return require("./rules/require-rate-limiting").requireRateLimiting},get"no-graphql-introspection-production"(){return require("./rules/no-graphql-introspection-production").noGraphqlIntrospectionProduction},get"no-cors-credentials-wildcard"(){return require("./rules/no-cors-credentials-wildcard").noCorsCredentialsWildcard},get"require-express-body-parser-limits"(){return require("./rules/require-express-body-parser-limits").requireExpressBodyParserLimits},get"no-express-unsafe-regex-route"(){return require("./rules/no-express-unsafe-regex-route").noExpressUnsafeRegexRoute},get"no-exposed-debug-endpoints"(){return require("./rules/no-exposed-debug-endpoints").noExposedDebugEndpoints},get"no-missing-cors-check"(){return require("./rules/no-missing-cors-check").noMissingCorsCheck},get"no-missing-csrf-protection"(){return require("./rules/no-missing-csrf-protection").noMissingCsrfProtection},get"no-missing-security-headers"(){return require("./rules/no-missing-security-headers").noMissingSecurityHeaders},get"no-user-controlled-redirect"(){return require("./rules/no-user-controlled-redirect").noUserControlledRedirect},get"no-host-header-in-links"(){return require("./rules/no-host-header-in-links").noHostHeaderInLinks},get"no-error-details-in-response"(){return require("./rules/no-error-details-in-response").noErrorDetailsInResponse},get"no-sensitive-data-in-query"(){return require("./rules/no-sensitive-data-in-query").noSensitiveDataInQuery},get"no-user-controlled-render-locals"(){return require("./rules/no-user-controlled-render-locals").noUserControlledRenderLocals},get"no-static-root-exposure"(){return require("./rules/no-static-root-exposure").noStaticRootExposure},get"require-case-insensitive-path-guard"(){return require("./rules/require-case-insensitive-path-guard").requireCaseInsensitivePathGuard},get"require-query-type-guard"(){return require("./rules/require-query-type-guard").requireQueryTypeGuard},get"no-disabled-helmet-protections"(){return require("./rules/no-disabled-helmet-protections").noDisabledHelmetProtections},get"require-strict-transport-security"(){return require("./rules/require-strict-transport-security").requireStrictTransportSecurity},get"no-unsafe-csp-directives"(){return require("./rules/no-unsafe-csp-directives").noUnsafeCspDirectives},get"no-permissive-trust-proxy"(){return require("./rules/no-permissive-trust-proxy").noPermissiveTrustProxy},get"require-route-authentication"(){return require("./rules/require-route-authentication").requireRouteAuthentication},get"no-client-controlled-authorization"(){return require("./rules/no-client-controlled-authorization").noClientControlledAuthorization},get"no-idor-resource-access"(){return require("./rules/no-idor-resource-access").noIdorResourceAccess}};(0,eslint_devkit_1.withCanonicalDocsUrls)("plugin-express-security",exports.rules);exports.plugin={meta:{name:"eslint-plugin-express-security",version:"3.1.3"},rules:exports.rules};const recommendedRules={"express-security/require-helmet":"error","express-security/no-permissive-cors":"error","express-security/require-csrf-protection":"warn","express-security/no-insecure-cookie-options":"error","express-security/require-rate-limiting":"error","express-security/no-graphql-introspection-production":"warn","express-security/no-cors-credentials-wildcard":"error","express-security/require-express-body-parser-limits":"warn","express-security/no-express-unsafe-regex-route":"error","express-security/no-exposed-debug-endpoints":"error","express-security/no-user-controlled-redirect":"error","express-security/no-host-header-in-links":"error","express-security/no-error-details-in-response":"error","express-security/no-sensitive-data-in-query":"warn","express-security/no-user-controlled-render-locals":"error","express-security/no-static-root-exposure":"error","express-security/require-case-insensitive-path-guard":"warn","express-security/require-query-type-guard":"warn","express-security/no-disabled-helmet-protections":"error","express-security/require-strict-transport-security":"error","express-security/no-unsafe-csp-directives":"error","express-security/no-permissive-trust-proxy":"error","express-security/require-route-authentication":"warn","express-security/no-client-controlled-authorization":"warn","express-security/no-idor-resource-access":"warn"};exports.configs={recommended:{plugins:{"express-security":exports.plugin},rules:recommendedRules},strict:{plugins:{"express-security":exports.plugin},rules:Object.fromEntries(Object.keys(exports.rules).map(ruleName=>[`express-security/${ruleName}`,"error"]))},api:{plugins:{"express-security":exports.plugin},rules:{"express-security/require-helmet":"error","express-security/no-disabled-helmet-protections":"error","express-security/require-strict-transport-security":"error","express-security/no-unsafe-csp-directives":"error","express-security/no-permissive-trust-proxy":"error","express-security/no-permissive-cors":"error","express-security/require-csrf-protection":"error","express-security/no-insecure-cookie-options":"error","express-security/require-rate-limiting":"error"}},graphql:{plugins:{"express-security":exports.plugin},rules:{"express-security/no-graphql-introspection-production":"error"}}};exports.default=exports.plugin;
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noCorsCredentialsWildcard=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function hasWildcardOrigin(node,sourceCode){const text=sourceCode.getText(node);if(/\borigin\s*:\s*['"`]\*['"`]/.test(text)){return true}if(/\borigin\s*:\s*true\b/.test(text)){return true}return false}function hasCredentialsTrue(node,sourceCode){const text=sourceCode.getText(node);return/\bcredentials\s*:\s*true\b/.test(text)}function getCorsConfigNode(node){const callee=node.callee;if(callee.type==="Identifier"&&callee.name==="cors"){const parent=node.parent;if(parent&&parent.type==="CallExpression"&&parent.callee.type==="MemberExpression"&&parent.callee.property.type==="Identifier"&&parent.callee.property.name==="use"){return null}if(node.arguments[0]?.type==="ObjectExpression"){return node.arguments[0]}return null}if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="use"){const firstArg=node.arguments[0];if(firstArg?.type==="CallExpression"&&firstArg.callee.type==="Identifier"&&firstArg.callee.name==="cors"&&firstArg.arguments[0]?.type==="ObjectExpression"){return firstArg.arguments[0]}}return null}exports.noCorsCredentialsWildcard=(0,eslint_devkit_1.createRule)({name:"no-cors-credentials-wildcard",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-cors-credentials-wildcard.md",description:"Disallow credentials: true with wildcard CORS origin (CVE-2024-25124)",cwe:"CWE-942",cvss:7.5},hasSuggestions:true,messages:{credentialsWildcard:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"CORS Credentials with Wildcard Origin",cwe:"CWE-942",description:'Using credentials: true with origin: "*" or origin: true allows any domain to send credentials to your API. This is a critical vulnerability (CVE-2024-25124, CVSS 9.1).',severity:"CRITICAL",fix:'Specify explicit allowed origins: origin: ["https://trusted-domain.com"]',documentationLink:"https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-25124"}),useExplicitOrigins:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Explicit Origins",description:"Replace wildcard with explicit origin whitelist",severity:"LOW",fix:'origin: ["https://your-frontend.com"]',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow in test files"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}const sourceCode=context.sourceCode;return{CallExpression(node){const corsConfigNode=getCorsConfigNode(node);if(corsConfigNode){const hasWildcard=hasWildcardOrigin(corsConfigNode,sourceCode);const hasCredentials=hasCredentialsTrue(corsConfigNode,sourceCode);if(hasWildcard&&hasCredentials){context.report({node:corsConfigNode,messageId:"credentialsWildcard",suggest:[{messageId:"useExplicitOrigins",fix:()=>null}]})}}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noCorsCredentialsWildcard=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function hasWildcardOrigin(node,sourceCode){const text=sourceCode.getText(node);if(/\borigin\s*:\s*['"`]\*['"`]/.test(text)){return true}if(/\borigin\s*:\s*true\b/.test(text)){return true}return false}function hasCredentialsTrue(node,sourceCode){const text=sourceCode.getText(node);return/\bcredentials\s*:\s*true\b/.test(text)}function getCorsConfigNode(node){const callee=node.callee;if(callee.type==="Identifier"&&callee.name==="cors"){const parent=node.parent;if(parent&&parent.type==="CallExpression"&&parent.callee.type==="MemberExpression"&&parent.callee.property.type==="Identifier"&&parent.callee.property.name==="use"){return null}if(node.arguments[0]?.type==="ObjectExpression"){return node.arguments[0]}return null}if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="use"){const firstArg=node.arguments[0];if(firstArg?.type==="CallExpression"&&firstArg.callee.type==="Identifier"&&firstArg.callee.name==="cors"&&firstArg.arguments[0]?.type==="ObjectExpression"){return firstArg.arguments[0]}}return null}exports.noCorsCredentialsWildcard=(0,eslint_devkit_1.createRule)({name:"no-cors-credentials-wildcard",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-cors-credentials-wildcard.md",description:"Disallow credentials: true with wildcard CORS origin (CVE-2024-25124)",cwe:"CWE-942",cvss:7.5},messages:{credentialsWildcard:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"CORS Credentials with Wildcard Origin",cwe:"CWE-942",description:'Using credentials: true with origin: "*" or origin: true allows any domain to send credentials to your API. This is a critical vulnerability (CVE-2024-25124, CVSS 9.1).',severity:"CRITICAL",fix:'Specify explicit allowed origins: origin: ["https://trusted-domain.com"]',documentationLink:"https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-25124"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow in test files"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false}=options;const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);if(isTestFile){return{}}const sourceCode=context.sourceCode;return{CallExpression(node){const corsConfigNode=getCorsConfigNode(node);if(corsConfigNode){const hasWildcard=hasWildcardOrigin(corsConfigNode,sourceCode);const hasCredentials=hasCredentialsTrue(corsConfigNode,sourceCode);if(hasWildcard&&hasCredentials){context.report({node:corsConfigNode,messageId:"credentialsWildcard"})}}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noExposedDebugEndpoints=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const express_evidence_1=require("../../utils/express-evidence");const DEFAULT_DEBUG_PATHS=["/debug","/__debug__","/admin","/_admin","/test","/health"];const HTTP_METHODS=new Set(["get","post","put","patch","delete","head","options","all","use","route"]);exports.noExposedDebugEndpoints=(0,eslint_devkit_1.createRule)({name:"no-exposed-debug-endpoints",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-exposed-debug-endpoints.md",description:"Detect debug endpoints without auth in Express applications",cwe:"CWE-489",cvss:7.5},messages:{violationDetected:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Exposed Debug Endpoint",cwe:"CWE-489",description:"Debug endpoint exposed without authentication",severity:"HIGH",fix:"Remove debug endpoints from production or add authentication",documentationLink:"https://cwe.mitre.org/data/definitions/489.html"})},schema:[{type:"object",properties:{endpoints:{type:"array",items:{type:"string"},description:"Custom list of debug/admin endpoints to flag"},ignoreFiles:{type:"array",items:{type:"string"},description:"List of files or patterns to ignore"}},additionalProperties:false}]},defaultOptions:[{}],create(context){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const options=context.options[0]||{};const debugPaths=options.endpoints||DEFAULT_DEBUG_PATHS;const ignoreFiles=options.ignoreFiles||[];const filename=context.filename;if(ignoreFiles.some(pattern=>filename.includes(pattern))){return{}}const isExpressRouteCall=node=>{return node.callee.type==="MemberExpression"&&node.callee.object.type==="Identifier"&&["app","router","express"].includes(node.callee.object.name)&&node.callee.property.type==="Identifier"&&HTTP_METHODS.has(node.callee.property.name)};return{CallExpression(node){if(!isExpressRouteCall(node)){return}const isSettingLookup=node.callee.type==="MemberExpression"&&node.callee.property.type==="Identifier"&&node.callee.property.name==="get"&&node.arguments.length===1;if(isSettingLookup){return}const pathArg=node.arguments[0];if(pathArg&&pathArg.type==="Literal"&&typeof pathArg.value==="string"){const path=pathArg.value.toLowerCase();if(debugPaths.some(dp=>path.includes(dp.toLowerCase()))){context.report({node:pathArg,messageId:"violationDetected"})}}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noExposedDebugEndpoints=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const express_evidence_1=require("../../utils/express-evidence");const DEFAULT_DEBUG_PATHS=["/debug","/__debug__","/admin","/_admin","/test","/health"];const HTTP_METHODS=new Set(["get","post","put","patch","delete","head","options","all","use","route"]);exports.noExposedDebugEndpoints=(0,eslint_devkit_1.createRule)({name:"no-exposed-debug-endpoints",skipTestFiles:true,meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-exposed-debug-endpoints.md",description:"Detect debug endpoints without auth in Express applications",cwe:"CWE-489",cvss:7.5},messages:{violationDetected:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Exposed Debug Endpoint",cwe:"CWE-489",description:"Debug endpoint exposed without authentication",severity:"HIGH",fix:"Remove debug endpoints from production or add authentication",documentationLink:"https://cwe.mitre.org/data/definitions/489.html"})},schema:[{type:"object",properties:{endpoints:{type:"array",items:{type:"string"},description:"Custom list of debug/admin endpoints to flag"},ignoreFiles:{type:"array",items:{type:"string"},description:"List of files or patterns to ignore"}},additionalProperties:false}]},defaultOptions:[{}],create(context){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const options=context.options[0]||{};const debugPaths=options.endpoints||DEFAULT_DEBUG_PATHS;const ignoreFiles=options.ignoreFiles||[];const filename=context.filename;if(ignoreFiles.some(pattern=>filename.includes(pattern))){return{}}const isExpressRouteCall=node=>{return node.callee.type==="MemberExpression"&&node.callee.object.type==="Identifier"&&["app","router","express"].includes(node.callee.object.name)&&node.callee.property.type==="Identifier"&&HTTP_METHODS.has(node.callee.property.name)};return{CallExpression(node){if(!isExpressRouteCall(node)){return}const isSettingLookup=node.callee.type==="MemberExpression"&&node.callee.property.type==="Identifier"&&node.callee.property.name==="get"&&node.arguments.length===1;if(isSettingLookup){return}const pathArg=node.arguments[0];if(pathArg&&pathArg.type==="Literal"&&typeof pathArg.value==="string"){const path=pathArg.value.toLowerCase();if(debugPaths.some(dp=>path.includes(dp.toLowerCase()))){context.report({node:pathArg,messageId:"violationDetected"})}}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noExpressUnsafeRegexRoute=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const HTTP_METHODS=new Set(["get","post","put","patch","delete","all","use"]);const VULNERABLE_PATTERNS=[/\([^)]*[+*][^)]*\)[+*]/,/\([^)]*\|[^)]*\)[+*]/,/[+*]{2,}/,/\([^)]+\)[+*].*\\[1-9]/];const VULNERABLE_PARAM_PATTERNS=[/:[a-zA-Z_][a-zA-Z0-9_]*\+/,/:[a-zA-Z_][a-zA-Z0-9_]*\*/];function isVulnerableRegex(pattern){return VULNERABLE_PATTERNS.some(regex=>regex.test(pattern))}function hasVulnerableParamPattern(route){return VULNERABLE_PARAM_PATTERNS.some(regex=>regex.test(route))}exports.noExpressUnsafeRegexRoute=(0,eslint_devkit_1.createRule)({name:"no-express-unsafe-regex-route",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-express-unsafe-regex-route.md",description:"Disallow ReDoS-vulnerable regular expressions in Express.js route patterns",cwe:"CWE-1333",cvss:7.5},hasSuggestions:true,messages:{unsafeRegexRoute:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"ReDoS Vulnerable Route Pattern",cwe:"CWE-1333",description:"Route uses a regular expression vulnerable to Regular Expression Denial of Service (ReDoS). Malicious input can cause catastrophic backtracking.",severity:"HIGH",fix:"Simplify the regex pattern. Avoid nested quantifiers like (a+)+ and overlapping alternatives. Consider using a string route with explicit parameters.",documentationLink:"https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS"}),unsafeParamPattern:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Unsafe Route Parameter Pattern",cwe:"CWE-1333",description:"Route parameter uses + or * quantifier which can match multiple path segments, potentially causing ReDoS or unexpected behavior.",severity:"MEDIUM",fix:"Use explicit path segments instead of :param+ or :param*. For example: /api/:id/details instead of /api/:path+",documentationLink:"https://expressjs.com/en/guide/routing.html"}),refactorRoute:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Refactor Route",description:"Refactor to use a simpler, non-vulnerable pattern",severity:"LOW",fix:"Use string routes with explicit path segments",documentationLink:"https://expressjs.com/en/guide/routing.html"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow in test files"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}return{CallExpression(node){const callee=node.callee;if(callee.type!=="MemberExpression"){return}const property=callee.property;if(property.type!=="Identifier"){return}if(!HTTP_METHODS.has(property.name)){return}const routeArg=node.arguments[0];if(!routeArg){return}if(routeArg.type==="Literal"&&"regex"in routeArg&&routeArg.regex){const regexNode=routeArg;const pattern=regexNode.regex.pattern;if(isVulnerableRegex(pattern)){context.report({node:routeArg,messageId:"unsafeRegexRoute",suggest:[{messageId:"refactorRoute",fix:()=>null}]})}return}if(routeArg.type==="NewExpression"&&routeArg.callee.type==="Identifier"&&routeArg.callee.name==="RegExp"){const patternArg=routeArg.arguments[0];if(patternArg&&patternArg.type==="Literal"&&typeof patternArg.value==="string"){if(isVulnerableRegex(patternArg.value)){context.report({node:routeArg,messageId:"unsafeRegexRoute",suggest:[{messageId:"refactorRoute",fix:()=>null}]})}}return}if(routeArg.type==="Literal"&&typeof routeArg.value==="string"){if(hasVulnerableParamPattern(routeArg.value)){context.report({node:routeArg,messageId:"unsafeParamPattern",suggest:[{messageId:"refactorRoute",fix:()=>null}]})}}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noExpressUnsafeRegexRoute=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const HTTP_METHODS=new Set(["get","post","put","patch","delete","all","use"]);const VULNERABLE_PATTERNS=[/\([^)]*[+*][^)]*\)[+*]/,/\([^)]*\|[^)]*\)[+*]/,/[+*]{2,}/,/\([^)]+\)[+*].*\\[1-9]/];const VULNERABLE_PARAM_PATTERNS=[/:[a-zA-Z_][a-zA-Z0-9_]*\+/,/:[a-zA-Z_][a-zA-Z0-9_]*\*/];function isVulnerableRegex(pattern){return VULNERABLE_PATTERNS.some(regex=>regex.test(pattern))}function hasVulnerableParamPattern(route){return VULNERABLE_PARAM_PATTERNS.some(regex=>regex.test(route))}exports.noExpressUnsafeRegexRoute=(0,eslint_devkit_1.createRule)({name:"no-express-unsafe-regex-route",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-express-unsafe-regex-route.md",description:"Disallow ReDoS-vulnerable regular expressions in Express.js route patterns",cwe:"CWE-1333",cvss:7.5},messages:{unsafeRegexRoute:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"ReDoS Vulnerable Route Pattern",cwe:"CWE-1333",description:"Route uses a regular expression vulnerable to Regular Expression Denial of Service (ReDoS). Malicious input can cause catastrophic backtracking.",severity:"HIGH",fix:"Simplify the regex pattern. Avoid nested quantifiers like (a+)+ and overlapping alternatives. Consider using a string route with explicit parameters.",documentationLink:"https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS"}),unsafeParamPattern:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Unsafe Route Parameter Pattern",cwe:"CWE-1333",description:"Route parameter uses + or * quantifier which can match multiple path segments, potentially causing ReDoS or unexpected behavior.",severity:"MEDIUM",fix:"Use explicit path segments instead of :param+ or :param*. For example: /api/:id/details instead of /api/:path+",documentationLink:"https://expressjs.com/en/guide/routing.html"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow in test files"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false}=options;const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);if(isTestFile){return{}}return{CallExpression(node){const callee=node.callee;if(callee.type!=="MemberExpression"){return}const property=callee.property;if(property.type!=="Identifier"){return}if(!HTTP_METHODS.has(property.name)){return}const routeArg=node.arguments[0];if(!routeArg){return}if(routeArg.type==="Literal"&&"regex"in routeArg&&routeArg.regex){const regexNode=routeArg;const pattern=regexNode.regex.pattern;if(isVulnerableRegex(pattern)){context.report({node:routeArg,messageId:"unsafeRegexRoute"})}return}if(routeArg.type==="NewExpression"&&routeArg.callee.type==="Identifier"&&routeArg.callee.name==="RegExp"){const patternArg=routeArg.arguments[0];if(patternArg&&patternArg.type==="Literal"&&typeof patternArg.value==="string"){if(isVulnerableRegex(patternArg.value)){context.report({node:routeArg,messageId:"unsafeRegexRoute"})}}return}if(routeArg.type==="Literal"&&typeof routeArg.value==="string"){if(hasVulnerableParamPattern(routeArg.value)){context.report({node:routeArg,messageId:"unsafeParamPattern"})}}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noGraphqlIntrospectionProduction=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function hasIntrospectionEnabled(node,sourceCode){const text=sourceCode.getText(node);if(/\bintrospection\s*:\s*true\b/.test(text)){return true}return false}function hasProductionGuard(node,sourceCode){const text=sourceCode.getText(node);const productionGuards=[/introspection\s*:\s*process\.env\.NODE_ENV\s*[!=]==?\s*['"]production['"]/,/introspection\s*:\s*!?\s*isProd/,/introspection\s*:\s*!?\s*isProduction/,/introspection\s*:\s*process\.env\.NODE_ENV\s*[!=]==?\s*['"]development['"]/];return productionGuards.some(guard=>guard.test(text))}exports.noGraphqlIntrospectionProduction=(0,eslint_devkit_1.createRule)({name:"no-graphql-introspection-production",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-graphql-introspection-production.md",description:"Disallow GraphQL introspection in production environments",cwe:"CWE-200",cvss:5.3},hasSuggestions:true,messages:{graphqlIntrospection:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"GraphQL Introspection Enabled",cwe:"CWE-200",description:"GraphQL introspection is enabled. In production, this exposes your entire API schema to attackers.",severity:"MEDIUM",fix:"Set introspection: process.env.NODE_ENV !== 'production' or introspection: false",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/GraphQL_Cheat_Sheet.html#introspection-graphiql"}),disableIntrospection:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Disable Introspection in Production",description:"Disable GraphQL introspection for production",severity:"LOW",fix:"introspection: process.env.NODE_ENV !== 'production'",documentationLink:"https://www.apollographql.com/docs/apollo-server/api/apollo-server/#introspection"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:true},allowInDevelopment:{type:"boolean",default:true,description:"Allow introspection when the code is guarded by a development check"}},additionalProperties:false}]},defaultOptions:[{allowInTests:true,allowInDevelopment:true}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=true}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}const sourceCode=context.sourceCode;return{CallExpression(node){const callee=node.callee;const isGraphQLServer=callee.type==="Identifier"&&["ApolloServer","GraphQLServer","createServer"].includes(callee.name)||callee.type==="NewExpression"&&callee.callee.type==="Identifier"&&["ApolloServer","GraphQLServer"].includes(callee.callee.name);const isExpressGraphQL=callee.type==="Identifier"&&callee.name==="graphqlHTTP";if(!isGraphQLServer&&!isExpressGraphQL){return}const configArg=node.arguments[0];if(!configArg||configArg.type!=="ObjectExpression"){return}if(hasProductionGuard(configArg,sourceCode)){return}if(hasIntrospectionEnabled(configArg,sourceCode)){context.report({node:configArg,messageId:"graphqlIntrospection",suggest:[{messageId:"disableIntrospection",fix:()=>null}]})}},NewExpression(node){const callee=node.callee;if(callee.type!=="Identifier"||!["ApolloServer","GraphQLServer"].includes(callee.name)){return}const configArg=node.arguments[0];if(!configArg||configArg.type!=="ObjectExpression"){return}if(hasProductionGuard(configArg,sourceCode)){return}if(hasIntrospectionEnabled(configArg,sourceCode)){context.report({node:configArg,messageId:"graphqlIntrospection",suggest:[{messageId:"disableIntrospection",fix:()=>null}]})}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noGraphqlIntrospectionProduction=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function hasIntrospectionEnabled(node,sourceCode){const text=sourceCode.getText(node);if(/\bintrospection\s*:\s*true\b/.test(text)){return true}return false}function hasProductionGuard(node,sourceCode){const text=sourceCode.getText(node);const productionGuards=[/introspection\s*:\s*process\.env\.NODE_ENV\s*[!=]==?\s*['"]production['"]/,/introspection\s*:\s*!?\s*isProd/,/introspection\s*:\s*!?\s*isProduction/,/introspection\s*:\s*process\.env\.NODE_ENV\s*[!=]==?\s*['"]development['"]/];return productionGuards.some(guard=>guard.test(text))}exports.noGraphqlIntrospectionProduction=(0,eslint_devkit_1.createRule)({name:"no-graphql-introspection-production",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-graphql-introspection-production.md",description:"Disallow GraphQL introspection in production environments",cwe:"CWE-200",cvss:5.3},messages:{graphqlIntrospection:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"GraphQL Introspection Enabled",cwe:"CWE-200",description:"GraphQL introspection is enabled. In production, this exposes your entire API schema to attackers.",severity:"MEDIUM",fix:"Set introspection: process.env.NODE_ENV !== 'production' or introspection: false",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/GraphQL_Cheat_Sheet.html#introspection-graphiql"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:true},allowInDevelopment:{type:"boolean",default:true,description:"Allow introspection when the code is guarded by a development check"}},additionalProperties:false}]},defaultOptions:[{allowInTests:true,allowInDevelopment:true}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=true}=options;const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);if(isTestFile){return{}}const sourceCode=context.sourceCode;return{CallExpression(node){const callee=node.callee;const isGraphQLServer=callee.type==="Identifier"&&["ApolloServer","GraphQLServer","createServer"].includes(callee.name)||callee.type==="NewExpression"&&callee.callee.type==="Identifier"&&["ApolloServer","GraphQLServer"].includes(callee.callee.name);const isExpressGraphQL=callee.type==="Identifier"&&callee.name==="graphqlHTTP";if(!isGraphQLServer&&!isExpressGraphQL){return}const configArg=node.arguments[0];if(!configArg||configArg.type!=="ObjectExpression"){return}if(hasProductionGuard(configArg,sourceCode)){return}if(hasIntrospectionEnabled(configArg,sourceCode)){context.report({node:configArg,messageId:"graphqlIntrospection"})}},NewExpression(node){const callee=node.callee;if(callee.type!=="Identifier"||!["ApolloServer","GraphQLServer"].includes(callee.name)){return}const configArg=node.arguments[0];if(!configArg||configArg.type!=="ObjectExpression"){return}if(hasProductionGuard(configArg,sourceCode)){return}if(hasIntrospectionEnabled(configArg,sourceCode)){context.report({node:configArg,messageId:"graphqlIntrospection"})}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noHostHeaderInLinks=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const HOST_HEADER_NAMES=new Set(["host","x-forwarded-host"]);const HOST_GETTER_METHODS=new Set(["get","header"]);exports.noHostHeaderInLinks=(0,eslint_devkit_1.createRule)({name:"no-host-header-in-links",meta:{type:"problem",hasSuggestions:true,docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-host-header-in-links.md",description:"Disallow building absolute URLs (reset/verification links) from the Host or X-Forwarded-Host request header",cwe:"CWE-640",cvss:8.1},messages:{hostHeaderInLink:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Host-Header Poisoning (CWE-640)",cwe:"CWE-640",description:"A URL is built from {{source}}, which the client controls. Reset/verification links built this way can be redirected to an attacker-owned host, leaking the token.",severity:"HIGH",fix:"Build absolute links from a server-side constant (e.g. process.env.PUBLIC_ORIGIN), never from request headers.",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),useConfiguredOrigin:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use a configured origin",description:"Replace the header-derived host with a deployment constant such as process.env.PUBLIC_ORIGIN",severity:"LOW",fix:"const origin = process.env.PUBLIC_ORIGIN; // 'https://app.example.com'",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"})},schema:[{type:"object",properties:{allowedHosts:{type:"array",items:{type:"string"},description:"Trusted literal hosts \u2014 an if-guard comparing against one of these suppresses the report"},checkMailCallees:{type:"array",items:{type:"string"},description:'Callee names treated as mail-send sinks (default: ["sendMail", "send"])'}},additionalProperties:false}]},defaultOptions:[{}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowedHosts,checkMailCallees}=options;const allowed=allowedHosts??[];const mailCallees=new Set(checkMailCallees??["sendMail","send"]);const sourceCode=context.sourceCode;const hostVars=new Map;function isRequestIdent(name){const lower=name.toLowerCase();return lower==="req"||lower==="request"||lower==="ctx"}function propName(node){if(node.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&!node.computed){return node.property.name}if(node.property.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.property.value==="string"){return node.property.value}return null}function getHostHeaderSource(node){if(node.type===eslint_devkit_1.AST_NODE_TYPES.LogicalExpression){return getHostHeaderSource(node.left)??getHostHeaderSource(node.right)}if(node.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=node.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&HOST_GETTER_METHODS.has(callee.property.name)&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&isRequestIdent(callee.object.name)){const arg=node.arguments[0];if(arg!==void 0&&arg.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof arg.value==="string"&&HOST_HEADER_NAMES.has(arg.value.toLowerCase())){return`req.${callee.property.name}('${arg.value}')`}}return null}if(node.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression){const obj=node.object;if(obj.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&obj.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&obj.property.name==="headers"&&obj.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&isRequestIdent(obj.object.name)){const name=propName(node);if(name!==null&&HOST_HEADER_NAMES.has(name.toLowerCase())){return`req.headers['${name}']`}}}return null}function resolveHostSource(node){if(node.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){let scope=sourceCode.getScope(node);while(scope){const variable=scope.variables.find(v=>v.name===node.name);if(variable)return hostVars.get(variable)??null;scope=scope.upper}return null}return getHostHeaderSource(node)}function isUrlish(text){return text.includes("://")||text.startsWith("//")}function isInMailCall(node){let current=node.parent;while(current!=null){if(current.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=current.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&mailCallees.has(callee.name)){return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&mailCallees.has(callee.property.name)){return true}}current=current.parent}return false}function isValidatedByAllowlist(node){if(allowed.length===0)return false;let current=node.parent;while(current!=null){if(current.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement){const testText=sourceCode.getText(current.test);if(allowed.some(host=>testText.includes(host)))return true}current=current.parent}return false}function reportHostUse(node,source){if(isValidatedByAllowlist(node))return;context.report({node,messageId:"hostHeaderInLink",data:{source},suggest:[{messageId:"useConfiguredOrigin",fix:()=>null}]})}return{VariableDeclarator(node){if(node.id.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier||node.init==null){return}const source=getHostHeaderSource(node.init);if(source===null)return;for(const variable of sourceCode.getDeclaredVariables(node)){hostVars.set(variable,source)}},TemplateLiteral(node){const urlish=node.quasis.some(q=>isUrlish(q.value.raw));for(const expr of node.expressions){const source=resolveHostSource(expr);if(source!==null&&(urlish||isInMailCall(node))){reportHostUse(expr,source)}}},BinaryExpression(node){if(node.operator!=="+")return;if(node.parent.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression&&node.parent.operator==="+"){return}const operands=[];const stack=[node];while(stack.length>0){const current=stack.pop();if(current.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression&&current.operator==="+"){stack.push(current.left,current.right)}else{operands.push(current)}}let urlish=false;let hostNode=null;let hostSource=null;for(const operand of operands){if(operand.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof operand.value==="string"&&isUrlish(operand.value)){urlish=true}if(hostSource===null){const source=resolveHostSource(operand);if(source!==null){hostSource=source;hostNode=operand}}}if(hostNode!==null&&(urlish||isInMailCall(node))){reportHostUse(hostNode,hostSource)}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noHostHeaderInLinks=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const HOST_HEADER_NAMES=new Set(["host","x-forwarded-host"]);const HOST_GETTER_METHODS=new Set(["get","header"]);exports.noHostHeaderInLinks=(0,eslint_devkit_1.createRule)({name:"no-host-header-in-links",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-host-header-in-links.md",description:"Disallow building absolute URLs (reset/verification links) from the Host or X-Forwarded-Host request header",cwe:"CWE-640",cvss:8.1},messages:{hostHeaderInLink:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Host-Header Poisoning (CWE-640)",cwe:"CWE-640",description:"A URL is built from {{source}}, which the client controls. Reset/verification links built this way can be redirected to an attacker-owned host, leaking the token.",severity:"HIGH",fix:"Build absolute links from a server-side constant (e.g. process.env.PUBLIC_ORIGIN), never from request headers.",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"})},schema:[{type:"object",properties:{allowedHosts:{type:"array",items:{type:"string"},description:"Trusted literal hosts \u2014 an if-guard comparing against one of these suppresses the report"},checkMailCallees:{type:"array",items:{type:"string"},description:'Callee names treated as mail-send sinks (default: ["sendMail", "send"])'}},additionalProperties:false}]},defaultOptions:[{}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowedHosts,checkMailCallees}=options;const allowed=allowedHosts??[];const mailCallees=new Set(checkMailCallees??["sendMail","send"]);const sourceCode=context.sourceCode;const hostVars=new Map;function isRequestIdent(name){const lower=name.toLowerCase();return lower==="req"||lower==="request"||lower==="ctx"}function propName(node){if(node.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&!node.computed){return node.property.name}if(node.property.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.property.value==="string"){return node.property.value}return null}function getHostHeaderSource(node){if(node.type===eslint_devkit_1.AST_NODE_TYPES.LogicalExpression){return getHostHeaderSource(node.left)??getHostHeaderSource(node.right)}if(node.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=node.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&HOST_GETTER_METHODS.has(callee.property.name)&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&isRequestIdent(callee.object.name)){const arg=node.arguments[0];if(arg!==void 0&&arg.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof arg.value==="string"&&HOST_HEADER_NAMES.has(arg.value.toLowerCase())){return`req.${callee.property.name}('${arg.value}')`}}return null}if(node.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression){const obj=node.object;if(obj.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&obj.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&obj.property.name==="headers"&&obj.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&isRequestIdent(obj.object.name)){const name=propName(node);if(name!==null&&HOST_HEADER_NAMES.has(name.toLowerCase())){return`req.headers['${name}']`}}}return null}function resolveHostSource(node){if(node.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){let scope=sourceCode.getScope(node);while(scope){const variable=scope.variables.find(v=>v.name===node.name);if(variable)return hostVars.get(variable)??null;scope=scope.upper}return null}return getHostHeaderSource(node)}function isUrlish(text){return text.includes("://")||text.startsWith("//")}function isInMailCall(node){let current=node.parent;while(current!=null){if(current.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=current.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&mailCallees.has(callee.name)){return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&mailCallees.has(callee.property.name)){return true}}current=current.parent}return false}function isValidatedByAllowlist(node){if(allowed.length===0)return false;let current=node.parent;while(current!=null){if(current.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement){const testText=sourceCode.getText(current.test);if(allowed.some(host=>testText.includes(host)))return true}current=current.parent}return false}function reportHostUse(node,source){if(isValidatedByAllowlist(node))return;context.report({node,messageId:"hostHeaderInLink",data:{source}})}return{VariableDeclarator(node){if(node.id.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier||node.init==null){return}const source=getHostHeaderSource(node.init);if(source===null)return;for(const variable of sourceCode.getDeclaredVariables(node)){hostVars.set(variable,source)}},TemplateLiteral(node){const urlish=node.quasis.some(q=>isUrlish(q.value.raw));for(const expr of node.expressions){const source=resolveHostSource(expr);if(source!==null&&(urlish||isInMailCall(node))){reportHostUse(expr,source)}}},BinaryExpression(node){if(node.operator!=="+")return;if(node.parent.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression&&node.parent.operator==="+"){return}const operands=[];const stack=[node];while(stack.length>0){const current=stack.pop();if(current.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression&&current.operator==="+"){stack.push(current.left,current.right)}else{operands.push(current)}}let urlish=false;let hostNode=null;let hostSource=null;for(const operand of operands){if(operand.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof operand.value==="string"&&isUrlish(operand.value)){urlish=true}if(hostSource===null){const source=resolveHostSource(operand);if(source!==null){hostSource=source;hostNode=operand}}}if(hostNode!==null&&(urlish||isInMailCall(node))){reportHostUse(hostNode,hostSource)}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noInsecureCookieOptions=void 0;exports.checkCookieOptions=checkCookieOptions;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function propertyName(property){if(property.type!=="Property")return void 0;if(property.key.type==="Identifier"&&!property.computed){return property.key.name.toLowerCase()}if(property.key.type==="Literal"&&typeof property.key.value==="string"){return property.key.value.toLowerCase()}return void 0}function flagState(node,name,hasSpread){const property=[...node.properties].reverse().find(p=>propertyName(p)===name);if(property===void 0)return hasSpread?"unknown":"absent";const value=property.value;if(value.type!=="Literal")return"unknown";return value.value===true?"on":"off"}function checkCookieOptions(node,options){const issues=[];const hasSpread=node.properties.some(p=>p.type==="SpreadElement");if(options.requireHttpOnly!==false){const state=flagState(node,"httponly",hasSpread);if(state==="absent"||state==="off"){issues.push("missing httpOnly flag (prevents XSS access to cookie)")}}if(options.requireSecure!==false){const state=flagState(node,"secure",hasSpread);if(state==="absent"||state==="off"){issues.push("missing secure flag (cookie sent over HTTPS only)")}}if(options.requireSameSite!==false){const acceptableValues=options.acceptableSameSiteValues||["strict","lax"];const property=[...node.properties].reverse().find(p=>propertyName(p)==="samesite");if(property===void 0){if(!hasSpread)issues.push("missing sameSite flag (prevents CSRF)")}else if(property.value.type==="Literal"&&typeof property.value.value==="string"){const value=property.value.value;if(!acceptableValues.includes(value.toLowerCase())){issues.push(`sameSite should be 'strict' or 'lax', not '${value}'`)}}}return{issues,hasSuggestions:issues.length>0}}exports.noInsecureCookieOptions=(0,eslint_devkit_1.createRule)({name:"no-insecure-cookie-options",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-insecure-cookie-options.md",description:"Require secure cookie flags (httpOnly, secure, sameSite) in Express.js",cwe:"CWE-614",cvss:5.3},hasSuggestions:true,messages:{insecureCookie:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Insecure Cookie Configuration",cwe:"CWE-614",description:"{{issues}}",severity:"HIGH",fix:'Set httpOnly: true, secure: true, sameSite: "strict"',documentationLink:"https://owasp.org/www-community/controls/SecureCookieAttribute"}),addSecureFlags:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Secure Cookie Flags",description:"Add missing security flags to cookie options",severity:"LOW",fix:'{ httpOnly: true, secure: true, sameSite: "strict" }',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#security"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false},requireHttpOnly:{type:"boolean",default:true},requireSecure:{type:"boolean",default:true},requireSameSite:{type:"boolean",default:true},acceptableSameSiteValues:{type:"array",items:{type:"string"},default:["strict","lax"]}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,requireHttpOnly:true,requireSecure:true,requireSameSite:true,acceptableSameSiteValues:["strict","lax"]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}return{CallExpression(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="cookie"){const optionsArg=node.arguments[2];if(!optionsArg){context.report({node,messageId:"insecureCookie",data:{issues:"Cookie set without options - missing httpOnly, secure, sameSite flags"},suggest:[{messageId:"addSecureFlags",fix:fixer=>{const lastArg=node.arguments[node.arguments.length-1];return fixer.insertTextAfter(lastArg,', { httpOnly: true, secure: true, sameSite: "strict" }')}}]});return}if(optionsArg.type==="ObjectExpression"){const{issues}=checkCookieOptions(optionsArg,options);if(issues.length>0){context.report({node:optionsArg,messageId:"insecureCookie",data:{issues:issues.join("; ")},suggest:[{messageId:"addSecureFlags",fix:()=>null}]})}}}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noInsecureCookieOptions=void 0;exports.checkCookieOptions=checkCookieOptions;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function propertyName(property){if(property.type!=="Property")return void 0;if(property.key.type==="Identifier"&&!property.computed){return property.key.name.toLowerCase()}if(property.key.type==="Literal"&&typeof property.key.value==="string"){return property.key.value.toLowerCase()}return void 0}function flagState(node,name,hasSpread){const property=[...node.properties].reverse().find(p=>propertyName(p)===name);if(property===void 0)return hasSpread?"unknown":"absent";const value=property.value;if(value.type!=="Literal")return"unknown";return value.value===true?"on":"off"}function checkCookieOptions(node,options){const issues=[];const hasSpread=node.properties.some(p=>p.type==="SpreadElement");if(options.requireHttpOnly!==false){const state=flagState(node,"httponly",hasSpread);if(state==="absent"||state==="off"){issues.push("missing httpOnly flag (prevents XSS access to cookie)")}}if(options.requireSecure!==false){const state=flagState(node,"secure",hasSpread);if(state==="absent"||state==="off"){issues.push("missing secure flag (cookie sent over HTTPS only)")}}if(options.requireSameSite!==false){const acceptableValues=options.acceptableSameSiteValues||["strict","lax"];const property=[...node.properties].reverse().find(p=>propertyName(p)==="samesite");if(property===void 0){if(!hasSpread)issues.push("missing sameSite flag (prevents CSRF)")}else if(property.value.type==="Literal"&&typeof property.value.value==="string"){const value=property.value.value;if(!acceptableValues.includes(value.toLowerCase())){issues.push(`sameSite should be 'strict' or 'lax', not '${value}'`)}}}return{issues,hasSuggestions:issues.length>0}}exports.noInsecureCookieOptions=(0,eslint_devkit_1.createRule)({name:"no-insecure-cookie-options",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-insecure-cookie-options.md",description:"Require secure cookie flags (httpOnly, secure, sameSite) in Express.js",cwe:"CWE-614",cvss:5.3},hasSuggestions:true,messages:{insecureCookie:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Insecure Cookie Configuration",cwe:"CWE-614",description:"{{issues}}",severity:"HIGH",fix:'Set httpOnly: true, secure: true, sameSite: "strict"',documentationLink:"https://owasp.org/www-community/controls/SecureCookieAttribute"}),addSecureFlags:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Secure Cookie Flags",description:"Add missing security flags to cookie options",severity:"LOW",fix:'{ httpOnly: true, secure: true, sameSite: "strict" }',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#security"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false},requireHttpOnly:{type:"boolean",default:true},requireSecure:{type:"boolean",default:true},requireSameSite:{type:"boolean",default:true},acceptableSameSiteValues:{type:"array",items:{type:"string"},default:["strict","lax"]}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,requireHttpOnly:true,requireSecure:true,requireSameSite:true,acceptableSameSiteValues:["strict","lax"]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false}=options;const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);if(isTestFile){return{}}return{CallExpression(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="cookie"){const optionsArg=node.arguments[2];if(!optionsArg){context.report({node,messageId:"insecureCookie",data:{issues:"Cookie set without options - missing httpOnly, secure, sameSite flags"},suggest:[{messageId:"addSecureFlags",fix:fixer=>{const lastArg=node.arguments[node.arguments.length-1];return fixer.insertTextAfter(lastArg,', { httpOnly: true, secure: true, sameSite: "strict" }')}}]});return}if(optionsArg.type==="ObjectExpression"){const{issues}=checkCookieOptions(optionsArg,options);if(issues.length>0){context.report({node:optionsArg,messageId:"insecureCookie",data:{issues:issues.join("; ")}})}}}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noMissingCorsCheck=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const express_evidence_1=require("../../utils/express-evidence");function matchesIgnorePattern(text,ignorePatterns){return ignorePatterns.some(pattern=>{try{const regex=new RegExp(pattern,"i");return regex.test(text)}catch{return false}})}exports.noMissingCorsCheck=(0,eslint_devkit_2.createRule)({name:"no-missing-cors-check",meta:{type:"problem",deprecated:true,replacedBy:["@see eslint-plugin-express-security/no-permissive-cors"],docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-browser-security/docs/rules/no-missing-cors-check.md",description:"Detects missing CORS validation (wildcard CORS, missing origin check)",cwe:"CWE-346",cvss:7.5},hasSuggestions:true,messages:{missingCorsCheck:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing CORS Validation",cwe:"CWE-346",description:"Missing CORS validation detected: {{issue}}",severity:"HIGH",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/346.html"}),useOriginValidation:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Validate Origin",description:"Validate CORS origin",severity:"LOW",fix:"cors({ origin: (origin, cb) => allowedOrigins.includes(origin) ? cb(null, true) : cb(new Error()) })",documentationLink:"https://github.com/expressjs/cors#configuration-options"}),useCorsMiddleware:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use CORS Middleware",description:"Use CORS middleware with origin validation",severity:"LOW",fix:"app.use(cors({ origin: allowedOrigins }))",documentationLink:"https://github.com/expressjs/cors"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow missing CORS checks in test files"},trustedLibraries:{type:"array",items:{type:"string"},default:[],description:"Custom CORS libraries to trust (wildcard origins in these libraries will not be reported)"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Additional safe patterns to ignore"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,trustedLibraries:[],ignorePatterns:[]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,trustedLibraries:corsTrustedLibraries=[],ignorePatterns=[]}=options;const trustedLibraries=corsTrustedLibraries;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);const sourceCode=context.sourceCode;function checkLiteral(node){if(isTestFile){return}if(node.value==="*"&&typeof node.value==="string"){const text=sourceCode.getText(node);if(matchesIgnorePattern(text,ignorePatterns)){return}let shouldSkip=false;let current=node;while(current&&current.parent){current=current.parent;if(current.type==="CallExpression"){const callText=sourceCode.getText(current);if(/\b(setHeader|header)\s*\(/i.test(callText)&&/\bAccess-Control-Allow-Origin\b/i.test(callText)){shouldSkip=true;break}if(/\buse\s*\(/i.test(callText)&&/\bcors\s*\(/i.test(callText)){if(node.parent&&node.parent.type==="Property"){const prop=node.parent;if(prop.key.type==="Identifier"&&prop.key.name==="origin"){shouldSkip=true;break}}}}}if(shouldSkip){return}let isActualCorsContext=false;current=node;while(current&&current.parent){current=current.parent;if(current.type==="CallExpression"){const callText=sourceCode.getText(current);if(/\b(use|cors)\s*\(/i.test(callText)&&/\bcors\s*\(/i.test(callText)){isActualCorsContext=true;break}}}if(node.parent&&node.parent.type==="Property"){const prop=node.parent;if(prop.key.type==="Identifier"){const keyName=prop.key.name.toLowerCase();if(keyName==="origin"||keyName==="allowedorigins"){let inCorsCall=false;let checkNode=prop;while(checkNode&&checkNode.parent){checkNode=checkNode.parent;if(checkNode.type==="CallExpression"){const callText=sourceCode.getText(checkNode);if(/\bcors\s*\(/i.test(callText)||/\buse\s*\(/i.test(callText)&&/\bcors/i.test(callText)){inCorsCall=true;break}}}if(inCorsCall){context.report({node,messageId:"missingCorsCheck",data:{issue:"Wildcard CORS origin (*) allows all origins",safeAlternative:'Use origin validation: app.use(cors({ origin: (origin, callback) => { if (allowedOrigins.includes(origin)) callback(null, true); else callback(new Error("Not allowed")); } } }));'},suggest:[{messageId:"useOriginValidation",fix:_fixer=>null}]});return}}}}if(isActualCorsContext){context.report({node,messageId:"missingCorsCheck",data:{issue:"Wildcard CORS origin (*) allows all origins",safeAlternative:'Use origin validation: app.use(cors({ origin: (origin, callback) => { if (allowedOrigins.includes(origin)) callback(null, true); else callback(new Error("Not allowed")); } } }));'},suggest:[{messageId:"useOriginValidation",fix:_fixer=>null}]})}}}function checkCallExpression(node){if(isTestFile){return}if(node.callee.type==="MemberExpression"){const property=node.callee.property;if(property.type==="Identifier"&&property.name==="use"){const text=sourceCode.getText(node);if(matchesIgnorePattern(text,ignorePatterns)){return}const firstArg=node.arguments.length>0?node.arguments[0]:null;let isCorsCall=/\bcors\s*\(/i.test(text);if(!isCorsCall&&firstArg&&firstArg.type==="CallExpression"&&firstArg.callee.type==="Identifier"){const callee=firstArg.callee;const calleeName=callee.name.toLowerCase();isCorsCall=calleeName==="cors"||trustedLibraries.some(lib=>{return calleeName.includes(lib.toLowerCase())})}let isTrustedLibrary=false;if(firstArg&&firstArg.type==="CallExpression"&&firstArg.callee.type==="Identifier"){const calleeName=firstArg.callee.name.toLowerCase();isTrustedLibrary=trustedLibraries.some(lib=>calleeName.includes(lib.toLowerCase()))}if(isTrustedLibrary){return}if(/\bcors\s*\(/i.test(text)||isCorsCall){const corsCallArg=firstArg&&firstArg.type==="CallExpression"?firstArg:null;const argsToCheck=corsCallArg?corsCallArg.arguments:node.arguments;for(const arg of argsToCheck){if(arg.type==="ObjectExpression"){for(const prop of arg.properties){if(prop.type==="Property"&&prop.key.type==="Identifier"&&prop.key.name==="origin"&&prop.value.type==="Literal"&&prop.value.value==="*"){context.report({node:prop.value,messageId:"missingCorsCheck",data:{issue:"Wildcard CORS origin (*) allows all origins",safeAlternative:'Use origin validation: app.use(cors({ origin: (origin, callback) => { if (allowedOrigins.includes(origin)) callback(null, true); else callback(new Error("Not allowed")); } } }));'},suggest:[{messageId:"useOriginValidation",fix:_fixer=>null}]})}}}else if(arg.type==="Identifier"){const varName=arg.name;let current=node;while(current){if(current.type==="Program"||current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){const scopeBody=current.type==="Program"?current.body:current.body.type==="BlockStatement"?current.body.body:[];for(const stmt of scopeBody){if(stmt.type==="VariableDeclaration"){for(const declarator of stmt.declarations){if(declarator.id.type==="Identifier"&&declarator.id.name===varName&&declarator.init){if(declarator.init.type==="ObjectExpression"){for(const prop of declarator.init.properties){if(prop.type==="Property"&&prop.key.type==="Identifier"&&prop.key.name==="origin"&&prop.value.type==="Literal"&&prop.value.value==="*"){context.report({node:arg,messageId:"missingCorsCheck",data:{issue:"Wildcard CORS origin (*) allows all origins",safeAlternative:'Use origin validation: app.use(cors({ origin: (origin, callback) => { if (allowedOrigins.includes(origin)) callback(null, true); else callback(new Error("Not allowed")); } } }));'},suggest:[{messageId:"useOriginValidation",fix:_fixer=>null}]});return}}}}}}}break}if(current.parent){current=current.parent}else{break}}}}}}}}function checkMemberExpression(node){if(isTestFile){return}if(node.property.type==="Identifier"){const propertyName=node.property.name;if(propertyName==="setHeader"||propertyName==="header"){const text=sourceCode.getText(node);if(matchesIgnorePattern(text,ignorePatterns)){return}const parent=node.parent;if(parent&&parent.type==="CallExpression"){const callText=sourceCode.getText(parent);if(/\bAccess-Control-Allow-Origin\b/i.test(callText)){const args=parent.arguments;if(args.length>=2&&args[1].type==="Literal"&&args[1].value==="*"){context.report({node:args[1],messageId:"missingCorsCheck",data:{issue:"Wildcard CORS header allows all origins",safeAlternative:'Validate origin before setting header: res.setHeader("Access-Control-Allow-Origin", allowedOrigins.includes(origin) ? origin : "null");'},suggest:[{messageId:"useOriginValidation",fix:_fixer=>null}]})}}}}}}return{Literal:checkLiteral,CallExpression:checkCallExpression,MemberExpression:checkMemberExpression}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noMissingCorsCheck=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const express_evidence_1=require("../../utils/express-evidence");function matchesIgnorePattern(text,ignorePatterns){return ignorePatterns.some(pattern=>{try{const regex=new RegExp(pattern,"i");return regex.test(text)}catch{return false}})}exports.noMissingCorsCheck=(0,eslint_devkit_2.createRule)({name:"no-missing-cors-check",meta:{type:"problem",deprecated:true,replacedBy:["@see eslint-plugin-express-security/no-permissive-cors"],docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-browser-security/docs/rules/no-missing-cors-check.md",description:"Detects missing CORS validation (wildcard CORS, missing origin check)",cwe:"CWE-346",cvss:7.5},messages:{missingCorsCheck:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing CORS Validation",cwe:"CWE-346",description:"Missing CORS validation detected: {{issue}}",severity:"HIGH",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/346.html"}),useCorsMiddleware:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use CORS Middleware",description:"Use CORS middleware with origin validation",severity:"LOW",fix:"app.use(cors({ origin: allowedOrigins }))",documentationLink:"https://github.com/expressjs/cors"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow missing CORS checks in test files"},trustedLibraries:{type:"array",items:{type:"string"},default:[],description:"Custom CORS libraries to trust (wildcard origins in these libraries will not be reported)"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Additional safe patterns to ignore"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,trustedLibraries:[],ignorePatterns:[]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,trustedLibraries:corsTrustedLibraries=[],ignorePatterns=[]}=options;const trustedLibraries=corsTrustedLibraries;const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);const sourceCode=context.sourceCode;function checkLiteral(node){if(isTestFile){return}if(node.value==="*"&&typeof node.value==="string"){const text=sourceCode.getText(node);if(matchesIgnorePattern(text,ignorePatterns)){return}let shouldSkip=false;let current=node;while(current&&current.parent){current=current.parent;if(current.type==="CallExpression"){const callText=sourceCode.getText(current);if(/\b(setHeader|header)\s*\(/i.test(callText)&&/\bAccess-Control-Allow-Origin\b/i.test(callText)){shouldSkip=true;break}if(/\buse\s*\(/i.test(callText)&&/\bcors\s*\(/i.test(callText)){if(node.parent&&node.parent.type==="Property"){const prop=node.parent;if(prop.key.type==="Identifier"&&prop.key.name==="origin"){shouldSkip=true;break}}}}}if(shouldSkip){return}let isActualCorsContext=false;current=node;while(current&&current.parent){current=current.parent;if(current.type==="CallExpression"){const callText=sourceCode.getText(current);if(/\b(use|cors)\s*\(/i.test(callText)&&/\bcors\s*\(/i.test(callText)){isActualCorsContext=true;break}}}if(node.parent&&node.parent.type==="Property"){const prop=node.parent;if(prop.key.type==="Identifier"){const keyName=prop.key.name.toLowerCase();if(keyName==="origin"||keyName==="allowedorigins"){let inCorsCall=false;let checkNode=prop;while(checkNode&&checkNode.parent){checkNode=checkNode.parent;if(checkNode.type==="CallExpression"){const callText=sourceCode.getText(checkNode);if(/\bcors\s*\(/i.test(callText)||/\buse\s*\(/i.test(callText)&&/\bcors/i.test(callText)){inCorsCall=true;break}}}if(inCorsCall){context.report({node,messageId:"missingCorsCheck",data:{issue:"Wildcard CORS origin (*) allows all origins",safeAlternative:'Use origin validation: app.use(cors({ origin: (origin, callback) => { if (allowedOrigins.includes(origin)) callback(null, true); else callback(new Error("Not allowed")); } } }));'}});return}}}}if(isActualCorsContext){context.report({node,messageId:"missingCorsCheck",data:{issue:"Wildcard CORS origin (*) allows all origins",safeAlternative:'Use origin validation: app.use(cors({ origin: (origin, callback) => { if (allowedOrigins.includes(origin)) callback(null, true); else callback(new Error("Not allowed")); } } }));'}})}}}function checkCallExpression(node){if(isTestFile){return}if(node.callee.type==="MemberExpression"){const property=node.callee.property;if(property.type==="Identifier"&&property.name==="use"){const text=sourceCode.getText(node);if(matchesIgnorePattern(text,ignorePatterns)){return}const firstArg=node.arguments.length>0?node.arguments[0]:null;let isCorsCall=/\bcors\s*\(/i.test(text);if(!isCorsCall&&firstArg&&firstArg.type==="CallExpression"&&firstArg.callee.type==="Identifier"){const callee=firstArg.callee;const calleeName=callee.name.toLowerCase();isCorsCall=calleeName==="cors"||trustedLibraries.some(lib=>{return calleeName.includes(lib.toLowerCase())})}let isTrustedLibrary=false;if(firstArg&&firstArg.type==="CallExpression"&&firstArg.callee.type==="Identifier"){const calleeName=firstArg.callee.name.toLowerCase();isTrustedLibrary=trustedLibraries.some(lib=>calleeName.includes(lib.toLowerCase()))}if(isTrustedLibrary){return}if(/\bcors\s*\(/i.test(text)||isCorsCall){const corsCallArg=firstArg&&firstArg.type==="CallExpression"?firstArg:null;const argsToCheck=corsCallArg?corsCallArg.arguments:node.arguments;for(const arg of argsToCheck){if(arg.type==="ObjectExpression"){for(const prop of arg.properties){if(prop.type==="Property"&&prop.key.type==="Identifier"&&prop.key.name==="origin"&&prop.value.type==="Literal"&&prop.value.value==="*"){context.report({node:prop.value,messageId:"missingCorsCheck",data:{issue:"Wildcard CORS origin (*) allows all origins",safeAlternative:'Use origin validation: app.use(cors({ origin: (origin, callback) => { if (allowedOrigins.includes(origin)) callback(null, true); else callback(new Error("Not allowed")); } } }));'}})}}}else if(arg.type==="Identifier"){const varName=arg.name;let current=node;while(current){if(current.type==="Program"||current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){const scopeBody=current.type==="Program"?current.body:current.body.type==="BlockStatement"?current.body.body:[];for(const stmt of scopeBody){if(stmt.type==="VariableDeclaration"){for(const declarator of stmt.declarations){if(declarator.id.type==="Identifier"&&declarator.id.name===varName&&declarator.init){if(declarator.init.type==="ObjectExpression"){for(const prop of declarator.init.properties){if(prop.type==="Property"&&prop.key.type==="Identifier"&&prop.key.name==="origin"&&prop.value.type==="Literal"&&prop.value.value==="*"){context.report({node:arg,messageId:"missingCorsCheck",data:{issue:"Wildcard CORS origin (*) allows all origins",safeAlternative:'Use origin validation: app.use(cors({ origin: (origin, callback) => { if (allowedOrigins.includes(origin)) callback(null, true); else callback(new Error("Not allowed")); } } }));'}});return}}}}}}}break}if(current.parent){current=current.parent}else{break}}}}}}}}function checkMemberExpression(node){if(isTestFile){return}if(node.property.type==="Identifier"){const propertyName=node.property.name;if(propertyName==="setHeader"||propertyName==="header"){const text=sourceCode.getText(node);if(matchesIgnorePattern(text,ignorePatterns)){return}const parent=node.parent;if(parent&&parent.type==="CallExpression"){const callText=sourceCode.getText(parent);if(/\bAccess-Control-Allow-Origin\b/i.test(callText)){const args=parent.arguments;if(args.length>=2&&args[1].type==="Literal"&&args[1].value==="*"){context.report({node:args[1],messageId:"missingCorsCheck",data:{issue:"Wildcard CORS header allows all origins",safeAlternative:'Validate origin before setting header: res.setHeader("Access-Control-Allow-Origin", allowedOrigins.includes(origin) ? origin : "null");'}})}}}}}}return{Literal:checkLiteral,CallExpression:checkCallExpression,MemberExpression:checkMemberExpression}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noMissingCsrfProtection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const express_evidence_1=require("../../utils/express-evidence");const DEFAULT_CSRF_MIDDLEWARE_PATTERNS=["csrf","csurf","csrfProtection","verifyCsrfToken","csrfToken","validateCsrf","checkCsrf","csrfMiddleware"];const DEFAULT_PROTECTED_METHODS=["post","put","delete","patch"];function matchesIgnorePattern(text,patterns){return patterns.some(pattern=>{try{const regex=new RegExp(pattern,"i");return regex.test(text)}catch{return text.toLowerCase().includes(pattern.toLowerCase())}})}exports.noMissingCsrfProtection=(0,eslint_devkit_2.createRule)({name:"no-missing-csrf-protection",meta:{type:"problem",deprecated:true,replacedBy:["@see eslint-plugin-express-security/require-csrf-protection"],docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-browser-security/docs/rules/no-missing-csrf-protection.md",description:"Detects missing CSRF token validation in POST/PUT/DELETE requests",cwe:"CWE-352",cvss:8.8},hasSuggestions:true,messages:{missingCsrfProtection:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing CSRF Protection",cwe:"CWE-352",description:"Missing CSRF protection detected: {{issue}}",severity:"HIGH",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/352.html"}),addCsrfValidation:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add CSRF Validation",description:"Add CSRF middleware",severity:"LOW",fix:"app.use(csrf({ cookie: true }))",documentationLink:"https://github.com/expressjs/csurf"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow missing CSRF protection in test files"},csrfMiddlewarePatterns:{type:"array",items:{type:"string"},default:[],description:"CSRF middleware patterns to recognize"},protectedMethods:{type:"array",items:{type:"string"},default:[],description:"HTTP methods that require CSRF protection"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Additional safe patterns to ignore"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,csrfMiddlewarePatterns:[],protectedMethods:[],ignorePatterns:[]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,csrfMiddlewarePatterns,protectedMethods:customProtectedMethods,ignorePatterns=[]}=options;const csrfPatterns=csrfMiddlewarePatterns&&csrfMiddlewarePatterns.length>0?csrfMiddlewarePatterns:DEFAULT_CSRF_MIDDLEWARE_PATTERNS;const protectedMethods=customProtectedMethods&&customProtectedMethods.length>0?customProtectedMethods:DEFAULT_PROTECTED_METHODS;const protectedMethodsSet=new Set(protectedMethods.map(m=>m.toLowerCase()));const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);const sourceCode=context.sourceCode;function checkCallExpression(node){if(isTestFile){return}const callee=node.callee;const callText=sourceCode.getText(node);if(matchesIgnorePattern(callText,ignorePatterns)){return}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const methodName=callee.property.name;if(protectedMethodsSet.has(methodName.toLowerCase())){if(node.arguments.length<2){return}let hasCsrfInChain=false;for(let i=1;i<node.arguments.length;i++){const arg=node.arguments[i];const argText=sourceCode.getText(arg);if(csrfPatterns.some(pattern=>argText.toLowerCase().includes(pattern.toLowerCase()))){hasCsrfInChain=true;break}}if(!hasCsrfInChain){context.report({node,messageId:"missingCsrfProtection",data:{issue:`${methodName.toUpperCase()} route handler missing CSRF protection`,safeAlternative:`Add CSRF middleware: app.${methodName}("/path", csrf(), handler) or use app.use(csrf()) globally`},suggest:[{messageId:"addCsrfValidation",fix(fixer){return fixer.insertTextAfter(node.arguments[0],", csrf()")}}]})}}}}return{CallExpression:checkCallExpression}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noMissingCsrfProtection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const express_evidence_1=require("../../utils/express-evidence");const DEFAULT_CSRF_MIDDLEWARE_PATTERNS=["csrf","csurf","csrfProtection","verifyCsrfToken","csrfToken","validateCsrf","checkCsrf","csrfMiddleware"];const DEFAULT_PROTECTED_METHODS=["post","put","delete","patch"];function matchesIgnorePattern(text,patterns){return patterns.some(pattern=>{try{const regex=new RegExp(pattern,"i");return regex.test(text)}catch{return text.toLowerCase().includes(pattern.toLowerCase())}})}exports.noMissingCsrfProtection=(0,eslint_devkit_2.createRule)({name:"no-missing-csrf-protection",meta:{type:"problem",deprecated:true,replacedBy:["@see eslint-plugin-express-security/require-csrf-protection"],docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-browser-security/docs/rules/no-missing-csrf-protection.md",description:"Detects missing CSRF token validation in POST/PUT/DELETE requests",cwe:"CWE-352",cvss:8.8},hasSuggestions:true,messages:{missingCsrfProtection:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing CSRF Protection",cwe:"CWE-352",description:"Missing CSRF protection detected: {{issue}}",severity:"HIGH",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/352.html"}),addCsrfValidation:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add CSRF Validation",description:"Add CSRF middleware",severity:"LOW",fix:"app.use(csrf({ cookie: true }))",documentationLink:"https://github.com/expressjs/csurf"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow missing CSRF protection in test files"},csrfMiddlewarePatterns:{type:"array",items:{type:"string"},default:[],description:"CSRF middleware patterns to recognize"},protectedMethods:{type:"array",items:{type:"string"},default:[],description:"HTTP methods that require CSRF protection"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Additional safe patterns to ignore"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,csrfMiddlewarePatterns:[],protectedMethods:[],ignorePatterns:[]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,csrfMiddlewarePatterns,protectedMethods:customProtectedMethods,ignorePatterns=[]}=options;const csrfPatterns=csrfMiddlewarePatterns&&csrfMiddlewarePatterns.length>0?csrfMiddlewarePatterns:DEFAULT_CSRF_MIDDLEWARE_PATTERNS;const protectedMethods=customProtectedMethods&&customProtectedMethods.length>0?customProtectedMethods:DEFAULT_PROTECTED_METHODS;const protectedMethodsSet=new Set(protectedMethods.map(m=>m.toLowerCase()));const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);const sourceCode=context.sourceCode;function checkCallExpression(node){if(isTestFile){return}const callee=node.callee;const callText=sourceCode.getText(node);if(matchesIgnorePattern(callText,ignorePatterns)){return}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const methodName=callee.property.name;if(protectedMethodsSet.has(methodName.toLowerCase())){if(node.arguments.length<2){return}let hasCsrfInChain=false;for(let i=1;i<node.arguments.length;i++){const arg=node.arguments[i];const argText=sourceCode.getText(arg);if(csrfPatterns.some(pattern=>argText.toLowerCase().includes(pattern.toLowerCase()))){hasCsrfInChain=true;break}}if(!hasCsrfInChain){context.report({node,messageId:"missingCsrfProtection",data:{issue:`${methodName.toUpperCase()} route handler missing CSRF protection`,safeAlternative:`Add CSRF middleware: app.${methodName}("/path", csrf(), handler) or use app.use(csrf()) globally`},suggest:[{messageId:"addCsrfValidation",fix(fixer){return fixer.insertTextAfter(node.arguments[0],", csrf()")}}]})}}}}return{CallExpression:checkCallExpression}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noMissingSecurityHeaders=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const express_evidence_1=require("../../utils/express-evidence");const DEFAULT_REQUIRED_HEADERS=["Content-Security-Policy","X-Frame-Options","X-Content-Type-Options"];const HEADER_METHODS=new Set(["setHeader","header","set"]);const RESPONSE_RECEIVER=/^(res|resp|response|reply)$/i;function isResponseHeaderCall(node){const{callee}=node;if(callee.type!=="MemberExpression"||callee.property.type!=="Identifier"||!HEADER_METHODS.has(callee.property.name)){return false}const{object}=callee;if(object.type==="Identifier"){return RESPONSE_RECEIVER.test(object.name)}if(object.type==="MemberExpression"&&object.property.type==="Identifier"){return RESPONSE_RECEIVER.test(object.property.name)}return false}function extractHeaderName(node){if(node.arguments.length>0&&node.arguments[0].type==="Literal"){return String(node.arguments[0].value)}return null}function checkFunctionForSecurityHeaders(node,requiredHeaders,context){const setHeaders=new Set;let current=node;let scopeNode=null;while(current){if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){scopeNode=current;break}current=current.parent??null}if(!scopeNode){scopeNode=context.sourceCode.ast}function collectHeaders(astNode){if(astNode.type==="CallExpression"&&isResponseHeaderCall(astNode)){const headerName=extractHeaderName(astNode);if(headerName){setHeaders.add(headerName)}}if(astNode.type==="Program"&&astNode.body){astNode.body.forEach(collectHeaders)}else if((astNode.type==="FunctionDeclaration"||astNode.type==="FunctionExpression"||astNode.type==="ArrowFunctionExpression")&&astNode.body){collectHeaders(astNode.body)}else if(astNode.type==="BlockStatement"&&astNode.body){astNode.body.forEach(collectHeaders)}else if(astNode.type==="ExpressionStatement"&&astNode.expression){collectHeaders(astNode.expression)}}collectHeaders(scopeNode);return requiredHeaders.filter(header=>!setHeaders.has(header))}exports.noMissingSecurityHeaders=(0,eslint_devkit_2.createRule)({name:"no-missing-security-headers",meta:{type:"problem",deprecated:true,replacedBy:["@see eslint-plugin-express-security/require-helmet"],docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-browser-security/docs/rules/no-missing-security-headers.md",description:"Detects missing security headers in HTTP responses",cwe:"CWE-693",cvss:7.5},hasSuggestions:true,messages:{missingSecurityHeader:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing security headers",cwe:"CWE-693",description:"Missing security headers: {{headers}}",severity:"HIGH",fix:"Set security headers: Content-Security-Policy, X-Frame-Options, X-Content-Type-Options",documentationLink:"https://owasp.org/www-project-secure-headers/"}),addSecurityHeaders:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Security Headers",description:"Add security headers middleware",severity:"LOW",fix:"Add Content-Security-Policy, X-Frame-Options headers",documentationLink:"https://owasp.org/www-project-secure-headers/"}),useMiddleware:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Helmet",description:"Use helmet.js for security headers",severity:"LOW",fix:"app.use(helmet())",documentationLink:"https://helmetjs.github.io/"}),setHeader:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Set Headers",description:"Set security headers manually",severity:"LOW",fix:'res.setHeader("X-Frame-Options", "DENY")',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers"})},schema:[{type:"object",properties:{requiredHeaders:{type:"array",items:{type:"string"},default:DEFAULT_REQUIRED_HEADERS},ignoreInTests:{type:"boolean",default:true}},additionalProperties:false}]},defaultOptions:[{requiredHeaders:DEFAULT_REQUIRED_HEADERS,ignoreInTests:true}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{requiredHeaders=DEFAULT_REQUIRED_HEADERS,ignoreInTests=true}=options;const filename=context.filename;const isTestFile=ignoreInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}const reportedScopes=new Set;function getScopeKey(node){let current=node;while(current){if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){return`${current.range?.[0]}-${current.range?.[1]}`}current=current.parent??null}return"program"}function checkCallExpression(node){if(!isResponseHeaderCall(node)){return}const scopeKey=getScopeKey(node);if(reportedScopes.has(scopeKey)){return}const missing=checkFunctionForSecurityHeaders(node,requiredHeaders,context);reportedScopes.add(scopeKey);if(missing.length>0){context.report({node,messageId:"missingSecurityHeader",data:{headers:missing.join(", ")},suggest:[{messageId:"addSecurityHeaders",fix:()=>null},{messageId:"useMiddleware",fix:()=>null},{messageId:"setHeader",fix:()=>null}]})}}return{CallExpression:checkCallExpression}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noMissingSecurityHeaders=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const express_evidence_1=require("../../utils/express-evidence");const DEFAULT_REQUIRED_HEADERS=["Content-Security-Policy","X-Frame-Options","X-Content-Type-Options"];const HEADER_METHODS=new Set(["setHeader","header","set"]);const RESPONSE_RECEIVER=/^(res|resp|response|reply)$/i;function isResponseHeaderCall(node){const{callee}=node;if(callee.type!=="MemberExpression"||callee.property.type!=="Identifier"||!HEADER_METHODS.has(callee.property.name)){return false}const{object}=callee;if(object.type==="Identifier"){return RESPONSE_RECEIVER.test(object.name)}if(object.type==="MemberExpression"&&object.property.type==="Identifier"){return RESPONSE_RECEIVER.test(object.property.name)}return false}function extractHeaderName(node){if(node.arguments.length>0&&node.arguments[0].type==="Literal"){return String(node.arguments[0].value)}return null}function checkFunctionForSecurityHeaders(node,requiredHeaders,context){const setHeaders=new Set;let current=node;let scopeNode=null;while(current){if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){scopeNode=current;break}current=current.parent??null}if(!scopeNode){scopeNode=context.sourceCode.ast}function collectHeaders(astNode){if(astNode.type==="CallExpression"&&isResponseHeaderCall(astNode)){const headerName=extractHeaderName(astNode);if(headerName){setHeaders.add(headerName)}}if(astNode.type==="Program"&&astNode.body){astNode.body.forEach(collectHeaders)}else if((astNode.type==="FunctionDeclaration"||astNode.type==="FunctionExpression"||astNode.type==="ArrowFunctionExpression")&&astNode.body){collectHeaders(astNode.body)}else if(astNode.type==="BlockStatement"&&astNode.body){astNode.body.forEach(collectHeaders)}else if(astNode.type==="ExpressionStatement"&&astNode.expression){collectHeaders(astNode.expression)}}collectHeaders(scopeNode);return requiredHeaders.filter(header=>!setHeaders.has(header))}exports.noMissingSecurityHeaders=(0,eslint_devkit_2.createRule)({name:"no-missing-security-headers",meta:{type:"problem",deprecated:true,replacedBy:["@see eslint-plugin-express-security/require-helmet"],docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-browser-security/docs/rules/no-missing-security-headers.md",description:"Detects missing security headers in HTTP responses",cwe:"CWE-693",cvss:7.5},messages:{missingSecurityHeader:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing security headers",cwe:"CWE-693",description:"Missing security headers: {{headers}}",severity:"HIGH",fix:"Set security headers: Content-Security-Policy, X-Frame-Options, X-Content-Type-Options",documentationLink:"https://owasp.org/www-project-secure-headers/"})},schema:[{type:"object",properties:{requiredHeaders:{type:"array",items:{type:"string"},default:DEFAULT_REQUIRED_HEADERS},ignoreInTests:{type:"boolean",default:true}},additionalProperties:false}]},defaultOptions:[{requiredHeaders:DEFAULT_REQUIRED_HEADERS,ignoreInTests:true}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{requiredHeaders=DEFAULT_REQUIRED_HEADERS,ignoreInTests=true}=options;const filename=context.filename;const isTestFile=ignoreInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);if(isTestFile){return{}}const reportedScopes=new Set;function getScopeKey(node){let current=node;while(current){if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){return`${current.range?.[0]}-${current.range?.[1]}`}current=current.parent??null}return"program"}function checkCallExpression(node){if(!isResponseHeaderCall(node)){return}const scopeKey=getScopeKey(node);if(reportedScopes.has(scopeKey)){return}const missing=checkFunctionForSecurityHeaders(node,requiredHeaders,context);reportedScopes.add(scopeKey);if(missing.length>0){context.report({node,messageId:"missingSecurityHeader",data:{headers:missing.join(", ")}})}}return{CallExpression:checkCallExpression}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noPermissiveCors=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function readsBooleanTrue(node,name){return node.properties.some(property=>property.type==="Property"&&!property.computed&&(property.key.type==="Identifier"&&property.key.name===name||property.key.type==="Literal"&&property.key.value===name)&&property.value.type==="Literal"&&property.value.value===true)}function isPermissiveOrigin(node){return node.properties.some(property=>property.type==="Property"&&!property.computed&&(property.key.type==="Identifier"&&property.key.name==="origin"||property.key.type==="Literal"&&property.key.value==="origin")&&property.value.type==="Literal"&&(property.value.value===true||property.value.value==="*"))}function isPermissiveCorsConfig(node,sourceCode,options){const text=sourceCode.getText(node);if(readsBooleanTrue(node,"credentials")&&isPermissiveOrigin(node)){return{isPermissive:false,reason:""}}if(/\borigin\s*:\s*['"`]\*['"`]/.test(text)){return{isPermissive:true,reason:"origin: '*' allows any domain to access your API"}}if(!options.allowOriginTrue&&/\borigin\s*:\s*true\b/.test(text)){return{isPermissive:true,reason:"origin: true reflects the request origin, allowing any domain"}}return{isPermissive:false,reason:""}}function isStandaloneCorsCall(node){const callee=node.callee;if(callee.type==="Identifier"&&callee.name==="cors"){const parent=node.parent;if(parent&&parent.type==="CallExpression"&&parent.callee.type==="MemberExpression"&&parent.callee.property.type==="Identifier"&&parent.callee.property.name==="use"){return false}return true}return false}function isAppUseCors(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="use"){const firstArg=node.arguments[0];if(firstArg&&firstArg.type==="CallExpression"&&firstArg.callee.type==="Identifier"&&firstArg.callee.name==="cors"){return true}}return false}exports.noPermissiveCors=(0,eslint_devkit_1.createRule)({name:"no-permissive-cors",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-permissive-cors.md",description:"Disallow overly permissive CORS configurations (wildcard origin, origin: true)",cwe:"CWE-942",cvss:7.5},hasSuggestions:true,messages:{permissiveCors:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Permissive CORS Configuration",cwe:"CWE-942",description:"{{reason}}",severity:"HIGH",fix:'Specify an explicit whitelist of allowed origins: origin: ["https://trusted-domain.com"]',documentationLink:"https://owasp.org/www-community/attacks/CORS_OriginHeaderScrutiny"}),useWhitelist:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Origin Whitelist",description:"Replace with explicit origin whitelist",severity:"LOW",fix:'origin: ["https://your-frontend.com", "https://app.your-domain.com"]',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow permissive CORS in test files"},allowOriginTrue:{type:"boolean",default:false,description:"Allow origin: true for development"},allowedOrigins:{type:"array",items:{type:"string"},default:[],description:"Allowed origins that should not trigger warnings"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,allowOriginTrue:false,allowedOrigins:[]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,allowOriginTrue=false}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}const sourceCode=context.sourceCode;return{CallExpression(node){if(isStandaloneCorsCall(node)||isAppUseCors(node)){let corsConfigNode=null;if(isStandaloneCorsCall(node)&&node.arguments[0]?.type==="ObjectExpression"){corsConfigNode=node.arguments[0]}else if(isAppUseCors(node)){const corsCall=node.arguments[0];if(corsCall.arguments[0]?.type==="ObjectExpression"){corsConfigNode=corsCall.arguments[0]}}let corsCallNode=null;if(isStandaloneCorsCall(node)){corsCallNode=node}else{corsCallNode=node.arguments[0]}if(corsCallNode&&corsCallNode.arguments.length===0){context.report({node:corsCallNode,messageId:"permissiveCors",data:{reason:"cors() with no options uses permissive defaults"},suggest:[{messageId:"useWhitelist",fix:()=>null}]});return}if(corsConfigNode){const{isPermissive,reason}=isPermissiveCorsConfig(corsConfigNode,sourceCode,{allowOriginTrue});if(isPermissive){context.report({node:corsConfigNode,messageId:"permissiveCors",data:{reason},suggest:[{messageId:"useWhitelist",fix:()=>null}]})}}}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noPermissiveCors=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function readsBooleanTrue(node,name){return node.properties.some(property=>property.type==="Property"&&!property.computed&&(property.key.type==="Identifier"&&property.key.name===name||property.key.type==="Literal"&&property.key.value===name)&&property.value.type==="Literal"&&property.value.value===true)}function isPermissiveOrigin(node){return node.properties.some(property=>property.type==="Property"&&!property.computed&&(property.key.type==="Identifier"&&property.key.name==="origin"||property.key.type==="Literal"&&property.key.value==="origin")&&property.value.type==="Literal"&&(property.value.value===true||property.value.value==="*"))}function isPermissiveCorsConfig(node,sourceCode,options){const text=sourceCode.getText(node);if(readsBooleanTrue(node,"credentials")&&isPermissiveOrigin(node)){return{isPermissive:false,reason:""}}if(/\borigin\s*:\s*['"`]\*['"`]/.test(text)){return{isPermissive:true,reason:"origin: '*' allows any domain to access your API"}}if(!options.allowOriginTrue&&/\borigin\s*:\s*true\b/.test(text)){return{isPermissive:true,reason:"origin: true reflects the request origin, allowing any domain"}}return{isPermissive:false,reason:""}}function isStandaloneCorsCall(node){const callee=node.callee;if(callee.type==="Identifier"&&callee.name==="cors"){const parent=node.parent;if(parent&&parent.type==="CallExpression"&&parent.callee.type==="MemberExpression"&&parent.callee.property.type==="Identifier"&&parent.callee.property.name==="use"){return false}return true}return false}function isAppUseCors(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="use"){const firstArg=node.arguments[0];if(firstArg&&firstArg.type==="CallExpression"&&firstArg.callee.type==="Identifier"&&firstArg.callee.name==="cors"){return true}}return false}exports.noPermissiveCors=(0,eslint_devkit_1.createRule)({name:"no-permissive-cors",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-permissive-cors.md",description:"Disallow overly permissive CORS configurations (wildcard origin, origin: true)",cwe:"CWE-942",cvss:7.5},messages:{permissiveCors:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Permissive CORS Configuration",cwe:"CWE-942",description:"{{reason}}",severity:"HIGH",fix:'Specify an explicit whitelist of allowed origins: origin: ["https://trusted-domain.com"]',documentationLink:"https://owasp.org/www-community/attacks/CORS_OriginHeaderScrutiny"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow permissive CORS in test files"},allowOriginTrue:{type:"boolean",default:false,description:"Allow origin: true for development"},allowedOrigins:{type:"array",items:{type:"string"},default:[],description:"Allowed origins that should not trigger warnings"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,allowOriginTrue:false,allowedOrigins:[]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,allowOriginTrue=false}=options;const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);if(isTestFile){return{}}const sourceCode=context.sourceCode;return{CallExpression(node){if(isStandaloneCorsCall(node)||isAppUseCors(node)){let corsConfigNode=null;if(isStandaloneCorsCall(node)&&node.arguments[0]?.type==="ObjectExpression"){corsConfigNode=node.arguments[0]}else if(isAppUseCors(node)){const corsCall=node.arguments[0];if(corsCall.arguments[0]?.type==="ObjectExpression"){corsConfigNode=corsCall.arguments[0]}}let corsCallNode=null;if(isStandaloneCorsCall(node)){corsCallNode=node}else{corsCallNode=node.arguments[0]}if(corsCallNode&&corsCallNode.arguments.length===0){context.report({node:corsCallNode,messageId:"permissiveCors",data:{reason:"cors() with no options uses permissive defaults"}});return}if(corsConfigNode){const{isPermissive,reason}=isPermissiveCorsConfig(corsConfigNode,sourceCode,{allowOriginTrue});if(isPermissive){context.report({node:corsConfigNode,messageId:"permissiveCors",data:{reason}})}}}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noSensitiveDataInQuery=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_SENSITIVE=["password","token","secret","apiKey","api_key","auth","credential","ssn","card"];const MAX_PARAM_NAME_LENGTH=128;function tokenize(name){return name.replace(/([a-z0-9])([A-Z])/g,"$1 $2").toLowerCase().split(/[^a-z0-9]+/).filter(token=>token.length>0)}function containsSubsequence(tokens,term){for(let i=0;i+term.length<=tokens.length;i++){let match=true;for(let j=0;j<term.length;j++){if(tokens[i+j]!==term[j]){match=false;break}}if(match)return true}return false}exports.noSensitiveDataInQuery=(0,eslint_devkit_1.createRule)({name:"no-sensitive-data-in-query",meta:{type:"problem",hasSuggestions:true,docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-sensitive-data-in-query.md",description:"Disallow reading sensitive-named parameters (password, token, secret, ...) from req.query",cwe:"CWE-598",cvss:6.5},messages:{sensitiveQueryParam:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Sensitive Data in Query String (CWE-598)",cwe:"CWE-598",description:"Query parameter '{{name}}' is sensitive. Query strings are stored in access logs, proxy logs, browser history and leak via the Referer header.",severity:"MEDIUM",fix:"Move the value to the POST request body (req.body) or an Authorization header; never accept secrets via the query string.",documentationLink:"https://cwe.mitre.org/data/definitions/598.html"}),moveToBody:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Move the secret out of the query string",description:"Accept the value from the POST body or an Authorization header instead",severity:"LOW",fix:"app.post('/login', (req, res) => { const { password } = req.body; })",documentationLink:"https://cwe.mitre.org/data/definitions/598.html"})},schema:[{type:"object",properties:{sensitiveParams:{type:"array",items:{type:"string"},description:"Additional sensitive parameter names (extends the defaults)"},extraPatterns:{type:"array",items:{type:"string"},description:"Additional regex patterns (case-insensitive) matched against the raw parameter name"},allowedParams:{type:"array",items:{type:"string"},description:"Parameter names explicitly allowed in the query string (exact, case-insensitive)"}},additionalProperties:false}]},defaultOptions:[{}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{sensitiveParams,extraPatterns,allowedParams}=options;const terms=[...DEFAULT_SENSITIVE,...sensitiveParams??[]].map(term=>tokenize(term));const patterns=[];for(const pattern of extraPatterns??[]){try{patterns.push(new RegExp(pattern,"i"))}catch{}}const allowedSet=new Set((allowedParams??[]).map(name=>name.toLowerCase()));function isRequestIdent(name){const lower=name.toLowerCase();return lower==="req"||lower==="request"||lower==="ctx"}function isReqQuery(node){return node.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&!node.computed&&node.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&isRequestIdent(node.object.name)&&node.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&node.property.name==="query"}function isSensitive(name){if(allowedSet.has(name.toLowerCase()))return false;const tokens=tokenize(name);for(const term of terms){if(term.length===1){const single=term[0];if(tokens.some(token=>token===single||token===`${single}s`)){return true}}else if(containsSubsequence(tokens,term)){return true}}if(name.length>MAX_PARAM_NAME_LENGTH)return false;return patterns.some(pattern=>pattern.test(name))}function report(node,name){context.report({node,messageId:"sensitiveQueryParam",data:{name},suggest:[{messageId:"moveToBody",fix:()=>null}]})}return{MemberExpression(node){if(!isReqQuery(node.object))return;let name=null;if(node.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&!node.computed){name=node.property.name}else if(node.property.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.property.value==="string"){name=node.property.value}if(name!==null&&isSensitive(name))report(node,name)},VariableDeclarator(node){if(node.id.type!==eslint_devkit_1.AST_NODE_TYPES.ObjectPattern)return;if(node.init===null||!isReqQuery(node.init))return;for(const prop of node.id.properties){if(prop.type!==eslint_devkit_1.AST_NODE_TYPES.Property)continue;let name=null;if(prop.key.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&!prop.computed){name=prop.key.name}else if(prop.key.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof prop.key.value==="string"){name=prop.key.value}if(name!==null&&isSensitive(name))report(prop,name)}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noSensitiveDataInQuery=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_SENSITIVE=["password","token","secret","apiKey","api_key","auth","credential","ssn","card"];const MAX_PARAM_NAME_LENGTH=128;function tokenize(name){return name.replace(/([a-z0-9])([A-Z])/g,"$1 $2").toLowerCase().split(/[^a-z0-9]+/).filter(token=>token.length>0)}function containsSubsequence(tokens,term){for(let i=0;i+term.length<=tokens.length;i++){let match=true;for(let j=0;j<term.length;j++){if(tokens[i+j]!==term[j]){match=false;break}}if(match)return true}return false}exports.noSensitiveDataInQuery=(0,eslint_devkit_1.createRule)({name:"no-sensitive-data-in-query",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-sensitive-data-in-query.md",description:"Disallow reading sensitive-named parameters (password, token, secret, ...) from req.query",cwe:"CWE-598",cvss:6.5},messages:{sensitiveQueryParam:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Sensitive Data in Query String (CWE-598)",cwe:"CWE-598",description:"Query parameter '{{name}}' is sensitive. Query strings are stored in access logs, proxy logs, browser history and leak via the Referer header.",severity:"MEDIUM",fix:"Move the value to the POST request body (req.body) or an Authorization header; never accept secrets via the query string.",documentationLink:"https://cwe.mitre.org/data/definitions/598.html"})},schema:[{type:"object",properties:{sensitiveParams:{type:"array",items:{type:"string"},description:"Additional sensitive parameter names (extends the defaults)"},extraPatterns:{type:"array",items:{type:"string"},description:"Additional regex patterns (case-insensitive) matched against the raw parameter name"},allowedParams:{type:"array",items:{type:"string"},description:"Parameter names explicitly allowed in the query string (exact, case-insensitive)"}},additionalProperties:false}]},defaultOptions:[{}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{sensitiveParams,extraPatterns,allowedParams}=options;const terms=[...DEFAULT_SENSITIVE,...sensitiveParams??[]].map(term=>tokenize(term));const patterns=[];for(const pattern of extraPatterns??[]){try{patterns.push(new RegExp(pattern,"i"))}catch{}}const allowedSet=new Set((allowedParams??[]).map(name=>name.toLowerCase()));function isRequestIdent(name){const lower=name.toLowerCase();return lower==="req"||lower==="request"||lower==="ctx"}function isReqQuery(node){return node.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&!node.computed&&node.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&isRequestIdent(node.object.name)&&node.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&node.property.name==="query"}function isSensitive(name){if(allowedSet.has(name.toLowerCase()))return false;const tokens=tokenize(name);for(const term of terms){if(term.length===1){const single=term[0];if(tokens.some(token=>token===single||token===`${single}s`)){return true}}else if(containsSubsequence(tokens,term)){return true}}if(name.length>MAX_PARAM_NAME_LENGTH)return false;return patterns.some(pattern=>pattern.test(name))}function report(node,name){context.report({node,messageId:"sensitiveQueryParam",data:{name}})}return{MemberExpression(node){if(!isReqQuery(node.object))return;let name=null;if(node.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&!node.computed){name=node.property.name}else if(node.property.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.property.value==="string"){name=node.property.value}if(name!==null&&isSensitive(name))report(node,name)},VariableDeclarator(node){if(node.id.type!==eslint_devkit_1.AST_NODE_TYPES.ObjectPattern)return;if(node.init===null||!isReqQuery(node.init))return;for(const prop of node.id.properties){if(prop.type!==eslint_devkit_1.AST_NODE_TYPES.Property)continue;let name=null;if(prop.key.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&!prop.computed){name=prop.key.name}else if(prop.key.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof prop.key.value==="string"){name=prop.key.value}if(name!==null&&isSensitive(name))report(prop,name)}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireCsrfProtection=void 0;const express_evidence_1=require("../../utils/express-evidence");const app_composition_1=require("../../utils/app-composition");const auth_evidence_1=require("../../utils/auth-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_PROTECTED_METHODS=["post","put","patch","delete"];const EMPTY=new Set;function isCsrfMiddleware(node){const callee=node.callee;if(callee.type==="Identifier"){const name=callee.name.toLowerCase();return name==="csrf"||name==="csurf"||name==="csrfprotection"}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="lusca"&&callee.property.type==="Identifier"&&callee.property.name==="csrf"){return true}return false}function isCsrfReference(node){if(node.type==="Identifier")return/csrf|csurf/i.test(node.name);if(node.type==="MemberExpression"){return isCsrfReference(node.object)||node.property.type==="Identifier"&&isCsrfReference(node.property)}if(node.type==="CallExpression")return isCsrfReference(node.callee);return false}function hasCsrfInMiddlewareChain(chain){return chain.some(isCsrfReference)}const EXPRESS_IDENTIFIERS=new Set(["app","router","api","apiRouter","routes","express"]);function isLikelyExpressObject(callee){const obj=callee.object;if(obj.type==="Identifier"){if(EXPRESS_IDENTIFIERS.has(obj.name)){return true}return false}if(obj.type==="CallExpression"){const objCallee=obj.callee;if(objCallee.type==="Identifier"&&objCallee.name==="express"){return true}if(objCallee.type==="MemberExpression"&&objCallee.object.type==="Identifier"&&objCallee.object.name==="express"&&objCallee.property.type==="Identifier"&&objCallee.property.name==="Router"){return true}}if(obj.type==="MemberExpression"){return false}return false}exports.requireCsrfProtection=(0,eslint_devkit_1.createRule)({name:"require-csrf-protection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-csrf-protection.md",description:"Require CSRF protection middleware for state-changing HTTP methods",cwe:"CWE-352",cvss:8.8},hasSuggestions:true,messages:{missingCsrf:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing CSRF Protection",cwe:"CWE-352",description:"Route handler for {{method}} request lacks CSRF protection. Attackers can forge requests from malicious sites.",severity:"HIGH",fix:"Add CSRF middleware: app.use(csrf()) or use csurf package. Include csrfToken in forms.",documentationLink:"https://owasp.org/www-community/attacks/csrf"}),addCsrf:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add CSRF Protection",description:"Add CSRF middleware to protect state-changing requests",severity:"LOW",fix:"npm install csurf; app.use(csurf({ cookie: true }))",documentationLink:"https://www.npmjs.com/package/csurf"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow missing CSRF in test files"},protectedMethods:{type:"array",items:{type:"string"},default:["post","put","patch","delete"],description:"HTTP methods that require CSRF protection"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Route patterns to ignore"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,protectedMethods:DEFAULT_PROTECTED_METHODS,ignorePatterns:[]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};if(!(0,app_composition_1.fileHasAmbientCredentials)(context.sourceCode.ast))return{};const{allowInTests=false,protectedMethods=DEFAULT_PROTECTED_METHODS,ignorePatterns=[]}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}let hasGlobalCsrf=false;const candidates=[];let hasGlobalAuth=false;function shouldIgnoreRoute(routeArg){if(routeArg.type!=="Literal"||typeof routeArg.value!=="string"){return false}const route=routeArg.value;return ignorePatterns.some(pattern=>{try{return new RegExp(pattern).test(route)}catch{return route.includes(pattern)}})}return{CallExpression(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="use"){for(const arg of node.arguments){if(arg.type==="CallExpression"&&isCsrfMiddleware(arg)){hasGlobalCsrf=true;return}if(arg.type==="Identifier"){const name=arg.name.toLowerCase();if(name.includes("csrf")||name.includes("csurf")){hasGlobalCsrf=true;return}}}const[first]=node.arguments;const pathScoped=first?.type==="Literal"&&typeof first.value==="string";if(!pathScoped&&(0,auth_evidence_1.routeIsAuthenticated)(node.arguments,void 0,EMPTY)){hasGlobalAuth=true}}if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"){const method=callee.property.name.toLowerCase();if(!protectedMethods.includes(method)){return}if(!isLikelyExpressObject(callee)){return}const[routeArg,...rest]=node.arguments;if(routeArg&&shouldIgnoreRoute(routeArg)){return}if(hasCsrfInMiddlewareChain(rest.slice(0,-1))){return}candidates.push({node,method:method.toUpperCase(),chain:rest.slice(0,-1),handler:rest[rest.length-1]})}},"Program:exit"(){if(hasGlobalCsrf)return;for(const candidate of candidates){if(!hasGlobalAuth&&!(0,auth_evidence_1.routeIsAuthenticated)(candidate.chain,candidate.handler,EMPTY)){continue}context.report({node:candidate.node,messageId:"missingCsrf",data:{method:candidate.method},suggest:[{messageId:"addCsrf",fix:()=>null}]})}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireCsrfProtection=void 0;const express_evidence_1=require("../../utils/express-evidence");const app_composition_1=require("../../utils/app-composition");const auth_evidence_1=require("../../utils/auth-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_PROTECTED_METHODS=["post","put","patch","delete"];const EMPTY=new Set;function isCsrfMiddleware(node){const callee=node.callee;if(callee.type==="Identifier"){const name=callee.name.toLowerCase();return name==="csrf"||name==="csurf"||name==="csrfprotection"}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="lusca"&&callee.property.type==="Identifier"&&callee.property.name==="csrf"){return true}return false}function isCsrfReference(node){if(node.type==="Identifier")return/csrf|csurf/i.test(node.name);if(node.type==="MemberExpression"){return isCsrfReference(node.object)||node.property.type==="Identifier"&&isCsrfReference(node.property)}if(node.type==="CallExpression")return isCsrfReference(node.callee);return false}function hasCsrfInMiddlewareChain(chain){return chain.some(isCsrfReference)}const EXPRESS_IDENTIFIERS=new Set(["app","router","api","apiRouter","routes","express"]);function isLikelyExpressObject(callee){const obj=callee.object;if(obj.type==="Identifier"){if(EXPRESS_IDENTIFIERS.has(obj.name)){return true}return false}if(obj.type==="CallExpression"){const objCallee=obj.callee;if(objCallee.type==="Identifier"&&objCallee.name==="express"){return true}if(objCallee.type==="MemberExpression"&&objCallee.object.type==="Identifier"&&objCallee.object.name==="express"&&objCallee.property.type==="Identifier"&&objCallee.property.name==="Router"){return true}}if(obj.type==="MemberExpression"){return false}return false}exports.requireCsrfProtection=(0,eslint_devkit_1.createRule)({name:"require-csrf-protection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-csrf-protection.md",description:"Require CSRF protection middleware for state-changing HTTP methods",cwe:"CWE-352",cvss:8.8},messages:{missingCsrf:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing CSRF Protection",cwe:"CWE-352",description:"Route handler for {{method}} request lacks CSRF protection. Attackers can forge requests from malicious sites.",severity:"HIGH",fix:"Add CSRF middleware: app.use(csrf()) or use csurf package. Include csrfToken in forms.",documentationLink:"https://owasp.org/www-community/attacks/csrf"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow missing CSRF in test files"},protectedMethods:{type:"array",items:{type:"string"},default:["post","put","patch","delete"],description:"HTTP methods that require CSRF protection"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Route patterns to ignore"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,protectedMethods:DEFAULT_PROTECTED_METHODS,ignorePatterns:[]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};if(!(0,app_composition_1.fileHasAmbientCredentials)(context.sourceCode.ast))return{};const{allowInTests=false,protectedMethods=DEFAULT_PROTECTED_METHODS,ignorePatterns=[]}=options;const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);if(isTestFile){return{}}let hasGlobalCsrf=false;const candidates=[];let hasGlobalAuth=false;function shouldIgnoreRoute(routeArg){if(routeArg.type!=="Literal"||typeof routeArg.value!=="string"){return false}const route=routeArg.value;return ignorePatterns.some(pattern=>{try{return new RegExp(pattern).test(route)}catch{return route.includes(pattern)}})}return{CallExpression(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="use"){for(const arg of node.arguments){if(arg.type==="CallExpression"&&isCsrfMiddleware(arg)){hasGlobalCsrf=true;return}if(arg.type==="Identifier"){const name=arg.name.toLowerCase();if(name.includes("csrf")||name.includes("csurf")){hasGlobalCsrf=true;return}}}const[first]=node.arguments;const pathScoped=first?.type==="Literal"&&typeof first.value==="string";if(!pathScoped&&(0,auth_evidence_1.routeIsAuthenticated)(node.arguments,void 0,EMPTY)){hasGlobalAuth=true}}if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"){const method=callee.property.name.toLowerCase();if(!protectedMethods.includes(method)){return}if(!isLikelyExpressObject(callee)){return}const[routeArg,...rest]=node.arguments;if(routeArg&&shouldIgnoreRoute(routeArg)){return}if(hasCsrfInMiddlewareChain(rest.slice(0,-1))){return}candidates.push({node,method:method.toUpperCase(),chain:rest.slice(0,-1),handler:rest[rest.length-1]})}},"Program:exit"(){if(hasGlobalCsrf)return;for(const candidate of candidates){if(!hasGlobalAuth&&!(0,auth_evidence_1.routeIsAuthenticated)(candidate.chain,candidate.handler,EMPTY)){continue}context.report({node:candidate.node,messageId:"missingCsrf",data:{method:candidate.method}})}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireExpressBodyParserLimits=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_MAX_LIMIT=5*1024*1024;const DEFAULT_EXCESSIVE_LIMITS=["10mb","50mb","100mb","500mb","1gb","1GB","10MB","50MB","100MB","500MB"];const BODY_PARSER_METHODS=new Set(["json","urlencoded","raw","text"]);function getLimitOption(properties){for(const prop of properties){if(prop.type==="Property"&&prop.key.type==="Identifier"&&prop.key.name==="limit"){return prop}}return null}const UNITS={b:1,kb:1024,mb:1024**2,gb:1024**3,tb:1024**4};function limitInBytes(value){if(value.type!=="Literal")return null;if(typeof value.value==="number")return value.value;if(typeof value.value!=="string")return null;const parsed=/^\s*(\d+(?:\.\d+)?)\s*(b|kb|mb|gb|tb)?\s*$/i.exec(value.value);if(!parsed)return null;return Number(parsed[1])*UNITS[(parsed[2]??"b").toLowerCase()]}function isExcessiveLimit(value,excessiveLimits,maxLimit){if(value.type==="Literal"&&typeof value.value==="string"){const named=excessiveLimits.some(limit=>String(value.value).toLowerCase()===limit.toLowerCase());if(named)return true}const bytes=limitInBytes(value);return bytes!==null&&bytes>maxLimit}exports.requireExpressBodyParserLimits=(0,eslint_devkit_1.createRule)({name:"require-express-body-parser-limits",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-express-body-parser-limits.md",description:"Require size limits on Express.js body parsers to prevent DoS attacks",cwe:"CWE-400",cvss:7.5},messages:{excessiveLimit:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Excessive Body Parser Limit",cwe:"CWE-400",description:"This body parser raises the limit above Express's 100kb default, so a single request can pin that much memory per connection.",severity:"MEDIUM",fix:"Reduce the limit to a reasonable size: '100kb' for JSON APIs, '1mb' for file uploads with proper handling",documentationLink:"https://expressjs.com/en/4x/api.html#express.json"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow in test files"},maxLimit:{type:"number",default:DEFAULT_MAX_LIMIT,description:"Largest explicit body-parser limit, in bytes, that is not reported"},excessiveLimits:{type:"array",items:{type:"string"},default:DEFAULT_EXCESSIVE_LIMITS,description:"Limits considered excessive"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,maxLimit:DEFAULT_MAX_LIMIT,excessiveLimits:DEFAULT_EXCESSIVE_LIMITS}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,maxLimit=DEFAULT_MAX_LIMIT,excessiveLimits=DEFAULT_EXCESSIVE_LIMITS}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}return{CallExpression(node){const callee=node.callee;if(callee.type!=="MemberExpression"){return}const object=callee.object;const property=callee.property;if(object.type!=="Identifier"){return}if(object.name!=="express"&&object.name!=="bodyParser"){return}if(property.type!=="Identifier"){return}if(!BODY_PARSER_METHODS.has(property.name)){return}const firstArg=node.arguments[0];if(firstArg?.type!=="ObjectExpression")return;const limitProp=getLimitOption(firstArg.properties);if(!limitProp)return;if(isExcessiveLimit(limitProp.value,excessiveLimits,maxLimit)){context.report({node:limitProp,messageId:"excessiveLimit"})}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireExpressBodyParserLimits=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_MAX_LIMIT=5*1024*1024;const DEFAULT_EXCESSIVE_LIMITS=["10mb","50mb","100mb","500mb","1gb","1GB","10MB","50MB","100MB","500MB"];const BODY_PARSER_METHODS=new Set(["json","urlencoded","raw","text"]);function getLimitOption(properties){for(const prop of properties){if(prop.type==="Property"&&prop.key.type==="Identifier"&&prop.key.name==="limit"){return prop}}return null}const UNITS={b:1,kb:1024,mb:1024**2,gb:1024**3,tb:1024**4};function limitInBytes(value){if(value.type!=="Literal")return null;if(typeof value.value==="number")return value.value;if(typeof value.value!=="string")return null;const parsed=/^\s*(\d+(?:\.\d+)?)\s*(b|kb|mb|gb|tb)?\s*$/i.exec(value.value);if(!parsed)return null;return Number(parsed[1])*UNITS[(parsed[2]??"b").toLowerCase()]}function isExcessiveLimit(value,excessiveLimits,maxLimit){if(value.type==="Literal"&&typeof value.value==="string"){const named=excessiveLimits.some(limit=>String(value.value).toLowerCase()===limit.toLowerCase());if(named)return true}const bytes=limitInBytes(value);return bytes!==null&&bytes>maxLimit}exports.requireExpressBodyParserLimits=(0,eslint_devkit_1.createRule)({name:"require-express-body-parser-limits",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-express-body-parser-limits.md",description:"Require size limits on Express.js body parsers to prevent DoS attacks",cwe:"CWE-400",cvss:7.5},messages:{excessiveLimit:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Excessive Body Parser Limit",cwe:"CWE-400",description:"This body parser raises the limit above Express's 100kb default, so a single request can pin that much memory per connection.",severity:"MEDIUM",fix:"Reduce the limit to a reasonable size: '100kb' for JSON APIs, '1mb' for file uploads with proper handling",documentationLink:"https://expressjs.com/en/4x/api.html#express.json"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow in test files"},maxLimit:{type:"number",default:DEFAULT_MAX_LIMIT,description:"Largest explicit body-parser limit, in bytes, that is not reported"},excessiveLimits:{type:"array",items:{type:"string"},default:DEFAULT_EXCESSIVE_LIMITS,description:"Limits considered excessive"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,maxLimit:DEFAULT_MAX_LIMIT,excessiveLimits:DEFAULT_EXCESSIVE_LIMITS}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,maxLimit=DEFAULT_MAX_LIMIT,excessiveLimits=DEFAULT_EXCESSIVE_LIMITS}=options;const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);if(isTestFile){return{}}return{CallExpression(node){const callee=node.callee;if(callee.type!=="MemberExpression"){return}const object=callee.object;const property=callee.property;if(object.type!=="Identifier"){return}if(object.name!=="express"&&object.name!=="bodyParser"){return}if(property.type!=="Identifier"){return}if(!BODY_PARSER_METHODS.has(property.name)){return}const firstArg=node.arguments[0];if(firstArg?.type!=="ObjectExpression")return;const limitProp=getLimitOption(firstArg.properties);if(!limitProp)return;if(isExcessiveLimit(limitProp.value,excessiveLimits,maxLimit)){context.report({node:limitProp,messageId:"excessiveLimit"})}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireHelmet=void 0;const express_evidence_1=require("../../utils/express-evidence");const app_composition_1=require("../../utils/app-composition");const eslint_devkit_1=require("@interlace/eslint-devkit");function isHelmetMiddleware(node){const callee=node.callee;if(callee.type!=="MemberExpression"){return false}if(callee.property.type!=="Identifier"||callee.property.name!=="use"){return false}for(const arg of node.arguments){if(arg.type==="CallExpression"){const argCallee=arg.callee;if(argCallee.type==="Identifier"&&argCallee.name==="helmet"){return true}if(argCallee.type==="MemberExpression"&&argCallee.object.type==="Identifier"&&argCallee.object.name==="helmet"){return true}}if(arg.type==="Identifier"&&arg.name==="helmet"){return true}}return false}function isAlternativeMiddleware(node,alternatives){for(const arg of node.arguments){if(arg.type==="CallExpression"&&arg.callee.type==="Identifier"){if(alternatives.includes(arg.callee.name)){return true}}if(arg.type==="Identifier"&&alternatives.includes(arg.name)){return true}}return false}exports.requireHelmet=(0,eslint_devkit_1.createRule)({name:"require-helmet",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-helmet.md",description:"Require helmet middleware for security headers in Express.js applications",cwe:"CWE-693",cvss:7.5,confidence:"high"},hasSuggestions:true,messages:{missingHelmet:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing Security Headers",cwe:"CWE-693",description:"This Express app renders documents to a browser but never mounts helmet. Without it the responses carry no Content-Security-Policy, X-Frame-Options or referrer policy, so any rendered page is framable and unconstrained.",severity:"HIGH",fix:"Add helmet middleware: app.use(helmet()). Install with 'npm install helmet'.",documentationLink:"https://helmetjs.github.io/"}),addHelmet:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Helmet",description:"Add helmet middleware for security headers",severity:"LOW",fix:"import helmet from 'helmet'; app.use(helmet());",documentationLink:"https://helmetjs.github.io/"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow missing helmet in test files"},alternativeMiddleware:{type:"array",items:{type:"string"},default:[],description:"Alternative security headers middleware names to accept"},assumeHelmetMiddleware:{type:"boolean",default:false,description:"Skip rule if security headers are provided elsewhere (e.g., reverse proxy)"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,alternativeMiddleware:[],assumeHelmetMiddleware:false}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};if(!(0,app_composition_1.servesBrowserDocuments)(context.sourceCode.ast))return{};const{allowInTests=false,alternativeMiddleware=[],assumeHelmetMiddleware=false}=options;if(assumeHelmetMiddleware){return{}}const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}let hasExpressApp=false;let hasHelmet=false;let expressAppNode=null;let appBinding=null;let appEscapes=false;return{[app_composition_1.RELEASE_SELECTOR](node){if(appBinding!==null&&(0,app_composition_1.nodeReleasesBinding)(node,appBinding)){appEscapes=true}},CallExpression(node){const callee=node.callee;if(appBinding!==null&&(0,app_composition_1.nodeReleasesBinding)(node,appBinding)){appEscapes=true}if(callee.type==="Identifier"&&callee.name==="express"){hasExpressApp=true;expressAppNode=node;if(node.parent?.type==="VariableDeclarator"&&node.parent.id.type==="Identifier"){appBinding=node.parent.id.name}return}if(callee.type==="CallExpression"&&callee.callee.type==="Identifier"&&callee.callee.name==="require"){const firstArg=callee.arguments[0];if(firstArg&&firstArg.type==="Literal"&&firstArg.value==="express"){hasExpressApp=true;expressAppNode=node;return}}if(isHelmetMiddleware(node)){hasHelmet=true;return}if(isAlternativeMiddleware(node,alternativeMiddleware)){hasHelmet=true;return}},"Program:exit"(){if(hasExpressApp&&!hasHelmet&&!appEscapes&&expressAppNode){context.report({node:expressAppNode,messageId:"missingHelmet",suggest:[{messageId:"addHelmet",fix:()=>null}]})}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireHelmet=void 0;const express_evidence_1=require("../../utils/express-evidence");const app_composition_1=require("../../utils/app-composition");const eslint_devkit_1=require("@interlace/eslint-devkit");function isHelmetMiddleware(node){const callee=node.callee;if(callee.type!=="MemberExpression"){return false}if(callee.property.type!=="Identifier"||callee.property.name!=="use"){return false}for(const arg of node.arguments){if(arg.type==="CallExpression"){const argCallee=arg.callee;if(argCallee.type==="Identifier"&&argCallee.name==="helmet"){return true}if(argCallee.type==="MemberExpression"&&argCallee.object.type==="Identifier"&&argCallee.object.name==="helmet"){return true}}if(arg.type==="Identifier"&&arg.name==="helmet"){return true}}return false}function isAlternativeMiddleware(node,alternatives){for(const arg of node.arguments){if(arg.type==="CallExpression"&&arg.callee.type==="Identifier"){if(alternatives.includes(arg.callee.name)){return true}}if(arg.type==="Identifier"&&alternatives.includes(arg.name)){return true}}return false}exports.requireHelmet=(0,eslint_devkit_1.createRule)({name:"require-helmet",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-helmet.md",description:"Require helmet middleware for security headers in Express.js applications",cwe:"CWE-693",cvss:7.5,confidence:"high"},messages:{missingHelmet:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing Security Headers",cwe:"CWE-693",description:"This Express app renders documents to a browser but never mounts helmet. Without it the responses carry no Content-Security-Policy, X-Frame-Options or referrer policy, so any rendered page is framable and unconstrained.",severity:"HIGH",fix:"Add helmet middleware: app.use(helmet()). Install with 'npm install helmet'.",documentationLink:"https://helmetjs.github.io/"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow missing helmet in test files"},alternativeMiddleware:{type:"array",items:{type:"string"},default:[],description:"Alternative security headers middleware names to accept"},assumeHelmetMiddleware:{type:"boolean",default:false,description:"Skip rule if security headers are provided elsewhere (e.g., reverse proxy)"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,alternativeMiddleware:[],assumeHelmetMiddleware:false}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};if(!(0,app_composition_1.servesBrowserDocuments)(context.sourceCode.ast))return{};const{allowInTests=false,alternativeMiddleware=[],assumeHelmetMiddleware=false}=options;if(assumeHelmetMiddleware){return{}}const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);if(isTestFile){return{}}let hasExpressApp=false;let hasHelmet=false;let expressAppNode=null;let appBinding=null;let appEscapes=false;return{[app_composition_1.RELEASE_SELECTOR](node){if(appBinding!==null&&(0,app_composition_1.nodeReleasesBinding)(node,appBinding)){appEscapes=true}},CallExpression(node){const callee=node.callee;if(appBinding!==null&&(0,app_composition_1.nodeReleasesBinding)(node,appBinding)){appEscapes=true}if(callee.type==="Identifier"&&callee.name==="express"){hasExpressApp=true;expressAppNode=node;if(node.parent?.type==="VariableDeclarator"&&node.parent.id.type==="Identifier"){appBinding=node.parent.id.name}return}if(callee.type==="CallExpression"&&callee.callee.type==="Identifier"&&callee.callee.name==="require"){const firstArg=callee.arguments[0];if(firstArg&&firstArg.type==="Literal"&&firstArg.value==="express"){hasExpressApp=true;expressAppNode=node;return}}if(isHelmetMiddleware(node)){hasHelmet=true;return}if(isAlternativeMiddleware(node,alternativeMiddleware)){hasHelmet=true;return}},"Program:exit"(){if(hasExpressApp&&!hasHelmet&&!appEscapes&&expressAppNode){context.report({node:expressAppNode,messageId:"missingHelmet"})}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireRateLimiting=void 0;const express_evidence_1=require("../../utils/express-evidence");const app_composition_1=require("../../utils/app-composition");const eslint_devkit_1=require("@interlace/eslint-devkit");const STATE_CHANGING_METHODS=new Set(["post","put","patch","delete"]);const APP_RECEIVER=/^(app|router|express|api|apiRouter|routes)$/i;const CREDENTIAL_PATH=/(^|[^a-z0-9])(login|log-in|signin|sign-in|signup|sign-up|register|authenticate|auth|authorize|token|password|passwd|credential|otp|mfa|2fa|totp|verify|verification|confirm|reset|forgot|recover|unlock|challenge|session|invite|redeem|coupon|promo)([^a-z0-9]|$)/i;const RATE_LIMIT_PACKAGES=["ratelimit","rateLimit","rateLimiter","limiter","expressRateLimit","slowDown","expressBrute"];function isRateLimitMiddleware(node,alternatives){const allPatterns=[...RATE_LIMIT_PACKAGES,...alternatives];for(const arg of node.arguments){if(arg.type==="CallExpression"&&arg.callee.type==="Identifier"){const calleeName=arg.callee.name.toLowerCase();if(allPatterns.some(p=>calleeName.includes(p.toLowerCase()))){return true}}if(arg.type==="Identifier"){if(allPatterns.some(p=>arg.name.toLowerCase().includes(p.toLowerCase()))){return true}}}return false}exports.requireRateLimiting=(0,eslint_devkit_1.createRule)({name:"require-rate-limiting",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-rate-limiting.md",description:"Require rate-limiting middleware in Express.js applications",cwe:"CWE-770",cvss:7.5},hasSuggestions:true,messages:{missingRateLimiting:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Unthrottled Credential Endpoint",cwe:"CWE-770",description:"{{method}} {{path}} accepts a secret to be checked and this app mounts no rate limiter. An attacker can run the guess-and-retry loop at full speed.",severity:"HIGH",fix:"Add rate limiting: npm install express-rate-limit; app.use(rateLimit({ windowMs: 15*60*1000, max: 100 }))",documentationLink:"https://www.npmjs.com/package/express-rate-limit"}),addRateLimiting:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Rate Limiting",description:"Add rate-limiting middleware to protect against abuse",severity:"LOW",fix:"import rateLimit from 'express-rate-limit'; app.use(rateLimit({ windowMs: 15*60*1000, max: 100 }));",documentationLink:"https://www.npmjs.com/package/express-rate-limit"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false},alternativeMiddleware:{type:"array",items:{type:"string"},default:[],description:"Extra middleware names that count as rate limiting"},assumeRateLimiting:{type:"boolean",default:false,description:"Skip if rate limiting is provided by infrastructure (API Gateway, nginx, etc.)"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,alternativeMiddleware:[],assumeRateLimiting:false}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,alternativeMiddleware=[],assumeRateLimiting=false}=options;if(assumeRateLimiting){return{}}const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}let hasExpressApp=false;let hasRateLimiting=false;let credentialRoute=null;let appBinding=null;let appEscapes=false;return{[app_composition_1.RELEASE_SELECTOR](node){if(appBinding!==null&&(0,app_composition_1.nodeReleasesBinding)(node,appBinding)){appEscapes=true}},CallExpression(node){const callee=node.callee;if(appBinding!==null&&(0,app_composition_1.nodeReleasesBinding)(node,appBinding)){appEscapes=true}if(callee.type==="Identifier"&&callee.name==="express"){hasExpressApp=true;if(node.parent?.type==="VariableDeclarator"&&node.parent.id.type==="Identifier"){appBinding=node.parent.id.name}return}if(callee.type!=="MemberExpression"||callee.property.type!=="Identifier"){return}const method=callee.property.name.toLowerCase();if(isRateLimitMiddleware(node,alternativeMiddleware)){hasRateLimiting=true;return}if(!STATE_CHANGING_METHODS.has(method))return;if(callee.object.type!=="Identifier"||!APP_RECEIVER.test(callee.object.name)){return}const[pathArg,...rest]=node.arguments;if(rest.length===0||pathArg?.type!=="Literal"||typeof pathArg.value!=="string"){return}if(!CREDENTIAL_PATH.test(pathArg.value))return;credentialRoute??={node,method:method.toUpperCase(),path:pathArg.value}},"Program:exit"(){if(hasExpressApp&&!hasRateLimiting&&!appEscapes&&credentialRoute){context.report({node:credentialRoute.node,messageId:"missingRateLimiting",data:{method:credentialRoute.method,path:credentialRoute.path},suggest:[{messageId:"addRateLimiting",fix:()=>null}]})}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireRateLimiting=void 0;const express_evidence_1=require("../../utils/express-evidence");const app_composition_1=require("../../utils/app-composition");const eslint_devkit_1=require("@interlace/eslint-devkit");const STATE_CHANGING_METHODS=new Set(["post","put","patch","delete"]);const APP_RECEIVER=/^(app|router|express|api|apiRouter|routes)$/i;const CREDENTIAL_PATH=/(^|[^a-z0-9])(login|log-in|signin|sign-in|signup|sign-up|register|authenticate|auth|authorize|token|password|passwd|credential|otp|mfa|2fa|totp|verify|verification|confirm|reset|forgot|recover|unlock|challenge|session|invite|redeem|coupon|promo)([^a-z0-9]|$)/i;const RATE_LIMIT_PACKAGES=["ratelimit","rateLimit","rateLimiter","limiter","expressRateLimit","slowDown","expressBrute"];function isRateLimitMiddleware(node,alternatives){const allPatterns=[...RATE_LIMIT_PACKAGES,...alternatives];for(const arg of node.arguments){if(arg.type==="CallExpression"&&arg.callee.type==="Identifier"){const calleeName=arg.callee.name.toLowerCase();if(allPatterns.some(p=>calleeName.includes(p.toLowerCase()))){return true}}if(arg.type==="Identifier"){if(allPatterns.some(p=>arg.name.toLowerCase().includes(p.toLowerCase()))){return true}}}return false}exports.requireRateLimiting=(0,eslint_devkit_1.createRule)({name:"require-rate-limiting",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-rate-limiting.md",description:"Require rate-limiting middleware in Express.js applications",cwe:"CWE-770",cvss:7.5},messages:{missingRateLimiting:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Unthrottled Credential Endpoint",cwe:"CWE-770",description:"{{method}} {{path}} accepts a secret to be checked and this app mounts no rate limiter. An attacker can run the guess-and-retry loop at full speed.",severity:"HIGH",fix:"Add rate limiting: npm install express-rate-limit; app.use(rateLimit({ windowMs: 15*60*1000, max: 100 }))",documentationLink:"https://www.npmjs.com/package/express-rate-limit"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false},alternativeMiddleware:{type:"array",items:{type:"string"},default:[],description:"Extra middleware names that count as rate limiting"},assumeRateLimiting:{type:"boolean",default:false,description:"Skip if rate limiting is provided by infrastructure (API Gateway, nginx, etc.)"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,alternativeMiddleware:[],assumeRateLimiting:false}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,alternativeMiddleware=[],assumeRateLimiting=false}=options;if(assumeRateLimiting){return{}}const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);if(isTestFile){return{}}let hasExpressApp=false;let hasRateLimiting=false;let credentialRoute=null;let appBinding=null;let appEscapes=false;return{[app_composition_1.RELEASE_SELECTOR](node){if(appBinding!==null&&(0,app_composition_1.nodeReleasesBinding)(node,appBinding)){appEscapes=true}},CallExpression(node){const callee=node.callee;if(appBinding!==null&&(0,app_composition_1.nodeReleasesBinding)(node,appBinding)){appEscapes=true}if(callee.type==="Identifier"&&callee.name==="express"){hasExpressApp=true;if(node.parent?.type==="VariableDeclarator"&&node.parent.id.type==="Identifier"){appBinding=node.parent.id.name}return}if(callee.type!=="MemberExpression"||callee.property.type!=="Identifier"){return}const method=callee.property.name.toLowerCase();if(isRateLimitMiddleware(node,alternativeMiddleware)){hasRateLimiting=true;return}if(!STATE_CHANGING_METHODS.has(method))return;if(callee.object.type!=="Identifier"||!APP_RECEIVER.test(callee.object.name)){return}const[pathArg,...rest]=node.arguments;if(rest.length===0||pathArg?.type!=="Literal"||typeof pathArg.value!=="string"){return}if(!CREDENTIAL_PATH.test(pathArg.value))return;credentialRoute??={node,method:method.toUpperCase(),path:pathArg.value}},"Program:exit"(){if(hasExpressApp&&!hasRateLimiting&&!appEscapes&&credentialRoute){context.report({node:credentialRoute.node,messageId:"missingRateLimiting",data:{method:credentialRoute.method,path:credentialRoute.path}})}}}}});