eslint-plugin-express-security 2.0.1 → 3.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +1 -0
- package/package.json +2 -2
- package/src/index.js +1 -1
- package/src/rules/no-insecure-cookie-options/index.js +1 -1
- package/src/rules/no-permissive-cors/index.js +1 -1
- package/src/rules/no-static-root-exposure/index.js +1 -1
- package/src/rules/require-csrf-protection/index.js +1 -1
- package/src/rules/require-express-body-parser-limits/index.js +1 -1
- package/src/rules/require-helmet/index.js +1 -1
- package/src/rules/require-rate-limiting/index.js +1 -1
- package/src/rules/require-route-authentication/index.js +1 -1
- package/src/utils/app-composition.js +1 -0
- package/src/utils/auth-evidence.js +1 -0
package/README.md
CHANGED
|
@@ -18,6 +18,7 @@
|
|
|
18
18
|
<a href="https://opensource.org/licenses/MIT" target="_blank"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="Package License" /></a>
|
|
19
19
|
<a href="https://app.codecov.io/gh/ofri-peretz/eslint/components?components%5B0%5D=eslint-plugin-express-security" target="_blank"><img src="https://codecov.io/gh/ofri-peretz/eslint/graph/badge.svg?component=eslint-plugin-express-security" alt="Codecov" /></a>
|
|
20
20
|
<a href="https://github.com/ofri-peretz/eslint" target="_blank"><img src="https://img.shields.io/badge/Since-Dec_2025-blue?logo=rocket&logoColor=white" alt="Since Dec 2025" /></a>
|
|
21
|
+
<a href="https://scorecard.dev/viewer/?uri=github.com/ofri-peretz/eslint" target="_blank"><img src="https://api.securityscorecards.dev/projects/github.com/ofri-peretz/eslint/badge" alt="OpenSSF Scorecard" /></a>
|
|
21
22
|
</p>
|
|
22
23
|
|
|
23
24
|
> ⭐ If this plugin caught a real bug for you, [**star the repo**](https://github.com/ofri-peretz/eslint) — it's the signal that keeps these rules maintained.
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "eslint-plugin-express-security",
|
|
3
|
-
"version": "
|
|
3
|
+
"version": "3.1.0",
|
|
4
4
|
"description": "ESLint plugin for Express.js security — detects permissive CORS, missing CSRF protection, missing helmet headers, insecure cookies, and GraphQL introspection in production.",
|
|
5
5
|
"type": "commonjs",
|
|
6
6
|
"main": "./src/index.js",
|
|
@@ -76,7 +76,7 @@
|
|
|
76
76
|
"node": ">=18.0.0"
|
|
77
77
|
},
|
|
78
78
|
"dependencies": {
|
|
79
|
-
"@interlace/eslint-devkit": "^1.
|
|
79
|
+
"@interlace/eslint-devkit": "^1.14.0"
|
|
80
80
|
},
|
|
81
81
|
"peerDependencies": {
|
|
82
82
|
"eslint": "^8.40.0 || ^9.0.0 || ^10.0.0",
|
package/src/index.js
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;exports.rules={get"require-helmet"(){return require("./rules/require-helmet").requireHelmet},get"no-permissive-cors"(){return require("./rules/no-permissive-cors").noPermissiveCors},get"require-csrf-protection"(){return require("./rules/require-csrf-protection").requireCsrfProtection},get"no-insecure-cookie-options"(){return require("./rules/no-insecure-cookie-options").noInsecureCookieOptions},get"require-rate-limiting"(){return require("./rules/require-rate-limiting").requireRateLimiting},get"no-graphql-introspection-production"(){return require("./rules/no-graphql-introspection-production").noGraphqlIntrospectionProduction},get"no-cors-credentials-wildcard"(){return require("./rules/no-cors-credentials-wildcard").noCorsCredentialsWildcard},get"require-express-body-parser-limits"(){return require("./rules/require-express-body-parser-limits").requireExpressBodyParserLimits},get"no-express-unsafe-regex-route"(){return require("./rules/no-express-unsafe-regex-route").noExpressUnsafeRegexRoute},get"no-exposed-debug-endpoints"(){return require("./rules/no-exposed-debug-endpoints").noExposedDebugEndpoints},get"no-missing-cors-check"(){return require("./rules/no-missing-cors-check").noMissingCorsCheck},get"no-missing-csrf-protection"(){return require("./rules/no-missing-csrf-protection").noMissingCsrfProtection},get"no-missing-security-headers"(){return require("./rules/no-missing-security-headers").noMissingSecurityHeaders},get"no-user-controlled-redirect"(){return require("./rules/no-user-controlled-redirect").noUserControlledRedirect},get"no-host-header-in-links"(){return require("./rules/no-host-header-in-links").noHostHeaderInLinks},get"no-error-details-in-response"(){return require("./rules/no-error-details-in-response").noErrorDetailsInResponse},get"no-sensitive-data-in-query"(){return require("./rules/no-sensitive-data-in-query").noSensitiveDataInQuery},get"no-user-controlled-render-locals"(){return require("./rules/no-user-controlled-render-locals").noUserControlledRenderLocals},get"no-static-root-exposure"(){return require("./rules/no-static-root-exposure").noStaticRootExposure},get"require-case-insensitive-path-guard"(){return require("./rules/require-case-insensitive-path-guard").requireCaseInsensitivePathGuard},get"require-query-type-guard"(){return require("./rules/require-query-type-guard").requireQueryTypeGuard},get"no-disabled-helmet-protections"(){return require("./rules/no-disabled-helmet-protections").noDisabledHelmetProtections},get"require-strict-transport-security"(){return require("./rules/require-strict-transport-security").requireStrictTransportSecurity},get"no-unsafe-csp-directives"(){return require("./rules/no-unsafe-csp-directives").noUnsafeCspDirectives},get"no-permissive-trust-proxy"(){return require("./rules/no-permissive-trust-proxy").noPermissiveTrustProxy},get"require-route-authentication"(){return require("./rules/require-route-authentication").requireRouteAuthentication},get"no-client-controlled-authorization"(){return require("./rules/no-client-controlled-authorization").noClientControlledAuthorization},get"no-idor-resource-access"(){return require("./rules/no-idor-resource-access").noIdorResourceAccess}};exports.plugin={meta:{name:"eslint-plugin-express-security",version:"
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;exports.rules={get"require-helmet"(){return require("./rules/require-helmet").requireHelmet},get"no-permissive-cors"(){return require("./rules/no-permissive-cors").noPermissiveCors},get"require-csrf-protection"(){return require("./rules/require-csrf-protection").requireCsrfProtection},get"no-insecure-cookie-options"(){return require("./rules/no-insecure-cookie-options").noInsecureCookieOptions},get"require-rate-limiting"(){return require("./rules/require-rate-limiting").requireRateLimiting},get"no-graphql-introspection-production"(){return require("./rules/no-graphql-introspection-production").noGraphqlIntrospectionProduction},get"no-cors-credentials-wildcard"(){return require("./rules/no-cors-credentials-wildcard").noCorsCredentialsWildcard},get"require-express-body-parser-limits"(){return require("./rules/require-express-body-parser-limits").requireExpressBodyParserLimits},get"no-express-unsafe-regex-route"(){return require("./rules/no-express-unsafe-regex-route").noExpressUnsafeRegexRoute},get"no-exposed-debug-endpoints"(){return require("./rules/no-exposed-debug-endpoints").noExposedDebugEndpoints},get"no-missing-cors-check"(){return require("./rules/no-missing-cors-check").noMissingCorsCheck},get"no-missing-csrf-protection"(){return require("./rules/no-missing-csrf-protection").noMissingCsrfProtection},get"no-missing-security-headers"(){return require("./rules/no-missing-security-headers").noMissingSecurityHeaders},get"no-user-controlled-redirect"(){return require("./rules/no-user-controlled-redirect").noUserControlledRedirect},get"no-host-header-in-links"(){return require("./rules/no-host-header-in-links").noHostHeaderInLinks},get"no-error-details-in-response"(){return require("./rules/no-error-details-in-response").noErrorDetailsInResponse},get"no-sensitive-data-in-query"(){return require("./rules/no-sensitive-data-in-query").noSensitiveDataInQuery},get"no-user-controlled-render-locals"(){return require("./rules/no-user-controlled-render-locals").noUserControlledRenderLocals},get"no-static-root-exposure"(){return require("./rules/no-static-root-exposure").noStaticRootExposure},get"require-case-insensitive-path-guard"(){return require("./rules/require-case-insensitive-path-guard").requireCaseInsensitivePathGuard},get"require-query-type-guard"(){return require("./rules/require-query-type-guard").requireQueryTypeGuard},get"no-disabled-helmet-protections"(){return require("./rules/no-disabled-helmet-protections").noDisabledHelmetProtections},get"require-strict-transport-security"(){return require("./rules/require-strict-transport-security").requireStrictTransportSecurity},get"no-unsafe-csp-directives"(){return require("./rules/no-unsafe-csp-directives").noUnsafeCspDirectives},get"no-permissive-trust-proxy"(){return require("./rules/no-permissive-trust-proxy").noPermissiveTrustProxy},get"require-route-authentication"(){return require("./rules/require-route-authentication").requireRouteAuthentication},get"no-client-controlled-authorization"(){return require("./rules/no-client-controlled-authorization").noClientControlledAuthorization},get"no-idor-resource-access"(){return require("./rules/no-idor-resource-access").noIdorResourceAccess}};exports.plugin={meta:{name:"eslint-plugin-express-security",version:"3.1.0"},rules:exports.rules};const recommendedRules={"express-security/require-helmet":"error","express-security/no-permissive-cors":"error","express-security/require-csrf-protection":"warn","express-security/no-insecure-cookie-options":"error","express-security/require-rate-limiting":"error","express-security/no-graphql-introspection-production":"warn","express-security/no-cors-credentials-wildcard":"error","express-security/require-express-body-parser-limits":"warn","express-security/no-express-unsafe-regex-route":"error","express-security/no-exposed-debug-endpoints":"error","express-security/no-user-controlled-redirect":"error","express-security/no-host-header-in-links":"error","express-security/no-error-details-in-response":"error","express-security/no-sensitive-data-in-query":"warn","express-security/no-user-controlled-render-locals":"error","express-security/no-static-root-exposure":"error","express-security/require-case-insensitive-path-guard":"warn","express-security/require-query-type-guard":"warn","express-security/no-disabled-helmet-protections":"error","express-security/require-strict-transport-security":"error","express-security/no-unsafe-csp-directives":"error","express-security/no-permissive-trust-proxy":"error","express-security/require-route-authentication":"warn","express-security/no-client-controlled-authorization":"warn","express-security/no-idor-resource-access":"warn"};exports.configs={recommended:{plugins:{"express-security":exports.plugin},rules:recommendedRules},strict:{plugins:{"express-security":exports.plugin},rules:Object.fromEntries(Object.keys(exports.rules).map(ruleName=>[`express-security/${ruleName}`,"error"]))},api:{plugins:{"express-security":exports.plugin},rules:{"express-security/require-helmet":"error","express-security/no-disabled-helmet-protections":"error","express-security/require-strict-transport-security":"error","express-security/no-unsafe-csp-directives":"error","express-security/no-permissive-trust-proxy":"error","express-security/no-permissive-cors":"error","express-security/require-csrf-protection":"error","express-security/no-insecure-cookie-options":"error","express-security/require-rate-limiting":"error"}},graphql:{plugins:{"express-security":exports.plugin},rules:{"express-security/no-graphql-introspection-production":"error"}}};exports.default=exports.plugin;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noInsecureCookieOptions=void 0;exports.checkCookieOptions=checkCookieOptions;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noInsecureCookieOptions=void 0;exports.checkCookieOptions=checkCookieOptions;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function propertyName(property){if(property.type!=="Property")return void 0;if(property.key.type==="Identifier"&&!property.computed){return property.key.name.toLowerCase()}if(property.key.type==="Literal"&&typeof property.key.value==="string"){return property.key.value.toLowerCase()}return void 0}function flagState(node,name,hasSpread){const property=[...node.properties].reverse().find(p=>propertyName(p)===name);if(property===void 0)return hasSpread?"unknown":"absent";const value=property.value;if(value.type!=="Literal")return"unknown";return value.value===true?"on":"off"}function checkCookieOptions(node,options){const issues=[];const hasSpread=node.properties.some(p=>p.type==="SpreadElement");if(options.requireHttpOnly!==false){const state=flagState(node,"httponly",hasSpread);if(state==="absent"||state==="off"){issues.push("missing httpOnly flag (prevents XSS access to cookie)")}}if(options.requireSecure!==false){const state=flagState(node,"secure",hasSpread);if(state==="absent"||state==="off"){issues.push("missing secure flag (cookie sent over HTTPS only)")}}if(options.requireSameSite!==false){const acceptableValues=options.acceptableSameSiteValues||["strict","lax"];const property=[...node.properties].reverse().find(p=>propertyName(p)==="samesite");if(property===void 0){if(!hasSpread)issues.push("missing sameSite flag (prevents CSRF)")}else if(property.value.type==="Literal"&&typeof property.value.value==="string"){const value=property.value.value;if(!acceptableValues.includes(value.toLowerCase())){issues.push(`sameSite should be 'strict' or 'lax', not '${value}'`)}}}return{issues,hasSuggestions:issues.length>0}}exports.noInsecureCookieOptions=(0,eslint_devkit_1.createRule)({name:"no-insecure-cookie-options",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-insecure-cookie-options.md",description:"Require secure cookie flags (httpOnly, secure, sameSite) in Express.js",cwe:"CWE-614",cvss:5.3},hasSuggestions:true,messages:{insecureCookie:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Insecure Cookie Configuration",cwe:"CWE-614",description:"{{issues}}",severity:"HIGH",fix:'Set httpOnly: true, secure: true, sameSite: "strict"',documentationLink:"https://owasp.org/www-community/controls/SecureCookieAttribute"}),addSecureFlags:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Secure Cookie Flags",description:"Add missing security flags to cookie options",severity:"LOW",fix:'{ httpOnly: true, secure: true, sameSite: "strict" }',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#security"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false},requireHttpOnly:{type:"boolean",default:true},requireSecure:{type:"boolean",default:true},requireSameSite:{type:"boolean",default:true},acceptableSameSiteValues:{type:"array",items:{type:"string"},default:["strict","lax"]}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,requireHttpOnly:true,requireSecure:true,requireSameSite:true,acceptableSameSiteValues:["strict","lax"]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}return{CallExpression(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="cookie"){const optionsArg=node.arguments[2];if(!optionsArg){context.report({node,messageId:"insecureCookie",data:{issues:"Cookie set without options - missing httpOnly, secure, sameSite flags"},suggest:[{messageId:"addSecureFlags",fix:fixer=>{const lastArg=node.arguments[node.arguments.length-1];return fixer.insertTextAfter(lastArg,', { httpOnly: true, secure: true, sameSite: "strict" }')}}]});return}if(optionsArg.type==="ObjectExpression"){const{issues}=checkCookieOptions(optionsArg,options);if(issues.length>0){context.report({node:optionsArg,messageId:"insecureCookie",data:{issues:issues.join("; ")},suggest:[{messageId:"addSecureFlags",fix:()=>null}]})}}}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noPermissiveCors=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function isPermissiveCorsConfig(node,sourceCode,options){const text=sourceCode.getText(node);if(/\borigin\s*:\s*['"`]\*['"`]/.test(text)){return{isPermissive:true,reason:"origin: '*' allows any domain to access your API"}}if(!options.allowOriginTrue&&/\borigin\s*:\s*true\b/.test(text)){return{isPermissive:true,reason:"origin: true reflects the request origin, allowing any domain"}}
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noPermissiveCors=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function readsBooleanTrue(node,name){return node.properties.some(property=>property.type==="Property"&&!property.computed&&(property.key.type==="Identifier"&&property.key.name===name||property.key.type==="Literal"&&property.key.value===name)&&property.value.type==="Literal"&&property.value.value===true)}function isPermissiveOrigin(node){return node.properties.some(property=>property.type==="Property"&&!property.computed&&(property.key.type==="Identifier"&&property.key.name==="origin"||property.key.type==="Literal"&&property.key.value==="origin")&&property.value.type==="Literal"&&(property.value.value===true||property.value.value==="*"))}function isPermissiveCorsConfig(node,sourceCode,options){const text=sourceCode.getText(node);if(readsBooleanTrue(node,"credentials")&&isPermissiveOrigin(node)){return{isPermissive:false,reason:""}}if(/\borigin\s*:\s*['"`]\*['"`]/.test(text)){return{isPermissive:true,reason:"origin: '*' allows any domain to access your API"}}if(!options.allowOriginTrue&&/\borigin\s*:\s*true\b/.test(text)){return{isPermissive:true,reason:"origin: true reflects the request origin, allowing any domain"}}return{isPermissive:false,reason:""}}function isStandaloneCorsCall(node){const callee=node.callee;if(callee.type==="Identifier"&&callee.name==="cors"){const parent=node.parent;if(parent&&parent.type==="CallExpression"&&parent.callee.type==="MemberExpression"&&parent.callee.property.type==="Identifier"&&parent.callee.property.name==="use"){return false}return true}return false}function isAppUseCors(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="use"){const firstArg=node.arguments[0];if(firstArg&&firstArg.type==="CallExpression"&&firstArg.callee.type==="Identifier"&&firstArg.callee.name==="cors"){return true}}return false}exports.noPermissiveCors=(0,eslint_devkit_1.createRule)({name:"no-permissive-cors",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-permissive-cors.md",description:"Disallow overly permissive CORS configurations (wildcard origin, origin: true)",cwe:"CWE-942",cvss:7.5},hasSuggestions:true,messages:{permissiveCors:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Permissive CORS Configuration",cwe:"CWE-942",description:"{{reason}}",severity:"HIGH",fix:'Specify an explicit whitelist of allowed origins: origin: ["https://trusted-domain.com"]',documentationLink:"https://owasp.org/www-community/attacks/CORS_OriginHeaderScrutiny"}),useWhitelist:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Origin Whitelist",description:"Replace with explicit origin whitelist",severity:"LOW",fix:'origin: ["https://your-frontend.com", "https://app.your-domain.com"]',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow permissive CORS in test files"},allowOriginTrue:{type:"boolean",default:false,description:"Allow origin: true for development"},allowedOrigins:{type:"array",items:{type:"string"},default:[],description:"Allowed origins that should not trigger warnings"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,allowOriginTrue:false,allowedOrigins:[]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,allowOriginTrue=false}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}const sourceCode=context.sourceCode;return{CallExpression(node){if(isStandaloneCorsCall(node)||isAppUseCors(node)){let corsConfigNode=null;if(isStandaloneCorsCall(node)&&node.arguments[0]?.type==="ObjectExpression"){corsConfigNode=node.arguments[0]}else if(isAppUseCors(node)){const corsCall=node.arguments[0];if(corsCall.arguments[0]?.type==="ObjectExpression"){corsConfigNode=corsCall.arguments[0]}}let corsCallNode=null;if(isStandaloneCorsCall(node)){corsCallNode=node}else{corsCallNode=node.arguments[0]}if(corsCallNode&&corsCallNode.arguments.length===0){context.report({node:corsCallNode,messageId:"permissiveCors",data:{reason:"cors() with no options uses permissive defaults"},suggest:[{messageId:"useWhitelist",fix:()=>null}]});return}if(corsConfigNode){const{isPermissive,reason}=isPermissiveCorsConfig(corsConfigNode,sourceCode,{allowOriginTrue});if(isPermissive){context.report({node:corsConfigNode,messageId:"permissiveCors",data:{reason},suggest:[{messageId:"useWhitelist",fix:()=>null}]})}}}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noStaticRootExposure=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_ALLOWED_ROOTS=[
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noStaticRootExposure=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_ALLOWED_ROOTS=[];const JOIN_METHODS=new Set(["join","resolve"]);function quoteLiteral(value){const json=JSON.stringify(value);const inner=json.slice(1,-1);return/['\\]/.test(inner)?json:`'${inner}'`}exports.noStaticRootExposure=(0,eslint_devkit_1.createRule)({name:"no-static-root-exposure",meta:{type:"problem",hasSuggestions:true,docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/no-static-root-exposure.md",description:"Disallow express.static() roots that expose the application directory and any serve-index usage",cwe:"CWE-548",cvss:7.5},messages:{staticRoot:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Application Root Served Statically (CWE-548)",cwe:"CWE-548",description:"express.static() serves {{exposed}} \u2014 the application root. This publishes .env, package-lock.json, .git metadata and the server source itself.",severity:"HIGH",fix:"Serve a dedicated asset directory instead: express.static(path.join(__dirname, 'public')).",documentationLink:"https://cwe.mitre.org/data/definitions/548.html"}),traversalSegments:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Static Root Escapes the Application Directory (CWE-548)",cwe:"CWE-548",description:'The static root contains a ".." segment, so files OUTSIDE the intended directory become publicly reachable.',severity:"HIGH",fix:'Point express.static() at a dedicated asset directory inside the project, with no ".." segments.',documentationLink:"https://cwe.mitre.org/data/definitions/548.html"}),nonLiteralPath:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Dynamic Static-Root Segment (CWE-548)",cwe:"CWE-548",description:"The static root is built from a non-literal segment, so the served directory cannot be verified at lint time and may expose unintended files.",severity:"MEDIUM",fix:"Use a string literal for every path segment: path.join(__dirname, 'public').",documentationLink:"https://cwe.mitre.org/data/definitions/548.html"}),unknownRoot:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Unrecognized Static-Assets Directory (CWE-548)",cwe:"CWE-548",description:'"{{root}}" is not an allowlisted static-assets directory. Serving arbitrary directories risks exposing files that were never meant to be public.',severity:"MEDIUM",fix:"Serve a dedicated asset directory (public/, static/, dist/, build/, assets/) or add the directory to the allowedRoots option.",documentationLink:"https://cwe.mitre.org/data/definitions/548.html"}),directoryListing:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Directory Listing Enabled (CWE-548)",cwe:"CWE-548",description:"serve-index exposes a browsable listing of every file in the served directory, giving attackers a map of the filesystem.",severity:"HIGH",fix:"Remove the serve-index middleware; serve an explicit index file or a curated file list instead.",documentationLink:"https://cwe.mitre.org/data/definitions/548.html"}),scopeToSubdir:"Serve path.join(__dirname, '{{root}}') instead"},schema:[{type:"object",properties:{allowedRoots:{type:"array",items:{type:"string"},description:"Directory names accepted as the first path segment of a static root"}},additionalProperties:false}]},defaultOptions:[{}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowedRoots}=options;const roots=new Set(allowedRoots??DEFAULT_ALLOWED_ROOTS);const suggestionRoot=(allowedRoots??DEFAULT_ALLOWED_ROOTS)[0]??"public";const serveIndexNames=new Set(["serveIndex"]);function isDirnameNode(node){return node.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&node.name==="__dirname"}function isProcessCwdCall(node){if(node.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return false;const callee=node.callee;if(callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return false;if(callee.object.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;if(callee.object.name!=="process")return false;if(callee.property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;return callee.property.name==="cwd"}function isPathJoinCall(node){if(node.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return false;const callee=node.callee;if(callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return false;if(callee.object.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;if(callee.object.name!=="path")return false;if(callee.property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;return JOIN_METHODS.has(callee.property.name)}function isExpressStaticCall(node){const callee=node.callee;if(callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return false;if(callee.property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;if(callee.property.name!=="static")return false;if(callee.object.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;return callee.object.name.toLowerCase()==="express"}function segmentsOf(value){return value.split(/[\\/]+/).filter(seg=>seg!==""&&seg!==".")}function reportRoot(node,exposed){context.report({node,messageId:"staticRoot",data:{exposed},suggest:[{messageId:"scopeToSubdir",data:{root:suggestionRoot},fix:fixer=>fixer.replaceText(node,`path.join(__dirname, ${quoteLiteral(suggestionRoot)})`)}]})}function checkJoinRoot(call){const literalSegments=[];let hasNonLiteral=false;let hasTraversal=false;for(const arg of call.arguments){if(isDirnameNode(arg)||isProcessCwdCall(arg))continue;if(arg.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof arg.value==="string"){const segments=segmentsOf(arg.value);if(segments.includes(".."))hasTraversal=true;literalSegments.push(...segments);continue}hasNonLiteral=true}if(hasTraversal){context.report({node:call,messageId:"traversalSegments"});return}if(hasNonLiteral&&literalSegments.length===0){context.report({node:call,messageId:"nonLiteralPath"});return}if(literalSegments.length===0){reportRoot(call,context.sourceCode.getText(call));return}if(roots.size>0&&!roots.has(literalSegments[0])){context.report({node:call,messageId:"unknownRoot",data:{root:literalSegments[0]}})}}function checkStaticRoot(node){if(isDirnameNode(node)){reportRoot(node,"__dirname");return}if(isProcessCwdCall(node)){reportRoot(node,"process.cwd()");return}if(node.type===eslint_devkit_1.AST_NODE_TYPES.Literal){if(typeof node.value!=="string")return;const segments=segmentsOf(node.value);if(segments.includes("..")){context.report({node,messageId:"traversalSegments"});return}if(segments.length===0){reportRoot(node,`'${node.value}'`);return}if(roots.size>0&&!roots.has(segments[0])){context.report({node,messageId:"unknownRoot",data:{root:segments[0]}})}return}if(isPathJoinCall(node)){checkJoinRoot(node)}}return{ImportDeclaration(node){if(node.source.value!=="serve-index")return;for(const specifier of node.specifiers){serveIndexNames.add(specifier.local.name)}},VariableDeclarator(node){if(node.id.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return;if(!node.init)return;if(node.init.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return;const callee=node.init.callee;if(callee.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return;if(callee.name!=="require")return;const requiredModule=node.init.arguments[0];if(!requiredModule)return;if(requiredModule.type!==eslint_devkit_1.AST_NODE_TYPES.Literal)return;if(requiredModule.value!=="serve-index")return;serveIndexNames.add(node.id.name)},CallExpression(node){const callee=node.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&serveIndexNames.has(callee.name)){context.report({node,messageId:"directoryListing"});return}if(!isExpressStaticCall(node))return;const rootArg=node.arguments[0];if(!rootArg)return;checkStaticRoot(rootArg)}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireCsrfProtection=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_PROTECTED_METHODS=["post","put","patch","delete"];function isCsrfMiddleware(node){const callee=node.callee;if(callee.type==="Identifier"){const name=callee.name.toLowerCase();return name==="csrf"||name==="csurf"||name==="csrfprotection"}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="lusca"&&callee.property.type==="Identifier"&&callee.property.name==="csrf"){return true}return false}function
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireCsrfProtection=void 0;const express_evidence_1=require("../../utils/express-evidence");const app_composition_1=require("../../utils/app-composition");const auth_evidence_1=require("../../utils/auth-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_PROTECTED_METHODS=["post","put","patch","delete"];const EMPTY=new Set;function isCsrfMiddleware(node){const callee=node.callee;if(callee.type==="Identifier"){const name=callee.name.toLowerCase();return name==="csrf"||name==="csurf"||name==="csrfprotection"}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="lusca"&&callee.property.type==="Identifier"&&callee.property.name==="csrf"){return true}return false}function isCsrfReference(node){if(node.type==="Identifier")return/csrf|csurf/i.test(node.name);if(node.type==="MemberExpression"){return isCsrfReference(node.object)||node.property.type==="Identifier"&&isCsrfReference(node.property)}if(node.type==="CallExpression")return isCsrfReference(node.callee);return false}function hasCsrfInMiddlewareChain(chain){return chain.some(isCsrfReference)}const EXPRESS_IDENTIFIERS=new Set(["app","router","api","apiRouter","routes","express"]);function isLikelyExpressObject(callee){const obj=callee.object;if(obj.type==="Identifier"){if(EXPRESS_IDENTIFIERS.has(obj.name)){return true}return false}if(obj.type==="CallExpression"){const objCallee=obj.callee;if(objCallee.type==="Identifier"&&objCallee.name==="express"){return true}if(objCallee.type==="MemberExpression"&&objCallee.object.type==="Identifier"&&objCallee.object.name==="express"&&objCallee.property.type==="Identifier"&&objCallee.property.name==="Router"){return true}}if(obj.type==="MemberExpression"){return false}return false}exports.requireCsrfProtection=(0,eslint_devkit_1.createRule)({name:"require-csrf-protection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-csrf-protection.md",description:"Require CSRF protection middleware for state-changing HTTP methods",cwe:"CWE-352",cvss:8.8},hasSuggestions:true,messages:{missingCsrf:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing CSRF Protection",cwe:"CWE-352",description:"Route handler for {{method}} request lacks CSRF protection. Attackers can forge requests from malicious sites.",severity:"HIGH",fix:"Add CSRF middleware: app.use(csrf()) or use csurf package. Include csrfToken in forms.",documentationLink:"https://owasp.org/www-community/attacks/csrf"}),addCsrf:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add CSRF Protection",description:"Add CSRF middleware to protect state-changing requests",severity:"LOW",fix:"npm install csurf; app.use(csurf({ cookie: true }))",documentationLink:"https://www.npmjs.com/package/csurf"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow missing CSRF in test files"},protectedMethods:{type:"array",items:{type:"string"},default:["post","put","patch","delete"],description:"HTTP methods that require CSRF protection"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Route patterns to ignore"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,protectedMethods:DEFAULT_PROTECTED_METHODS,ignorePatterns:[]}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};if(!(0,app_composition_1.fileHasAmbientCredentials)(context.sourceCode.ast))return{};const{allowInTests=false,protectedMethods=DEFAULT_PROTECTED_METHODS,ignorePatterns=[]}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}let hasGlobalCsrf=false;const candidates=[];let hasGlobalAuth=false;function shouldIgnoreRoute(routeArg){if(routeArg.type!=="Literal"||typeof routeArg.value!=="string"){return false}const route=routeArg.value;return ignorePatterns.some(pattern=>{try{return new RegExp(pattern).test(route)}catch{return route.includes(pattern)}})}return{CallExpression(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="use"){for(const arg of node.arguments){if(arg.type==="CallExpression"&&isCsrfMiddleware(arg)){hasGlobalCsrf=true;return}if(arg.type==="Identifier"){const name=arg.name.toLowerCase();if(name.includes("csrf")||name.includes("csurf")){hasGlobalCsrf=true;return}}}const[first]=node.arguments;const pathScoped=first?.type==="Literal"&&typeof first.value==="string";if(!pathScoped&&(0,auth_evidence_1.routeIsAuthenticated)(node.arguments,void 0,EMPTY)){hasGlobalAuth=true}}if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"){const method=callee.property.name.toLowerCase();if(!protectedMethods.includes(method)){return}if(!isLikelyExpressObject(callee)){return}const[routeArg,...rest]=node.arguments;if(routeArg&&shouldIgnoreRoute(routeArg)){return}if(hasCsrfInMiddlewareChain(rest.slice(0,-1))){return}candidates.push({node,method:method.toUpperCase(),chain:rest.slice(0,-1),handler:rest[rest.length-1]})}},"Program:exit"(){if(hasGlobalCsrf)return;for(const candidate of candidates){if(!hasGlobalAuth&&!(0,auth_evidence_1.routeIsAuthenticated)(candidate.chain,candidate.handler,EMPTY)){continue}context.report({node:candidate.node,messageId:"missingCsrf",data:{method:candidate.method},suggest:[{messageId:"addCsrf",fix:()=>null}]})}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireExpressBodyParserLimits=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_EXCESSIVE_LIMITS=["10mb","50mb","100mb","500mb","1gb","1GB","10MB","50MB","100MB","500MB"];const BODY_PARSER_METHODS=new Set(["json","urlencoded","raw","text"]);function getLimitOption(properties){for(const prop of properties){if(prop.type==="Property"&&prop.key.type==="Identifier"&&prop.key.name==="limit"){return prop}}return null}function isExcessiveLimit(value,excessiveLimits){if(value.type==="Literal"&&typeof value.value==="string"){
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireExpressBodyParserLimits=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_MAX_LIMIT=5*1024*1024;const DEFAULT_EXCESSIVE_LIMITS=["10mb","50mb","100mb","500mb","1gb","1GB","10MB","50MB","100MB","500MB"];const BODY_PARSER_METHODS=new Set(["json","urlencoded","raw","text"]);function getLimitOption(properties){for(const prop of properties){if(prop.type==="Property"&&prop.key.type==="Identifier"&&prop.key.name==="limit"){return prop}}return null}const UNITS={b:1,kb:1024,mb:1024**2,gb:1024**3,tb:1024**4};function limitInBytes(value){if(value.type!=="Literal")return null;if(typeof value.value==="number")return value.value;if(typeof value.value!=="string")return null;const parsed=/^\s*(\d+(?:\.\d+)?)\s*(b|kb|mb|gb|tb)?\s*$/i.exec(value.value);if(!parsed)return null;return Number(parsed[1])*UNITS[(parsed[2]??"b").toLowerCase()]}function isExcessiveLimit(value,excessiveLimits,maxLimit){if(value.type==="Literal"&&typeof value.value==="string"){const named=excessiveLimits.some(limit=>String(value.value).toLowerCase()===limit.toLowerCase());if(named)return true}const bytes=limitInBytes(value);return bytes!==null&&bytes>maxLimit}exports.requireExpressBodyParserLimits=(0,eslint_devkit_1.createRule)({name:"require-express-body-parser-limits",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-express-body-parser-limits.md",description:"Require size limits on Express.js body parsers to prevent DoS attacks",cwe:"CWE-400",cvss:7.5},messages:{excessiveLimit:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Excessive Body Parser Limit",cwe:"CWE-400",description:"This body parser raises the limit above Express's 100kb default, so a single request can pin that much memory per connection.",severity:"MEDIUM",fix:"Reduce the limit to a reasonable size: '100kb' for JSON APIs, '1mb' for file uploads with proper handling",documentationLink:"https://expressjs.com/en/4x/api.html#express.json"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow in test files"},maxLimit:{type:"number",default:DEFAULT_MAX_LIMIT,description:"Largest explicit body-parser limit, in bytes, that is not reported"},excessiveLimits:{type:"array",items:{type:"string"},default:DEFAULT_EXCESSIVE_LIMITS,description:"Limits considered excessive"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,maxLimit:DEFAULT_MAX_LIMIT,excessiveLimits:DEFAULT_EXCESSIVE_LIMITS}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,maxLimit=DEFAULT_MAX_LIMIT,excessiveLimits=DEFAULT_EXCESSIVE_LIMITS}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}return{CallExpression(node){const callee=node.callee;if(callee.type!=="MemberExpression"){return}const object=callee.object;const property=callee.property;if(object.type!=="Identifier"){return}if(object.name!=="express"&&object.name!=="bodyParser"){return}if(property.type!=="Identifier"){return}if(!BODY_PARSER_METHODS.has(property.name)){return}const firstArg=node.arguments[0];if(firstArg?.type!=="ObjectExpression")return;const limitProp=getLimitOption(firstArg.properties);if(!limitProp)return;if(isExcessiveLimit(limitProp.value,excessiveLimits,maxLimit)){context.report({node:limitProp,messageId:"excessiveLimit"})}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireHelmet=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");function isHelmetMiddleware(node){const callee=node.callee;if(callee.type!=="MemberExpression"){return false}if(callee.property.type!=="Identifier"||callee.property.name!=="use"){return false}for(const arg of node.arguments){if(arg.type==="CallExpression"){const argCallee=arg.callee;if(argCallee.type==="Identifier"&&argCallee.name==="helmet"){return true}if(argCallee.type==="MemberExpression"&&argCallee.object.type==="Identifier"&&argCallee.object.name==="helmet"){return true}}if(arg.type==="Identifier"&&arg.name==="helmet"){return true}}return false}function isAlternativeMiddleware(node,alternatives){for(const arg of node.arguments){if(arg.type==="CallExpression"&&arg.callee.type==="Identifier"){if(alternatives.includes(arg.callee.name)){return true}}if(arg.type==="Identifier"&&alternatives.includes(arg.name)){return true}}return false}exports.requireHelmet=(0,eslint_devkit_1.createRule)({name:"require-helmet",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-helmet.md",description:"Require helmet middleware for security headers in Express.js applications",cwe:"CWE-693",cvss:7.5,confidence:"high"},hasSuggestions:true,messages:{missingHelmet:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing Security Headers",cwe:"CWE-693",description:"Express app
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireHelmet=void 0;const express_evidence_1=require("../../utils/express-evidence");const app_composition_1=require("../../utils/app-composition");const eslint_devkit_1=require("@interlace/eslint-devkit");function isHelmetMiddleware(node){const callee=node.callee;if(callee.type!=="MemberExpression"){return false}if(callee.property.type!=="Identifier"||callee.property.name!=="use"){return false}for(const arg of node.arguments){if(arg.type==="CallExpression"){const argCallee=arg.callee;if(argCallee.type==="Identifier"&&argCallee.name==="helmet"){return true}if(argCallee.type==="MemberExpression"&&argCallee.object.type==="Identifier"&&argCallee.object.name==="helmet"){return true}}if(arg.type==="Identifier"&&arg.name==="helmet"){return true}}return false}function isAlternativeMiddleware(node,alternatives){for(const arg of node.arguments){if(arg.type==="CallExpression"&&arg.callee.type==="Identifier"){if(alternatives.includes(arg.callee.name)){return true}}if(arg.type==="Identifier"&&alternatives.includes(arg.name)){return true}}return false}exports.requireHelmet=(0,eslint_devkit_1.createRule)({name:"require-helmet",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-helmet.md",description:"Require helmet middleware for security headers in Express.js applications",cwe:"CWE-693",cvss:7.5,confidence:"high"},hasSuggestions:true,messages:{missingHelmet:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing Security Headers",cwe:"CWE-693",description:"This Express app renders documents to a browser but never mounts helmet. Without it the responses carry no Content-Security-Policy, X-Frame-Options or referrer policy, so any rendered page is framable and unconstrained.",severity:"HIGH",fix:"Add helmet middleware: app.use(helmet()). Install with 'npm install helmet'.",documentationLink:"https://helmetjs.github.io/"}),addHelmet:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Helmet",description:"Add helmet middleware for security headers",severity:"LOW",fix:"import helmet from 'helmet'; app.use(helmet());",documentationLink:"https://helmetjs.github.io/"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow missing helmet in test files"},alternativeMiddleware:{type:"array",items:{type:"string"},default:[],description:"Alternative security headers middleware names to accept"},assumeHelmetMiddleware:{type:"boolean",default:false,description:"Skip rule if security headers are provided elsewhere (e.g., reverse proxy)"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,alternativeMiddleware:[],assumeHelmetMiddleware:false}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};if(!(0,app_composition_1.servesBrowserDocuments)(context.sourceCode.ast))return{};const{allowInTests=false,alternativeMiddleware=[],assumeHelmetMiddleware=false}=options;if(assumeHelmetMiddleware){return{}}const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}let hasExpressApp=false;let hasHelmet=false;let expressAppNode=null;let appBinding=null;let appEscapes=false;return{[app_composition_1.RELEASE_SELECTOR](node){if(appBinding!==null&&(0,app_composition_1.nodeReleasesBinding)(node,appBinding)){appEscapes=true}},CallExpression(node){const callee=node.callee;if(appBinding!==null&&(0,app_composition_1.nodeReleasesBinding)(node,appBinding)){appEscapes=true}if(callee.type==="Identifier"&&callee.name==="express"){hasExpressApp=true;expressAppNode=node;if(node.parent?.type==="VariableDeclarator"&&node.parent.id.type==="Identifier"){appBinding=node.parent.id.name}return}if(callee.type==="CallExpression"&&callee.callee.type==="Identifier"&&callee.callee.name==="require"){const firstArg=callee.arguments[0];if(firstArg&&firstArg.type==="Literal"&&firstArg.value==="express"){hasExpressApp=true;expressAppNode=node;return}}if(isHelmetMiddleware(node)){hasHelmet=true;return}if(isAlternativeMiddleware(node,alternativeMiddleware)){hasHelmet=true;return}},"Program:exit"(){if(hasExpressApp&&!hasHelmet&&!appEscapes&&expressAppNode){context.report({node:expressAppNode,messageId:"missingHelmet",suggest:[{messageId:"addHelmet",fix:()=>null}]})}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireRateLimiting=void 0;const express_evidence_1=require("../../utils/express-evidence");const eslint_devkit_1=require("@interlace/eslint-devkit");const RATE_LIMIT_PACKAGES=["ratelimit","rateLimit","rateLimiter","limiter","expressRateLimit","slowDown","expressBrute"];function isRateLimitMiddleware(node,alternatives){const allPatterns=[...RATE_LIMIT_PACKAGES,...alternatives];for(const arg of node.arguments){if(arg.type==="CallExpression"&&arg.callee.type==="Identifier"){const calleeName=arg.callee.name.toLowerCase();if(allPatterns.some(p=>calleeName.includes(p.toLowerCase()))){return true}}if(arg.type==="Identifier"){if(allPatterns.some(p=>arg.name.toLowerCase().includes(p.toLowerCase()))){return true}}}return false}exports.requireRateLimiting=(0,eslint_devkit_1.createRule)({name:"require-rate-limiting",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-rate-limiting.md",description:"Require rate limiting middleware in Express.js applications",cwe:"CWE-770",cvss:7.5},hasSuggestions:true,messages:{missingRateLimiting:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireRateLimiting=void 0;const express_evidence_1=require("../../utils/express-evidence");const app_composition_1=require("../../utils/app-composition");const eslint_devkit_1=require("@interlace/eslint-devkit");const STATE_CHANGING_METHODS=new Set(["post","put","patch","delete"]);const APP_RECEIVER=/^(app|router|express|api|apiRouter|routes)$/i;const CREDENTIAL_PATH=/(^|[^a-z0-9])(login|log-in|signin|sign-in|signup|sign-up|register|authenticate|auth|authorize|token|password|passwd|credential|otp|mfa|2fa|totp|verify|verification|confirm|reset|forgot|recover|unlock|challenge|session|invite|redeem|coupon|promo)([^a-z0-9]|$)/i;const RATE_LIMIT_PACKAGES=["ratelimit","rateLimit","rateLimiter","limiter","expressRateLimit","slowDown","expressBrute"];function isRateLimitMiddleware(node,alternatives){const allPatterns=[...RATE_LIMIT_PACKAGES,...alternatives];for(const arg of node.arguments){if(arg.type==="CallExpression"&&arg.callee.type==="Identifier"){const calleeName=arg.callee.name.toLowerCase();if(allPatterns.some(p=>calleeName.includes(p.toLowerCase()))){return true}}if(arg.type==="Identifier"){if(allPatterns.some(p=>arg.name.toLowerCase().includes(p.toLowerCase()))){return true}}}return false}exports.requireRateLimiting=(0,eslint_devkit_1.createRule)({name:"require-rate-limiting",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-rate-limiting.md",description:"Require rate limiting middleware in Express.js applications",cwe:"CWE-770",cvss:7.5},hasSuggestions:true,messages:{missingRateLimiting:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Unthrottled Credential Endpoint",cwe:"CWE-770",description:"{{method}} {{path}} accepts a secret to be checked and this app mounts no rate limiter. An attacker can run the guess-and-retry loop at full speed.",severity:"HIGH",fix:"Add rate limiting: npm install express-rate-limit; app.use(rateLimit({ windowMs: 15*60*1000, max: 100 }))",documentationLink:"https://www.npmjs.com/package/express-rate-limit"}),addRateLimiting:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Rate Limiting",description:"Add rate limiting middleware to protect against abuse",severity:"LOW",fix:"import rateLimit from 'express-rate-limit'; app.use(rateLimit({ windowMs: 15*60*1000, max: 100 }));",documentationLink:"https://www.npmjs.com/package/express-rate-limit"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false},alternativeMiddleware:{type:"array",items:{type:"string"},default:[],description:"Extra middleware names that count as rate limiting"},assumeRateLimiting:{type:"boolean",default:false,description:"Skip if rate limiting is provided by infrastructure (API Gateway, nginx, etc.)"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,alternativeMiddleware:[],assumeRateLimiting:false}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{allowInTests=false,alternativeMiddleware=[],assumeRateLimiting=false}=options;if(assumeRateLimiting){return{}}const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);if(isTestFile){return{}}let hasExpressApp=false;let hasRateLimiting=false;let credentialRoute=null;let appBinding=null;let appEscapes=false;return{[app_composition_1.RELEASE_SELECTOR](node){if(appBinding!==null&&(0,app_composition_1.nodeReleasesBinding)(node,appBinding)){appEscapes=true}},CallExpression(node){const callee=node.callee;if(appBinding!==null&&(0,app_composition_1.nodeReleasesBinding)(node,appBinding)){appEscapes=true}if(callee.type==="Identifier"&&callee.name==="express"){hasExpressApp=true;if(node.parent?.type==="VariableDeclarator"&&node.parent.id.type==="Identifier"){appBinding=node.parent.id.name}return}if(callee.type!=="MemberExpression"||callee.property.type!=="Identifier"){return}const method=callee.property.name.toLowerCase();if(isRateLimitMiddleware(node,alternativeMiddleware)){hasRateLimiting=true;return}if(!STATE_CHANGING_METHODS.has(method))return;if(callee.object.type!=="Identifier"||!APP_RECEIVER.test(callee.object.name)){return}const[pathArg,...rest]=node.arguments;if(rest.length===0||pathArg?.type!=="Literal"||typeof pathArg.value!=="string"){return}if(!CREDENTIAL_PATH.test(pathArg.value))return;credentialRoute??={node,method:method.toUpperCase(),path:pathArg.value}},"Program:exit"(){if(hasExpressApp&&!hasRateLimiting&&!appEscapes&&credentialRoute){context.report({node:credentialRoute.node,messageId:"missingRateLimiting",data:{method:credentialRoute.method,path:credentialRoute.path},suggest:[{messageId:"addRateLimiting",fix:()=>null}]})}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireRouteAuthentication=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const utils_1=require("../../utils");const express_evidence_1=require("../../utils/express-evidence");const DEFAULT_CRITICAL_PATHS=["password","credential","secret","apikey","api-key","user","account","profile","role","permission","grant","payment","billing","invoice","charge","refund","transfer","withdraw","order","config","setting","export","import","mfa","2fa","otp","deploy","migrate","backup","restore","internal","private"];const DEFAULT_PUBLIC_PATHS=["login","signin","sign-in","logout","signup","sign-up","register","forgot","reset","confirm","verify","webhook","hook","health","healthz","readyz","livez","ping","status","public","static","assets","favicon","robots","callback","oauth","sso","docs","swagger","openapi"];const ROUTE_METHODS=new Set(["get","post","put","patch","delete","all"]);const APP_RECEIVER=/^(app|router|express|api)$/i;function matchesFragment(path,fragment){const escaped=fragment.replace(/[.*+?^${}()|[\]\\]/g,"\\$&");return new RegExp(`(^|[^a-z0-9])${escaped}s?([^a-z0-9]|$)`).test(path)}const
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireRouteAuthentication=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const utils_1=require("../../utils");const auth_evidence_1=require("../../utils/auth-evidence");const express_evidence_1=require("../../utils/express-evidence");const DEFAULT_CRITICAL_PATHS=["password","credential","secret","apikey","api-key","user","account","profile","role","permission","grant","payment","billing","invoice","charge","refund","transfer","withdraw","order","config","setting","export","import","mfa","2fa","otp","deploy","migrate","backup","restore","internal","private"];const DEFAULT_PUBLIC_PATHS=["login","signin","sign-in","logout","signup","sign-up","register","forgot","reset","confirm","verify","recover","recovery","unlock","challenge","enroll","enrol","enrollment","activate","activation","resend","consent","webhook","hook","health","healthz","readyz","livez","ping","status","public","static","assets","favicon","robots","callback","oauth","sso","docs","swagger","openapi"];const ROUTE_METHODS=new Set(["get","post","put","patch","delete","all"]);const APP_RECEIVER=/^(app|router|express|api)$/i;function matchesFragment(path,fragment){const escaped=fragment.replace(/[.*+?^${}()|[\]\\]/g,"\\$&");return new RegExp(`(^|[^a-z0-9])${escaped}s?([^a-z0-9]|$)`).test(path)}function asFunction(node){return node?.type===eslint_devkit_1.AST_NODE_TYPES.FunctionDeclaration||node?.type===eslint_devkit_1.AST_NODE_TYPES.FunctionExpression||node?.type===eslint_devkit_1.AST_NODE_TYPES.ArrowFunctionExpression?node:void 0}function isDelegatingHandler(fn){let callsNext=false;let touchesResponse=false;(0,utils_1.walk)(fn.body,node=>{if(node.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&node.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&node.callee.name==="next"){callsNext=true;return}if(node.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&node.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&RESPONSE_RECEIVER.test(node.object.name)){touchesResponse=true}});return callsNext&&!touchesResponse}const RESPONSE_RECEIVER=/^(res|response)$/i;exports.requireRouteAuthentication=(0,eslint_devkit_1.createRule)({name:"require-route-authentication",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-express-security/docs/rules/require-route-authentication.md",description:"Require authentication on routes that expose a critical function (account, credential, payment, configuration)",cwe:"CWE-306",cvss:8.2,confidence:"medium"},messages:{missingAuthentication:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Critical Route Without Authentication (CWE-306)",cwe:"CWE-306",cvss:8.2,description:"{{method}} {{path}} exposes a critical function but its chain has no authentication middleware and the handler never reads an authenticated principal. Anyone who can reach the port can call it.",severity:"HIGH",fix:"Mount an authentication middleware on the route \u2014 app.{{method}}('{{path}}', requireAuth, handler) \u2014 or app.use(requireAuth) for the whole router.",documentationLink:"https://cwe.mitre.org/data/definitions/306.html"})},schema:[{type:"object",properties:{criticalPaths:{type:"array",items:{type:"string"},description:"Path fragments that mark a route as critical"},publicPaths:{type:"array",items:{type:"string"},description:"Path fragments that are public by design"},authMiddleware:{type:"array",items:{type:"string"},description:"Extra middleware names accepted as authentication"}},additionalProperties:false}]},defaultOptions:[{}],create(context,[options]){if(!(0,express_evidence_1.fileUsesExpress)(context.sourceCode.ast))return{};const{criticalPaths,publicPaths,authMiddleware}=options;const critical=(criticalPaths??DEFAULT_CRITICAL_PATHS).map(p=>p.toLowerCase());const publics=(publicPaths??DEFAULT_PUBLIC_PATHS).map(p=>p.toLowerCase());const extraAuth=new Set(authMiddleware??[]);const topLevelFunctions=new Map;for(const stmt of context.sourceCode.ast.body){if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.FunctionDeclaration&&stmt.id){topLevelFunctions.set(stmt.id.name,stmt);continue}if(stmt.type!==eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration)continue;for(const decl of stmt.declarations){if(decl.id.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init){topLevelFunctions.set(decl.id.name,decl.init)}}}const candidates=[];let hasGlobalAuth=false;function routeMethodOf(node){const callee=node.callee;if(callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return null;if(callee.property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return null;if(callee.computed)return null;if(callee.object.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return null;if(!APP_RECEIVER.test(callee.object.name))return null;return callee.property.name}return{CallExpression(node){const method=routeMethodOf(node);if(!method)return;if(method==="use"){const[first]=node.arguments;const pathScoped=first?.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof first.value==="string";if(!pathScoped){for(const arg of node.arguments){if(arg.type!==eslint_devkit_1.AST_NODE_TYPES.Literal&&(0,auth_evidence_1.isAuthMiddlewareArg)(arg,extraAuth)){hasGlobalAuth=true}}}return}if(!ROUTE_METHODS.has(method))return;const[pathArg,...rest]=node.arguments;if(!pathArg||pathArg.type!==eslint_devkit_1.AST_NODE_TYPES.Literal||typeof pathArg.value!=="string"){return}if(rest.length===0)return;const path=pathArg.value.toLowerCase();if(publics.some(fragment=>matchesFragment(path,fragment)))return;if(!critical.some(fragment=>matchesFragment(path,fragment)))return;const handler=rest[rest.length-1];if((0,auth_evidence_1.routeIsAuthenticated)(rest.slice(0,-1),handler,extraAuth)){return}const fn=asFunction(handler)??(handler.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?asFunction(topLevelFunctions.get(handler.name)):void 0);if(fn&&isDelegatingHandler(fn))return;candidates.push({node:pathArg,method,path:pathArg.value})},"Program:exit"(){if(hasGlobalAuth)return;for(const candidate of candidates){context.report({node:candidate.node,messageId:"missingAuthentication",data:{method:candidate.method,path:candidate.path}})}}}}});
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.RELEASE_SELECTOR=void 0;exports.nodeReleasesBinding=nodeReleasesBinding;exports.fileHasAmbientCredentials=fileHasAmbientCredentials;exports.servesBrowserDocuments=servesBrowserDocuments;const eslint_devkit_1=require("@interlace/eslint-devkit");const index_1=require("./index");function nodeReleasesBinding(node,binding){const isBinding=n=>n?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&n.name===binding;switch(node.type){case eslint_devkit_1.AST_NODE_TYPES.CallExpression:return node.arguments.some(isBinding);case eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression:return isBinding(node.right);case eslint_devkit_1.AST_NODE_TYPES.ExportDefaultDeclaration:return isBinding(node.declaration);default:return isBinding(node.argument)}}exports.RELEASE_SELECTOR="AssignmentExpression, ExportDefaultDeclaration, ReturnStatement";const CREDENTIAL_PACKAGES=new Set(["cookie-parser","express-session","cookie-session","client-sessions","csurf","csrf","lusca","passport"]);const CREDENTIAL_MEMBERS=new Set(["session","cookies","signedCookies","cookie","clearCookie"]);const CREDENTIAL_RECEIVER=/^(req|request|res|response)$/i;function specifierRoot(specifier){const parts=specifier.split("/");return specifier.startsWith("@")?parts.slice(0,2).join("/"):parts[0]}function isCredentialModuleLoad(node){if(node.type===eslint_devkit_1.AST_NODE_TYPES.ImportDeclaration&&typeof node.source.value==="string"){return CREDENTIAL_PACKAGES.has(specifierRoot(node.source.value))}if(node.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&node.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&node.callee.name==="require"){const[arg]=node.arguments;return arg?.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof arg.value==="string"&&CREDENTIAL_PACKAGES.has(specifierRoot(arg.value))}return false}function isCredentialMember(node){if(node.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return false;if(node.computed||node.property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}if(!CREDENTIAL_MEMBERS.has(node.property.name))return false;return node.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&CREDENTIAL_RECEIVER.test(node.object.name)}function fileHasAmbientCredentials(ast){let found=false;(0,index_1.walk)(ast,node=>{if(found)return;if(isCredentialModuleLoad(node)||isCredentialMember(node))found=true});return found}const DOCUMENT_RESPONDERS=new Set(["render","sendFile"]);function servesBrowserDocuments(ast){let found=false;(0,index_1.walk)(ast,node=>{if(found)return;if(node.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return;const callee=node.callee;if(callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return;if(callee.property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return;const name=callee.property.name;if(DOCUMENT_RESPONDERS.has(name)||name==="engine"){found=true;return}if(name!=="set")return;const[key]=node.arguments;found=key?.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof key.value==="string"&&key.value.toLowerCase().startsWith("view ")});return found}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.AUTH_MIDDLEWARE=void 0;exports.isAuthMiddlewareArg=isAuthMiddlewareArg;exports.routeIsAuthenticated=routeIsAuthenticated;const eslint_devkit_1=require("@interlace/eslint-devkit");const index_1=require("./index");exports.AUTH_MIDDLEWARE=/auth|jwt|passport|token|session|guard|protect|ensure|require|permit|acl|rbac|verify|login|identity|principal/i;function referenceNames(node){switch(node.type){case eslint_devkit_1.AST_NODE_TYPES.Identifier:return[node.name];case eslint_devkit_1.AST_NODE_TYPES.MemberExpression:return[...referenceNames(node.object),...node.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?[node.property.name]:[]];case eslint_devkit_1.AST_NODE_TYPES.CallExpression:return referenceNames(node.callee);default:return[]}}const CREDENTIAL_STORES=new Set(["session","expresssession","cookiesession","clientsessions","cookieparser"]);function isAuthMiddlewareArg(arg,extra){if(arg.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&arg.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&arg.callee.name==="require"){return false}const names=referenceNames(arg);if(names.length===1&&CREDENTIAL_STORES.has(names[0].toLowerCase())){return false}if(names.some(name=>exports.AUTH_MIDDLEWARE.test(name)))return true;return names.some(name=>[...extra].some(wanted=>name.includes(wanted)))}function routeIsAuthenticated(chain,handler,extra){if(chain.some(arg=>isAuthMiddlewareArg(arg,extra)))return true;return handler!==void 0&&(0,index_1.readsPrincipal)(handler)}
|