eslint-plugin-cypress 5.0.1 → 5.1.1

package/CONTRIBUTING.md

@@ -4,45 +4,47 @@ Thanks for taking the time to contribute! :smile:
 
 ## Preparation
 
-* Fork and clone this repository
-* Branch from the default `master` branch using a descriptive new branch name
-* Install dependencies with `npm ci`
+- Fork and clone this repository
+- Branch from the default `master` branch using a descriptive new branch name
+- Install dependencies with `npm ci`
 
 ## Rule references
 
-* Refer to the [ESLint documentation](https://eslint.org/docs/latest/) and the [Custom Rules](https://eslint.org/docs/latest/extend/custom-rules) page
+- Refer to the [ESLint documentation](https://eslint.org/docs/latest/) and the [Custom Rules](https://eslint.org/docs/latest/extend/custom-rules) page
 
 ## New rule
 
 To add a new rule:
 
-* Follow the instructions in the ESLint [generator-eslint](https://www.npmjs.com/package/generator-eslint) documentation to install [Yeoman](https://www.npmjs.com/package/yo) and the generator
-* Run the new rule generator `yo eslint:rule` and answer the questions
+- Follow the instructions in the ESLint [generator-eslint](https://www.npmjs.com/package/generator-eslint) documentation to install [Yeoman](https://www.npmjs.com/package/yo) and the generator
+- Run the new rule generator `yo eslint:rule` and answer the questions
   - select "ESLint Plugin"
   - for "Type a short description of this rule" provide text which starts with one of "enforce", "require" or "disallow" (all lower case)
-* Yeoman creates three boilerplate files:
+- Yeoman creates three boilerplate files:
   - `docs/rules/<rule-id>.md`
   - `lib/rules/<rule-id>.js`
   - `test/rules/<rule-id>.js`
-* Run `npm run lint-fix`
-* Address the linting errors by editing `lib/rules/<rule-id>.js`
+- Run `npm run lint-fix`
+- Address the linting errors by editing `lib/rules/<rule-id>.js`
   - Add a `meta.messages` property (see [MessageIds](https://eslint.org/docs/latest/extend/custom-rules#messageids))
   - Select the appropriate `meta.type` property using `problem`, `suggestion`, or `layout`
-* Complete the new rule by adding content to the three files previously created
-* Run `eslint-doc-generator` to generate automated documentation sections (see [Document generation](#document-generation) below)
-* Review documentation changes
-* Run `npm run lint`
-* Run `npm test` to run [Vitest](https://vitest.dev/)
-* Make sure all tests are passing
-* Add the rule to [flat.js](https://github.com/cypress-io/eslint-plugin-cypress/blob/master/lib/flat.js)
-* Create a git commit with a commit message similar to: `feat: add rule <description>` (see [commit message conventions](https://github.com/semantic-release/semantic-release#commit-message-format))
-* Create a PR from your branch
+- Complete the new rule by adding content to the three files previously created
+- Run `eslint-doc-generator` to generate automated documentation sections (see [Document generation](#document-generation) below)
+- Review documentation changes
+- Run `npm run lint`
+- Run `npm run format`
+- Run `npm test` to run [Vitest](https://vitest.dev/)
+- Make sure all tests are passing
+- Add the rule to [flat.js](https://github.com/cypress-io/eslint-plugin-cypress/blob/master/lib/flat.js)
+- Create a git commit with a commit message similar to: `feat: add rule <description>` (see [commit message conventions](https://github.com/semantic-release/semantic-release#commit-message-format))
+- Create a PR from your branch
 
 ## Document generation
 
 This plugin uses the ESLint [eslint-doc-generator](https://www.npmjs.com/package/eslint-doc-generator) to generate consistent documentation.
-* Install with `npm install eslint-doc-generator -g`
-* Run `eslint-doc-generator` in the root directory of the plugin
+
+- Install with `npm install eslint-doc-generator -g`
+- Run `eslint-doc-generator` in the root directory of the plugin
 
 ## Merging pull requests
 
@@ -65,7 +67,7 @@ This information is for Cypress.io Members or Collaborators who merge pull reque
    ```
 
 1. New versions of this module will be released automatically by the CI pipeline when any PR with a triggering commit message is merged to the `master` branch: see the `release` job of [circle.yml](circle.yml).
-This will create a new [GitHub release](https://github.com/cypress-io/eslint-plugin-cypress/releases) and publish it to [eslint-plugin-cypress](https://www.npmjs.com/package/eslint-plugin-cypress) on the [npm registry](https://docs.npmjs.com/about-the-public-npm-registry).
+   This will create a new [GitHub release](https://github.com/cypress-io/eslint-plugin-cypress/releases) and publish it to [eslint-plugin-cypress](https://www.npmjs.com/package/eslint-plugin-cypress) on the [npm registry](https://docs.npmjs.com/about-the-public-npm-registry).
 1. The module's CI is configured to use the [default Angular release rules](https://github.com/semantic-release/commit-analyzer/blob/master/lib/default-release-rules.js).
-This means that only `feat:`, `fix:` and `perf:` trigger a new release.
-Other Angular commit types listed in the [Angular commit message guidelines](https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md) can be used for documentation purposes, however they are ignored by the currently configured release process.
+   This means that only `feat:`, `fix:` and `perf:` trigger a new release.
+   Other Angular commit types listed in the [Angular commit message guidelines](https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md) can be used for documentation purposes, however they are ignored by the currently configured release process.

package/README.md

@@ -11,7 +11,9 @@ Prerequisites: [ESLint](https://www.npmjs.com/package/eslint) `v9`. Lower versio
 ```sh
 npm install eslint eslint-plugin-cypress --save-dev
 ```
+
 or
+
 ```sh
 yarn add eslint eslint-plugin-cypress --dev
 ```
@@ -36,15 +38,16 @@ import pluginCypress from 'eslint-plugin-cypress/flat' # deprecated
 
 There are two specific configurations available:
 
-| Configuration         | Content                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   |
-| --------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| Configuration         | Content                                                                                                                                                                                                                                                     |
+| --------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | `configs.globals`     | defines globals `cy`, `Cypress`, `expect`, `assert` and `chai` used in Cypress test specs as well as `globals.browser` and `globals.mocha` from [globals](https://www.npmjs.com/package/globals). There are no default rules enabled in this configuration. |
-| `configs.recommended` | enables [recommended Rules](#rules). It includes also `configs.global` (see above).                                                                                                                                                                                                                                                                                                                                                                                               |
+| `configs.recommended` | enables [recommended Rules](#rules). It includes also `configs.global` (see above).                                                                                                                                                                         |
 
 ## Rules
 
 These rules enforce some of the [best practices recommended for using Cypress](https://on.cypress.io/best-practices).
 
+<!-- prettier-ignore-start -->
 <!-- begin auto-generated rules list -->
 
 💼 Configurations enabled in.\
@@ -66,6 +69,7 @@ These rules enforce some of the [best practices recommended for using Cypress](h
 | [unsafe-to-chain-command](docs/rules/unsafe-to-chain-command.md)         | disallow actions within chains                             | ✅  |
 
 <!-- end auto-generated rules list -->
+<!-- prettier-ignore-end -->
 
 ## Usage examples
 
@@ -74,6 +78,7 @@ In the following sections, different examples of possible configuration file con
 ### Cypress
 
 All rules are available by importing from `eslint-plugin-cypress` and can be individually activated.
+
 - [cypress/unsafe-to-chain-command](https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules/unsafe-to-chain-command.md) is activated and set to `error`
 
 ```js
@@ -81,18 +86,19 @@ import pluginCypress from 'eslint-plugin-cypress'
 export default [
   {
     plugins: {
-      cypress: pluginCypress
+      cypress: pluginCypress,
     },
     rules: {
-      'cypress/unsafe-to-chain-command': 'error'
-    }
-  }
+      'cypress/unsafe-to-chain-command': 'error',
+    },
+  },
 ]
 ```
 
 ### Cypress recommended
 
 The `eslint-plugin-cypress` [recommended rules](#rules) `configs.recommended` are activated, except for
+
 - [cypress/no-unnecessary-waiting](https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules/no-unnecessary-waiting.md) which is set to `off`
 
 ```js
@@ -101,9 +107,9 @@ export default [
   pluginCypress.configs.recommended,
   {
     rules: {
-      'cypress/no-unnecessary-waiting': 'off'
-    }
-  }
+      'cypress/no-unnecessary-waiting': 'off',
+    },
+  },
 ]
 ```
 
@@ -113,9 +119,7 @@ The `configs.globals` are activated.
 
 ```js
 import pluginCypress from 'eslint-plugin-cypress'
-export default [
-  pluginCypress.configs.globals
-]
+export default [pluginCypress.configs.globals]
 ```
 
 ## Disable rules
@@ -174,6 +178,7 @@ During test spec development, [Mocha exclusive tests](https://mochajs.org/#exclu
 [eslint-plugin-mocha@^11](https://www.npmjs.com/package/eslint-plugin-mocha) is added to the example [Cypress recommended](#cypress-recommended). This version of the plugin supports only flat file configurations with the option `configs.recommended`.
 
 The settings for individual `mocha` rules from the `configs.recommended` option are changed.
+
 - [mocha/no-exclusive-tests](https://github.com/lo1tuma/eslint-plugin-mocha/blob/main/docs/rules/no-exclusive-tests.md) and [mocha/no-pending-tests](https://github.com/lo1tuma/eslint-plugin-mocha/blob/main/docs/rules/no-pending-tests.md) are set to `error` instead of `warn`
 - [mocha/no-mocha-arrows](https://github.com/lo1tuma/eslint-plugin-mocha/blob/main/docs/rules/no-mocha-arrows.md) is set to `off` instead of `error`
 
@@ -192,9 +197,9 @@ export default [
       'mocha/no-exclusive-tests': 'error',
       'mocha/no-pending-tests': 'error',
       'mocha/no-mocha-arrows': 'off',
-      'cypress/no-unnecessary-waiting': 'off'
-    }
-  }
+      'cypress/no-unnecessary-waiting': 'off',
+    },
+  },
 ]
 ```
 
@@ -220,7 +225,7 @@ export default [
     rules: {
       'cypress/no-unnecessary-waiting': 'off',
     },
-  }
+  },
 ]
 ```
 

package/docs/rules/assertion-before-screenshot.md

@@ -1,6 +1,7 @@
 # Require screenshots to be preceded by an assertion (`cypress/assertion-before-screenshot`)
 
 <!-- end auto-generated rule header -->
+
 If you take screenshots without assertions then you may get different screenshots depending on timing.
 
 For example, if clicking a button makes some network calls and upon success, renders something, then the screenshot may sometimes have the new render and sometimes not.
@@ -12,14 +13,14 @@ This rule checks there is an assertion making sure your application state is cor
 Examples of **incorrect** code for this rule:
 
 ```js
-cy.visit('myUrl');
-cy.screenshot();
+cy.visit('myUrl')
+cy.screenshot()
 ```
 
 Examples of **correct** code for this rule:
 
 ```js
-cy.visit('myUrl');
-cy.get('[data-test-id="my-element"]').should('be.visible');
-cy.screenshot();
+cy.visit('myUrl')
+cy.get('[data-test-id="my-element"]').should('be.visible')
+cy.screenshot()
 ```

package/docs/rules/no-assigning-return-values.md

@@ -3,6 +3,7 @@
 💼 This rule is enabled in the ✅ `recommended` config.
 
 <!-- end auto-generated rule header -->
+
 ## Further Reading
 
 See [the Cypress Best Practices guide](https://on.cypress.io/best-practices#Assigning-Return-Values).

package/docs/rules/no-async-before.md

@@ -1,6 +1,7 @@
 # Disallow using `async`/`await` in Cypress `before` methods (`cypress/no-async-before`)
 
 <!-- end auto-generated rule header -->
+
 Cypress commands that return a promise may cause side effects in `before`/`beforeEach` hooks, possibly causing unexpected behavior.
 
 ## Rule Details
@@ -11,7 +12,7 @@ Examples of **incorrect** code for this rule:
 
 ```js
 describe('my feature', () => {
-  before('my test case', async ()  => {
+  before('my test case', async () => {
     await cy.get('.myClass')
     // other operations
   })
@@ -20,10 +21,8 @@ describe('my feature', () => {
 
 ```js
 describe('my feature', () => {
-  before('my test case', async ()  => {
-    cy
-    .get('.myClass')
-    .click()
+  before('my test case', async () => {
+    cy.get('.myClass').click()
 
     await someAsyncFunction()
   })
@@ -34,7 +33,7 @@ Examples of **correct** code for this rule:
 
 ```js
 describe('my feature', () => {
-  before('my test case', ()  => {
+  before('my test case', () => {
     cy.get('.myClass')
     // other operations
   })
@@ -47,5 +46,5 @@ If there are genuine use-cases for using `async/await` in your `before` hooks th
 
 ## Further Reading
 
-- [Mixing Async and Sync code](https://on.cypress.io/guides/core-concepts/introduction-to-cypress#Mixing-Async-and-Sync-code)
-- [Commands Are Asynchronous](https://on.cypress.io/guides/core-concepts/introduction-to-cypress.html#Commands-Are-Asynchronous)
+- [Mixing Async and Sync code](https://on.cypress.io/app/core-concepts/introduction-to-cypress#Mixing-Async-and-Sync-code)
+- [Commands Are Asynchronous](https://on.cypress.io/app/core-concepts/introduction-to-cypress.html#Commands-Are-Asynchronous)

package/docs/rules/no-async-tests.md

@@ -3,7 +3,8 @@
 💼 This rule is enabled in the ✅ `recommended` config.
 
 <!-- end auto-generated rule header -->
-Cypress tests [that return a promise will error](https://docs.cypress.io/guides/references/error-messages.html#Cypress-detected-that-you-returned-a-promise-from-a-command-while-also-invoking-one-or-more-cy-commands-in-that-promise) and cannot run successfully.
+
+Cypress tests [that return a promise will error](https://docs.cypress.io/app/references/error-messages.html#Cypress-detected-that-you-returned-a-promise-from-a-command-while-also-invoking-one-or-more-cy-commands-in-that-promise) and cannot run successfully.
 An `async` function returns a promise under the hood, so a test using an `async` function will also error.
 
 ## Rule Details
@@ -14,7 +15,7 @@ Examples of **incorrect** code for this rule:
 
 ```js
 describe('my feature', () => {
-  it('my test case', async ()  => {
+  it('my test case', async () => {
     await cy.get('.myClass')
     // other operations
   })
@@ -23,10 +24,8 @@ describe('my feature', () => {
 
 ```js
 describe('my feature', () => {
-  it('my test case', async ()  => {
-    cy
-    .get('.myClass')
-    .click()
+  it('my test case', async () => {
+    cy.get('.myClass').click()
 
     await someAsyncFunction()
   })
@@ -37,7 +36,7 @@ Examples of **correct** code for this rule:
 
 ```js
 describe('my feature', () => {
-  it('my test case', ()  => {
+  it('my test case', () => {
     cy.get('.myClass')
     // other operations
   })
@@ -50,5 +49,5 @@ If there are genuine use-cases for using `async/await` in your test cases then y
 
 ## Further Reading
 
-- [Mixing Async and Sync code](https://on.cypress.io/guides/core-concepts/introduction-to-cypress#Mixing-Async-and-Sync-code)
-- [Commands Are Asynchronous](https://on.cypress.io/guides/core-concepts/introduction-to-cypress.html#Commands-Are-Asynchronous)
+- [Mixing Async and Sync code](https://on.cypress.io/app/core-concepts/introduction-to-cypress#Mixing-Async-and-Sync-code)
+- [Commands Are Asynchronous](https://on.cypress.io/app/core-concepts/introduction-to-cypress.html#Commands-Are-Asynchronous)

package/docs/rules/no-chained-get.md

@@ -1,6 +1,7 @@
 # Disallow chain of `cy.get()` calls (`cypress/no-chained-get`)
 
 <!-- end auto-generated rule header -->
+
 This rule disallows the usage of chained `.get()` calls as `cy.get()` always starts its search from the cy.root element.
 
 ## Rule Details
@@ -14,6 +15,5 @@ cy.get('parent').get('child')
 Examples of **correct** code for this rule:
 
 ```js
-cy.get('parent')
-  .find('child')
+cy.get('parent').find('child')
 ```

package/docs/rules/no-debug.md

@@ -1,6 +1,7 @@
 # Disallow using `cy.debug()` calls (`cypress/no-debug`)
 
 <!-- end auto-generated rule header -->
+
 It is recommended to remove any [cy.debug](https://on.cypress.io/debug) commands before committing specs to avoid other developers getting unexpected results.
 
 ## Rule Details
@@ -8,8 +9,8 @@ It is recommended to remove any [cy.debug](https://on.cypress.io/debug) commands
 Examples of **incorrect** code for this rule:
 
 ```js
-cy.debug();
-cy.get('selector').debug();
+cy.debug()
+cy.get('selector').debug()
 ```
 
 Examples of **correct** code for this rule:

package/docs/rules/no-force.md

@@ -1,9 +1,10 @@
 # Disallow using `force: true` with action commands (`cypress/no-force`)
 
 <!-- end auto-generated rule header -->
+
 Using `force: true` on inputs appears to be confusing rather than helpful.
 It usually silences the actual problem instead of providing a way to overcome it.
-See [Cypress Core Concepts](https://docs.cypress.io/guides/core-concepts/interacting-with-elements.html#Forcing).
+See [Cypress Core Concepts](https://docs.cypress.io/app/core-concepts/interacting-with-elements.html#Forcing).
 
 If enabling this rule, it's recommended to set the severity to `warn`.
 
@@ -18,26 +19,26 @@ and [`.trigger()`](https://on.cypress.io/trigger).
 Examples of **incorrect** code for this rule:
 
 ```js
-cy.get('button').click({force: true})
-cy.get('button').dblclick({force: true})
-cy.get('input').type('somth', {force: true})
-cy.get('div').find('.foo').find('.bar').trigger('change', {force: true})
-cy.get('input').trigger('click', {force: true})
-cy.get('input').rightclick({force: true})
-cy.get('input').check({force: true})
-cy.get('input').select({force: true})
-cy.get('input').focus({force: true})
+cy.get('button').click({ force: true })
+cy.get('button').dblclick({ force: true })
+cy.get('input').type('somth', { force: true })
+cy.get('div').find('.foo').find('.bar').trigger('change', { force: true })
+cy.get('input').trigger('click', { force: true })
+cy.get('input').rightclick({ force: true })
+cy.get('input').check({ force: true })
+cy.get('input').select({ force: true })
+cy.get('input').focus({ force: true })
 ```
 
 Examples of **correct** code for this rule:
 
 ```js
 cy.get('button').click()
-cy.get('button').click({multiple: true})
+cy.get('button').click({ multiple: true })
 cy.get('button').dblclick()
 cy.get('input').type('somth')
-cy.get('input').trigger('click', {anyoption: true})
-cy.get('input').rightclick({anyoption: true})
+cy.get('input').trigger('click', { anyoption: true })
+cy.get('input').rightclick({ anyoption: true })
 cy.get('input').check()
 cy.get('input').select()
 cy.get('input').focus()

package/docs/rules/no-pause.md

@@ -1,6 +1,7 @@
 # Disallow using `cy.pause()` calls (`cypress/no-pause`)
 
 <!-- end auto-generated rule header -->
+
 It is recommended to remove any [cy.pause](https://on.cypress.io/pause) commands before committing specs to avoid other developers getting unexpected results.
 
 ## Rule Details
@@ -8,8 +9,8 @@ It is recommended to remove any [cy.pause](https://on.cypress.io/pause) commands
 Examples of **incorrect** code for this rule:
 
 ```js
-cy.pause();
-cy.get('selector').pause();
+cy.pause()
+cy.get('selector').pause()
 ```
 
 Examples of **correct** code for this rule:

package/docs/rules/no-unnecessary-waiting.md

@@ -3,6 +3,7 @@
 💼 This rule is enabled in the ✅ `recommended` config.
 
 <!-- end auto-generated rule header -->
+
 ## Further Reading
 
 See [the Cypress Best Practices guide](https://on.cypress.io/best-practices#Unnecessary-Waiting).

package/docs/rules/no-xpath.md

@@ -15,11 +15,11 @@ cy.xpath('//div[@class=\"container\"]').click()
 Examples of **correct** code for this rule:
 
 ```js
-cy.get('[data-cy="container"]').click();
+cy.get('[data-cy="container"]').click()
 ```
 
 ## Further Reading
 
 Both `@cypress/xpath` and `cypress-xpath` are deprecated.
 
-See [the Cypress Best Practices guide](https://docs.cypress.io/guides/references/best-practices.html#Selecting-Elements).
+See [the Cypress Best Practices guide](https://docs.cypress.io/app/core-concepts/best-practices.html#Selecting-Elements).

package/docs/rules/require-data-selectors.md

@@ -1,6 +1,7 @@
 # Require `data-*` attribute selectors (`cypress/require-data-selectors`)
 
 <!-- end auto-generated rule header -->
+
 Require `cy.get` to use only selectors that target `data-*` attributes.
 
 > Note: If you use this rule, consider only using the `warn` error level, since using `data-*` attribute selectors may not always be possible.
@@ -10,11 +11,14 @@ Require `cy.get` to use only selectors that target `data-*` attributes.
 Examples of **incorrect** code for this rule:
 
 ```js
-cy.get(".a")
+cy.get('.a')
 cy.get('[daedta-cy=submit]').click()
 cy.get('[d-cy=submit]')
-cy.get(".btn-large").click()
-cy.get(".btn-.large").click()
+cy.get('.btn-large').click()
+cy.get('.btn-.large').click()
+
+const CLASS_SELECTOR = ".my-class"; 
+cy.get(CLASS_SELECTOR)
 ```
 
 Examples of **correct** code for this rule:
@@ -22,8 +26,14 @@ Examples of **correct** code for this rule:
 ```js
 cy.get('[data-cy=submit]').click()
 cy.get('[data-QA=submit]')
+cy.get(`[data-QA=submit]`)
+```
+
+```js
+const ASSESSMENT_SUBMIT = "[data-cy=assessment-submit]"
+cy.get(ASSESSMENT_SUBMIT).click()
 ```
 
 ## Further Reading
 
-See [the Cypress Best Practices guide](https://docs.cypress.io/guides/references/best-practices.html#Selecting-Elements).
+See [the Cypress Best Practices guide](https://docs.cypress.io/app/core-concepts/best-practices.html#Selecting-Elements).

package/docs/rules/unsafe-to-chain-command.md

@@ -3,6 +3,7 @@
 💼 This rule is enabled in the ✅ `recommended` config.
 
 <!-- end auto-generated rule header -->
+
 ### Options
 
 <!-- begin auto-generated rule options list -->
@@ -15,4 +16,4 @@
 
 ## Further Reading
 
-See [retry-ability guide](https://docs.cypress.io/guides/core-concepts/retry-ability#Actions-should-be-at-the-end-of-chains-not-the-middle).
+See [retry-ability guide](https://docs.cypress.io/app/core-concepts/retry-ability#Actions-should-be-at-the-end-of-chains-not-the-middle).

package/lib/rules/require-data-selectors.js

@@ -1,5 +1,4 @@
 'use strict'
-
 module.exports = {
   meta: {
     type: 'suggestion',
@@ -16,9 +15,29 @@ module.exports = {
   },
 
   create(context) {
+    const variablesSet = new Set()
     return {
+      VariableDeclarator(node) {
+        if (node.init && node.id && node.id.type === 'Identifier') {
+          let selectorValue = null
+
+          if (node.init.type === 'Literal' && typeof node.init.value === 'string') {
+            selectorValue = node.init.value
+          }
+          else if (node.init.type === 'TemplateLiteral'
+            && node.init.expressions.length === 0
+            && node.init.quasis.length === 1) {
+            selectorValue = node.init.quasis[0].value.cooked
+          }
+
+          if (selectorValue && isAliasOrDataSelector(selectorValue)) {
+            variablesSet.add(node.id.name)
+          }
+        }
+      },
+
       CallExpression(node) {
-        if (isCallingCyGet(node) && !isDataArgument(node)) {
+        if (isCallingCyGet(node) && !isDataArgument(node, variablesSet)) {
           context.report({ node, messageId: 'unexpected' })
         }
       },
@@ -34,12 +53,24 @@ function isCallingCyGet(node) {
     && node.callee.property.name === 'get'
 }
 
-function isDataArgument(node) {
-  return node.arguments.length > 0
-    && (
-      (node.arguments[0].type === 'Literal' && isAliasOrDataSelector(String(node.arguments[0].value)))
-      || (node.arguments[0].type === 'TemplateLiteral' && isAliasOrDataSelector(String(node.arguments[0].quasis[0].value.cooked)))
-    )
+function isDataArgument(node, dataVariables) {
+  if (node.arguments.length === 0) return false
+
+  const firstArg = node.arguments[0]
+
+  if (firstArg.type === 'Literal') {
+    return isAliasOrDataSelector(String(firstArg.value))
+  }
+
+  if (firstArg.type === 'TemplateLiteral') {
+    return isAliasOrDataSelector(String(firstArg.quasis[0].value.cooked))
+  }
+
+  if (firstArg.type === 'Identifier') {
+    return dataVariables.has(firstArg.name)
+  }
+
+  return false
 }
 
 function isAliasOrDataSelector(selector) {

package/lib/rules/unsafe-to-chain-command.js

@@ -7,7 +7,7 @@ const DESCRIPTION = 'disallow actions within chains'
 
 /**
  * Commands listed in the documentation with text: 'It is unsafe to chain further commands that rely on the subject after xxx.'
- * See {@link https://docs.cypress.io/guides/core-concepts/retry-ability#Actions-should-be-at-the-end-of-chains-not-the-middle Actions should be at the end of chains, not the middle}
+ * See {@link https://docs.cypress.io/app/core-concepts/retry-ability#Actions-should-be-at-the-end-of-chains-not-the-middle Actions should be at the end of chains, not the middle}
  * for more information.
  *
  * @type {string[]}

package/package.json

@@ -1,12 +1,17 @@
 {
   "name": "eslint-plugin-cypress",
-  "version": "5.0.1",
+  "version": "5.1.1",
   "description": "An ESLint plugin for projects using Cypress",
   "main": "./lib/flat.js",
   "exports": {
     ".": "./lib/flat.js",
     "./flat": "./lib/flat.js"
   },
+  "files": [
+    "lib",
+    "docs",
+    "CONTRIBUTING.md"
+  ],
   "author": "Cypress-io",
   "license": "MIT",
   "keywords": [
@@ -34,12 +39,15 @@
     "eslint-plugin-eslint-plugin": "^6.4.0",
     "eslint-plugin-mocha": "^11.1.0",
     "husky": "^9.1.7",
+    "prettier": "^3.5.3",
     "semantic-release": "24.2.5",
     "vitest": "^3.1.4"
   },
   "scripts": {
     "lint": "eslint",
     "lint-fix": "eslint --fix",
+    "format": "prettier --write .",
+    "format:check": "prettier --check .",
     "semantic-release": "semantic-release",
     "test": "vitest run",
     "prepare": "husky"

package/.github/workflows/add-issue-triage-board.yml

@@ -1,12 +0,0 @@
-name: 'Add issue/PR to Triage Board'
-on:
-  issues:
-    types:
-      - opened
-  pull_request_target:
-    types:
-      - opened
-jobs:
-  add-to-triage-project-board:
-    uses: cypress-io/cypress/.github/workflows/triage_add_to_project.yml@develop
-    secrets: inherit