eslint-plugin-cypress 3.0.3 → 3.1.1

package/docs/rules/no-pause.md

@@ -9,11 +9,11 @@ Examples of **incorrect** code for this rule:
 
 ```js
 cy.pause();
+cy.get('selector').pause();
 ```
 
 Examples of **correct** code for this rule:
 
 ```js
-// only the parent cy.pause command is detected
-cy.get('selector').pause();
+cy.get('selector')
 ```

package/lib/rules/no-pause.js

@@ -35,12 +35,15 @@ module.exports = {
     }
 
     function isCypressCall (node) {
-      return node.callee &&
-        node.callee.type === 'MemberExpression' &&
-        node.callee.object.type === 'Identifier' &&
-        node.callee.object.name === 'cy'
+      if (!node.callee || node.callee.type !== 'MemberExpression') {
+        return false;
+      }
+      if (node.callee.object.type === 'Identifier' && node.callee.object.name === 'cy') {
+        return true;
+      }
+      return isCypressCall(node.callee.object);
     }
-
+    
     //----------------------------------------------------------------------
     // Public
     //----------------------------------------------------------------------

package/lib/rules/unsafe-to-chain-command.js

@@ -19,7 +19,7 @@ const unsafeToChainActions = [
   'check',
   'dblclick',
   'each',
-  'focus$',
+  'focus',
   'rightclick',
   'screenshot',
   'scrollIntoView',
@@ -130,7 +130,7 @@ const isRootCypress = (node) => {
  */
 const isActionUnsafeToChain = (node, additionalMethods = []) => {
   const unsafeActionsRegex = new RegExp([
-    ...unsafeToChainActions,
+    ...unsafeToChainActions.map((action) => `^${action}$`),
     ...additionalMethods.map((method) => method instanceof RegExp ? method.source : method),
   ].join('|'))
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-cypress",
-  "version": "3.0.3",
+  "version": "3.1.1",
   "description": "An ESLint plugin for projects using Cypress",
   "main": "index.js",
   "author": "Cypress-io",

package/tests/lib/rules/no-pause.js

@@ -20,14 +20,18 @@ const ruleTester = new RuleTester()
 ruleTester.run('no-pause', rule, {
 
   valid: [
-    // for now, we do not detect .pause() child command
-    { code: `cy.get('button').pause()`, parserOptions },
     { code: `pause()`, parserOptions },
     { code: `cy.get('button').dblclick()`, parserOptions },
   ],
-
+  
   invalid: [
     { code: `cy.pause()`, parserOptions, errors },
     { code: `cy.pause({ log: false })`, parserOptions, errors },
+    { code: `cy.get('button').pause()`, parserOptions, errors },
+    { 
+      code: `cy.get('a').should('have.attr', 'href').and('match', /dashboard/).pause()`, 
+      parserOptions, 
+      errors 
+    }
   ],
 })

package/tests/lib/rules/unsafe-to-chain-command.js

@@ -18,6 +18,10 @@ ruleTester.run('action-ends-chain', rule, {
       code: 'cy.focused().should("be.visible");',
       parserOptions,
     },
+    {
+      code: 'cy.submitBtn().click();',
+      parserOptions,
+    },
   ],
 
   invalid: [