eslint-plugin-cvsdk-rules 10.0.0-1 → 10.0.0-ad-data-structure-refactor

package/build/index.d.ts

@@ -1,5 +1,6 @@
 declare const plugin: {
     rules: {
+        'prefer-no-lodash-cloneDeep': import("@typescript-eslint/utils/dist/ts-eslint/Rule.js").RuleModule<"forbiddenCloneDeepUsage", never[], unknown, import("@typescript-eslint/utils/dist/ts-eslint/Rule.js").RuleListener>;
         'prefer-self-over-window': import("@typescript-eslint/utils/dist/ts-eslint/Rule.js").RuleModule<"forbiddenWindowAccess", never[], unknown, import("@typescript-eslint/utils/dist/ts-eslint/Rule.js").RuleListener>;
         'prefer-txml-over-domparser': import("@typescript-eslint/utils/dist/ts-eslint/Rule.js").RuleModule<"forbiddenDomParserUsage", never[], unknown, import("@typescript-eslint/utils/dist/ts-eslint/Rule.js").RuleListener>;
     };

package/build/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAQA,QAAA,MAAM,MAAM;;;;;CAEX,CAAC;AAEF,OAAO,EAAE,MAAM,EAAE,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAUA,QAAA,MAAM,MAAM;;;;;;CAEX,CAAC;AAEF,OAAO,EAAE,MAAM,EAAE,CAAC"}

package/build/index.js

@@ -1,6 +1,8 @@
 import { rule as preferSelfOverWindow } from './rules/prefer-self-over-window.js';
 import { rule as preferTxmlOverDomParser } from './rules/prefer-txml-over-domparser.js';
+import { rule as preferNoLodashCloneDeep } from './rules/prefer-no-lodash-clone-deep.js';
 var rules = {
+    'prefer-no-lodash-cloneDeep': preferNoLodashCloneDeep,
     'prefer-self-over-window': preferSelfOverWindow,
     'prefer-txml-over-domparser': preferTxmlOverDomParser,
 };

package/build/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,IAAI,oBAAoB,EAAE,MAAM,oCAAoC,CAAC;AAClF,OAAO,EAAE,IAAI,IAAI,uBAAuB,EAAE,MAAM,uCAAuC,CAAC;AAExF,IAAM,KAAK,GAAG;IACV,yBAAyB,EAAE,oBAAoB;IAC/C,4BAA4B,EAAE,uBAAuB;CACxD,CAAC;AAEF,IAAM,MAAM,GAAG;IACX,KAAK,OAAA;CACR,CAAC;AAEF,OAAO,EAAE,MAAM,EAAE,CAAC"}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,IAAI,oBAAoB,EAAE,MAAM,oCAAoC,CAAC;AAClF,OAAO,EAAE,IAAI,IAAI,uBAAuB,EAAE,MAAM,uCAAuC,CAAC;AACxF,OAAO,EAAE,IAAI,IAAI,uBAAuB,EAAE,MAAM,wCAAwC,CAAC;AAEzF,IAAM,KAAK,GAAG;IACV,4BAA4B,EAAE,uBAAuB;IACrD,yBAAyB,EAAE,oBAAoB;IAC/C,4BAA4B,EAAE,uBAAuB;CACxD,CAAC;AAEF,IAAM,MAAM,GAAG;IACX,KAAK,OAAA;CACR,CAAC;AAEF,OAAO,EAAE,MAAM,EAAE,CAAC"}

package/build/rules/prefer-no-lodash-clone-deep.d.ts

@@ -0,0 +1,3 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+export declare const rule: ESLintUtils.RuleModule<"forbiddenCloneDeepUsage", never[], unknown, ESLintUtils.RuleListener>;
+//# sourceMappingURL=prefer-no-lodash-clone-deep.d.ts.map

package/build/rules/prefer-no-lodash-clone-deep.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"prefer-no-lodash-clone-deep.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-no-lodash-clone-deep.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAIvD,eAAO,MAAM,IAAI,+FAwBf,CAAC"}

package/build/rules/prefer-no-lodash-clone-deep.js

@@ -0,0 +1,27 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+var createRule = ESLintUtils.RuleCreator(function (name) { return name; });
+export var rule = createRule({
+    create: function (context) {
+        return {
+            "Program:has(ImportDeclaration[source.value='lodash'] > ImportSpecifier[imported.name=cloneDeep]) CallExpression[callee.name=cloneDeep]": function (node) {
+                context.report({
+                    node: node,
+                    messageId: 'forbiddenCloneDeepUsage',
+                });
+            },
+        };
+    },
+    name: 'prefer-no-lodash-cloneDeep',
+    meta: {
+        docs: {
+            description: 'Detect usage of Lodash cloneDeep',
+        },
+        messages: {
+            forbiddenCloneDeepUsage: "Prefer using rfdc (@sky-uk-ott/core-video-sdk-js-external-rfdc) over lodash.cloneDeep as it cost a lot in performance",
+        },
+        schema: [],
+        type: 'problem',
+    },
+    defaultOptions: [],
+});
+//# sourceMappingURL=prefer-no-lodash-clone-deep.js.map

package/build/rules/prefer-no-lodash-clone-deep.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"prefer-no-lodash-clone-deep.js","sourceRoot":"","sources":["../../src/rules/prefer-no-lodash-clone-deep.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAEvD,IAAM,UAAU,GAAG,WAAW,CAAC,WAAW,CAAC,UAAC,IAAI,IAAK,OAAA,IAAI,EAAJ,CAAI,CAAC,CAAC;AAE3D,MAAM,CAAC,IAAM,IAAI,GAAG,UAAU,CAAC;IAC3B,MAAM,YAAC,OAAO;QACV,OAAO;YACH,wIAAwI,EACpI,UAAC,IAAI;gBACD,OAAO,CAAC,MAAM,CAAC;oBACX,IAAI,MAAA;oBACJ,SAAS,EAAE,yBAAyB;iBACvC,CAAC,CAAC;YACP,CAAC;SACR,CAAC;IACN,CAAC;IACD,IAAI,EAAE,4BAA4B;IAClC,IAAI,EAAE;QACF,IAAI,EAAE;YACF,WAAW,EAAE,kCAAkC;SAClD;QACD,QAAQ,EAAE;YACN,uBAAuB,EAAE,uHAAuH;SACnJ;QACD,MAAM,EAAE,EAAE;QACV,IAAI,EAAE,SAAS;KAClB;IACD,cAAc,EAAE,EAAE;CACrB,CAAC,CAAC"}

package/jest.config.js

@@ -1,2 +1,40 @@
-{
-}
+import path from 'node:path';
+
+export default {
+    collectCoverage: false,
+    collectCoverageFrom: ['src/**/*.{js,jsx,ts,tsx}'],
+    coverageReporters: ['lcov'],
+    moduleFileExtensions: [
+      'ts',
+      'tsx',
+      'mts',
+      'mtsx',
+      'cjs',
+      'js',
+      'jsx',
+      'mjs',
+      'mjsx',
+      'json',
+      'node',
+    ],
+    setupFilesAfterEnv: [
+      path.join(path.resolve(), 'node_modules/console-fail-test/setup.cjs'),
+    ],
+    testRegex: ['./tests/.+\\.test\\.ts$', './src/rules/.+\\.spec\\.ts$'],
+    transform: {
+      '^.+\\.(t|j)sx?$': [
+        '@swc/jest',
+        {
+          jsc: {
+            target: 'es2019',
+            transform: {
+              react: {
+                runtime: 'automatic',
+              },
+            },
+          },
+        },
+      ],
+    },
+    workerIdleMemoryLimit: '300MB',
+  };

package/package.json

@@ -1,18 +1,26 @@
 {
     "name": "eslint-plugin-cvsdk-rules",
-    "version": "10.0.0-1",
-    "main": "index.js",
+    "version": "10.0.0-ad-data-structure-refactor",
+    "main": "./build/index.js",
+    "type": "module",
     "scripts": {
         "test": "jest",
-        "test:nocoverage": "jest"
+        "test:nocoverage": "jest",
+        "build": "tsc"
     },
     "dependencies": {
-        "@typescript-eslint/utils": "6.21.0",
-        "eslint": "8.54.0"
+        "typescript-eslint": "8.8.0"
     },
     "devDependencies": {
-        "@typescript-eslint/rule-tester": "6.21.0",
-        "jest": "29.7.0"
+        "@eslint/js": "^9.8.0",
+        "@types/eslint": "^9.6.0",
+        "@types/eslint__js": "^8.42.3",
+        "@types/node": "^22.0.2",
+        "@typescript-eslint/rule-tester": "8.8.0",
+        "console-fail-test": "^0.5.0",
+        "eslint": "^9.8.0",
+        "eslint-plugin-eslint-plugin": "6.2.0",
+        "typescript": "5.0.2"
     },
-    "gitHead": "3c2af8c7ba90a6e1e23a0f80b2d4c4026edf9598"
+    "gitHead": "e366ef8405f417954fda5abd269d1f624508ccc9"
 }

package/src/index.ts

@@ -0,0 +1,15 @@
+import { rule as preferSelfOverWindow } from './rules/prefer-self-over-window.js';
+import { rule as preferTxmlOverDomParser } from './rules/prefer-txml-over-domparser.js';
+import { rule as preferNoLodashCloneDeep } from './rules/prefer-no-lodash-clone-deep.js';
+
+const rules = {
+    'prefer-no-lodash-cloneDeep': preferNoLodashCloneDeep,
+    'prefer-self-over-window': preferSelfOverWindow,
+    'prefer-txml-over-domparser': preferTxmlOverDomParser,
+};
+
+const plugin = {
+    rules,
+};
+
+export { plugin };

package/src/rules/prefer-no-lodash-clone-deep.ts

@@ -0,0 +1,29 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+
+const createRule = ESLintUtils.RuleCreator((name) => name);
+
+export const rule = createRule({
+    create(context) {
+        return {
+            "Program:has(ImportDeclaration[source.value='lodash'] > ImportSpecifier[imported.name=cloneDeep]) CallExpression[callee.name=cloneDeep]":
+                (node) => {
+                    context.report({
+                        node,
+                        messageId: 'forbiddenCloneDeepUsage',
+                    });
+                },
+        };
+    },
+    name: 'prefer-no-lodash-cloneDeep',
+    meta: {
+        docs: {
+            description: 'Detect usage of Lodash cloneDeep',
+        },
+        messages: {
+            forbiddenCloneDeepUsage: `Prefer using rfdc (@sky-uk-ott/core-video-sdk-js-external-rfdc) over lodash.cloneDeep as it cost a lot in performance`,
+        },
+        schema: [],
+        type: 'problem',
+    },
+    defaultOptions: [],
+});

package/{rules/prefer-self-over-window.spec.js → src/rules/prefer-self-over-window.spec.ts}

@@ -1,21 +1,26 @@
-const { RuleTester } = require('@typescript-eslint/rule-tester');
-const path = require('path');
+import { RuleTester } from '@typescript-eslint/rule-tester';
+import tseslint from 'typescript-eslint';
+import path from 'node:path';
+import { rule } from '../../build/rules/prefer-self-over-window.js';
 
-const rule = require('./prefer-self-over-window');
-
-const ruleName = 'prefer-self-over-window';
+console.log(`Root dir: ${path.join(__dirname, '../..')}`);
 
 // https://typescript-eslint.io/packages/rule-tester/#type-aware-testing
 const ruleTester = new RuleTester({
-    parser: require.resolve('@typescript-eslint/parser'),
-    parserOptions: {
-        project: true,
-        tsconfigRootDir: path.join(__dirname, '../config'),
+    languageOptions: {
+        parser: tseslint.parser,
+        parserOptions: {
+            projectService: {
+                allowDefaultProject: ['*.ts*'],
+                defaultProject: 'tsconfig.json',
+            },
+            tsconfigRootDir: path.join(__dirname, '../..'),
+        },
     },
 });
 
 describe('Disallow window access', () => {
-    ruleTester.run(ruleName, rule, {
+    ruleTester.run('prefer-self-over-window', rule, {
         invalid: [
             {
                 code: 'window;',

package/src/rules/prefer-self-over-window.ts

@@ -0,0 +1,41 @@
+import { ESLintUtils, type TSESTree } from '@typescript-eslint/utils';
+
+const createRule = ESLintUtils.RuleCreator((name) => name);
+
+export const rule = createRule({
+    create(context) {
+        const parserServices = ESLintUtils.getParserServices(context);
+
+        function reportWindowError(node: TSESTree.Node) {
+            if (node.parent!.type !== 'VariableDeclarator') {
+                const nodeType = parserServices.getTypeAtLocation(node);
+                if (Object.prototype.hasOwnProperty.call(nodeType, 'aliasSymbol')) {
+                    context.report({
+                        messageId: 'forbiddenWindowAccess',
+                        node,
+                        fix: function (fixer) {
+                            return fixer.replaceText(node, 'self');
+                        },
+                    });
+                }
+            }
+        }
+
+        return {
+            "Identifier[name='window']": reportWindowError,
+        };
+    },
+    name: 'uppercase-first-declarations',
+    meta: {
+        docs: {
+            description: 'Disallow window access.',
+        },
+        messages: {
+            forbiddenWindowAccess: '`window` cannot be accessed inside some containers, we prefer using `self` as it has more compatibility.',
+        },
+        schema: [], // no options
+        type: 'problem',
+        fixable: 'code',
+    },
+    defaultOptions: [],
+});

package/src/rules/prefer-txml-over-domparser.ts

@@ -0,0 +1,28 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+
+const createRule = ESLintUtils.RuleCreator((name) => name);
+
+export const rule = createRule({
+    create(context) {
+        return {
+            Identifier(node) {
+                if (node.type === 'Identifier' && node.name === 'DOMParser' && node.parent.type === 'NewExpression') {
+                    context.report({
+                        node,
+                        messageId: 'forbiddenDomParserUsage',
+                    });
+                }
+            },
+        };
+    },
+    name: 'prefer-txml-over-domparser',
+    meta: {
+        docs: { description: 'Disallow DOMParser usage.' },
+        messages: {
+            forbiddenDomParserUsage: `Prefer using txml (https://www.npmjs.com/package/txml) over DOMParser as DOMParser isn't supported on ION.`,
+        },
+        schema: [],
+        type: 'problem',
+    },
+    defaultOptions: [],
+});

package/tsconfig.json

@@ -0,0 +1,25 @@
+{
+  "compilerOptions": {
+      "module": "esnext",
+      "declaration": true,
+      "outDir": "build",
+      "declarationMap": true,
+      "downlevelIteration": true,
+      "noImplicitAny": true,
+      "preserveConstEnums": true,
+      "sourceMap": true,
+      "target": "es5",
+      "strict": true,
+      "noUnusedLocals": true,
+      "skipLibCheck": true,
+      "moduleResolution": "node",
+      "resolveJsonModule": true,
+      "importHelpers": true,
+      "esModuleInterop": true,
+      "jsx": "react",
+      "useDefineForClassFields": false,
+      "lib": ["dom", "dom.iterable", "es2017"]
+  },
+"include": ["src/**/*.ts"],
+"exclude": ["**/*.spec.ts"]
+}

package/config/file.ts

@@ -1 +0,0 @@
-// See: https://typescript-eslint.io/packages/rule-tester/#type-aware-testing

package/config/tsconfig.json

@@ -1,11 +0,0 @@
-{
-  // https://typescript-eslint.io/packages/rule-tester/#type-aware-testing
-  "compilerOptions": {
-    // Otherwise TS will complain it'll override the base project's output
-    "outDir": "./",
-    "strict": true
-  },
-  "exclude": [],
-  // See: https://typescript-eslint.io/packages/rule-tester/#type-aware-testing
-  "include": ["file.ts"]
-}

package/index.js

@@ -1,6 +0,0 @@
-module.exports = {
-    rules: {
-        'prefer-self-over-window': require('./rules/prefer-self-over-window'),
-        'prefer-txml-over-domparser': require('./rules/prefer-txml-over-domparser'),
-    },
-};

package/rules/prefer-self-over-window.js

@@ -1,41 +0,0 @@
-const { ESLintUtils } = require('@typescript-eslint/utils');
-
-const meta = {
-    docs: {
-        description: 'Disallow window access.',
-    },
-    messages: {
-        forbiddenWindowAccess: '`window` cannot be accessed inside some containers, we prefer using `self` as it has more compatibility.',
-    },
-    schema: [], // no options
-    type: 'problem',
-    fixable: 'code',
-};
-
-function create(context) {
-    const parserServices = ESLintUtils.getParserServices(context);
-
-    function reportWindowError(node) {
-        if (node.parent.type !== 'VariableDeclarator') {
-            const nodeType = parserServices.getTypeAtLocation(node);
-            if (Object.prototype.hasOwnProperty.call(nodeType, 'aliasSymbol')) {
-                context.report({
-                    messageId: 'forbiddenWindowAccess',
-                    node,
-                    fix: function (fixer) {
-                        return fixer.replaceText(node, 'self');
-                    },
-                });
-            }
-        }
-    }
-
-    return {
-        "Identifier[name='window']": reportWindowError,
-    };
-}
-
-module.exports = {
-    create,
-    meta,
-};

package/rules/prefer-txml-over-domparser.js

@@ -1,26 +0,0 @@
-const meta = {
-    docs: 'Disallow DOMParser usage.',
-    messages: {
-        forbiddenDomParserUsage: `Prefer using txml (https://www.npmjs.com/package/txml) over DOMParser as DOMParser isn't supported on ION.`,
-    },
-    schema: [],
-    type: 'problem',
-};
-
-function create(context) {
-    return {
-        Identifier(node) {
-            if (node.type === 'Identifier' && node.name === 'DOMParser' && node.parent.type === 'NewExpression') {
-                context.report({
-                    node,
-                    messageId: 'forbiddenDomParserUsage',
-                });
-            }
-        },
-    };
-}
-
-module.exports = {
-    create,
-    meta,
-};