eslint-plugin-crisp 1.7.18 → 1.7.19

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-crisp",
-  "version": "1.7.18",
+  "version": "1.7.19",
   "description": "Custom ESLint Rules for Crisp",
   "author": "Crisp IM SAS",
   "main": "index.js",

package/rules/enforce-optional.js

@@ -18,9 +18,10 @@ export default {
 
     const patterns = [
       // Search for `foo && foo.` or `foo && foo[`
-      // Notice: do not match `foo && foo.bar !==` or `foo && foo[bar] !==`, \
-      //   as the version with optional chaining would be unsafe
-      /\b(\w\S+)\s&&\s+\1\b[\[\.](?!\w\S+\s\!\=\=)/g,
+      // Notice: do not match when the accessed value is compared, as the \
+      //   version with optional chaining could change the result for falsy \
+      //   non-nullish values
+      /\b(\w\S+)\s&&\s+\1\b[\[\.](?!\S+\s*(?:[=!]==?|[<>]=?))/g,
 
       // Search for patterns like `foo || {}).bar`, `foo || {})[`, \
       //   `foo || []).bar` or `foo || [])[`

package/tests/rules/enforce-optional.test.js

@@ -7,6 +7,9 @@ ruleTester.run("enforce-optional", rule, {
   valid: [
     "const result = foo?.bar;",
     "const result = foo && foo.bar !== null;",
+    "const result = foo && foo.bar <= maximum;",
+    "const result = foo && foo[bar] === value;",
+    "if (_header_value && _header_value.length <= ORIGINAL_HEADER_MAX_LENGTH) {}",
     "const keys = Object.keys(foo || {});",
     "const filtered = (foo || []).filter(Boolean);"
   ],