eslint-plugin-crisp 1.4.16 → 1.4.17

package/index.js

@@ -29,6 +29,7 @@ import ruleMultilineCommentEndBackslash from "./rules/multiline-comment-end-back
 import ruleNewlineAfterSwitchCase from "./rules/newline-after-switch-case.js";
 import ruleNoAsync from "./rules/no-async.js";
 import ruleNoExtraLineWithinFunction from "./rules/no-extra-line-within-function.js";
+import ruleNoInlineFunctionInTernary from "./rules/no-inline-function-in-ternary.js";
 import ruleNoSpaceInOptionalArguments from "./rules/no-space-in-optional-arguments.js";
 import ruleNoUselessTemplateLiterals from "./rules/no-useless-template-literals.js";
 import ruleNoVarInBlocks from "./rules/no-var-in-blocks.js";
@@ -96,6 +97,7 @@ const plugin = {
     "newline-after-switch-case": ruleNewlineAfterSwitchCase,
     "no-async": ruleNoAsync,
     "no-extra-line-within-function": ruleNoExtraLineWithinFunction,
+    "no-inline-function-in-ternary": ruleNoInlineFunctionInTernary,
     "no-space-in-optional-arguments": ruleNoSpaceInOptionalArguments,
     "no-var-in-blocks": ruleNoVarInBlocks,
     "no-useless-template-literals": ruleNoUselessTemplateLiterals,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-crisp",
-  "version": "1.4.16",
+  "version": "1.4.17",
   "description": "Custom ESLint Rules for Crisp",
   "author": "Crisp IM SAS",
   "main": "index.js",

package/recommended-ts.js

@@ -163,6 +163,7 @@ export default function configRecommendedTS(pluginCrisp) {
         "crisp/newline-after-switch-case": "error",
         "crisp/no-async": "off",
         "crisp/no-extra-line-within-function": "error",
+        "crisp/no-inline-function-in-ternary": "error",
         "crisp/no-short-parameters": [
           "error",
           {

package/recommended-vue.js

@@ -179,6 +179,7 @@ export default function configRecommendedVue(pluginCrisp) {
         "crisp/newline-after-switch-case": "error",
         "crisp/no-async": "error",
         "crisp/no-extra-line-within-function": "error",
+        "crisp/no-inline-function-in-ternary": "error",
         "crisp/no-short-parameters": [
           "error",
 

package/recommended.js

@@ -171,6 +171,7 @@ export default function configRecommended(pluginCrisp) {
         "crisp/newline-after-switch-case": "error",
         "crisp/no-async": "error",
         "crisp/no-extra-line-within-function": "error",
+        "crisp/no-inline-function-in-ternary": "error",
         "crisp/no-var-in-blocks": "error",
         "crisp/no-short-parameters": [
           "error",

package/rules/no-inline-function-in-ternary.js

@@ -0,0 +1,49 @@
+const findContainingTernaryBranch = (node) => {
+  let child = node;
+  let parent = node.parent;
+
+  while (parent) {
+    if (
+      parent.type === "ConditionalExpression" &&
+      (parent.consequent === child || parent.alternate === child)
+    ) {
+      return parent;
+    }
+
+    child = parent;
+    parent = parent.parent;
+  }
+
+  return null;
+};
+
+export default {
+  meta: {
+    type: "suggestion",
+    docs: {
+      description: "Disallow inline functions in ternary branches."
+    },
+    schema: [],
+    messages: {
+      inlineFunction: "Extract this inline function from the ternary expression."
+    }
+  },
+
+  create(context) {
+    const checkFunction = (node) => {
+      if (!findContainingTernaryBranch(node)) {
+        return;
+      }
+
+      context.report({
+        node,
+        messageId: "inlineFunction"
+      });
+    };
+
+    return {
+      ArrowFunctionExpression: checkFunction,
+      FunctionExpression: checkFunction
+    };
+  }
+};