eslint-plugin-crisp 1.0.21 → 1.0.23

package/index.js

@@ -31,7 +31,9 @@ module.exports = {
     "align-consecutive-class-assignements": require("./rules/align-consecutive-class-assignements"),
     "vue-computed-order": require("./rules/vue-computed-order"),
     "vue-emits-order": require("./rules/vue-emits-order"),
+    "vue-header-check": require("./rules/vue-header-check"),
     "vue-html-quotes": require("./rules/vue-html-quotes"),
+    "vue-no-regex-data": require("./rules/vue-no-regex-data"),
     "vue-props-declaration-order": require("./rules/vue-props-declaration-order")
   }
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-crisp",
-  "version": "1.0.21",
+  "version": "1.0.23",
   "description": "Custom EsLint Rules for Crisp",
   "main": "index.js",
   "author": "Crisp IM SAS",

package/recommended-vue.js

@@ -72,6 +72,7 @@ module.exports = {
     "crisp/no-useless-template-literals": "error",
     "crisp/one-space-after-operator": ["error", { "checkColon": false }],
     "crisp/regex-in-constructor": "error",
+    "crisp/ternary-parenthesis": "error",
     "crisp/variable-names": "error",
     "crisp/no-short-parameters": [
       "error",
@@ -178,7 +179,9 @@ module.exports = {
     // Crisp Vue rules
     "crisp/vue-computed-order": "error",
     "crisp/vue-emits-order": "error",
+    "crisp/vue-header-check": "error",
     "crisp/vue-html-quotes": "error",
+    "crisp/vue-no-regex-data": "error",
     "crisp/vue-props-declaration-order": "error"
   },
 

package/rules/ternary-parenthesis.js

@@ -7,6 +7,7 @@ module.exports = {
       recommended: false,
     },
     schema: [], // no options
+    fixable: "code",
   },
   create(context) {
     return {
@@ -20,6 +21,13 @@ module.exports = {
             context.report({
               node,
               message: "The condition in ternary expressions with an operator should be wrapped in parentheses",
+              fix(fixer) {
+                const conditionText = sourceCode.getText(node.test);
+                return [
+                  fixer.insertTextBefore(node.test, "("),
+                  fixer.insertTextAfter(node.test, ")"),
+                ];
+              },
             });
           }
         }

package/rules/vue-header-check.js

@@ -0,0 +1,48 @@
+const fs = require("fs");
+const path = require("path");
+
+module.exports = {
+  meta: {
+    type: "suggestion",
+    docs: {
+      description: "Enforce Vue section headers",
+      category: "Best Practices",
+      recommended: false,
+    },
+    fixable: null  // This rule is not auto-fixable
+  },
+
+  create(context) {
+    return {
+      Program(node) {
+        const fileName = context.getFilename();
+        const fileContent = fs.readFileSync(path.resolve(fileName), "utf8");
+
+        // Determine the file extension
+        const fileExtension = path.extname(fileName);
+
+        if (fileExtension === ".vue") {
+          // Define the headers
+          const headers = ["TEMPLATE", "SCRIPT", "STYLE"];
+
+          // Define the Vue tags
+          const vueTags = ["template", "script", "style"];
+
+          // Check each tag individually
+          vueTags.forEach((tag, index) => {
+            const tagRegExp = new RegExp(`<${tag}`);
+            const headerRegExp = new RegExp(`<!--\\s*\\*{73}\\s*\\n\\s*${headers[index]}\\s*\\n\\s*\\*{73}\\s*-->\\s*\\n\\s*<${tag}`);
+
+            // If the tag exists without the corresponding header, report an error
+            if (tagRegExp.test(fileContent) && !headerRegExp.test(fileContent)) {
+              context.report({
+                node,
+                message: `The '<${tag}>' section must be preceded by the '${headers[index]}' header comment.`,
+              });
+            }
+          });
+        }
+      }
+    };
+  }
+};

package/rules/vue-no-regex-data.js

@@ -0,0 +1,46 @@
+module.exports = {
+  meta: {
+    type: "problem",
+    docs: {
+      description: "disallow regex in Vue data object",
+      category: "Possible Errors",
+      recommended: true,
+    },
+    fixable: "code",
+  },
+
+  create(context) {
+    function isRegex(node) {
+      if (
+        node.type === "NewExpression" &&
+        node.callee.name === "RegExp"
+      ) {
+        // Check for RegExp constructor
+        return true;
+      } else if (
+        node.type === "Literal" &&
+        node.regex
+      ) {
+        // Check for RegExp literal
+        return true;
+      }
+
+      return false;
+    }
+
+    return {
+      'Property[key.name="data"] > FunctionExpression > BlockStatement > ReturnStatement > ObjectExpression'(node) {
+        const properties = node.properties;
+
+        properties.forEach((property, index) => {
+          if (isRegex(property.value)) {
+            context.report({
+              node: property,
+              message: "Do not use regex in Vue data object. Please move it outside, as a constant.",
+            });
+          }
+        });
+      }
+    };
+  }
+};