eslint-plugin-conventions 4.2.6 → 4.2.7

package/src/rules/conventions/prefer-dependency-version-strategy.js

@@ -1,201 +1 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.preferDependencyVersionStrategy = void 0;
-const eslint_devkit_1 = require("@interlace/eslint-devkit");
-const eslint_devkit_2 = require("@interlace/eslint-devkit");
-exports.preferDependencyVersionStrategy = (0, eslint_devkit_2.createRule)({
-    name: 'prefer-dependency-version-strategy',
-    meta: {
-        type: 'suggestion',
-        docs: {
-            url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/prefer-dependency-version-strategy.md',
-            description: 'Enforce consistent version strategy (caret, tilde, exact, etc.) for package.json dependencies',
-        },
-        fixable: 'code',
-        messages: {
-            preferStrategy: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.PACKAGE,
-                issueName: 'Dependency Version Strategy',
-                description: 'Dependency "{{name}}" should use {{strategy}} version',
-                severity: 'MEDIUM',
-                fix: 'Change "{{current}}" to "{{expected}}" for version flexibility',
-                documentationLink: 'https://docs.npmjs.com/cli/v10/configuring-npm/package-json#dependencies',
-            }),
-            invalidStrategy: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.WARNING,
-                issueName: 'Invalid Version Strategy',
-                description: 'Strategy "{{strategy}}" is not valid',
-                severity: 'MEDIUM',
-                fix: 'Use one of: caret (^), tilde (~), exact (no prefix), range (<, >, ||), or any',
-                documentationLink: 'https://docs.npmjs.com/cli/v10/configuring-npm/package-json#dependencies',
-            }),
-        },
-        schema: [
-            {
-                type: 'object',
-                properties: {
-                    strategy: {
-                        type: 'string',
-                        enum: ['caret', 'tilde', 'exact', 'range', 'any'],
-                        description: 'Version strategy to enforce: caret (^), tilde (~), exact (no prefix), range (allows <, >, ||), or any (allows all)',
-                    },
-                    allowWorkspace: {
-                        type: 'boolean',
-                        description: 'Allow workspace: protocol versions',
-                        default: true,
-                    },
-                    allowFile: {
-                        type: 'boolean',
-                        description: 'Allow file: protocol versions',
-                        default: true,
-                    },
-                    allowLink: {
-                        type: 'boolean',
-                        description: 'Allow link: protocol versions',
-                        default: true,
-                    },
-                    overrides: {
-                        type: 'object',
-                        additionalProperties: {
-                            type: 'string',
-                            enum: ['caret', 'tilde', 'exact', 'range', 'any'],
-                        },
-                        description: 'Package-specific strategy overrides. Key is package name, value is strategy. Example: { "react": "exact", "lodash": "tilde" }',
-                    },
-                },
-                additionalProperties: false,
-            },
-        ],
-    },
-    defaultOptions: [
-        {
-            strategy: 'caret',
-            allowWorkspace: true,
-            allowFile: true,
-            allowLink: true,
-            overrides: {},
-        },
-    ],
-    create(context) {
-        const options = context.options[0] || {};
-        const { strategy = 'caret', allowWorkspace = true, allowFile = true, allowLink = true, overrides = {}, } = options;
-        const validStrategies = [
-            'caret',
-            'tilde',
-            'exact',
-            'range',
-            'any',
-        ];
-        if (!validStrategies.includes(strategy)) {
-            context.report({
-                loc: { line: 1, column: 0 },
-                messageId: 'invalidStrategy',
-                data: { strategy },
-            });
-            return {};
-        }
-        if (strategy === 'any') {
-            return {};
-        }
-        function checkVersion(node, depName, version) {
-            if (allowWorkspace && version.startsWith('workspace:'))
-                return;
-            if (allowFile && version.startsWith('file:'))
-                return;
-            if (allowLink && version.startsWith('link:'))
-                return;
-            if (!version.match(/^[\^~<>=]?\d+\.\d+\.\d+/))
-                return;
-            const packageStrategy = overrides[depName] || strategy;
-            if (packageStrategy === 'any')
-                return;
-            let expectedVersion = version;
-            let needsFix = false;
-            const baseVersion = version.replace(/^[\^~<>=]+/, '');
-            switch (packageStrategy) {
-                case 'caret':
-                    if (!version.startsWith('^')) {
-                        expectedVersion = `^${baseVersion}`;
-                        needsFix = true;
-                    }
-                    break;
-                case 'tilde':
-                    if (!version.startsWith('~')) {
-                        expectedVersion = `~${baseVersion}`;
-                        needsFix = true;
-                    }
-                    break;
-                case 'exact': {
-                    if (version !== baseVersion) {
-                        expectedVersion = baseVersion;
-                        needsFix = true;
-                    }
-                    break;
-                }
-                case 'range':
-                    if (!version.includes('||') &&
-                        !version.includes('>=') &&
-                        !version.includes('<=') &&
-                        !version.includes('>') &&
-                        !version.includes('<') &&
-                        !version.includes(' - ')) {
-                        expectedVersion = `^${baseVersion}`;
-                        needsFix = true;
-                    }
-                    break;
-            }
-            if (needsFix) {
-                context.report({
-                    node: node.value,
-                    messageId: 'preferStrategy',
-                    data: {
-                        name: depName,
-                        strategy: packageStrategy,
-                        current: version,
-                        expected: expectedVersion,
-                    },
-                    fix(fixer) {
-                        return fixer.replaceText(node.value, JSON.stringify(expectedVersion));
-                    },
-                });
-            }
-        }
-        const checkObjectExpression = (node) => {
-            for (const prop of node.properties) {
-                if (prop.type === 'Property' &&
-                    prop.key &&
-                    prop.value &&
-                    prop.value.type === 'Literal') {
-                    const depName = prop.key.type === 'Identifier'
-                        ? prop.key.name
-                        : prop.key.type === 'Literal'
-                            ? String(prop.key.value)
-                            : null;
-                    if (depName && typeof prop.value.value === 'string') {
-                        checkVersion(prop, depName, prop.value.value);
-                    }
-                }
-            }
-        };
-        return {
-            'Property[key.value="dependencies"], Property[key.value="devDependencies"], Property[key.value="peerDependencies"]'(node) {
-                if (node.value.type !== 'ObjectExpression')
-                    return;
-                checkObjectExpression(node.value);
-            },
-            ObjectExpression(node) {
-                const hasVersionLikeValues = node.properties.some((prop) => {
-                    if (prop.type === 'Property' && prop.value.type === 'Literal') {
-                        const value = String(prop.value.value);
-                        return (/^[\^~]?\d+\.\d+\.\d+/.test(value) ||
-                            value.startsWith('workspace:'));
-                    }
-                    return false;
-                });
-                if (hasVersionLikeValues) {
-                    checkObjectExpression(node);
-                }
-            },
-        };
-    },
-});
+"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.preferDependencyVersionStrategy=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");exports.preferDependencyVersionStrategy=(0,eslint_devkit_2.createRule)({name:"prefer-dependency-version-strategy",meta:{type:"suggestion",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/prefer-dependency-version-strategy.md",description:"Enforce consistent version strategy (caret, tilde, exact, etc.) for package.json dependencies"},fixable:"code",messages:{preferStrategy:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.PACKAGE,issueName:"Dependency Version Strategy",description:'Dependency "{{name}}" should use {{strategy}} version',severity:"MEDIUM",fix:'Change "{{current}}" to "{{expected}}" for version flexibility',documentationLink:"https://docs.npmjs.com/cli/v10/configuring-npm/package-json#dependencies"}),invalidStrategy:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.WARNING,issueName:"Invalid Version Strategy",description:'Strategy "{{strategy}}" is not valid',severity:"MEDIUM",fix:"Use one of: caret (^), tilde (~), exact (no prefix), range (<, >, ||), or any",documentationLink:"https://docs.npmjs.com/cli/v10/configuring-npm/package-json#dependencies"})},schema:[{type:"object",properties:{strategy:{type:"string",enum:["caret","tilde","exact","range","any"],description:"Version strategy to enforce: caret (^), tilde (~), exact (no prefix), range (allows <, >, ||), or any (allows all)"},allowWorkspace:{type:"boolean",description:"Allow workspace: protocol versions",default:true},allowFile:{type:"boolean",description:"Allow file: protocol versions",default:true},allowLink:{type:"boolean",description:"Allow link: protocol versions",default:true},overrides:{type:"object",additionalProperties:{type:"string",enum:["caret","tilde","exact","range","any"]},description:'Package-specific strategy overrides. Key is package name, value is strategy. Example: { "react": "exact", "lodash": "tilde" }'}},additionalProperties:false}]},defaultOptions:[{strategy:"caret",allowWorkspace:true,allowFile:true,allowLink:true,overrides:{}}],create(context){const options=context.options[0]||{};const{strategy="caret",allowWorkspace=true,allowFile=true,allowLink=true,overrides={}}=options;const validStrategies=["caret","tilde","exact","range","any"];if(!validStrategies.includes(strategy)){context.report({loc:{line:1,column:0},messageId:"invalidStrategy",data:{strategy}});return{}}if(strategy==="any"){return{}}function checkVersion(node,depName,version){if(allowWorkspace&&version.startsWith("workspace:"))return;if(allowFile&&version.startsWith("file:"))return;if(allowLink&&version.startsWith("link:"))return;if(!version.match(/^[\^~<>=]?\d+\.\d+\.\d+/))return;const packageStrategy=overrides[depName]||strategy;if(packageStrategy==="any")return;let expectedVersion=version;let needsFix=false;const baseVersion=version.replace(/^[\^~<>=]+/,"");switch(packageStrategy){case"caret":if(!version.startsWith("^")){expectedVersion=`^${baseVersion}`;needsFix=true}break;case"tilde":if(!version.startsWith("~")){expectedVersion=`~${baseVersion}`;needsFix=true}break;case"exact":{if(version!==baseVersion){expectedVersion=baseVersion;needsFix=true}break}case"range":if(!version.includes("||")&&!version.includes(">=")&&!version.includes("<=")&&!version.includes(">")&&!version.includes("<")&&!version.includes(" - ")){expectedVersion=`^${baseVersion}`;needsFix=true}break}if(needsFix){context.report({node:node.value,messageId:"preferStrategy",data:{name:depName,strategy:packageStrategy,current:version,expected:expectedVersion},fix(fixer){return fixer.replaceText(node.value,JSON.stringify(expectedVersion))}})}}const checkObjectExpression=node=>{for(const prop of node.properties){if(prop.type==="Property"&&prop.key&&prop.value&&prop.value.type==="Literal"){const depName=prop.key.type==="Identifier"?prop.key.name:prop.key.type==="Literal"?String(prop.key.value):null;if(depName&&typeof prop.value.value==="string"){checkVersion(prop,depName,prop.value.value)}}}};return{'Property[key.value="dependencies"], Property[key.value="devDependencies"], Property[key.value="peerDependencies"]'(node){if(node.value.type!=="ObjectExpression")return;checkObjectExpression(node.value)},ObjectExpression(node){const hasVersionLikeValues=node.properties.some(prop=>{if(prop.type==="Property"&&prop.value.type==="Literal"){const value=String(prop.value.value);return/^[\^~]?\d+\.\d+\.\d+/.test(value)||value.startsWith("workspace:")}return false});if(hasVersionLikeValues){checkObjectExpression(node)}}}}});

package/src/rules/conventions/prefer-dom-node-text-content.js

@@ -1,127 +1 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.preferDomNodeTextContent = void 0;
-const eslint_devkit_1 = require("@interlace/eslint-devkit");
-const eslint_devkit_2 = require("@interlace/eslint-devkit");
-exports.preferDomNodeTextContent = (0, eslint_devkit_1.createRule)({
-    name: 'prefer-dom-node-text-content',
-    meta: {
-        type: 'suggestion',
-        docs: {
-            url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/prefer-dom-node-text-content.md',
-            description: 'Prefer textContent over innerText for better performance and reliability',
-        },
-        hasSuggestions: true,
-        messages: {
-            preferDomNodeTextContent: (0, eslint_devkit_2.formatLLMMessage)({
-                icon: eslint_devkit_2.MessageIcons.PERFORMANCE,
-                issueName: 'DOM Text Access',
-                description: 'Use textContent instead of innerText',
-                severity: 'MEDIUM',
-                fix: 'Replace innerText with textContent',
-                documentationLink: 'https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-dom-node-text-content.md',
-            }),
-        },
-        schema: [
-            {
-                type: 'object',
-                properties: {},
-                additionalProperties: false,
-            },
-        ],
-    },
-    defaultOptions: [],
-    create(context) {
-        function isInAllowedContext() {
-            return false;
-        }
-        function isLikelyDomElement(node) {
-            const obj = node.object;
-            if (obj.type === 'Identifier') {
-                const name = obj.name;
-                if (name.match(/^(element|el|div|span|node|ref|dom|elem)$/i)) {
-                    return true;
-                }
-                if (name.match(/(Element|Node|Ref)$/)) {
-                    return true;
-                }
-            }
-            if (obj.type === 'CallExpression' &&
-                obj.callee.type === 'MemberExpression') {
-                const methodName = obj.callee.property?.name;
-                if (methodName &&
-                    [
-                        'querySelector',
-                        'querySelectorAll',
-                        'getElementById',
-                        'getElementsByClassName',
-                        'getElementsByTagName',
-                        'createElement',
-                    ].includes(methodName)) {
-                    return true;
-                }
-            }
-            if (obj.type === 'MemberExpression') {
-                const propName = obj.property?.name;
-                if (propName &&
-                    [
-                        'current',
-                        'children',
-                        'childNodes',
-                        'parentNode',
-                        'element',
-                    ].includes(propName)) {
-                    return true;
-                }
-            }
-            return false;
-        }
-        function isInnerTextAccess(node) {
-            if (node.property.type === 'Identifier' &&
-                node.property.name === 'innerText') {
-                return true;
-            }
-            if (node.computed &&
-                node.property.type === 'Literal' &&
-                node.property.value === 'innerText') {
-                return true;
-            }
-            return false;
-        }
-        return {
-            MemberExpression(node) {
-                if (isInnerTextAccess(node) &&
-                    isLikelyDomElement(node) &&
-                    !isInAllowedContext()) {
-                    context.report({
-                        node,
-                        messageId: 'preferDomNodeTextContent',
-                        data: {
-                            current: 'innerText',
-                            fix: 'textContent',
-                        },
-                        suggest: [
-                            {
-                                messageId: 'preferDomNodeTextContent',
-                                data: {
-                                    replacement: 'textContent',
-                                    suggestion: 'Replace with textContent',
-                                },
-                                fix(fixer) {
-                                    if (node.property.type === 'Identifier') {
-                                        return fixer.replaceText(node.property, 'textContent');
-                                    }
-                                    else if (node.property.type === 'Literal' &&
-                                        node.property.value === 'innerText') {
-                                        return fixer.replaceText(node.property, '"textContent"');
-                                    }
-                                    return null;
-                                },
-                            },
-                        ],
-                    });
-                }
-            },
-        };
-    },
-});
+"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.preferDomNodeTextContent=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");exports.preferDomNodeTextContent=(0,eslint_devkit_1.createRule)({name:"prefer-dom-node-text-content",meta:{type:"suggestion",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/prefer-dom-node-text-content.md",description:"Prefer textContent over innerText for better performance and reliability"},hasSuggestions:true,messages:{preferDomNodeTextContent:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.PERFORMANCE,issueName:"DOM Text Access",description:"Use textContent instead of innerText",severity:"MEDIUM",fix:"Replace innerText with textContent",documentationLink:"https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-dom-node-text-content.md"})},schema:[{type:"object",properties:{},additionalProperties:false}]},defaultOptions:[],create(context){function isInAllowedContext(){return false}function isLikelyDomElement(node){const obj=node.object;if(obj.type==="Identifier"){const name=obj.name;if(name.match(/^(element|el|div|span|node|ref|dom|elem)$/i)){return true}if(name.match(/(Element|Node|Ref)$/)){return true}}if(obj.type==="CallExpression"&&obj.callee.type==="MemberExpression"){const methodName=obj.callee.property?.name;if(methodName&&["querySelector","querySelectorAll","getElementById","getElementsByClassName","getElementsByTagName","createElement"].includes(methodName)){return true}}if(obj.type==="MemberExpression"){const propName=obj.property?.name;if(propName&&["current","children","childNodes","parentNode","element"].includes(propName)){return true}}return false}function isInnerTextAccess(node){if(node.property.type==="Identifier"&&node.property.name==="innerText"){return true}if(node.computed&&node.property.type==="Literal"&&node.property.value==="innerText"){return true}return false}return{MemberExpression(node){if(isInnerTextAccess(node)&&isLikelyDomElement(node)&&!isInAllowedContext()){context.report({node,messageId:"preferDomNodeTextContent",data:{current:"innerText",fix:"textContent"},suggest:[{messageId:"preferDomNodeTextContent",data:{replacement:"textContent",suggestion:"Replace with textContent"},fix(fixer){if(node.property.type==="Identifier"){return fixer.replaceText(node.property,"textContent")}else if(node.property.type==="Literal"&&node.property.value==="innerText"){return fixer.replaceText(node.property,'"textContent"')}return null}}]})}}}}});

package/src/rules/conventions/require-data-testid.js

@@ -1,179 +1 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.requireDataTestId = void 0;
-const eslint_devkit_1 = require("@interlace/eslint-devkit");
-const ALWAYS_INTERACTIVE = new Set([
-    'button',
-    'input',
-    'select',
-    'textarea',
-    'form',
-]);
-function isInteractiveAnchor(node) {
-    return node.attributes.some((attr) => {
-        if (attr.type !== 'JSXAttribute')
-            return false;
-        const name = attr.name.type === 'JSXIdentifier' ? attr.name.name : undefined;
-        return name === 'href' || name === 'onClick';
-    });
-}
-function hasEventHandler(node) {
-    return node.attributes.some((attr) => {
-        if (attr.type !== 'JSXAttribute')
-            return false;
-        if (attr.name.type !== 'JSXIdentifier')
-            return false;
-        return /^on[A-Z]/.test(attr.name.name);
-    });
-}
-function getJsxName(name) {
-    if (name.type === 'JSXIdentifier')
-        return name.name;
-    if (name.type === 'JSXMemberExpression') {
-        return name.property.type === 'JSXIdentifier'
-            ? name.property.name
-            : undefined;
-    }
-    return undefined;
-}
-function hasDataTestId(node) {
-    for (const attr of node.attributes) {
-        if (attr.type !== 'JSXAttribute')
-            continue;
-        if (attr.name.type === 'JSXIdentifier' && attr.name.name === 'data-testid')
-            return attr;
-    }
-    return null;
-}
-function hasSpreadingAllProps(node) {
-    return node.attributes.some((a) => a.type === 'JSXSpreadAttribute');
-}
-function isStableValue(attr) {
-    if (!attr.value)
-        return false;
-    if (attr.value.type === 'Literal')
-        return typeof attr.value.value === 'string';
-    if (attr.value.type === 'JSXExpressionContainer') {
-        const expr = attr.value.expression;
-        if (expr.type === 'Literal')
-            return typeof expr.value === 'string';
-        if (expr.type === 'TemplateLiteral') {
-            return expr.expressions.every((e) => ['Identifier', 'MemberExpression', 'Literal'].includes(e.type));
-        }
-        if (expr.type === 'Identifier')
-            return true;
-        return false;
-    }
-    return false;
-}
-exports.requireDataTestId = (0, eslint_devkit_1.createRule)({
-    name: 'require-data-testid',
-    meta: {
-        type: 'problem',
-        docs: {
-            url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/require-data-testid.md',
-            description: 'Require stable `data-testid` attributes on interactive elements and custom components for testability.',
-        },
-        fixable: undefined,
-        hasSuggestions: false,
-        messages: {
-            missingDataTestId: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.WARNING,
-                issueName: 'Missing data-testid',
-                description: 'Interactive elements and custom components must expose a stable `data-testid` for E2E testability. Class-name selectors break on every Tailwind refactor; `data-testid` survives.',
-                severity: 'MEDIUM',
-                fix: 'Add `data-testid="<lower-kebab-case-name>"` to the element.',
-                documentationLink: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/require-data-testid.md',
-            }),
-            dynamicDataTestId: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.WARNING,
-                issueName: 'Unstable data-testid value',
-                description: '`data-testid` should be a string literal or a template literal of stable identifiers — values that change between renders make tests flaky.',
-                severity: 'LOW',
-                fix: 'Use a string literal or template like `pagination-page-${pageNumber}` instead of dynamic / computed values.',
-                documentationLink: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/require-data-testid.md',
-            }),
-        },
-        schema: [
-            {
-                type: 'object',
-                additionalProperties: false,
-                properties: {
-                    requireOn: {
-                        type: 'array',
-                        items: { type: 'string' },
-                        description: 'Extra element / component names to flag.',
-                    },
-                    ignore: {
-                        type: 'array',
-                        items: { type: 'string' },
-                        description: 'Element / component names to skip.',
-                    },
-                    componentPattern: {
-                        type: 'string',
-                        description: 'Regex; matched names are treated as custom components. Empty disables component checks.',
-                    },
-                    componentRequiresHandler: {
-                        type: 'boolean',
-                        description: 'When `componentPattern` matches, only flag if the component has an `on*` event handler (default true). Set false to flag every matching component.',
-                    },
-                    enforceStableValues: {
-                        type: 'boolean',
-                        description: 'Reject computed `data-testid` values (default: true).',
-                    },
-                },
-            },
-        ],
-    },
-    defaultOptions: [
-        {
-            requireOn: [],
-            ignore: [],
-            componentPattern: '^[A-Z]',
-            componentRequiresHandler: true,
-            enforceStableValues: true,
-        },
-    ],
-    create(context, [opts]) {
-        const options = opts ?? {};
-        const requireOn = new Set(options.requireOn ?? []);
-        const ignore = new Set(options.ignore ?? []);
-        const componentPatternStr = options.componentPattern ?? '^[A-Z]';
-        const componentPattern = componentPatternStr
-            ? new RegExp(componentPatternStr)
-            : null;
-        const componentRequiresHandler = options.componentRequiresHandler ?? true;
-        const enforceStableValues = options.enforceStableValues ?? true;
-        return {
-            JSXOpeningElement(node) {
-                const name = getJsxName(node.name);
-                if (!name)
-                    return;
-                if (ignore.has(name))
-                    return;
-                let inScope = false;
-                if (ALWAYS_INTERACTIVE.has(name))
-                    inScope = true;
-                else if (name === 'a' && isInteractiveAnchor(node))
-                    inScope = true;
-                else if (componentPattern && componentPattern.test(name)) {
-                    inScope = componentRequiresHandler ? hasEventHandler(node) : true;
-                }
-                else if (requireOn.has(name))
-                    inScope = true;
-                if (!inScope)
-                    return;
-                if (hasSpreadingAllProps(node))
-                    return;
-                const existing = hasDataTestId(node);
-                if (!existing) {
-                    context.report({ node, messageId: 'missingDataTestId' });
-                    return;
-                }
-                if (enforceStableValues && !isStableValue(existing)) {
-                    context.report({ node: existing, messageId: 'dynamicDataTestId' });
-                }
-            },
-        };
-    },
-});
+"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireDataTestId=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const ALWAYS_INTERACTIVE=new Set(["button","input","select","textarea","form"]);function isInteractiveAnchor(node){return node.attributes.some(attr=>{if(attr.type!=="JSXAttribute")return false;const name=attr.name.type==="JSXIdentifier"?attr.name.name:void 0;return name==="href"||name==="onClick"})}function hasEventHandler(node){return node.attributes.some(attr=>{if(attr.type!=="JSXAttribute")return false;if(attr.name.type!=="JSXIdentifier")return false;return/^on[A-Z]/.test(attr.name.name)})}function getJsxName(name){if(name.type==="JSXIdentifier")return name.name;if(name.type==="JSXMemberExpression"){return name.property.type==="JSXIdentifier"?name.property.name:void 0}return void 0}function hasDataTestId(node){for(const attr of node.attributes){if(attr.type!=="JSXAttribute")continue;if(attr.name.type==="JSXIdentifier"&&attr.name.name==="data-testid")return attr}return null}function hasSpreadingAllProps(node){return node.attributes.some(a=>a.type==="JSXSpreadAttribute")}function isStableValue(attr){if(!attr.value)return false;if(attr.value.type==="Literal")return typeof attr.value.value==="string";if(attr.value.type==="JSXExpressionContainer"){const expr=attr.value.expression;if(expr.type==="Literal")return typeof expr.value==="string";if(expr.type==="TemplateLiteral"){return expr.expressions.every(e=>["Identifier","MemberExpression","Literal"].includes(e.type))}if(expr.type==="Identifier")return true;return false}return false}exports.requireDataTestId=(0,eslint_devkit_1.createRule)({name:"require-data-testid",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/require-data-testid.md",description:"Require stable `data-testid` attributes on interactive elements and custom components for testability."},fixable:void 0,hasSuggestions:false,messages:{missingDataTestId:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.WARNING,issueName:"Missing data-testid",description:"Interactive elements and custom components must expose a stable `data-testid` for E2E testability. Class-name selectors break on every Tailwind refactor; `data-testid` survives.",severity:"MEDIUM",fix:'Add `data-testid="<lower-kebab-case-name>"` to the element.',documentationLink:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/require-data-testid.md"}),dynamicDataTestId:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.WARNING,issueName:"Unstable data-testid value",description:"`data-testid` should be a string literal or a template literal of stable identifiers \u2014 values that change between renders make tests flaky.",severity:"LOW",fix:"Use a string literal or template like `pagination-page-${pageNumber}` instead of dynamic / computed values.",documentationLink:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/require-data-testid.md"})},schema:[{type:"object",additionalProperties:false,properties:{requireOn:{type:"array",items:{type:"string"},description:"Extra element / component names to flag."},ignore:{type:"array",items:{type:"string"},description:"Element / component names to skip."},componentPattern:{type:"string",description:"Regex; matched names are treated as custom components. Empty disables component checks."},componentRequiresHandler:{type:"boolean",description:"When `componentPattern` matches, only flag if the component has an `on*` event handler (default true). Set false to flag every matching component."},enforceStableValues:{type:"boolean",description:"Reject computed `data-testid` values (default: true)."}}}]},defaultOptions:[{requireOn:[],ignore:[],componentPattern:"^[A-Z]",componentRequiresHandler:true,enforceStableValues:true}],create(context,[opts]){const options=opts??{};const requireOn=new Set(options.requireOn??[]);const ignore=new Set(options.ignore??[]);const componentPatternStr=options.componentPattern??"^[A-Z]";const componentPattern=componentPatternStr?new RegExp(componentPatternStr):null;const componentRequiresHandler=options.componentRequiresHandler??true;const enforceStableValues=options.enforceStableValues??true;return{JSXOpeningElement(node){const name=getJsxName(node.name);if(!name)return;if(ignore.has(name))return;let inScope=false;if(ALWAYS_INTERACTIVE.has(name))inScope=true;else if(name==="a"&&isInteractiveAnchor(node))inScope=true;else if(componentPattern&&componentPattern.test(name)){inScope=componentRequiresHandler?hasEventHandler(node):true}else if(requireOn.has(name))inScope=true;if(!inScope)return;if(hasSpreadingAllProps(node))return;const existing=hasDataTestId(node);if(!existing){context.report({node,messageId:"missingDataTestId"});return}if(enforceStableValues&&!isStableValue(existing)){context.report({node:existing,messageId:"dynamicDataTestId"})}}}}});

package/src/rules/conventions/utm-taxonomy.js

@@ -1,106 +1 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.utmTaxonomy = void 0;
-const eslint_devkit_1 = require("@interlace/eslint-devkit");
-const eslint_devkit_2 = require("@interlace/eslint-devkit");
-const VALID_UTM_SOURCES = new Set([
-    'ofriperetz_dev',
-    'interlace',
-    'eslint_docs',
-    'serverless_docs',
-    'ds',
-    'storybook',
-    'devto',
-    'github',
-    'npm',
-    'x',
-    'linkedin',
-    'email',
-]);
-const VALID_UTM_MEDIUMS = new Set([
-    'article',
-    'blog',
-    'docs',
-    'landing',
-    'social',
-    'email',
-    'referral',
-    'cli',
-]);
-const UTM_PARAM_RE = /[?&](utm_source|utm_medium)=([^&#]+)/g;
-exports.utmTaxonomy = (0, eslint_devkit_1.createRule)({
-    name: 'utm-taxonomy',
-    meta: {
-        type: 'problem',
-        docs: {
-            url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/utm-taxonomy.md',
-            description: 'Validate utm_source and utm_medium values against the fixed taxonomy in UTM_PHILOSOPHY.md',
-        },
-        fixable: undefined,
-        hasSuggestions: false,
-        messages: {
-            invalidUtmSource: (0, eslint_devkit_2.formatLLMMessage)({
-                icon: eslint_devkit_2.MessageIcons.WARNING,
-                issueName: 'Invalid utm_source',
-                description: 'utm_source="{{value}}" is not in the fixed taxonomy. Allowed: {{allowed}}',
-                severity: 'HIGH',
-                fix: 'Use one of the allowed values, or extend the taxonomy in UTM_PHILOSOPHY.md and this rule together.',
-                documentationLink: 'https://github.com/ofri-peretz/eslint/blob/main/UTM_PHILOSOPHY.md',
-            }),
-            invalidUtmMedium: (0, eslint_devkit_2.formatLLMMessage)({
-                icon: eslint_devkit_2.MessageIcons.WARNING,
-                issueName: 'Invalid utm_medium',
-                description: 'utm_medium="{{value}}" is not in the fixed taxonomy. Allowed: {{allowed}}',
-                severity: 'HIGH',
-                fix: 'Use one of the allowed values, or extend the taxonomy in UTM_PHILOSOPHY.md and this rule together.',
-                documentationLink: 'https://github.com/ofri-peretz/eslint/blob/main/UTM_PHILOSOPHY.md',
-            }),
-        },
-        schema: [],
-    },
-    defaultOptions: [],
-    create(context) {
-        function checkString(node, value) {
-            UTM_PARAM_RE.lastIndex = 0;
-            let match;
-            while ((match = UTM_PARAM_RE.exec(value)) !== null) {
-                const [, key, raw] = match;
-                const decoded = decodeURIComponent(raw);
-                if (key === 'utm_source' && !VALID_UTM_SOURCES.has(decoded)) {
-                    context.report({
-                        node,
-                        messageId: 'invalidUtmSource',
-                        data: {
-                            value: decoded,
-                            allowed: [...VALID_UTM_SOURCES].join(', '),
-                        },
-                    });
-                }
-                else if (key === 'utm_medium' && !VALID_UTM_MEDIUMS.has(decoded)) {
-                    context.report({
-                        node,
-                        messageId: 'invalidUtmMedium',
-                        data: {
-                            value: decoded,
-                            allowed: [...VALID_UTM_MEDIUMS].join(', '),
-                        },
-                    });
-                }
-            }
-        }
-        return {
-            Literal(node) {
-                if (typeof node.value === 'string' && node.value.includes('utm_')) {
-                    checkString(node, node.value);
-                }
-            },
-            TemplateLiteral(node) {
-                for (const quasi of node.quasis) {
-                    if (quasi.value.cooked && quasi.value.cooked.includes('utm_')) {
-                        checkString(quasi, quasi.value.cooked);
-                    }
-                }
-            },
-        };
-    },
-});
+"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.utmTaxonomy=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const VALID_UTM_SOURCES=new Set(["ofriperetz_dev","interlace","eslint_docs","serverless_docs","ds","storybook","devto","github","npm","x","linkedin","email"]);const VALID_UTM_MEDIUMS=new Set(["article","blog","docs","landing","social","email","referral","cli"]);const UTM_PARAM_RE=/[?&](utm_source|utm_medium)=([^&#]+)/g;exports.utmTaxonomy=(0,eslint_devkit_1.createRule)({name:"utm-taxonomy",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/utm-taxonomy.md",description:"Validate utm_source and utm_medium values against the fixed taxonomy in UTM_PHILOSOPHY.md"},fixable:void 0,hasSuggestions:false,messages:{invalidUtmSource:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Invalid utm_source",description:'utm_source="{{value}}" is not in the fixed taxonomy. Allowed: {{allowed}}',severity:"HIGH",fix:"Use one of the allowed values, or extend the taxonomy in UTM_PHILOSOPHY.md and this rule together.",documentationLink:"https://github.com/ofri-peretz/eslint/blob/main/UTM_PHILOSOPHY.md"}),invalidUtmMedium:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Invalid utm_medium",description:'utm_medium="{{value}}" is not in the fixed taxonomy. Allowed: {{allowed}}',severity:"HIGH",fix:"Use one of the allowed values, or extend the taxonomy in UTM_PHILOSOPHY.md and this rule together.",documentationLink:"https://github.com/ofri-peretz/eslint/blob/main/UTM_PHILOSOPHY.md"})},schema:[]},defaultOptions:[],create(context){function checkString(node,value){UTM_PARAM_RE.lastIndex=0;let match;while((match=UTM_PARAM_RE.exec(value))!==null){const[,key,raw]=match;const decoded=decodeURIComponent(raw);if(key==="utm_source"&&!VALID_UTM_SOURCES.has(decoded)){context.report({node,messageId:"invalidUtmSource",data:{value:decoded,allowed:[...VALID_UTM_SOURCES].join(", ")}})}else if(key==="utm_medium"&&!VALID_UTM_MEDIUMS.has(decoded)){context.report({node,messageId:"invalidUtmMedium",data:{value:decoded,allowed:[...VALID_UTM_MEDIUMS].join(", ")}})}}}return{Literal(node){if(typeof node.value==="string"&&node.value.includes("utm_")){checkString(node,node.value)}},TemplateLiteral(node){for(const quasi of node.quasis){if(quasi.value.cooked&&quasi.value.cooked.includes("utm_")){checkString(quasi,quasi.value.cooked)}}}}}});