eslint-plugin-conventions 4.2.5 → 4.2.7

package/src/rules/conventions/no-json-schema-tags.js

@@ -1,159 +1 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.noJsonSchemaTags = void 0;
-const eslint_devkit_1 = require("@interlace/eslint-devkit");
-const DEFAULT_FORBIDDEN_TAGS = new Set([
-    'minimum',
-    'maximum',
-    'exclusiveMinimum',
-    'exclusiveMaximum',
-    'minLength',
-    'maxLength',
-    'minItems',
-    'maxItems',
-    'minProperties',
-    'maxProperties',
-    'multipleOf',
-    'pattern',
-    'uniqueItems',
-    'const',
-    'enum',
-    'format',
-    'contentMediaType',
-    'contentEncoding',
-]);
-function findForbiddenTags(commentText, forbiddenSet) {
-    const results = [];
-    const tagRegex = /@([a-zA-Z][a-zA-Z0-9]*)\b/g;
-    let match;
-    while ((match = tagRegex.exec(commentText)) !== null) {
-        const tagName = match[1];
-        if (forbiddenSet.has(tagName)) {
-            results.push({ tag: tagName, offset: match.index });
-        }
-    }
-    return results;
-}
-function getSuggestionText(tag) {
-    const suggestions = {
-        minimum: 'Include range in description, e.g. "(min: 1)" or "Range: 1-100"',
-        maximum: 'Include range in description, e.g. "(max: 100)" or "Range: 1-100"',
-        exclusiveMinimum: 'Include constraint in description, e.g. "(> 0)"',
-        exclusiveMaximum: 'Include constraint in description, e.g. "(< 100)"',
-        minLength: 'Include length constraint in description, e.g. "(min length: 1)"',
-        maxLength: 'Include length constraint in description, e.g. "(max length: 255)"',
-        minItems: 'Include item count in description, e.g. "(at least 1 item)"',
-        maxItems: 'Include item count in description, e.g. "(at most 10 items)"',
-        pattern: 'Include the expected format in description text',
-        enum: 'Use @typedef or list allowed values in description',
-        const: 'Use @default instead, or document the fixed value in description',
-        format: 'Describe the expected format in description, e.g. "(ISO 8601 date)"',
-    };
-    return (suggestions[tag] ||
-        'Move this constraint information into the description text');
-}
-exports.noJsonSchemaTags = (0, eslint_devkit_1.createRule)({
-    name: 'no-json-schema-tags',
-    meta: {
-        type: 'suggestion',
-        docs: {
-            url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/no-json-schema-tags.md',
-            description: 'Disallow JSON Schema keywords used as JSDoc tags (e.g. @minimum, @maximum)',
-        },
-        hasSuggestions: true,
-        messages: {
-            jsonSchemaTag: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.WARNING,
-                issueName: 'JSON Schema Tag in JSDoc',
-                description: '`@{{tag}}` is a JSON Schema keyword, not a valid JSDoc tag. It will cause CI failures in projects with strict tag validation (e.g. DefinitelyTyped). {{suggestion}}',
-                severity: 'MEDIUM',
-                fix: 'Remove the @{{tag}} tag and express the constraint in the description text instead',
-                documentationLink: 'https://jsdoc.app/about-block-inline-tags',
-            }),
-            moveToDescription: (0, eslint_devkit_1.formatLLMMessage)({
-                icon: eslint_devkit_1.MessageIcons.INFO,
-                issueName: 'Move to Description Text',
-                description: 'Remove the `@{{tag}}` tag and add the constraint directly to the description',
-                severity: 'LOW',
-                fix: 'Delete the @{{tag}} line and include the information in the type description',
-                documentationLink: 'https://jsdoc.app/about-block-inline-tags',
-            }),
-        },
-        schema: [
-            {
-                type: 'object',
-                properties: {
-                    additionalForbiddenTags: {
-                        type: 'array',
-                        items: { type: 'string' },
-                        default: [],
-                        description: 'Additional tag names to forbid',
-                    },
-                },
-                additionalProperties: false,
-            },
-        ],
-    },
-    defaultOptions: [{ additionalForbiddenTags: [] }],
-    create(context, [options = {}]) {
-        const { additionalForbiddenTags = [] } = options;
-        const forbiddenTags = new Set(DEFAULT_FORBIDDEN_TAGS);
-        for (const tag of additionalForbiddenTags) {
-            forbiddenTags.add(tag);
-        }
-        const sourceCode = context.sourceCode;
-        return {
-            Program() {
-                const comments = sourceCode.getAllComments();
-                for (const comment of comments) {
-                    if (comment.type !== 'Block') {
-                        continue;
-                    }
-                    const commentText = comment.value;
-                    const hits = findForbiddenTags(commentText, forbiddenTags);
-                    for (const { tag, offset } of hits) {
-                        const absoluteStart = comment
-                            .range[0] +
-                            2 +
-                            offset;
-                        const absoluteEnd = absoluteStart + 1 + tag.length;
-                        const suggestion = getSuggestionText(tag);
-                        context.report({
-                            loc: {
-                                start: sourceCode.getLocFromIndex(absoluteStart),
-                                end: sourceCode.getLocFromIndex(absoluteEnd),
-                            },
-                            messageId: 'jsonSchemaTag',
-                            data: {
-                                tag,
-                                suggestion,
-                            },
-                            suggest: [
-                                {
-                                    messageId: 'moveToDescription',
-                                    data: { tag },
-                                    fix: (fixer) => {
-                                        const fullSource = sourceCode.getText();
-                                        let lineStart = absoluteStart;
-                                        while (lineStart > 0 && fullSource[lineStart - 1] !== '\n') {
-                                            lineStart--;
-                                        }
-                                        let lineEnd = absoluteEnd;
-                                        while (lineEnd < fullSource.length &&
-                                            fullSource[lineEnd] !== '\n') {
-                                            lineEnd++;
-                                        }
-                                        if (lineEnd < fullSource.length && fullSource[lineEnd] === '\n') {
-                                            lineEnd++;
-                                        }
-                                        return fixer.removeRange([lineStart, lineEnd]);
-                                    },
-                                },
-                            ],
-                        });
-                    }
-                }
-            },
-        };
-    },
-});
+"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noJsonSchemaTags=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const DEFAULT_FORBIDDEN_TAGS=new Set(["minimum","maximum","exclusiveMinimum","exclusiveMaximum","minLength","maxLength","minItems","maxItems","minProperties","maxProperties","multipleOf","pattern","uniqueItems","const","enum","format","contentMediaType","contentEncoding"]);function findForbiddenTags(commentText,forbiddenSet){const results=[];const tagRegex=/@([a-zA-Z][a-zA-Z0-9]*)\b/g;let match;while((match=tagRegex.exec(commentText))!==null){const tagName=match[1];if(forbiddenSet.has(tagName)){results.push({tag:tagName,offset:match.index})}}return results}function getSuggestionText(tag){const suggestions={minimum:'Include range in description, e.g. "(min: 1)" or "Range: 1-100"',maximum:'Include range in description, e.g. "(max: 100)" or "Range: 1-100"',exclusiveMinimum:'Include constraint in description, e.g. "(> 0)"',exclusiveMaximum:'Include constraint in description, e.g. "(< 100)"',minLength:'Include length constraint in description, e.g. "(min length: 1)"',maxLength:'Include length constraint in description, e.g. "(max length: 255)"',minItems:'Include item count in description, e.g. "(at least 1 item)"',maxItems:'Include item count in description, e.g. "(at most 10 items)"',pattern:"Include the expected format in description text",enum:"Use @typedef or list allowed values in description",const:"Use @default instead, or document the fixed value in description",format:'Describe the expected format in description, e.g. "(ISO 8601 date)"'};return suggestions[tag]||"Move this constraint information into the description text"}exports.noJsonSchemaTags=(0,eslint_devkit_1.createRule)({name:"no-json-schema-tags",meta:{type:"suggestion",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/no-json-schema-tags.md",description:"Disallow JSON Schema keywords used as JSDoc tags (e.g. @minimum, @maximum)"},hasSuggestions:true,messages:{jsonSchemaTag:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.WARNING,issueName:"JSON Schema Tag in JSDoc",description:"`@{{tag}}` is a JSON Schema keyword, not a valid JSDoc tag. It will cause CI failures in projects with strict tag validation (e.g. DefinitelyTyped). {{suggestion}}",severity:"MEDIUM",fix:"Remove the @{{tag}} tag and express the constraint in the description text instead",documentationLink:"https://jsdoc.app/about-block-inline-tags"}),moveToDescription:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Move to Description Text",description:"Remove the `@{{tag}}` tag and add the constraint directly to the description",severity:"LOW",fix:"Delete the @{{tag}} line and include the information in the type description",documentationLink:"https://jsdoc.app/about-block-inline-tags"})},schema:[{type:"object",properties:{additionalForbiddenTags:{type:"array",items:{type:"string"},default:[],description:"Additional tag names to forbid"}},additionalProperties:false}]},defaultOptions:[{additionalForbiddenTags:[]}],create(context,[options={}]){const{additionalForbiddenTags=[]}=options;const forbiddenTags=new Set(DEFAULT_FORBIDDEN_TAGS);for(const tag of additionalForbiddenTags){forbiddenTags.add(tag)}const sourceCode=context.sourceCode;return{Program(){const comments=sourceCode.getAllComments();for(const comment of comments){if(comment.type!=="Block"){continue}const commentText=comment.value;const hits=findForbiddenTags(commentText,forbiddenTags);for(const{tag,offset}of hits){const absoluteStart=comment.range[0]+2+offset;const absoluteEnd=absoluteStart+1+tag.length;const suggestion=getSuggestionText(tag);context.report({loc:{start:sourceCode.getLocFromIndex(absoluteStart),end:sourceCode.getLocFromIndex(absoluteEnd)},messageId:"jsonSchemaTag",data:{tag,suggestion},suggest:[{messageId:"moveToDescription",data:{tag},fix:fixer=>{const fullSource=sourceCode.getText();let lineStart=absoluteStart;while(lineStart>0&&fullSource[lineStart-1]!=="\n"){lineStart--}let lineEnd=absoluteEnd;while(lineEnd<fullSource.length&&fullSource[lineEnd]!=="\n"){lineEnd++}if(lineEnd<fullSource.length&&fullSource[lineEnd]==="\n"){lineEnd++}return fixer.removeRange([lineStart,lineEnd])}}]})}}}}}});

package/src/rules/conventions/no-magic-numbers.js

@@ -1,185 +1,2 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.noMagicNumbers = void 0;
-const eslint_devkit_1 = require("@interlace/eslint-devkit");
-const eslint_devkit_2 = require("@interlace/eslint-devkit");
-const DEFAULT_IGNORE = new Set([-1, 0, 1, 2]);
-function constNameFor(value) {
-    const prefix = value < 0 ? 'MAGIC_NEG_' : 'MAGIC_';
-    const digits = String(Math.abs(value)).replace('.', '_');
-    return `${prefix}${digits}`;
-}
-function nearestStatement(node) {
-    const STATEMENT_TYPES = new Set([
-        'ExpressionStatement', 'VariableDeclaration', 'ReturnStatement',
-        'IfStatement', 'WhileStatement', 'ForStatement', 'ForInStatement',
-        'ForOfStatement', 'ThrowStatement', 'SwitchStatement',
-    ]);
-    let current = node.parent;
-    while (current) {
-        if (STATEMENT_TYPES.has(current.type))
-            return current;
-        current = current.parent;
-    }
-    return null;
-}
-exports.noMagicNumbers = (0, eslint_devkit_1.createRule)({
-    name: 'no-magic-numbers',
-    meta: {
-        type: 'suggestion',
-        docs: {
-            url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/no-magic-numbers.md',
-            description: 'Disallow magic numbers (numeric literals without a named constant)',
-        },
-        hasSuggestions: true,
-        messages: {
-            noMagicNumber: (0, eslint_devkit_2.formatLLMMessage)({
-                icon: eslint_devkit_2.MessageIcons.INFO,
-                issueName: 'Magic Number',
-                description: 'The number {{value}} is a magic literal. Extract it to a named constant to make the intent clear.',
-                severity: 'LOW',
-                fix: 'const TIMEOUT_MS = {{value}}; // use the named constant everywhere',
-                documentationLink: 'https://refactoring.guru/replace-magic-literal',
-            }),
-            extractConst: 'Extract {{value}} to a named constant ({{constName}})',
-        },
-        schema: [
-            {
-                type: 'object',
-                properties: {
-                    ignore: {
-                        type: 'array',
-                        items: { type: 'number' },
-                        description: 'Additional numbers to allow',
-                    },
-                    ignoreArrayIndexes: { type: 'boolean', default: true },
-                    ignoreDefaultValues: { type: 'boolean', default: true },
-                    ignoreEnums: { type: 'boolean', default: true },
-                    ignoreBitwiseExpressions: { type: 'boolean', default: false },
-                },
-                additionalProperties: false,
-            },
-        ],
-    },
-    defaultOptions: [
-        {
-            ignore: [],
-            ignoreArrayIndexes: true,
-            ignoreDefaultValues: true,
-            ignoreEnums: true,
-            ignoreBitwiseExpressions: false,
-        },
-    ],
-    create(context) {
-        const [options = {}] = context.options;
-        const { ignore = [], ignoreArrayIndexes = true, ignoreDefaultValues = true, ignoreEnums = true, ignoreBitwiseExpressions = false, } = options;
-        const ignoredValues = new Set([...DEFAULT_IGNORE, ...ignore]);
-        function isIgnoredNumber(value) {
-            return ignoredValues.has(value);
-        }
-        function isArrayIndex(node) {
-            if (!ignoreArrayIndexes)
-                return false;
-            const parent = node.parent;
-            return (parent?.type === 'MemberExpression' &&
-                parent.computed &&
-                parent.property === node);
-        }
-        function isDefaultValue(node) {
-            if (!ignoreDefaultValues)
-                return false;
-            const parent = node.parent;
-            return (parent?.type === 'AssignmentPattern' &&
-                parent.right === node);
-        }
-        function isEnumMember(node) {
-            if (!ignoreEnums)
-                return false;
-            const parent = node.parent;
-            return parent?.type === 'TSEnumMember';
-        }
-        function isBitwiseContext(node) {
-            if (!ignoreBitwiseExpressions)
-                return false;
-            const parent = node.parent;
-            const BITWISE_OPS = new Set(['&', '|', '^', '<<', '>>', '>>>']);
-            return (parent?.type === 'BinaryExpression' &&
-                BITWISE_OPS.has(parent.operator));
-        }
-        function isVariableDeclarator(node) {
-            const parent = node.parent;
-            return parent?.type === 'VariableDeclarator';
-        }
-        function isExportedConst(node) {
-            let current = node;
-            while (current) {
-                if (current.type === 'ExportNamedDeclaration')
-                    return true;
-                if (current.type === 'VariableDeclaration' ||
-                    current.type === 'VariableDeclarator') {
-                    current = current.parent;
-                    continue;
-                }
-                break;
-            }
-            return false;
-        }
-        function isPropertyKey(node) {
-            const parent = node.parent;
-            return (parent?.type === 'Property' &&
-                parent.key === node);
-        }
-        return {
-            Literal(node) {
-                if (typeof node.value !== 'number')
-                    return;
-                const value = node.value;
-                if (isIgnoredNumber(value))
-                    return;
-                if (!isFinite(value))
-                    return;
-                if (isVariableDeclarator(node))
-                    return;
-                if (isExportedConst(node))
-                    return;
-                if (isArrayIndex(node))
-                    return;
-                if (isDefaultValue(node))
-                    return;
-                if (isEnumMember(node))
-                    return;
-                if (isBitwiseContext(node))
-                    return;
-                if (isPropertyKey(node))
-                    return;
-                const constName = constNameFor(value);
-                const sourceCode = context.sourceCode;
-                context.report({
-                    node,
-                    messageId: 'noMagicNumber',
-                    data: { value: String(value) },
-                    suggest: [
-                        {
-                            messageId: 'extractConst',
-                            data: { value: String(value), constName },
-                            fix(fixer) {
-                                const stmt = nearestStatement(node);
-                                if (!stmt)
-                                    return null;
-                                const firstToken = sourceCode.getFirstToken(stmt);
-                                if (!firstToken)
-                                    return null;
-                                const col = firstToken.loc.start.column;
-                                const indent = ' '.repeat(col);
-                                return [
-                                    fixer.insertTextBefore(stmt, `const ${constName} = ${value};\n${indent}`),
-                                    fixer.replaceText(node, constName),
-                                ];
-                            },
-                        },
-                    ],
-                });
-            },
-        };
-    },
-});
+"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noMagicNumbers=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const DEFAULT_IGNORE=new Set([-1,0,1,2]);function constNameFor(value){const prefix=value<0?"MAGIC_NEG_":"MAGIC_";const digits=String(Math.abs(value)).replace(".","_");return`${prefix}${digits}`}function nearestStatement(node){const STATEMENT_TYPES=new Set(["ExpressionStatement","VariableDeclaration","ReturnStatement","IfStatement","WhileStatement","ForStatement","ForInStatement","ForOfStatement","ThrowStatement","SwitchStatement"]);let current=node.parent;while(current){if(STATEMENT_TYPES.has(current.type))return current;current=current.parent}return null}exports.noMagicNumbers=(0,eslint_devkit_1.createRule)({name:"no-magic-numbers",meta:{type:"suggestion",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/no-magic-numbers.md",description:"Disallow magic numbers (numeric literals without a named constant)"},hasSuggestions:true,messages:{noMagicNumber:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Magic Number",description:"The number {{value}} is a magic literal. Extract it to a named constant to make the intent clear.",severity:"LOW",fix:"const TIMEOUT_MS = {{value}}; // use the named constant everywhere",documentationLink:"https://refactoring.guru/replace-magic-literal"}),extractConst:"Extract {{value}} to a named constant ({{constName}})"},schema:[{type:"object",properties:{ignore:{type:"array",items:{type:"number"},description:"Additional numbers to allow"},ignoreArrayIndexes:{type:"boolean",default:true},ignoreDefaultValues:{type:"boolean",default:true},ignoreEnums:{type:"boolean",default:true},ignoreBitwiseExpressions:{type:"boolean",default:false}},additionalProperties:false}]},defaultOptions:[{ignore:[],ignoreArrayIndexes:true,ignoreDefaultValues:true,ignoreEnums:true,ignoreBitwiseExpressions:false}],create(context){const[options={}]=context.options;const{ignore=[],ignoreArrayIndexes=true,ignoreDefaultValues=true,ignoreEnums=true,ignoreBitwiseExpressions=false}=options;const ignoredValues=new Set([...DEFAULT_IGNORE,...ignore]);function isIgnoredNumber(value){return ignoredValues.has(value)}function isArrayIndex(node){if(!ignoreArrayIndexes)return false;const parent=node.parent;return parent?.type==="MemberExpression"&&parent.computed&&parent.property===node}function isDefaultValue(node){if(!ignoreDefaultValues)return false;const parent=node.parent;return parent?.type==="AssignmentPattern"&&parent.right===node}function isEnumMember(node){if(!ignoreEnums)return false;const parent=node.parent;return parent?.type==="TSEnumMember"}function isBitwiseContext(node){if(!ignoreBitwiseExpressions)return false;const parent=node.parent;const BITWISE_OPS=new Set(["&","|","^","<<",">>",">>>"]);return parent?.type==="BinaryExpression"&&BITWISE_OPS.has(parent.operator)}function isVariableDeclarator(node){const parent=node.parent;return parent?.type==="VariableDeclarator"}function isExportedConst(node){let current=node;while(current){if(current.type==="ExportNamedDeclaration")return true;if(current.type==="VariableDeclaration"||current.type==="VariableDeclarator"){current=current.parent;continue}break}return false}function isPropertyKey(node){const parent=node.parent;return parent?.type==="Property"&&parent.key===node}return{Literal(node){if(typeof node.value!=="number")return;const value=node.value;if(isIgnoredNumber(value))return;if(!isFinite(value))return;if(isVariableDeclarator(node))return;if(isExportedConst(node))return;if(isArrayIndex(node))return;if(isDefaultValue(node))return;if(isEnumMember(node))return;if(isBitwiseContext(node))return;if(isPropertyKey(node))return;const constName=constNameFor(value);const sourceCode=context.sourceCode;context.report({node,messageId:"noMagicNumber",data:{value:String(value)},suggest:[{messageId:"extractConst",data:{value:String(value),constName},fix(fixer){const stmt=nearestStatement(node);if(!stmt)return null;const firstToken=sourceCode.getFirstToken(stmt);if(!firstToken)return null;const col=firstToken.loc.start.column;const indent=" ".repeat(col);return[fixer.insertTextBefore(stmt,`const ${constName} = ${value};
+${indent}`),fixer.replaceText(node,constName)]}}]})}}}});

package/src/rules/conventions/no-raw-cross-property-href.js

@@ -1,76 +1 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.noRawCrossPropertyHref = void 0;
-const eslint_devkit_1 = require("@interlace/eslint-devkit");
-const eslint_devkit_2 = require("@interlace/eslint-devkit");
-const CROSS_PROPERTY_HOSTS = new Set([
-    'ofriperetz.dev',
-    'interlace.tools',
-    'eslint.interlace.tools',
-    'serverless.interlace.tools',
-    'ds.interlace.tools',
-    'storybook.interlace.tools',
-]);
-exports.noRawCrossPropertyHref = (0, eslint_devkit_1.createRule)({
-    name: 'no-raw-cross-property-href',
-    meta: {
-        type: 'problem',
-        docs: {
-            url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/no-raw-cross-property-href.md',
-            description: 'Forbid hand-written cross-property hrefs; use buildUtmHref() from lib/utm.ts',
-        },
-        fixable: undefined,
-        hasSuggestions: false,
-        messages: {
-            rawCrossPropertyHref: (0, eslint_devkit_2.formatLLMMessage)({
-                icon: eslint_devkit_2.MessageIcons.WARNING,
-                issueName: 'Raw cross-property href',
-                description: 'href "{{href}}" points to a cross-property surface ({{host}}). Use buildUtmHref() from lib/utm.ts so the link carries UTM and ph_distinct_id.',
-                severity: 'HIGH',
-                fix: 'Replace with buildUtmHref(\'{{href}}\', { source, medium, campaign, content }).',
-                documentationLink: 'https://github.com/ofri-peretz/eslint/blob/main/UTM_PHILOSOPHY.md',
-            }),
-        },
-        schema: [],
-    },
-    defaultOptions: [],
-    create(context) {
-        function parseHost(value) {
-            if (!/^https?:\/\//i.test(value))
-                return null;
-            try {
-                return new URL(value).hostname.toLowerCase();
-            }
-            catch {
-                return null;
-            }
-        }
-        function isCrossPropertyHref(href) {
-            const host = parseHost(href);
-            if (!host)
-                return null;
-            if (!CROSS_PROPERTY_HOSTS.has(host))
-                return null;
-            return { host };
-        }
-        return {
-            JSXAttribute(node) {
-                if (node.name.type !== 'JSXIdentifier' ||
-                    node.name.name !== 'href' ||
-                    !node.value ||
-                    node.value.type !== 'Literal' ||
-                    typeof node.value.value !== 'string') {
-                    return;
-                }
-                const result = isCrossPropertyHref(node.value.value);
-                if (!result)
-                    return;
-                context.report({
-                    node: node.value,
-                    messageId: 'rawCrossPropertyHref',
-                    data: { href: node.value.value, host: result.host },
-                });
-            },
-        };
-    },
-});
+"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noRawCrossPropertyHref=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const CROSS_PROPERTY_HOSTS=new Set(["ofriperetz.dev","interlace.tools","eslint.interlace.tools","serverless.interlace.tools","ds.interlace.tools","storybook.interlace.tools"]);exports.noRawCrossPropertyHref=(0,eslint_devkit_1.createRule)({name:"no-raw-cross-property-href",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/no-raw-cross-property-href.md",description:"Forbid hand-written cross-property hrefs; use buildUtmHref() from lib/utm.ts"},fixable:void 0,hasSuggestions:false,messages:{rawCrossPropertyHref:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Raw cross-property href",description:'href "{{href}}" points to a cross-property surface ({{host}}). Use buildUtmHref() from lib/utm.ts so the link carries UTM and ph_distinct_id.',severity:"HIGH",fix:"Replace with buildUtmHref('{{href}}', { source, medium, campaign, content }).",documentationLink:"https://github.com/ofri-peretz/eslint/blob/main/UTM_PHILOSOPHY.md"})},schema:[]},defaultOptions:[],create(context){function parseHost(value){if(!/^https?:\/\//i.test(value))return null;try{return new URL(value).hostname.toLowerCase()}catch{return null}}function isCrossPropertyHref(href){const host=parseHost(href);if(!host)return null;if(!CROSS_PROPERTY_HOSTS.has(host))return null;return{host}}return{JSXAttribute(node){if(node.name.type!=="JSXIdentifier"||node.name.name!=="href"||!node.value||node.value.type!=="Literal"||typeof node.value.value!=="string"){return}const result=isCrossPropertyHref(node.value.value);if(!result)return;context.report({node:node.value,messageId:"rawCrossPropertyHref",data:{href:node.value.value,host:result.host}})}}}});

package/src/rules/conventions/prefer-code-point.js

@@ -1,80 +1 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.preferCodePoint = void 0;
-const eslint_devkit_1 = require("@interlace/eslint-devkit");
-const eslint_devkit_2 = require("@interlace/eslint-devkit");
-exports.preferCodePoint = (0, eslint_devkit_1.createRule)({
-    name: 'prefer-code-point',
-    meta: {
-        type: 'suggestion',
-        docs: {
-            url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/prefer-code-point.md',
-            description: 'Prefer codePointAt over charCodeAt for proper Unicode character handling',
-        },
-        messages: {
-            preferCodePoint: (0, eslint_devkit_2.formatLLMMessage)({
-                icon: eslint_devkit_2.MessageIcons.WARNING,
-                issueName: 'Prefer codePointAt',
-                description: 'Use codePointAt instead of charCodeAt for Unicode safety',
-                severity: 'MEDIUM',
-                fix: 'Replace charCodeAt() with codePointAt()',
-                documentationLink: 'https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-code-point.md',
-            }),
-        },
-        schema: [
-            {
-                type: 'object',
-                properties: {},
-                additionalProperties: false,
-            },
-        ],
-    },
-    defaultOptions: [],
-    create(context) {
-        function isInAllowedContext(node) {
-            return false;
-        }
-        function shouldIgnoreCall(node) {
-            if (node.callee.type === 'MemberExpression') {
-                if (node.callee.optional) {
-                    return true;
-                }
-                if (node.callee.computed &&
-                    node.callee.property.type === 'Identifier') {
-                    return true;
-                }
-            }
-            return false;
-        }
-        function isCharCodeAtCall(node) {
-            if (node.callee.type === 'MemberExpression') {
-                if (node.callee.property.type === 'Identifier' &&
-                    node.callee.property.name === 'charCodeAt') {
-                    return true;
-                }
-                if (node.callee.computed &&
-                    node.callee.property.type === 'Literal' &&
-                    node.callee.property.value === 'charCodeAt') {
-                    return true;
-                }
-            }
-            return false;
-        }
-        return {
-            CallExpression(node) {
-                if (isCharCodeAtCall(node) &&
-                    !isInAllowedContext(node) &&
-                    !shouldIgnoreCall(node)) {
-                    context.report({
-                        node,
-                        messageId: 'preferCodePoint',
-                        data: {
-                            current: 'charCodeAt()',
-                            fix: 'codePointAt()',
-                        },
-                    });
-                }
-            },
-        };
-    },
-});
+"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.preferCodePoint=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");exports.preferCodePoint=(0,eslint_devkit_1.createRule)({name:"prefer-code-point",meta:{type:"suggestion",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/prefer-code-point.md",description:"Prefer codePointAt over charCodeAt for proper Unicode character handling"},messages:{preferCodePoint:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Prefer codePointAt",description:"Use codePointAt instead of charCodeAt for Unicode safety",severity:"MEDIUM",fix:"Replace charCodeAt() with codePointAt()",documentationLink:"https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-code-point.md"})},schema:[{type:"object",properties:{},additionalProperties:false}]},defaultOptions:[],create(context){function isInAllowedContext(node){return false}function shouldIgnoreCall(node){if(node.callee.type==="MemberExpression"){if(node.callee.optional){return true}if(node.callee.computed&&node.callee.property.type==="Identifier"){return true}}return false}function isCharCodeAtCall(node){if(node.callee.type==="MemberExpression"){if(node.callee.property.type==="Identifier"&&node.callee.property.name==="charCodeAt"){return true}if(node.callee.computed&&node.callee.property.type==="Literal"&&node.callee.property.value==="charCodeAt"){return true}}return false}return{CallExpression(node){if(isCharCodeAtCall(node)&&!isInAllowedContext(node)&&!shouldIgnoreCall(node)){context.report({node,messageId:"preferCodePoint",data:{current:"charCodeAt()",fix:"codePointAt()"}})}}}}});