eslint-plugin-conventions 4.0.7 → 4.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +131 -0
- package/LICENSE +23 -0
- package/README.md +51 -21
- package/package.json +20 -3
- package/src/index.d.ts +49 -0
- package/src/index.js +15 -1
- package/src/index.js.map +1 -1
- package/src/lib/eslint-plugin-conventions.js.map +1 -1
- package/src/oxlint.d.ts +20 -0
- package/src/oxlint.js +22 -0
- package/src/oxlint.js.map +1 -0
- package/src/rules/conventions/analytics-event-naming.d.ts +41 -0
- package/src/rules/conventions/analytics-event-naming.js +104 -0
- package/src/rules/conventions/analytics-event-naming.js.map +1 -0
- package/src/rules/conventions/consistent-existence-index-check.js +5 -1
- package/src/rules/conventions/consistent-existence-index-check.js.map +1 -1
- package/src/rules/conventions/expiring-todo-comments.js +18 -2
- package/src/rules/conventions/expiring-todo-comments.js.map +1 -1
- package/src/rules/conventions/filename-case.js +9 -1
- package/src/rules/conventions/filename-case.js.map +1 -1
- package/src/rules/conventions/no-commented-code.js +3 -2
- package/src/rules/conventions/no-commented-code.js.map +1 -1
- package/src/rules/conventions/no-console-spaces.js +5 -0
- package/src/rules/conventions/no-console-spaces.js.map +1 -1
- package/src/rules/conventions/no-json-schema-tags.js +2 -1
- package/src/rules/conventions/no-json-schema-tags.js.map +1 -1
- package/src/rules/conventions/no-magic-numbers.d.ts +41 -0
- package/src/rules/conventions/no-magic-numbers.js +205 -0
- package/src/rules/conventions/no-magic-numbers.js.map +1 -0
- package/src/rules/conventions/no-raw-cross-property-href.d.ts +24 -0
- package/src/rules/conventions/no-raw-cross-property-href.js +86 -0
- package/src/rules/conventions/no-raw-cross-property-href.js.map +1 -0
- package/src/rules/conventions/prefer-code-point.js +4 -1
- package/src/rules/conventions/prefer-code-point.js.map +1 -1
- package/src/rules/conventions/prefer-dependency-version-strategy.d.ts +5 -5
- package/src/rules/conventions/prefer-dependency-version-strategy.js +1 -0
- package/src/rules/conventions/prefer-dependency-version-strategy.js.map +1 -1
- package/src/rules/conventions/prefer-dom-node-text-content.js +3 -0
- package/src/rules/conventions/prefer-dom-node-text-content.js.map +1 -1
- package/src/rules/conventions/require-data-testid.d.ts +56 -0
- package/src/rules/conventions/require-data-testid.js +209 -0
- package/src/rules/conventions/require-data-testid.js.map +1 -0
- package/src/rules/conventions/utm-taxonomy.d.ts +25 -0
- package/src/rules/conventions/utm-taxonomy.js +113 -0
- package/src/rules/conventions/utm-taxonomy.js.map +1 -0
- package/src/rules/deprecation/no-deprecated-api.js +4 -0
- package/src/rules/deprecation/no-deprecated-api.js.map +1 -1
|
@@ -0,0 +1,104 @@
|
|
|
1
|
+
"use strict";
|
|
2
|
+
/**
|
|
3
|
+
* Copyright (c) 2025 Ofri Peretz
|
|
4
|
+
* Licensed under the MIT License. Use of this source code is governed by the
|
|
5
|
+
* MIT license that can be found in the LICENSE file.
|
|
6
|
+
*/
|
|
7
|
+
Object.defineProperty(exports, "__esModule", { value: true });
|
|
8
|
+
exports.analyticsEventNaming = void 0;
|
|
9
|
+
const eslint_devkit_1 = require("@interlace/eslint-devkit");
|
|
10
|
+
const eslint_devkit_2 = require("@interlace/eslint-devkit");
|
|
11
|
+
// ANALYTICS_PHILOSOPHY.md principle 4 → fixed verb list. Edit there and
|
|
12
|
+
// here together.
|
|
13
|
+
const ACTION_VERBS = [
|
|
14
|
+
'click',
|
|
15
|
+
'submit',
|
|
16
|
+
'view',
|
|
17
|
+
'add',
|
|
18
|
+
'remove',
|
|
19
|
+
'start',
|
|
20
|
+
'end',
|
|
21
|
+
'generate',
|
|
22
|
+
'send',
|
|
23
|
+
'cancel',
|
|
24
|
+
'fail',
|
|
25
|
+
'create',
|
|
26
|
+
'delete',
|
|
27
|
+
'update',
|
|
28
|
+
'invite',
|
|
29
|
+
].join('|');
|
|
30
|
+
const EVENT_NAME_RE = new RegExp(`^[a-z][a-z0-9_]*:[a-z][a-z0-9_]*_(${ACTION_VERBS})$|^\\$[a-z_]+$`);
|
|
31
|
+
exports.analyticsEventNaming = (0, eslint_devkit_1.createRule)({
|
|
32
|
+
name: 'analytics-event-naming',
|
|
33
|
+
meta: {
|
|
34
|
+
type: 'problem',
|
|
35
|
+
docs: {
|
|
36
|
+
url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/analytics-event-naming.md',
|
|
37
|
+
description: 'Analytics event names (track/capture) must follow ANALYTICS_PHILOSOPHY.md principle 4: lowercase snake_case, category:object_action, fixed verb list',
|
|
38
|
+
},
|
|
39
|
+
fixable: undefined,
|
|
40
|
+
hasSuggestions: false,
|
|
41
|
+
messages: {
|
|
42
|
+
invalidEventName: (0, eslint_devkit_2.formatLLMMessage)({
|
|
43
|
+
icon: eslint_devkit_2.MessageIcons.WARNING,
|
|
44
|
+
issueName: 'Invalid analytics event name',
|
|
45
|
+
description: 'Event "{{name}}" does not match category:object_action grammar (lowercase snake_case, action from fixed verb list).',
|
|
46
|
+
severity: 'HIGH',
|
|
47
|
+
fix: 'Rename to match `<category>:<object>_<verb>` where verb ∈ {click, submit, view, add, remove, start, end, generate, send, cancel, fail, create, delete, update, invite}. Vendor reserved events ($pageview, $set, …) are exempt.',
|
|
48
|
+
documentationLink: 'https://github.com/ofri-peretz/eslint/blob/main/ANALYTICS_PHILOSOPHY.md',
|
|
49
|
+
}),
|
|
50
|
+
interpolatedEventName: (0, eslint_devkit_2.formatLLMMessage)({
|
|
51
|
+
icon: eslint_devkit_2.MessageIcons.WARNING,
|
|
52
|
+
issueName: 'Interpolated analytics event name',
|
|
53
|
+
description: 'Event names must be static string literals. Template literals create an unbounded catalog (ANALYTICS_PHILOSOPHY.md principle 3).',
|
|
54
|
+
severity: 'HIGH',
|
|
55
|
+
fix: 'Move the dynamic part into an event property: track(\'category:object_view\', { slug }).',
|
|
56
|
+
documentationLink: 'https://github.com/ofri-peretz/eslint/blob/main/ANALYTICS_PHILOSOPHY.md',
|
|
57
|
+
}),
|
|
58
|
+
},
|
|
59
|
+
schema: [],
|
|
60
|
+
},
|
|
61
|
+
defaultOptions: [],
|
|
62
|
+
create(context) {
|
|
63
|
+
function isCaptureLike(node) {
|
|
64
|
+
// <obj>.capture(...) — PostHog
|
|
65
|
+
// <obj>.track(...) — Segment / Mixpanel / Amplitude
|
|
66
|
+
if (node.callee.type === 'MemberExpression' &&
|
|
67
|
+
node.callee.property.type === 'Identifier' &&
|
|
68
|
+
(node.callee.property.name === 'capture' ||
|
|
69
|
+
node.callee.property.name === 'track')) {
|
|
70
|
+
return true;
|
|
71
|
+
}
|
|
72
|
+
// bare track(...) — our primitive
|
|
73
|
+
if (node.callee.type === 'Identifier' &&
|
|
74
|
+
node.callee.name === 'track') {
|
|
75
|
+
return true;
|
|
76
|
+
}
|
|
77
|
+
return false;
|
|
78
|
+
}
|
|
79
|
+
return {
|
|
80
|
+
CallExpression(node) {
|
|
81
|
+
if (!isCaptureLike(node) || node.arguments.length === 0)
|
|
82
|
+
return;
|
|
83
|
+
const first = node.arguments[0];
|
|
84
|
+
if (first.type === 'Literal' && typeof first.value === 'string') {
|
|
85
|
+
if (!EVENT_NAME_RE.test(first.value)) {
|
|
86
|
+
context.report({
|
|
87
|
+
node: first,
|
|
88
|
+
messageId: 'invalidEventName',
|
|
89
|
+
data: { name: first.value },
|
|
90
|
+
});
|
|
91
|
+
}
|
|
92
|
+
return;
|
|
93
|
+
}
|
|
94
|
+
if (first.type === 'TemplateLiteral' && first.expressions.length > 0) {
|
|
95
|
+
context.report({
|
|
96
|
+
node: first,
|
|
97
|
+
messageId: 'interpolatedEventName',
|
|
98
|
+
});
|
|
99
|
+
}
|
|
100
|
+
},
|
|
101
|
+
};
|
|
102
|
+
},
|
|
103
|
+
});
|
|
104
|
+
//# sourceMappingURL=analytics-event-naming.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"analytics-event-naming.js","sourceRoot":"","sources":["../../../../src/rules/conventions/analytics-event-naming.ts"],"names":[],"mappings":";AAAA;;;;GAIG;;;AAiCH,4DAAsD;AACtD,4DAA0E;AAK1E,wEAAwE;AACxE,iBAAiB;AACjB,MAAM,YAAY,GAAG;IACnB,OAAO;IACP,QAAQ;IACR,MAAM;IACN,KAAK;IACL,QAAQ;IACR,OAAO;IACP,KAAK;IACL,UAAU;IACV,MAAM;IACN,QAAQ;IACR,MAAM;IACN,QAAQ;IACR,QAAQ;IACR,QAAQ;IACR,QAAQ;CACT,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;AAEZ,MAAM,aAAa,GAAG,IAAI,MAAM,CAC9B,qCAAqC,YAAY,iBAAiB,CACnE,CAAC;AAEW,QAAA,oBAAoB,GAAG,IAAA,0BAAU,EAA0B;IACtE,IAAI,EAAE,wBAAwB;IAC9B,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,GAAG,EAAE,yHAAyH;YAC9H,WAAW,EACT,sJAAsJ;SACzJ;QACD,OAAO,EAAE,SAAS;QAClB,cAAc,EAAE,KAAK;QACrB,QAAQ,EAAE;YACR,gBAAgB,EAAE,IAAA,gCAAgB,EAAC;gBACjC,IAAI,EAAE,4BAAY,CAAC,OAAO;gBAC1B,SAAS,EAAE,8BAA8B;gBACzC,WAAW,EACT,qHAAqH;gBACvH,QAAQ,EAAE,MAAM;gBAChB,GAAG,EAAE,iOAAiO;gBACtO,iBAAiB,EACf,yEAAyE;aAC5E,CAAC;YACF,qBAAqB,EAAE,IAAA,gCAAgB,EAAC;gBACtC,IAAI,EAAE,4BAAY,CAAC,OAAO;gBAC1B,SAAS,EAAE,mCAAmC;gBAC9C,WAAW,EACT,kIAAkI;gBACpI,QAAQ,EAAE,MAAM;gBAChB,GAAG,EAAE,0FAA0F;gBAC/F,iBAAiB,EACf,yEAAyE;aAC5E,CAAC;SACH;QACD,MAAM,EAAE,EAAE;KACX;IACD,cAAc,EAAE,EAAE;IAElB,MAAM,CAAC,OAAsD;QAC3D,SAAS,aAAa,CAAC,IAA6B;YAClD,+BAA+B;YAC/B,sDAAsD;YACtD,IACE,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;gBACvC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY;gBAC1C,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,SAAS;oBACtC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,OAAO,CAAC,EACxC,CAAC;gBACD,OAAO,IAAI,CAAC;YACd,CAAC;YACD,kCAAkC;YAClC,IACE,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY;gBACjC,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,OAAO,EAC5B,CAAC;gBACD,OAAO,IAAI,CAAC;YACd,CAAC;YACD,OAAO,KAAK,CAAC;QACf,CAAC;QAED,OAAO;YACL,cAAc,CAAC,IAA6B;gBAC1C,IAAI,CAAC,aAAa,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC;oBAAE,OAAO;gBAChE,MAAM,KAAK,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;gBAChC,IAAI,KAAK,CAAC,IAAI,KAAK,SAAS,IAAI,OAAO,KAAK,CAAC,KAAK,KAAK,QAAQ,EAAE,CAAC;oBAChE,IAAI,CAAC,aAAa,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC;wBACrC,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI,EAAE,KAAK;4BACX,SAAS,EAAE,kBAAkB;4BAC7B,IAAI,EAAE,EAAE,IAAI,EAAE,KAAK,CAAC,KAAK,EAAE;yBAC5B,CAAC,CAAC;oBACL,CAAC;oBACD,OAAO;gBACT,CAAC;gBACD,IAAI,KAAK,CAAC,IAAI,KAAK,iBAAiB,IAAI,KAAK,CAAC,WAAW,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;oBACrE,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,KAAK;wBACX,SAAS,EAAE,uBAAuB;qBACnC,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC"}
|
|
@@ -13,6 +13,7 @@ exports.consistentExistenceIndexCheck = (0, eslint_devkit_1.createRule)({
|
|
|
13
13
|
meta: {
|
|
14
14
|
type: 'suggestion',
|
|
15
15
|
docs: {
|
|
16
|
+
url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/consistent-existence-index-check.md',
|
|
16
17
|
description: 'Enforce consistent style for checking object property existence',
|
|
17
18
|
},
|
|
18
19
|
fixable: 'code',
|
|
@@ -94,7 +95,10 @@ exports.consistentExistenceIndexCheck = (0, eslint_devkit_1.createRule)({
|
|
|
94
95
|
return {
|
|
95
96
|
// Check for hasOwnProperty calls
|
|
96
97
|
CallExpression(node) {
|
|
97
|
-
// Direct hasOwnProperty calls: obj.hasOwnProperty(prop)
|
|
98
|
+
// Direct hasOwnProperty calls: obj.hasOwnProperty(prop). Reindented
|
|
99
|
+
// to match the sibling `if` blocks below — the original 6-space
|
|
100
|
+
// indent here suggested this branch was at a different scope level
|
|
101
|
+
// (CodeQL: `js/misleading-indentation-after-control-statement`).
|
|
98
102
|
if (node.callee.type === 'MemberExpression' &&
|
|
99
103
|
node.callee.property.type === 'Identifier' &&
|
|
100
104
|
node.callee.property.name === 'hasOwnProperty' &&
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"consistent-existence-index-check.js","sourceRoot":"","sources":["
|
|
1
|
+
{"version":3,"file":"consistent-existence-index-check.js","sourceRoot":"","sources":["../../../../src/rules/conventions/consistent-existence-index-check.ts"],"names":[],"mappings":";AAAA;;;;GAIG;;;AAOH,4DAAsD;AACtD,4DAA0E;AAW7D,QAAA,6BAA6B,GAAG,IAAA,0BAAU,EAA0B;IAC/E,IAAI,EAAE,kCAAkC;IACxC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,GAAG,EAAE,mIAAmI;YACxI,WAAW,EACT,iEAAiE;SACpE;QACD,OAAO,EAAE,MAAM;QACf,cAAc,EAAE,IAAI;QACpB,QAAQ,EAAE;YACR,wBAAwB,EAAE,IAAA,gCAAgB,EAAC;gBACzC,IAAI,EAAE,4BAAY,CAAC,OAAO;gBAC1B,SAAS,EAAE,6BAA6B;gBACxC,WAAW,EAAE,qDAAqD;gBAClE,QAAQ,EAAE,QAAQ;gBAClB,GAAG,EAAE,kEAAkE;gBACvE,iBAAiB,EAAE,gFAAgF;aACpG,CAAC;SACH;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,SAAS,EAAE;wBACT,IAAI,EAAE,QAAQ;wBACd,IAAI,EAAE,CAAC,IAAI,EAAE,gBAAgB,EAAE,eAAe,CAAC;wBAC/C,OAAO,EAAE,IAAI;qBACd;iBACF;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;KACF;IACD,cAAc,EAAE,CAAC,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC;IAErC,MAAM,CAAC,OAAsD;QAC3D,MAAM,CAAC,OAAO,CAAC,GAAG,OAAO,CAAC,OAAO,CAAC;QAClC,MAAM,EAAE,SAAS,GAAG,IAAI,EAAE,GAAG,OAAO,IAAI,EAAE,CAAC;QAE3C,SAAS,uBAAuB,CAAC,IAAmB,EAAE,aAAqB,EAAE,MAAqB,EAAE,QAAuB;YACzH,IAAI,GAA2C,CAAC;YAEhD,qFAAqF;YACrF,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC;YAC3B,MAAM,sBAAsB,GAAG,CAAC,MAAM;gBACpC,MAAM,CAAC,IAAI,KAAK,qBAAqB;gBACrC,CAAC,MAAM,CAAC,IAAI,KAAK,oBAAoB,IAAI,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC;gBAC9D,CAAC,MAAM,CAAC,IAAI,KAAK,sBAAsB,IAAI,MAAM,CAAC,KAAK,KAAK,IAAI,CAAC;gBACjE,CAAC,MAAM,CAAC,IAAI,KAAK,iBAAiB,IAAI,MAAM,CAAC,QAAQ,KAAK,IAAI,CAAC;gBAC/D,CAAC,MAAM,CAAC,IAAI,KAAK,yBAAyB,IAAI,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC;gBACnE,CAAC,MAAM,CAAC,IAAI,KAAK,aAAa,IAAI,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC;gBACvD,CAAC,MAAM,CAAC,IAAI,KAAK,gBAAgB,IAAI,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC;gBAC1D,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB,IAAI,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC;gBAC5D,CAAC,MAAM,CAAC,IAAI,KAAK,cAAc,IAAI,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC;gBACxD,CAAC,MAAM,CAAC,IAAI,KAAK,uBAAuB,IAAI,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC;YAGpE,IAAI,SAAS,KAAK,IAAI,IAAI,sBAAsB,EAAE,CAAC;gBACjD,GAAG,GAAG,UAAS,KAAyB;oBACtC,MAAM,UAAU,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC;oBACtD,MAAM,YAAY,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;oBAC1D,OAAO,KAAK,CAAC,WAAW,CAAC,IAAI,EAAE,GAAG,YAAY,OAAO,UAAU,EAAE,CAAC,CAAC;gBACrE,CAAC,CAAC;YACJ,CAAC;iBAAM,IAAI,SAAS,KAAK,gBAAgB,IAAI,sBAAsB,EAAE,CAAC;gBACpE,GAAG,GAAG,UAAS,KAAyB;oBACtC,MAAM,UAAU,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC;oBACtD,MAAM,YAAY,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;oBAC1D,OAAO,KAAK,CAAC,WAAW,CAAC,IAAI,EAAE,GAAG,UAAU,mBAAmB,YAAY,GAAG,CAAC,CAAC;gBAClF,CAAC,CAAC;YACJ,CAAC;iBAAM,IAAI,SAAS,KAAK,eAAe,IAAI,sBAAsB,EAAE,CAAC;gBACnE,GAAG,GAAG,UAAS,KAAyB;oBACtC,MAAM,UAAU,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC;oBACtD,MAAM,YAAY,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;oBAC1D,OAAO,KAAK,CAAC,WAAW,CAAC,IAAI,EAAE,iBAAiB,UAAU,KAAK,YAAY,GAAG,CAAC,CAAC;gBAClF,CAAC,CAAC;YACJ,CAAC;YAED,OAAO,CAAC,MAAM,CAAC;gBACb,IAAI;gBACJ,SAAS,EAAE,0BAA0B;gBACrC,IAAI,EAAE;oBACJ,OAAO,EAAE,aAAa;oBACtB,SAAS;iBACV;gBACD,GAAG;aACJ,CAAC,CAAC;QACL,CAAC;QAED,OAAO;YACL,iCAAiC;YACjC,cAAc,CAAC,IAA6B;gBAC1C,oEAAoE;gBACpE,gEAAgE;gBAChE,mEAAmE;gBACnE,iEAAiE;gBACjE,IACE,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;oBACvC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY;oBAC1C,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,gBAAgB;oBAC9C,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC;oBAC3B,SAAS,KAAK,gBAAgB,EAC9B,CAAC;oBACD,uBAAuB,CAAC,IAAI,EAAE,gBAAgB,EAAE,IAAI,CAAC,MAAM,CAAC,MAAM,EAAE,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;gBACzF,CAAC;gBAED,kDAAkD;gBAClD,IACE,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;oBACvC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;oBAC9C,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;oBACrD,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY;oBACtD,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,QAAQ;oBAClD,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY;oBACxD,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,WAAW;oBACvD,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY;oBACjD,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,gBAAgB;oBACrD,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY;oBAC1C,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,MAAM;oBACpC,IAAI,CAAC,SAAS,CAAC,MAAM,IAAI,CAAC;oBAC1B,SAAS,KAAK,gBAAgB,EAC9B,CAAC;oBACD,uBAAuB,CAAC,IAAI,EAAE,sCAAsC,EAAE,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;gBAC9G,CAAC;gBAED,2BAA2B;gBAC3B,IACE,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;oBACvC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY;oBACxC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,QAAQ;oBACpC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY;oBAC1C,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,QAAQ;oBACtC,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC;oBAC3B,SAAS,KAAK,eAAe,EAC7B,CAAC;oBACD,uBAAuB,CAAC,IAAI,EAAE,eAAe,EAAE,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;gBACvF,CAAC;YACH,CAAC;YAED,gCAAgC;YAChC,gBAAgB,CAAC,IAA+B;gBAC9C,IAAI,IAAI,CAAC,QAAQ,KAAK,IAAI,IAAI,SAAS,KAAK,IAAI,EAAE,CAAC;oBACjD,uBAAuB,CAAC,IAAI,EAAE,IAAI,EAAE,IAAI,CAAC,KAAK,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;gBAC7D,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC"}
|
|
@@ -15,6 +15,7 @@ exports.expiringTodoComments = (0, eslint_devkit_1.createRule)({
|
|
|
15
15
|
meta: {
|
|
16
16
|
type: 'problem',
|
|
17
17
|
docs: {
|
|
18
|
+
url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/expiring-todo-comments.md',
|
|
18
19
|
description: 'Add expiration conditions to TODO comments to prevent forgotten tasks',
|
|
19
20
|
},
|
|
20
21
|
hasSuggestions: false,
|
|
@@ -78,6 +79,7 @@ exports.expiringTodoComments = (0, eslint_devkit_1.createRule)({
|
|
|
78
79
|
packageJson = (0, eslint_devkit_3.readJsonFileSync)(packageJsonPath);
|
|
79
80
|
return packageJson;
|
|
80
81
|
}
|
|
82
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
81
83
|
function parseSemver(version) {
|
|
82
84
|
const match = version.match(/^(\d+)\.(\d+)\.(\d+)/);
|
|
83
85
|
if (!match)
|
|
@@ -89,8 +91,19 @@ exports.expiringTodoComments = (0, eslint_devkit_1.createRule)({
|
|
|
89
91
|
};
|
|
90
92
|
}
|
|
91
93
|
function compareVersions(version1, version2) {
|
|
92
|
-
|
|
93
|
-
|
|
94
|
+
// Normalize wildcards (`24.x`, `24`) to a full semver so parseSemver
|
|
95
|
+
// succeeds — without this, `package.json#engines.node: "24.x"` falls
|
|
96
|
+
// through to `parseSemver -> null`, which the original code returned
|
|
97
|
+
// as 0 (equal), making every `>=` engine TODO falsely match.
|
|
98
|
+
const norm = (v) => {
|
|
99
|
+
const cleaned = v.replace(/^[\^~>=<]+/, '').trim();
|
|
100
|
+
const parts = cleaned.split('.').map((p) => (/^\d+$/.test(p) ? p : '0'));
|
|
101
|
+
while (parts.length < 3)
|
|
102
|
+
parts.push('0');
|
|
103
|
+
return parts.slice(0, 3).join('.');
|
|
104
|
+
};
|
|
105
|
+
const v1 = parseSemver(norm(version1));
|
|
106
|
+
const v2 = parseSemver(norm(version2));
|
|
94
107
|
if (!v1 || !v2)
|
|
95
108
|
return 0;
|
|
96
109
|
if (v1.major !== v2.major)
|
|
@@ -99,6 +112,7 @@ exports.expiringTodoComments = (0, eslint_devkit_1.createRule)({
|
|
|
99
112
|
return v1.minor - v2.minor;
|
|
100
113
|
return v1.patch - v2.patch;
|
|
101
114
|
}
|
|
115
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
102
116
|
function checkDateCondition(dateStr) {
|
|
103
117
|
try {
|
|
104
118
|
const conditionDate = new Date(dateStr + 'T00:00:00Z'); // UTC
|
|
@@ -166,6 +180,7 @@ exports.expiringTodoComments = (0, eslint_devkit_1.createRule)({
|
|
|
166
180
|
const hasPackage = packageName in allDeps;
|
|
167
181
|
return present ? hasPackage : hasPackage;
|
|
168
182
|
}
|
|
183
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
169
184
|
function parseTodoCondition(commentValue, term) {
|
|
170
185
|
// Match patterns like: TODO [condition]: message
|
|
171
186
|
// or TODO (@author) [condition]: message
|
|
@@ -180,6 +195,7 @@ exports.expiringTodoComments = (0, eslint_devkit_1.createRule)({
|
|
|
180
195
|
const conditions = conditionStr.split(/\s*,\s*/);
|
|
181
196
|
return { conditions, rest };
|
|
182
197
|
}
|
|
198
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
183
199
|
function validateCondition(condition) {
|
|
184
200
|
// Date condition: YYYY-MM-DD
|
|
185
201
|
if (/^\d{4}-\d{2}-\d{2}$/.test(condition)) {
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"expiring-todo-comments.js","sourceRoot":"","sources":["
|
|
1
|
+
{"version":3,"file":"expiring-todo-comments.js","sourceRoot":"","sources":["../../../../src/rules/conventions/expiring-todo-comments.ts"],"names":[],"mappings":";AAAA;;;;GAIG;;;AAOH,4DAAsD;AACtD,4DAA0E;AAC1E,4DAA4D;AAC5D,4DAAuD;AA4B1C,QAAA,oBAAoB,GAAG,IAAA,0BAAU,EAA0B;IACtE,IAAI,EAAE,wBAAwB;IAC9B,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,GAAG,EAAE,yHAAyH;YAC9H,WAAW,EACT,uEAAuE;SAC1E;QACD,cAAc,EAAE,KAAK;QACrB,QAAQ,EAAE;YACR,mBAAmB,EAAE,IAAA,gCAAgB,EAAC;gBACpC,IAAI,EAAE,4BAAY,CAAC,OAAO;gBAC1B,SAAS,EAAE,uBAAuB;gBAClC,WAAW,EAAE,oCAAoC;gBACjD,QAAQ,EAAE,MAAM;gBAChB,GAAG,EAAE,iDAAiD;gBACtD,iBAAiB,EACf,sGAAsG;aACzG,CAAC;YACF,oBAAoB,EAAE,IAAA,gCAAgB,EAAC;gBACrC,IAAI,EAAE,4BAAY,CAAC,OAAO;gBAC1B,SAAS,EAAE,wBAAwB;gBACnC,WAAW,EAAE,oDAAoD;gBACjE,QAAQ,EAAE,QAAQ;gBAClB,GAAG,EAAE,kDAAkD;gBACvD,iBAAiB,EACf,sGAAsG;aACzG,CAAC;YACF,sBAAsB,EAAE,IAAA,gCAAgB,EAAC;gBACvC,IAAI,EAAE,4BAAY,CAAC,OAAO;gBAC1B,SAAS,EAAE,0BAA0B;gBACrC,WAAW,EAAE,sCAAsC;gBACnD,QAAQ,EAAE,QAAQ;gBAClB,GAAG,EAAE,yCAAyC;gBAC9C,iBAAiB,EACf,sGAAsG;aACzG,CAAC;SACH;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,KAAK,EAAE;wBACL,IAAI,EAAE,OAAO;wBACb,KAAK,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACzB,OAAO,EAAE,CAAC,MAAM,EAAE,OAAO,EAAE,KAAK,CAAC;qBAClC;oBACD,UAAU,EAAE;wBACV,IAAI,EAAE,QAAQ;wBACd,OAAO,EAAE,YAAY;qBACtB;iBACF;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;KACF;IACD,cAAc,EAAE;QACd,EAAE,KAAK,EAAE,CAAC,MAAM,EAAE,OAAO,EAAE,KAAK,CAAC,EAAE,UAAU,EAAE,YAAY,EAAE;KAC9D;IAED,MAAM,CAAC,OAAsD;QAC3D,MAAM,CAAC,OAAO,CAAC,GAAG,OAAO,CAAC,OAAO,CAAC;QAClC,MAAM,EAAE,KAAK,GAAG,CAAC,MAAM,EAAE,OAAO,EAAE,KAAK,CAAC,EAAE,GAAG,OAAO,IAAI,EAAE,CAAC;QAE3D,0BAA0B;QAC1B,IAAI,WAAW,GAAuB,IAAI,CAAC;QAE3C,SAAS,eAAe;YACtB,IAAI,WAAW,KAAK,IAAI,EAAE,CAAC;gBACzB,OAAO,WAAW,CAAC;YACrB,CAAC;YAED,MAAM,eAAe,GAAG,IAAA,2BAAW,EAAC,OAAO,CAAC,GAAG,EAAE,EAAE,cAAc,CAAC,CAAC;YACnE,WAAW,GAAG,IAAA,gCAAgB,EAAc,eAAe,CAAC,CAAC;YAC7D,OAAO,WAAW,CAAC;QACrB,CAAC;QAED,uDAAuD;QACvD,SAAS,WAAW,CAClB,OAAe;YAEf,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,sBAAsB,CAAC,CAAC;YACpD,IAAI,CAAC,KAAK;gBAAE,OAAO,IAAI,CAAC;YAExB,OAAO;gBACL,KAAK,EAAE,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;gBAC7B,KAAK,EAAE,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;gBAC7B,KAAK,EAAE,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;aAC9B,CAAC;QACJ,CAAC;QAED,SAAS,eAAe,CAAC,QAAgB,EAAE,QAAgB;YACzD,qEAAqE;YACrE,qEAAqE;YACrE,qEAAqE;YACrE,6DAA6D;YAC7D,MAAM,IAAI,GAAG,CAAC,CAAS,EAAU,EAAE;gBACjC,MAAM,OAAO,GAAG,CAAC,CAAC,OAAO,CAAC,YAAY,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;gBACnD,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC;gBACzE,OAAO,KAAK,CAAC,MAAM,GAAG,CAAC;oBAAE,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;gBACzC,OAAO,KAAK,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;YACrC,CAAC,CAAC;YACF,MAAM,EAAE,GAAG,WAAW,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC;YACvC,MAAM,EAAE,GAAG,WAAW,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC;YAEvC,IAAI,CAAC,EAAE,IAAI,CAAC,EAAE;gBAAE,OAAO,CAAC,CAAC;YAEzB,IAAI,EAAE,CAAC,KAAK,KAAK,EAAE,CAAC,KAAK;gBAAE,OAAO,EAAE,CAAC,KAAK,GAAG,EAAE,CAAC,KAAK,CAAC;YACtD,IAAI,EAAE,CAAC,KAAK,KAAK,EAAE,CAAC,KAAK;gBAAE,OAAO,EAAE,CAAC,KAAK,GAAG,EAAE,CAAC,KAAK,CAAC;YACtD,OAAO,EAAE,CAAC,KAAK,GAAG,EAAE,CAAC,KAAK,CAAC;QAC7B,CAAC;QAED,uDAAuD;QACvD,SAAS,kBAAkB,CAAC,OAAe;YACzC,IAAI,CAAC;gBACH,MAAM,aAAa,GAAG,IAAI,IAAI,CAAC,OAAO,GAAG,YAAY,CAAC,CAAC,CAAC,MAAM;gBAC9D,MAAM,GAAG,GAAG,IAAI,IAAI,EAAE,CAAC;gBACvB,OAAO,GAAG,IAAI,aAAa,CAAC;YAC9B,CAAC;YAAC,MAAM,CAAC;gBACP,OAAO,KAAK,CAAC;YACf,CAAC;QACH,CAAC;QAED,SAAS,4BAA4B,CACnC,QAAgB,EAChB,aAAqB;YAErB,MAAM,GAAG,GAAG,eAAe,EAAE,CAAC;YAC9B,IAAI,CAAC,GAAG,EAAE,OAAO;gBAAE,OAAO,KAAK,CAAC;YAEhC,MAAM,cAAc,GAAG,GAAG,CAAC,OAAO,CAAC;YACnC,MAAM,UAAU,GAAG,eAAe,CAAC,cAAc,EAAE,aAAa,CAAC,CAAC;YAElE,QAAQ,QAAQ,EAAE,CAAC;gBACjB,KAAK,GAAG;oBACN,OAAO,UAAU,GAAG,CAAC,CAAC;gBACxB,KAAK,IAAI;oBACP,OAAO,UAAU,IAAI,CAAC,CAAC;gBACzB,KAAK,GAAG;oBACN,OAAO,UAAU,GAAG,CAAC,CAAC;gBACxB,KAAK,IAAI;oBACP,OAAO,UAAU,IAAI,CAAC,CAAC;gBACzB,KAAK,GAAG,CAAC;gBACT,KAAK,IAAI;oBACP,OAAO,UAAU,KAAK,CAAC,CAAC;gBAC1B;oBACE,OAAO,KAAK,CAAC;YACjB,CAAC;QACH,CAAC;QAED,SAAS,2BAA2B,CAClC,MAAc,EACd,QAAgB,EAChB,aAAqB;YAErB,IAAI,MAAM,KAAK,MAAM;gBAAE,OAAO,KAAK,CAAC;YAEpC,MAAM,GAAG,GAAG,eAAe,EAAE,CAAC;YAC9B,MAAM,WAAW,GAAG,GAAG,EAAE,OAAO,EAAE,IAAI,CAAC;YACvC,IAAI,CAAC,WAAW;gBAAE,OAAO,KAAK,CAAC;YAE/B,wCAAwC;YACxC,MAAM,cAAc,GAAG,WAAW,CAAC,OAAO,CAAC,YAAY,EAAE,EAAE,CAAC,CAAC;YAC7D,MAAM,UAAU,GAAG,eAAe,CAAC,cAAc,EAAE,aAAa,CAAC,CAAC;YAElE,QAAQ,QAAQ,EAAE,CAAC;gBACjB,KAAK,GAAG;oBACN,OAAO,UAAU,GAAG,CAAC,CAAC;gBACxB,KAAK,IAAI;oBACP,OAAO,UAAU,IAAI,CAAC,CAAC;gBACzB,KAAK,GAAG;oBACN,OAAO,UAAU,GAAG,CAAC,CAAC;gBACxB,KAAK,IAAI;oBACP,OAAO,UAAU,IAAI,CAAC,CAAC;gBACzB;oBACE,OAAO,KAAK,CAAC;YACjB,CAAC;QACH,CAAC;QAED,SAAS,wBAAwB,CAC/B,WAAmB,EACnB,OAAgB;YAEhB,MAAM,GAAG,GAAG,eAAe,EAAE,CAAC;YAC9B,IAAI,CAAC,GAAG;gBAAE,OAAO,KAAK,CAAC;YAEvB,MAAM,OAAO,GAAG;gBACd,GAAG,GAAG,CAAC,YAAY;gBACnB,GAAG,GAAG,CAAC,eAAe;gBACtB,GAAG,GAAG,CAAC,gBAAgB;aACxB,CAAC;YAEF,MAAM,UAAU,GAAG,WAAW,IAAI,OAAO,CAAC;YAC1C,OAAO,OAAO,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC;QAC3C,CAAC;QAED,uDAAuD;QACvD,SAAS,kBAAkB,CACzB,YAAoB,EACpB,IAAY;YAEZ,iDAAiD;YACjD,yCAAyC;YACzC,wEAAwE;YACxE,MAAM,SAAS,GAAG,IAAI,MAAM,CAC1B,WAAW,IAAI,uDAAuD,EACtE,IAAI,CACL,CAAC;YACF,MAAM,KAAK,GAAG,YAAY,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC;YAE5C,IAAI,CAAC,KAAK;gBAAE,OAAO,IAAI,CAAC;YAExB,MAAM,YAAY,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YAC9B,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YAEtB,sEAAsE;YACtE,MAAM,UAAU,GAAG,YAAY,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC;YAEjD,OAAO,EAAE,UAAU,EAAE,IAAI,EAAE,CAAC;QAC9B,CAAC;QAED,uDAAuD;QACvD,SAAS,iBAAiB,CACxB,SAAiB;YAEjB,6BAA6B;YAC7B,IAAI,qBAAqB,CAAC,IAAI,CAAC,SAAS,CAAC,EAAE,CAAC;gBAC1C,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,SAAS,EAAE,CAAC;YAC5C,CAAC;YAED,mDAAmD;YACnD,MAAM,mBAAmB,GAAG,SAAS,CAAC,KAAK,CAAC,4BAA4B,CAAC,CAAC;YAC1E,IAAI,mBAAmB,EAAE,CAAC;gBACxB,OAAO;oBACL,IAAI,EAAE,iBAAiB;oBACvB,QAAQ,EAAE,mBAAmB,CAAC,CAAC,CAAC;oBAChC,KAAK,EAAE,mBAAmB,CAAC,CAAC,CAAC;iBAC9B,CAAC;YACJ,CAAC;YAED,iEAAiE;YACjE,MAAM,kBAAkB,GAAG,SAAS,CAAC,KAAK,CACxC,oCAAoC,CACrC,CAAC;YACF,IAAI,kBAAkB,EAAE,CAAC;gBACvB,MAAM,MAAM,GAAG,kBAAkB,CAAC,CAAC,CAAC,CAAC;gBACrC,uBAAuB;gBACvB,IAAI,CAAC,CAAC,MAAM,EAAE,KAAK,EAAE,MAAM,EAAE,MAAM,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,EAAE,CAAC;oBACtD,OAAO,IAAI,CAAC,CAAC,wDAAwD;gBACvE,CAAC;gBACD,OAAO;oBACL,IAAI,EAAE,gBAAgB;oBACtB,KAAK,EAAE,GAAG,MAAM,IAAI,kBAAkB,CAAC,CAAC,CAAC,EAAE;oBAC3C,QAAQ,EAAE,kBAAkB,CAAC,CAAC,CAAC;iBAChC,CAAC;YACJ,CAAC;YAED,uDAAuD;YACvD,MAAM,QAAQ,GAAG,SAAS,CAAC,KAAK,CAAC,cAAc,CAAC,CAAC;YACjD,IAAI,QAAQ,EAAE,CAAC;gBACb,OAAO;oBACL,IAAI,EAAE,YAAY;oBAClB,KAAK,EAAE,QAAQ,CAAC,CAAC,CAAC;oBAClB,QAAQ,EAAE,QAAQ,CAAC,CAAC,CAAC;iBACtB,CAAC;YACJ,CAAC;YAED,OAAO,IAAI,CAAC;QACd,CAAC;QAED,SAAS,cAAc,CAAC,SAAiB;YACvC,MAAM,MAAM,GAAG,iBAAiB,CAAC,SAAS,CAAC,CAAC;YAC5C,IAAI,CAAC,MAAM;gBAAE,OAAO,KAAK,CAAC;YAE1B,QAAQ,MAAM,CAAC,IAAI,EAAE,CAAC;gBACpB,KAAK,MAAM;oBACT,OAAO,kBAAkB,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;gBAC1C,KAAK,iBAAiB;oBACpB,OAAO,MAAM,CAAC,QAAQ;wBACpB,CAAC,CAAC,4BAA4B,CAAC,MAAM,CAAC,QAAQ,EAAE,MAAM,CAAC,KAAK,CAAC;wBAC7D,CAAC,CAAC,KAAK,CAAC;gBACZ,KAAK,gBAAgB,CAAC,CAAC,CAAC;oBACtB,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC;oBAClD,OAAO,MAAM,CAAC,QAAQ;wBACpB,CAAC,CAAC,2BAA2B,CAAC,MAAM,EAAE,MAAM,CAAC,QAAQ,EAAE,OAAO,CAAC;wBAC/D,CAAC,CAAC,KAAK,CAAC;gBACZ,CAAC;gBACD,KAAK,YAAY;oBACf,OAAO,wBAAwB,CAC7B,MAAM,CAAC,KAAK,EACZ,MAAM,CAAC,QAAQ,KAAK,GAAG,CACxB,CAAC;gBACJ;oBACE,OAAO,KAAK,CAAC;YACjB,CAAC;QACH,CAAC;QAED,SAAS,YAAY,CAAC,OAAyB;YAC7C,MAAM,YAAY,GAAG,OAAO,CAAC,KAAK,CAAC;YAEnC,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;gBACzB,MAAM,MAAM,GAAG,kBAAkB,CAAC,YAAY,EAAE,IAAI,CAAC,CAAC;gBACtD,IAAI,CAAC,MAAM;oBAAE,SAAS;gBAEtB,MAAM,EAAE,UAAU,EAAE,IAAI,EAAE,GAAG,MAAM,CAAC;gBAEpC,gCAAgC;gBAChC,IAAI,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;oBAC1B,OAAO,CAAC,MAAM,CAAC;wBACb,GAAG,EAAE,OAAO,CAAC,GAAG;wBAChB,SAAS,EAAE,wBAAwB;wBACnC,IAAI,EAAE;4BACJ,IAAI;4BACJ,UAAU,EAAE,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC;yBAClC;qBACF,CAAC,CAAC;oBACH,SAAS;gBACX,CAAC;gBAED,MAAM,SAAS,GAAG,UAAU,CAAC,CAAC,CAAC,CAAC;gBAEhC,4BAA4B;gBAC5B,MAAM,eAAe,GAAG,iBAAiB,CAAC,SAAS,CAAC,CAAC;gBACrD,IAAI,CAAC,eAAe,EAAE,CAAC;oBACrB,OAAO,CAAC,MAAM,CAAC;wBACb,GAAG,EAAE,OAAO,CAAC,GAAG;wBAChB,SAAS,EAAE,sBAAsB;wBACjC,IAAI,EAAE;4BACJ,SAAS;4BACT,IAAI;yBACL;qBACF,CAAC,CAAC;oBACH,SAAS;gBACX,CAAC;gBAED,iCAAiC;gBACjC,IAAI,cAAc,CAAC,SAAS,CAAC,EAAE,CAAC;oBAC9B,OAAO,CAAC,MAAM,CAAC;wBACb,GAAG,EAAE,OAAO,CAAC,GAAG;wBAChB,SAAS,EAAE,qBAAqB;wBAChC,IAAI,EAAE;4BACJ,IAAI;4BACJ,SAAS;4BACT,OAAO,EAAE,IAAI;yBACd;qBACF,CAAC,CAAC;gBACL,CAAC;gBAED,oCAAoC;gBACpC,MAAM;YACR,CAAC;QACH,CAAC;QAED,OAAO;YACL,OAAO;gBACL,MAAM,UAAU,GAAG,OAAO,CAAC,UAAU,CAAC;gBACtC,MAAM,QAAQ,GAAG,UAAU,CAAC,cAAc,EAAE,CAAC;gBAE7C,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;oBAC/B,IAAI,OAAO,CAAC,IAAI,KAAK,MAAM,IAAI,OAAO,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;wBACxD,YAAY,CAAC,OAAO,CAAC,CAAC;oBACxB,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC"}
|
|
@@ -29,6 +29,7 @@ exports.filenameCase = (0, eslint_devkit_1.createRule)({
|
|
|
29
29
|
meta: {
|
|
30
30
|
type: 'problem',
|
|
31
31
|
docs: {
|
|
32
|
+
url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/filename-case.md',
|
|
32
33
|
description: 'Enforce filename case conventions for consistency',
|
|
33
34
|
},
|
|
34
35
|
hasSuggestions: true,
|
|
@@ -108,9 +109,11 @@ exports.filenameCase = (0, eslint_devkit_1.createRule)({
|
|
|
108
109
|
const [options] = context.options;
|
|
109
110
|
const { case: caseType = 'kebabCase', ignore = [], allowedUppercaseFiles = DEFAULT_ALLOWED_UPPERCASE_FILES, allowedKebabCase = [], allowedSnakeCase = [], allowedCamelCase = [], allowedPascalCase = [], } = options || {};
|
|
110
111
|
// Convert to different case formats
|
|
112
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
111
113
|
function toCamelCase(str) {
|
|
112
114
|
return str.replace(/[-_](.)/g, (_, letter) => letter.toUpperCase());
|
|
113
115
|
}
|
|
116
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
114
117
|
function toKebabCase(str) {
|
|
115
118
|
return str
|
|
116
119
|
.replace(/([a-z])([A-Z])/g, '$1-$2')
|
|
@@ -121,6 +124,7 @@ exports.filenameCase = (0, eslint_devkit_1.createRule)({
|
|
|
121
124
|
const camel = toCamelCase(str);
|
|
122
125
|
return camel.charAt(0).toUpperCase() + camel.slice(1);
|
|
123
126
|
}
|
|
127
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
124
128
|
function toSnakeCase(str) {
|
|
125
129
|
return str
|
|
126
130
|
.replace(/([a-z])([A-Z])/g, '$1_$2')
|
|
@@ -128,18 +132,22 @@ exports.filenameCase = (0, eslint_devkit_1.createRule)({
|
|
|
128
132
|
.toLowerCase();
|
|
129
133
|
}
|
|
130
134
|
// Check if filename matches the expected case pattern
|
|
135
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
131
136
|
function isCamelCase(str) {
|
|
132
137
|
// camelCase: starts with lowercase, no separators, can have uppercase after first char
|
|
133
138
|
return /^[a-z][a-zA-Z0-9]*$/.test(str);
|
|
134
139
|
}
|
|
140
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
135
141
|
function isKebabCase(str) {
|
|
136
142
|
// kebab-case: all lowercase with hyphens as separators
|
|
137
143
|
return /^[a-z][a-z0-9]*(-[a-z0-9]+)*$/.test(str);
|
|
138
144
|
}
|
|
145
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
139
146
|
function isPascalCase(str) {
|
|
140
147
|
// PascalCase: starts with uppercase, no separators
|
|
141
148
|
return /^[A-Z][a-zA-Z0-9]*$/.test(str);
|
|
142
149
|
}
|
|
150
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
143
151
|
function isSnakeCase(str) {
|
|
144
152
|
// snake_case: all lowercase with underscores as separators
|
|
145
153
|
return /^[a-z][a-z0-9]*(_[a-z0-9]+)*$/.test(str);
|
|
@@ -184,7 +192,7 @@ exports.filenameCase = (0, eslint_devkit_1.createRule)({
|
|
|
184
192
|
return {
|
|
185
193
|
Program(node) {
|
|
186
194
|
// Get filename from context
|
|
187
|
-
const filename = context.
|
|
195
|
+
const filename = context.filename;
|
|
188
196
|
if (!filename) {
|
|
189
197
|
return;
|
|
190
198
|
}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"filename-case.js","sourceRoot":"","sources":["
|
|
1
|
+
{"version":3,"file":"filename-case.js","sourceRoot":"","sources":["../../../../src/rules/conventions/filename-case.ts"],"names":[],"mappings":";AAAA;;;;GAIG;;;AAOH,4DAAsD;AACtD,4DAA0E;AAC1E,4DAAuD;AAMvD;;GAEG;AACH,MAAM,+BAA+B,GAAG;IACtC,QAAQ;IACR,SAAS;IACT,WAAW;IACX,cAAc;IACd,SAAS;IACT,SAAS;IACT,UAAU;IACV,QAAQ;IACR,SAAS;IACT,SAAS;CACV,CAAC;AAqBW,QAAA,YAAY,GAAG,IAAA,0BAAU,EAA0B;IAC9D,IAAI,EAAE,eAAe;IACrB,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,GAAG,EAAE,gHAAgH;YACrH,WAAW,EAAE,mDAAmD;SACjE;QACD,cAAc,EAAE,IAAI;QACpB,QAAQ,EAAE;YACR,YAAY,EAAE,IAAA,gCAAgB,EAAC;gBAC7B,IAAI,EAAE,4BAAY,CAAC,OAAO;gBAC1B,SAAS,EAAE,0BAA0B;gBACrC,WAAW,EAAE,4DAA4D;gBACzE,QAAQ,EAAE,QAAQ;gBAClB,GAAG,EAAE,iFAAiF;gBACtF,iBAAiB,EAAE,6FAA6F;aACjH,CAAC;SACH;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,IAAI,EAAE;wBACJ,IAAI,EAAE,QAAQ;wBACd,IAAI,EAAE,CAAC,WAAW,EAAE,WAAW,EAAE,YAAY,EAAE,WAAW,CAAC;wBAC3D,OAAO,EAAE,WAAW;qBACrB;oBACD,MAAM,EAAE;wBACN,IAAI,EAAE,OAAO;wBACb,KAAK,EAAE;4BACL,KAAK,EAAE;gCACL,EAAE,IAAI,EAAE,QAAQ,EAAE;gCAClB,EAAE,IAAI,EAAE,QAAQ,EAAE;6BACnB;yBACF;wBACD,OAAO,EAAE,EAAE;qBACZ;oBACD,qBAAqB,EAAE;wBACrB,IAAI,EAAE,OAAO;wBACb,KAAK,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACzB,WAAW,EAAE,+GAA+G;qBAC7H;oBACD,gBAAgB,EAAE;wBAChB,IAAI,EAAE,OAAO;wBACb,KAAK,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACzB,WAAW,EAAE,oFAAoF;wBACjG,OAAO,EAAE,EAAE;qBACZ;oBACD,gBAAgB,EAAE;wBAChB,IAAI,EAAE,OAAO;wBACb,KAAK,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACzB,WAAW,EAAE,oFAAoF;wBACjG,OAAO,EAAE,EAAE;qBACZ;oBACD,gBAAgB,EAAE;wBAChB,IAAI,EAAE,OAAO;wBACb,KAAK,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACzB,WAAW,EAAE,mFAAmF;wBAChG,OAAO,EAAE,EAAE;qBACZ;oBACD,iBAAiB,EAAE;wBACjB,IAAI,EAAE,OAAO;wBACb,KAAK,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACzB,WAAW,EAAE,oFAAoF;wBACjG,OAAO,EAAE,EAAE;qBACZ;iBACF;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;KACF;IACD,cAAc,EAAE,CAAC;YACf,IAAI,EAAE,WAAW;YACjB,MAAM,EAAE,EAAE;YACV,qBAAqB,EAAE,+BAA+B;YACtD,gBAAgB,EAAE,EAAE;YACpB,gBAAgB,EAAE,EAAE;YACpB,gBAAgB,EAAE,EAAE;YACpB,iBAAiB,EAAE,EAAE;SACtB,CAAC;IAEF,MAAM,CAAC,OAAsD;QAC3D,MAAM,CAAC,OAAO,CAAC,GAAG,OAAO,CAAC,OAAO,CAAC;QAClC,MAAM,EACJ,IAAI,EAAE,QAAQ,GAAG,WAAW,EAC5B,MAAM,GAAG,EAAE,EACX,qBAAqB,GAAG,+BAA+B,EACvD,gBAAgB,GAAG,EAAE,EACrB,gBAAgB,GAAG,EAAE,EACrB,gBAAgB,GAAG,EAAE,EACrB,iBAAiB,GAAG,EAAE,GACvB,GAAG,OAAO,IAAI,EAAE,CAAC;QAElB,oCAAoC;QACpC,uDAAuD;QACvD,SAAS,WAAW,CAAC,GAAW;YAC9B,OAAO,GAAG,CAAC,OAAO,CAAC,UAAU,EAAE,CAAC,CAAC,EAAE,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,WAAW,EAAE,CAAC,CAAC;QACtE,CAAC;QAED,uDAAuD;QACvD,SAAS,WAAW,CAAC,GAAW;YAC9B,OAAO,GAAG;iBACP,OAAO,CAAC,iBAAiB,EAAE,OAAO,CAAC;iBACnC,OAAO,CAAC,SAAS,EAAE,GAAG,CAAC;iBACvB,WAAW,EAAE,CAAC;QACnB,CAAC;QAED,SAAS,YAAY,CAAC,GAAW;YAC/B,MAAM,KAAK,GAAG,WAAW,CAAC,GAAG,CAAC,CAAC;YAC/B,OAAO,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,WAAW,EAAE,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;QACxD,CAAC;QAED,uDAAuD;QACvD,SAAS,WAAW,CAAC,GAAW;YAC9B,OAAO,GAAG;iBACP,OAAO,CAAC,iBAAiB,EAAE,OAAO,CAAC;iBACnC,OAAO,CAAC,SAAS,EAAE,GAAG,CAAC;iBACvB,WAAW,EAAE,CAAC;QACnB,CAAC;QAED,sDAAsD;QACtD,uDAAuD;QACvD,SAAS,WAAW,CAAC,GAAW;YAC9B,uFAAuF;YACvF,OAAO,qBAAqB,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QACzC,CAAC;QAED,uDAAuD;QACvD,SAAS,WAAW,CAAC,GAAW;YAC9B,uDAAuD;YACvD,OAAO,+BAA+B,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QACnD,CAAC;QAED,uDAAuD;QACvD,SAAS,YAAY,CAAC,GAAW;YAC/B,mDAAmD;YACnD,OAAO,qBAAqB,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QACzC,CAAC;QAED,uDAAuD;QACvD,SAAS,WAAW,CAAC,GAAW;YAC9B,2DAA2D;YAC3D,OAAO,+BAA+B,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QACnD,CAAC;QAED,SAAS,WAAW,CAAC,GAAW,EAAE,YAAsB;YACtD,QAAQ,YAAY,EAAE,CAAC;gBACrB,KAAK,WAAW;oBACd,OAAO,WAAW,CAAC,GAAG,CAAC,CAAC;gBAC1B,KAAK,WAAW;oBACd,OAAO,WAAW,CAAC,GAAG,CAAC,CAAC;gBAC1B,KAAK,YAAY;oBACf,OAAO,YAAY,CAAC,GAAG,CAAC,CAAC;gBAC3B,KAAK,WAAW;oBACd,OAAO,WAAW,CAAC,GAAG,CAAC,CAAC;gBAC1B;oBACE,OAAO,IAAI,CAAC;YAChB,CAAC;QACH,CAAC;QAED,8BAA8B;QAC9B,SAAS,gBAAgB,CAAC,QAAgB,EAAE,cAAsB,EAAE,UAAoB;YACtF,IAAI,WAAmB,CAAC;YACxB,QAAQ,UAAU,EAAE,CAAC;gBACnB,KAAK,WAAW;oBACd,WAAW,GAAG,WAAW,CAAC,cAAc,CAAC,CAAC;oBAC1C,MAAM;gBACR,KAAK,WAAW;oBACd,WAAW,GAAG,WAAW,CAAC,cAAc,CAAC,CAAC;oBAC1C,MAAM;gBACR,KAAK,YAAY;oBACf,WAAW,GAAG,YAAY,CAAC,cAAc,CAAC,CAAC;oBAC3C,MAAM;gBACR,KAAK,WAAW;oBACd,WAAW,GAAG,WAAW,CAAC,cAAc,CAAC,CAAC;oBAC1C,MAAM;gBACR;oBACE,WAAW,GAAG,cAAc,CAAC;YACjC,CAAC;YAED,yBAAyB;YACzB,MAAM,GAAG,GAAG,QAAQ,CAAC,KAAK,CAAC,cAAc,CAAC,MAAM,CAAC,CAAC;YAClD,OAAO,WAAW,GAAG,GAAG,CAAC;QAC3B,CAAC;QAED,OAAO;YACL,OAAO,CAAC,IAAsB;gBAC5B,4BAA4B;gBAC5B,MAAM,QAAQ,GAAG,OAAO,CAAC,QAAQ,CAAC;gBAClC,IAAI,CAAC,QAAQ,EAAE,CAAC;oBACd,OAAO;gBACT,CAAC;gBAED,iDAAiD;gBACjD,MAAM,QAAQ,GAAG,IAAA,2BAAW,EAAC,QAAQ,CAAC,CAAC;gBAEvC,yEAAyE;gBACzE,MAAM,cAAc,GAAG,QAAQ,CAAC,OAAO,CAAC,8CAA8C,EAAE,EAAE,CAAC,CAAC;gBAE5F,yDAAyD;gBACzD,IAAI,CAAC,cAAc,EAAE,CAAC;oBACpB,OAAO;gBACT,CAAC;gBAED,sCAAsC;gBACtC,KAAK,MAAM,aAAa,IAAI,MAAM,EAAE,CAAC;oBACnC,IAAI,OAAO,aAAa,KAAK,QAAQ,EAAE,CAAC;wBACtC,IAAI,QAAQ,KAAK,aAAa,EAAE,CAAC;4BAC/B,OAAO;wBACT,CAAC;oBACH,CAAC;yBAAM,IAAI,aAAa,YAAY,MAAM,EAAE,CAAC;wBAC3C,IAAI,aAAa,CAAC,IAAI,CAAC,QAAQ,CAAC,EAAE,CAAC;4BACjC,OAAO;wBACT,CAAC;oBACH,CAAC;gBACH,CAAC;gBAED,wFAAwF;gBACxF,IAAI,qBAAqB,CAAC,QAAQ,CAAC,cAAc,CAAC,EAAE,CAAC;oBACnD,OAAO;gBACT,CAAC;gBAED,8CAA8C;gBAC9C,IAAI,QAAQ,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC7B,OAAO;gBACT,CAAC;gBAED,2DAA2D;gBAC3D,6EAA6E;gBAC7E,IAAI,gBAAgB,CAAC,QAAQ,CAAC,cAAc,CAAC,IAAI,WAAW,CAAC,cAAc,EAAE,WAAW,CAAC,EAAE,CAAC;oBAC1F,OAAO;gBACT,CAAC;gBACD,IAAI,gBAAgB,CAAC,QAAQ,CAAC,cAAc,CAAC,IAAI,WAAW,CAAC,cAAc,EAAE,WAAW,CAAC,EAAE,CAAC;oBAC1F,OAAO;gBACT,CAAC;gBACD,IAAI,gBAAgB,CAAC,QAAQ,CAAC,cAAc,CAAC,IAAI,WAAW,CAAC,cAAc,EAAE,WAAW,CAAC,EAAE,CAAC;oBAC1F,OAAO;gBACT,CAAC;gBACD,IAAI,iBAAiB,CAAC,QAAQ,CAAC,cAAc,CAAC,IAAI,WAAW,CAAC,cAAc,EAAE,YAAY,CAAC,EAAE,CAAC;oBAC5F,OAAO;gBACT,CAAC;gBAED,8CAA8C;gBAC9C,IAAI,CAAC,WAAW,CAAC,cAAc,EAAE,QAAQ,CAAC,EAAE,CAAC;oBAC3C,MAAM,aAAa,GAAG,gBAAgB,CAAC,QAAQ,EAAE,cAAc,EAAE,QAAQ,CAAC,CAAC;oBAE3E,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,6BAA6B;wBACnC,SAAS,EAAE,cAAc;wBACzB,IAAI,EAAE;4BACJ,IAAI,EAAE,QAAQ;4BACd,OAAO,EAAE,QAAQ;4BACjB,SAAS,EAAE,aAAa;yBACzB;wBACD,OAAO,EAAE;4BACP;gCACE,SAAS,EAAE,cAAc;gCACzB,IAAI,EAAE;oCACJ,aAAa;iCACd;gCACD,GAAG;oCACD,2DAA2D;oCAC3D,8BAA8B;oCAC9B,OAAO,IAAI,CAAC;gCACd,CAAC;6BACF;yBACF;qBACF,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC"}
|
|
@@ -81,6 +81,7 @@ exports.noCommentedCode = (0, eslint_devkit_2.createRule)({
|
|
|
81
81
|
meta: {
|
|
82
82
|
type: 'suggestion',
|
|
83
83
|
docs: {
|
|
84
|
+
url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/no-commented-code.md',
|
|
84
85
|
description: 'Detects commented-out code blocks',
|
|
85
86
|
},
|
|
86
87
|
hasSuggestions: true,
|
|
@@ -144,12 +145,12 @@ exports.noCommentedCode = (0, eslint_devkit_2.createRule)({
|
|
|
144
145
|
],
|
|
145
146
|
create(context, [options = {}]) {
|
|
146
147
|
const { ignoreSingleLine = false, ignoreInTests = true, minLines = 1, } = options || {};
|
|
147
|
-
const filename = context.
|
|
148
|
+
const filename = context.filename;
|
|
148
149
|
const isTestFile = ignoreInTests && /\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);
|
|
149
150
|
if (isTestFile) {
|
|
150
151
|
return {};
|
|
151
152
|
}
|
|
152
|
-
const sourceCode = context.sourceCode
|
|
153
|
+
const sourceCode = context.sourceCode;
|
|
153
154
|
/**
|
|
154
155
|
* Check comment nodes
|
|
155
156
|
*/
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-commented-code.js","sourceRoot":"","sources":["
|
|
1
|
+
{"version":3,"file":"no-commented-code.js","sourceRoot":"","sources":["../../../../src/rules/conventions/no-commented-code.ts"],"names":[],"mappings":";AAAA;;;;GAIG;;;AASH,4DAA0E;AAC1E,4DAAsD;AAiBtD;;GAEG;AACH,SAAS,aAAa,CAAC,OAAe,EAAE,cAAuB;IAC7D,8CAA8C;IAC9C,IAAI,IAAI,GAAG,OAAO,CAAC;IACnB,IAAI,cAAc,EAAE,CAAC;QACnB,0DAA0D;QAC1D,IAAI,GAAG,IAAI,CAAC,OAAO,CAAC,WAAW,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,WAAW,EAAE,EAAE,CAAC,CAAC;QAC9D,oDAAoD;QACpD,IAAI,GAAG,IAAI;aACR,KAAK,CAAC,IAAI,CAAC;aACX,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,OAAO,CAAC,YAAY,EAAE,EAAE,CAAC,CAAC;aAC7C,IAAI,CAAC,IAAI,CAAC,CAAC;IAChB,CAAC;SAAM,CAAC;QACN,oBAAoB;QACpB,IAAI,GAAG,IAAI;aACR,KAAK,CAAC,IAAI,CAAC;aACX,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,OAAO,CAAC,cAAc,EAAE,EAAE,CAAC,CAAC;aAC/C,IAAI,CAAC,IAAI,CAAC,CAAC;IAChB,CAAC;IAED,uCAAuC;IACvC,MAAM,KAAK,GAAG,IAAI;SACf,KAAK,CAAC,IAAI,CAAC;SACX,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC;SAC1B,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IAErC,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACvB,OAAO,KAAK,CAAC;IACf,CAAC;IAED,MAAM,YAAY,GAAG;QACnB,sEAAsE;QACtE,qCAAqC;QACrC,gCAAgC;QAChC,UAAU;KACX,CAAC;IAEF,sCAAsC;IACtC,IAAI,aAAa,GAAG,CAAC,CAAC;IAEtB,6DAA6D;IAC7D,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,2BAA2B;QAC3B,IAAI,yBAAyB,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;YACzC,SAAS;QACX,CAAC;QAED,sCAAsC;QACtC,KAAK,MAAM,OAAO,IAAI,YAAY,EAAE,CAAC;YACnC,IAAI,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;gBACvB,aAAa,EAAE,CAAC;gBAChB,MAAM,CAAC,4BAA4B;YACrC,CAAC;QACH,CAAC;IACH,CAAC;IAED,wDAAwD;IACxD,OAAO,aAAa,GAAG,CAAC,CAAC;AAC3B,CAAC;AAED;;;;GAIG;AACH,SAAS,iBAAiB,CAAC,OAAe;IACxC,IAAI,CAAC,OAAO;QAAE,OAAO,CAAC,CAAC;IACvB,MAAM,YAAY,GAAG,CAAC,OAAO,CAAC,KAAK,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC;IACzD,4EAA4E;IAC5E,sDAAsD;IACtD,OAAO,YAAY,GAAG,CAAC,CAAC,CAAC,CAAC,YAAY,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AACjD,CAAC;AAEY,QAAA,eAAe,GAAG,IAAA,0BAAU,EAA0B;IACjE,IAAI,EAAE,mBAAmB;IACzB,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,GAAG,EAAE,oHAAoH;YACzH,WAAW,EAAE,mCAAmC;SACjD;QACD,cAAc,EAAE,IAAI;QACpB,QAAQ,EAAE;YACR,aAAa,EAAE,IAAA,gCAAgB,EAAC;gBAC9B,IAAI,EAAE,4BAAY,CAAC,OAAO;gBAC1B,SAAS,EAAE,gBAAgB;gBAC3B,WAAW,EAAE,+CAA+C;gBAC5D,QAAQ,EAAE,KAAK;gBACf,GAAG,EAAE,0DAA0D;gBAC/D,iBAAiB,EACf,qDAAqD;aACxD,CAAC;YACF,UAAU,EAAE,IAAA,gCAAgB,EAAC;gBAC3B,IAAI,EAAE,4BAAY,CAAC,IAAI;gBACvB,SAAS,EAAE,aAAa;gBACxB,WAAW,EAAE,6BAA6B;gBAC1C,QAAQ,EAAE,KAAK;gBACf,GAAG,EAAE,iCAAiC;gBACtC,iBAAiB,EACf,qDAAqD;aACxD,CAAC;YACF,iBAAiB,EAAE,IAAA,gCAAgB,EAAC;gBAClC,IAAI,EAAE,4BAAY,CAAC,IAAI;gBACvB,SAAS,EAAE,SAAS;gBACpB,WAAW,EAAE,sCAAsC;gBACnD,QAAQ,EAAE,KAAK;gBACf,GAAG,EAAE,mDAAmD;gBACxD,iBAAiB,EAAE,kCAAkC;aACtD,CAAC;SACH;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,gBAAgB,EAAE;wBAChB,IAAI,EAAE,SAAS;wBACf,OAAO,EAAE,KAAK;wBACd,WAAW,EAAE,6BAA6B;qBAC3C;oBACD,aAAa,EAAE;wBACb,IAAI,EAAE,SAAS;wBACf,OAAO,EAAE,IAAI;wBACb,WAAW,EAAE,+BAA+B;qBAC7C;oBACD,QAAQ,EAAE;wBACR,IAAI,EAAE,QAAQ;wBACd,OAAO,EAAE,CAAC;wBACV,OAAO,EAAE,CAAC;wBACV,WAAW,EAAE,4CAA4C;qBAC1D;iBACF;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;KACF;IACD,cAAc,EAAE;QACd;YACE,gBAAgB,EAAE,KAAK;YACvB,aAAa,EAAE,IAAI;YACnB,QAAQ,EAAE,CAAC;SACZ;KACF;IACD,MAAM,CACJ,OAAsD,EACtD,CAAC,OAAO,GAAG,EAAE,CAAC;QAEd,MAAM,EACJ,gBAAgB,GAAG,KAAK,EACxB,aAAa,GAAG,IAAI,EACpB,QAAQ,GAAG,CAAC,GACb,GAAY,OAAO,IAAI,EAAE,CAAC;QAE3B,MAAM,QAAQ,GAAG,OAAO,CAAC,QAAQ,CAAC;QAClC,MAAM,UAAU,GACd,aAAa,IAAI,iCAAiC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAEpE,IAAI,UAAU,EAAE,CAAC;YACf,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,MAAM,UAAU,GAAG,OAAO,CAAC,UAAU,CAAC;QAEtC;;WAEG;QACH,SAAS,YAAY,CAAC,IAAsB;YAC1C,IAAI,CAAC;gBACH,MAAM,WAAW,GAAG,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC;gBACrC,MAAM,cAAc,GAAG,IAAI,CAAC,IAAI,KAAK,OAAO,CAAC;gBAC7C,MAAM,KAAK,GAAG,iBAAiB,CAAC,WAAW,CAAC,CAAC;gBAE7C,0CAA0C;gBAC1C,IAAI,gBAAgB,IAAI,KAAK,KAAK,CAAC,IAAI,CAAC,cAAc,EAAE,CAAC;oBACvD,OAAO;gBACT,CAAC;gBAED,8BAA8B;gBAC9B,IAAI,KAAK,GAAG,QAAQ,EAAE,CAAC;oBACrB,OAAO;gBACT,CAAC;gBAED,8BAA8B;gBAC9B,IAAI,aAAa,CAAC,WAAW,EAAE,cAAc,CAAC,EAAE,CAAC;oBAC/C,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI;wBACJ,SAAS,EAAE,eAAe;wBAC1B,IAAI,EAAE;4BACJ,KAAK,EAAE,MAAM,CAAC,KAAK,CAAC;yBACrB;wBACD,OAAO,EAAE;4BACP;gCACE,SAAS,EAAE,YAAY;gCACvB,GAAG,EAAE,CAAC,KAAyB,EAAE,EAAE;oCACjC,IAAI,CAAC;wCACH,4BAA4B;wCAC5B,OAAO,KAAK,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;oCAC5B,CAAC;oCAAC,MAAM,CAAC;wCACP,OAAO,IAAI,CAAC;oCACd,CAAC;gCACH,CAAC;6BACF;4BACD;gCACE,SAAS,EAAE,mBAAmB;gCAC9B,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI;6BAChB;yBACF;qBACF,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;YAAC,MAAM,CAAC;gBACP,2DAA2D;gBAC3D,OAAO;YACT,CAAC;QACH,CAAC;QAED,OAAO;YACL,OAAO;gBACL,MAAM,QAAQ,GAAG,UAAU,CAAC,cAAc,EAAE,CAAC;gBAE7C,iDAAiD;gBACjD,MAAM,eAAe,GAAyB,EAAE,CAAC;gBACjD,IAAI,YAAY,GAAuB,EAAE,CAAC;gBAE1C,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,QAAQ,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;oBACzC,MAAM,OAAO,GAAG,QAAQ,CAAC,CAAC,CAAC,CAAC;oBAC5B,MAAM,WAAW,GAAG,OAAO,CAAC,KAAK,IAAI,EAAE,CAAC;oBACxC,MAAM,cAAc,GAAG,OAAO,CAAC,IAAI,KAAK,OAAO,CAAC;oBAEhD,wCAAwC;oBACxC,IAAI,aAAa,CAAC,WAAW,EAAE,cAAc,CAAC,EAAE,CAAC;wBAC/C,YAAY,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;oBAC7B,CAAC;yBAAM,CAAC;wBACN,4DAA4D;wBAC5D,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;4BAC5B,eAAe,CAAC,IAAI,CAAC,CAAC,GAAG,YAAY,CAAC,CAAC,CAAC;4BACxC,YAAY,GAAG,EAAE,CAAC;wBACpB,CAAC;oBACH,CAAC;gBACH,CAAC;gBAED,6BAA6B;gBAC7B,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;oBAC5B,eAAe,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;gBACrC,CAAC;gBAED,qBAAqB;gBACrB,eAAe,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;oBAChC,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;wBACvB,0DAA0D;wBAC1D,YAAY,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;oBACzB,CAAC;yBAAM,CAAC;wBACN,sDAAsD;wBACtD,MAAM,YAAY,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;wBAC9B,MAAM,UAAU,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,GAAG,EAAE,OAAO,EAAE,EAAE;4BAC/C,MAAM,WAAW,GAAG,OAAO,CAAC,KAAK,IAAI,EAAE,CAAC;4BACxC,OAAO,GAAG,GAAG,iBAAiB,CAAC,WAAW,CAAC,CAAC;wBAC9C,CAAC,EAAE,CAAC,CAAC,CAAC;wBAEN,IAAI,UAAU,IAAI,QAAQ,EAAE,CAAC;4BAC3B,OAAO,CAAC,MAAM,CAAC;gCACb,IAAI,EAAE,YAAY;gCAClB,SAAS,EAAE,eAAe;gCAC1B,IAAI,EAAE;oCACJ,KAAK,EAAE,MAAM,CAAC,UAAU,CAAC;iCAC1B;gCACD,OAAO,EAAE;oCACP;wCACE,SAAS,EAAE,YAAY;wCACvB,GAAG,EAAE,CAAC,KAAyB,EAAE,EAAE;4CACjC,IAAI,CAAC;gDACH,kDAAkD;gDAClD,OAAO,KAAK,CAAC,WAAW,CAAC;oDACvB,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC;oDACjB,KAAK,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC;iDACjC,CAAC,CAAC;4CACL,CAAC;4CAAC,MAAM,CAAC;gDACP,OAAO,IAAI,CAAC;4CACd,CAAC;wCACH,CAAC;qCACF;oCACD;wCACE,SAAS,EAAE,mBAAmB;wCAC9B,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI;qCAChB;iCACF;6BACF,CAAC,CAAC;wBACL,CAAC;oBACH,CAAC;gBACH,CAAC,CAAC,CAAC;YACL,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC"}
|
|
@@ -13,6 +13,7 @@ exports.noConsoleSpaces = (0, eslint_devkit_1.createRule)({
|
|
|
13
13
|
meta: {
|
|
14
14
|
type: 'problem',
|
|
15
15
|
docs: {
|
|
16
|
+
url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/no-console-spaces.md',
|
|
16
17
|
description: 'Prevent leading/trailing space between console.log parameters',
|
|
17
18
|
},
|
|
18
19
|
fixable: 'code',
|
|
@@ -43,6 +44,7 @@ exports.noConsoleSpaces = (0, eslint_devkit_1.createRule)({
|
|
|
43
44
|
'group',
|
|
44
45
|
'groupCollapsed',
|
|
45
46
|
]);
|
|
47
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
46
48
|
function isInAllowedContext() {
|
|
47
49
|
// For simplicity, we'll skip the allow option for now
|
|
48
50
|
return false;
|
|
@@ -58,6 +60,7 @@ exports.noConsoleSpaces = (0, eslint_devkit_1.createRule)({
|
|
|
58
60
|
}
|
|
59
61
|
return false;
|
|
60
62
|
}
|
|
63
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
61
64
|
function getConsoleMethodName(node) {
|
|
62
65
|
// Safe extraction of console method name
|
|
63
66
|
if (node.callee.type === 'MemberExpression' &&
|
|
@@ -66,12 +69,14 @@ exports.noConsoleSpaces = (0, eslint_devkit_1.createRule)({
|
|
|
66
69
|
}
|
|
67
70
|
return 'console';
|
|
68
71
|
}
|
|
72
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
69
73
|
function hasLeadingOrTrailingSpaces(text) {
|
|
70
74
|
// Check if string starts or ends with whitespace, but not if it's only whitespace
|
|
71
75
|
// Only flag if there's actual content with leading/trailing spaces
|
|
72
76
|
const trimmed = text.trim();
|
|
73
77
|
return trimmed.length > 0 && /^\s|\s$/.test(text);
|
|
74
78
|
}
|
|
79
|
+
// oxlint-disable-next-line consistent-function-scoping
|
|
75
80
|
function hasLeadingOrTrailingSpacesInTemplate(text) {
|
|
76
81
|
// For template literals, even whitespace-only quasis should be flagged
|
|
77
82
|
return /^\s|\s$/.test(text);
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-console-spaces.js","sourceRoot":"","sources":["
|
|
1
|
+
{"version":3,"file":"no-console-spaces.js","sourceRoot":"","sources":["../../../../src/rules/conventions/no-console-spaces.ts"],"names":[],"mappings":";AAAA;;;;GAIG;;;AAOH,4DAAsD;AACtD,4DAA0E;AAM7D,QAAA,eAAe,GAAG,IAAA,0BAAU,EAA0B;IACjE,IAAI,EAAE,mBAAmB;IACzB,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,GAAG,EAAE,oHAAoH;YACzH,WAAW,EACT,+DAA+D;SAClE;QACD,OAAO,EAAE,MAAM;QACf,cAAc,EAAE,IAAI;QACpB,QAAQ,EAAE;YACR,eAAe,EAAE,IAAA,gCAAgB,EAAC;gBAChC,IAAI,EAAE,4BAAY,CAAC,OAAO;gBAC1B,SAAS,EAAE,gBAAgB;gBAC3B,WAAW,EACT,6DAA6D;gBAC/D,QAAQ,EAAE,QAAQ;gBAClB,GAAG,EAAE,6CAA6C;gBAClD,iBAAiB,EACf,iGAAiG;aACpG,CAAC;SACH;QACD,MAAM,EAAE,EAAE;KACX;IACD,cAAc,EAAE,EAAE;IAElB,MAAM,CAAC,OAAsD;QAC3D,mDAAmD;QACnD,MAAM,cAAc,GAAG,IAAI,GAAG,CAAC;YAC7B,KAAK;YACL,OAAO;YACP,MAAM;YACN,MAAM;YACN,OAAO;YACP,OAAO;YACP,OAAO;YACP,OAAO;YACP,gBAAgB;SACjB,CAAC,CAAC;QAEH,uDAAuD;QACvD,SAAS,kBAAkB;YACzB,sDAAsD;YACtD,OAAO,KAAK,CAAC;QACf,CAAC;QAED,SAAS,mBAAmB,CAAC,IAA6B;YACxD,8CAA8C;YAC9C,IACE,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;gBACvC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY;gBACxC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,SAAS;gBACrC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY;gBAC1C,cAAc,CAAC,GAAG,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,EAC7C,CAAC;gBACD,OAAO,IAAI,CAAC;YACd,CAAC;YAED,OAAO,KAAK,CAAC;QACf,CAAC;QAED,uDAAuD;QACvD,SAAS,oBAAoB,CAAC,IAA6B;YACzD,yCAAyC;YACzC,IACE,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;gBACvC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY,EAC1C,CAAC;gBACD,OAAO,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC;YACnC,CAAC;YACD,OAAO,SAAS,CAAC;QACnB,CAAC;QAED,uDAAuD;QACvD,SAAS,0BAA0B,CAAC,IAAY;YAC9C,kFAAkF;YAClF,mEAAmE;YACnE,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;YAC5B,OAAO,OAAO,CAAC,MAAM,GAAG,CAAC,IAAI,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACpD,CAAC;QAED,uDAAuD;QACvD,SAAS,oCAAoC,CAAC,IAAY;YACxD,uEAAuE;YACvE,OAAO,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC9B,CAAC;QAED,OAAO;YACL,cAAc,CAAC,IAA6B;gBAC1C,IAAI,mBAAmB,CAAC,IAAI,CAAC,IAAI,CAAC,kBAAkB,EAAE,EAAE,CAAC;oBACvD,kDAAkD;oBAClD,KAAK,MAAM,GAAG,IAAI,IAAI,CAAC,SAAS,EAAE,CAAC;wBACjC,IAAI,GAAG,CAAC,IAAI,KAAK,SAAS,IAAI,OAAO,GAAG,CAAC,KAAK,KAAK,QAAQ,EAAE,CAAC;4BAC5D,IAAI,0BAA0B,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC;gCAC1C,OAAO,CAAC,MAAM,CAAC;oCACb,IAAI,EAAE,GAAG;oCACT,SAAS,EAAE,iBAAiB;oCAC5B,IAAI,EAAE;wCACJ,MAAM,EAAE,oBAAoB,CAAC,IAAI,CAAC;wCAClC,GAAG,EAAE,GAAG,CAAC,KAAK;qCACf;oCACD,GAAG,CAAC,KAAyB;wCAC3B,MAAM,OAAO,GAAG,GAAG,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;wCACjC,OAAO,KAAK,CAAC,WAAW,CAAC,GAAG,EAAE,IAAI,OAAO,GAAG,CAAC,CAAC;oCAChD,CAAC;iCACF,CAAC,CAAC;4BACL,CAAC;wBACH,CAAC;6BAAM,IAAI,GAAG,CAAC,IAAI,KAAK,iBAAiB,EAAE,CAAC;4BAC1C,kEAAkE;4BAClE,IAAI,mBAAmB,GAAG,KAAK,CAAC;4BAChC,KAAK,MAAM,KAAK,IAAI,GAAG,CAAC,MAAM,EAAE,CAAC;gCAC/B,IAAI,oCAAoC,CAAC,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,EAAE,CAAC;oCAC1D,mBAAmB,GAAG,IAAI,CAAC;oCAC3B,MAAM;gCACR,CAAC;4BACH,CAAC;4BAED,IAAI,mBAAmB,EAAE,CAAC;gCACxB,OAAO,CAAC,MAAM,CAAC;oCACb,IAAI,EAAE,GAAG;oCACT,SAAS,EAAE,iBAAiB;oCAC5B,IAAI,EAAE;wCACJ,MAAM,EAAE,oBAAoB,CAAC,IAAI,CAAC;wCAClC,GAAG,EAAE,8BAA8B;qCACpC;oCACD,oDAAoD;oCACpD,GAAG,EAAE,IAAI;iCACV,CAAC,CAAC;4BACL,CAAC;wBACH,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC"}
|
|
@@ -76,6 +76,7 @@ exports.noJsonSchemaTags = (0, eslint_devkit_1.createRule)({
|
|
|
76
76
|
meta: {
|
|
77
77
|
type: 'suggestion',
|
|
78
78
|
docs: {
|
|
79
|
+
url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-conventions/docs/rules/no-json-schema-tags.md',
|
|
79
80
|
description: 'Disallow JSON Schema keywords used as JSDoc tags (e.g. @minimum, @maximum)',
|
|
80
81
|
},
|
|
81
82
|
hasSuggestions: true,
|
|
@@ -120,7 +121,7 @@ exports.noJsonSchemaTags = (0, eslint_devkit_1.createRule)({
|
|
|
120
121
|
for (const tag of additionalForbiddenTags) {
|
|
121
122
|
forbiddenTags.add(tag);
|
|
122
123
|
}
|
|
123
|
-
const sourceCode = context.sourceCode
|
|
124
|
+
const sourceCode = context.sourceCode;
|
|
124
125
|
return {
|
|
125
126
|
Program() {
|
|
126
127
|
const comments = sourceCode.getAllComments();
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-json-schema-tags.js","sourceRoot":"","sources":["
|
|
1
|
+
{"version":3,"file":"no-json-schema-tags.js","sourceRoot":"","sources":["../../../../src/rules/conventions/no-json-schema-tags.ts"],"names":[],"mappings":";AAAA;;;;GAIG;;;AAiBH,4DAIkC;AAWlC;;;;GAIG;AACH,MAAM,sBAAsB,GAAG,IAAI,GAAG,CAAC;IACrC,SAAS;IACT,SAAS;IACT,kBAAkB;IAClB,kBAAkB;IAClB,WAAW;IACX,WAAW;IACX,UAAU;IACV,UAAU;IACV,eAAe;IACf,eAAe;IACf,YAAY;IACZ,SAAS;IACT,aAAa;IACb,OAAO;IACP,MAAM;IACN,QAAQ;IACR,kBAAkB;IAClB,iBAAiB;CAClB,CAAC,CAAC;AAEH;;GAEG;AACH,SAAS,iBAAiB,CACxB,WAAmB,EACnB,YAAyB;IAEzB,MAAM,OAAO,GAAsC,EAAE,CAAC;IAEtD,uEAAuE;IACvE,+DAA+D;IAC/D,MAAM,QAAQ,GAAG,4BAA4B,CAAC;IAC9C,IAAI,KAA6B,CAAC;IAElC,OAAO,CAAC,KAAK,GAAG,QAAQ,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;QACrD,MAAM,OAAO,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;QACzB,IAAI,YAAY,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC;YAC9B,OAAO,CAAC,IAAI,CAAC,EAAE,GAAG,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,CAAC,KAAK,EAAE,CAAC,CAAC;QACtD,CAAC;IACH,CAAC;IAED,OAAO,OAAO,CAAC;AACjB,CAAC;AAED;;;GAGG;AACH,SAAS,iBAAiB,CAAC,GAAW;IACpC,MAAM,WAAW,GAA2B;QAC1C,OAAO,EAAE,iEAAiE;QAC1E,OAAO,EAAE,mEAAmE;QAC5E,gBAAgB,EAAE,iDAAiD;QACnE,gBAAgB,EAAE,mDAAmD;QACrE,SAAS,EAAE,kEAAkE;QAC7E,SAAS,EAAE,oEAAoE;QAC/E,QAAQ,EAAE,6DAA6D;QACvE,QAAQ,EAAE,8DAA8D;QACxE,OAAO,EAAE,iDAAiD;QAC1D,IAAI,EAAE,oDAAoD;QAC1D,KAAK,EAAE,kEAAkE;QACzE,MAAM,EAAE,qEAAqE;KAC9E,CAAC;IAEF,OAAO,CACL,WAAW,CAAC,GAAG,CAAC;QAChB,4DAA4D,CAC7D,CAAC;AACJ,CAAC;AAEY,QAAA,gBAAgB,GAAG,IAAA,0BAAU,EAA0B;IAClE,IAAI,EAAE,qBAAqB;IAC3B,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,GAAG,EAAE,sHAAsH;YAC3H,WAAW,EACT,4EAA4E;SAC/E;QACD,cAAc,EAAE,IAAI;QACpB,QAAQ,EAAE;YACR,aAAa,EAAE,IAAA,gCAAgB,EAAC;gBAC9B,IAAI,EAAE,4BAAY,CAAC,OAAO;gBAC1B,SAAS,EAAE,0BAA0B;gBACrC,WAAW,EACT,qKAAqK;gBACvK,QAAQ,EAAE,QAAQ;gBAClB,GAAG,EAAE,oFAAoF;gBACzF,iBAAiB,EAAE,2CAA2C;aAC/D,CAAC;YACF,iBAAiB,EAAE,IAAA,gCAAgB,EAAC;gBAClC,IAAI,EAAE,4BAAY,CAAC,IAAI;gBACvB,SAAS,EAAE,0BAA0B;gBACrC,WAAW,EACT,8EAA8E;gBAChF,QAAQ,EAAE,KAAK;gBACf,GAAG,EAAE,8EAA8E;gBACnF,iBAAiB,EAAE,2CAA2C;aAC/D,CAAC;SACH;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,uBAAuB,EAAE;wBACvB,IAAI,EAAE,OAAO;wBACb,KAAK,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACzB,OAAO,EAAE,EAAE;wBACX,WAAW,EAAE,gCAAgC;qBAC9C;iBACF;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;KACF;IACD,cAAc,EAAE,CAAC,EAAE,uBAAuB,EAAE,EAAE,EAAE,CAAC;IACjD,MAAM,CACJ,OAAsD,EACtD,CAAC,OAAO,GAAG,EAAE,CAAC;QAEd,MAAM,EAAE,uBAAuB,GAAG,EAAE,EAAE,GAAG,OAAkB,CAAC;QAE5D,uCAAuC;QACvC,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC,sBAAsB,CAAC,CAAC;QACtD,KAAK,MAAM,GAAG,IAAI,uBAAuB,EAAE,CAAC;YAC1C,aAAa,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;QACzB,CAAC;QAED,MAAM,UAAU,GAAG,OAAO,CAAC,UAAU,CAAC;QAEtC,OAAO;YACL,OAAO;gBACL,MAAM,QAAQ,GAAG,UAAU,CAAC,cAAc,EAAE,CAAC;gBAE7C,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;oBAC/B,wDAAwD;oBACxD,IAAI,OAAO,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;wBAC7B,SAAS;oBACX,CAAC;oBAED,MAAM,WAAW,GAAG,OAAO,CAAC,KAAK,CAAC;oBAClC,MAAM,IAAI,GAAG,iBAAiB,CAAC,WAAW,EAAE,aAAa,CAAC,CAAC;oBAE3D,KAAK,MAAM,EAAE,GAAG,EAAE,MAAM,EAAE,IAAI,IAAI,EAAE,CAAC;wBACnC,oCAAoC;wBACpC,yDAAyD;wBACzD,MAAM,aAAa,GAChB,OAA0D;6BACxD,KAAK,CAAC,CAAC,CAAC;4BACX,CAAC;4BACD,MAAM,CAAC;wBACT,MAAM,WAAW,GAAG,aAAa,GAAG,CAAC,GAAG,GAAG,CAAC,MAAM,CAAC,CAAC,gBAAgB;wBAEpE,MAAM,UAAU,GAAG,iBAAiB,CAAC,GAAG,CAAC,CAAC;wBAE1C,OAAO,CAAC,MAAM,CAAC;4BACb,GAAG,EAAE;gCACH,KAAK,EAAE,UAAU,CAAC,eAAe,CAAC,aAAa,CAAC;gCAChD,GAAG,EAAE,UAAU,CAAC,eAAe,CAAC,WAAW,CAAC;6BAC7C;4BACD,SAAS,EAAE,eAAe;4BAC1B,IAAI,EAAE;gCACJ,GAAG;gCACH,UAAU;6BACX;4BACD,OAAO,EAAE;gCACP;oCACE,SAAS,EAAE,mBAAmB;oCAC9B,IAAI,EAAE,EAAE,GAAG,EAAE;oCACb,GAAG,EAAE,CAAC,KAAyB,EAAE,EAAE;wCACjC,wDAAwD;wCACxD,2BAA2B;wCAC3B,MAAM,UAAU,GAAG,UAAU,CAAC,OAAO,EAAE,CAAC;wCACxC,IAAI,SAAS,GAAG,aAAa,CAAC;wCAC9B,OAAO,SAAS,GAAG,CAAC,IAAI,UAAU,CAAC,SAAS,GAAG,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;4CAC3D,SAAS,EAAE,CAAC;wCACd,CAAC;wCACD,IAAI,OAAO,GAAG,WAAW,CAAC;wCAC1B,OACE,OAAO,GAAG,UAAU,CAAC,MAAM;4CAC3B,UAAU,CAAC,OAAO,CAAC,KAAK,IAAI,EAC5B,CAAC;4CACD,OAAO,EAAE,CAAC;wCACZ,CAAC;wCACD,0CAA0C;wCAC1C,IAAI,OAAO,GAAG,UAAU,CAAC,MAAM,IAAI,UAAU,CAAC,OAAO,CAAC,KAAK,IAAI,EAAE,CAAC;4CAChE,OAAO,EAAE,CAAC;wCACZ,CAAC;wCACD,OAAO,KAAK,CAAC,WAAW,CAAC,CAAC,SAAS,EAAE,OAAO,CAAC,CAAC,CAAC;oCACjD,CAAC;iCACF;6BACF;yBACF,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC"}
|
|
@@ -0,0 +1,41 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* Copyright (c) 2025 Ofri Peretz
|
|
3
|
+
* Licensed under the MIT License. Use of this source code is governed by the
|
|
4
|
+
* MIT license that can be found in the LICENSE file.
|
|
5
|
+
*/
|
|
6
|
+
/**
|
|
7
|
+
* ESLint Rule: no-magic-numbers
|
|
8
|
+
* Flags numeric literals that are not self-documenting — i.e., numbers that
|
|
9
|
+
* appear in code without a named constant explaining their meaning.
|
|
10
|
+
*
|
|
11
|
+
* Beats ESLint core's no-magic-numbers in two ways:
|
|
12
|
+
* 1. Built-in allowlist covers idiomatic JS patterns (array indices, bit
|
|
13
|
+
* masks, HTTP status codes family boundaries) so teams don't need to
|
|
14
|
+
* enumerate common safe values.
|
|
15
|
+
* 2. Skips enums, default parameter values, and export declarations where
|
|
16
|
+
* the context already provides naming.
|
|
17
|
+
*
|
|
18
|
+
* @see https://refactoring.guru/replace-magic-literal
|
|
19
|
+
*/
|
|
20
|
+
import type { TSESLint } from '@interlace/eslint-devkit';
|
|
21
|
+
type MessageIds = 'noMagicNumber' | 'extractConst';
|
|
22
|
+
export interface Options {
|
|
23
|
+
/**
|
|
24
|
+
* Numbers that are always allowed regardless of context.
|
|
25
|
+
* Defaults to [-1, 0, 1, 2] — universally idiomatic.
|
|
26
|
+
*/
|
|
27
|
+
ignore?: number[];
|
|
28
|
+
/** Allow numbers used as array indices (e.g., `items[2]`). Default: true */
|
|
29
|
+
ignoreArrayIndexes?: boolean;
|
|
30
|
+
/** Allow numbers in default parameter values (e.g., `function f(n = 10)`). Default: true */
|
|
31
|
+
ignoreDefaultValues?: boolean;
|
|
32
|
+
/** Allow numbers in enum member initializers. Default: true */
|
|
33
|
+
ignoreEnums?: boolean;
|
|
34
|
+
/** Allow numbers in bitwise expressions. Default: false */
|
|
35
|
+
ignoreBitwiseExpressions?: boolean;
|
|
36
|
+
}
|
|
37
|
+
type RuleOptions = [Options?];
|
|
38
|
+
export declare const noMagicNumbers: TSESLint.RuleModule<MessageIds, RuleOptions, unknown, TSESLint.RuleListener> & {
|
|
39
|
+
name: string;
|
|
40
|
+
};
|
|
41
|
+
export {};
|