eslint-plugin-complete 1.0.3 → 1.0.5

package/dist/rules/no-mutable-return.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"no-mutable-return.d.ts","sourceRoot":"","sources":["../../src/rules/no-mutable-return.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAMvD,KAAK,UAAU,GAAG,cAAc,GAAG,YAAY,GAAG,YAAY,CAAC;AAE/D,eAAO,MAAM,eAAe,wHA6C1B,CAAC"}
+{"version":3,"file":"no-mutable-return.d.ts","sourceRoot":"","sources":["../../src/rules/no-mutable-return.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAMvD,KAAK,UAAU,GAAG,cAAc,GAAG,YAAY,GAAG,YAAY,CAAC;AAE/D,eAAO,MAAM,eAAe,wHA6C1B,CAAC"}

package/dist/rules/no-mutable-return.js

@@ -1,3 +1,4 @@
+import { isTypeReferenceType } from "@typescript-eslint/type-utils";
 import { ESLintUtils } from "@typescript-eslint/utils";
 import { getTypeName, unionTypeParts } from "../typeUtils.js";
 import { createRule } from "../utils.js";
@@ -47,6 +48,15 @@ function getErrorMessageId(type) {
     if (typeName === undefined) {
         return undefined;
     }
+    // Handle unwrapping promises.
+    if (typeName === "Promise" &&
+        isTypeReferenceType(type) &&
+        type.typeArguments !== undefined) {
+        const typeArgument = type.typeArguments[0];
+        if (typeArgument !== undefined) {
+            return getErrorMessageId(typeArgument);
+        }
+    }
     // This would be "ReadonlyMap" if it was the read-only version.
     if (typeName === "Map") {
         return "mutableMap";

package/dist/rules/require-variadic-function-argument.js

@@ -57,11 +57,15 @@ export const requireVariadicFunctionArgument = createRule({
 });
 function isHardCodedException(node) {
     const { callee } = node;
-    return (isConsoleOrWindowFunction(callee) ||
-        isTimeoutFunction(callee) ||
-        isLoggerMethod(callee));
+    return isConsoleOrWindowOrLoggerFunction(callee) || isTimeoutFunction(callee);
 }
-function isConsoleOrWindowFunction(callee) {
+/**
+ * This rule has a false positive with any logger function. (Both `console.log` and logger functions
+ * from logging libraries like Pino and Winston are affected.)
+ *
+ * e.g. `logger.info("hello world");`
+ */
+function isConsoleOrWindowOrLoggerFunction(callee) {
     if (callee.type !== AST_NODE_TYPES.MemberExpression) {
         return false;
     }
@@ -69,7 +73,9 @@ function isConsoleOrWindowFunction(callee) {
     if (object.type !== AST_NODE_TYPES.Identifier) {
         return false;
     }
-    return object.name === "console" || object.name === "window";
+    return (object.name === "console" ||
+        object.name === "window" ||
+        object.name === "logger");
 }
 function isTimeoutFunction(callee) {
     if (callee.type !== AST_NODE_TYPES.Identifier) {
@@ -77,28 +83,6 @@ function isTimeoutFunction(callee) {
     }
     return callee.name === "setTimeout" || callee.name === "setInterval";
 }
-/**
- * This rule has a false positive with any Pino logger function.
- *
- * e.g. `logger.info("hello world");`
- *
- * @see https://github.com/pinojs/pino
- */
-function isLoggerMethod(callee) {
-    if (callee.type !== AST_NODE_TYPES.MemberExpression) {
-        return false;
-    }
-    const { object } = callee;
-    if (object.type !== AST_NODE_TYPES.Identifier) {
-        return false;
-    }
-    return (object.name === "trace" ||
-        object.name === "debug" ||
-        object.name === "info" ||
-        object.name === "warn" ||
-        object.name === "error" ||
-        object.name === "fatal");
-}
 function hasJSDocExceptionTag(checker, declaration) {
     const type = checker.getTypeAtLocation(declaration);
     const symbol = type.getSymbol();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-complete",
-  "version": "1.0.3",
+  "version": "1.0.5",
   "description": "An ESLint plugin that contains useful rules.",
   "keywords": [
     "eslint",
@@ -44,9 +44,9 @@
     "test": "jest"
   },
   "dependencies": {
-    "@typescript-eslint/type-utils": "^8.7.0",
-    "@typescript-eslint/utils": "^8.7.0",
-    "typescript-eslint": "^8.7.0"
+    "@typescript-eslint/type-utils": "^8.8.0",
+    "@typescript-eslint/utils": "^8.8.0",
+    "typescript-eslint": "^8.8.0"
   },
   "devDependencies": {
     "@babel/core": "^7.25.2",
@@ -54,8 +54,8 @@
     "@babel/preset-typescript": "^7.24.7",
     "@types/jest": "^29.5.13",
     "@types/node": "^22.7.4",
-    "@typescript-eslint/rule-tester": "^8.7.0",
-    "@typescript-eslint/types": "^8.7.0",
+    "@typescript-eslint/rule-tester": "^8.8.0",
+    "@typescript-eslint/types": "^8.8.0",
     "complete-common": "^1.0.0",
     "complete-node": "^1.5.1",
     "jest": "^29.7.0",