eslint-plugin-complete 1.0.3 → 1.0.4

package/dist/rules/require-variadic-function-argument.js

@@ -57,11 +57,15 @@ export const requireVariadicFunctionArgument = createRule({
 });
 function isHardCodedException(node) {
     const { callee } = node;
-    return (isConsoleOrWindowFunction(callee) ||
-        isTimeoutFunction(callee) ||
-        isLoggerMethod(callee));
+    return isConsoleOrWindowOrLoggerFunction(callee) || isTimeoutFunction(callee);
 }
-function isConsoleOrWindowFunction(callee) {
+/**
+ * This rule has a false positive with any logger function. (Both `console.log` and logger functions
+ * from logging libraries like Pino and Winston are affected.)
+ *
+ * e.g. `logger.info("hello world");`
+ */
+function isConsoleOrWindowOrLoggerFunction(callee) {
     if (callee.type !== AST_NODE_TYPES.MemberExpression) {
         return false;
     }
@@ -69,7 +73,9 @@ function isConsoleOrWindowFunction(callee) {
     if (object.type !== AST_NODE_TYPES.Identifier) {
         return false;
     }
-    return object.name === "console" || object.name === "window";
+    return (object.name === "console" ||
+        object.name === "window" ||
+        object.name === "logger");
 }
 function isTimeoutFunction(callee) {
     if (callee.type !== AST_NODE_TYPES.Identifier) {
@@ -77,28 +83,6 @@ function isTimeoutFunction(callee) {
     }
     return callee.name === "setTimeout" || callee.name === "setInterval";
 }
-/**
- * This rule has a false positive with any Pino logger function.
- *
- * e.g. `logger.info("hello world");`
- *
- * @see https://github.com/pinojs/pino
- */
-function isLoggerMethod(callee) {
-    if (callee.type !== AST_NODE_TYPES.MemberExpression) {
-        return false;
-    }
-    const { object } = callee;
-    if (object.type !== AST_NODE_TYPES.Identifier) {
-        return false;
-    }
-    return (object.name === "trace" ||
-        object.name === "debug" ||
-        object.name === "info" ||
-        object.name === "warn" ||
-        object.name === "error" ||
-        object.name === "fatal");
-}
 function hasJSDocExceptionTag(checker, declaration) {
     const type = checker.getTypeAtLocation(declaration);
     const symbol = type.getSymbol();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-complete",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "An ESLint plugin that contains useful rules.",
   "keywords": [
     "eslint",