eslint-plugin-code-style 1.9.3 → 1.9.5

package/CHANGELOG.md

@@ -7,6 +7,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+## [1.9.5] - 2026-02-03
+
+### Fixed
+
+- **`no-hardcoded-strings`** - Fix bug where strings inside exported components were incorrectly skipped:
+  - Previously: `export const Component = () => { const name = "ahmed" }` was not detected
+  - Now: Strings inside functions are properly detected regardless of export status
+  - Only direct constant exports are skipped: `export const MESSAGE = "value"` or `export const DATA = { key: "value" }`
+
+---
+
+## [1.9.4] - 2026-02-03
+
+### Enhanced
+
+- **`no-hardcoded-strings`** - Skip UI component patterns only in JSX attributes:
+  - In JSX attributes: `<Button variant="ghost" />` is now ignored
+  - In logic: `const status = "success"` or `setValue("primary")` is still detected
+  - UI patterns: `primary`, `secondary`, `ghost`, `outline`, `link`, `muted`, `danger`, `warning`, `success`, `error`, `sm`, `md`, `lg`, `xl`, `left`, `right`, `center`, `top`, `bottom`, `hover`, `focus`, `click`, etc.
+
+---
+
 ## [1.9.3] - 2026-02-03
 
 ### Enhanced
@@ -1288,6 +1310,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+[1.9.5]: https://github.com/Mohamed-Elhawary/eslint-plugin-code-style/compare/v1.9.4...v1.9.5
+[1.9.4]: https://github.com/Mohamed-Elhawary/eslint-plugin-code-style/compare/v1.9.3...v1.9.4
 [1.9.3]: https://github.com/Mohamed-Elhawary/eslint-plugin-code-style/compare/v1.9.2...v1.9.3
 [1.9.2]: https://github.com/Mohamed-Elhawary/eslint-plugin-code-style/compare/v1.9.1...v1.9.2
 [1.9.1]: https://github.com/Mohamed-Elhawary/eslint-plugin-code-style/compare/v1.9.0...v1.9.1

package/index.js

@@ -14090,6 +14090,9 @@ const noHardcodedStrings = {
 
         const allIgnorePatterns = [...technicalPatterns, ...extraIgnorePatterns];
 
+        // UI component patterns - only ignored in JSX attributes, not in logic
+        const uiComponentPattern = /^(primary|secondary|tertiary|ghost|outline|link|muted|danger|warning|info|success|error|default|subtle|solid|soft|plain|flat|elevated|filled|tonal|text|contained|standard|xs|sm|md|lg|xl|2xl|3xl|4xl|5xl|xxs|xxl|small|medium|large|tiny|huge|compact|comfortable|spacious|left|right|center|top|bottom|start|end|middle|baseline|stretch|between|around|evenly|horizontal|vertical|row|column|inline|block|flex|grid|auto|none|hidden|visible|static|relative|absolute|fixed|sticky|on|off|hover|focus|click|blur|always|never)$/;
+
         // HTTP status codes that should NOT be hardcoded (2xx, 4xx, and 5xx)
         const httpStatusCodePattern = /^[245]\d{2}$/;
 
@@ -14418,8 +14421,11 @@ const noHardcodedStrings = {
         // Check if string is in an object that looks like constants definition
         const isInConstantsObjectHandler = (node) => {
             let current = node.parent;
+            let depth = 0;
 
             while (current) {
+                depth++;
+
                 if (current.type === "VariableDeclarator") {
                     const varName = current.id && current.id.name;
 
@@ -14437,9 +14443,34 @@ const noHardcodedStrings = {
                     }
                 }
 
-                // Check for export const CONSTANT_NAME = "value"
-                if (current.type === "ExportNamedDeclaration") {
-                    return true;
+                // Check for export const CONSTANT_NAME = "value" - only direct assignments (depth <= 3)
+                // e.g., export const X = "value" or export const X = { key: "value" }
+                // But NOT strings inside exported functions like export const Component = () => { const x = "value" }
+                if (current.type === "ExportNamedDeclaration" && depth <= 3) {
+                    // Only skip if the export is a direct literal or object, not a function
+                    const declaration = current.declaration;
+
+                    if (declaration && declaration.type === "VariableDeclaration") {
+                        const declarator = declaration.declarations[0];
+
+                        if (declarator && declarator.init) {
+                            const initType = declarator.init.type;
+
+                            // Skip if it's a direct string, object, or array constant
+                            if (initType === "Literal" || initType === "ObjectExpression" || initType === "ArrayExpression") {
+                                return true;
+                            }
+                        }
+                    }
+                }
+
+                // Stop traversing if we hit a function - strings inside functions should be checked
+                if (
+                    current.type === "FunctionDeclaration"
+                    || current.type === "FunctionExpression"
+                    || current.type === "ArrowFunctionExpression"
+                ) {
+                    return false;
                 }
 
                 current = current.parent;
@@ -14545,6 +14576,9 @@ const noHardcodedStrings = {
                 if (node.value.type === "Literal" && typeof node.value.value === "string") {
                     const str = node.value.value;
 
+                    // Skip UI component patterns in JSX attributes (variant, size, position props)
+                    if (uiComponentPattern.test(str)) return;
+
                     // Check if it's a flagged special string (status code, role name)
                     const isSpecialString = isFlaggedSpecialStringHandler(str);
 
@@ -14569,6 +14603,9 @@ const noHardcodedStrings = {
                     if (expression.type === "Literal" && typeof expression.value === "string") {
                         const str = expression.value;
 
+                        // Skip UI component patterns in JSX attributes (variant, size, position props)
+                        if (uiComponentPattern.test(str)) return;
+
                         // Check if it's a flagged special string (status code, role name)
                         const isSpecialString = isFlaggedSpecialStringHandler(str);
 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "eslint-plugin-code-style",
-    "version": "1.9.3",
+    "version": "1.9.5",
     "description": "A custom ESLint plugin for enforcing consistent code formatting and style rules in React/JSX projects",
     "main": "index.js",
     "types": "index.d.ts",