eslint-plugin-code-style 1.9.2 → 1.9.4

package/CHANGELOG.md

@@ -7,6 +7,30 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+## [1.9.4] - 2026-02-03
+
+### Enhanced
+
+- **`no-hardcoded-strings`** - Skip UI component patterns only in JSX attributes:
+  - In JSX attributes: `<Button variant="ghost" />` is now ignored
+  - In logic: `const status = "success"` or `setValue("primary")` is still detected
+  - UI patterns: `primary`, `secondary`, `ghost`, `outline`, `link`, `muted`, `danger`, `warning`, `success`, `error`, `sm`, `md`, `lg`, `xl`, `left`, `right`, `center`, `top`, `bottom`, `hover`, `focus`, `click`, etc.
+
+---
+
+## [1.9.3] - 2026-02-03
+
+### Enhanced
+
+- **`no-hardcoded-strings`** - Remove single-word string length limitations and add more special cases:
+  - Removed length restrictions (now detects all single-word hardcoded strings)
+  - Added validation strings: `empty`, `invalid`, `missing`, `optional`, `required`, `valid`
+  - Added auth state strings: `anonymous`, `authenticated`, `authed`, `authorized`, `denied`, `forbidden`, `granted`, `locked`, `loggedin`, `loggedout`, `revoked`, `unauthenticated`, `unauthorized`, `unlocked`, `unverified`, `verified`
+  - Added more status strings: `done`, `finished`, `inprogress`, `queued`, `ready`, `running`, `started`, `stopped`, `successful`, `waiting`
+  - Made technical patterns stricter to avoid false negatives (camelCase requires uppercase in middle, snake_case requires underscore, kebab-case requires hyphen)
+
+---
+
 ## [1.9.2] - 2026-02-03
 
 ### Enhanced
@@ -1275,6 +1299,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+[1.9.4]: https://github.com/Mohamed-Elhawary/eslint-plugin-code-style/compare/v1.9.3...v1.9.4
+[1.9.3]: https://github.com/Mohamed-Elhawary/eslint-plugin-code-style/compare/v1.9.2...v1.9.3
 [1.9.2]: https://github.com/Mohamed-Elhawary/eslint-plugin-code-style/compare/v1.9.1...v1.9.2
 [1.9.1]: https://github.com/Mohamed-Elhawary/eslint-plugin-code-style/compare/v1.9.0...v1.9.1
 [1.9.0]: https://github.com/Mohamed-Elhawary/eslint-plugin-code-style/compare/v1.8.4...v1.9.0

package/index.js

@@ -14055,20 +14055,21 @@ const noHardcodedStrings = {
             /^\d{4}-\d{2}-\d{2}(T\d{2}:\d{2}:\d{2})?/,
             // Time formats
             /^\d{1,2}:\d{2}(:\d{2})?(\s?(AM|PM|am|pm))?$/,
-            // JSON keys (camelCase, snake_case, SCREAMING_SNAKE_CASE)
-            /^[a-z][a-zA-Z0-9]*$/,
-            /^[a-z][a-z0-9_]*$/,
-            /^[A-Z][A-Z0-9_]*$/,
+            // JSON keys - require actual naming convention markers (underscore/uppercase in middle)
+            // camelCase: must have uppercase letter in middle (e.g., userId, firstName)
+            /^[a-z]+[A-Z][a-zA-Z0-9]*$/,
+            // snake_case: must have underscore (e.g., user_id, first_name)
+            /^[a-z][a-z0-9]*_[a-z0-9_]*$/,
+            // SCREAMING_SNAKE_CASE: must have underscore (e.g., MAX_VALUE, API_URL)
+            /^[A-Z][A-Z0-9]*_[A-Z0-9_]+$/,
             // Common technical strings
             /^(true|false|null|undefined|NaN|Infinity)$/,
             // Content types
             /^application\//,
-            // Environment variables pattern
-            /^[A-Z][A-Z0-9_]*$/,
             // Query parameters
             /^[a-z][a-zA-Z0-9_]*=/,
-            // CSS property-like
-            /^[a-z]+(-[a-z]+)*$/,
+            // CSS property-like (kebab-case): must have hyphen (e.g., font-size, background-color)
+            /^[a-z]+-[a-z]+(-[a-z]+)*$/,
             // Numbers with separators
             /^[\d,._]+$/,
             // Semantic version
@@ -14089,6 +14090,9 @@ const noHardcodedStrings = {
 
         const allIgnorePatterns = [...technicalPatterns, ...extraIgnorePatterns];
 
+        // UI component patterns - only ignored in JSX attributes, not in logic
+        const uiComponentPattern = /^(primary|secondary|tertiary|ghost|outline|link|muted|danger|warning|info|success|error|default|subtle|solid|soft|plain|flat|elevated|filled|tonal|text|contained|standard|xs|sm|md|lg|xl|2xl|3xl|4xl|5xl|xxs|xxl|small|medium|large|tiny|huge|compact|comfortable|spacious|left|right|center|top|bottom|start|end|middle|baseline|stretch|between|around|evenly|horizontal|vertical|row|column|inline|block|flex|grid|auto|none|hidden|visible|static|relative|absolute|fixed|sticky|on|off|hover|focus|click|blur|always|never)$/;
+
         // HTTP status codes that should NOT be hardcoded (2xx, 4xx, and 5xx)
         const httpStatusCodePattern = /^[245]\d{2}$/;
 
@@ -14164,23 +14168,64 @@ const noHardcodedStrings = {
             "declined",
             "deleted",
             "disabled",
+            "done",
             "draft",
             "enabled",
             "expired",
             "failed",
+            "finished",
             "inactive",
+            "inprogress",
             "open",
             "paused",
             "pending",
             "processing",
             "published",
+            "queued",
+            "ready",
             "rejected",
             "resolved",
+            "running",
             "scheduled",
+            "started",
+            "stopped",
             "submitted",
             "success",
+            "successful",
             "suspended",
             "verified",
+            "waiting",
+        ]);
+
+        // Validation/form strings that should be imported from enums/data
+        const validationStrings = new Set([
+            "empty",
+            "invalid",
+            "missing",
+            "optional",
+            "required",
+            "valid",
+        ]);
+
+        // Auth/permission state strings that should be imported from enums/data
+        const authStrings = new Set([
+            "anonymous",
+            "authenticated",
+            "authed",
+            "authorized",
+            "denied",
+            "expired",
+            "forbidden",
+            "granted",
+            "locked",
+            "loggedin",
+            "loggedout",
+            "revoked",
+            "unauthenticated",
+            "unauthorized",
+            "unlocked",
+            "unverified",
+            "verified",
         ]);
 
         // Priority levels that should be imported from enums/data
@@ -14203,6 +14248,8 @@ const noHardcodedStrings = {
         const isLogLevelHandler = (str) => logLevels.has(str.toLowerCase());
         const isStatusStringHandler = (str) => statusStrings.has(str.toLowerCase());
         const isPriorityLevelHandler = (str) => priorityLevels.has(str.toLowerCase());
+        const isValidationStringHandler = (str) => validationStrings.has(str.toLowerCase());
+        const isAuthStringHandler = (str) => authStrings.has(str.toLowerCase());
 
         // Check if string should be flagged even if it matches technical patterns
         const isFlaggedSpecialStringHandler = (str) => isHttpStatusCodeHandler(str)
@@ -14211,7 +14258,9 @@ const noHardcodedStrings = {
             || isEnvironmentNameHandler(str)
             || isLogLevelHandler(str)
             || isStatusStringHandler(str)
-            || isPriorityLevelHandler(str);
+            || isPriorityLevelHandler(str)
+            || isValidationStringHandler(str)
+            || isAuthStringHandler(str);
 
         // Get descriptive error message based on string type
         const getErrorMessageHandler = (str, context = "") => {
@@ -14246,6 +14295,14 @@ const noHardcodedStrings = {
                 return `Hardcoded priority level "${truncatedStr}"${contextPart} should be imported from @/enums or @/data`;
             }
 
+            if (isValidationStringHandler(str)) {
+                return `Hardcoded validation string "${truncatedStr}"${contextPart} should be imported from @/enums or @/data`;
+            }
+
+            if (isAuthStringHandler(str)) {
+                return `Hardcoded auth state "${truncatedStr}"${contextPart} should be imported from @/enums or @/data`;
+            }
+
             return `Hardcoded string "${truncatedStr}"${contextPart} should be imported from @/data or @/strings or @/constants or @/@constants or @/@strings`;
         };
 
@@ -14491,6 +14548,9 @@ const noHardcodedStrings = {
                 if (node.value.type === "Literal" && typeof node.value.value === "string") {
                     const str = node.value.value;
 
+                    // Skip UI component patterns in JSX attributes (variant, size, position props)
+                    if (uiComponentPattern.test(str)) return;
+
                     // Check if it's a flagged special string (status code, role name)
                     const isSpecialString = isFlaggedSpecialStringHandler(str);
 
@@ -14499,9 +14559,6 @@ const noHardcodedStrings = {
                     // Check if it looks like user-facing text - skip for special strings
                     if (!isSpecialString && !/[a-zA-Z]/.test(str)) return;
 
-                    // Require multiple words or reasonable length for non-special strings
-                    if (!isSpecialString && str.split(/\s+/).length < 2 && str.length < 10) return;
-
                     context.report({
                         message: getErrorMessageHandler(str, `attribute "${attrName}"`),
                         node: node.value,
@@ -14518,6 +14575,9 @@ const noHardcodedStrings = {
                     if (expression.type === "Literal" && typeof expression.value === "string") {
                         const str = expression.value;
 
+                        // Skip UI component patterns in JSX attributes (variant, size, position props)
+                        if (uiComponentPattern.test(str)) return;
+
                         // Check if it's a flagged special string (status code, role name)
                         const isSpecialString = isFlaggedSpecialStringHandler(str);
 
@@ -14525,9 +14585,6 @@ const noHardcodedStrings = {
 
                         if (!isSpecialString && !/[a-zA-Z]/.test(str)) return;
 
-                        // Require multiple words or reasonable length for non-special strings
-                        if (!isSpecialString && str.split(/\s+/).length < 2 && str.length < 10) return;
-
                         context.report({
                             message: getErrorMessageHandler(str, `attribute "${attrName}"`),
                             node: expression,
@@ -14567,9 +14624,6 @@ const noHardcodedStrings = {
                 // Skip if it doesn't look like user-facing text - but not for special strings
                 if (!isSpecialString && !/[a-zA-Z]/.test(str)) return;
 
-                // Require at least 2 words or be reasonably long - but not for special strings
-                if (!isSpecialString && str.split(/\s+/).length < 2 && str.length < 15) return;
-
                 context.report({
                     message: getErrorMessageHandler(str),
                     node,

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "eslint-plugin-code-style",
-    "version": "1.9.2",
+    "version": "1.9.4",
     "description": "A custom ESLint plugin for enforcing consistent code formatting and style rules in React/JSX projects",
     "main": "index.js",
     "types": "index.d.ts",