eslint-plugin-chrome-extensions 2.7.0 → 2.8.0

package/src/rules/valid-url-fields.js

@@ -6,7 +6,7 @@ import regex from '../data/regex.js'
 const re = {
     absoluteURL: /^[a-z][a-z0-9+.-]*:\/\/[^\s/]+/i,
     match: /^(\*|https?|file|ftp):\/\/([^/]*)(\/.*)$/,
-    template: /\{[^}]+\}/g
+    template: /\{[^{}]+\}/g
 }
 
 function collectStrings(obj, path = [], out = []) {
@@ -15,7 +15,7 @@ function collectStrings(obj, path = [], out = []) {
     else if (Array.isArray(obj))
         for (const elem of obj) collectStrings(elem, path, out)
     else if (typeof obj == 'object')
-        for (const key of Object.keys(obj)) // eslint-disable-next-line security/detect-object-injection
+        for (const key of Object.keys(obj)) // oxlint-disable-next-line security/detect-object-injection
             collectStrings(obj[key], [...path, key], out)
     return out
 }

package/src/rules/valid-version-field.js

@@ -1,11 +1,11 @@
 import extension from '../utils/extension.js'
 import regex from '../data/regex.js'
 
-const re = { /* eslint-disable security/detect-unsafe-regex */
+const re = { // oxlint-disable security/detect-unsafe-regex
     chromeParts: /^\d+(?:\.\d+){0,3}$/,
     date: /^\d{4}\.(?:0?[1-9]|1[0-2])\.(?:0?[1-9]|[12]\d|3[01])(?:\.\d+)?$/,
     semver: /^(?:0|[1-9]\d*)\.(?:0|[1-9]\d*)\.(?:0|[1-9]\d*)$/
-} /* eslint-enable security/detect-unsafe-regex */
+} // oxlint-enable security/detect-unsafe-regex
 
 export default {
     meta: {

package/src/utils/api.js

@@ -0,0 +1,20 @@
+import apis from '../data/apis.js'
+
+export default {
+    findDeprecated(api) {
+        for (const [deprecated, replacement] of apis.deprecated)
+            if (api == deprecated || api.startsWith(`${deprecated}.`))
+                return { deprecated, replacement }
+        return null
+    },
+
+    findPermission(api) {
+        if (apis.permless.has(api)) return null
+        for (const [prefix, permission] of apis.permissionMap)
+            if (api == prefix || api.startsWith(`${prefix}.`))
+                return permission
+        return null
+    },
+
+    isExternalMsgListener(api) { return apis.externalMsgListeners.has(api) }
+}

package/src/utils/extension.js

@@ -1,4 +1,4 @@
-/* eslint-disable security/detect-non-literal-fs-filename -- lint-time test fixtures only */
+// oxlint-disable security/detect-non-literal-fs-filename
 
 import fs from 'node:fs'
 import path from 'node:path'
@@ -40,8 +40,6 @@ const utils = {
 
     manifest: {
         permission: {
-            valid: permissions.valid,
-            sensitive: permissions.sensitive,
             isValid(name, target = 'mv3') {
                 if (permissions.valid.has(name)) return true
                 if (target == 'mv3') return false

package/src/utils/html.js

@@ -0,0 +1,29 @@
+import regex from '../data/regex.js'
+
+export default {
+    isHTML(text) { return text.trimStart().startsWith('<') },
+
+    isRemote(src, allowedPrefixes) {
+        if (!src || allowedPrefixes.some(prefix => src.startsWith(prefix))) return false
+        return regex.scheme.test(src)
+    },
+
+    offsetToLoc(text, offset) {
+        let line = 1, column = 1
+        for (let i = 0; i < offset && i < text.length; i++) {
+            if (text[i] == '\n') { line++ ; column = 1 } // oxlint-disable-line security/detect-object-injection
+            else column++
+        }
+        return { line, column }
+    },
+
+    pickAttrVal(match) { return match ? (match[1] ?? match[2] ?? match[3] ?? '') : null },
+
+    re: {
+        attr: {
+            data: /\sdata\s*=\s*(?:"([^"]*)"|'([^']*)'|([^\s>]+))/i,
+            src: /\ssrc\s*=\s*(?:"([^"]*)"|'([^']*)'|([^\s>]+))/i,
+            type: /\stype\s*=\s*(?:"([^"]*)"|'([^']*)'|([^\s>]+))/i
+        }
+    }
+}

package/src/utils/i18n.js

@@ -1,4 +1,4 @@
-/* eslint-disable security/detect-non-literal-fs-filename -- lint-time test fixtures only */
+// oxlint-disable security/detect-non-literal-fs-filename
 
 import fs from 'node:fs'
 import path from 'node:path'
@@ -7,7 +7,7 @@ import i18n from '../data/i18n.js'
 
 function templateToPattern(body) {
     const parts = body.split(i18n.re.templateExpr).map(part => part.replace(i18n.re.specialChars, '\\$&'))
-    return new RegExp(`^${parts.join('.*')}$`) // eslint-disable-line security/detect-non-literal-regexp
+    return new RegExp(`^${parts.join('.*')}$`) // oxlint-disable-line security/detect-non-literal-regexp
 }
 
 export default {

package/src/utils/init.js

@@ -1,6 +1,7 @@
 import css from '@eslint/css'
 import html from '@html-eslint/eslint-plugin'
 import json from '@eslint/json'
+import pkg from './pkg.js'
 import rulesUtils from './rules.js'
 import text from './text.js'
 
@@ -12,6 +13,8 @@ import noDeprecatedAPIs from '../rules/no-deprecated-apis.js'
 import noDuplicateManifestKeys from '../rules/no-duplicate-manifest-keys.js'
 import noGlobalKeyframes from '../rules/no-global-keyframes.js'
 import noHostPageSelectors from '../rules/no-host-page-selectors.js'
+import noInlineEventHandlers from '../rules/no-inline-event-handlers.js'
+import noInlineScripts from '../rules/no-inline-scripts.js'
 import noInsecureFetch from '../rules/no-insecure-fetch.js'
 import noInsecureMessaging from '../rules/no-insecure-messaging.js'
 import noInvalidLocales from '../rules/no-invalid-locales.js'
@@ -21,6 +24,7 @@ import noMissingI18nKeys from '../rules/no-missing-i18n-keys.js'
 import noMissingPermissions from '../rules/no-missing-permissions.js'
 import noMissingWebAccessibleResources from '../rules/no-missing-web-accessible-resources.js'
 import noRemoteCode from '../rules/no-remote-code.js'
+import noRemoteObjects from '../rules/no-remote-objects.js'
 import noRemoteURLs from '../rules/no-remote-urls.js'
 import noScrollbarStyling from '../rules/no-scrollbar-styling.js'
 import noSensitivePermissions from '../rules/no-sensitive-permissions.js'
@@ -38,7 +42,8 @@ import validServiceWorker from '../rules/valid-service-worker.js'
 import validURLfields from '../rules/valid-url-fields.js'
 import validVersionField from '../rules/valid-version-field.js'
 
-const namespace = 'chrome-extensions'
+const pkgName = pkg.getName(),
+      namespace = pkgName.replace(/^@[^/]+\//, '').replace(/^eslint-plugin-/, '')
 
 export default {
     configs(plugin) {
@@ -67,7 +72,7 @@ export default {
         }
     },
 
-    plugin() { return { rules: {}, configs: {} }},
+    plugin() { return { meta: { name: pkgName }, rules: {}, configs: {} }},
 
     rules(plugin) {
         plugin.rules = {
@@ -79,6 +84,8 @@ export default {
             'no-duplicate-manifest-keys': noDuplicateManifestKeys,
             'no-global-keyframes': noGlobalKeyframes,
             'no-host-page-selectors': noHostPageSelectors,
+            'no-inline-event-handlers': noInlineEventHandlers,
+            'no-inline-scripts': noInlineScripts,
             'no-insecure-fetch': noInsecureFetch,
             'no-insecure-messaging': noInsecureMessaging,
             'no-invalid-locales': noInvalidLocales,
@@ -88,6 +95,7 @@ export default {
             'no-missing-permissions': noMissingPermissions,
             'no-missing-web-accessible-resources': noMissingWebAccessibleResources,
             'no-remote-code': noRemoteCode,
+            'no-remote-objects': noRemoteObjects,
             'no-remote-urls': noRemoteURLs,
             'no-scrollbar-styling': noScrollbarStyling,
             'no-sensitive-permissions': noSensitivePermissions,
@@ -106,6 +114,6 @@ export default {
             'valid-version-field': validVersionField
         }
         for (const [ruleId, rule] of Object.entries(plugin.rules))
-            rule.meta.docs.url = `https://codeberg.org/adamlui/eslint-plugin-${namespace}/#${ruleId}`
+            rule.meta.docs.url = `https://codeberg.org/adamlui/${pkgName}/#${ruleId}`
     }
 }

package/src/utils/license.js

@@ -1,4 +1,4 @@
-/* eslint-disable security/detect-non-literal-fs-filename -- lint-time test fixtures only */
+// oxlint-disable security/detect-non-literal-fs-filename
 
 import { createRequire } from 'node:module'
 import fs from 'node:fs'

package/src/utils/node.js

@@ -19,5 +19,7 @@ export default {
             ancestor = ancestor.parent
         }
         return false
-    }
+    },
+
+    plainType(node, prefix) { return node?.type?.replace(prefix, '') ?? '' }
 }

package/src/utils/pkg.js

@@ -1,3 +1,4 @@
+import { fileURLToPath } from 'node:url'
 import fs from 'node:fs'
 import path from 'node:path'
 
@@ -11,11 +12,27 @@ export default {
                 current = parent
                 continue
             }
-            if ( // eslint-disable-next-line security/detect-non-literal-fs-filename
+            if ( // oxlint-disable-next-line security/detect-non-literal-fs-filename
                 fs.existsSync(path.join(current, 'package.json'))) return current
             const parent = path.dirname(current)
             if (parent === current) return null
             current = parent
         }
-    }
+    },
+
+    getName() { // oxlint-disable security/detect-non-literal-fs-filename
+        let current = path.dirname(fileURLToPath(import.meta.url))
+        while (current) {
+            const pkgPath = path.join(current, 'package.json')
+            if (fs.existsSync(pkgPath))
+                try {
+                    const { name } = JSON.parse(fs.readFileSync(pkgPath, 'utf8'))
+                    if (name) return name
+                } catch { /* malformed, keep walking */ }
+            const parent = path.dirname(current)
+            if (parent === current) return null
+            current = parent
+        }
+        return null
+    } // oxlint-enable security/detect-non-literal-fs-filename
 }

package/src/utils/rules.js

@@ -1,7 +1,7 @@
 export default {
     bundle(rules, predicate, pluginName) {
         return Object.fromEntries(Object.entries(rules)
-            .filter(([, rule]) => predicate(rule))
+            .filter(([, rule]) => !rule.meta.deprecated && predicate(rule))
             .map(([ruleId]) => [`${pluginName}/${ruleId}`, 'error']))
     }
 }