eslint-plugin-chrome-extensions 2.5.0 → 2.6.0

package/src/rules/valid-version-field.js

@@ -13,7 +13,7 @@ export default {
         docs: {
             description: 'Validate the manifest version field format',
             category: 'Possible Errors',
-            recommended: false,
+            recommended: true,
             manifest: true
         },
         schema: [{

package/src/utils/extension.js

@@ -3,6 +3,9 @@
 import fs from 'node:fs'
 import path from 'node:path'
 
+import permissions from '../data/permissions.js'
+import regex from '../data/regex.js'
+
 const manifestCache = new Map()
 
 const utils = {
@@ -36,6 +39,16 @@ const utils = {
     },
 
     manifest: {
+        permission: {
+            valid: permissions.valid,
+            sensitive: permissions.sensitive,
+            isValid(name, target = 'mv3') {
+                if (permissions.valid.has(name)) return true
+                if (target == 'mv3') return false
+                return regex.url.test(name) || name.startsWith('<') || name == '*://*/*'
+            }
+        },
+
         read(context) {
             const root = utils.findRoot(context) ; if (!root) return null
             if (manifestCache.has(root)) return manifestCache.get(root)

package/src/utils/i18n.js

@@ -43,6 +43,9 @@ export default {
 
     isPredefined(key) { return key.startsWith('@@') },
 
+    localeIsValid(code, allowed = new Set()) {
+        return typeof code == 'string' && (allowed.has(code) || i18n.locales.supported.has(code)) },
+
     readDefaultLocaleMessages(manifest, root) {
         const locale = manifest?.default_locale
         if (typeof locale != 'string') return null

package/src/utils/init.js

@@ -11,6 +11,7 @@ import noDeprecatedAPIs from '../rules/no-deprecated-apis.js'
 import noDuplicateManifestKeys from '../rules/no-duplicate-manifest-keys.js'
 import noInsecureFetch from '../rules/no-insecure-fetch.js'
 import noInsecureMessaging from '../rules/no-insecure-messaging.js'
+import noInvalidLocales from '../rules/no-invalid-locales.js'
 import noInvalidPermissions from '../rules/no-invalid-permissions.js'
 import noMissingDefaultLocale from '../rules/no-missing-default-locale.js'
 import noMissingI18nKeys from '../rules/no-missing-i18n-keys.js'
@@ -67,7 +68,7 @@ export default {
         }
     },
 
-    plugin() { return { rules: {}, configs: {}}},
+    plugin() { return { rules: {}, configs: {} }},
 
     rules(plugin) {
         plugin.rules = {
@@ -78,6 +79,7 @@ export default {
             'no-duplicate-manifest-keys': noDuplicateManifestKeys,
             'no-insecure-fetch': noInsecureFetch,
             'no-insecure-messaging': noInsecureMessaging,
+            'no-invalid-locales': noInvalidLocales,
             'no-invalid-permissions': noInvalidPermissions,
             'no-missing-default-locale': noMissingDefaultLocale,
             'no-missing-i18n-keys': noMissingI18nKeys,

package/src/utils/license.js

@@ -14,8 +14,7 @@ const re = { spdxTag: /SPDX-License-Identifier:\s*([\w.-]+)/i },
           .map(([id, { name }]) => ({ id, name }))
           .sort((a, b) => b.name.length - a.name.length)
 
-function tryReaddir(dir) {
-    try { return fs.readdirSync(dir, { withFileTypes: true }) } catch { return null }}
+function tryReaddir(dir) { try { return fs.readdirSync(dir, { withFileTypes: true }) } catch { return null }}
 
 export default {
     find(root) {
@@ -38,6 +37,7 @@ export default {
                 trailer = `${text.endsWith(nl) ? '' : nl}${nl}SPDX-License-Identifier: ${id}${nl}`
             return fixer.insertTextAfterRange([0, text.length], trailer)
         },
+
         find(text) {
             const normalizedTxt = text.replace(/\s+/g, ' ')
             let best = null
@@ -49,6 +49,7 @@ export default {
             }
             return best?.id ?? null
         },
+
         isValid(id) { return spdxIDs.has(id) },
         parse(text) { return text.match(re.spdxTag)?.[1] ?? null }
     }