eslint-plugin-chrome-extensions 2.12.2 → 2.12.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-chrome-extensions",
-  "version": "2.12.2",
+  "version": "2.12.3",
   "description": "ESLint rules for Chrome extensions",
   "keywords": [
     "eslint",
@@ -65,13 +65,13 @@
       "katex": "^0.19.1"
     },
     "eslint": {
-      "minimatch": "^11.0.5"
+      "minimatch": "^11.0.7"
     },
     "eslint-plugin-import-x": {
-      "minimatch": "^11.0.5"
+      "minimatch": "^11.0.7"
     },
     "eslint-plugin-sonarjs": {
-      "minimatch": "^11.0.5"
+      "minimatch": "^11.0.7"
     }
   },
   "dependencies": {
@@ -100,7 +100,7 @@
     "eslint-plugin-regexp": "^3.3.3",
     "eslint-plugin-security": "^4.2.1",
     "eslint-plugin-sonarjs": "^4.2.2",
-    "eslint-plugin-woodpecker": "^1.1.4",
+    "eslint-plugin-woodpecker": "^1.1.6",
     "oxlint": "^1.93.0",
     "typescript": "npm:@typescript/typescript6@^6.0.2",
     "typescript-latest": "npm:typescript@^7.0.2"

package/src/rules/no-content-style-leak.js

@@ -2,7 +2,7 @@ import extension from '../utils/extension.js'
 import nodeUtils from '../utils/node.js'
 
 const re = {
-    appendMethod: /^(?:append|appendChild|prepend|replaceChildren|insertBefore)$/,
+    appendMethod: /^(?:append|appendChild|insertBefore|prepend|replaceChildren)$/,
     invokeMethod: /^(?:apply|call)$/,
     styleName: /style/i
 }

package/src/rules/no-unused-permissions.js

@@ -80,10 +80,10 @@ export default {
         const root = extension.findRoot(context) ; if (!root) return {}
         const usedAPIs = collectUsedAPIs(manifest, root)
         function isUsed(permission) {
-            let knownPermission = false
-            for (const [, mappedPermission] of apis.permissionMap)
-                if (mappedPermission == permission) { knownPermission = true ; break }
-            if (!knownPermission) return true
+            let knownPerm = false
+            for (const [, mappedPerm] of apis.permissionMap)
+                if (mappedPerm == permission) { knownPerm = true ; break }
+            if (!knownPerm) return true
             for (const api of usedAPIs)
                 if (apiUtils.findPermission(api) == permission) return true
             return false
@@ -96,7 +96,7 @@ export default {
                     context.report({ loc, messageId: 'unusedPermission', data: { permission }})
             return {}
         }
-        const permissionNodes = new Map()
+        const permNodes = new Map()
         return {
             '*'(node) {
                 const keyNode = node.name || node.key ; if (!keyNode) return
@@ -108,12 +108,12 @@ export default {
                     const valueNode = elem.value || elem,
                           permission = valueNode?.value
                     if (typeof permission != 'string') continue
-                    if (!permissionNodes.has(permission)) permissionNodes.set(permission, [])
-                    permissionNodes.get(permission).push(valueNode)
+                    if (!permNodes.has(permission)) permNodes.set(permission, [])
+                    permNodes.get(permission).push(valueNode)
                 }
             },
             'Document:exit'() {
-                for (const [permission, nodes] of permissionNodes) {
+                for (const [permission, nodes] of permNodes) {
                     if (isUsed(permission)) continue
                     for (const node of nodes)
                         context.report({ node, messageId: 'unusedPermission', data: { permission }})

package/src/rules/valid-service-worker.js

@@ -5,6 +5,24 @@ import manifestData from '../data/manifest.js'
 
 const defaultOptions = { checkListenerTopLevel: true, checkKeepaliveTimer: true, checkDOMglobals: true }
 
+function isSelfRemovingListener(node) {
+    const listenerFn = node.arguments[0]
+    if (listenerFn?.type != 'FunctionExpression' || !listenerFn.id) return false
+    return (function check(node) {
+        if (!node || typeof node.type != 'string') return false
+        if (node.type == 'CallExpression'
+            && node.callee.type == 'MemberExpression'
+            && node.callee.property?.name == 'removeListener'
+            && node.arguments[0]?.type == 'Identifier'
+            && node.arguments[0].name == listenerFn.id.name
+        ) return true
+        return Object.keys(node).some(function(key) {
+            return key != 'parent' && ( // oxlint-disable-next-line security/detect-object-injection
+                Array.isArray(node[key]) ? node[key].some(check) : check(node[key]))
+        })
+    })(listenerFn.body)
+}
+
 export default {
     meta: {
         type: 'problem',
@@ -45,6 +63,7 @@ export default {
                     && node.callee.type == 'MemberExpression'
                     && node.callee.property.name == 'addListener'
                     && nodeUtils.isInsideNestedFunction(node)
+                    && !isSelfRemovingListener(node)
                 ) context.report({ node, messageId: 'listenerNotTopLevel' })
                 if (checkKeepaliveTimer
                     && node.callee.type == 'Identifier'